[Bug 128267] FILESAVE: Spurious definitions in SVG file (EmbeddedBulletChars)
https://bugs.documentfoundation.org/show_bug.cgi?id=128267 --- Comment #7 from Buovjaga --- git grep and git blame reveal that the change was made to filter/source/svg/svgexport.cxx in commit b76628acb1ae4fc06f8c1b70ec2e0cf39356deef -- You are receiving this mail because: You are the assignee for the bug.
core.git: include/static offapi/org static/source unotest/source
include/static/unoembindhelpers/PrimaryBindings.hxx |6 +
offapi/org/libreoffice/embindtest/XTest.idl |5 +
static/source/embindmaker/embindmaker.cxx | 79
static/source/unoembindhelpers/PrimaryBindings.cxx | 18
unotest/source/embindtest/embindtest.cxx| 15 +++
unotest/source/embindtest/embindtest.js | 38 +
6 files changed, 95 insertions(+), 66 deletions(-)
New commits:
commit 735ea444f2c15771736260fc78704f6b9132ceac
Author: Stephan Bergmann
AuthorDate: Mon Apr 29 14:20:05 2024 +0200
Commit: Stephan Bergmann
CommitDate: Tue Apr 30 07:53:11 2024 +0200
Embind: Fix out-param handling
...by using UnoInOutParam in all cases. Some types whose Embind mappings
don't
employ any smart pointers (like any and sequence) would have worked directly
with pointers, but others (like string and type) would have caused Embind
errors
at runtime. So consistently use UnoInOutParam in all cases (and generate
bindings for all the used cases in embindmaker).
Change-Id: If26551bf4e99d10748aec1597d6e99f994dfd86e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166854
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/include/static/unoembindhelpers/PrimaryBindings.hxx
b/include/static/unoembindhelpers/PrimaryBindings.hxx
index 6acf2803132a..2af843ef6a3d 100644
--- a/include/static/unoembindhelpers/PrimaryBindings.hxx
+++ b/include/static/unoembindhelpers/PrimaryBindings.hxx
@@ -122,6 +122,12 @@ template void registerSequence(char const*
name)
});
registerUnoType>();
}
+
+template void registerInOutParameter(char const* name)
+{
+emscripten::class_>(name).constructor().template
constructor().property(
+"val", ::get, ::set);
+}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/offapi/org/libreoffice/embindtest/XTest.idl
b/offapi/org/libreoffice/embindtest/XTest.idl
index 38ac60a47618..b84753ebb8c6 100644
--- a/offapi/org/libreoffice/embindtest/XTest.idl
+++ b/offapi/org/libreoffice/embindtest/XTest.idl
@@ -117,7 +117,10 @@ interface XTest {
void getOut(
[out] boolean value1, [out] byte value2, [out] short value3, [out]
unsigned short value4,
[out] long value5, [out] unsigned long value6, [out] hyper value7,
-[out] unsigned hyper value8, [out] float value9, [out] double value10,
[out] char value11);
+[out] unsigned hyper value8, [out] float value9, [out] double value10,
[out] char value11,
+[out] string value12, [out] type value13, [out] any value14,
+[out] sequence value15, [out] Enum value16, [out] Struct
value17,
+[out] XTest value18);
void throwRuntimeException();
void passJob([in] com::sun::star::task::XJob object);
void passJobExecutor([in] com::sun::star::task::XJobExecutor object);
diff --git a/static/source/embindmaker/embindmaker.cxx
b/static/source/embindmaker/embindmaker.cxx
index 6c0017ccb8c2..0b7634cf8409 100644
--- a/static/source/embindmaker/embindmaker.cxx
+++ b/static/source/embindmaker/embindmaker.cxx
@@ -558,49 +558,13 @@ void dumpParameters(std::ostream& out,
rtl::Reference const& manage
{
out << ", ";
}
-bool wrap = false;
-if (param.direction !=
unoidl::InterfaceTypeEntity::Method::Parameter::DIRECTION_IN)
-{
-switch (manager->getSort(resolveOuterTypedefs(manager,
param.type)))
-{
-case codemaker::UnoType::Sort::Boolean:
-case codemaker::UnoType::Sort::Byte:
-case codemaker::UnoType::Sort::Short:
-case codemaker::UnoType::Sort::UnsignedShort:
-case codemaker::UnoType::Sort::Long:
-case codemaker::UnoType::Sort::UnsignedLong:
-case codemaker::UnoType::Sort::Hyper:
-case codemaker::UnoType::Sort::UnsignedHyper:
-case codemaker::UnoType::Sort::Float:
-case codemaker::UnoType::Sort::Double:
-case codemaker::UnoType::Sort::Char:
-case codemaker::UnoType::Sort::Enum:
-wrap = true;
-break;
-case codemaker::UnoType::Sort::String:
-case codemaker::UnoType::Sort::Type:
-case codemaker::UnoType::Sort::Any:
-case codemaker::UnoType::Sort::Sequence:
-case codemaker::UnoType::Sort::PlainStruct:
-case codemaker::UnoType::Sort::InstantiatedPolymorphicStruct:
-case codemaker::UnoType::Sort::Interface:
-break;
-default:
-throw CannotDumpException("unexpected entity \"" +
param.type
- + "\" as parameter type");
-}
-}
if (declarations)
[Bug 103239] [META] Toolbars bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103239 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||149610 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149610 [Bug 149610] Whether and how to present iconography should adhere to what the host-OS or desktop-environment mandate (e.g. KDE Plasma Application Style settings) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149610] Whether and how to present iconography should adhere to what the host-OS or desktop-environment mandate (e.g. KDE Plasma Application Style settings)
https://bugs.documentfoundation.org/show_bug.cgi?id=149610 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||103239 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103239 [Bug 103239] [META] Toolbars bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 130857] Qt5 implement theming using native widgets (weld)
https://bugs.documentfoundation.org/show_bug.cgi?id=130857 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9610 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149610] Whether and how to present iconography should adhere to what the host-OS or desktop-environment mandate (e.g. KDE Plasma Application Style settings)
https://bugs.documentfoundation.org/show_bug.cgi?id=149610 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0857 --- Comment #13 from Stéphane Guillou (stragu) --- (In reply to Michael Weghorn from comment #12) > I think it makes sense to keep these reports separate. (There are 2 > potential ways to address this: implement handling in VCL widgets or welding > toolbar + implementing weld for qt6). Thanks, sounds good. Putting bug 130857 in See Also then. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132075] Crash OutlinerParaObject::OutlinerParaObject
https://bugs.documentfoundation.org/show_bug.cgi?id=132075 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8557 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101216] [META] Calc comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||148557 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148557 [Bug 148557] Crash mergedlo!SdrTextObj::GetOutlinerParaObject+0x10mergedlo!SdrTextObj::GetOutlinerParaObject+0x10: -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 148557, which changed state. Bug 148557 Summary: Crash mergedlo!SdrTextObj::GetOutlinerParaObject+0x10mergedlo!SdrTextObj::GetOutlinerParaObject+0x10: https://bugs.documentfoundation.org/show_bug.cgi?id=148557 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101216] [META] Calc comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Bug 101216 depends on bug 148557, which changed state. Bug 148557 Summary: Crash mergedlo!SdrTextObj::GetOutlinerParaObject+0x10mergedlo!SdrTextObj::GetOutlinerParaObject+0x10: https://bugs.documentfoundation.org/show_bug.cgi?id=148557 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108843] [META] Clipboard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108843 Bug 108843 depends on bug 148557, which changed state. Bug 148557 Summary: Crash mergedlo!SdrTextObj::GetOutlinerParaObject+0x10mergedlo!SdrTextObj::GetOutlinerParaObject+0x10: https://bugs.documentfoundation.org/show_bug.cgi?id=148557 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Bug 105948 depends on bug 148557, which changed state. Bug 148557 Summary: Crash mergedlo!SdrTextObj::GetOutlinerParaObject+0x10mergedlo!SdrTextObj::GetOutlinerParaObject+0x10: https://bugs.documentfoundation.org/show_bug.cgi?id=148557 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148557] Crash mergedlo!SdrTextObj::GetOutlinerParaObject+0x10mergedlo!SdrTextObj::GetOutlinerParaObject+0x10:
https://bugs.documentfoundation.org/show_bug.cgi?id=148557 Stéphane Guillou (stragu) changed: What|Removed |Added Status|NEW |RESOLVED Blocks||101216 Whiteboard||target:7.5.0 Crash report or||["OutlinerParaObject::Outli crash signature||nerParaObject(OutlinerParaO ||bject ||const&)","ScPostIt::CreateC ||aption(ScAddress const&, ||SdrCaptionObj const*)"] See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2075 Severity|normal |critical Resolution|--- |FIXED CC||noelgran...@gmail.com, ||stephane.guillou@libreoffic ||e.org --- Comment #8 from Stéphane Guillou (stragu) --- Reproduced in 7.3.0.3 with signature "OutlinerParaObject::OutlinerParaObject(OutlinerParaObject const&)": https://crashreport.libreoffice.org/stats/crash_details/d40704e2-2919-4879-8bd6-50269d94c35f In 7.4.0.3, I get "ScPostIt::CreateCaption(ScAddress const&, SdrCaptionObj const*)": https://crashreport.libreoffice.org/stats/crash_details/07db99bb-06a2-4b83-bc71-360fa1438758 ...so quite similar to bug 132075. Not reproduced in 7.5.9, 7.6.6 or current daily build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2f5ab5b8e7bd7dd06e00153abb77a69e5d192dd2 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Bibisected the fix with linux-64-7.5 repo to first good build [6f10bfc3f53a7d88037a32deadcc7f3be94c061e] which points to: commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 author Noel GrandinThu May 27 10:27:46 2021 +0200 committer Noel GrandinMon Aug 29 13:44:02 2022 +0200 ref-count SdrObject Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138837 Thank you Noel! Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101216 [Bug 101216] [META] Calc comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157373] Using the Paste Special dialog ends in "Requested clipboard format is not available" error; can't reopen dialog after
https://bugs.documentfoundation.org/show_bug.cgi?id=157373 --- Comment #23 from Michael Weghorn --- @Stéphane: I've now submitted 2 more related changes to master to address potential races Michael S. noticed in the review of the 24-2 backports of the previous ones. I don't really expect they should be causing the issue you still describe, but maybe it's still worth retesting. Commits: commit 893deef4f77f19d7b2d31df09260a34affe1 Author: Michael Weghorn Date: Fri Apr 26 14:39:14 2024 +0200 qt: Avoid race on QtTransferable member commit 621cfc0e4120ab2b381b54268fe39bd19257df9b Author: Michael Weghorn Date: Fri Apr 26 15:04:24 2024 +0200 qt: Guard clipboard mime data with SolarMutex -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160864] Screen stops refreshing after save, does not make a restore auto-save for files
https://bugs.documentfoundation.org/show_bug.cgi?id=160864 --- Comment #1 from Mike Butash --- I did end up starting in safe mode per recommendation, wiping the profile new, and was able to again reproduce this behavior even in safe mode. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157901] Crash when I try to copy any cell that contains a formula
https://bugs.documentfoundation.org/show_bug.cgi?id=157901 --- Comment #9 from Stéphane Guillou (stragu) --- Not reproduced in: Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 4; OS: macOS 10.15.7; UI render: Skia/Raster; VCL: osx Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - vcl/inc vcl/qt5
vcl/inc/qt5/QtTransferable.hxx | 11 --
vcl/qt5/QtClipboard.cxx|2 -
vcl/qt5/QtTransferable.cxx | 43 +++--
3 files changed, 35 insertions(+), 21 deletions(-)
New commits:
commit 621cfc0e4120ab2b381b54268fe39bd19257df9b
Author: Michael Weghorn
AuthorDate: Fri Apr 26 15:04:24 2024 +0200
Commit: Michael Weghorn
CommitDate: Tue Apr 30 06:53:19 2024 +0200
qt: Guard clipboard mime data with SolarMutex
Most of the access to the QtClipboardTransferable
mime data happens exclusively on the main thread,
with the solar mutex held.
However, `mimeData()`, called from `QtClipboard::getContents`
didn't ensure that yet, so as Michael Stahl pointed out in [1],
commit 1db5b87fe69c2375f1d66974dafcd563303c76db
Author: Michael Weghorn
Date: Tue Feb 13 13:23:17 2024 +0100
tdf#156562 qt: Sync with system clipboard content if necessary
introduced a data race by allowing to set new mime data.
Introduce a new
`QtClipboardTransferable::hasMimeData(const QMimeData* pMimeData)`
that guards access to the mime data with the solar mutext as well
and use that instead, so all access to the `QtClipboardTransferable`
mime data is now guarded by the solar mutex.
Also add an explicit note for the mime data getter/setter in the
`QtTransferable` base class that subclasses allowing to update
mime data are responsible for preventing data races.
[1] https://gerrit.libreoffice.org/c/core/+/166141/comment/fe75f418_40c1b622
Change-Id: I01dbbb0b37a4c6ad06b4d3001ecce8b0260eb32e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166750
Reviewed-by: Michael Weghorn
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/vcl/inc/qt5/QtTransferable.hxx b/vcl/inc/qt5/QtTransferable.hxx
index c58490e90460..5687fa06df52 100644
--- a/vcl/inc/qt5/QtTransferable.hxx
+++ b/vcl/inc/qt5/QtTransferable.hxx
@@ -40,12 +40,17 @@ protected:
* Since data flavors supported by this class depend on the mime data,
* results from previous calls to the public methods of this
* class are no longer valid after setting new mime data using this
method.
+ *
+ * Subclasses that set new mime data must ensure that no data race exists
+ * on m_pMimeData.
+ * (For the current only subclass doing so, QtClipboardTransferable, all
access
+ * to m_pMimeData happens with the SolarMutex held.)
*/
void setMimeData(const QMimeData* pMimeData) { m_pMimeData = pMimeData; }
+const QMimeData* mimeData() const { return m_pMimeData; }
public:
QtTransferable(const QMimeData* pMimeData);
-const QMimeData* mimeData() const { return m_pMimeData; }
css::uno::Sequence SAL_CALL
getTransferDataFlavors() override;
sal_Bool SAL_CALL isDataFlavorSupported(const
css::datatransfer::DataFlavor& rFlavor) override;
@@ -74,6 +79,9 @@ class QtClipboardTransferable final : public QtTransferable
public:
explicit QtClipboardTransferable(const QClipboard::Mode aMode, const
QMimeData* pMimeData);
+// whether pMimeData are the current mime data
+bool hasMimeData(const QMimeData* pMimeData) const;
+
// these are the same then QtTransferable, except they go through
RunInMainThread
css::uno::Sequence SAL_CALL
getTransferDataFlavors() override;
sal_Bool SAL_CALL isDataFlavorSupported(const
css::datatransfer::DataFlavor& rFlavor) override;
diff --git a/vcl/qt5/QtClipboard.cxx b/vcl/qt5/QtClipboard.cxx
index e9eb476fb253..ea05784bbfb2 100644
--- a/vcl/qt5/QtClipboard.cxx
+++ b/vcl/qt5/QtClipboard.cxx
@@ -103,7 +103,7 @@ css::uno::Reference
QtClipboard::getContents()
{
const auto* pTrans =
dynamic_cast(m_aContents.get());
assert(pTrans);
-if (pTrans && pTrans->mimeData() == pMimeData)
+if (pTrans && pTrans->hasMimeData(pMimeData))
return m_aContents;
}
diff --git a/vcl/qt5/QtTransferable.cxx b/vcl/qt5/QtTransferable.cxx
index a6902824ab3a..1aec5da27843 100644
--- a/vcl/qt5/QtTransferable.cxx
+++ b/vcl/qt5/QtTransferable.cxx
@@ -13,6 +13,7 @@
#include
#include
#include
+#include
#include
@@ -173,10 +174,17 @@ void
QtClipboardTransferable::ensureConsistencyWithSystemClipboard()
{
SAL_WARN("vcl.qt", "In flight clipboard change detected - updating
mime data with current "
"clipboard contents.");
+DBG_TESTSOLARMUTEX();
setMimeData(pCurrentClipboardData);
}
}
+bool QtClipboardTransferable::hasMimeData(const QMimeData* pMimeData) const
+{
+SolarMutexGuard aGuard;
+return QtTransferable::mimeData() == pMimeData;
+}
+
css::uno::Any SAL_CALL
QtClipboardTransferable::getTransferData(const css::datatransfer::DataFlavor&
rFlavor)
{
commit 893deef4f77f19d7b2d31df09260a34affe1
Author: Michael Weghorn
AuthorDate:
[Bug 158110] Copy/paste of Calc comments fails when more than one cell is copied
https://bugs.documentfoundation.org/show_bug.cgi?id=158110 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|Copy/paste of more than one |Copy/paste of Calc comments |comment in calc does not|fails when more than one |work|cell is copied -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158110] Copy/paste of more than one comment in calc does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=158110 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords||bibisected, bisected, ||regression Version|7.6.1.2 release |7.6.0.0 alpha1+ Blocks||108479 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0765, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||9858 OS|Linux (All) |All --- Comment #3 from Stéphane Guillou (stragu) --- >From my comment in duplicate: Steps: 1. Insert a comment in cell A1 2. Copy range A1:A2 3. Paste special into B1, with only option "Only comments" ticked Results: no comment pasted in target Reproduced in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d4f6534e8870e8f271984c37ce54a6878f372ae1 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Same on Windows 11. Bibisected with linux-64-7.6 repo to first bad commit d82812a13723fc093897c1b27d29ac263c66d0d0 which points to: commit 28bcb35b12f19858eca3d08559d7914e36ad1d2b Author: Andreas Heinisch Date: Wed May 10 09:08:47 2023 +0200 tdf#139858 - Do not delete existing cell contents when pasting notes Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151603 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108479 [Bug 108479] [META] Paste special bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108479] [META] Paste special bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108479 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||158110 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158110 [Bug 158110] Copy/paste of more than one comment in calc does not work -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108479] [META] Paste special bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108479 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|160859 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160859 [Bug 160859] Paste only comments fails when several cells copied -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101216] [META] Calc comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|160859 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160859 [Bug 160859] Paste only comments fails when several cells copied -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160859] Paste only comments fails when several cells copied
https://bugs.documentfoundation.org/show_bug.cgi?id=160859 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks|101216, 108479 | See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=16 | |0765, | |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=13 | |9858| Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101216 [Bug 101216] [META] Calc comment bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108479 [Bug 108479] [META] Paste special bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149610] Whether and how to present iconography should adhere to what the host-OS or desktop-environment mandate (e.g. KDE Plasma Application Style settings)
https://bugs.documentfoundation.org/show_bug.cgi?id=149610 --- Comment #12 from Michael Weghorn --- (In reply to Stéphane Guillou (stragu) from comment #11) > Thanks for clarifying, Michael. I'll let you decide if this needs to be > blocked by bug 130857, or be marked as a duplicate of it. I think it makes sense to keep these reports separate. (There are 2 potential ways to address this: implement handling in VCL widgets or welding toolbar + implementing weld for qt6). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160865] South African dictionary maintainer
https://bugs.documentfoundation.org/show_bug.cgi?id=160865 Marco A.G.Pinto changed: What|Removed |Added CC||marcoagpi...@sapo.pt Assignee|libreoffice-b...@lists.free |marcoagpi...@sapo.pt |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160865] New: South African dictionary maintainer
https://bugs.documentfoundation.org/show_bug.cgi?id=160865 Bug ID: 160865 Summary: South African dictionary maintainer Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marcoagpi...@sapo.pt Heya, Just to let you know: Since the South African dictionary isn't maintained any more, I am going to fork it. As you know, it is me who has been addressing issues in it and improving the affix flags. Let me just finish the PhD and I will take care of en_ZA. My first improvement, after I am a free man (PhD), will be to add all proper names from en_GB into en_ZA. Then, I will start adding plurals and possessives, like I have been doing for en_GB. Also, Kevin Atkinson plans to pass his US+CA+AU dictionaries to other people, so the next year is a promising year for English dictionaries' development. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160864] New: Screen stops refreshing after save, does not make a restore auto-save for files
https://bugs.documentfoundation.org/show_bug.cgi?id=160864 Bug ID: 160864 Summary: Screen stops refreshing after save, does not make a restore auto-save for files Product: LibreOffice Version: 24.2.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mich...@butash.net Description: After an update to my arch linux system going from 24.2.0-1 to 24.2.2-2, I am having problems using calc or writer that in both cases, saving the file seem to trigger the UI to stop refreshing the window. It seems to still works, but not reflect UI changes, such as if I click and drag, it acts like it's highlighting, I can right click and get a menu, but I see no changes to the actual window workspace. If I type something and save, it is reflected on reopening the file and works normally until I save the file, then freezes again. More concerning, if I open a new or existing file, make a change, save or save-as, it freezes the screen, and I use a small script to kill all the libreoffice pids to kill -9 everything, but then upon restart where I expect to see that file in the restore list as I have for some 2 decades, it doesn't add that to the restore list or act like it's ever seen the file. Normally I would expect open any file, save the file, forcibly kill/crash libreoffice, that it would assuredly open and restore that and all the other files I have open. It's been one failsafe constant in my life since moving to linux mid-2000's using openoffice and later libreoffice. This seems sort of like a weird compositor issue I have with KDE/kwin where windows stop refreshing after a week or two uptime, but this only seems to do it to the active libreoffice document, and not the other calc/writer docs also open. I'd expect/witnessed with compositor issues before it will affect all windows for an app (including libreoffice), so instead seems more a UI problem with libreoffice alone. Steps to Reproduce: For arch linux: 1.Open LibreOffice Base 2.Get Document Recovery window, Recover Selected prior open documents 3.Click on opened file, Ctrl-o to open new file (calc or writer) 4.Click on Untitled file, add some text content, ctrl-shift-s file to save-as a file where ever 5.Observe after saving clicking in the document, dragging, typing, the work space of the window does not reflect changes, but menu and clicking does change pointer to reflect it is doing something 6.Observe clicking other libreoffice windows, calc or writer, others respond normally for a time, others freeze the same way 7.Issue a kill -9 to all libreoffice pids to abort all instances 8.Click to open again Libreoffice Base 9.Observe the new file freshly saved is not part of Recovery, only the original files recovered 10.Re-open the prior saved file, observe changes were saved, visible or not prior to force kill 11.Repeat ad nauseam Actual Results: 1.Windows freeze updating UI after any kind of save or auto-save, unable to edit file 2.New windows added/edited, saved or not are no longer recovered after crash after upgrade Expected Results: 1.Quick save or save-as should not freeze the UI and allow normal continued work after manual or auto-save 2.Any forced or unexpected crash of unsaved "Untitled #" or saved named files are expected to be included in recovery after manual save or auto-save interval (10min) Reproducible: Always User Profile Reset: No Additional Info: Arch Linux on Lenovo Thinkpad T15g G2 Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+xcb) Locale: en-US (en_US.UTF-8); UI: en-US 24.2.2-2 Calc: threaded DE: KDE Plasma 6.0.4, xorg session (not wayland) -- You are receiving this mail because: You are the assignee for the bug.
core.git: desktop/source extensions/source i18npool/source include/comphelper scripting/source sd/qa slideshow/source stoc/source sw/source testtools/source
desktop/source/deployment/manager/dp_commandenvironments.cxx | 21 +--
desktop/source/deployment/registry/component/dp_component.cxx |4
extensions/source/abpilot/datasourcehandling.cxx | 14 --
extensions/source/abpilot/fieldmappingimpl.cxx| 24 +---
extensions/source/bibliography/bibconfig.cxx | 31 ++---
extensions/source/bibliography/bibload.cxx|2
extensions/source/bibliography/datman.cxx | 54 --
extensions/source/bibliography/framectr.cxx | 12 --
extensions/source/bibliography/toolbar.cxx| 16 --
extensions/source/dbpilots/controlwizard.cxx | 21 +--
extensions/source/dbpilots/gridwizard.cxx | 19 +--
i18npool/source/localedata/saxparser.cxx |2
include/comphelper/namedvaluecollection.hxx |8 -
scripting/source/basprov/baslibnode.cxx |3
scripting/source/basprov/basscript.cxx|3
sd/qa/unit/import-tests.cxx |2
slideshow/source/engine/opengl/TransitionerImpl.cxx | 43 +++
stoc/source/implementationregistration/implreg.cxx| 32 ++---
stoc/source/implementationregistration/mergekeys.cxx |5
stoc/source/security/permissions.cxx |3
stoc/source/servicemanager/servicemanager.cxx |7 -
sw/source/core/unocore/unostyle.cxx | 26 +---
testtools/source/bridgetest/bridgetest.cxx|4
23 files changed, 136 insertions(+), 220 deletions(-)
New commits:
commit ea9367037232054a576f1e6aabffeb3a62ffa44b
Author: Mike Kaganski
AuthorDate: Mon Apr 29 01:31:19 2024 +0500
Commit: Mike Kaganski
CommitDate: Tue Apr 30 06:20:50 2024 +0200
Drop some uses of css::uno::Sequence::getConstArray ...
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
(Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const
Sequence::operator[]
in internal code 2021-11-05).
Change-Id: I4ccc647bb794515c8c11f8dfd9a26563f4aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166819
Reviewed-by: Mike Kaganski
Tested-by: Jenkins
diff --git a/desktop/source/deployment/manager/dp_commandenvironments.cxx
b/desktop/source/deployment/manager/dp_commandenvironments.cxx
index 2b98ff971908..4a0a88f42432 100644
--- a/desktop/source/deployment/manager/dp_commandenvironments.cxx
+++ b/desktop/source/deployment/manager/dp_commandenvironments.cxx
@@ -82,21 +82,14 @@ void BaseCommandEnv::handle_(bool approve,
else
{
// select:
-uno::Sequence< Reference< task::XInteractionContinuation > > conts(
-xRequest->getContinuations() );
-Reference< task::XInteractionContinuation > const * pConts =
-conts.getConstArray();
-sal_Int32 len = conts.getLength();
-for ( sal_Int32 pos = 0; pos < len; ++pos )
+for (auto& xContinuation : xRequest->getContinuations())
{
-if (approve) {
-Reference< task::XInteractionApprove > xInteractionApprove(
-pConts[ pos ], uno::UNO_QUERY );
-if (xInteractionApprove.is()) {
-xInteractionApprove->select();
-// don't query again for ongoing continuations:
-approve = false;
-}
+Reference
xInteractionApprove(xContinuation, uno::UNO_QUERY);
+if (xInteractionApprove.is())
+{
+xInteractionApprove->select();
+// don't query again for ongoing continuations:
+break;
}
}
}
diff --git a/desktop/source/deployment/registry/component/dp_component.cxx
b/desktop/source/deployment/registry/component/dp_component.cxx
index 7a692ec8c6c5..7efa1ba854e6 100644
--- a/desktop/source/deployment/registry/component/dp_component.cxx
+++ b/desktop/source/deployment/registry/component/dp_component.cxx
@@ -1279,13 +1279,11 @@ BackendImpl::ComponentPackageImpl::isRegistered_(
Sequence implNames;
if (xImplKey.is() && xImplKey->isValid())
implNames = xImplKey->getKeyNames();
-OUString const * pImplNames = implNames.getConstArray();
sal_Int32 pos = implNames.getLength();
for ( ; pos--; )
{
checkAborted( abortChannel );
-const OUString key(
-pImplNames[ pos ] + "/UNO/LOCATION" );
+const OUString key(implNames[pos] + "/UNO/LOCATION");
const Reference xKey(
xRootKey->openKey(key) );
if
[Bug 160852] delete all comments in Impress (.uno:DeleteAllAnnotation) only deletes uneven-numbered comments
https://bugs.documentfoundation.org/show_bug.cgi?id=160852 --- Comment #2 from Stéphane Guillou (stragu) --- (In reply to m_a_riosv from comment #1) > Works for me with > Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: ea43cbbb7371a743f470d949762a0e92f196e652 That was before Quikee's commits quoted in comment 0. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||132075 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=132075 [Bug 132075] Crash OutlinerParaObject::OutlinerParaObject -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101216] [META] Calc comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||132075 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=132075 [Bug 132075] Crash OutlinerParaObject::OutlinerParaObject -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 132075, which changed state. Bug 132075 Summary: Crash OutlinerParaObject::OutlinerParaObject https://bugs.documentfoundation.org/show_bug.cgi?id=132075 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 132075, which changed state. Bug 132075 Summary: Crash OutlinerParaObject::OutlinerParaObject https://bugs.documentfoundation.org/show_bug.cgi?id=132075 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101216] [META] Calc comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Bug 101216 depends on bug 132075, which changed state. Bug 132075 Summary: Crash OutlinerParaObject::OutlinerParaObject https://bugs.documentfoundation.org/show_bug.cgi?id=132075 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132075] Crash OutlinerParaObject::OutlinerParaObject
https://bugs.documentfoundation.org/show_bug.cgi?id=132075 Stéphane Guillou (stragu) changed: What|Removed |Added CC||nem...@numbertext.org, ||stephane.guillou@libreoffic ||e.org Crash report or|["ScPostIt::ScPostIt(ScDocu |["ScPostIt::ScPostIt(ScDocu crash signature|ment &,ScAddress const |ment &,ScAddress const |&,ScPostIt const &,unsigned |&,ScPostIt const &,unsigned |long)"] |long)","ScPostIt::CreateCap ||tion","ScPostIt::CreateCapt ||ion(ScAddress const&, ||SdrCaptionObj const*)"] Whiteboard||target:7.4.0 Blocks||101216, 102593 Resolution|--- |FIXED Status|NEW |RESOLVED Severity|normal |major --- Comment #9 from Stéphane Guillou (stragu) --- I had to use these steps (note extra step 2b, without which it would not crash): 1. Open Calc 2. Insert a comment with text 2b. Click elsewhere in the sheet to deselect the cell with comment 3. Copy the cell with comment (CTRL + C) 4. CTRL+Z 5. CTRL+V 6. CTRL+V (Accept to overwrite) -> Crash Repro in 6.3.0.4 and 7.0.0.3 with signature "ScPostIt::CreateCaption": - https://crashreport.libreoffice.org/stats/crash_details/c8676532-12b1-4435-b085-1d0e73aa175a - https://crashreport.libreoffice.org/stats/crash_details/496de9b8-bc7a-432c-9aab-4a742a0e6433 In 7.3.0.3 as well with "ScPostIt::CreateCaption(ScAddress const&, SdrCaptionObj const*)": https://crashreport.libreoffice.org/stats/crash_details/20b0f1cb-71dd-4c32-81a3-125b53605ab7 Resolved in 7.5.9, 7.6.6 and a recent daily build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2f5ab5b8e7bd7dd06e00153abb77a69e5d192dd2 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded In the linux-64-7.4 bibiset repo, I've bibisected the first build that doesn't crash to [37c0c21c8d03e151c19874bb2555b6a8e8a641de] which is László's 8c018910ae4d8701b1ce2a95727b9baed4016da3. I can't make sense of how it could be related, but I've tested a few times before and after the commit and it is consistent... There might be a remaining series of steps that can lead to the same signature, as can be seen here for 7.4.0.3: https://crashreport.libreoffice.org/stats/crash_details/079e2698-db26-465e-a46d-0cee6c11ec47 ...but I can't determine what it is, and we can close this report for the steps above. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101216 [Bug 101216] [META] Calc comment bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160618] LibreOffice (Draw) can't rotate orientation (landscape document into portrait) for printing
https://bugs.documentfoundation.org/show_bug.cgi?id=160618 --- Comment #15 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157454] Crash if I open Find... dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=157454 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160646] GIF don't animate in edit mode; are rendered as still images
https://bugs.documentfoundation.org/show_bug.cgi?id=160646 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160676] Prints only one page of multiple copies
https://bugs.documentfoundation.org/show_bug.cgi?id=160676 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157929] Lost PUA chars with xlsx/ods formats
https://bugs.documentfoundation.org/show_bug.cgi?id=157929 --- Comment #5 from QA Administrators --- Dear yukiguo, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154412] Software crashes repeatedly
https://bugs.documentfoundation.org/show_bug.cgi?id=154412 --- Comment #5 from QA Administrators --- Dear leticia, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157454] Crash if I open Find... dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=157454 --- Comment #7 from QA Administrators --- Dear Panos, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154412] Software crashes repeatedly
https://bugs.documentfoundation.org/show_bug.cgi?id=154412 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 131953] UI 'locked' after undo textbox insertion
https://bugs.documentfoundation.org/show_bug.cgi?id=131953 --- Comment #4 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141861] Graphic placement is incorrect on last page with 2 columns and Evenly distribute contents to all columns
https://bugs.documentfoundation.org/show_bug.cgi?id=141861 --- Comment #7 from QA Administrators --- Dear fred.r.green, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 129324] EDITING Draw converts text to curves in a SVG file with viewBox in SVG code
https://bugs.documentfoundation.org/show_bug.cgi?id=129324 --- Comment #7 from QA Administrators --- Dear joachim_liedtke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 128267] FILESAVE: Spurious definitions in SVG file (EmbeddedBulletChars)
https://bugs.documentfoundation.org/show_bug.cgi?id=128267 --- Comment #6 from QA Administrators --- Dear Gerry Garvey, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101783] Percent-value for font size in character style works wrongly.
https://bugs.documentfoundation.org/show_bug.cgi?id=101783 --- Comment #7 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
core.git: include/svx
include/svx/svdetc.hxx |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
New commits:
commit e82c9633e4f9bc4590bd6cd8d2a82a974ddaf00f
Author: Tomaž Vajngerl
AuthorDate: Sun Apr 28 09:31:46 2024 +0900
Commit: Tomaž Vajngerl
CommitDate: Tue Apr 30 04:55:09 2024 +0200
svx: use o3tl::convert instead of 847 (mm100) when we want 24pt
Change-Id: I1d1c4a0e12c0443e7021c8aedcd386814a1647be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166823
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/svx/svdetc.hxx b/include/svx/svdetc.hxx
index f0c28ae2f8fc..5f80ead04e4a 100644
--- a/include/svx/svdetc.hxx
+++ b/include/svx/svdetc.hxx
@@ -27,6 +27,7 @@
#include
#include
#include
+#include
/**
@@ -67,11 +68,8 @@ namespace SdrEngineDefaults
// Default FontColor is COL_AUTO
inline Color GetFontColor() { return COL_AUTO; }
-// Default FontHeight is 847. The font height uses logical units
(MapUnit/MapFraction
-// see below for further details). The default setting 847/100mm
corresponds to about
-// 24 Point. If e.g. one would use Twips (SetMapUnit(MapUnit::MapTwip))
(20 Twip = 1 Point)
-// instead, one would need to set the font height to 480, in order to get
a 24 Point height.
-inline size_t GetFontHeight() { return 847; }
+// Default font height
+inline size_t GetFontHeight() { return o3tl::convert(24, o3tl::Length::pt,
o3tl::Length::mm100); }
// The MapMode is needed for the global Outliner.
// Incidentally, every newly instantiated SdrModel is assigned this
MapMode by default.
[Bug 99619] query design segfault on redoing an undone table join creation
https://bugs.documentfoundation.org/show_bug.cgi?id=99619 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Blocks||108443 --- Comment #15 from Stéphane Guillou (stragu) --- Still reproduced following comment 10 steps with: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2f5ab5b8e7bd7dd06e00153abb77a69e5d192dd2 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Crash report for 24.2: https://crashreport.libreoffice.org/stats/crash_details/0b9d870f-96da-417b-b504-eec845a0ae17 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108443 [Bug 108443] [META] Database query bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108443] [META] Database query bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108443 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||99619 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99619 [Bug 99619] query design segfault on redoing an undone table join creation -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160753] XMATCH function in search for empty cell is different to Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=160753 ady changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8425 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143387] CRASH: undoing paste ( debug build )
https://bugs.documentfoundation.org/show_bug.cgi?id=143387 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #10 from Stéphane Guillou (stragu) --- No repro in this debug build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0957ee9f5d379c80fca4027c187b471118d0490d CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Xisco/Julien/Aron, can you double-check? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 115707] Crash in: cppu::_copyConstructAny(_uno_Any *,void *,_typelib_TypeDescriptionReference *,_typelib_TypeDescription *,void (*)(void *),_uno_Mapping *)
https://bugs.documentfoundation.org/show_bug.cgi?id=115707 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.
[Bug 115707] Crash in: cppu::_copyConstructAny(_uno_Any *,void *,_typelib_TypeDescriptionReference *,_typelib_TypeDescription *,void (*)(void *),_uno_Mapping *)
https://bugs.documentfoundation.org/show_bug.cgi?id=115707 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #15 from Stéphane Guillou (stragu) --- Created attachment 193901 --> https://bugs.documentfoundation.org/attachment.cgi?id=193901=edit WinDbg backtrace for 24.8 alpha0+ Still reproduced in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: f61ffdfa1a56b1b1fa1aa4f269477e1d1d475955 CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 131981] LO writer continuously looses spellcheck in new versions.
https://bugs.documentfoundation.org/show_bug.cgi?id=131981 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #16 from Stéphane Guillou (stragu) --- Jacques, have you experienced this issue in recent upgrades or has the situation improved? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160851] Hiding rows or columns in Calc causes severe lag
https://bugs.documentfoundation.org/show_bug.cgi?id=160851 --- Comment #5 from ady --- I have mentioned this behavior in other reports. STR: 1. Open attachment 193900. 2. [CTRL]+[HOME]. 3. During 10 seconds, press and hold the [PageDown] key. 4. At the 10 seconds stopper/timer, release the [PageDown] key and take note of the row number of the active cell. 5. Select All cells – click the area at the intersection between Column headers and Row headers. 6. Menu Format > Columns > Show. Now we repeat the procedure: 7. [CTRL]+[HOME]. 8. During 10 seconds, press and hold the [PageDown] key. 9. At the 10 seconds stopper/timer, release the [PageDown] key and take note of the row number of the active cell. Now compare the row numbers, between step 4 and step 9. For me, the current ratio is around 1:8 approximately. So, without having hidden columns at the "end" of the worksheet (inactive area), Calc scrolls 7/8 times faster than when I have the inactive area hidden. A similar test can be performed when having the "inactive" rows as hidden instead of hidden columns. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ea43cbbb7371a743f470d949762a0e92f196e652 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (es_AR); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150900] [META] Excel Functions
https://bugs.documentfoundation.org/show_bug.cgi?id=150900 Aron Budea changed: What|Removed |Added Depends on||160725 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160725 [Bug 160725] XLOOKUP has different result for approximate search than Excel -- You are receiving this mail because: You are the assignee for the bug.
[Bug 92617] Base is crashing frequently when EDITING data and switching Forms
https://bugs.documentfoundation.org/show_bug.cgi?id=92617 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #42 from Stéphane Guillou (stragu) --- Using comment 5 steps, getting the BASIC runtime error as described in comment 32. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2f5ab5b8e7bd7dd06e00153abb77a69e5d192dd2 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded @Lionel, are you able to provide modified steps that still produce a crash? Would be good also to clarify to summary. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160851] Hiding rows or columns in Calc causes severe lag
https://bugs.documentfoundation.org/show_bug.cgi?id=160851 m_a_riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from m_a_riosv --- Seems a bit slower than without them Version: 7.6.6.3 (X86_64) / LibreOffice Community Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL threaded almost imperceptible with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ea43cbbb7371a743f470d949762a0e92f196e652 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded and Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: vcl/inc vcl/osx vcl/quartz vcl/source
vcl/inc/quartz/salgdi.h |4
vcl/osx/salframe.cxx |2 +-
vcl/quartz/salgdi.cxx| 13 +
vcl/source/app/IconThemeSelector.cxx |4 ++--
vcl/source/image/ImplImage.cxx |9 -
5 files changed, 28 insertions(+), 4 deletions(-)
New commits:
commit f4ef5435df5560e6b6b061ce4053c71e2819bf51
Author: Patrick Luby
AuthorDate: Mon Apr 29 09:35:30 2024 -0400
Commit: Patrick Luby
CommitDate: Tue Apr 30 01:24:29 2024 +0200
tdf#130678 draw SVG icons at Retina resolution on macOS
Also, change the default icon theme on macOS to SVG now that SVG icons
support Retina display resolution and the existing PNG icon themes do not.
Change-Id: I8c86c316b0db005661759c132ecf7e8667cf30bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166867
Reviewed-by: Patrick Luby
Tested-by: Jenkins
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index c8befcc50280..b7fb674f7553 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -473,6 +473,10 @@ public:
GetTextLayout(int nFallbackLevel) override;
virtual voidDrawTextLayout( const GenericSalLayout& ) override;
+#ifdef MACOSX
+virtual boolShouldDownscaleIconsAtSurface(double* pScaleOut)
const override;
+#endif
+
virtual SystemGraphicsData
GetGraphicsData() const override;
};
diff --git a/vcl/osx/salframe.cxx b/vcl/osx/salframe.cxx
index b02dbc59585e..940337b770a1 100644
--- a/vcl/osx/salframe.cxx
+++ b/vcl/osx/salframe.cxx
@@ -1390,7 +1390,7 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
StyleSettings aStyleSettings = rSettings.GetStyleSettings();
bool bUseDarkMode(GetUseDarkMode());
-OUString sThemeName(!bUseDarkMode ? u"sukapura" : u"sukapura_dark");
+OUString sThemeName(!bUseDarkMode ? u"sukapura_svg" :
u"sukapura_dark_svg");
aStyleSettings.SetPreferredIconTheme(sThemeName, bUseDarkMode);
Color aControlBackgroundColor(getNSBoxBackgroundColor([NSColor
controlBackgroundColor]));
diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx
index fd81f1a04512..8c9d3a6486dd 100644
--- a/vcl/quartz/salgdi.cxx
+++ b/vcl/quartz/salgdi.cxx
@@ -299,6 +299,19 @@ void AquaSalGraphics::DrawTextLayout(const
GenericSalLayout& rLayout)
mpBackend->drawTextLayout(rLayout);
}
+#ifdef MACOSX
+
+bool AquaSalGraphics::ShouldDownscaleIconsAtSurface(double* pScaleOut) const
+{
+if (comphelper::LibreOfficeKit::isActive())
+return SalGraphics::ShouldDownscaleIconsAtSurface(pScaleOut);
+if (pScaleOut)
+*pScaleOut = sal::aqua::getWindowScaling();
+return true;
+}
+
+#endif
+
void AquaGraphicsBackend::drawTextLayout(const GenericSalLayout& rLayout)
{
#ifdef IOS
diff --git a/vcl/source/app/IconThemeSelector.cxx
b/vcl/source/app/IconThemeSelector.cxx
index eb79752beb47..ae3af74b3da2 100644
--- a/vcl/source/app/IconThemeSelector.cxx
+++ b/vcl/source/app/IconThemeSelector.cxx
@@ -79,9 +79,9 @@ IconThemeSelector::GetIconThemeForDesktopEnvironment(const
OUString& desktopEnvi
}
else if ( desktopEnvironment.equalsIgnoreAsciiCase("macosx") ) {
if (!bPreferDarkIconTheme)
-r = "sukapura";
+r = "sukapura_svg";
else
-r = "sukapura_dark";
+r = "sukapura_dark_svg";
}
else if ( desktopEnvironment.equalsIgnoreAsciiCase("gnome") ||
desktopEnvironment.equalsIgnoreAsciiCase("mate") ||
diff --git a/vcl/source/image/ImplImage.cxx b/vcl/source/image/ImplImage.cxx
index cf70052a9fd7..f4b1cbba21a4 100644
--- a/vcl/source/image/ImplImage.cxx
+++ b/vcl/source/image/ImplImage.cxx
@@ -61,13 +61,20 @@ bool ImplImage::loadStockAtScale(SalGraphics* pGraphics,
BitmapEx )
sal_Int32 nScalePercentage = -1;
double fScale(1.0);
+OUString aIconTheme =
Application::GetSettings().GetStyleSettings().DetermineIconTheme();
+#ifdef MACOSX
+if (aIconTheme.endsWith("_svg"))
+{
+#endif
if (pGraphics && pGraphics->ShouldDownscaleIconsAtSurface()) //
scale at the surface
{
nScalePercentage = fScale * 100.0;
eScalingFlags = ImageLoadFlags::IgnoreScalingFactor;
}
+#ifdef MACOSX
+}
+#endif
-OUString aIconTheme =
Application::GetSettings().GetStyleSettings().DetermineIconTheme();
if (!ImageTree::get().loadImage(maStockName, aIconTheme, aBitmapEx, true,
nScalePercentage, eScalingFlags))
{
[Bug 148616] FILEOPEN PPTX A certain POTX template is slow to open
https://bugs.documentfoundation.org/show_bug.cgi?id=148616 Aron Budea changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |aron.bu...@gmail.com |desktop.org | Hardware|x86-64 (AMD64) |All CC||aron.bu...@gmail.com OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108479] [META] Paste special bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108479 Bug 108479 depends on bug 160859, which changed state. Bug 160859 Summary: Paste only comments fails when several cells copied https://bugs.documentfoundation.org/show_bug.cgi?id=160859 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101216] [META] Calc comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Bug 101216 depends on bug 160859, which changed state. Bug 160859 Summary: Paste only comments fails when several cells copied https://bugs.documentfoundation.org/show_bug.cgi?id=160859 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160859] Paste only comments fails when several cells copied
https://bugs.documentfoundation.org/show_bug.cgi?id=160859 m_a_riosv changed: What|Removed |Added Status|NEW |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |DUPLICATE --- Comment #2 from m_a_riosv --- *** This bug has been marked as a duplicate of bug 158110 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158110] Copy/paste of more than one comment in calc does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=158110 m_a_riosv changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #2 from m_a_riosv --- *** Bug 160859 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160851] Hiding rows or columns in Calc causes severe lag
https://bugs.documentfoundation.org/show_bug.cgi?id=160851 --- Comment #3 from lunarsoulsch...@gmail.com --- (In reply to m_a_riosv from comment #1) > Please test in safe mode, Menu/Help/Restart in Safe Mode > > Please attach a sample file. Testing in Safe Mode produced the same results. I have attempted to create and attach a suitable sample file. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160851] Hiding rows or columns in Calc causes severe lag
https://bugs.documentfoundation.org/show_bug.cgi?id=160851 --- Comment #2 from lunarsoulsch...@gmail.com --- Created attachment 193900 --> https://bugs.documentfoundation.org/attachment.cgi?id=193900=edit A Calc spreadsheet with columns AA-onward hidden -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157901] Crash when I try to copy any cell that contains a formula
https://bugs.documentfoundation.org/show_bug.cgi?id=157901 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #8 from raal --- No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5740d3fa83e9725a2771e5f00ba4aaf9965f0be2 CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - cppuhelper/source cpputools/source cui/source dbaccess/source
cppuhelper/source/implbase_ex.cxx |9 cppuhelper/source/implementationentry.cxx |6 cppuhelper/source/propertysetmixin.cxx |7 cppuhelper/source/propshlp.cxx | 31 +-- cppuhelper/source/tdmgr.cxx| 30 +-- cpputools/source/unoexe/unoexe.cxx |3 cui/source/customize/cfgutil.cxx |6 cui/source/dialogs/AdditionsDialog.cxx |8 cui/source/dialogs/SpellDialog.cxx | 32 +-- cui/source/dialogs/cuifmsearch.cxx |6 cui/source/dialogs/hangulhanjadlg.cxx | 23 -- cui/source/dialogs/hlmarkwn.cxx| 11 - cui/source/dialogs/hyphen.cxx | 40 +--- cui/source/dialogs/thesdlg.cxx | 19 - cui/source/options/connpoolconfig.cxx |7 cui/source/options/dbregisterednamesconfig.cxx | 20 -- cui/source/options/optdict.cxx | 50 + cui/source/options/optgdlg.cxx | 25 -- cui/source/options/optlingu.cxx| 104 ++ cui/source/options/optpath.cxx | 14 - cui/source/options/optsave.cxx | 19 - cui/source/tabpages/numpages.cxx | 34 +-- dbaccess/source/core/api/FilteredContainer.cxx | 33 +-- dbaccess/source/core/api/KeySet.cxx| 39 +-- dbaccess/source/core/api/OptimisticSet.cxx |7 dbaccess/source/core/api/RowSet.cxx| 28 +- dbaccess/source/core/api/RowSetCache.cxx |9 dbaccess/source/core/api/SingleSelectQueryComposer.cxx | 45 +--- dbaccess/source/core/api/View.cxx | 10 - dbaccess/source/core/api/column.cxx| 29 +- dbaccess/source/core/api/querycontainer.cxx|9 dbaccess/source/core/api/table.cxx |8 dbaccess/source/core/api/tablecontainer.cxx| 19 - dbaccess/source/core/dataaccess/ContentHelper.cxx | 51 + dbaccess/source/core/dataaccess/ModelImpl.cxx | 128 ++--- dbaccess/source/core/dataaccess/datasource.cxx | 95 +++-- dbaccess/source/core/dataaccess/documentcontainer.cxx | 26 -- dbaccess/source/core/dataaccess/documentdefinition.cxx | 16 - dbaccess/source/core/dataaccess/intercept.cxx | 14 - dbaccess/source/core/dataaccess/myucp_datasupplier.cxx | 25 -- dbaccess/source/core/inc/ModelImpl.hxx | 29 +- dbaccess/source/core/misc/DatabaseDataProvider.cxx | 24 +- dbaccess/source/core/misc/dsntypes.cxx | 20 -- dbaccess/source/filter/xml/xmlExport.cxx | 79 +++- dbaccess/source/filter/xml/xmlfilter.cxx | 28 +- dbaccess/source/ui/app/AppController.cxx | 51 ++--- dbaccess/source/ui/app/AppControllerDnD.cxx|7 dbaccess/source/ui/app/AppDetailPageHelper.cxx | 17 - dbaccess/source/ui/app/AppDetailView.cxx | 20 -- dbaccess/source/ui/browser/brwctrlr.cxx|7 dbaccess/source/ui/browser/dbloader.cxx|8 dbaccess/source/ui/browser/genericcontroller.cxx | 42 +--- dbaccess/source/ui/browser/sbagrid.cxx |4 dbaccess/source/ui/control/RelationControl.cxx |7 dbaccess/source/ui/dlg/ConnectionHelper.cxx|7 dbaccess/source/ui/dlg/UserAdmin.cxx |7 dbaccess/source/ui/dlg/UserAdmin.hxx |1 dbaccess/source/ui/dlg/adtabdlg.cxx| 16 - dbaccess/source/ui/dlg/dbwizsetup.cxx | 13 - dbaccess/source/ui/dlg/indexfieldscontrol.cxx |6 dbaccess/source/ui/dlg/queryfilter.cxx | 49 +--- dbaccess/source/ui/dlg/queryorder.cxx |9 dbaccess/source/ui/inc/indexes.hxx |4 dbaccess/source/ui/misc/DExport.cxx|6 dbaccess/source/ui/misc/RowSetDrop.cxx | 17 - dbaccess/source/ui/misc/TokenWriter.cxx| 30 +-- dbaccess/source/ui/misc/WCopyTable.cxx | 39 +-- dbaccess/source/ui/misc/dsmeta.cxx |9 dbaccess/source/ui/misc/indexcollection.cxx| 34 +-- dbaccess/source/ui/querydesign/JoinController.cxx |9 dbaccess/source/ui/querydesign/QueryDesignView.cxx |9
core.git: 2 commits - accessibility/source basctl/source basegfx/source canvas/source cli_ure/source connectivity/source
accessibility/source/extended/AccessibleBrowseBoxHeaderBar.cxx |2
basctl/source/basicide/IDEComboBox.cxx | 16
basctl/source/basicide/basides1.cxx|3
basctl/source/basicide/basidesh.cxx| 22
basctl/source/basicide/basobj3.cxx |8
basctl/source/basicide/bastype2.cxx| 51 -
basctl/source/basicide/localizationmgr.cxx | 121 ---
basctl/source/basicide/moduldl2.cxx| 26
basctl/source/dlged/dlged.cxx | 59 -
basctl/source/dlged/dlgedobj.cxx | 36 -
basctl/source/dlged/managelang.cxx | 18
basegfx/source/polygon/b2dpolygontools.cxx | 41 -
basegfx/source/polygon/b2dpolypolygontools.cxx | 21
basegfx/source/polygon/b3dpolypolygontools.cxx | 25
canvas/source/factory/cf_service.cxx | 16
canvas/source/tools/canvastools.cxx| 329
+++---
cli_ure/source/climaker/climaker_emit.cxx | 74 --
connectivity/source/commontools/DriversConfig.cxx | 27
connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx | 26
connectivity/source/commontools/FValue.cxx |7
connectivity/source/commontools/TDatabaseMetaDataBase.cxx |6
connectivity/source/commontools/dbtools.cxx|9
connectivity/source/commontools/dbtools2.cxx | 17
connectivity/source/commontools/parameters.cxx |7
connectivity/source/cpool/ZPoolCollection.cxx |9
connectivity/source/drivers/ado/AConnection.cxx| 16
connectivity/source/drivers/ado/AResultSet.cxx |6
connectivity/source/drivers/ado/Aolevariant.cxx|6
connectivity/source/drivers/ado/Awrapado.cxx |6
connectivity/source/drivers/calc/CConnection.cxx | 11
connectivity/source/drivers/calc/CDatabaseMetaData.cxx | 18
connectivity/source/drivers/calc/CTable.cxx|9
connectivity/source/drivers/dbase/DDatabaseMetaData.cxx| 47 -
connectivity/source/drivers/dbase/DTable.cxx | 10
connectivity/source/parse/sqliterator.cxx | 14
35 files changed, 385 insertions(+), 734 deletions(-)
New commits:
commit 8755c80018bec656e1b102da25edc450da4eee52
Author: Mike Kaganski
AuthorDate: Mon Apr 29 01:31:19 2024 +0500
Commit: Mike Kaganski
CommitDate: Mon Apr 29 23:15:33 2024 +0200
Drop uses of css::uno::Sequence::getConstArray in canvas .. connectivity
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
(Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const
Sequence::operator[]
in internal code 2021-11-05).
Change-Id: I9467028fd1a7eeafad7f0dd776a91a9a40770b48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166816
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/canvas/source/factory/cf_service.cxx
b/canvas/source/factory/cf_service.cxx
index 94f7069e267a..10d05379e8e9 100644
--- a/canvas/source/factory/cf_service.cxx
+++ b/canvas/source/factory/cf_service.cxx
@@ -142,13 +142,10 @@ CanvasFactory::CanvasFactory(
Reference const & xContext ) :
Reference
xHierarchicalNameAccess(
xNameAccess, UNO_QUERY_THROW);
-Sequence serviceNames = xNameAccess->getElementNames();
-const OUString* pCurr = serviceNames.getConstArray();
-const OUString* const pEnd = pCurr + serviceNames.getLength();
-while( pCurr != pEnd )
+for (auto& serviceName : xNameAccess->getElementNames())
{
Reference xEntryNameAccess(
-xHierarchicalNameAccess->getByHierarchicalName(*pCurr),
+
xHierarchicalNameAccess->getByHierarchicalName(serviceName),
UNO_QUERY );
if( xEntryNameAccess.is() )
@@ -156,20 +153,17 @@ CanvasFactory::CanvasFactory(
Reference const & xContext ) :
Sequence implementationList;
if(
xEntryNameAccess->getByName("PreferredImplementations") >>= implementationList )
{
-
m_aAvailableImplementations.emplace_back(*pCurr,implementationList );
+m_aAvailableImplementations.emplace_back(serviceName,
implementationList);
}
if(
xEntryNameAccess->getByName("AcceleratedImplementations") >>=
implementationList )
{
-
core.git: Branch 'distro/cib/libreoffice-6-4' - configure.ac helpcontent2
configure.ac |2 +- helpcontent2 |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 546fb6ff2068506fe4b88f545c0f740d11692321 Author: Thorsten Behrens AuthorDate: Mon Apr 29 22:38:25 2024 +0200 Commit: Thorsten Behrens CommitDate: Mon Apr 29 22:38:25 2024 +0200 Bump version to 6.4.0.25 Change-Id: I7d285a065189eeab6f7fe24f892b5d8b077f519f diff --git a/configure.ac b/configure.ac index 4b7de8d43669..80e396a5c67c 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([CIB Office],[6.4.0.24],[],[],[https://www.cib.de/office/]) +AC_INIT([CIB Office],[6.4.0.25],[],[],[https://www.cib.de/office/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard diff --git a/helpcontent2 b/helpcontent2 index 92adb81e1e5e..5995b61e8d08 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 92adb81e1e5ed153aac049648aec0a0a87a8768f +Subproject commit 5995b61e8d08489f44e0473f8d0d21e189a0b3db
[Bug 160863] New: AVI files freeze Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=160863 Bug ID: 160863 Summary: AVI files freeze Impress Product: LibreOffice Version: 24.2.1.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sarentasci...@hotmail.com Created attachment 193899 --> https://bugs.documentfoundation.org/attachment.cgi?id=193899=edit Sample of a video file causing this issue My old presentation started to freeze after some time. I do not remember, when it worked last. The bug may emerged sometime at version 7.x or 24.2. (but more likely 7.x, as I remember having issues before upgrading to 24.2). Freezing means unresponsive Impress without excessive CPU/RAM usage. Actually, the process is pretty much idle. Finally, finding the time, I investigated, why freezing occurs at a random time point. This led to the finding that freezing occurred at any time certain 2 slides were displayed (either in slide pane or content view). So I checked the content of those slides and found video files linked. After a few trials of removing those and checking if Impress freezes, I realized that removing all of those 4 videos managed to prevent freezing Impress. I think that this is a codec issue. Then I went ahead and opened a fresh new file and tried to embed or link one of these videos. This immediately froze Impress. These videos are (if I remember correctly) generated with ImageJ. They may deviate from traditional AVIs recorded by cameras in terms of encoding. For instance, they may not be RGB or 8-bit color depth (e.g. 16-bit). Besides, they may also not be 24fps or any other traditional frame rate. All of these scenarios are quite normal for a presentation in life sciences (and probably also medicine, astronomy, physics etc.). My version of LO: Version: 24.2.1.2 (X86_64) / LibreOffice Community Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: de-AT (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160852] delete all comments in Impress (.uno:DeleteAllAnnotation) only deletes uneven-numbered comments
https://bugs.documentfoundation.org/show_bug.cgi?id=160852 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Works for me with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ea43cbbb7371a743f470d949762a0e92f196e652 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160862] New: Converting a DOCX to ODT using command line export each frame twice
https://bugs.documentfoundation.org/show_bug.cgi?id=160862 Bug ID: 160862 Summary: Converting a DOCX to ODT using command line export each frame twice Product: LibreOffice Version: 7.6.0.3 release Hardware: All OS: All Status: UNCONFIRMED Keywords: bisected, regression Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com CC: michael.st...@allotropia.de Download attachment 144783 from bug 119800. Open and see that it shows one frame with a table, unless hidden characters are shown, in which case two frames are seen (119800 re-introduced in bug 137469), and the navigator shows two frames and two tables. Convert it to ODT using command line like soffice --convert-to odt path/to/tdf119800-1.odt Check that the resulting ODT has four frames (two per each original fame). Regression from commit 2bcfb7231b5ca74f02274cfb74ca8463f78905d6 (tdf#152872 sw: conditionally hide paragraph breaks, 2023-01-10). Since commit 69ed893087f89d176a5ec4b263ce8d75774be72b (tdf#160253: fix list identifier export decision code, 2024-04-24), exporting using a debug build fails an assertion in XMLTextParagraphExport::RecordNodeIndex, which is a correct failure, showing exactly the problem that is described here. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160805] Conditional formatting range does not respond to insert/delete rows/columns
https://bugs.documentfoundation.org/show_bug.cgi?id=160805 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5740d3fa83e9725a2771e5f00ba4aaf9965f0be2 CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo Created conditional formatting range A1:A10. After insert new row 5 is range A1:A11. Tested with condition Color scale. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160851] Hiding rows or columns in Calc causes severe lag
https://bugs.documentfoundation.org/show_bug.cgi?id=160851 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Please test in safe mode, Menu/Help/Restart in Safe Mode Please attach a sample file. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 raal changed: What|Removed |Added Depends on||160023 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160023 [Bug 160023] Pasting Array formula used ROW or COLUMN function as GDI-Image results in an error-displayed image -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160023] Pasting Array formula used ROW or COLUMN function as GDI-Image results in an error-displayed image
https://bugs.documentfoundation.org/show_bug.cgi?id=160023 raal changed: What|Removed |Added Version|6.1.3.2 release |4.1.0.4 release CC||r...@post.cz Blocks||102593 OS|Windows (All) |All Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from raal --- Confirm with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5740d3fa83e9725a2771e5f00ba4aaf9965f0be2 CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160646] GIF don't animate in edit mode; are rendered as still images
https://bugs.documentfoundation.org/show_bug.cgi?id=160646 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5740d3fa83e9725a2771e5f00ba4aaf9965f0be2 CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
4 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1596697:(FORWARD_NULL)
*** CID 1596697:(FORWARD_NULL)
/sc/source/ui/miscdlgs/inscldlg.cxx: 99 in
ScInsertCellDlg::ScInsertCellDlg(weld::Window *, bool)()
93 break;
94 }
95 }
96
97 // if some cells are selected, then disable the SpinButtons
98 m_xNumberOfCols->set_sensitive(bColCount &&
!pViewData->GetMarkData().IsMarked());
>>> CID 1596697:(FORWARD_NULL)
>>> Passing null pointer "pViewData->GetMarkData()" to "IsMarked", which
>>> dereferences it.
99 m_xNumberOfRows->set_sensitive(bRowsCount &&
!pViewData->GetMarkData().IsMarked());
100 }
101
102 ScInsertCellDlg::~ScInsertCellDlg() {}
103
104 InsCellCmd ScInsertCellDlg::GetInsCellCmd() const
/sc/source/ui/miscdlgs/inscldlg.cxx: 98 in
ScInsertCellDlg::ScInsertCellDlg(weld::Window *, bool)()
92 bColCount = true;
93 break;
94 }
95 }
96
97 // if some cells are selected, then disable the SpinButtons
>>> CID 1596697:(FORWARD_NULL)
>>> Passing null pointer "pViewData->GetMarkData()" to "IsMarked", which
>>> dereferences it.
98 m_xNumberOfCols->set_sensitive(bColCount &&
!pViewData->GetMarkData().IsMarked());
99 m_xNumberOfRows->set_sensitive(bRowsCount &&
!pViewData->GetMarkData().IsMarked());
100 }
101
102 ScInsertCellDlg::~ScInsertCellDlg() {}
103
** CID 1596696: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/drawshape.cxx: 1282 in
slideshow::internal::DelayedGraphicLoader::DelayedGraphicLoader(std::shared_ptr)()
*** CID 1596696: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/drawshape.cxx: 1282 in
slideshow::internal::DelayedGraphicLoader::DelayedGraphicLoader(std::shared_ptr)()
1276 {
1277 mpGraphicLoader.reset();
1278 }
1279 }
1280
1281
DelayedGraphicLoader::DelayedGraphicLoader(std::shared_ptr pGraphic)
>>> CID 1596696: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pGraphic" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved instead.
1282 : mpGraphic(pGraphic)
1283 , mpVDevMask(DeviceFormat::WITHOUT_ALPHA)
1284 {
1285 }
1286 }
1287
** CID 1596695: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/drawshape.cxx: 575 in
slideshow::internal::DrawShape::create(const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &, double,
std::shared_ptr, const slideshow::internal::SlideShowContext &)()
*** CID 1596695: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/drawshape.cxx: 575 in
slideshow::internal::DrawShape::create(const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &, double,
std::shared_ptr, const slideshow::internal::SlideShowContext &)()
569 std::shared_ptrpGraphic,
570 const SlideShowContext& rContext )
571 {
572 DrawShapeSharedPtr pShape( new DrawShape(xShape,
573 xContainingPage,
574 nPrio,
>>> CID 1596695: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pGraphic" is passed-by-value as parameter to
>>> "slideshow::internal::DrawShape::DrawShape(com::sun::star::uno::Reference
>>> const &,
>>> com::sun::star::uno::Reference, double,
>>> std::shared_ptr, slideshow::internal::SlideShowContext const &)"
>>> when it could be moved instead.
575 pGraphic,
576 rContext) );
577
578 if( pShape->hasIntrinsicAnimation() )
579 {
580 OSL_ASSERT( !pShape->maAnimationFrames.empty() );
** CID 1596694: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/shapeimporter.cxx: 323 in
slideshow::internal::ShapeImporter::createShape(const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &,
std::basic_string_view>) const()
[Bug 137469] Text filter should have an option to hide hidden paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=137469 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9800 --- Comment #20 from Mike Kaganski --- This broke the fix for bug 119800. Now attachment 144783 doesn't show the first frame, again. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/core/access/acctable.cxx |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
New commits:
commit 2bad2224090eb2802111760ec83db230aeca0616
Author: Caolán McNamara
AuthorDate: Mon Apr 29 11:59:09 2024 +0100
Commit: Caolán McNamara
CommitDate: Mon Apr 29 21:23:07 2024 +0200
futile to null check here if we deref afterwards anyway
Change-Id: I994b276ad39b09547cb1dbd3710daf519c5f5c66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166864
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/core/access/acctable.cxx
b/sw/source/core/access/acctable.cxx
index 3c8beaf9a0a4..d58a8b74b1ae 100644
--- a/sw/source/core/access/acctable.cxx
+++ b/sw/source/core/access/acctable.cxx
@@ -611,9 +611,7 @@ SwAccessibleTable::SwAccessibleTable(
SwAccessibleContext( pInitMap, AccessibleRole::TABLE, pTabFrame )
{
const SwFrameFormat* pFrameFormat = pTabFrame->GetFormat();
-if(pFrameFormat)
-
StartListening(const_cast(pFrameFormat)->GetNotifier());
-
+StartListening(const_cast(pFrameFormat)->GetNotifier());
SetName( pFrameFormat->GetName() + "-" + OUString::number(
pTabFrame->GetPhyPageNum() ) );
const OUString sArg1( static_cast< const SwTabFrame * >( GetFrame()
)->GetFormat()->GetName() );
@@ -1620,8 +1618,7 @@ SwAccessibleTableColHeaders::SwAccessibleTableColHeaders(
SolarMutexGuard aGuard;
const SwFrameFormat* pFrameFormat = pTabFrame->GetFormat();
-if(pFrameFormat)
-
StartListening(const_cast(pFrameFormat)->GetNotifier());
+StartListening(const_cast(pFrameFormat)->GetNotifier());
const OUString aName = pFrameFormat->GetName() + "-ColumnHeaders";
SetName( aName + "-" + OUString::number( pTabFrame->GetPhyPageNum() ) );
[Bug 160861] Polish language is missing, it goes beyond the text area
https://bugs.documentfoundation.org/show_bug.cgi?id=160861 --- Comment #1 from Łukasz --- Created attachment 193898 --> https://bugs.documentfoundation.org/attachment.cgi?id=193898=edit problem -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160861] New: Polish language is missing, it goes beyond the text area
https://bugs.documentfoundation.org/show_bug.cgi?id=160861 Bug ID: 160861 Summary: Polish language is missing, it goes beyond the text area Product: LibreOffice Version: 24.2.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ljani...@wp.pl Description: I sent you 5 euros. gives you a screenshot with 6 places where the Polish language is missing. there are many more such places. Actual Results: switch to Polish Expected Results: Polish text is missing Reproducible: Always User Profile Reset: Yes Additional Info: show the entire text in Polish -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159366] List styles add paragraph direct formatting on loading Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=159366 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 target:7.6.8 |target:24.8.0 target:7.6.8 ||target:24.2.4 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159366] List styles add paragraph direct formatting on loading Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=159366 --- Comment #10 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/d45a0651990a58b8eb1306205cb2209d1012398f tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override It will be available in 24.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 114287] fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style
https://bugs.documentfoundation.org/show_bug.cgi?id=114287 --- Comment #8 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/d45a0651990a58b8eb1306205cb2209d1012398f tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override It will be available in 24.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 114287] fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style
https://bugs.documentfoundation.org/show_bug.cgi?id=114287 Commit Notification changed: What|Removed |Added Whiteboard|target:7.6.0 target:24.8.0 |target:7.6.0 target:24.8.0 |target:7.6.8|target:7.6.8 target:24.2.4 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sw/qa xmloff/source
sw/qa/extras/odfexport/odfexport2.cxx |6 +-
xmloff/source/text/XMLTextListBlockContext.hxx |1
xmloff/source/text/txtimp.cxx | 72 -
3 files changed, 5 insertions(+), 74 deletions(-)
New commits:
commit d45a0651990a58b8eb1306205cb2209d1012398f
Author: Michael Stahl
AuthorDate: Fri Apr 19 18:04:47 2024 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 29 21:14:33 2024 +0200
tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override
This reverts commit ade0a153f453500f15343380ac937252992733e0 "tdf#114287
xmloff: ODF import: fix text:list override of list style" and subsequent
commits 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d and
1b2a6b98291cf8b7022951be19b915fe2a9e18e6.
It turns out that there is actually a paragraph in ODF 1.2 and later
that gives paragraph's indent priority over the list style's, which i
unfortunately missed when investigating the above issues:
17.20
...
The fo:text-indent and fo:margin-left attributes are evaluated only
for paragraphs inside list items whose paragraph styles do not specify
them. If one of the two properties, or both, are specified by the
paragraph style, the text indent and/or left margin are taken from the
paragraph style. In this case the paragraph style's properties are
used to determine the indent and margin for the text lines and thus
also the alignment position.
This is usually interpreted as "on the same level", so applying a
list-style at a paragraph style overrides the indents inherited from a
parent paragraph style, but if the style then specifies its own indents
that overrides the list style's indents.
Furthermore it turns out that Google Docs now imports this bugdoc the
same way as LO 7.5 does; unclear if that changed recently (it shows
it like Word does in the preview, but like LO 7.5 does after opening it).
This means the way MS Word imports the bugdoc, which remains unchanged,
now looks like a bug and we should not change LO to be compatible with
it (when the same structure is created in Word, storing to ODF and
loading again, it looks different too).
Change-Id: I0c65bde38de9e6fcbccec55899c60c3245adb5ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166309
Reviewed-by: Michael Stahl
Tested-by: Jenkins
(cherry picked from commit 546741148863ae0b2a25cc994a7323c8113cb573)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166716
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/odfexport/odfexport2.cxx
b/sw/qa/extras/odfexport/odfexport2.cxx
index f654821acf6a..fb45d5c8e93c 100644
--- a/sw/qa/extras/odfexport/odfexport2.cxx
+++ b/sw/qa/extras/odfexport/odfexport2.cxx
@@ -885,9 +885,9 @@ DECLARE_ODFEXPORT_TEST(testTdf114287, "tdf114287.odt")
xmlDocUniquePtr pXmlDoc = parseLayoutDump();
assertXPath(pXmlDoc, "/root/page[1]/body/txt[2]/infos/prtBounds"_ostr,
"left"_ostr, "2268");
assertXPath(pXmlDoc, "/root/page[1]/body/txt[2]/infos/prtBounds"_ostr,
"right"_ostr, "11339");
-// the problem was that the list style name of the list must override the
-// paragraph style even though it's the same list style
-assertXPath(pXmlDoc, "/root/page[1]/body/txt[9]/infos/prtBounds"_ostr,
"left"_ostr, "357");
+// the list style name of the list is the same as the list style name of
the
+// paragraph, but in any case the margins of the paragraph take precedence
+assertXPath(pXmlDoc, "/root/page[1]/body/txt[9]/infos/prtBounds"_ostr,
"left"_ostr, "2268");
assertXPath(pXmlDoc, "/root/page[1]/body/txt[9]/infos/prtBounds"_ostr,
"right"_ostr, "11339");
assertXPath(pXmlDoc, "/root/page[1]/body/txt[16]/infos/prtBounds"_ostr,
"left"_ostr, "357");
assertXPath(pXmlDoc, "/root/page[1]/body/txt[16]/infos/prtBounds"_ostr,
"right"_ostr, "11339");
diff --git a/xmloff/source/text/XMLTextListBlockContext.hxx
b/xmloff/source/text/XMLTextListBlockContext.hxx
index 4b18d625cc36..a529afd1e476 100644
--- a/xmloff/source/text/XMLTextListBlockContext.hxx
+++ b/xmloff/source/text/XMLTextListBlockContext.hxx
@@ -66,7 +66,6 @@ public:
void ResetRestartNumbering() { mbRestartNumbering = false; }
/// does this list have (possibly inherited from parent) list-style-name?
-bool HasListStyleName() { return !msListStyleName.isEmpty(); }
const css::uno::Reference < css::container::XIndexReplace >& GetNumRules()
const
{ return mxNumRules; }
diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index d6e132323d34..56d21a5196f8 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -1004,45 +1004,6 @@ static bool lcl_HasListStyle( const OUString& sStyleName,
return bRet;
}
-namespace {
-
-auto IsPropertySet(uno::Reference const&
rxParaStyles,
-uno::Reference const&
core.git: Branch 'libreoffice-24-2' - sc/qa sc/source
sc/qa/uitest/pasteSpecial/tdf160765.py | 34 +
sc/source/ui/miscdlgs/inscodlg.cxx |4 ++-
2 files changed, 37 insertions(+), 1 deletion(-)
New commits:
commit 30524d5998d38b7e216b721859c72fbfc56a5b5a
Author: Andreas Heinisch
AuthorDate: Fri Apr 26 20:29:53 2024 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 29 21:12:47 2024 +0200
tdf#160765 - Paste Special Dialog: Remember comments checkbox
After the change of tdf#139858 the comments checkbox was not remembered
anymore after closing the dialog. In order to fix this issue, additionally
check not only the NOTE flag but also for the ADDNOTES one.
Change-Id: I8b24d231313b57a05b7e527c0865686762e5a2b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166762
Reviewed-by: Andreas Heinisch
Tested-by: Jenkins
(cherry picked from commit 7e30434655754277bfa7ce7d8ec37b07181d2c92)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166838
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/uitest/pasteSpecial/tdf160765.py
b/sc/qa/uitest/pasteSpecial/tdf160765.py
index 0b56be4c2dfa..c0c264432ef4 100755
--- a/sc/qa/uitest/pasteSpecial/tdf160765.py
+++ b/sc/qa/uitest/pasteSpecial/tdf160765.py
@@ -13,8 +13,42 @@ from libreoffice.calc.document import get_cell_by_position
from libreoffice.uno.propertyvalue import mkPropertyValues
from uitest.uihelper.calc import enter_text_to_cell
from libreoffice.calc.paste_special import reset_default_values
+from uitest.uihelper.common import get_state_as_dict
class tdf160765(UITestCase):
+def test_tdf160765_paste_special_comments_checked(self):
+with self.ui_test.create_doc_in_start_center("calc"):
+xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
+
+# Insert a comment in cell A1
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL":"A1"}))
+xArgs = mkPropertyValues({"Text": "Comment 1"})
+self.xUITest.executeCommandWithParameters(".uno:InsertAnnotation",
xArgs)
+
+# Copy cell A1 to clipboard
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL": "A1"}))
+self.xUITest.executeCommand(".uno:Copy")
+
+# Paste data using special options (check only comments)
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL": "A2"}))
+with
self.ui_test.execute_dialog_through_command(".uno:PasteSpecial") as
xPasteSpecialDlg:
+reset_default_values(self, xPasteSpecialDlg)
+xDateTimeChkBox = xPasteSpecialDlg.getChild("datetime")
+xDateTimeChkBox.executeAction("CLICK", tuple())
+xTextChkBox = xPasteSpecialDlg.getChild("text")
+xTextChkBox.executeAction("CLICK", tuple())
+xNumbersChkBox = xPasteSpecialDlg.getChild("numbers")
+xNumbersChkBox.executeAction("CLICK", tuple())
+xCommentsChkBox = xPasteSpecialDlg.getChild("comments")
+xCommentsChkBox.executeAction("CLICK", tuple())
+
+with
self.ui_test.execute_dialog_through_command(".uno:PasteSpecial") as
xPasteSpecialDlg:
+xCommentsChkBox = xPasteSpecialDlg.getChild("comments")
+# Without the fix in place, this test would have failed with
+# AssertionError: 'true' != 'false'
+# i.e., the comments checkbox was not remembered
+
self.assertEqual(get_state_as_dict(xCommentsChkBox)["Selected"], "true")
+
def test_tdf160765_undo_paste_comment(self):
with self.ui_test.create_doc_in_start_center("calc") as document:
xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
diff --git a/sc/source/ui/miscdlgs/inscodlg.cxx
b/sc/source/ui/miscdlgs/inscodlg.cxx
index 84292dcd91c4..378b10f37fd0 100644
--- a/sc/source/ui/miscdlgs/inscodlg.cxx
+++ b/sc/source/ui/miscdlgs/inscodlg.cxx
@@ -231,7 +231,9 @@ void ScInsertContentsDlg::SetInsContentsCmdBits(const
InsertDeleteFlags eFlags)
mxBtnInsNumbers->set_active((InsertDeleteFlags::VALUE & eFlags) ==
InsertDeleteFlags::VALUE);
mxBtnInsDateTime->set_active((InsertDeleteFlags::DATETIME & eFlags) ==
InsertDeleteFlags::DATETIME);
mxBtnInsStrings->set_active((InsertDeleteFlags::STRING & eFlags) ==
InsertDeleteFlags::STRING);
-mxBtnInsNotes->set_active((InsertDeleteFlags::NOTE & eFlags) ==
InsertDeleteFlags::NOTE);
+// tdf#160765 - additionally check either NOTE or ADDNOTES
+mxBtnInsNotes->set_active(((InsertDeleteFlags::NOTE |
InsertDeleteFlags::ADDNOTES) & eFlags)
+ != InsertDeleteFlags::NONE);
mxBtnInsFormulas->set_active((InsertDeleteFlags::FORMULA & eFlags) ==
InsertDeleteFlags::FORMULA);
mxBtnInsAttrs->set_active((InsertDeleteFlags::ATTRIB & eFlags) ==
InsertDeleteFlags::ATTRIB);
mxBtnInsObjects->set_active((InsertDeleteFlags::OBJECTS & eFlags) ==
core.git: Branch 'libreoffice-7-6-7' - xmloff/source
xmloff/source/text/txtimp.cxx |8
1 file changed, 8 insertions(+)
New commits:
commit 878f51b4ec313a45335585f6f88d3a2cd5631df1
Author: Michael Stahl
AuthorDate: Thu Apr 18 13:00:04 2024 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 29 21:06:24 2024 +0200
tdf#159903 xmloff: ODF import: fix bug in margin compatibility override
The check for the property being set was wrong: the state in a parent
style may be DIRECT_VALUE but a derived style may have a list style set,
which effectively overrides the ParaLeftMargin and ParaFirstLineIndent.
Fix this so that the compatibility override only happens when required.
(regression from commit 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d)
Change-Id: I6c8ca493df946afcb48a63c01c132620bcd7b390
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166257
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 1b2a6b98291cf8b7022951be19b915fe2a9e18e6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166218
Reviewed-by: Adolfo Jayme Barrientos
(cherry picked from commit 0b816bade2395d532862e8f2bba6fd7ea0ce540f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166718
Tested-by: Xisco Fauli
Reviewed-by: Xisco Fauli
Reviewed-by: Patrick Luby
diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index 1e17f9921df0..f63b13cebe86 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -1016,6 +1016,10 @@ auto
IsPropertySet(uno::Reference const& rxParaStyles
{
return true;
}
+if (xPropState->getPropertyState("NumberingStyleName") ==
beans::PropertyState_DIRECT_VALUE)
+{
+return false; // tdf#159903 this overrides value in the parent style
+}
// check if it is set by any parent common style
OUString style;
rxPropSet->getPropertyValue("ParaStyleName") >>= style;
@@ -1028,6 +1032,10 @@ auto
IsPropertySet(uno::Reference const& rxParaStyles
{
return true;
}
+if (xStyleProps->getPropertyState("NumberingStyleName") ==
beans::PropertyState_DIRECT_VALUE)
+{
+return false; // tdf#159903 this overrides value in the parent
style
+}
style = xStyle->getParentStyle();
}
return false;
[Bug 159366] List styles add paragraph direct formatting on loading Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=159366 --- Comment #9 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/0c1e01cd8370b1c05e12dc965bf3e95bc2fd7378 tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override It will be available in 7.6.8. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 114287] fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style
https://bugs.documentfoundation.org/show_bug.cgi?id=114287 --- Comment #7 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/0c1e01cd8370b1c05e12dc965bf3e95bc2fd7378 tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override It will be available in 7.6.8. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159366] List styles add paragraph direct formatting on loading Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=159366 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 target:7.6.8 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 114287] fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style
https://bugs.documentfoundation.org/show_bug.cgi?id=114287 Commit Notification changed: What|Removed |Added Whiteboard|target:7.6.0 target:24.8.0 |target:7.6.0 target:24.8.0 ||target:7.6.8 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-7-6' - sw/qa xmloff/source
sw/qa/extras/odfexport/odfexport2.cxx |6 +-
xmloff/source/text/XMLTextListBlockContext.hxx |1
xmloff/source/text/txtimp.cxx | 72 -
3 files changed, 5 insertions(+), 74 deletions(-)
New commits:
commit 0c1e01cd8370b1c05e12dc965bf3e95bc2fd7378
Author: Michael Stahl
AuthorDate: Fri Apr 19 18:04:47 2024 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 29 21:04:59 2024 +0200
tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override
This reverts commit ade0a153f453500f15343380ac937252992733e0 "tdf#114287
xmloff: ODF import: fix text:list override of list style" and subsequent
commits 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d and
1b2a6b98291cf8b7022951be19b915fe2a9e18e6.
It turns out that there is actually a paragraph in ODF 1.2 and later
that gives paragraph's indent priority over the list style's, which i
unfortunately missed when investigating the above issues:
17.20
...
The fo:text-indent and fo:margin-left attributes are evaluated only
for paragraphs inside list items whose paragraph styles do not specify
them. If one of the two properties, or both, are specified by the
paragraph style, the text indent and/or left margin are taken from the
paragraph style. In this case the paragraph style's properties are
used to determine the indent and margin for the text lines and thus
also the alignment position.
This is usually interpreted as "on the same level", so applying a
list-style at a paragraph style overrides the indents inherited from a
parent paragraph style, but if the style then specifies its own indents
that overrides the list style's indents.
Furthermore it turns out that Google Docs now imports this bugdoc the
same way as LO 7.5 does; unclear if that changed recently (it shows
it like Word does in the preview, but like LO 7.5 does after opening it).
This means the way MS Word imports the bugdoc, which remains unchanged,
now looks like a bug and we should not change LO to be compatible with
it (when the same structure is created in Word, storing to ODF and
loading again, it looks different too).
Change-Id: I0c65bde38de9e6fcbccec55899c60c3245adb5ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166309
Reviewed-by: Michael Stahl
Tested-by: Jenkins
(cherry picked from commit 546741148863ae0b2a25cc994a7323c8113cb573)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166717
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/odfexport/odfexport2.cxx
b/sw/qa/extras/odfexport/odfexport2.cxx
index 103892a7723a..67080ede80a9 100644
--- a/sw/qa/extras/odfexport/odfexport2.cxx
+++ b/sw/qa/extras/odfexport/odfexport2.cxx
@@ -852,9 +852,9 @@ DECLARE_ODFEXPORT_TEST(testTdf114287, "tdf114287.odt")
xmlDocUniquePtr pXmlDoc = parseLayoutDump();
assertXPath(pXmlDoc, "/root/page[1]/body/txt[2]/infos/prtBounds", "left",
"2268");
assertXPath(pXmlDoc, "/root/page[1]/body/txt[2]/infos/prtBounds", "right",
"11339");
-// the problem was that the list style name of the list must override the
-// paragraph style even though it's the same list style
-assertXPath(pXmlDoc, "/root/page[1]/body/txt[9]/infos/prtBounds", "left",
"357");
+// the list style name of the list is the same as the list style name of
the
+// paragraph, but in any case the margins of the paragraph take precedence
+assertXPath(pXmlDoc, "/root/page[1]/body/txt[9]/infos/prtBounds", "left",
"2268");
assertXPath(pXmlDoc, "/root/page[1]/body/txt[9]/infos/prtBounds", "right",
"11339");
assertXPath(pXmlDoc, "/root/page[1]/body/txt[16]/infos/prtBounds", "left",
"357");
assertXPath(pXmlDoc, "/root/page[1]/body/txt[16]/infos/prtBounds",
"right", "11339");
diff --git a/xmloff/source/text/XMLTextListBlockContext.hxx
b/xmloff/source/text/XMLTextListBlockContext.hxx
index 4b18d625cc36..a529afd1e476 100644
--- a/xmloff/source/text/XMLTextListBlockContext.hxx
+++ b/xmloff/source/text/XMLTextListBlockContext.hxx
@@ -66,7 +66,6 @@ public:
void ResetRestartNumbering() { mbRestartNumbering = false; }
/// does this list have (possibly inherited from parent) list-style-name?
-bool HasListStyleName() { return !msListStyleName.isEmpty(); }
const css::uno::Reference < css::container::XIndexReplace >& GetNumRules()
const
{ return mxNumRules; }
diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index f63b13cebe86..0a7856bca90e 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -1004,45 +1004,6 @@ static bool lcl_HasListStyle( const OUString& sStyleName,
return bRet;
}
-namespace {
-
-auto IsPropertySet(uno::Reference const&
rxParaStyles,
-uno::Reference const& rxPropSet,
-OUString const& rProperty)
-{
-uno::Reference const
[Bug 160859] Paste only comments fails when several cells copied
https://bugs.documentfoundation.org/show_bug.cgi?id=160859 Andreas Heinisch changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Andreas Heinisch --- Confirmed in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 88a8c897726ae9613f02834a3a843749e8b889c2 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: CL threaded Copying range A1:B1 to A2:B2 surprisingly works. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-7-6' - sc/qa sc/source
sc/qa/uitest/pasteSpecial/tdf160765.py | 75 +
sc/source/ui/view/viewfun3.cxx |3 -
2 files changed, 77 insertions(+), 1 deletion(-)
New commits:
commit 4d744d94cc4ee114a7e5d5373b2b599baed31ee5
Author: Andreas Heinisch
AuthorDate: Mon Apr 22 20:06:50 2024 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 29 21:01:47 2024 +0200
tdf#160765 - Save content for undo when pasting notes
even if no content was changed after pasting special. Otherwise, the undo
functionality crashes due to undoing a cell with no content where the
annotation indicator will remain (unod/redo of note captions are handled via
drawing undo).
Change-Id: I7007fce510d6e9896cbda11a1e14a61b5ccb34a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166469
Tested-by: Jenkins
Reviewed-by: Stéphane Guillou
Reviewed-by: Andreas Heinisch
(cherry picked from commit a1694b194c2b3e89250c5b79a69e7dd184b69976)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166524
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/uitest/pasteSpecial/tdf160765.py
b/sc/qa/uitest/pasteSpecial/tdf160765.py
new file mode 100755
index ..0b56be4c2dfa
--- /dev/null
+++ b/sc/qa/uitest/pasteSpecial/tdf160765.py
@@ -0,0 +1,75 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.paste_special import reset_default_values
+
+class tdf160765(UITestCase):
+def test_tdf160765_undo_paste_comment(self):
+with self.ui_test.create_doc_in_start_center("calc") as document:
+xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
+
+# Write text to cell A1 and B1
+enter_text_to_cell(xGridWin, "A1", "A1 sample text")
+enter_text_to_cell(xGridWin, "B1", "B1 sample text")
+
+# Insert a comment in cell B1
+xArgs = mkPropertyValues({"Text": "Comment 1"})
+self.xUITest.executeCommandWithParameters(".uno:InsertAnnotation",
xArgs)
+
+# Insert a comment in cell A2
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL":"A2"}))
+xArgs = mkPropertyValues({"Text": "Comment 2"})
+self.xUITest.executeCommandWithParameters(".uno:InsertAnnotation",
xArgs)
+
+# Copy cell A2 to clipboard
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL": "A2"}))
+self.xUITest.executeCommand(".uno:Copy")
+
+# Set cursor to cells and paste data using special options (check
only comments)
+targetCells = ["A1", "B1"]
+for index, targetCell in enumerate(targetCells):
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL":
targetCell}))
+with
self.ui_test.execute_dialog_through_command(".uno:PasteSpecial") as
xPasteSpecialDlg:
+reset_default_values(self, xPasteSpecialDlg)
+xDateTimeChkBox = xPasteSpecialDlg.getChild("datetime")
+xDateTimeChkBox.executeAction("CLICK", tuple())
+xTextChkBox = xPasteSpecialDlg.getChild("text")
+xTextChkBox.executeAction("CLICK", tuple())
+xNumbersChkBox = xPasteSpecialDlg.getChild("numbers")
+xNumbersChkBox.executeAction("CLICK", tuple())
+xCommentsChkBox = xPasteSpecialDlg.getChild("comments")
+xCommentsChkBox.executeAction("CLICK", tuple())
+
+# Undo both inserted comments
+self.xUITest.executeCommand(".uno:Undo")
+# Without the fix in place, this test would have failed with
+# AssertionError: 'Comment 1' != ''
+# i.e., the cell does not contain any comment
+self.assertEqual("Comment 1", get_cell_by_position(document, 0, 1,
0).Annotation.String)
+self.xUITest.executeCommand(".uno:Undo")
+self.assertEqual("", get_cell_by_position(document, 0, 0,
0).Annotation.String)
+
+# Redo both inserted comments
+self.xUITest.executeCommand(".uno:Redo")
+# Without the fix in place, this test would have failed with
+# AssertionError: 'Comment 2' != ''
+# i.e., the cell does not contain the restored comment
+self.assertEqual("Comment 2", get_cell_by_position(document, 0, 0,
0).Annotation.String)
+self.xUITest.executeCommand(".uno:Redo")
+
core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9bc04a380016c7537850b3f929afab21448eac03 Author: Olivier Hallot AuthorDate: Mon Apr 29 15:51:44 2024 -0300 Commit: Gerrit Code Review CommitDate: Mon Apr 29 20:51:44 2024 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 0d4e0c0452346d797ae5eda7e3c1c61d73f6eb3c - Fix indexer="include" in Help files. + refactor Change-Id: Ia0dfdc0f88f40776042ca0b745e26dc9e0cd479f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166874 Reviewed-by: Olivier Hallot Tested-by: Jenkins diff --git a/helpcontent2 b/helpcontent2 index 3fa70de3d05c..0d4e0c045234 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 3fa70de3d05c43e190a2d2718a43667bda3ff5f1 +Subproject commit 0d4e0c0452346d797ae5eda7e3c1c61d73f6eb3c
