[Bug 161055] New: Editing Docx Image shifts to and sticks to righthand margin when moved
https://bugs.documentfoundation.org/show_bug.cgi?id=161055 Bug ID: 161055 Summary: Editing Docx Image shifts to and sticks to righthand margin when moved Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: saywel...@gmail.com Created attachment 194098 --> https://bugs.documentfoundation.org/attachment.cgi?id=194098=edit The right hand image jumps to margin when moved In the attached .docx, if I touch the right hand image with the mouse, the image jumps to the right hand margin and can only be put back by setting the position in the Properties dialogue. Expected behaviour: the image can be dragged and placed in a new location and stay where it is placed. Issue arose in https://ask.libreoffice.org/t/positioning-images-of-different-sizes-and-shapes-side-by-side-and-setting-default-text-padding-to-0-2cm/105752/4 UnstableImages.docx created in Word 2010 for this report following this question: "Every time I add the second image to the right of another image it snaps to the right edge of the page." Same behaviour seen in 6.4.7.2 Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-NZ (en_NZ); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160846] Flathub Libreoffice (24.2.2.2) Failed to open display terminal message. Crashes seconds later
https://bugs.documentfoundation.org/show_bug.cgi?id=160846 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #2 from Buovjaga --- Is there a reason why this is not reported to https://github.com/flathub/org.libreoffice.LibreOffice/issues -- You are receiving this mail because: You are the assignee for the bug.
core.git: include/vcl vcl/source
include/vcl/toolkit/combobox.hxx | 33 ++
vcl/source/control/combobox.cxx | 576 ++-
2 files changed, 298 insertions(+), 311 deletions(-)
New commits:
commit 737a07897e7414228d727fd3d16b3bd47ff226fa
Author: Michael Weghorn
AuthorDate: Fri May 10 16:55:49 2024 +0200
Commit: Michael Weghorn
CommitDate: Mon May 13 06:31:55 2024 +0200
vcl: Merge ComboBox and ComboBox::Impl
This removes one level of indirection.
`ComboBox::Impl` had originally been introduced in
commit ece8699f8f22f6bae137c601bc29b83b75dc3bf3
Author: Michael Stahl
Date: Fri Jul 10 12:05:48 2015 +0200
vcl: pImplify ComboBox
The boost::signal stuff is quite heavy (33 kloc), so try to hide it
from the header.
Change-Id: I87826ccfd2a151aff274ffa6b7159a988f751808
, but all of the boost usage in here has been replaced
since then.
Change-Id: Ia8fb5cb895800edae104857c7713fa65e509a3c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167485
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/include/vcl/toolkit/combobox.hxx b/include/vcl/toolkit/combobox.hxx
index 89565cac8652..9e676601f8a8 100644
--- a/include/vcl/toolkit/combobox.hxx
+++ b/include/vcl/toolkit/combobox.hxx
@@ -31,15 +31,44 @@
#define COMBOBOX_ENTRY_NOTFOUND (SAL_MAX_INT32)
#define COMBOBOX_MAX_ENTRIES(SAL_MAX_INT32 - 1)
+class ImplBtn;
+class ImplListBox;
class ImplListBoxWindow;
+class ImplListBoxFloatingWindow;
class UserDrawEvent;
+struct ComboBoxBounds;
/// A widget used to choose from a list of items and which has an entry.
class VCL_DLLPUBLIC ComboBox : public Edit
{
private:
-struct SAL_DLLPRIVATE Impl;
-std::unique_ptr m_pImpl;
+VclPtr m_pSubEdit;
+VclPtr m_pImplLB;
+VclPtr m_pBtn;
+VclPtr m_pFloatWin;
+sal_uInt16 m_nDDHeight;
+sal_Unicode m_cMultiSep;
+bool m_isDDAutoSize : 1;
+bool m_isSyntheticModify : 1;
+bool m_isKeyBoardModify : 1;
+bool m_isMatchCase : 1;
+sal_Int32 m_nMaxWidthChars;
+sal_Int32 m_nWidthInChars;
+Link m_SelectHdl;
+
+void ImplInitComboBoxData();
+void ImplUpdateFloatSelection();
+ComboBoxBounds calcComboBoxDropDownComponentBounds(
+const Size , const Size ) const;
+
+DECL_LINK(ImplSelectHdl, LinkParamNone*, void);
+DECL_LINK(ImplCancelHdl, LinkParamNone*, void);
+DECL_LINK(ImplDoubleClickHdl, ImplListBoxWindow*, void);
+DECL_LINK(ImplClickBtnHdl, void*, void);
+DECL_LINK(ImplPopupModeEndHdl, FloatingWindow*, void);
+DECL_LINK(ImplSelectionChangedHdl, sal_Int32, void);
+DECL_LINK(ImplAutocompleteHdl, Edit&, void);
+DECL_LINK(ImplListItemSelectHdl , LinkParamNone*, void);
protected:
using Window::ImplInit;
diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
index 89a53c537d91..f4327ac77024 100644
--- a/vcl/source/control/combobox.cxx
+++ b/vcl/source/control/combobox.cxx
@@ -36,7 +36,6 @@
#include
#include
-namespace {
struct ComboBoxBounds
{
@@ -47,54 +46,6 @@ struct ComboBoxBounds
Size aButtonSize;
};
-}
-
-struct ComboBox::Impl
-{
-ComboBox & m_rThis;
-VclPtrm_pSubEdit;
-VclPtr m_pImplLB;
-VclPtr m_pBtn;
-VclPtr m_pFloatWin;
-sal_uInt16 m_nDDHeight;
-sal_Unicode m_cMultiSep;
-boolm_isDDAutoSize: 1;
-boolm_isSyntheticModify : 1;
-boolm_isKeyBoardModify: 1;
-boolm_isMatchCase : 1;
-sal_Int32 m_nMaxWidthChars;
-sal_Int32 m_nWidthInChars;
-Link m_SelectHdl;
-
-explicit Impl(ComboBox & rThis)
-: m_rThis(rThis)
-, m_nDDHeight(0)
-, m_cMultiSep(0)
-, m_isDDAutoSize(false)
-, m_isSyntheticModify(false)
-, m_isKeyBoardModify(false)
-, m_isMatchCase(false)
-, m_nMaxWidthChars(0)
-, m_nWidthInChars(-1)
-{
-}
-
-void ImplInitComboBoxData();
-void ImplUpdateFloatSelection();
-ComboBoxBounds calcComboBoxDropDownComponentBounds(
-const Size , const Size ) const;
-
-DECL_LINK( ImplSelectHdl, LinkParamNone*, void );
-DECL_LINK( ImplCancelHdl, LinkParamNone*, void );
-DECL_LINK( ImplDoubleClickHdl, ImplListBoxWindow*, void );
-DECL_LINK( ImplClickBtnHdl, void*, void );
-DECL_LINK( ImplPopupModeEndHdl, FloatingWindow*, void );
-DECL_LINK( ImplSelectionChangedHdl, sal_Int32, void );
-DECL_LINK( ImplAutocompleteHdl, Edit&, void );
-DECL_LINK( ImplListItemSelectHdl , LinkParamNone*, void );
-};
-
-
static void lcl_GetSelectedEntries( ::std::set< sal_Int32 >& rSelectedPos,
std::u16string_view rText, sal_Unicode cTokenSep, const ImplEntryList&
rEntryList )
{
if (rText.empty())
@@ -110,9 +61,16 @@ static void
[Bug 160824] Print dialogue's "Number of copies" field is scrollable and focused by default, leading to excess copies being printed on accident
https://bugs.documentfoundation.org/show_bug.cgi?id=160824 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|Print dialogue's "Number of |Print dialogue's "Number of |copies" field is scrollable |copies" field is scrollable |and focus by default, |and focused by default, |leading to excess copies|leading to excess copies |being printed on accident |being printed on accident -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103309] [META] Print dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103309 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||160824 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160824 [Bug 160824] Print dialogue's "Number of copies" field is scrollable and focus by default, leading to excess copies being printed on accident -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160824] Print dialogue's "Number of copies" field is scrollable and focus by default, leading to excess copies being printed on accident
https://bugs.documentfoundation.org/show_bug.cgi?id=160824 Stéphane Guillou (stragu) changed: What|Removed |Added Component|Draw|UI CC||caolan.mcnamara@collabora.c ||om, ||heiko.tietze@documentfounda ||tion.org, ||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEW Blocks||103309 Whiteboard| QA:needsComment| OS|Windows (All) |All Ever confirmed|0 |1 Version|24.2.2.2 release|7.2.0.4 release Summary|Print dialogue box is |Print dialogue's "Number of |scrollable for number of|copies" field is scrollable |copies leading to excess|and focus by default, |copies being printed on |leading to excess copies |accident|being printed on accident --- Comment #1 from Stéphane Guillou (stragu) --- I agree that it can lead to very problematic results, and I doubt anyone relies on the scrollability of this field to assign a value (too fiddly when we know exactly what value we want to assign). This kind of interaction might make sense for e.g. a value that auto-updates a preview (e.g. in the Character dialog), but not here. gtk3 VCL plugin does not allow changing the value by mouse scroll. gen and kf5 do, even with the pointer outside of the field, which is focused by default, as MT said. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ad1f0bdeac30fca1dc56a08803ef23f2aca4db05 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Also in 7.2.0.4. In 7.1.0.3, the field was not focused when opening the dialog, so it was less of a problem. Heiko, Caolán, thoughts? Are there other examples of making such a spinbox "unscrollable"? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103309 [Bug 103309] [META] Print dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161043] CALC Error in SUBTOTAL(9;range) when the source values are minutes and seconds exceeding 60 minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=161043 Colin changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161048] Background processes are left opened by LO Dev Start Center on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 --- Comment #9 from Mike Kaganski --- See also: https://ask.libreoffice.org/t/exit-lo-windows/93863 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160834] Unclear meaning of "Ignore pieces of length"
https://bugs.documentfoundation.org/show_bug.cgi?id=160834 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160849] [UI]Shortcut Key Ctrl+F6 is not listed in Tools>Customize, tab Keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=160849 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161053] the distance between first and second lines in paragraphs is smaller than others
https://bugs.documentfoundation.org/show_bug.cgi?id=161053 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160834] Unclear meaning of "Ignore pieces of length"
https://bugs.documentfoundation.org/show_bug.cgi?id=160834 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158210] Slide background transparency lost
https://bugs.documentfoundation.org/show_bug.cgi?id=158210 --- Comment #3 from QA Administrators --- Dear mkhemlock, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160850] Gender mismatch in Draw status bar
https://bugs.documentfoundation.org/show_bug.cgi?id=160850 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158214] picture resizing problem in LibreOffice write mode
https://bugs.documentfoundation.org/show_bug.cgi?id=158214 --- Comment #2 from QA Administrators --- Dear Piet Wierenga, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155269] Chapter numbering mech silently changes para style numeric outline-level
https://bugs.documentfoundation.org/show_bug.cgi?id=155269 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158208] crashed when I tried to save to email
https://bugs.documentfoundation.org/show_bug.cgi?id=158208 --- Comment #2 from QA Administrators --- Dear sk8elote, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 142261] [EMF/EMF+] SetMiterLimit support
https://bugs.documentfoundation.org/show_bug.cgi?id=142261 --- Comment #10 from QA Administrators --- Dear Valek Filippov, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 140411] Calc constantly re-calculating (bug in the sheet?)
https://bugs.documentfoundation.org/show_bug.cgi?id=140411 --- Comment #5 from QA Administrators --- Dear Dan, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158207] Crash in: SwRangeRedline::MoveFromSection(unsigned __int64)
https://bugs.documentfoundation.org/show_bug.cgi?id=158207 --- Comment #2 from QA Administrators --- Dear whawn, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141317] Screenreaders not announcing focus switch between frames (see comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=141317 --- Comment #9 from QA Administrators --- Dear juergenkohler23, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146494] Inserting LibreOffice OLE objects in other applications fail
https://bugs.documentfoundation.org/show_bug.cgi?id=146494 --- Comment #2 from QA Administrators --- Dear Hossein, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132578] Page wrap confused if page wrapping is on and another image is anchored as character
https://bugs.documentfoundation.org/show_bug.cgi?id=132578 --- Comment #4 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138634] Impress slide show pauses when using another LibreOffice application (except Base)
https://bugs.documentfoundation.org/show_bug.cgi?id=138634 --- Comment #4 from QA Administrators --- Dear Jayman, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 119887] DOC: Vertical spacing not properly applied in the paragraph, moves one more line to second page in LO compared to MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=119887 --- Comment #12 from QA Administrators --- Dear Patrick Jaap, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161054] New: ODT: incorrect size of empty lines in a text box
https://bugs.documentfoundation.org/show_bug.cgi?id=161054 Bug ID: 161054 Summary: ODT: incorrect size of empty lines in a text box Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com Created attachment 194097 --> https://bugs.documentfoundation.org/attachment.cgi?id=194097=edit A text box with directly set font size, with an empty line The same problem as in bug 161023, but in ODT files: empty lines in a text box, where font size was set directly, lose that size, and revert to the default size, changing vertical size of the shape. In the attachment, put cursor into the text box, and check font size of each of the three lines. In 24.2.0, it shows font size 10 in all three. In current master, it shows 18 in the second (empty) line, making the overall height larger. Regression after commit 69ed893087f89d176a5ec4b263ce8d75774be72b (tdf#160253: fix list identifier export decision code, 2024-04-24). The fix for bug 161023 only fixed this problem in non-text documents. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161048] Background processes are left opened by LO Dev Start Center on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 --- Comment #8 from Mike Kaganski --- (In reply to V Stuart Foote from comment #6) > Despite being an alpha+, not yet beta, I do see significant writes into > Windows registry. Note that writing to registry in this case is likely related to the Windows Installer service operation itself (e.g., its uninstall logging), not to the registry settings that LibreOffice MSI has in it (registration of explorer extensions, file type associations, and so on). ady, can you please: 1. Check which command line is reported in Windows Task Manager for the leftover process? You might need to enable "Command line" column in Details tab for that. The command line may be long. 2. Use https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg#Producing_a_mini_dump to produce a minidump of the leftover BIN process. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 105582] [META] Function wizard dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105582 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||160835 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160835 [Bug 160835] Unclear meaning of "a basic total population" -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160835] Unclear meaning of "a basic total population"
https://bugs.documentfoundation.org/show_bug.cgi?id=160835 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||105582 Version|unspecified |Inherited From OOo Priority|medium |low Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||rafael.palma.l...@gmail.com ||, ||stephane.guillou@libreoffic ||e.org Severity|normal |minor --- Comment #7 from Stéphane Guillou (stragu) --- Rafael, what do you think? I feel like this could be simplified to just "population". The string exists in OOo 3.3, but doesn't mean anything to me either, and an online search seems to confirms that it does not have any special meaning in stats. Elsewhere: - MS Excel uses "a sample of a population"[1][2]. - Google Docs only says it's a sample without having to mention "from a population". (Only uses "population" to refer to other functions that consider the whole population instead of a sample.)[2] [1]: https://support.microsoft.com/en-us/office/stdeva-function-5ff3-7ea5-48de-9a6d-11ed73b29e9d [2]: https://support.microsoft.com/en-us/office/vara-function-3de77469-fa3a-47b4-85fd-81758a1e1d07 [3]: https://support.google.com/docs/answer/3094055 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105582 [Bug 105582] [META] Function wizard dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
core.git: sd/qa xmloff/source
sd/qa/unit/data/odp/tdf161023.fodp | 35
sd/qa/unit/import-tests2.cxx | 52 +
xmloff/source/text/txtparai.cxx|4 ++
3 files changed, 90 insertions(+), 1 deletion(-)
New commits:
commit 2ca93eb5df7ddb8641ff7d884a109261c9700aca
Author: Mike Kaganski
AuthorDate: Sun May 12 22:53:23 2024 +0500
Commit: Mike Kaganski
CommitDate: Mon May 13 04:21:20 2024 +0200
tdf#161023: Empty spans may only define paragraph marks in text documents
Change-Id: I40607652a0fd8e31c609732daa54bb796e3fffa0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167557
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sd/qa/unit/data/odp/tdf161023.fodp
b/sd/qa/unit/data/odp/tdf161023.fodp
new file mode 100644
index ..bf3a894cec4b
--- /dev/null
+++ b/sd/qa/unit/data/odp/tdf161023.fodp
@@ -0,0 +1,35 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ a
+
+ c
+
+
+
+
+
+
\ No newline at end of file
diff --git a/sd/qa/unit/import-tests2.cxx b/sd/qa/unit/import-tests2.cxx
index 5457224bd642..d5e6c2bf14bb 100644
--- a/sd/qa/unit/import-tests2.cxx
+++ b/sd/qa/unit/import-tests2.cxx
@@ -2006,6 +2006,58 @@ CPPUNIT_TEST_FIXTURE(SdImportTest2, testMasterSlides)
CPPUNIT_ASSERT_EQUAL(sal_Int32(7), xMasterPages->getCount());
}
+CPPUNIT_TEST_FIXTURE(SdImportTest2, testTdf161023)
+{
+// Given a shape with three paragraphs (18pt), all directly assigned a
smaller font (10pt)
+createSdImpressDoc("odp/tdf161023.fodp");
+auto shape = getShapeFromPage(0, 0);
+
+// 1st paragraph, not empty
+{
+auto paragraph(getParagraphFromShape(0, shape));
+CPPUNIT_ASSERT_EQUAL(u"a"_ustr, paragraph->getString());
+auto run(getRunFromParagraph(0, paragraph));
+CPPUNIT_ASSERT_EQUAL(u"a"_ustr, run->getString());
+uno::Reference xPropSet(run,
uno::UNO_QUERY_THROW);
+double fCharHeight = 0;
+xPropSet->getPropertyValue("CharHeight") >>= fCharHeight;
+CPPUNIT_ASSERT_EQUAL(10.0, fCharHeight);
+// No more runs
+CPPUNIT_ASSERT_THROW(getRunFromParagraph(1, paragraph),
container::NoSuchElementException);
+}
+
+// Empty 2nd paragraph, consisting of a single span: this span was treated
as "paragraph mark"
+{
+auto paragraph(getParagraphFromShape(1, shape));
+CPPUNIT_ASSERT_EQUAL(u""_ustr, paragraph->getString());
+auto run(getRunFromParagraph(0, paragraph));
+CPPUNIT_ASSERT_EQUAL(u""_ustr, run->getString());
+uno::Reference xPropSet(run,
uno::UNO_QUERY_THROW);
+double fCharHeight = 0;
+xPropSet->getPropertyValue("CharHeight") >>= fCharHeight;
+// Without the fix, this would fail with
+// - Expected: 10
+// - Actual : 18
+CPPUNIT_ASSERT_EQUAL(10.0, fCharHeight);
+// No more runs
+CPPUNIT_ASSERT_THROW(getRunFromParagraph(1, paragraph),
container::NoSuchElementException);
+}
+
+// 3rd paragraph, not empty
+{
+auto paragraph(getParagraphFromShape(2, shape));
+CPPUNIT_ASSERT_EQUAL(u"c"_ustr, paragraph->getString());
+auto run(getRunFromParagraph(0, paragraph));
+CPPUNIT_ASSERT_EQUAL(u"c"_ustr, run->getString());
+uno::Reference xPropSet(run,
uno::UNO_QUERY_THROW);
+double fCharHeight = 0;
+xPropSet->getPropertyValue("CharHeight") >>= fCharHeight;
+CPPUNIT_ASSERT_EQUAL(10.0, fCharHeight);
+// No more runs
+CPPUNIT_ASSERT_THROW(getRunFromParagraph(1, paragraph),
container::NoSuchElementException);
+}
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/text/txtparai.cxx b/xmloff/source/text/txtparai.cxx
index 816bf876..cd4cc2b9996c 100644
--- a/xmloff/source/text/txtparai.cxx
+++ b/xmloff/source/text/txtparai.cxx
@@ -33,6 +33,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -1796,6 +1797,7 @@ void XMLParaContext::endFastElement(sal_Int32 )
uno::Reference
xCompare(xTxtImport->GetText(), uno::UNO_QUERY);
if (xCompare.is())
{
+bool bTextDocument =
GetImport().GetModel().query().is();
try
{
for (const auto& pHint : m_xHints->GetHints())
@@ -1809,7 +1811,7 @@ void XMLParaContext::endFastElement(sal_Int32 )
// created between commits
6249858a8972aef077e0249bd93cfe8f01bce4d6 and
// 1a88efa8e02a6d765dab13c7110443bb9e6acecf, where the
trailing empty spans
// were used to store the marker formatting
-if (pHint->GetType() == XMLHintType::XML_HINT_STYLE
+if (bTextDocument && pHint->GetType() ==
XMLHintType::XML_HINT_STYLE
&&
[Bug 153293] [META] Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=153293 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||160829 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160829 [Bug 160829] checkbox state ticked / unticked poorly visible in dark mode (Breeze icon theme) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118017] [META] macOS Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118017 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|160829 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160829 [Bug 160829] checkbox state ticked / unticked poorly visible in dark mode (Breeze icon theme) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107139] [META] Breeze icons
https://bugs.documentfoundation.org/show_bug.cgi?id=107139 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||160829 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160829 [Bug 160829] checkbox state ticked / unticked poorly visible in dark mode (Breeze icon theme) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160829] checkbox state ticked / unticked poorly visible in dark mode (Breeze icon theme)
https://bugs.documentfoundation.org/show_bug.cgi?id=160829 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|checkbox state ticked / |checkbox state ticked / |unticked poorly visible in |unticked poorly visible in |dark mode |dark mode (Breeze icon ||theme) Blocks|118017 |153293, 107139 Keywords||accessibility CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 OS|macOS (All) |All Status|UNCONFIRMED |NEW --- Comment #5 from Stéphane Guillou (stragu) --- Looks like it is specific to the Breeze (dark) icon theme. Not reproduced with other icon theme variants. Steve, can you please double-check that's correct? (You might need to restart LO to make extra sure the change of icon theme is registered, I have seen inconsistency in that.) I can reproduce on Linux, so not macOS-specific. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ad1f0bdeac30fca1dc56a08803ef23f2aca4db05 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107139 [Bug 107139] [META] Breeze icons https://bugs.documentfoundation.org/show_bug.cgi?id=118017 [Bug 118017] [META] macOS Dark Mode bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=153293 [Bug 153293] [META] Dark Mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118000] [META] Remote desktop related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118000 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||160839 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160839 [Bug 160839] "Recent Documents" file open menu items filenames from remote sources have %20 instead of spaces (URI entities not unquoted) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 61174] [META] Recent Documents List
https://bugs.documentfoundation.org/show_bug.cgi?id=61174 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||160839 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160839 [Bug 160839] "Recent Documents" file open menu items filenames from remote sources have %20 instead of spaces (URI entities not unquoted) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160839] "Recent Documents" file open menu items filenames from remote sources have %20 instead of spaces (URI entities not unquoted)
https://bugs.documentfoundation.org/show_bug.cgi?id=160839 Stéphane Guillou (stragu) changed: What|Removed |Added Priority|medium |low Blocks||61174, 118000 Whiteboard| QA:needsComment| Ever confirmed|0 |1 Severity|normal |minor Status|UNCONFIRMED |NEW CC||stephane.guillou@libreoffic ||e.org --- Comment #2 from Stéphane Guillou (stragu) --- Reproduced with: Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded (Flatpak or not, using WebDav) Also in 7.3.7.2 and a recent daily build. Window title not affected. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=61174 [Bug 61174] [META] Recent Documents List https://bugs.documentfoundation.org/show_bug.cgi?id=118000 [Bug 118000] [META] Remote desktop related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160846] Flathub Libreoffice (24.2.2.2) Failed to open display terminal message. Crashes seconds later
https://bugs.documentfoundation.org/show_bug.cgi?id=160846 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||stephane.guillou@libreoffic ||e.org Whiteboard| QA:needsComment| --- Comment #1 from Stéphane Guillou (stragu) --- Not reproduced with Flatpak version: Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Flatpak Calc: threaded Have you tried updating to 24.2.3? That's now the latest version of Flathub. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161035] Spinning wheel hang on MacOS when using the Zotero plugin.
https://bugs.documentfoundation.org/show_bug.cgi?id=161035 Patrick Luby (volunteer) changed: What|Removed |Added CC||guibomac...@gmail.com --- Comment #2 from Patrick Luby (volunteer) --- I don't know anything about Zotero, but my first guess is that LibreOffice is caught in a deadlock between two competing threads. Are you familiar with the Activity Monitor application on macOS? If yes, can you upload a sample of LibreOffice when it is hanging? If no, I can write some steps for you. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161048] Background processes are left opened by LO Dev Start Center on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 --- Comment #7 from ady --- I uninstalled LO Dev, manually searched for LibreOfficeDev in the registry and deleted every item I found (except those also related to the antivirus, because the antivirus itself does not allow me to perform such action). Between each step I also reboot the system. I did not use Revo. While re-installing LO Dev 2024-05-11, the original custom location (D:\LO\ALPHA\) was not recognized by default as it used to happen before. Instead, the default location (under program files) was offered as installation location. This was expected. I modified the installation location to be the same customized location as before. When I selected to personalized installation (not the "typical" radius option), the same custom options that I used before (with additional languages and dictionaries) were already selected. This was not expected, and it hints that some remnants were left-over from the normal uninstall procedure. For the purpose of this ticket, I am OK with this, but others might disagree. Launching the new soffice.exe adds 1 process to the Windows' Task Manager. Closing the Start Center leaves that first process and adds 1 more, leaving 2 left-over processes in the background. New processes are left over for every such launch-and-close steps. Once again I installed LO Dev built on an older date as before. Once again I do not have any left-overs. So, for now I will have to remain at this LO Dev date. Hopefully someone will be able to replicate the behavior and gather more info, or alternatively I might find where the problem is in this system. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161052] Color mistake (rows on color palette shifted?)
https://bugs.documentfoundation.org/show_bug.cgi?id=161052 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #2 from Regina Henschel --- I see no color difference when opening a file created by LO7.2 in a current daily build. Tested with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2b85bceca88ab119fff5cbdc41fe913435a479ca CPU threads: 32; OS: Windows 11 (10.0 build 22631); UI render: default; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158262] SVG generated by a handwriting tool shows "hollow"
https://bugs.documentfoundation.org/show_bug.cgi?id=158262 --- Comment #8 from Animus --- I just encountered this issue also in LibreOffice 24.2 This is a >> crucial << rendering issue, that currently defeats the benefits of SVGs e.g. with text in widely used Google Fonts (which contain path overlaps) converted to curves for compatibility. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160960] Conversion from PPT(X) to PDF via LibreOffice Headless distorts background color (gradient)
https://bugs.documentfoundation.org/show_bug.cgi?id=160960 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #4 from Regina Henschel --- Created attachment 194096 --> https://bugs.documentfoundation.org/attachment.cgi?id=194096=edit Compare 2-stop with 3-stop gradient in pptx The interpolation of a two-stop-color gradient is different to a three-stop-color gradient in MS Office even if the third stop is at the same place and has the same color as the start or end stop of the two-stop-color gradient. MS Office seems to use a somehow quadratic interpolation in the two-stops-color gradient case. Open attached document in PowerPoint. It has in the middle a rectangle with two-stop-color gradient and below it a rectangle with three-stop-color gradient. Above is a screenshot of the two rectangles as rendered in PowerPoint. Then open the file in LibreOffice. LibreOffice has only linear color interpolation, same as MS Office uses, if three or more stops are present. So when you want the color interpolation to be the same in LibreOffice as in MS Office, you have to use at least three color stops in MS Office. I have added a screenshot to the file, because MS Office does not export the two-stop-color interpolation the same way to png as it renders it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161043] CALC Error in SUBTOTAL(9;range) when the source values are minutes and seconds exceeding 60 minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=161043
--- Comment #9 from ady ---
(In reply to m_a_riosv from comment #8)
> For me Excel shows the same result as LibreOffice, for the attached sample
> file.
IIUC, I think that @Colin meant that (for him or in his system) Excel shows
cell D1 as 547:12:52 whereas Calc shows the same cell D1 as 12:52:00, without
having to modify the cell format of that specific cell ("MM:SS"). I don't see
the same as @Colin's claims.
In any case, I don't see a bug in the SUBTOTAL function in Calc.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 161053] the distance between first and second lines in paragraphs is smaller than others
https://bugs.documentfoundation.org/show_bug.cgi?id=161053 m_a_riosv changed: What|Removed |Added Keywords||regression Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW --- Comment #2 from m_a_riosv --- Seems it happens whet for the paragraph style, in this case 'Default..', has the line spacing as 'Proportional' in the 'Indents & Spacing' tab. Looks fine for other types. Maybe is there some other option creating the issue. Reproducible Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2b85bceca88ab119fff5cbdc41fe913435a479ca CPU threads: 16; OS: Windows 11 (10.0 build 22631); UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Of the versions I have installed. Last working for me Version 3.6.7.2 (Build ID: e183d5b) First showing the issue Version: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: es_ES -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161046] No substitute fonts when opening a file without the file's font installed locally
https://bugs.documentfoundation.org/show_bug.cgi?id=161046 --- Comment #2 from Jon --- Thank you for the link. However, the solutions there (of 8 or 9 years ago) don't seem to apply here. Yes, I could use the substitution table, but I'm looking at documents that do not consistently use a certain font. Also, the problem only occurred when moving from 7.6 to 24.2, not when there was a change in OS or as a result of a kernel or other update in Fedora 39. I observed the same behavior on two separate computers, both running Fedora 39, though I updated LibreOffice on them weeks apart from each other. -- You are receiving this mail because: You are the assignee for the bug.
OSS-fuzzing
Hello. I want to try to run oss-fuzz tests by myself, but i found no info about it. I found some scripts in the "bin" folder, like oss-fuzz-setup.sh and oss-fuzz-build.sh, and found that I should use clang, but I found nothing about the environment. I can build LibreOffice with clang, but if i run oss-fuzz-build, i get a lot of errors after postprocess step What environment should i use and how should i run fuzzing correctly? I use clang 15, LibreOffice builds successfully without fuzzing I get errors like this: /usr/lib/llvm-15/lib/clang/15.0.7/lib/linux/libclang_rt.fuzzer-x86_64.a(FuzzerDataFlowTrace.cpp.o):function fuzzer::BlockCoverage::AppendCoverage(std::istream&): error: undefined reference to 'VTT for std::__cxx11::basic_stringstream, std::allocator >' /usr/lib/llvm-15/lib/clang/15.0.7/lib/linux/libclang_rt.fuzzer-x86_64.a(FuzzerDataFlowTrace.cpp.o):function fuzzer::BlockCoverage::AppendCoverage(std::istream&): error: undefined reference to 'vtable for std::basic_ios >' /usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function /usr/lib/llvm-15/lib/clang/15.0.7/lib/linux/libclang_rt.fuzzer-x86_64.a(FuzzerDataFlowTrace.cpp.o):function fuzzer::BlockCoverage::AppendCoverage(std::istream&): error: undefined reference to 'vtable for std::basic_streambuf >'
[Bug 161053] the distance between first and second lines in paragraphs is smaller than others
https://bugs.documentfoundation.org/show_bug.cgi?id=161053 --- Comment #1 from ardv --- Created attachment 194095 --> https://bugs.documentfoundation.org/attachment.cgi?id=194095=edit example file -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161053] New: the distance between first and second lines in paragraphs is smaller than others
https://bugs.documentfoundation.org/show_bug.cgi?id=161053 Bug ID: 161053 Summary: the distance between first and second lines in paragraphs is smaller than others Product: LibreOffice Version: 24.2.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dz.wb...@gmail.com Description: when i write a paragraph in Arabic language and change the line spacing below 100% the the distance between the first and second lines in paragraphs is smaller than others. an example file is attached Steps to Reproduce: 1. a paragraph in Arabic language 2. change the paragraph line spacing below 100 percent Actual Results: space between 2 first line is smaller than others Expected Results: the space should be similar to other lines Reproducible: Always User Profile Reset: No Additional Info: make the lines spacing similar -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161048] Background processes are left opened by LO Dev Start Center on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 V Stuart Foote changed: What|Removed |Added CC||mikekagan...@hotmail.com --- Comment #6 from V Stuart Foote --- So went ahead and did an actual /i install of the TB77 nightly from 20240510. Custom to a named folder (C:\Program Files\LibreOfficeDev_24"), just the en-US dict and locale, no default document association, no quickstarter. Sorry, but still can't repro the zombie soffice.bin instance, opening and closing to Start Center. I get just one soffice.exe/soffice.bin pair, and both close cleanly on exit. I was curious about the MSI packaging. And should have logged the install (done via command line rather than GUI and adding a /L*v instLog.txt). Despite being an alpha+, not yet beta, I do see significant writes into Windows registry. But if I open the MSI in Orca, and the 'Property' table's -> WRITE_REGISTRY value is set to 0, and checked the Win registry for items that tested for that control. Did not see any, and no recent change to the Windows build solver: solenv/bin/modules/installer/windows/registry.pm To clean up between installs, you should be able to use the Win appwiz.cpl to remove the LODev cleanly, then use the Find command in regedit.exe to check for any left overs (look for "LibreOfficeDev"). Or for a more robust uninstall with a bit more aggressive registry cleanup, VSRevo Revo Uninstaller is my preferred tool. =-testing-= Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0ffdfb58a07e2a1b89a36bc241c6a2767e82cd2c CPU threads: 8; OS: Windows 10 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161021] LO hangs (endless loop) when footnote is on the wrong page
https://bugs.documentfoundation.org/show_bug.cgi?id=161021 Markus Grob changed: What|Removed |Added Hardware|x86-64 (AMD64) |All OS|Windows (All) |All --- Comment #6 from Markus Grob --- I have checked now with debug mode on OpenSuse. Same as on Windows. Because it runs into this function: SwTwips SwLayoutFrame::ShrinkFrame( SwTwips nDist, bool bTst, bool bInfo ) x times/second (defined in: wsfrm.cxx line 3084) it runs at 100% CPU time and doesn't react. It warns (in the background), that there are unknown properties and the bookmark is on the wrong page. The unknown properties are in lngprophelp.cxx line 636: unknown property 'HyphNoLastWord', unknown property 'HyphKeepType', unknown property 'HyphKeep' My problem is, that it doesn't tells me, where exactly in the document and why it happens. Maybe I could unzip and wipe it out manually or use the ooxml-viewer-vscode on github: https://github.com/yuenm18/ooxml-viewer-vscode Somebody any hints? At the moment I will find out, if LO runs through this function even if an empty document is open, but for this, I have to insert timestamps and recompile. Let's see, I never programmed c++ until now ;-) Sincerely, Markus -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158288] When you select part of a column with merged cells, all columns that are part of the merged cell are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=158288 Aron Budea changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #5 from Aron Budea --- Thinking about this, I'm not sure this should be considered a bug. There's a merged cell in the range, which means your selection isn't strictly within column A, but spans to column C. Excel also behaves the same way. Let's ask the UX team, can you please share your thoughts? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158288] When you select part of a column with merged cells, all columns that are part of the merged cell are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=158288 Aron Budea changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #5 from Aron Budea --- Thinking about this, I'm not sure this should be considered a bug. There's a merged cell in the range, which means your selection isn't strictly within column A, but spans to column C. Excel also behaves the same way. Let's ask the UX team, can you please share your thoughts? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 155796] Deselecting merged cells using Shift+⬆ doesn't work in some cases
https://bugs.documentfoundation.org/show_bug.cgi?id=155796 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8288 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158288] When you select part of a column with merged cells, all columns that are part of the merged cell are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=158288 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||5796 --- Comment #4 from Aron Budea --- (In reply to kdub from comment #3) > I was able to replicate this bug in Linux using this repository: > https://bibisect.libreoffice.org/linux-64-7.6 > > More information on the commit that caused this bug here: > https://git.libreoffice.org/core/commit/ > 39aa1f6424390821579bfb6b6ba14e9ce11040ce Let's the commit from the master branch (24.2) as well: https://cgit.freedesktop.org/libreoffice/core/commit/?id=341029de72cf957b7bc7775e51544070d4a49874 -- You are receiving this mail because: You are the assignee for the bug.
core.git: jvmfwk/source
jvmfwk/source/elements.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 0dcaff6043e1f24ce0fa354dff80a86e40622247
Author: Caolán McNamara
AuthorDate: Sun May 12 20:01:01 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun May 12 22:14:19 2024 +0200
WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: I6d1ea7e14f5d2a75d485dae69d51cec8c2343445
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167558
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/jvmfwk/source/elements.cxx b/jvmfwk/source/elements.cxx
index 00ad1d741667..447cb49ca2da 100644
--- a/jvmfwk/source/elements.cxx
+++ b/jvmfwk/source/elements.cxx
@@ -784,7 +784,7 @@ void CNodeJavaInfo::writeToNode(xmlDoc* pDoc,
xmlNode* pJavaInfoNode) const
{
-OSL_ASSERT(pJavaInfoNode && pDoc);
+assert(pJavaInfoNode && pDoc);
//write the attribute vendorSettings
//javaInfo@vendorUpdate
[Bug 161052] Color mistake (rows on color palette shifted?)
https://bugs.documentfoundation.org/show_bug.cgi?id=161052 --- Comment #1 from HunHKPK --- Created attachment 194094 --> https://bugs.documentfoundation.org/attachment.cgi?id=194094=edit Screenshot for explanation -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161052] New: Color mistake (rows on color palette shifted?)
https://bugs.documentfoundation.org/show_bug.cgi?id=161052 Bug ID: 161052 Summary: Color mistake (rows on color palette shifted?) Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lass...@freemail.hu Description: I have an older calc file, continuously edited. Some cells had light green background. Since version 7.3.7.2 these colors became "mustard". On color palette the rows seems to be shifted. Steps to Reproduce: 1.Update to 7.3.7.2 from older version. 2.Open in an older file which has light green colored cells. 3.You may see the color of mustard instead light green Actual Results: displayed color changed Expected Results: Restore the original color Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.7.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: hu-HU Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.4 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161051] New: Scrolling too fast and snappy while selecting text
https://bugs.documentfoundation.org/show_bug.cgi?id=161051 Bug ID: 161051 Summary: Scrolling too fast and snappy while selecting text Product: LibreOffice Version: 24.2.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: alessiomanfr...@gmail.com Description: While I select a portion of text, and maybe want to go down or up to select the text that I don’t see on the screen, the program makes me scroll through pages in a snappy way, not smooth and too fast, so as to prevent a detailed and precise selection of text. The problem arises only with libreoffice, so I rule out that it is a problem of settings of my pc or mouse. Steps to Reproduce: 1.Hold down the left mouse button to select text 2.While holding down and selecting text, move the mouse to the bottom or top of the screen Actual Results: pages scroll too fast and snappy Expected Results: pages should scroll more slowly and smoothly Reproducible: Always User Profile Reset: Yes Additional Info: Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 8; OS: Windows 10.0 Build 22635; UI render: Skia/Raster; VCL: win Locale: it-IT (it_IT); UI: it-IT Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: sd/source
sd/source/ui/dlg/tpoption.cxx |6 --
sd/source/ui/view/drviewsg.cxx |5 -
sd/source/ui/view/frmview.cxx |3 ++-
3 files changed, 10 insertions(+), 4 deletions(-)
New commits:
commit 3df9a50322dc9f24c87d0095316aadf1ad09ec3e
Author: Gabor Kelemen
AuthorDate: Fri May 3 11:41:49 2024 +0200
Commit: Gabor Kelemen
CommitDate: Sun May 12 21:18:01 2024 +0200
Use less SdOptionsSnapItem->IsSnapBorder/SetSnapBorder
in favor of officecfg
Change-Id: Iaa6801ef773de7d3dcb1f08d4eac4a4f62ac656b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167533
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen
diff --git a/sd/source/ui/dlg/tpoption.cxx b/sd/source/ui/dlg/tpoption.cxx
index 1a2bfee07646..2708d8d933fa 100644
--- a/sd/source/ui/dlg/tpoption.cxx
+++ b/sd/source/ui/dlg/tpoption.cxx
@@ -66,13 +66,14 @@ bool SdTpOptionsSnap::FillItemSet( SfxItemSet* rAttrs )
if (bDrawMode)
{
officecfg::Office::Draw::Snap::Object::SnapLine::set(
m_xCbxSnapHelplines->get_active(), batch );
+officecfg::Office::Draw::Snap::Object::PageMargin::set(
m_xCbxSnapBorder->get_active(), batch );
}
else
{
officecfg::Office::Impress::Snap::Object::SnapLine::set(
m_xCbxSnapHelplines->get_active(), batch );
+officecfg::Office::Impress::Snap::Object::PageMargin::set(
m_xCbxSnapBorder->get_active(), batch );
}
-aOptsItem.GetOptionsSnap().SetSnapBorder( m_xCbxSnapBorder->get_active() );
aOptsItem.GetOptionsSnap().SetSnapFrame( m_xCbxSnapFrame->get_active() );
aOptsItem.GetOptionsSnap().SetSnapPoints( m_xCbxSnapPoints->get_active() );
aOptsItem.GetOptionsSnap().SetOrtho( m_xCbxOrtho->get_active() );
@@ -100,10 +101,12 @@ void SdTpOptionsSnap::Reset( const SfxItemSet* rAttrs )
if (bDrawMode)
{
m_xCbxSnapHelplines->set_active(
officecfg::Office::Draw::Snap::Object::SnapLine::get() );
+m_xCbxSnapBorder->set_active(
officecfg::Office::Draw::Snap::Object::PageMargin::get() );
}
else
{
m_xCbxSnapHelplines->set_active(
officecfg::Office::Impress::Snap::Object::SnapLine::get() );
+m_xCbxSnapBorder->set_active(
officecfg::Office::Impress::Snap::Object::PageMargin::get() );
}
bool bReadOnly = bDrawMode ?
officecfg::Office::Draw::Snap::Object::SnapLine::isReadOnly() :
@@ -113,7 +116,6 @@ void SdTpOptionsSnap::Reset( const SfxItemSet* rAttrs )
bReadOnly = bDrawMode ?
officecfg::Office::Draw::Snap::Object::PageMargin::isReadOnly() :
officecfg::Office::Impress::Snap::Object::PageMargin::isReadOnly();
-m_xCbxSnapBorder->set_active( aOptsItem.GetOptionsSnap().IsSnapBorder() );
m_xCbxSnapBorder->set_sensitive(!bReadOnly);
m_xCbxSnapBorderImg->set_visible(bReadOnly);
diff --git a/sd/source/ui/view/drviewsg.cxx b/sd/source/ui/view/drviewsg.cxx
index e256ef926172..20a7814abbee 100644
--- a/sd/source/ui/view/drviewsg.cxx
+++ b/sd/source/ui/view/drviewsg.cxx
@@ -156,7 +156,10 @@ void DrawViewShell::ExecOptionsBar( SfxRequest& rReq )
case SID_SNAP_BORDER:
{
-pOptions->SetSnapBorder( !mpDrawView->IsBordSnap() );
+if ( GetDoc()->GetDocumentType() == DocumentType::Impress )
+officecfg::Office::Impress::Snap::Object::PageMargin::set(
!mpDrawView->IsBordSnap(), batch );
+else
+officecfg::Office::Draw::Snap::Object::PageMargin::set(
!mpDrawView->IsBordSnap(), batch );
}
break;
diff --git a/sd/source/ui/view/frmview.cxx b/sd/source/ui/view/frmview.cxx
index ad500cfb4eed..c252b6183a6a 100644
--- a/sd/source/ui/view/frmview.cxx
+++ b/sd/source/ui/view/frmview.cxx
@@ -287,6 +287,7 @@ void FrameView::Update(SdOptions const * pOptions)
if (bImpress)
{
mbRuler = officecfg::Office::Impress::Layout::Display::Ruler::get();
+SetBordSnap(
officecfg::Office::Impress::Snap::Object::PageMargin::get() );
SetDragStripes(
officecfg::Office::Impress::Layout::Display::Guide::get() );
SetHlplSnap( officecfg::Office::Impress::Snap::Object::SnapLine::get()
);
SetHlplVisible(
officecfg::Office::Impress::Layout::Display::Helpline::get() );
@@ -296,6 +297,7 @@ void FrameView::Update(SdOptions const * pOptions)
else
{
mbRuler = officecfg::Office::Draw::Layout::Display::Ruler::get();
+SetBordSnap( officecfg::Office::Draw::Snap::Object::PageMargin::get()
);
SetDragStripes( officecfg::Office::Draw::Layout::Display::Guide::get()
);
SetHlplSnap( officecfg::Office::Draw::Snap::Object::SnapLine::get() );
SetHlplVisible(
officecfg::Office::Draw::Layout::Display::Helpline::get() );
@@ -306,7 +308,6 @@ void FrameView::Update(SdOptions const * pOptions)
SetGridVisible( pOptions->IsGridVisible() );
SetSnapAngle( pOptions->GetAngle() );
SetGridSnap( pOptions->IsUseGridSnap() );
-SetBordSnap( pOptions->IsSnapBorder() );
[Bug 161007] Report Builder Wizard fails
https://bugs.documentfoundation.org/show_bug.cgi?id=161007 --- Comment #4 from Andreas Säger --- (In reply to mc from comment #3) > Hi, after pressing 5 times the Next button, next step appear > > > Version: 24.2.3.2 (X86_64) / LibreOffice Community > Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba > CPU threads: 12; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: > win > Locale: it-IT (it_IT); UI: it-IT > Calc: CL threaded For me, it jumps to the last step without filling any controls into the document. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161007] Report Builder Wizard fails
https://bugs.documentfoundation.org/show_bug.cgi?id=161007 --- Comment #3 from mc --- Hi, after pressing 5 times the Next button, next step appear Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 12; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: it-IT (it_IT); UI: it-IT Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: jvmfwk/plugins jvmfwk/source
jvmfwk/plugins/sunmajor/pluginlib/util.cxx |1 +
jvmfwk/source/elements.cxx |2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
New commits:
commit c79a48a75f7f44b5a042109251e185fc4695cde6
Author: Caolán McNamara
AuthorDate: Sun May 12 18:41:16 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun May 12 21:00:09 2024 +0200
WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: Ica8b3c8c5476f2f0f3bebf0cfcd80b08090c6119
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167556
Reviewed-by: Caolán McNamara
Tested-by: Jenkins
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
index 1610188f55ac..21258af12944 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
@@ -539,6 +539,7 @@ static bool getJavaInfoFromRegistry(const wchar_t* szRegKey,
if( RegQueryValueExW(hKey, L"JavaHome", nullptr, ,
nullptr, )== ERROR_SUCCESS)
{
unsigned char* szTmpPath= static_cast(malloc(dwTmpPathLen+sizeof(sal_Unicode)));
+assert(szTmpPath && "Don't handle OOM conditions");
// According to https://msdn.microsoft.com/en-us/ms724911,
the application should ensure
// that the string is properly terminated before using it
for (DWORD i = 0; i < sizeof(sal_Unicode); ++i)
diff --git a/jvmfwk/source/elements.cxx b/jvmfwk/source/elements.cxx
index d47af20f2e4b..00ad1d741667 100644
--- a/jvmfwk/source/elements.cxx
+++ b/jvmfwk/source/elements.cxx
@@ -683,7 +683,7 @@ void CNodeJavaInfo::loadFromNode(xmlDoc * pDoc, xmlNode *
pJavaInfo)
OString sExcMsg("[Java framework] Error in function
NodeJavaInfo::loadFromNode "
"(elements.cxx)."_ostr);
-OSL_ASSERT(pJavaInfo && pDoc);
+assert(pJavaInfo && pDoc);
if (pJavaInfo->children == nullptr)
return;
//Get the xsi:nil attribute;
[Bug 159348] Highlight cell does not repaint on when window is maximized
https://bugs.documentfoundation.org/show_bug.cgi?id=159348 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #4 from BogdanB --- Also in Version: 24.2.3.1 (X86_64) / LibreOffice Community Build ID: fc604d5980a783e74808a001f1918a603d920494 CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99746] [META] PDF import filter in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=99746 BogdanB changed: What|Removed |Added Depends on||160885 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160885 [Bug 160885] Libreoffice draw improper handling of texts in pdf with highlights -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160885] Libreoffice draw improper handling of texts in pdf with highlights
https://bugs.documentfoundation.org/show_bug.cgi?id=160885 BogdanB changed: What|Removed |Added Blocks||99746 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99746 [Bug 99746] [META] PDF import filter in Draw -- You are receiving this mail because: You are the assignee for the bug.
core.git: vcl/unx
vcl/unx/gtk3/a11y/atktextattributes.cxx | 64
1 file changed, 32 insertions(+), 32 deletions(-)
New commits:
commit 24b178cfb6b35789e69d80857e73e911abe338a3
Author: Noel Grandin
AuthorDate: Thu May 9 11:48:34 2024 +0200
Commit: Noel Grandin
CommitDate: Sun May 12 20:26:23 2024 +0200
createFromAscii -> OUString literals in attribute_set_map_to_property_values
Change-Id: I98f40cba9baf2a21d095af84a07cd794723cb75d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167552
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/unx/gtk3/a11y/atktextattributes.cxx
b/vcl/unx/gtk3/a11y/atktextattributes.cxx
index d34d0a3d9860..7f3e5a23ce1e 100644
--- a/vcl/unx/gtk3/a11y/atktextattributes.cxx
+++ b/vcl/unx/gtk3/a11y/atktextattributes.cxx
@@ -1306,42 +1306,42 @@ namespace {
struct AtkTextAttrMapping
{
-const char * name;
-TextPropertyValueFunc const toPropertyValue;
+OUString name;
+TextPropertyValueFunc toPropertyValue;
};
}
-const AtkTextAttrMapping g_TextAttrMap[] =
+constexpr AtkTextAttrMapping g_TextAttrMap[]
{
-{ "", InvalidValue }, // ATK_TEXT_ATTR_INVALID = 0
-{ "ParaLeftMargin", UnitString2CMM }, // ATK_TEXT_ATTR_LEFT_MARGIN
-{ "ParaRightMargin", UnitString2CMM }, // ATK_TEXT_ATTR_RIGHT_MARGIN
-{ "ParaFirstLineIndent", UnitString2CMM }, // ATK_TEXT_ATTR_INDENT
-{ "CharHidden", String2Bool }, // ATK_TEXT_ATTR_INVISIBLE
-{ "", InvalidValue }, // ATK_TEXT_ATTR_EDITABLE
-{ "ParaTopMargin", UnitString2CMM },//
ATK_TEXT_ATTR_PIXELS_ABOVE_LINES
-{ "ParaBottomMargin", UnitString2CMM }, //
ATK_TEXT_ATTR_PIXELS_BELOW_LINES
-{ "", InvalidValue }, //
ATK_TEXT_ATTR_PIXELS_INSIDE_WRAP
-{ "", InvalidValue }, // ATK_TEXT_ATTR_BG_FULL_HEIGHT
-{ "", InvalidValue }, // ATK_TEXT_ATTR_RISE
-{ "CharUnderline", String2Underline }, // ATK_TEXT_ATTR_UNDERLINE
-{ "CharStrikeout", String2Strikeout }, // ATK_TEXT_ATTR_STRIKETHROUGH
-{ "CharHeight", String2Float }, // ATK_TEXT_ATTR_SIZE
-{ "CharScaleWidth", String2Scale }, // ATK_TEXT_ATTR_SCALE
-{ "CharWeight", String2Weight },// ATK_TEXT_ATTR_WEIGHT
-{ "CharLocale", String2Locale },// ATK_TEXT_ATTR_LANGUAGE
-{ "CharFontName", SetString }, // ATK_TEXT_ATTR_FAMILY_NAME
-{ "CharBackColor", String2Color }, // ATK_TEXT_ATTR_BG_COLOR
-{ "CharColor", String2Color }, // ATK_TEXT_ATTR_FG_COLOR
-{ "", InvalidValue }, // ATK_TEXT_ATTR_BG_STIPPLE
-{ "", InvalidValue }, // ATK_TEXT_ATTR_FG_STIPPLE
-{ "", InvalidValue }, // ATK_TEXT_ATTR_WRAP_MODE
-{ "", InvalidValue }, // ATK_TEXT_ATTR_DIRECTION
-{ "ParaAdjust", Justification2Adjust }, // ATK_TEXT_ATTR_JUSTIFICATION
-{ "", InvalidValue }, // ATK_TEXT_ATTR_STRETCH
-{ "CharCaseMap", String2CaseMap }, // ATK_TEXT_ATTR_VARIANT
-{ "CharPosture", Style2FontSlant } // ATK_TEXT_ATTR_STYLE
+{ u""_ustr, InvalidValue }, // ATK_TEXT_ATTR_INVALID
= 0
+{ u"ParaLeftMargin"_ustr, UnitString2CMM }, //
ATK_TEXT_ATTR_LEFT_MARGIN
+{ u"ParaRightMargin"_ustr, UnitString2CMM }, //
ATK_TEXT_ATTR_RIGHT_MARGIN
+{ u"ParaFirstLineIndent"_ustr, UnitString2CMM }, // ATK_TEXT_ATTR_INDENT
+{ u"CharHidden"_ustr, String2Bool }, //
ATK_TEXT_ATTR_INVISIBLE
+{ u""_ustr, InvalidValue }, // ATK_TEXT_ATTR_EDITABLE
+{ u"ParaTopMargin"_ustr, UnitString2CMM },//
ATK_TEXT_ATTR_PIXELS_ABOVE_LINES
+{ u"ParaBottomMargin"_ustr, UnitString2CMM }, //
ATK_TEXT_ATTR_PIXELS_BELOW_LINES
+{ u""_ustr, InvalidValue }, //
ATK_TEXT_ATTR_PIXELS_INSIDE_WRAP
+{ u""_ustr, InvalidValue }, //
ATK_TEXT_ATTR_BG_FULL_HEIGHT
+{ u""_ustr, InvalidValue }, // ATK_TEXT_ATTR_RISE
+{ u"CharUnderline"_ustr, String2Underline }, //
ATK_TEXT_ATTR_UNDERLINE
+{ u"CharStrikeout"_ustr, String2Strikeout }, //
ATK_TEXT_ATTR_STRIKETHROUGH
+{ u"CharHeight"_ustr, String2Float }, // ATK_TEXT_ATTR_SIZE
+{ u"CharScaleWidth"_ustr, String2Scale }, // ATK_TEXT_ATTR_SCALE
+{ u"CharWeight"_ustr, String2Weight },// ATK_TEXT_ATTR_WEIGHT
+{ u"CharLocale"_ustr, String2Locale },// ATK_TEXT_ATTR_LANGUAGE
+{ u"CharFontName"_ustr, SetString }, //
ATK_TEXT_ATTR_FAMILY_NAME
+{ u"CharBackColor"_ustr, String2Color }, // ATK_TEXT_ATTR_BG_COLOR
+{ u"CharColor"_ustr, String2Color }, // ATK_TEXT_ATTR_FG_COLOR
+{ u""_ustr,
core.git: 2 commits - vcl/inc vcl/source
vcl/inc/graphic/GraphicFormatDetector.hxx | 64 +-
vcl/source/filter/FilterConfigCache.cxx | 106 +++---
vcl/source/filter/FilterConfigCache.hxx |2
3 files changed, 85 insertions(+), 87 deletions(-)
New commits:
commit 8701b4fd4ea9a006c97207bd542dd072f6a92b41
Author: Noel Grandin
AuthorDate: Thu May 9 11:44:06 2024 +0200
Commit: Noel Grandin
CommitDate: Sun May 12 20:26:08 2024 +0200
replace createFromAscii with OUString literals in FilterConfigCache
Change-Id: I31a16e4b709955cb01d6aebaf169d40f71f7ea09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167551
Reviewed-by: Noel Grandin
Tested-by: Jenkins
diff --git a/vcl/source/filter/FilterConfigCache.cxx
b/vcl/source/filter/FilterConfigCache.cxx
index 85020ec607a4..56541992dc5d 100644
--- a/vcl/source/filter/FilterConfigCache.cxx
+++ b/vcl/source/filter/FilterConfigCache.cxx
@@ -192,66 +192,66 @@ void FilterConfigCache::ImplInit()
}
};
-const char* FilterConfigCache::InternalFilterListForSvxLight[] =
-{
-"bmp","1","SVBMP",
-"bmp","2","SVBMP",
-"dxf","1","SVDXF",
-"eps","1","SVIEPS",
-"eps","2","SVEEPS",
-"gif","1","SVIGIF",
-"gif","2","SVEGIF",
-"jpg","1","SVIJPEG",
-"jpg","2","SVEJPEG",
-"mov","1","SVMOV",
-"mov","2","SVMOV",
-"met","1","SVMET",
-"png","1","SVIPNG",
-"png","2","SVEPNG",
-"pct","1","SVPICT",
-"pcd","1","SVPCD",
-"psd","1","SVPSD",
-"pcx","1","SVPCX",
-"pbm","1","SVPBM",
-"pgm","1","SVPBM",
-"ppm","1","SVPBM",
-"ras","1","SVRAS",
-"svm","1","SVMETAFILE",
-"svm","2","SVMETAFILE",
-"tga","1","SVTGA",
-"tif","1","SVTIFF",
-"tif","2","SVTIFF",
-"emf","1","SVEMF",
-"emf","2","SVEMF",
-"wmf","1","SVWMF",
-"wmf","2","SVWMF",
-"xbm","1","SVIXBM",
-"xpm","1","SVIXPM",
-"svg","1","SVISVG",
-"svg","2","SVESVG",
-"webp","1","SVIWEBP",
-"webp","2","SVEWEBP",
-nullptr
+namespace {
+struct FilterEntry
+{
+OUString sExtension;
+sal_Int32 nFlags;
+OUString sUserData;
+};
+}
+constexpr FilterEntry InternalFilterListForSvxLight[]
+{
+{ u"bmp"_ustr, 1, u"SVBMP"_ustr },
+{ u"bmp"_ustr, 2, u"SVBMP"_ustr },
+{ u"dxf"_ustr, 1, u"SVDXF"_ustr },
+{ u"eps"_ustr, 1, u"SVIEPS"_ustr },
+{ u"eps"_ustr, 2, u"SVEEPS"_ustr },
+{ u"gif"_ustr, 1, u"SVIGIF"_ustr },
+{ u"gif"_ustr, 2, u"SVEGIF"_ustr },
+{ u"jpg"_ustr, 1, u"SVIJPEG"_ustr },
+{ u"jpg"_ustr, 2, u"SVEJPEG"_ustr },
+{ u"mov"_ustr, 1, u"SVMOV"_ustr },
+{ u"mov"_ustr, 2, u"SVMOV"_ustr },
+{ u"met"_ustr, 1, u"SVMET"_ustr },
+{ u"png"_ustr, 1, u"SVIPNG"_ustr },
+{ u"png"_ustr, 2, u"SVEPNG"_ustr },
+{ u"pct"_ustr, 1, u"SVPICT"_ustr },
+{ u"pcd"_ustr, 1, u"SVPCD"_ustr },
+{ u"psd"_ustr, 1, u"SVPSD"_ustr },
+{ u"pcx"_ustr, 1, u"SVPCX"_ustr },
+{ u"pbm"_ustr, 1, u"SVPBM"_ustr },
+{ u"pgm"_ustr, 1, u"SVPBM"_ustr },
+{ u"ppm"_ustr, 1, u"SVPBM"_ustr },
+{ u"ras"_ustr, 1, u"SVRAS"_ustr },
+{ u"svm"_ustr, 1, u"SVMETAFILE"_ustr },
+{ u"svm"_ustr, 2, u"SVMETAFILE"_ustr },
+{ u"tga"_ustr, 1, u"SVTGA"_ustr },
+{ u"tif"_ustr, 1, u"SVTIFF"_ustr },
+{ u"tif"_ustr, 2, u"SVTIFF"_ustr },
+{ u"emf"_ustr, 1, u"SVEMF"_ustr },
+{ u"emf"_ustr, 2, u"SVEMF"_ustr },
+{ u"wmf"_ustr, 1, u"SVWMF"_ustr },
+{ u"wmf"_ustr, 2, u"SVWMF"_ustr },
+{ u"xbm"_ustr, 1, u"SVIXBM"_ustr },
+{ u"xpm"_ustr, 1, u"SVIXPM"_ustr },
+{ u"svg"_ustr, 1, u"SVISVG"_ustr },
+{ u"svg"_ustr, 2, u"SVESVG"_ustr },
+{ u"webp"_ustr, 1, u"SVIWEBP"_ustr },
+{ u"webp"_ustr, 2, u"SVEWEBP"_ustr },
};
void FilterConfigCache::ImplInitSmart()
{
-const char** pPtr;
-for ( pPtr = InternalFilterListForSvxLight; *pPtr; pPtr++ )
+for ( const FilterEntry& rEntry : InternalFilterListForSvxLight )
{
FilterConfigCacheEntry aEntry;
-OUStringsExtension( OUString::createFromAscii( *pPtr++ ) );
-
-aEntry.lExtensionList.push_back(sExtension);
-
-aEntry.sType = sExtension;
-aEntry.sUIName = sExtension;
-
-aEntry.nFlags = o3tl::toInt32(std::string_view(*pPtr++));
-
-OUStringsUserData( OUString::createFromAscii( *pPtr ) );
-aEntry.CreateFilterName( sUserData );
+aEntry.lExtensionList.push_back(rEntry.sExtension);
+aEntry.sType = rEntry.sExtension;
+aEntry.sUIName = rEntry.sExtension;
+aEntry.nFlags = rEntry.nFlags;
+aEntry.CreateFilterName( rEntry.sUserData );
if ( aEntry.nFlags & 1 )
aImport.push_back( aEntry );
diff --git a/vcl/source/filter/FilterConfigCache.hxx
b/vcl/source/filter/FilterConfigCache.hxx
index 95e52d80ecaf..84830283b11d 100644
--- a/vcl/source/filter/FilterConfigCache.hxx
+++ b/vcl/source/filter/FilterConfigCache.hxx
@@ -51,8 +51,6 @@ class FilterConfigCache
std::vector< FilterConfigCacheEntry > aImport;
[Bug 112128] [META] Cell edit mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112128 BogdanB changed: What|Removed |Added Depends on||160908 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160908 [Bug 160908] "Edit cell background highlight" -- You are receiving this mail because: You are the assignee for the bug.
[Bug 153293] [META] Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=153293 BogdanB changed: What|Removed |Added Depends on||159121 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159121 [Bug 159121] MS word highlighting is not displayed correctly in dark mode -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159121] MS word highlighting is not displayed correctly in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159121 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||153293 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153293 [Bug 153293] [META] Dark Mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 113363] [META] DOCX (OOXML) content control-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113363 BogdanB changed: What|Removed |Added Depends on||158661 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158661 [Bug 158661] FILEOPEN: DOCX: extra character in block SDT -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158661] FILEOPEN: DOCX: extra character in block SDT
https://bugs.documentfoundation.org/show_bug.cgi?id=158661 BogdanB changed: What|Removed |Added Blocks||113363 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113363 [Bug 113363] [META] DOCX (OOXML) content control-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104522] [META] DOCX (OOXML) header & footer-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104522 BogdanB changed: What|Removed |Added Depends on||159013 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159013 [Bug 159013] FILEOPEN: DOCX: first page is duplicated on page 2 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159013] FILEOPEN: DOCX: first page is duplicated on page 2
https://bugs.documentfoundation.org/show_bug.cgi?id=159013 BogdanB changed: What|Removed |Added Blocks||104522 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104522 [Bug 104522] [META] DOCX (OOXML) header & footer-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107331] [META] Document themes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107331 BogdanB changed: What|Removed |Added Depends on||159479 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159479 [Bug 159479] FILESAVE: DOCX: Connectors in SmartArt are lost in MSO -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159479] FILESAVE: DOCX: Connectors in SmartArt are lost in MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=159479 BogdanB changed: What|Removed |Added Blocks||107331 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107331 [Bug 107331] [META] Document themes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160545] LO Writer not saving hyperlink in docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=160545 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||125611 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125611 [Bug 125611] [META] DOCX (OOXML) Hyperlink-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 125611] [META] DOCX (OOXML) Hyperlink-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=125611 BogdanB changed: What|Removed |Added Depends on||160545 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160545 [Bug 160545] LO Writer not saving hyperlink in docx file -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103152 BogdanB changed: What|Removed |Added Depends on||160571 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160571 [Bug 160571] FILEOPEN: Cropped SVG in .docx file (from winword) is rendered uncropped in Writer -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160571] FILEOPEN: Cropped SVG in .docx file (from winword) is rendered uncropped in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=160571 BogdanB changed: What|Removed |Added Blocks||103152 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103152 [Bug 103152] [META] Writer image bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 BogdanB changed: What|Removed |Added Depends on||160713 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160713 [Bug 160713] DOCX: Merged cells or spans are lost when the document has complex tables -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160713] DOCX: Merged cells or spans are lost when the document has complex tables
https://bugs.documentfoundation.org/show_bug.cgi?id=160713 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||103100 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160840] Crash on libuno_sal.so.3 when saving document on DOCX (Word 2007-365)
https://bugs.documentfoundation.org/show_bug.cgi?id=160840 BogdanB changed: What|Removed |Added Blocks||104520 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104520 [Bug 104520] [META] DOCX (OOXML) bug tracker -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104520 BogdanB changed: What|Removed |Added Depends on||160840 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160840 [Bug 160840] Crash on libuno_sal.so.3 when saving document on DOCX (Word 2007-365) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161023] FILESAVE: ODP: Incorrect spacing in list
https://bugs.documentfoundation.org/show_bug.cgi?id=161023 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #3 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/167557 -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - dbaccess/source sc/source sfx2/source svx/source xmlsecurity/source
dbaccess/source/ui/misc/TableCopyHelper.cxx |2 +-
dbaccess/source/ui/misc/asyncmodaldialog.cxx|2 +-
sc/source/ui/app/scmod.cxx |2 +-
sfx2/source/control/shell.cxx |2 +-
svx/source/form/fmshimp.cxx |2 +-
xmlsecurity/source/framework/saxeventkeeperimpl.cxx |1 +
6 files changed, 6 insertions(+), 5 deletions(-)
New commits:
commit 0025c300d6e952a4252fb3bdb7b4b91d1f7e59ec
Author: Caolán McNamara
AuthorDate: Sun May 12 14:24:17 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun May 12 19:39:10 2024 +0200
cid#1597307 silence Unchecked return value
and
cid#1597304 Unchecked return value
cid#1597303 Unchecked return value
cid#1597306 Unchecked return value
cid#1597305 Unchecked return value
Change-Id: I2fa1c467751405d3b69f1d9b552232e4d52b610e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167554
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/dbaccess/source/ui/misc/TableCopyHelper.cxx
b/dbaccess/source/ui/misc/TableCopyHelper.cxx
index ca2ef2a4d7ba..75be554a1cd1 100644
--- a/dbaccess/source/ui/misc/TableCopyHelper.cxx
+++ b/dbaccess/source/ui/misc/TableCopyHelper.cxx
@@ -107,7 +107,7 @@ void OTableCopyHelper::insertTable( std::u16string_view
i_rSourceDataSource, con
bool bAppendToExisting = !sTableNameForAppend.isEmpty();
xWizard->setOperation( bAppendToExisting ?
CopyTableOperation::AppendData : CopyTableOperation::CopyDefinitionAndData );
-xWizard->execute();
+(void)xWizard->execute();
}
catch( const SQLException& )
{
diff --git a/dbaccess/source/ui/misc/asyncmodaldialog.cxx
b/dbaccess/source/ui/misc/asyncmodaldialog.cxx
index 8323d47dba6f..2c7db57be16e 100644
--- a/dbaccess/source/ui/misc/asyncmodaldialog.cxx
+++ b/dbaccess/source/ui/misc/asyncmodaldialog.cxx
@@ -65,7 +65,7 @@ namespace dbaui
{
try
{
-m_xDialog->execute();
+(void)m_xDialog->execute();
}
catch( const Exception& )
{
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 50d71a589182..b06e3385cea1 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -532,7 +532,7 @@ void ScModule::Execute( SfxRequest& rReq )
try
{
css::uno::Reference < css::ui::dialogs::XExecutableDialog >
xDialog = css::ui::dialogs::XSLTFilterDialog::create(
::comphelper::getProcessComponentContext());
-xDialog->execute();
+(void)xDialog->execute();
}
catch( css::uno::RuntimeException& )
{
diff --git a/sfx2/source/control/shell.cxx b/sfx2/source/control/shell.cxx
index f368d3d2824d..f87fbb7d8282 100644
--- a/sfx2/source/control/shell.cxx
+++ b/sfx2/source/control/shell.cxx
@@ -281,7 +281,7 @@ void SfxShell::HandleOpenXmlFilterSettings(SfxRequest &
rReq)
try
{
uno::Reference < ui::dialogs::XExecutableDialog > xDialog =
ui::dialogs::XSLTFilterDialog::create(
::comphelper::getProcessComponentContext() );
-xDialog->execute();
+(void)xDialog->execute();
}
catch (const uno::Exception&)
{
diff --git a/svx/source/form/fmshimp.cxx b/svx/source/form/fmshimp.cxx
index 86798c8a85c7..f16511f29cc0 100644
--- a/svx/source/form/fmshimp.cxx
+++ b/svx/source/form/fmshimp.cxx
@@ -1391,7 +1391,7 @@ void FmXFormShell::ExecuteTabOrderDialog_Lock(const
Referenceexecute();
+(void)xDialog->execute();
}
catch( const Exception& )
{
commit 970ee1d96cedef06a65997e40bf4d0402347fadd
Author: Caolán McNamara
AuthorDate: Sun May 12 12:57:51 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun May 12 19:39:01 2024 +0200
WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: I19824cd8fdc3ac5b5afb4e769527bf71513212fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167553
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx
b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx
index fe6c0ed915d9..b490e24327d3 100644
--- a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx
+++ b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx
@@ -625,6 +625,7 @@ void SAXEventKeeperImpl::releaseElementMarkBuffer()
* Delete the TH from the buffer node.
*/
BufferNode *pBufferNode = pElementMark->getBufferNode();
+assert(pBufferNode);
pBufferNode->setBlocker(nullptr);
/*
[Bug 161043] CALC Error in SUBTOTAL(9;range) when the source values are minutes and seconds exceeding 60 minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=161043 --- Comment #8 from m_a_riosv --- Created attachment 194093 --> https://bugs.documentfoundation.org/attachment.cgi?id=194093=edit Screenshot LibreOffice vs Excel For me Excel shows the same result as LibreOffice, for the attached sample file. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161048] Background processes are left opened by LO Dev Start Center on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #5 from m_a_riosv --- I can not reproduce with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2b85bceca88ab119fff5cbdc41fe913435a479ca CPU threads: 16; OS: Windows 11 (10.0 build 22631); UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161046] No substitute fonts when opening a file without the file's font installed locally
https://bugs.documentfoundation.org/show_bug.cgi?id=161046 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Please take a look at https://ask.libreoffice.org/t/an-option-like-missing-font-substitution/11053 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161048] Background processes are left opened by LO Dev Start Center on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 ady changed: What|Removed |Added Summary|Background processes are|Background processes are |left opened by LO Dev |left opened by LO Dev Start |install on Windows |Center on Windows -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148174] FILEOPEN DOCX Ref field incorrect with "Paragraph # in full context" and "Relative position of paragraph" enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148174 --- Comment #3 from Dieter --- Still present in Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148173] FILEOPEN DOCX Ref field incorrect with "Paragraph # from marked paragraph" and "Relative position of paragraph" enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148173 --- Comment #3 from Dieter --- Still present in Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148171] FILEOPEN DOCX PageRef field with "Position of paragraph" option incorrectly imported
https://bugs.documentfoundation.org/show_bug.cgi?id=148171 --- Comment #3 from Dieter --- Still present in Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160690] Animated GIF completely invisible in Edit mode (GIF has alpha-transparency)
https://bugs.documentfoundation.org/show_bug.cgi?id=160690 Patrick Luby (volunteer) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |guibomac...@gmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #9 from Patrick Luby (volunteer) --- I think I found the cause: GIF images with color palettes of 16 colors or less need additional handling. I have a fix (see following debug patch) but I need to do more testing before I submit it to make sure it doesn't cause tdf#157635 or tdf#157793 to reoccur: diff --git a/vcl/source/filter/igif/gifread.cxx b/vcl/source/filter/igif/gifread.cxx index c3151f3274d0..6c3deb4da3d0 100644 --- a/vcl/source/filter/igif/gifread.cxx +++ b/vcl/source/filter/igif/gifread.cxx @@ -683,10 +683,10 @@ void GIFReader::CreateNewBitmaps() // Due to the switch from transparency to alpha in commit // 81994cb2b8b32453a92bcb011830fcb884f22ff3, mask out black // pixels in bitmap. -if (bEnhance) -aAnimationFrame.maBitmapEx = BitmapEx( aBmp8, aBmp8 ); -else -aAnimationFrame.maBitmapEx = BitmapEx( aBmp8 ); +Bitmap aAlphaMask( aBmp8 ); +if (!bEnhance) +aAlphaMask.Invert(); +aAnimationFrame.maBitmapEx = BitmapEx( aBmp8, aAlphaMask ); } aAnimationFrame.maPositionPixel = Point( nImagePosX, nImagePosY ); -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161048] Background processes are left opened by LO Dev install on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 --- Comment #4 from ady --- (In reply to V Stuart Foote from comment #3) > If you want to install/test like that, what I'd suggest is to clear the per > user profile that links to you D:\LO\Alpha\program used in your custom > installs. Even though install is to your D: drive, your user profile is > going to be C:\Users\\AppData\Roaming\LibreOfficeDev. Delete > it to clear the profile (on next launch that will recreate with defaults. I have "reset" my LO Dev profile, but I have not manually deleted anything in C:\Users\\AppData\Roaming\LibreOfficeDev. I'd like to ask you, what should I manually delete, specifically, and what not? Additionally, should I delete anything using regedit.exe? FWIW, I have been installing and using LO Dev as I described, for more than a year, with several updates per month. The left-overs processes in Windows' Task Manager are new, and I cannot replicate the problem when going back to the build from 2024-04-30. So maybe the "/a" installation method overcomes or avoids the problem, whereas the "common" installation method allows the problem to be triggered. If this happens to be true, then at some point the "common" install method will arrive to the Stable branch (e.g. when 24.8 becomes Stable Fresh), and then users will report the same problem. My point is that perhaps the "common" installation should be tested now with LO Dev 24.8 in order to test whether the left-overs of soffice.exe can be replicated, after launching and closing the LO Dev Start Center several times. -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - sc/source test/source
sc/source/ui/app/inputhdl.cxx|9 -
sc/source/ui/docshell/docsh5.cxx |9 -
test/source/diff/diff.cxx|2 ++
test/source/xmltesttools.cxx |6 ++
4 files changed, 24 insertions(+), 2 deletions(-)
New commits:
commit 034eb5078096d146fb5c5e6246a407f2aad09094
Author: Caolán McNamara
AuthorDate: Sun May 12 12:52:14 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun May 12 17:21:40 2024 +0200
help msvc -analyzer out wrt C6011 Dereferencing NULL pointer
Change-Id: Ied22e4ea805ab5a94f89a71438962bdd6d118771
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167548
Reviewed-by: Caolán McNamara
Tested-by: Jenkins
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index 6dd8315e7b4e..1c1aaf06963d 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -4227,6 +4227,13 @@ void ScInputHandler::InputCommand( const CommandEvent&
rCEvt )
}
}
+static ScInputHdlState* getLastState(const ScInputHdlState* pState)
+{
+if (!pState)
+return nullptr;
+return new ScInputHdlState(*pState);
+}
+
void ScInputHandler::NotifyChange( const ScInputHdlState* pState,
bool bForce, ScTabViewShell* pSourceSh,
bool bStopEditing)
@@ -4260,7 +4267,7 @@ void ScInputHandler::NotifyChange( const ScInputHdlState*
pState,
if ( pState != pLastState.get() )
{
-pLastState.reset( pState ? new ScInputHdlState( *pState ) : nullptr);
+pLastState.reset(getLastState(pState));
}
if ( pState && pActiveViewSh )
diff --git a/sc/source/ui/docshell/docsh5.cxx b/sc/source/ui/docshell/docsh5.cxx
index 63bb94408eba..1b2ddf216b9f 100644
--- a/sc/source/ui/docshell/docsh5.cxx
+++ b/sc/source/ui/docshell/docsh5.cxx
@@ -508,6 +508,13 @@ static OUString lcl_GetAreaName( ScDocument* pDoc, const
ScArea* pArea )
return aName;
}
+static ScDBData* getUndoData(ScDBData* pDestData)
+{
+if (!pDestData)
+return nullptr;
+return new ScDBData(*pDestData);
+}
+
void ScDocShell::DoConsolidate( const ScConsolidateParam& rParam, bool bRecord
)
{
ScConsData aData;
@@ -568,7 +575,7 @@ void ScDocShell::DoConsolidate( const ScConsolidateParam&
rParam, bool bRecord )
aData.GetSize( nColSize, nRowSize );
if (bRecord && nColSize > 0 && nRowSize > 0)
{
-std::unique_ptr pUndoData(pDestData ? new
ScDBData(*pDestData) : nullptr);
+std::unique_ptr pUndoData(getUndoData(pDestData));
SCTAB nDestTab = rParam.nTab;
ScArea aDestArea( rParam.nTab, rParam.nCol, rParam.nRow,
commit 512e28bf8d10f9246df2d535f92c1ccef1628192
Author: Caolán McNamara
AuthorDate: Sun May 12 12:00:27 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun May 12 17:21:32 2024 +0200
WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: I7a4df11c23a92d0c5538cea4290dcc5e2c9ac3c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167547
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/test/source/diff/diff.cxx b/test/source/diff/diff.cxx
index 097452665308..dac6c1e4ed01 100644
--- a/test/source/diff/diff.cxx
+++ b/test/source/diff/diff.cxx
@@ -284,6 +284,8 @@ bool compareValuesWithTolerance(double val1, double val2,
double tolerance, bool
bool XMLDiff::compareAttributes(xmlNodePtr node1, xmlNodePtr node2)
{
+CPPUNIT_ASSERT(node1);
+CPPUNIT_ASSERT(node2);
xmlAttrPtr attr1 = nullptr;
xmlAttrPtr attr2 = nullptr;
for(attr1 = node1->properties, attr2 = node2->properties; attr1 != nullptr
&& attr2 != nullptr; attr1 = attr1->next, attr2 = attr2->next)
diff --git a/test/source/xmltesttools.cxx b/test/source/xmltesttools.cxx
index b0e4cf48e989..22fa266a966d 100644
--- a/test/source/xmltesttools.cxx
+++ b/test/source/xmltesttools.cxx
@@ -92,6 +92,7 @@ OUString XmlTestTools::getXPath(const xmlDocUniquePtr&
pXmlDoc, const OString& r
xmlXPathObjectPtr pXmlObj = getXPathNode(pXmlDoc, rXPath);
CPPUNIT_ASSERT(pXmlObj);
xmlNodeSetPtr pXmlNodes = pXmlObj->nodesetval;
+CPPUNIT_ASSERT(pXmlNodes);
CPPUNIT_ASSERT_EQUAL_MESSAGE(OString(OString::Concat("In <") +
pXmlDoc->name + ">, XPath '" + rXPath + "' number of nodes is
incorrect").getStr(),
1, xmlXPathNodeSetGetLength(pXmlNodes));
CPPUNIT_ASSERT(!rAttribute.isEmpty());
@@ -240,6 +241,7 @@ void XmlTestTools::assertXPathChildren(const
xmlDocUniquePtr& pXmlDoc, const OSt
#if LIBXML_VERSION >= 20703 /* xmlChildElementCount is only available in
libxml2 >= 2.7.3 */
xmlXPathObjectPtr pXmlObj = getXPathNode(pXmlDoc, rXPath);
xmlNodeSetPtr pXmlNodes = pXmlObj->nodesetval;
+CPPUNIT_ASSERT(pXmlNodes);
CPPUNIT_ASSERT_EQUAL_MESSAGE(OString(OString::Concat("In <") +
pXmlDoc->name + ">, XPath '" + rXPath + "' number of nodes is
incorrect").getStr(),
1,
core.git: 2 commits - include/unotools svx/source unotools/source
include/unotools/configvaluecontainer.hxx |8 +-
svx/source/form/fmsrccfg.cxx| 70
unotools/source/config/configvaluecontainer.cxx |8 +-
unotools/source/config/fontcfg.cxx | 52 -
4 files changed, 69 insertions(+), 69 deletions(-)
New commits:
commit cb08b5e8617ea7b278eef0acc0606585b294e1db
Author: Noel Grandin
AuthorDate: Thu May 9 11:31:33 2024 +0200
Commit: Noel Grandin
CommitDate: Sun May 12 17:01:23 2024 +0200
replace createFromAscii with OUString literals in DefaultFontConfiguration
Change-Id: I550a9a2c069b43cc8824d3b26736f656393a5afb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167546
Reviewed-by: Noel Grandin
Tested-by: Jenkins
diff --git a/unotools/source/config/fontcfg.cxx
b/unotools/source/config/fontcfg.cxx
index 14bfb646fb75..a9b1556fbbea 100644
--- a/unotools/source/config/fontcfg.cxx
+++ b/unotools/source/config/fontcfg.cxx
@@ -48,36 +48,36 @@ using namespace com::sun::star::configuration;
* DefaultFontConfiguration
*/
-static const char* getKeyType( DefaultFontType nKeyType )
+static OUString getKeyType( DefaultFontType nKeyType )
{
switch( nKeyType )
{
-case DefaultFontType::CJK_DISPLAY: return "CJK_DISPLAY";
-case DefaultFontType::CJK_HEADING: return "CJK_HEADING";
-case DefaultFontType::CJK_PRESENTATION: return "CJK_PRESENTATION";
-case DefaultFontType::CJK_SPREADSHEET: return "CJK_SPREADSHEET";
-case DefaultFontType::CJK_TEXT: return "CJK_TEXT";
-case DefaultFontType::CTL_DISPLAY: return "CTL_DISPLAY";
-case DefaultFontType::CTL_HEADING: return "CTL_HEADING";
-case DefaultFontType::CTL_PRESENTATION: return "CTL_PRESENTATION";
-case DefaultFontType::CTL_SPREADSHEET: return "CTL_SPREADSHEET";
-case DefaultFontType::CTL_TEXT: return "CTL_TEXT";
-case DefaultFontType::FIXED: return "FIXED";
-case DefaultFontType::LATIN_DISPLAY: return "LATIN_DISPLAY";
-case DefaultFontType::LATIN_FIXED: return "LATIN_FIXED";
-case DefaultFontType::LATIN_HEADING: return "LATIN_HEADING";
-case DefaultFontType::LATIN_PRESENTATION: return "LATIN_PRESENTATION";
-case DefaultFontType::LATIN_SPREADSHEET: return "LATIN_SPREADSHEET";
-case DefaultFontType::LATIN_TEXT: return "LATIN_TEXT";
-case DefaultFontType::SANS: return "SANS";
-case DefaultFontType::SANS_UNICODE: return "SANS_UNICODE";
-case DefaultFontType::SERIF: return "SERIF";
-case DefaultFontType::SYMBOL: return "SYMBOL";
-case DefaultFontType::UI_FIXED: return "UI_FIXED";
-case DefaultFontType::UI_SANS: return "UI_SANS";
+case DefaultFontType::CJK_DISPLAY: return u"CJK_DISPLAY"_ustr;
+case DefaultFontType::CJK_HEADING: return u"CJK_HEADING"_ustr;
+case DefaultFontType::CJK_PRESENTATION: return u"CJK_PRESENTATION"_ustr;
+case DefaultFontType::CJK_SPREADSHEET: return u"CJK_SPREADSHEET"_ustr;
+case DefaultFontType::CJK_TEXT: return u"CJK_TEXT"_ustr;
+case DefaultFontType::CTL_DISPLAY: return u"CTL_DISPLAY"_ustr;
+case DefaultFontType::CTL_HEADING: return u"CTL_HEADING"_ustr;
+case DefaultFontType::CTL_PRESENTATION: return u"CTL_PRESENTATION"_ustr;
+case DefaultFontType::CTL_SPREADSHEET: return u"CTL_SPREADSHEET"_ustr;
+case DefaultFontType::CTL_TEXT: return u"CTL_TEXT"_ustr;
+case DefaultFontType::FIXED: return u"FIXED"_ustr;
+case DefaultFontType::LATIN_DISPLAY: return u"LATIN_DISPLAY"_ustr;
+case DefaultFontType::LATIN_FIXED: return u"LATIN_FIXED"_ustr;
+case DefaultFontType::LATIN_HEADING: return u"LATIN_HEADING"_ustr;
+case DefaultFontType::LATIN_PRESENTATION: return
u"LATIN_PRESENTATION"_ustr;
+case DefaultFontType::LATIN_SPREADSHEET: return u"LATIN_SPREADSHEET"_ustr;
+case DefaultFontType::LATIN_TEXT: return u"LATIN_TEXT"_ustr;
+case DefaultFontType::SANS: return u"SANS"_ustr;
+case DefaultFontType::SANS_UNICODE: return u"SANS_UNICODE"_ustr;
+case DefaultFontType::SERIF: return u"SERIF"_ustr;
+case DefaultFontType::SYMBOL: return u"SYMBOL"_ustr;
+case DefaultFontType::UI_FIXED: return u"UI_FIXED"_ustr;
+case DefaultFontType::UI_SANS: return u"UI_SANS"_ustr;
default:
OSL_FAIL( "unmatched type" );
-return "";
+return u""_ustr;
}
}
@@ -188,7 +188,7 @@ OUString DefaultFontConfiguration::tryLocale( const
OUString& rBcp47, const OUSt
OUString DefaultFontConfiguration::getDefaultFont( const LanguageTag&
rLanguageTag, DefaultFontType nType ) const
{
-OUString aType = OUString::createFromAscii( getKeyType( nType ) );
+OUString aType = getKeyType( nType );
// Try the simple cases first without constructing fallbacks.
OUString aRet = tryLocale( rLanguageTag.getBcp47(), aType );
if (aRet.isEmpty())
commit bd77596dd8e3f6d3660ce5b096d8160502e13a70
Author: Noel Grandin
AuthorDate: Wed May 8 21:57:45 2024 +0200
Commit: Noel Grandin
CommitDate: Sun May
core.git: 2 commits - svx/source tools/source
svx/source/tbxctrls/tbcontrl.cxx | 21 +++---
tools/source/fsys/urlobj.cxx | 124 +++
2 files changed, 72 insertions(+), 73 deletions(-)
New commits:
commit 8b075d020ce25cff28a12fabad69d8677f7b8f2d
Author: Noel Grandin
AuthorDate: Wed May 8 21:50:58 2024 +0200
Commit: Noel Grandin
CommitDate: Sun May 12 17:01:06 2024 +0200
replace createFromAscii with OUString literals in INetURLObject
Change-Id: Ibad8181624afd745e2fa501cdcc7a5d915dfe6ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167544
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index 611a14145dde..a962682863aa 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -308,8 +308,8 @@ struct INetURLObject::PrefixInfo
{
enum class Kind { Official, Internal, External }; // order is important!
-char const * m_pPrefix;
-char const * m_pTranslatedPrefix;
+OUString m_aPrefix;
+OUString m_aTranslatedPrefix;
INetProtocol m_eScheme;
Kind m_eKind;
};
@@ -745,11 +745,11 @@ bool INetURLObject::setAbsURIRef(std::u16string_view
rTheAbsURIRef,
pPos = p;
m_eScheme = pPrefix->m_eScheme;
-char const * pTemp = pPrefix->m_eKind >= PrefixInfo::Kind::External ?
- pPrefix->m_pTranslatedPrefix :
- pPrefix->m_pPrefix;
-m_aAbsURIRef.appendAscii(pTemp);
-m_aScheme = SubString( 0, strstr(pTemp, ":") - pTemp );
+const OUString & rTemp = pPrefix->m_eKind >=
PrefixInfo::Kind::External ?
+ pPrefix->m_aTranslatedPrefix :
+ pPrefix->m_aPrefix;
+m_aAbsURIRef.append(rTemp);
+m_aScheme = SubString( 0, rTemp.indexOf(':') );
}
else
{
@@ -2152,7 +2152,7 @@ bool INetURLObject::convertIntToExt(std::u16string_view
rTheIntURIRef,
if (bConvert)
{
comphelper::string::replaceAt(aSynExtURIRef, 0, p - pBegin,
-OUString::createFromAscii(pPrefix->m_pTranslatedPrefix));
+pPrefix->m_aTranslatedPrefix);
}
rTheExtURIRef = decode(aSynExtURIRef, eDecodeMechanism, eCharset);
return bConvert;
@@ -2175,7 +2175,7 @@ bool INetURLObject::convertExtToInt(std::u16string_view
rTheExtURIRef,
if (bConvert)
{
comphelper::string::replaceAt(aSynIntURIRef, 0, p - pBegin,
-OUString::createFromAscii(pPrefix->m_pTranslatedPrefix));
+pPrefix->m_aTranslatedPrefix);
}
rTheIntURIRef = decode(aSynIntURIRef, eDecodeMechanism, eCharset);
return bConvert;
@@ -2185,83 +2185,83 @@ bool INetURLObject::convertExtToInt(std::u16string_view
rTheExtURIRef,
INetURLObject::PrefixInfo const * INetURLObject::getPrefix(sal_Unicode const
*& rBegin,
sal_Unicode const *
pEnd)
{
-static PrefixInfo const aMap[]
-= { // dummy entry at front needed, because pLast may point here:
-{ nullptr, nullptr, INetProtocol::NotValid,
PrefixInfo::Kind::Internal },
-{ ".component:", "staroffice.component:", INetProtocol::Component,
+static PrefixInfo constexpr aMap[]
+ { // dummy entry at front needed, because pLast may point here:
+{ u""_ustr, u""_ustr, INetProtocol::NotValid,
PrefixInfo::Kind::Internal },
+{ u".component:"_ustr, u"staroffice.component:"_ustr,
INetProtocol::Component,
PrefixInfo::Kind::Internal },
-{ ".uno:", "staroffice.uno:", INetProtocol::Uno,
+{ u".uno:"_ustr, u"staroffice.uno:"_ustr, INetProtocol::Uno,
PrefixInfo::Kind::Internal },
-{ "cid:", nullptr, INetProtocol::Cid, PrefixInfo::Kind::Official },
-{ "data:", nullptr, INetProtocol::Data, PrefixInfo::Kind::Official
},
-{ "db:", "staroffice.db:", INetProtocol::Db,
PrefixInfo::Kind::Internal },
-{ "file:", nullptr, INetProtocol::File, PrefixInfo::Kind::Official
},
-{ "ftp:", nullptr, INetProtocol::Ftp, PrefixInfo::Kind::Official },
-{ "hid:", "staroffice.hid:", INetProtocol::Hid,
+{ u"cid:"_ustr, u""_ustr, INetProtocol::Cid,
PrefixInfo::Kind::Official },
+{ u"data:"_ustr, u""_ustr, INetProtocol::Data,
PrefixInfo::Kind::Official },
+{ u"db:"_ustr, u"staroffice.db:"_ustr, INetProtocol::Db,
PrefixInfo::Kind::Internal },
+{ u"file:"_ustr, u""_ustr, INetProtocol::File,
PrefixInfo::Kind::Official },
+{ u"ftp:"_ustr, u""_ustr, INetProtocol::Ftp,
PrefixInfo::Kind::Official },
+{ u"hid:"_ustr, u"staroffice.hid:"_ustr, INetProtocol::Hid,
PrefixInfo::Kind::Internal },
-{ "http:", nullptr, INetProtocol::Http,
[Bug 160690] Animated GIF completely invisible in Edit mode (GIF has alpha-transparency)
https://bugs.documentfoundation.org/show_bug.cgi?id=160690
--- Comment #8 from Patrick Luby (volunteer) ---
If I apply the following debug patch, on macOS this bug no longer occurs in the
document window, printing, or export to PDF. Unfortunately, this swapping of
code that create alpha masks cause tdf#156630 to reoccur so there must to
something different between the animated images. I will continue debugging and
post again when I have some news:
diff --git a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
index d756e6e3b74f..03cecb5c6a7e 100644
--- a/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
+++ b/drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
@@ -180,12 +180,12 @@ namespace drawinglayer::primitive2d
BitmapEx bitmap;
if( useAlphaMask )
{
-const AlphaMask
aMaskBitmap(maVirtualDeviceMask->GetBitmap(Point(),
maVirtualDeviceMask->GetOutputSizePixel()));
+const Bitmap
aMaskBitmap(maVirtualDeviceMask->GetBitmap(Point(),
maVirtualDeviceMask->GetOutputSizePixel()));
bitmap = BitmapEx(aMainBitmap, aMaskBitmap);
}
else
{
-Bitmap aMaskBitmap(maVirtualDeviceMask->GetBitmap(Point(),
maVirtualDeviceMask->GetOutputSizePixel()));
+AlphaMask
aMaskBitmap(maVirtualDeviceMask->GetBitmap(Point(),
maVirtualDeviceMask->GetOutputSizePixel()));
// tdf#156630 invert the alpha mask
aMaskBitmap.Invert(); // convert from transparency to
alpha
bitmap = BitmapEx(aMainBitmap, aMaskBitmap);
--
You are receiving this mail because:
You are the assignee for the bug.
