[PUSHED] enable binary package option for a set of 'stable' libraries

2013-08-17 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4765

Approvals:
  LibreOffice gerrit bot: Verified
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4765
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8924ba22d178aa4d8e500ae3f484af654a37e87e
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] enable binary package option for a set of 'stable' libraries

2013-08-16 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Thorsten Behrens,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/4765

to look at the new patch set (#2).

Change subject: enable binary package option for a set of 'stable' libraries
..

enable binary package option for a set of 'stable' libraries

Change-Id: I8924ba22d178aa4d8e500ae3f484af654a37e87e
---
M apache-commons/Module_apache-commons.mk
M apache-commons/UnpackedTarball_apache_commons_httpclient.mk
M apache-commons/UnpackedTarball_apache_commons_lang.mk
M apache-commons/UnpackedTarball_apache_commons_logging.mk
M beanshell/UnpackedTarball_beanshell.mk
M cairo/UnpackedTarball_cairo.mk
M cairo/UnpackedTarball_pixman.mk
M cppunit/UnpackedTarball_cppunit.mk
M curl/UnpackedTarball_curl.mk
M epm/UnpackedTarball_epm.mk
M fontconfig/UnpackedTarball_fontconfig.mk
M freetype/UnpackedTarball_freetype.mk
M harfbuzz/UnpackedTarball_harfbuzz.mk
M hsqldb/UnpackedTarball_hsqldb.mk
M liblangtag/UnpackedTarball_langtag.mk
M libxml2/UnpackedTarball_xml2.mk
M libxmlsec/UnpackedTarball_xmlsec.mk
M openldap/UnpackedTarball_openldap.mk
M openssl/UnpackedTarball_openssl.mk
M poppler/UnpackedTarball_poppler.mk
M postgresql/UnpackedTarball_postgresql.mk
M python3/UnpackedTarball_python3.mk
M redland/UnpackedTarball_raptor.mk
M redland/UnpackedTarball_rasqal.mk
M redland/UnpackedTarball_redland.mk
M rhino/UnpackedTarball_rhino.mk
M tomcat/UnpackedTarball_tomcat.mk
27 files changed, 28 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/4765/2
-- 
To view, visit https://gerrit.libreoffice.org/4765
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8924ba22d178aa4d8e500ae3f484af654a37e87e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] add french QA list to CC, also fix Reply-To address

2013-06-24 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4471

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4471
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43e6e804024125f17822a993f587a8422b69c1e8
Gerrit-PatchSet: 3
Gerrit-Project: dev-tools
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] migrate check_index test from Java to Python

2013-06-17 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4310

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4310
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5080cb0c3ca4b28d197137407da0d5f5b3d6c6d7
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Xiaoli Duan duan19002...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Delete unused sal tests

2013-06-17 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4326

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/4326/1

Delete unused sal tests

Change-Id: Iba1eeb8d8fd0582f216b7552dc9ae21b69e66b4e
---
D sal/qa/rtl_strings/export.exp
D sal/qa/rtl_strings/readme.txt
D sal/qa/rtl_strings/rtl_OString.cxx
D sal/qa/rtl_strings/rtl_OUString.cxx
D sal/qa/rtl_strings/rtl_OUStringBuffer.cxx
D sal/qa/rtl_strings/rtl_String_Const.h
D sal/qa/rtl_strings/rtl_String_Utils.cxx
D sal/qa/rtl_strings/rtl_String_Utils.hxx
D sal/qa/rtl_strings/rtl_String_Utils_Const.h
D sal/qa/rtl_strings/rtl_old_testostring.cxx
D sal/qa/rtl_strings/rtl_old_testowstring.cxx
D sal/qa/rtl_strings/rtl_old_teststrbuf.cxx
12 files changed, 0 insertions(+), 10,038 deletions(-)




-- 
To view, visit https://gerrit.libreoffice.org/4326
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba1eeb8d8fd0582f216b7552dc9ae21b69e66b4e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Migrate CheckFields unit test to python

2013-06-15 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4294

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/4294/1

Migrate CheckFields unit test to python

Change-Id: Ia765b37888b4095a735015e792f06fc89201d1a3
---
M solenv/gbuild/PythonTest.mk
M sw/PythonTest_sw_python.mk
A sw/qa/python/check_fields.py
M unotest/source/python/org/libreoffice/unotest.py
4 files changed, 61 insertions(+), 0 deletions(-)



diff --git a/solenv/gbuild/PythonTest.mk b/solenv/gbuild/PythonTest.mk
index eaa8757..012d642 100644
--- a/solenv/gbuild/PythonTest.mk
+++ b/solenv/gbuild/PythonTest.mk
@@ -40,6 +40,7 @@
($(gb_PythonTest_PRECOMMAND) \
$(if $(G_SLICE),G_SLICE=$(G_SLICE)) \
$(if 
$(GLIBCXX_FORCE_NEW),GLIBCXX_FORCE_NEW=$(GLIBCXX_FORCE_NEW)) \
+   $(DEFS) \

URE_BOOTSTRAP=vnd.sun.star.pathname:$(gb_DEVINSTALLROOT)/program/fundamentalrc \
PYTHONPATH=$(PYPATH) \
UserInstallation=$(call 
gb_Helper_make_url,$(OUTDIR)/unittest) \
@@ -60,6 +61,11 @@
 
 $(eval $(call gb_Module_register_target,$(call 
gb_PythonTest_get_target,$(1)),$(call gb_PythonTest_get_clean_target,$(1
 $(call gb_Helper_make_userfriendly_targets,$(1),PythonTest)
+
+endef
+
+define gb_PythonTest_set_defs
+$(call gb_PythonTest_get_target,$(1)) : DEFS := $(2)
 
 endef
 
@@ -94,6 +100,7 @@
 
 endef
 
+gb_PythonTest_set_defs :=
 gb_PythonTest_add_modules :=
 gb_PythonTest_use_customtarget :=
 
diff --git a/sw/PythonTest_sw_python.mk b/sw/PythonTest_sw_python.mk
index cbddfc5..ecf57ba 100644
--- a/sw/PythonTest_sw_python.mk
+++ b/sw/PythonTest_sw_python.mk
@@ -9,7 +9,12 @@
 
 $(eval $(call gb_PythonTest_PythonTest,sw_python))
 
+$(eval $(call gb_PythonTest_set_defs,sw_python,\
+TDOC=$(SRCDIR)/sw/qa/complex/writer/testdocuments \
+))
+
 $(eval $(call gb_PythonTest_add_modules,sw_python,$(SRCDIR)/sw/qa/python,\
+   check_fields \
get_expression \
set_expression \
var_fields \
diff --git a/sw/qa/python/check_fields.py b/sw/qa/python/check_fields.py
new file mode 100644
index 000..180ae8f
--- /dev/null
+++ b/sw/qa/python/check_fields.py
@@ -0,0 +1,32 @@
+import unittest
+from org.libreoffice.unotest import UnoInProcess
+
+class CheckFields(unittest.TestCase):
+_uno = None
+_xDoc = None
+
+@classmethod
+def setUpClass(cls):
+cls._uno = UnoInProcess()
+cls._uno.setUp()
+cls._xDoc = cls._uno.openWriterTemplateDoc(fdo39694.ott)
+
+@classmethod
+def tearDownClass(cls):
+cls._uno.tearDown()
+
+def test_fdo39694_load(self):
+placeholders = [Kadr1, Kadr2, Kadr3, Kadr4, 
Pnname, Pvname, Pgeboren]
+xDoc = self.__class__._xDoc
+xEnumerationAccess = xDoc.getTextFields()
+xFieldEnum = xEnumerationAccess.createEnumeration()
+while xFieldEnum.hasMoreElements():
+xField = xFieldEnum.nextElement()
+if xField.supportsService(com.sun.star.text.TextField.JumpEdit):
+xAnchor = xField.getAnchor()
+readContent = xAnchor.getString()
+self.assertTrue(readContent in placeholders,
+field %s not contained % readContent)
+
+if __name__ == '__main__':
+unittest.main()
diff --git a/unotest/source/python/org/libreoffice/unotest.py 
b/unotest/source/python/org/libreoffice/unotest.py
index 3ec016a..883d3a4 100644
--- a/unotest/source/python/org/libreoffice/unotest.py
+++ b/unotest/source/python/org/libreoffice/unotest.py
@@ -31,6 +31,11 @@
 print(  URE_BOOTSTRAP=file:///installation/opt/program/fundamentalrc)
 raise
 
+try:
+from urllib.parse import quote
+except ImportError:
+from urllib import quote
+
 ### utilities ###
 
 def mkPropertyValue(name, value):
@@ -181,6 +186,18 @@
 assert(self.xDoc)
 return self.xDoc
 
+def openWriterTemplateDoc(self, file):
+assert(self.xContext)
+smgr = self.getContext().ServiceManager
+desktop = smgr.createInstanceWithContext(com.sun.star.frame.Desktop, 
self.getContext())
+props = [(Hidden, True), (ReadOnly, False), (AsTemplate, True)]
+loadProps = tuple([mkPropertyValue(name, value) for (name, value) in 
props])
+path = os.getenv(TDOC)
+url = file:// + quote(path) + / + quote(file)
+self.xDoc = desktop.loadComponentFromURL(url, _blank, 0, loadProps)
+assert(self.xDoc)
+return self.xDoc
+
 def checkProperties(self, obj, dict, test):
 for k,v in dict.items():
 obj.setPropertyValue(k, v)

-- 
To view, visit https://gerrit.libreoffice.org/4294
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia765b37888b4095a735015e792f06fc89201d1a3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de


[ABANDONED] fix python unit test invocation for MSVC

2013-05-23 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change.

Change subject: fix python unit test invocation for MSVC
..


Patch Set 1: Abandoned

-- 
To view, visit https://gerrit.libreoffice.org/3728
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib6836e7609e0c268f91b04a8ca8618a15dfdae82
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED] selectively disable applications from the suite

2013-05-22 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change.

Change subject: selectively disable applications from the suite
..


Patch Set 4: Abandoned

there are problems with tests with this approach

-- 
To view, visit https://gerrit.libreoffice.org/2778
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I7141f0bdedb398eca7f31a1d5c66f009056f4d23
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Markus Mohrhard markus.mohrh...@googlemail.com
Gerrit-Reviewer: Michael Meeks michael.me...@suse.com
Gerrit-Reviewer: Riccardo Magliocchetti riccardo.magliocche...@gmail.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fix python unit test invocation for MSVC

2013-05-01 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3728

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/3728/1

fix python unit test invocation for MSVC

Change-Id: Ib6836e7609e0c268f91b04a8ca8618a15dfdae82
---
M solenv/gbuild/platform/com_MSC_class.mk
M sw/Module_sw.mk
2 files changed, 4 insertions(+), 8 deletions(-)



diff --git a/solenv/gbuild/platform/com_MSC_class.mk 
b/solenv/gbuild/platform/com_MSC_class.mk
old mode 100644
new mode 100755
index 83d5d45..a9a2e81
--- a/solenv/gbuild/platform/com_MSC_class.mk
+++ b/solenv/gbuild/platform/com_MSC_class.mk
@@ -453,11 +453,6 @@
 
 endef
 
-# PythonTest class
-
-#TODO:
-gb_PythonTest_PRECOMMAND :=
-
 # SrsPartTarget class
 
 ifeq ($(gb_FULLDEPS),$(true))
@@ -598,6 +593,9 @@
 
 # Python
 gb_Python_PRECOMMAND := PATH=$(shell cygpath -w $(INSTDIR)/program);$(shell 
cygpath -w $(OUTDIR)/bin) 
PYTHONHOME=$(INSTDIR)/program/python-core-$(PYTHON_VERSION) 
PYTHONPATH=$(INSTDIR)/program/python-core-$(PYTHON_VERSION)/lib;$(INSTDIR)/program/python-core-$(PYTHON_VERSION)/lib/lib-dynload:$(INSTDIR)/program
-gb_Python_INSTALLED_EXECUTABLE := $(gb_DEVINSTALLROOT)/program/python.exe
+
+gb_Python_INSTALLED_EXECUTABLE := 
$(INSTDIR)/program/python-core-$(PYTHON_VERSION)/bin/python.exe
+
+gb_PythonTest_PRECOMMAND := $(gb_Python_PRECOMMAND)
 
 # vim: set noet sw=4:
diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index 202c67c..7048d8e 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -72,11 +72,9 @@
 endif
 
 ifneq ($(DISABLE_PYTHON),TRUE)
-ifneq ($(OS),WNT)
 $(eval $(call gb_Module_add_subsequentcheck_targets,sw,\
PythonTest_sw_python \
 ))
-endif
 endif
 
 # vim: set noet sw=4 ts=4:

-- 
To view, visit https://gerrit.libreoffice.org/3728
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6836e7609e0c268f91b04a8ca8618a15dfdae82
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fix WaE with system libhunspell

2013-04-26 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3618

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/3618/1

fix WaE with system libhunspell

Change-Id: I6d943136ef189a57bc5fa95530c76b0226ba874d
---
M RepositoryExternal.mk
1 file changed, 7 insertions(+), 1 deletion(-)



diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 322e914..2db87ca 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -518,10 +518,16 @@
 
 ifeq ($(SYSTEM_HUNSPELL),YES)
 
+#
+# Workaround to use system libhunspell with enabled werror:
+# OpenSUSE 12.3
+# hunspell-devel-1.3.2-12.1.1.x86_64
+# /usr/include/hunspell/hunvisapi.h
+# #elif BUILDING_LIBHUNSPELL  1
 define gb_LinkTarget__use_hunspell
 $(call gb_LinkTarget_set_include,$(1),\
$$(INCLUDE) \
-   $(HUNSPELL_CFLAGS) \
+   $(HUNSPELL_CFLAGS) -DBUILDING_LIBHUNSPELL=0 \
 )
 $(call gb_LinkTarget_add_libs,$(1),$(HUNSPELL_LIBS))
 

-- 
To view, visit https://gerrit.libreoffice.org/3618
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d943136ef189a57bc5fa95530c76b0226ba874d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[RESTORED] selectively disable applications from the suite

2013-04-22 Thread David Ostrovsky (via Code Review)
David Ostrovsky has restored this change.

Change subject: selectively disable applications from the suite
..


Patch Set 1: Restored

-- 
To view, visit https://gerrit.libreoffice.org/2778
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I7141f0bdedb398eca7f31a1d5c66f009056f4d23
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Michael Meeks michael.me...@suse.com
Gerrit-Reviewer: Riccardo Magliocchetti riccardo.magliocche...@gmail.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] clean up PythonTests

2013-04-19 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3478

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3478/1

clean up PythonTests

Change-Id: I8dc937df02efb686bf19d6606b9b42b6f0abf742
---
M sw/Module_sw.mk
R sw/PythonTest_sw_python.mk
M sw/qa/python/get_expression.py
M sw/qa/python/set_expression.py
M unotest/source/python/org/libreoffice/unotest.py
5 files changed, 23 insertions(+), 35 deletions(-)



diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index fedb44a..651ac52 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -72,7 +72,7 @@
 
 ifneq ($(DISABLE_PYTHON),TRUE)
 $(eval $(call gb_Module_add_subsequentcheck_targets,sw,\
-   PythonTest_sw_unoapi \
+   PythonTest_sw_python \
 ))
 endif
 
diff --git a/sw/PythonTest_sw_unoapi.mk b/sw/PythonTest_sw_python.mk
similarity index 81%
rename from sw/PythonTest_sw_unoapi.mk
rename to sw/PythonTest_sw_python.mk
index 20c6549..2b4132c 100644
--- a/sw/PythonTest_sw_unoapi.mk
+++ b/sw/PythonTest_sw_python.mk
@@ -7,15 +7,15 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_PythonTest_PythonTest,sw_unoapi))
+$(eval $(call gb_PythonTest_PythonTest,sw_python))
 
-$(eval $(call gb_PythonTest_use_configuration,sw_unoapi))
+$(eval $(call gb_PythonTest_use_configuration,sw_python))
 
-$(eval $(call gb_PythonTest_use_api,sw_unoapi,offapi))
+$(eval $(call gb_PythonTest_use_api,sw_python,offapi))
 
-# FAIL: this brings in GconfBackend $(eval $(call 
gb_PythonTest_use_rdb,sw_unoapi,services))
+# FAIL: this brings in GconfBackend $(eval $(call 
gb_PythonTest_use_rdb,sw_python,services))
 
-$(eval $(call gb_PythonTest_use_components,sw_unoapi,\
+$(eval $(call gb_PythonTest_use_components,sw_python,\
 basic/util/sb \
 comphelper/util/comphelp \
 configmgr/source/configmgr \
@@ -48,7 +48,7 @@
 unoxml/source/service/unoxml \
 ))
 
-$(eval $(call gb_PythonTest_add_classes,sw_unoapi,\
+$(eval $(call gb_PythonTest_add_classes,sw_python,\
 $(SRCDIR)/sw/qa/python/set_expression.py \
 $(SRCDIR)/sw/qa/python/get_expression.py \
 ))
diff --git a/sw/qa/python/get_expression.py b/sw/qa/python/get_expression.py
index 5ac49f8..089aa2d 100644
--- a/sw/qa/python/get_expression.py
+++ b/sw/qa/python/get_expression.py
@@ -1,22 +1,22 @@
 import unittest
-from org.libreoffice.unotest import UnoNotConnection as UnoConnection
+from org.libreoffice.unotest import UnoInProcess
 
 class TestGetExpression(unittest.TestCase):
-_unoCon = None
+_uno = None
 _xDoc = None
 
 @classmethod
 def setUpClass(cls):
-cls._unoCon = UnoConnection({})
-cls._unoCon.setUp()
-cls._xDoc = cls._unoCon.openEmptyWriterDoc()
+cls._uno = UnoInProcess()
+cls._uno.setUp()
+cls._xDoc = cls._uno.openEmptyWriterDoc()
 
 @classmethod
 def tearDownClass(cls):
-cls._unoCon.tearDown()
+cls._uno.tearDown()
 
 def test_get_expression(self):
-self.__class__._unoCon.checkProperties(
+self.__class__._uno.checkProperties(
 
self.__class__._xDoc.createInstance(com.sun.star.text.textfield.GetExpression),
 {Content: foo,
  CurrentPresentation: bar,
@@ -32,21 +32,11 @@
 # property 'Value' is read only?
 @unittest.expectedFailure
 def test_get_expression_veto_read_only(self):
-self.__class__._unoCon.checkProperties(
+self.__class__._uno.checkProperties(
 
self.__class__._xDoc.createInstance(com.sun.star.text.textfield.GetExpression),
 {Value: 0.0},
 self
 )
-
-# property 'NumberingType' is unknown?
-@unittest.expectedFailure
-def test_get_expression_unknown_property(self):
-self.__class__._unoCon.checkProperties(
-
self.__class__._xDoc.createInstance(com.sun.star.text.textfield.GetExpression),
-{NumberingType: 0},
-self
-)
-
 
 if __name__ == '__main__':
 unittest.main()
diff --git a/sw/qa/python/set_expression.py b/sw/qa/python/set_expression.py
index d88d2f3..6a24ff7 100644
--- a/sw/qa/python/set_expression.py
+++ b/sw/qa/python/set_expression.py
@@ -1,23 +1,23 @@
 import unittest
-from org.libreoffice.unotest import UnoNotConnection as UnoConnection
+from org.libreoffice.unotest import UnoInProcess
 
 #@unittest.skip(that seems to work)
 class TestSetExpresion(unittest.TestCase):
-_unoCon = None
+_uno = None
 _xDoc = None
 
 @classmethod
 def setUpClass(cls):
-cls._unoCon = UnoConnection({})
-cls._unoCon.setUp()
-cls._xDoc = cls._unoCon.openEmptyWriterDoc()
+cls._uno = UnoInProcess()
+cls._uno.setUp()
+cls._xDoc = cls._uno.openEmptyWriterDoc()
 
 @classmethod
 def tearDownClass(cls):
-cls._unoCon.tearDown()
+cls._uno.tearDown()
 
 def test_set_expression(self):
-self.__class__._unoCon.checkProperties(
+  

[PUSHED libreoffice-4-0] curl: link against the internal NSS if SYSTEM_NSS=NO

2013-04-18 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3463

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3463
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I06074de50daad19a2cc62fe4090d3c0fbfdb2cb1
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] pyuno_loader::CreateInstance: delete the initial PyThreadSta...

2013-04-18 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3452

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3452
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id6bbb4363928e4fdd8bda1905f6e1f9931dba74c
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] python3: disable check in PyThreadState_Swap

2013-04-18 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3453

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3453
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia82135f37f55ea69b545a83098619939869cb7c5
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] set up python unit test infrastructure

2013-04-08 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3214

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3214
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2692817673f786e950e1176a17c7675f989755b6
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] move Python tests in-process

2013-04-08 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3215

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3215
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e06741e55ead7fddec41ff776ff8ca5d2399469
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED] selectively disable applications from the suite

2013-04-05 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change.

Change subject: selectively disable applications from the suite
..


Patch Set 1: Abandoned

-- 
To view, visit https://gerrit.libreoffice.org/2778
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I7141f0bdedb398eca7f31a1d5c66f009056f4d23
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Michael Meeks michael.me...@suse.com
Gerrit-Reviewer: Riccardo Magliocchetti riccardo.magliocche...@gmail.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED] set up python unit test infrastructure

2013-04-05 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change.

Change subject: set up python unit test infrastructure
..


Patch Set 2: Abandoned

-- 
To view, visit https://gerrit.libreoffice.org/3128
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id481af5635e23fecfb9505e6e54a546a01602419
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Markus Mohrhard markus.mohrh...@googlemail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz
Gerrit-Reviewer: Riccardo Magliocchetti riccardo.magliocche...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] set up python unit test infrastructure

2013-03-30 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3128

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/3128/1

set up python unit test infrastructure

Extract boostraping code from convwatch.py to unotest.py. Use python builtin
unittest module as unit test framework. Specify the unit test modules in make
file. Another option would be to use discover mode of unittest module.

Add __pycache__ to global .gitignore to keep the source directory clean.
Another option would be to deliver the unit tests to workdir prior to test
execution.

Currently only system python3 is supported.

Change-Id: Id481af5635e23fecfb9505e6e54a546a01602419
---
M .gitignore
A solenv/gbuild/PythonTest.mk
M solenv/gbuild/TargetLocations.mk
M solenv/gbuild/gbuild.mk
M sw/Module_sw.mk
A sw/PythonTest_sw_unoapi.mk
A sw/qa/unoapi/python/get_expression.py
A sw/qa/unoapi/python/set_expression.py
A unotest/source/python/org/__init__.py
A unotest/source/python/org/libreoffice/__init__.py
A unotest/source/python/org/libreoffice/unotest.py
11 files changed, 421 insertions(+), 0 deletions(-)



diff --git a/.gitignore b/.gitignore
index fc3ecb5..1a9bf30 100644
--- a/.gitignore
+++ b/.gitignore
@@ -75,5 +75,6 @@
 /solenv/gdb/libreoffice/*.pyo
 /solenv/gdb/libreoffice/util/*.pyo
 /moz/zipped/*.zip
+__pycache__
 
 
diff --git a/solenv/gbuild/PythonTest.mk b/solenv/gbuild/PythonTest.mk
new file mode 100644
index 000..d97b2a8
--- /dev/null
+++ b/solenv/gbuild/PythonTest.mk
@@ -0,0 +1,83 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+# PythonTest class
+
+# TODO: FixMe problem with internal python:
+# Fatal Python error: Py_Initialize: Unable to get the locale encoding
+#gb_Python_EXE := $(call gb_Executable_get_command,python)
+gb_Python_EXE := python3
+
+gb_PythonTest_COMMAND := $(gb_Python_EXE) -m unittest
+
+.PHONY : $(call gb_PythonTest_get_clean_target,%)
+$(call gb_PythonTest_get_clean_target,%) :
+   $(call gb_Helper_abbreviate_dirs,\
+   rm -f $@ $@.log)
+
+ifneq ($(DISABLE_PYTHON),TRUE)
+
+.PHONY : $(call gb_PythonTest_get_target,%)
+$(call gb_PythonTest_get_target,%) :
+   $(call gb_Output_announce,$*,$(true),PYT,2)
+   $(call gb_Helper_abbreviate_dirs,\
+mkdir -p $(dir $(call gb_PythonTest_get_target,$*))  \
+
(PYTHONPATH=$(SRCDIR)/unotest/source/python:$(DEVINSTALLDIR)/opt/program \
+ SOFFICE_BIN=$(DEVINSTALLDIR)/opt/program/soffice \
+ URE_BOOTSTRAP=file://$(DEVINSTALLDIR)/opt/program/fundamentalrc \
+   $(gb_PythonTest_COMMAND) \
+$(CLASSES)  $@.log 21 || \
+   (cat $@.log \
+false)))
+   $(CLEAN_CMD)
+
+define gb_PythonTest_PythonTest
+$(call gb_PythonTest_get_target,$(1)) : T_CP :=
+$(call gb_PythonTest_get_target,$(1)) : CLASSES :=
+
+$(eval $(call gb_Module_register_target,$(call 
gb_PythonTest_get_target,$(1)),$(call gb_PythonTest_get_clean_target,$(1
+$(call gb_Helper_make_userfriendly_targets,$(1),PythonTest)
+
+endef
+
+define gb_PythonTest_add_classes
+$(call gb_PythonTest_get_target,$(1)) : CLASSES += $(2)
+
+endef
+
+define gb_PythonTest_add_class
+$(call gb_PythonTest_add_classes,$(1),$(2))
+
+endef
+
+define gb_PythonTest_use_customtarget
+$(call gb_PythonTest_get_target,$(1)) : $(call 
gb_CustomTarget_get_workdir,$(2))
+
+endef
+
+
+else # DISABLE_PYTHON
+
+.PHONY : $(call gb_PythonTest_get_target,$(1))
+$(call gb_PythonTest_get_target,%) :
+   $(call gb_Output_announce,$* (skipped - no PythonTest),$(true),PYT,2)
+   @true
+
+define gb_PythonTest_PythonTest
+$(eval $(call gb_Module_register_target,$(call 
gb_PythonTest_get_target,$(1)),$(call gb_PythonTest_get_clean_target,$(1
+$(call gb_Helper_make_userfriendly_targets,$(1),PythonTest)
+
+endef
+
+gb_PythonTest_add_classes :=
+gb_PythonTest_add_class :=
+gb_JunitTest_use_customtarget :=
+
+endif # DISABLE_PYTHON
+# vim: set noet sw=4:
diff --git a/solenv/gbuild/TargetLocations.mk b/solenv/gbuild/TargetLocations.mk
index b738b65..25dd542 100644
--- a/solenv/gbuild/TargetLocations.mk
+++ b/solenv/gbuild/TargetLocations.mk
@@ -147,6 +147,7 @@
 gb_JunitTest_get_classsetname = JunitTest/$(1)
 gb_JunitTest_get_target = $(WORKDIR)/JunitTest/$(1)/done
 gb_JunitTest_get_userdir = $(WORKDIR)/JunitTest/$(1)/user
+gb_PythonTest_get_target = $(WORKDIR)/PythonTest/$(1)/done
 gb_LinkTarget_get_external_headers_target = $(WORKDIR)/ExternalHeaders/$(1)
 gb_LinkTarget_get_headers_target = $(WORKDIR)/Headers/$(1)
 gb_LinkTarget_get_target = $(WORKDIR)/LinkTarget/$(1)
@@ -289,6 +290,7 @@
Pagein \
PrecompiledHeader \
Pyuno \
+   PythonTest \
Rdb \
ResTarget \
 

[PUSHED libreoffice-4-0] fdo#55814 SwDoc::UpdateExpFlds: hiding the last section may ...

2013-03-20 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2876

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2876
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6026846981b5af014246a8a604c5f762d34c891
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Miklos Vajna vmik...@suse.cz
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] remove unused code svtools/bmpmaker

2013-03-20 Thread David Ostrovsky (via Code Review)
David Ostrovsky has created a new patch set by issuing a rebase in Gerrit (#4).

Change subject: remove unused code svtools/bmpmaker
..

remove unused code svtools/bmpmaker

Investigated the usage of bmpmaker for fdo#39445, seemingly
it's not used anywhere. I removed it but I would be happier
if someone could confirm this.

Change-Id: I21c98e7857299aef8c482bb07750f4c13529c937
---
M Repository.mk
D svtools/Executable_bmp.mk
D svtools/Executable_bmpsum.mk
D svtools/Executable_g2g.mk
M svtools/Module_svtools.mk
D svtools/bmpmaker/bmp.cxx
D svtools/bmpmaker/bmp.hrc
D svtools/bmpmaker/bmp.src
D svtools/bmpmaker/bmpcore.cxx
D svtools/bmpmaker/bmpcore.hxx
D svtools/bmpmaker/bmpsum.cxx
D svtools/bmpmaker/g2g.cxx
12 files changed, 0 insertions(+), 1,751 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/2868/4
-- 
To view, visit https://gerrit.libreoffice.org/2868
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I21c98e7857299aef8c482bb07750f4c13529c937
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Krisztian Pinter pin.termina...@gmail.com
Gerrit-Reviewer: Krisztian Pinter pin.termina...@gmail.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Noel Power noel.po...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] add suport for new JVM versions

2013-03-20 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2884

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/2884/1

add suport for new JVM versions

Change-Id: I751e67aefabbb895490cdb8ea4cb522f19d23715
---
M codemaker/source/javamaker/classfile.cxx
M configure.ac
2 files changed, 17 insertions(+), 2 deletions(-)



diff --git a/codemaker/source/javamaker/classfile.cxx 
b/codemaker/source/javamaker/classfile.cxx
index 0f115b2..a79c920 100644
--- a/codemaker/source/javamaker/classfile.cxx
+++ b/codemaker/source/javamaker/classfile.cxx
@@ -651,6 +651,8 @@
 writeU4(file, 0xCAFEBABE);
 writeU2(file, 0);
 writeU2(file, 49); // class file version of JRE 1.5
+//writeU2(file, 50); // class file version of JRE 1.6
+//writeU2(file, 51); // class file version of JRE 1.7
 writeU2(file, m_constantPoolCount);
 writeStream(file, m_constantPool);
 writeU2(file, static_cast sal_uInt16 (m_accessFlags));
diff --git a/configure.ac b/configure.ac
index 75d64a3..f65ccd9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1620,6 +1620,14 @@
 ],
 ,with_junit=yes)
 
+AC_ARG_WITH(java-version,
+AS_HELP_STRING([--with-java-version],
+[Specifiy java version. Default is 1.5.])
+[
+  Usage: --with-java-version=1.6|1.7|...
+],
+,)
+
 AC_ARG_WITH(perl-home,
 AS_HELP_STRING([--with-perl-home],
 [If you have installed Perl 5 Distribution, on your system, please
@@ -6127,8 +6135,13 @@
 dnl Set target Java bytecode version
 dnl ===
 if test $SOLAR_JAVA != ; then
-_java_target_ver=1.5
-
+AC_MSG_CHECKING([which java version to use])
+if test -z $with_java_version; then
+_java_target_ver=1.5
+else
+   _java_target_ver=$with_java_version
+fi
+AC_MSG_RESULT([$_java_target_ver])
 JAVA_SOURCE_VER=$_java_target_ver
 JAVA_TARGET_VER=$_java_target_ver
 fi

-- 
To view, visit https://gerrit.libreoffice.org/2884
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I751e67aefabbb895490cdb8ea4cb522f19d23715
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] make gcc-wrapper work even with ccache

2013-03-19 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2857

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/2857/1

make gcc-wrapper work even with ccache

Change-Id: If97cc4f2af2adb6af1217cf7b095d0f0f7831bca
---
M solenv/gbuild/platform/com_MSC_class.mk
1 file changed, 5 insertions(+), 2 deletions(-)



diff --git a/solenv/gbuild/platform/com_MSC_class.mk 
b/solenv/gbuild/platform/com_MSC_class.mk
old mode 100644
new mode 100755
index 27211ef..612342d
--- a/solenv/gbuild/platform/com_MSC_class.mk
+++ b/solenv/gbuild/platform/com_MSC_class.mk
@@ -550,10 +550,13 @@
 $(call gb_ExternalProject_get_state_target,$(1),$(2)): WRAPPERS := 
$(gb_AUTOCONF_WRAPPERS)
 endef
 
+# if ccache is enabled, then split it and use lastword as REAL_FOO
+# /opt/lo/bin/ccache /cygdrive/c/PROGRA~2/MICROS~2.0/VC/bin/cl.exe
+
 gb_AUTOCONF_WRAPPERS := \
-   REAL_CC=$(shell cygpath -w $(CC)) \
+   REAL_CC=$(shell cygpath -w $(lastword $(CC))) \
CC=$(call gb_Executable_get_target,gcc-wrapper) \
-   REAL_CXX=$(shell cygpath -w $(CXX)) \
+   REAL_CXX=$(shell cygpath -w  $(lastword $(CXX))) \
CXX=$(call gb_Executable_get_target,g++-wrapper) \
 LD=$(shell cygpath -w $(COMPATH)/bin/link.exe) -nologo
 

-- 
To view, visit https://gerrit.libreoffice.org/2857
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If97cc4f2af2adb6af1217cf7b095d0f0f7831bca
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] make gcc-wrapper work even with ccache

2013-03-19 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2857

Approvals:
  LibreOffice gerrit bot: Verified
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2857
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If97cc4f2af2adb6af1217cf7b095d0f0f7831bca
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED] install a toolchain for man page, html pdf files

2013-03-13 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change.

Change subject: install a toolchain for man page, html  pdf files
..


Patch Set 3: Abandoned

Apparently not interesting

-- 
To view, visit https://gerrit.libreoffice.org/2068
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I1c81f80552f1b05cd6bcece39123dbfcf5c38b9b
Gerrit-PatchSet: 3
Gerrit-Project: buildbot
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED prod] add -2/+2 to categorie 'VRIF' for buildbot verification

2013-03-13 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change.

Change subject: add -2/+2 to categorie 'VRIF' for buildbot verification
..


Patch Set 2: Abandoned

Abandon after 1 month inactivity

-- 
To view, visit https://gerrit.libreoffice.org/2110
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I37c7806378ee0d58dfaa712c57b3e11cb4dca42c
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-etc
Gerrit-Branch: prod
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED prod] sql script to customize the Review -1 and -2 messages

2013-03-13 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change.

Change subject: sql script to customize the Review -1 and -2 messages
..


Patch Set 1: Abandoned

Already applied in prod

-- 
To view, visit https://gerrit.libreoffice.org/2158
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I789af82554345524ffcb9b3512525d4371da30c7
Gerrit-PatchSet: 1
Gerrit-Project: gerrit-etc
Gerrit-Branch: prod
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED] Try to fix fdo#55814 by reverting bb6bd1ff9

2013-03-13 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change.

Change subject: Try to fix fdo#55814 by reverting bb6bd1ff9
..


Patch Set 2: Abandoned

didn't work that way

-- 
To view, visit https://gerrit.libreoffice.org/2613
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I45018618ed646db20b107251707e65c17068b073
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] use system python for building if possible

2013-03-12 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2563

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2563
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5c6c53fbee06cd1ecccf878a5c080274bfd950c1
Gerrit-PatchSet: 7
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Tomáš Chvátal tchva...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] solenv: remove versionlist.hrc

2013-03-12 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2677

Approvals:
  Michael Stahl: Looks good to me, approved
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2677
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iddbfcacd17c1022293357ff5240ab7a52b1a390e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-11 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2578

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2578
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
Gerrit-PatchSet: 8
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-10 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann, LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2578

to look at the new patch set (#5).

Change subject: fdo#61726: rename report-builder package to 
org.libreoffice.report
..

fdo#61726: rename report-builder package to org.libreoffice.report

To prevent future clashes with uno's name space rename the
com.sun.star.report package to org.libreoffice.report.

Bump the version to 1.2.4.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
---
M Repository.mk
M connectivity/source/commontools/dbtools2.cxx
M dbaccess/source/ui/app/AppController.cxx
M reportbuilder/Configuration_reportbuilder.mk
M reportbuilder/Extension_reportbuilder.mk
M reportbuilder/Jar_reportbuilder.mk
D reportbuilder/java/com/sun/star/report/pentaho/configuration.properties
D reportbuilder/java/com/sun/star/report/pentaho/parser/selectors.properties
M reportbuilder/java/jfreereport.properties
M reportbuilder/java/libformula.properties
M reportbuilder/java/loader.properties
R reportbuilder/java/org/libreoffice/report/DataRow.java
R reportbuilder/java/org/libreoffice/report/DataSource.java
R reportbuilder/java/org/libreoffice/report/DataSourceException.java
R reportbuilder/java/org/libreoffice/report/DataSourceFactory.java
R reportbuilder/java/org/libreoffice/report/ImageService.java
R reportbuilder/java/org/libreoffice/report/InputRepository.java
R reportbuilder/java/org/libreoffice/report/JobDefinitionException.java
R reportbuilder/java/org/libreoffice/report/JobProgressIndicator.java
R reportbuilder/java/org/libreoffice/report/JobProperties.java
R reportbuilder/java/org/libreoffice/report/OfficeToken.java
R reportbuilder/java/org/libreoffice/report/OutputRepository.java
R reportbuilder/java/org/libreoffice/report/ParameterMap.java
R reportbuilder/java/org/libreoffice/report/ReportAddIn.java
R reportbuilder/java/org/libreoffice/report/ReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/report/ReportEngineParameterNames.java
R reportbuilder/java/org/libreoffice/report/ReportExecutionException.java
R reportbuilder/java/org/libreoffice/report/ReportExpression.java
R reportbuilder/java/org/libreoffice/report/ReportExpressionMetaData.java
R reportbuilder/java/org/libreoffice/report/ReportFunction.java
R reportbuilder/java/org/libreoffice/report/ReportJob.java
R reportbuilder/java/org/libreoffice/report/ReportJobDefinition.java
R reportbuilder/java/org/libreoffice/report/ReportJobFactory.java
R reportbuilder/java/org/libreoffice/report/SDBCReportData.java
R reportbuilder/java/org/libreoffice/report/SDBCReportDataFactory.java
R reportbuilder/java/org/libreoffice/report/SOImageService.java
R reportbuilder/java/org/libreoffice/report/StorageRepository.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Author-Function.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Author-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/AuthorFunction.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/AuthorFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/MetaDataFunctionCategory.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Title-Function.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Title-Function_en_US.properties
R reportbuilder/java/org/libreoffice/report/function/metadata/TitleFunction.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/TitleFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/category.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/category_en_US.properties
R reportbuilder/java/org/libreoffice/report/pentaho/DefaultNameGenerator.java
R reportbuilder/java/org/libreoffice/report/pentaho/Manifest.mf
R reportbuilder/java/org/libreoffice/report/pentaho/OfficeNamespaces.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoFormulaContext.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportAddIn.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportEngine.java
R 
reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportJob.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOFormulaOpCodeMapper.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOFormulaParser.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOFunctionManager.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOReportJobFactory.java
R reportbuilder/java/org/libreoffice/report/pentaho/StarFunctionCategory.java
R reportbuilder/java/org/libreoffice/report/pentaho/StarFunctionDescription.java
R reportbuilder/java/org/libreoffice/report/pentaho/StarReportData.java
R 

[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-10 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann, LibreOffice gerrit bot,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2578

to look at the new rebased patch set (#6).

Change subject: fdo#61726: rename report-builder package to 
org.libreoffice.report
..

fdo#61726: rename report-builder package to org.libreoffice.report

To prevent future clashes with uno's name space rename the
com.sun.star.report package to org.libreoffice.report.

Bump the version to 1.2.4.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
---
M Repository.mk
M connectivity/source/commontools/dbtools2.cxx
M dbaccess/source/ui/app/AppController.cxx
M reportbuilder/Configuration_reportbuilder.mk
M reportbuilder/Extension_reportbuilder.mk
M reportbuilder/Jar_reportbuilder.mk
D reportbuilder/java/com/sun/star/report/pentaho/configuration.properties
D reportbuilder/java/com/sun/star/report/pentaho/parser/selectors.properties
M reportbuilder/java/jfreereport.properties
M reportbuilder/java/libformula.properties
M reportbuilder/java/loader.properties
R reportbuilder/java/org/libreoffice/report/DataRow.java
R reportbuilder/java/org/libreoffice/report/DataSource.java
R reportbuilder/java/org/libreoffice/report/DataSourceException.java
R reportbuilder/java/org/libreoffice/report/DataSourceFactory.java
R reportbuilder/java/org/libreoffice/report/ImageService.java
R reportbuilder/java/org/libreoffice/report/InputRepository.java
R reportbuilder/java/org/libreoffice/report/JobDefinitionException.java
R reportbuilder/java/org/libreoffice/report/JobProgressIndicator.java
R reportbuilder/java/org/libreoffice/report/JobProperties.java
R reportbuilder/java/org/libreoffice/report/OfficeToken.java
R reportbuilder/java/org/libreoffice/report/OutputRepository.java
R reportbuilder/java/org/libreoffice/report/ParameterMap.java
R reportbuilder/java/org/libreoffice/report/ReportAddIn.java
R reportbuilder/java/org/libreoffice/report/ReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/report/ReportEngineParameterNames.java
R reportbuilder/java/org/libreoffice/report/ReportExecutionException.java
R reportbuilder/java/org/libreoffice/report/ReportExpression.java
R reportbuilder/java/org/libreoffice/report/ReportExpressionMetaData.java
R reportbuilder/java/org/libreoffice/report/ReportFunction.java
R reportbuilder/java/org/libreoffice/report/ReportJob.java
R reportbuilder/java/org/libreoffice/report/ReportJobDefinition.java
R reportbuilder/java/org/libreoffice/report/ReportJobFactory.java
R reportbuilder/java/org/libreoffice/report/SDBCReportData.java
R reportbuilder/java/org/libreoffice/report/SDBCReportDataFactory.java
R reportbuilder/java/org/libreoffice/report/SOImageService.java
R reportbuilder/java/org/libreoffice/report/StorageRepository.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Author-Function.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Author-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/AuthorFunction.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/AuthorFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/MetaDataFunctionCategory.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Title-Function.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Title-Function_en_US.properties
R reportbuilder/java/org/libreoffice/report/function/metadata/TitleFunction.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/TitleFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/category.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/category_en_US.properties
R reportbuilder/java/org/libreoffice/report/pentaho/DefaultNameGenerator.java
R reportbuilder/java/org/libreoffice/report/pentaho/Manifest.mf
R reportbuilder/java/org/libreoffice/report/pentaho/OfficeNamespaces.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoFormulaContext.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportAddIn.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportEngine.java
R 
reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportJob.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOFormulaOpCodeMapper.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOFormulaParser.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOFunctionManager.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOReportJobFactory.java
R reportbuilder/java/org/libreoffice/report/pentaho/StarFunctionCategory.java
R reportbuilder/java/org/libreoffice/report/pentaho/StarFunctionDescription.java
R reportbuilder/java/org/libreoffice/report/pentaho/StarReportData.java
R 

[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-10 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann, LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2578

to look at the new patch set (#7).

Change subject: fdo#61726: rename report-builder package to 
org.libreoffice.report
..

fdo#61726: rename report-builder package to org.libreoffice.report

To prevent future clashes with uno name space rename the
com.sun.star.report package to org.libreoffice.report.

Bump the version to 1.2.4.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
---
M Repository.mk
M connectivity/source/commontools/dbtools2.cxx
M dbaccess/source/core/dataaccess/documentdefinition.cxx
M dbaccess/source/ui/app/AppController.cxx
M reportbuilder/Configuration_reportbuilder.mk
M reportbuilder/Extension_reportbuilder.mk
M reportbuilder/Jar_reportbuilder.mk
D reportbuilder/java/com/sun/star/report/pentaho/configuration.properties
D reportbuilder/java/com/sun/star/report/pentaho/parser/selectors.properties
M reportbuilder/java/jfreereport.properties
M reportbuilder/java/libformula.properties
M reportbuilder/java/loader.properties
R reportbuilder/java/org/libreoffice/report/DataRow.java
R reportbuilder/java/org/libreoffice/report/DataSource.java
R reportbuilder/java/org/libreoffice/report/DataSourceException.java
R reportbuilder/java/org/libreoffice/report/DataSourceFactory.java
R reportbuilder/java/org/libreoffice/report/ImageService.java
R reportbuilder/java/org/libreoffice/report/InputRepository.java
R reportbuilder/java/org/libreoffice/report/JobDefinitionException.java
R reportbuilder/java/org/libreoffice/report/JobProgressIndicator.java
R reportbuilder/java/org/libreoffice/report/JobProperties.java
R reportbuilder/java/org/libreoffice/report/OfficeToken.java
R reportbuilder/java/org/libreoffice/report/OutputRepository.java
R reportbuilder/java/org/libreoffice/report/ParameterMap.java
R reportbuilder/java/org/libreoffice/report/ReportAddIn.java
R reportbuilder/java/org/libreoffice/report/ReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/report/ReportEngineParameterNames.java
R reportbuilder/java/org/libreoffice/report/ReportExecutionException.java
R reportbuilder/java/org/libreoffice/report/ReportExpression.java
R reportbuilder/java/org/libreoffice/report/ReportExpressionMetaData.java
R reportbuilder/java/org/libreoffice/report/ReportFunction.java
R reportbuilder/java/org/libreoffice/report/ReportJob.java
R reportbuilder/java/org/libreoffice/report/ReportJobDefinition.java
R reportbuilder/java/org/libreoffice/report/ReportJobFactory.java
R reportbuilder/java/org/libreoffice/report/SDBCReportData.java
R reportbuilder/java/org/libreoffice/report/SDBCReportDataFactory.java
R reportbuilder/java/org/libreoffice/report/SOImageService.java
R reportbuilder/java/org/libreoffice/report/StorageRepository.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Author-Function.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Author-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/AuthorFunction.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/AuthorFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/MetaDataFunctionCategory.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Title-Function.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/Title-Function_en_US.properties
R reportbuilder/java/org/libreoffice/report/function/metadata/TitleFunction.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/TitleFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/report/function/metadata/category.properties
R 
reportbuilder/java/org/libreoffice/report/function/metadata/category_en_US.properties
R reportbuilder/java/org/libreoffice/report/pentaho/DefaultNameGenerator.java
R reportbuilder/java/org/libreoffice/report/pentaho/Manifest.mf
R reportbuilder/java/org/libreoffice/report/pentaho/OfficeNamespaces.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoFormulaContext.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportAddIn.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportEngine.java
R 
reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/report/pentaho/PentahoReportJob.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOFormulaOpCodeMapper.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOFormulaParser.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOFunctionManager.java
R reportbuilder/java/org/libreoffice/report/pentaho/SOReportJobFactory.java
R reportbuilder/java/org/libreoffice/report/pentaho/StarFunctionCategory.java
R reportbuilder/java/org/libreoffice/report/pentaho/StarFunctionDescription.java
R 

[PATCH] always use system python for building

2013-03-09 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2563

to look at the new patch set (#2).

Change subject: always use system python for building
..

always use system python for building

We don't package perl, awk, sed, etc. to satisfy build dependency.
So just in case we are using python as extension language for LO
doesn't mean that we should use internal packaged python for building
LO and fail back to it, even in the case if Pyuno is disabled.

We stop with this silliness and always require Python interpreter with
version = 2.7 to be installed.

Note: once merged, all tinderboxes, that don't have system Python installed,
have to be updated.

Change-Id: I5c6c53fbee06cd1ecccf878a5c080274bfd950c1
---
M RepositoryExternal.mk
M config_host.mk.in
M configure.ac
M nss/ExternalProject_nss.mk
M solenv/gbuild/ExternalExecutable.mk
5 files changed, 27 insertions(+), 89 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/2563/2
-- 
To view, visit https://gerrit.libreoffice.org/2563
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c6c53fbee06cd1ecccf878a5c080274bfd950c1
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Tomáš Chvátal tchva...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] always use system python for building

2013-03-09 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2563

to look at the new rebased patch set (#3).

Change subject: always use system python for building
..

always use system python for building

We don't package perl, awk, sed, etc. to satisfy build dependency.
So just in case we are using python as extension language for LO
doesn't mean that we should use internal packaged python for building
LO and fail back to it, even in the case if Pyuno is disabled.

We stop with this silliness and always require Python interpreter with
version = 2.7 to be installed.

Note: once merged, all tinderboxes, that don't have system Python installed,
have to be updated.

Change-Id: I5c6c53fbee06cd1ecccf878a5c080274bfd950c1
---
M RepositoryExternal.mk
M config_host.mk.in
M configure.ac
M nss/ExternalProject_nss.mk
M solenv/gbuild/ExternalExecutable.mk
5 files changed, 27 insertions(+), 89 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/2563/3
-- 
To view, visit https://gerrit.libreoffice.org/2563
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c6c53fbee06cd1ecccf878a5c080274bfd950c1
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Tomáš Chvátal tchva...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] always use system python for building

2013-03-09 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2563

to look at the new patch set (#4).

Change subject: always use system python for building
..

always use system python for building

We don't package perl, awk, sed, etc. to satisfy build dependency.
So just in case we are using python as extension language for LO
doesn't mean that we should use internal packaged python for building
LO and fail back to it, even in the case if Pyuno is disabled.

We stop with this silliness and always require Python interpreter with
version = 2.7 to be installed.

Note: once merged, all tinderboxes, that don't have system Python installed,
have to be updated.

Change-Id: I5c6c53fbee06cd1ecccf878a5c080274bfd950c1
---
M RepositoryExternal.mk
M config_host.mk.in
M configure.ac
M nss/ExternalProject_nss.mk
M solenv/gbuild/ExternalExecutable.mk
5 files changed, 29 insertions(+), 89 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/2563/4
-- 
To view, visit https://gerrit.libreoffice.org/2563
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c6c53fbee06cd1ecccf878a5c080274bfd950c1
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Tomáš Chvátal tchva...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Fixes fdo#55814 by reverting bb6bd1ff9

2013-03-09 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2613

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/2613/1

Fixes fdo#55814 by reverting bb6bd1ff9

This commit revert bb6bd1ff9cd3eecec7eb2cd7bd0a4dcef584c903.
After reverting no crashes happen.

Change-Id: I45018618ed646db20b107251707e65c17068b073
---
M sw/source/core/doc/docfld.cxx
1 file changed, 1 insertion(+), 26 deletions(-)



diff --git a/sw/source/core/doc/docfld.cxx b/sw/source/core/doc/docfld.cxx
index 8c01695..be41983 100644
--- a/sw/source/core/doc/docfld.cxx
+++ b/sw/source/core/doc/docfld.cxx
@@ -1277,15 +1277,6 @@
 SwNewDBMgr* pMgr = GetNewDBMgr();
 pMgr-CloseAll(sal_False);
 
-// Make sure we don't hide all sections, which would lead to a crash. 
First, count how many of them do we have.
-int nShownSections = 0;
-for( _SetGetExpFlds::const_iterator it = 
mpUpdtFlds-GetSortLst()-begin(); it != mpUpdtFlds-GetSortLst()-end(); ++it )
-{
-SwSection* pSect = (SwSection*)(*it)-GetSection();
-if ( pSect  !pSect-IsCondHidden())
-nShownSections++;
-}
-
 String aNew;
 for( _SetGetExpFlds::const_iterator it = 
mpUpdtFlds-GetSortLst()-begin(); it != mpUpdtFlds-GetSortLst()-end(); ++it )
 {
@@ -1296,23 +1287,7 @@
 SwSbxValue aValue = aCalc.Calculate(
 pSect-GetCondition() );
 if(!aValue.IsVoidValue())
-{
-// Do we want to hide this one?
-bool bHide = aValue.GetBool();
-if (bHide  !pSect-IsCondHidden())
-{
-// This section will be hidden, but it wasn't before
-if (nShownSections == 1)
-{
-// This would be the last section, so set its 
condition to false, and avoid hiding it.
-OUString aCond(0);
-pSect-SetCondition(aCond);
-bHide = false;
-}
-nShownSections--;
-}
-pSect-SetCondHidden( bHide );
-}
+pSect-SetCondHidden( aValue.GetBool() );
 continue;
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/2613
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45018618ed646db20b107251707e65c17068b073
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fdo#61726: rename report-builder package org.libreoffice.ext...

2013-03-07 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2578

to look at the new patch set (#2).

Change subject: fdo#61726: rename report-builder package 
org.libreoffice.ext.report
..

fdo#61726: rename report-builder package org.libreoffice.ext.report

To prevent future collisions with uno's own territory rename the
com.sun.star.report package to org.libreoffice.ext.report.

Bump version to 1.2.4 and preserv the identifier still to
com.sun.reportdesigner to not to confuse the extension sync manager.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
---
M Repository.mk
M connectivity/source/commontools/dbtools2.cxx
M dbaccess/source/ui/app/AppController.cxx
M reportbuilder/Configuration_reportbuilder.mk
M reportbuilder/Extension_reportbuilder.mk
M reportbuilder/Jar_reportbuilder.mk
D reportbuilder/java/com/sun/star/report/pentaho/configuration.properties
D reportbuilder/java/com/sun/star/report/pentaho/parser/selectors.properties
M reportbuilder/java/jfreereport.properties
M reportbuilder/java/libformula.properties
M reportbuilder/java/loader.properties
R reportbuilder/java/org/libreoffice/ext/report/DataRow.java
R reportbuilder/java/org/libreoffice/ext/report/DataSource.java
R reportbuilder/java/org/libreoffice/ext/report/DataSourceException.java
R reportbuilder/java/org/libreoffice/ext/report/DataSourceFactory.java
R reportbuilder/java/org/libreoffice/ext/report/ImageService.java
R reportbuilder/java/org/libreoffice/ext/report/InputRepository.java
R reportbuilder/java/org/libreoffice/ext/report/JobDefinitionException.java
R reportbuilder/java/org/libreoffice/ext/report/JobProgressIndicator.java
R reportbuilder/java/org/libreoffice/ext/report/JobProperties.java
R reportbuilder/java/org/libreoffice/ext/report/OfficeToken.java
R reportbuilder/java/org/libreoffice/ext/report/OutputRepository.java
R reportbuilder/java/org/libreoffice/ext/report/ParameterMap.java
R reportbuilder/java/org/libreoffice/ext/report/ReportAddIn.java
R reportbuilder/java/org/libreoffice/ext/report/ReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/ReportEngineParameterNames.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExecutionException.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExpression.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExpressionMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/ReportFunction.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJob.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJobDefinition.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJobFactory.java
R reportbuilder/java/org/libreoffice/ext/report/SDBCReportData.java
R reportbuilder/java/org/libreoffice/ext/report/SDBCReportDataFactory.java
R reportbuilder/java/org/libreoffice/ext/report/SOImageService.java
R reportbuilder/java/org/libreoffice/ext/report/StorageRepository.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Author-Function.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Author-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/AuthorFunction.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/AuthorFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/MetaDataFunctionCategory.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Title-Function.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Title-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/TitleFunction.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/TitleFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/category.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/category_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/DefaultNameGenerator.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/Manifest.mf
R reportbuilder/java/org/libreoffice/ext/report/pentaho/OfficeNamespaces.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoFormulaContext.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportAddIn.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportEngine.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportJob.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFormulaOpCodeMapper.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFormulaParser.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFunctionManager.java
R 

[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-07 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2578

to look at the new patch set (#3).

Change subject: fdo#61726: rename report-builder package to 
org.libreoffice.ext.report
..

fdo#61726: rename report-builder package to org.libreoffice.ext.report

To prevent future collisions with uno's own territory rename the
com.sun.star.report package to org.libreoffice.ext.report.

Bump the version to 1.2.4.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
---
M Repository.mk
M connectivity/source/commontools/dbtools2.cxx
M dbaccess/source/ui/app/AppController.cxx
M reportbuilder/Configuration_reportbuilder.mk
M reportbuilder/Extension_reportbuilder.mk
M reportbuilder/Jar_reportbuilder.mk
D reportbuilder/java/com/sun/star/report/pentaho/configuration.properties
D reportbuilder/java/com/sun/star/report/pentaho/parser/selectors.properties
M reportbuilder/java/jfreereport.properties
M reportbuilder/java/libformula.properties
M reportbuilder/java/loader.properties
R reportbuilder/java/org/libreoffice/ext/report/DataRow.java
R reportbuilder/java/org/libreoffice/ext/report/DataSource.java
R reportbuilder/java/org/libreoffice/ext/report/DataSourceException.java
R reportbuilder/java/org/libreoffice/ext/report/DataSourceFactory.java
R reportbuilder/java/org/libreoffice/ext/report/ImageService.java
R reportbuilder/java/org/libreoffice/ext/report/InputRepository.java
R reportbuilder/java/org/libreoffice/ext/report/JobDefinitionException.java
R reportbuilder/java/org/libreoffice/ext/report/JobProgressIndicator.java
R reportbuilder/java/org/libreoffice/ext/report/JobProperties.java
R reportbuilder/java/org/libreoffice/ext/report/OfficeToken.java
R reportbuilder/java/org/libreoffice/ext/report/OutputRepository.java
R reportbuilder/java/org/libreoffice/ext/report/ParameterMap.java
R reportbuilder/java/org/libreoffice/ext/report/ReportAddIn.java
R reportbuilder/java/org/libreoffice/ext/report/ReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/ReportEngineParameterNames.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExecutionException.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExpression.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExpressionMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/ReportFunction.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJob.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJobDefinition.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJobFactory.java
R reportbuilder/java/org/libreoffice/ext/report/SDBCReportData.java
R reportbuilder/java/org/libreoffice/ext/report/SDBCReportDataFactory.java
R reportbuilder/java/org/libreoffice/ext/report/SOImageService.java
R reportbuilder/java/org/libreoffice/ext/report/StorageRepository.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Author-Function.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Author-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/AuthorFunction.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/AuthorFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/MetaDataFunctionCategory.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Title-Function.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Title-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/TitleFunction.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/TitleFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/category.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/category_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/DefaultNameGenerator.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/Manifest.mf
R reportbuilder/java/org/libreoffice/ext/report/pentaho/OfficeNamespaces.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoFormulaContext.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportAddIn.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportEngine.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportJob.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFormulaOpCodeMapper.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFormulaParser.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFunctionManager.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOReportJobFactory.java
R 

[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-07 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2578

to look at the new patch set (#4).

Change subject: fdo#61726: rename report-builder package to 
org.libreoffice.ext.report
..

fdo#61726: rename report-builder package to org.libreoffice.ext.report

To prevent future collisions with uno's own territory rename the
com.sun.star.report package to org.libreoffice.ext.report.

Bump the version to 1.2.4.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
---
M Repository.mk
M connectivity/source/commontools/dbtools2.cxx
M dbaccess/source/ui/app/AppController.cxx
M reportbuilder/Configuration_reportbuilder.mk
M reportbuilder/Extension_reportbuilder.mk
M reportbuilder/Jar_reportbuilder.mk
D reportbuilder/java/com/sun/star/report/pentaho/configuration.properties
D reportbuilder/java/com/sun/star/report/pentaho/parser/selectors.properties
M reportbuilder/java/jfreereport.properties
M reportbuilder/java/libformula.properties
M reportbuilder/java/loader.properties
R reportbuilder/java/org/libreoffice/ext/report/DataRow.java
R reportbuilder/java/org/libreoffice/ext/report/DataSource.java
R reportbuilder/java/org/libreoffice/ext/report/DataSourceException.java
R reportbuilder/java/org/libreoffice/ext/report/DataSourceFactory.java
R reportbuilder/java/org/libreoffice/ext/report/ImageService.java
R reportbuilder/java/org/libreoffice/ext/report/InputRepository.java
R reportbuilder/java/org/libreoffice/ext/report/JobDefinitionException.java
R reportbuilder/java/org/libreoffice/ext/report/JobProgressIndicator.java
R reportbuilder/java/org/libreoffice/ext/report/JobProperties.java
R reportbuilder/java/org/libreoffice/ext/report/OfficeToken.java
R reportbuilder/java/org/libreoffice/ext/report/OutputRepository.java
R reportbuilder/java/org/libreoffice/ext/report/ParameterMap.java
R reportbuilder/java/org/libreoffice/ext/report/ReportAddIn.java
R reportbuilder/java/org/libreoffice/ext/report/ReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/ReportEngineParameterNames.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExecutionException.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExpression.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExpressionMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/ReportFunction.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJob.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJobDefinition.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJobFactory.java
R reportbuilder/java/org/libreoffice/ext/report/SDBCReportData.java
R reportbuilder/java/org/libreoffice/ext/report/SDBCReportDataFactory.java
R reportbuilder/java/org/libreoffice/ext/report/SOImageService.java
R reportbuilder/java/org/libreoffice/ext/report/StorageRepository.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Author-Function.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Author-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/AuthorFunction.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/AuthorFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/MetaDataFunctionCategory.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Title-Function.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Title-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/TitleFunction.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/TitleFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/category.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/category_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/DefaultNameGenerator.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/Manifest.mf
R reportbuilder/java/org/libreoffice/ext/report/pentaho/OfficeNamespaces.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoFormulaContext.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportAddIn.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportEngine.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportJob.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFormulaOpCodeMapper.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFormulaParser.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFunctionManager.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOReportJobFactory.java
R 

[PATCH] fdo#61726: rename report-builder package org.libreoffice.ext...

2013-03-06 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2578

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/2578/1

fdo#61726: rename report-builder package org.libreoffice.ext.report

To prevent future collisions with uno's own territory rename the
com.sun.star.report package to org.libreoffice.ext.report.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
---
M Repository.mk
M connectivity/source/commontools/dbtools2.cxx
M dbaccess/source/ui/app/AppController.cxx
M reportbuilder/Configuration_reportbuilder.mk
M reportbuilder/Extension_reportbuilder.mk
M reportbuilder/Jar_reportbuilder.mk
D reportbuilder/java/com/sun/star/report/pentaho/configuration.properties
D reportbuilder/java/com/sun/star/report/pentaho/parser/selectors.properties
M reportbuilder/java/jfreereport.properties
M reportbuilder/java/libformula.properties
M reportbuilder/java/loader.properties
R reportbuilder/java/org/libreoffice/ext/report/DataRow.java
R reportbuilder/java/org/libreoffice/ext/report/DataSource.java
R reportbuilder/java/org/libreoffice/ext/report/DataSourceException.java
R reportbuilder/java/org/libreoffice/ext/report/DataSourceFactory.java
R reportbuilder/java/org/libreoffice/ext/report/ImageService.java
R reportbuilder/java/org/libreoffice/ext/report/InputRepository.java
R reportbuilder/java/org/libreoffice/ext/report/JobDefinitionException.java
R reportbuilder/java/org/libreoffice/ext/report/JobProgressIndicator.java
R reportbuilder/java/org/libreoffice/ext/report/JobProperties.java
R reportbuilder/java/org/libreoffice/ext/report/OfficeToken.java
R reportbuilder/java/org/libreoffice/ext/report/OutputRepository.java
R reportbuilder/java/org/libreoffice/ext/report/ParameterMap.java
R reportbuilder/java/org/libreoffice/ext/report/ReportAddIn.java
R reportbuilder/java/org/libreoffice/ext/report/ReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/ReportEngineParameterNames.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExecutionException.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExpression.java
R reportbuilder/java/org/libreoffice/ext/report/ReportExpressionMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/ReportFunction.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJob.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJobDefinition.java
R reportbuilder/java/org/libreoffice/ext/report/ReportJobFactory.java
R reportbuilder/java/org/libreoffice/ext/report/SDBCReportData.java
R reportbuilder/java/org/libreoffice/ext/report/SDBCReportDataFactory.java
R reportbuilder/java/org/libreoffice/ext/report/SOImageService.java
R reportbuilder/java/org/libreoffice/ext/report/StorageRepository.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Author-Function.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Author-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/AuthorFunction.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/AuthorFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/MetaDataFunctionCategory.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Title-Function.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/Title-Function_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/TitleFunction.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/TitleFunctionDescription.java
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/category.properties
R 
reportbuilder/java/org/libreoffice/ext/report/function/metadata/category_en_US.properties
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/DefaultNameGenerator.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/Manifest.mf
R reportbuilder/java/org/libreoffice/ext/report/pentaho/OfficeNamespaces.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoFormulaContext.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportAddIn.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportEngine.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportEngineMetaData.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/PentahoReportJob.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFormulaOpCodeMapper.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFormulaParser.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOFunctionManager.java
R reportbuilder/java/org/libreoffice/ext/report/pentaho/SOReportJobFactory.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/StarFunctionCategory.java
R 
reportbuilder/java/org/libreoffice/ext/report/pentaho/StarFunctionDescription.java
R 

[PATCH] remove minor.mk

2013-03-02 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Michael Stahl,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2491

to look at the new rebased patch set (#2).

Change subject: remove minor.mk
..

remove minor.mk

Hopefully all stays the same except for vcl/unx/gtk/a11y/atkutil.cxx.

Change-Id: I49108007ee6d045f045de86c8654efc7ca5fd3d0
---
M Makefile.in
M config_host.mk.in
M configure.ac
M crashrep/WinResTarget_crashrep.mk
M desktop/WinResTarget_sbase.mk
M desktop/WinResTarget_scalc.mk
M desktop/WinResTarget_sdraw.mk
M desktop/WinResTarget_simpress.mk
M desktop/WinResTarget_smath.mk
M desktop/WinResTarget_soffice.mk
M desktop/WinResTarget_sofficebin.mk
M desktop/WinResTarget_sweb.mk
M desktop/WinResTarget_swriter.mk
M instsetoo_native/CustomTarget_install.mk
M solenv/CustomTarget_versionlist.mk
M solenv/Module_solenv.mk
D solenv/Package_minor.mk
M solenv/bin/ooinstall
M solenv/gbuild/gbuild.mk
M solenv/gbuild/platform/WNT_INTEL_GCC.mk
M solenv/gbuild/platform/com_MSC_class.mk
D solenv/inc/.gitignore
D solenv/inc/minor.mk.in
M vcl/Library_vclplug_gtk.mk
M vcl/Library_vclplug_gtk3.mk
M vcl/unx/gtk/a11y/atkutil.cxx
26 files changed, 26 insertions(+), 104 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/2491/2
-- 
To view, visit https://gerrit.libreoffice.org/2491
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49108007ee6d045f045de86c8654efc7ca5fd3d0
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fix build with --disable-scripting option

2013-03-02 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2510

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/2510/1

fix build with --disable-scripting option

Change-Id: I98dbd3e46c81e1dd056d6e88dc1e526b5af456f5
---
M scp2/source/ooo/file_library_ooo.scp
M scp2/source/ooo/file_ooo.scp
M scp2/source/ooo/file_resource_ooo.scp
3 files changed, 25 insertions(+), 21 deletions(-)



diff --git a/scp2/source/ooo/file_library_ooo.scp 
b/scp2/source/ooo/file_library_ooo.scp
index 1da3175..292a05f 100644
--- a/scp2/source/ooo/file_library_ooo.scp
+++ b/scp2/source/ooo/file_library_ooo.scp
@@ -42,6 +42,8 @@
 
 #ifndef DISABLE_SCRIPTING
 
+STD_LIB_FILE( gid_File_Lib_Sf_Prothdlr, protocolhandler )
+
 File gid_File_Lib_Basprov
 LIB_FILE_BODY;
 Styles = (PACKED);
@@ -62,6 +64,21 @@
   #else
 Name = STRING(CONCAT3(vbaevents,.uno,.dll));
   #endif
+End
+
+File gid_File_Lib_Scriptframe
+LIB_FILE_BODY;
+  #ifdef UNX
+#ifdef MACOSX
+   Name = libscriptframe.dylib;
+#else
+   Name = libscriptframe.so;
+#endif
+  #else
+Name = scriptframe.dll;
+  #endif
+Dir = SCP2_OOO_BIN_DIR;
+Styles = (PACKED);
 End
 
 #endif
@@ -280,8 +297,6 @@
   #endif
 End
 
-#endif
-
 File gid_File_Lib_Stringresource
 LIB_FILE_BODY;
 Styles = (PACKED);
@@ -292,8 +307,6 @@
 Name = STRING(CONCAT3(stringresource,.uno,.dll));
   #endif
 End
-
-#ifndef DISABLE_SCRIPTING
 
 File gid_File_Lib_Vbaobj
 LIB_FILE_BODY;
@@ -1004,21 +1017,6 @@
 
 STD_LIB_FILE( gid_File_Lib_Scn, scn)
 
-File gid_File_Lib_Scriptframe
-LIB_FILE_BODY;
-  #ifdef UNX
-#ifdef MACOSX
-   Name = libscriptframe.dylib;
-#else
-   Name = libscriptframe.so;
-#endif
-  #else
-Name = scriptframe.dll;
-  #endif
-Dir = SCP2_OOO_BIN_DIR;
-Styles = (PACKED);
-End
-
 STD_LIB_FILE( gid_File_Lib_Sd , sd)
 STD_LIB_FILE( gid_File_Lib_Sdui, sdui)
 
@@ -1045,8 +1043,6 @@
 End
 
 STD_LIB_FILE( gid_File_Lib_Sdd , sdd)
-
-STD_LIB_FILE( gid_File_Lib_Sf_Prothdlr, protocolhandler )
 
 File gid_File_Lib_Sfx
 Name = LIBNAME(sfx);
diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index a5c2eb9..38e8003 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -57,12 +57,16 @@
 Name = basicsrvform.zip;
 End
 
+#ifndef DISABLE_SCRIPTING
+
 File gid_File_Basic_Scriptbindinglib
 Dir = gid_Dir_Basic_Scriptbindinglib;
 ARCHIVE_TXT_FILE_BODY;
 Name = scriptbindinglib.zip;
 End
 
+#endif
+
 File gid_File_Basic_Template
 Dir = gid_Dir_Basic_Template;
 ARCHIVE_TXT_FILE_BODY;
diff --git a/scp2/source/ooo/file_resource_ooo.scp 
b/scp2/source/ooo/file_resource_ooo.scp
index 29559dc..67a30ed 100644
--- a/scp2/source/ooo/file_resource_ooo.scp
+++ b/scp2/source/ooo/file_resource_ooo.scp
@@ -27,8 +27,12 @@
 
 #include macros.inc
 
+#ifndef DISABLE_SCRIPTING
+
 STD_RES_FILE( gid_File_Res_Basctl, basctl)
 
+#endif
+
 STD_RES_FILE( gid_File_Res_Bib, bib )
 
 STD_RES_FILE( gid_File_Res_Chartcontroller, chartcontroller )

-- 
To view, visit https://gerrit.libreoffice.org/2510
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98dbd3e46c81e1dd056d6e88dc1e526b5af456f5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Add new dialog to Query Design View

2013-03-02 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2508

to look at the new rebased patch set (#2).

Change subject: Add new dialog to Query Design View
..

Add new dialog to Query Design View

In Query Properties Dialog can be set properties like
distinct values and limit.
To open choose Edit\Query Properties.

Steps of implementation:
- Add new slot to Edit menu (menubar.xml): delete the slot of distinct values,
  because it can set in this dialog too
- Separate LimitBox class from limitboxcontroller.cxx (LimitBox.hxx\cxx)
  With it only LimitBox header is included in the dialog source.
- Extend LimitBox class to work with new layout widget (make... and 
GetOptimalSize())
  and add it to the galde catalog
- Make a class for the new dialog (QueryPropertiesDialog.hxx\cxx) and
  write the .ui file. (querypropertiesdialog.ui)
- Syncronize the two LimitBox (querycontroller.cxx)

Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
---
M dbaccess/Library_dbu.mk
M dbaccess/Module_dbaccess.mk
A dbaccess/UI_dbaccess.mk
M dbaccess/inc/dbaccess_slotid.hrc
A dbaccess/source/ui/dlg/QueryPropertiesDialog.cxx
A dbaccess/source/ui/inc/LimitBox.hxx
A dbaccess/source/ui/inc/QueryPropertiesDialog.hxx
M dbaccess/source/ui/inc/querycontroller.hxx
A dbaccess/source/ui/querydesign/LimitBox.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.hxx
M dbaccess/source/ui/querydesign/querycontroller.cxx
M dbaccess/uiconfig/dbquery/menubar/menubar.xml
A dbaccess/uiconfig/ui/querypropertiesdialog.ui
M extras/source/glade/libreoffice-catalog.xml
M officecfg/registry/data/org/openoffice/Office/UI/DbuCommands.xcu
16 files changed, 613 insertions(+), 135 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2508/2
-- 
To view, visit https://gerrit.libreoffice.org/2508
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] remove minor.mk

2013-03-02 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2491

Approvals:
  LibreOffice gerrit bot: Verified
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2491
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49108007ee6d045f045de86c8654efc7ca5fd3d0
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Correct spelling errors in comments.

2013-03-02 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2509

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2509
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I360d4672225ba86466d5ecf0abf615172a7c3659
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] [PUSHED] convert moz to gbuild and add to tail_build

2013-02-24 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2349

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2349
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d3f5d127f831ee9abc020d46558f7cfbe8c9380
Gerrit-PatchSet: 10
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] instsetoo_native: convert to gbuild

2013-02-24 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2242

to look at the new rebased patch set (#13).

Change subject: instsetoo_native: convert to gbuild
..

instsetoo_native: convert to gbuild

Removes:
 * instsetoo_native/util/update.xml
  - gen_update_info.pl can be removed ?

  On Windows the binary artifacts are created now in:
  workdir/*/installation/LibreOffice_Dev/native/install/en-US/*.msi

Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
---
M Makefile.in
A instsetoo_native/CustomTarget_install.mk
A instsetoo_native/Makefile
A instsetoo_native/Module_instsetoo_native.mk
M instsetoo_native/README
R instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
R instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
D instsetoo_native/inc_openoffice/unix/makefile.mk
D instsetoo_native/inc_openoffice/windows/msi_languages/makefile.mk
D instsetoo_native/prj/build.lst
D instsetoo_native/prj/d.lst
D instsetoo_native/prj/dmake
D instsetoo_native/util/makefile.mk
D instsetoo_native/util/update.xml
M scp2/source/python/file_python.scp
M solenv/bin/modules/installer/control.pm
M solenv/bin/modules/installer/windows/idtglobal.pm
17 files changed, 167 insertions(+), 516 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2242/13
-- 
To view, visit https://gerrit.libreoffice.org/2242
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
Gerrit-PatchSet: 13
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Andras Timar ati...@suse.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] [PUSHED] instsetoo_native: convert to gbuild

2013-02-24 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2242

Approvals:
  LibreOffice gerrit bot: Verified
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2242
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
Gerrit-PatchSet: 14
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Andras Timar ati...@suse.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] [PUSHED] add solenv to tail_build

2013-02-24 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2373

Approvals:
  LibreOffice gerrit bot: Verified
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2373
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8987f0d45ed5360d49f3589b418209488267863
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] instsetoo_native: convert to gbuild

2013-02-23 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2242

to look at the new rebased patch set (#11).

Change subject: instsetoo_native: convert to gbuild
..

instsetoo_native: convert to gbuild

Removes:
 * instsetoo_native/util/update.xml
  - gen_update_info.pl can be removed ?

  On Windows the binary artifacts are created now in:
  workdir/*/installation/LibreOffice_Dev/native/install/en-US/*.msi

Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
---
M Makefile.in
A instsetoo_native/CustomTarget_install.mk
A instsetoo_native/Makefile
A instsetoo_native/Module_instsetoo_native.mk
M instsetoo_native/README
R instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
R instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
D instsetoo_native/inc_openoffice/unix/makefile.mk
D instsetoo_native/inc_openoffice/windows/msi_languages/makefile.mk
D instsetoo_native/prj/build.lst
D instsetoo_native/prj/d.lst
D instsetoo_native/prj/dmake
D instsetoo_native/util/makefile.mk
D instsetoo_native/util/update.xml
M scp2/source/python/file_python.scp
M solenv/bin/modules/installer/control.pm
M solenv/bin/modules/installer/windows/idtglobal.pm
17 files changed, 138 insertions(+), 515 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2242/11
-- 
To view, visit https://gerrit.libreoffice.org/2242
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
Gerrit-PatchSet: 11
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Andras Timar ati...@suse.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] convert moz to gbuild and add to tail_build

2013-02-23 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2349

to look at the new rebased patch set (#6).

Change subject: convert moz to gbuild and add to tail_build
..

convert moz to gbuild and add to tail_build

Change-Id: I2d3f5d127f831ee9abc020d46558f7cfbe8c9380
---
M Makefile.fetch
M Makefile.in
M Module_tail_build.mk
M RepositoryExternal.mk
M RepositoryModule_ooo.mk
M configure.ac
M download.lst
A moz/CustomTarget_runtime.mk
A moz/ExternalPackage_moz_inc.mk
A moz/ExternalPackage_moz_lib.mk
A moz/Makefile
A moz/Module_moz.mk
A moz/Package_runtime.mk
A moz/UnpackedTarball_moz_inc.mk
A moz/UnpackedTarball_moz_lib.mk
D moz/extractfiles.mk
D moz/makefile.mk
D moz/patches/aix_build_fix.patch
D moz/patches/arm_build_fix.patch
D moz/patches/brokenmakefile.patch
D 
moz/patches/clang_add_nsCaseInsensitiveStringComparator_default_constructor.patch
D moz/patches/clang_missing_this_pointers.patch
D moz/patches/consecutive_ldap_queries.patch
D moz/patches/cygwin_paths_in_ldap_sdk.patch
D moz/patches/dtoa.patch
D moz/patches/embed_manifest.patch
D moz/patches/index.txt
D moz/patches/libpr0n_build_fix.patch
D moz/patches/link_fontconfig.patch
D moz/patches/macosx_build_fix.patch
D moz/patches/no_core_abspath_in_nss.patch
D moz/patches/nss-linux3.patch
D moz/patches/respect_disable_pango.patch
D moz/patches/seamonkey-1.1.14.source-macosx10.6and7.patch
D moz/patches/ssl-linux-no_as_needed_linker_option.patch
D moz/patches/wchart_on_msvc8.patch
M moz/prj/build.lst
M moz/prj/d.lst
D moz/prj/dmake
D moz/seamonkey-source-1.1.14.patch
D moz/zipped/makefile.mk
M openldap/ExternalProject_openldap.mk
M solenv/gbuild/LinkTarget.mk
M solenv/gbuild/UnoApiTarget.mk
M tail_build/prj/build.lst
45 files changed, 160 insertions(+), 8,520 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/2349/6
-- 
To view, visit https://gerrit.libreoffice.org/2349
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d3f5d127f831ee9abc020d46558f7cfbe8c9380
Gerrit-PatchSet: 6
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] convert moz to gbuild and add to tail_build

2013-02-23 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2349

to look at the new patch set (#7).

Change subject: convert moz to gbuild and add to tail_build
..

convert moz to gbuild and add to tail_build

Change-Id: I2d3f5d127f831ee9abc020d46558f7cfbe8c9380
---
M Makefile.fetch
M Makefile.in
M Module_tail_build.mk
M RepositoryExternal.mk
M RepositoryModule_ooo.mk
M configure.ac
M download.lst
A moz/CustomTarget_runtime.mk
A moz/ExternalPackage_moz_inc.mk
A moz/ExternalPackage_moz_lib.mk
A moz/Makefile
A moz/Module_moz.mk
A moz/Package_runtime.mk
A moz/UnpackedTarball_moz_inc.mk
A moz/UnpackedTarball_moz_lib.mk
D moz/extractfiles.mk
D moz/makefile.mk
D moz/patches/aix_build_fix.patch
D moz/patches/arm_build_fix.patch
D moz/patches/brokenmakefile.patch
D 
moz/patches/clang_add_nsCaseInsensitiveStringComparator_default_constructor.patch
D moz/patches/clang_missing_this_pointers.patch
D moz/patches/consecutive_ldap_queries.patch
D moz/patches/cygwin_paths_in_ldap_sdk.patch
D moz/patches/dtoa.patch
D moz/patches/embed_manifest.patch
D moz/patches/index.txt
D moz/patches/libpr0n_build_fix.patch
D moz/patches/link_fontconfig.patch
D moz/patches/macosx_build_fix.patch
D moz/patches/no_core_abspath_in_nss.patch
D moz/patches/nss-linux3.patch
D moz/patches/respect_disable_pango.patch
D moz/patches/seamonkey-1.1.14.source-macosx10.6and7.patch
D moz/patches/ssl-linux-no_as_needed_linker_option.patch
D moz/patches/wchart_on_msvc8.patch
M moz/prj/build.lst
M moz/prj/d.lst
D moz/prj/dmake
D moz/seamonkey-source-1.1.14.patch
D moz/zipped/makefile.mk
M openldap/ExternalProject_openldap.mk
M solenv/gbuild/LinkTarget.mk
M solenv/gbuild/UnoApiTarget.mk
M tail_build/prj/build.lst
45 files changed, 159 insertions(+), 8,520 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/2349/7
-- 
To view, visit https://gerrit.libreoffice.org/2349
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d3f5d127f831ee9abc020d46558f7cfbe8c9380
Gerrit-PatchSet: 7
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] convert moz to gbuild and add to tail_build

2013-02-23 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2349

to look at the new patch set (#8).

Change subject: convert moz to gbuild and add to tail_build
..

convert moz to gbuild and add to tail_build

Change-Id: I2d3f5d127f831ee9abc020d46558f7cfbe8c9380
---
M Makefile.fetch
M Makefile.in
M Module_tail_build.mk
M RepositoryExternal.mk
M RepositoryModule_ooo.mk
M configure.ac
M download.lst
A moz/CustomTarget_runtime.mk
A moz/ExternalPackage_moz_inc.mk
A moz/ExternalPackage_moz_lib.mk
A moz/Makefile
A moz/Module_moz.mk
A moz/Package_runtime.mk
A moz/UnpackedTarball_moz_inc.mk
A moz/UnpackedTarball_moz_lib.mk
D moz/extractfiles.mk
D moz/makefile.mk
D moz/patches/aix_build_fix.patch
D moz/patches/arm_build_fix.patch
D moz/patches/brokenmakefile.patch
D 
moz/patches/clang_add_nsCaseInsensitiveStringComparator_default_constructor.patch
D moz/patches/clang_missing_this_pointers.patch
D moz/patches/consecutive_ldap_queries.patch
D moz/patches/cygwin_paths_in_ldap_sdk.patch
D moz/patches/dtoa.patch
D moz/patches/embed_manifest.patch
D moz/patches/index.txt
D moz/patches/libpr0n_build_fix.patch
D moz/patches/link_fontconfig.patch
D moz/patches/macosx_build_fix.patch
D moz/patches/no_core_abspath_in_nss.patch
D moz/patches/nss-linux3.patch
D moz/patches/respect_disable_pango.patch
D moz/patches/seamonkey-1.1.14.source-macosx10.6and7.patch
D moz/patches/ssl-linux-no_as_needed_linker_option.patch
D moz/patches/wchart_on_msvc8.patch
M moz/prj/build.lst
M moz/prj/d.lst
D moz/prj/dmake
D moz/seamonkey-source-1.1.14.patch
D moz/zipped/makefile.mk
M openldap/ExternalProject_openldap.mk
M solenv/gbuild/LinkTarget.mk
M solenv/gbuild/UnoApiTarget.mk
M tail_build/prj/build.lst
45 files changed, 159 insertions(+), 8,520 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/2349/8
-- 
To view, visit https://gerrit.libreoffice.org/2349
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d3f5d127f831ee9abc020d46558f7cfbe8c9380
Gerrit-PatchSet: 8
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] instsetoo_native: convert to gbuild

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2242

to look at the new patch set (#2).

Change subject: instsetoo_native: convert to gbuild
..

instsetoo_native: convert to gbuild

Removes:
 * instsetoo_native/inc_openoffice/unix/*
 * instsetoo_native/util/update.xml
- gen_update_info.pl can be removed ?

Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
---
M Makefile.in
A instsetoo_native/CustomTarget_install.mk
A instsetoo_native/Makefile
A instsetoo_native/Module_instsetoo_native.mk
M instsetoo_native/README
R instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
R instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
D instsetoo_native/inc_openoffice/unix/find-requires-gnome.sh
D instsetoo_native/inc_openoffice/unix/find-requires-x11.sh
D instsetoo_native/inc_openoffice/unix/makefile.mk
D instsetoo_native/inc_openoffice/windows/msi_languages/makefile.mk
D instsetoo_native/prj/build.lst
D instsetoo_native/prj/d.lst
D instsetoo_native/prj/dmake
D instsetoo_native/util/makefile.mk
D instsetoo_native/util/update.xml
M scp2/source/python/file_python.scp
17 files changed, 146 insertions(+), 567 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2242/2
-- 
To view, visit https://gerrit.libreoffice.org/2242
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] instsetoo_native: convert to gbuild

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2242

to look at the new rebased patch set (#3).

Change subject: instsetoo_native: convert to gbuild
..

instsetoo_native: convert to gbuild

Removes:
 * instsetoo_native/inc_openoffice/unix/*
 * instsetoo_native/util/update.xml
- gen_update_info.pl can be removed ?

Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
---
M Makefile.in
A instsetoo_native/CustomTarget_install.mk
A instsetoo_native/Makefile
A instsetoo_native/Module_instsetoo_native.mk
M instsetoo_native/README
R instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
R instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
D instsetoo_native/inc_openoffice/unix/find-requires-gnome.sh
D instsetoo_native/inc_openoffice/unix/find-requires-x11.sh
D instsetoo_native/inc_openoffice/unix/makefile.mk
D instsetoo_native/inc_openoffice/windows/msi_languages/makefile.mk
D instsetoo_native/prj/build.lst
D instsetoo_native/prj/d.lst
D instsetoo_native/prj/dmake
D instsetoo_native/util/makefile.mk
D instsetoo_native/util/update.xml
M scp2/source/python/file_python.scp
17 files changed, 146 insertions(+), 567 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2242/3
-- 
To view, visit https://gerrit.libreoffice.org/2242
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] convert odk to gbuild and add to tail_build

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2288

to look at the new patch set (#8).

Change subject: convert odk to gbuild and add to tail_build
..

convert odk to gbuild and add to tail_build

Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
---
M Module_tail_build.mk
M Repository.mk
M RepositoryModule_ooo.mk
A odk/CustomTarget_autodoc.mk
A odk/CustomTarget_bin.mk
A odk/CustomTarget_check.mk
A odk/CustomTarget_classes.mk
A odk/CustomTarget_cli.mk
A odk/CustomTarget_doxygen.mk
A odk/CustomTarget_idl.mk
A odk/CustomTarget_include.mk
A odk/CustomTarget_javadoc.mk
A odk/CustomTarget_lib.mk
A odk/CustomTarget_odkcommon.mk
A odk/CustomTarget_settings.mk
A odk/CustomTarget_unowinreg.mk
A odk/Executable_unoapploader.mk
A odk/Library_unowinreg.mk
A odk/Makefile
A odk/Module_odk.mk
A odk/Zip_odkcommon.mk
A odk/Zip_odkexamples.mk
A odk/Zip_uno_loader_classes.mk
R odk/config/cfgWin.js
R odk/config/configure.pl
R odk/config/setsdkenv_unix
R odk/config/setsdkenv_unix.csh.in
R odk/config/setsdkenv_unix.sh.in
R odk/config/setsdkenv_windows.bat
R odk/config/setsdkenv_windows.template
R odk/config/setsdkname.bat
D odk/inc/makefile.mk
D odk/pack/checkbin/makefile.mk
D odk/pack/checkidl/makefile.mk
D odk/pack/checkinc/makefile.mk
D odk/pack/checkinc2/makefile.mk
D odk/pack/copying/makefile.mk
D odk/pack/gendocu/makefile.mk
D odk/pack/unzip_udk/deltree.txt
D odk/pack/unzip_udk/makefile.mk
M odk/prj/build.lst
M odk/prj/d.lst
D odk/prj/dmake
D odk/source/com/sun/star/lib/loader/makefile.mk
D odk/source/unoapploader/unx/makefile.mk
D odk/source/unoapploader/win/makefile.mk
D odk/source/unowinreg/win/makefile.mk
A odk/source/unowinreg/win/unowinreg.def
D odk/source/unowinreg/win/unowinreg.dxp
D odk/util/delzip
D odk/util/makefile.mk
D odk/util/makefile.pmk
D odk/util/odk_rules.pmk
M postprocess/prj/build.lst
M solenv/gbuild/Zip.mk
55 files changed, 979 insertions(+), 1,468 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2288/8
-- 
To view, visit https://gerrit.libreoffice.org/2288
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
Gerrit-PatchSet: 8
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] instsetoo_native: convert to gbuild

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2242

to look at the new patch set (#4).

Change subject: instsetoo_native: convert to gbuild
..

instsetoo_native: convert to gbuild

Removes:
 * instsetoo_native/inc_openoffice/unix/*
 * instsetoo_native/util/update.xml
- gen_update_info.pl can be removed ?

Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
---
M Makefile.in
A instsetoo_native/CustomTarget_install.mk
A instsetoo_native/Makefile
A instsetoo_native/Module_instsetoo_native.mk
M instsetoo_native/README
R instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
R instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
D instsetoo_native/inc_openoffice/unix/find-requires-gnome.sh
D instsetoo_native/inc_openoffice/unix/find-requires-x11.sh
D instsetoo_native/inc_openoffice/unix/makefile.mk
D instsetoo_native/inc_openoffice/windows/msi_languages/makefile.mk
D instsetoo_native/prj/build.lst
D instsetoo_native/prj/d.lst
D instsetoo_native/prj/dmake
D instsetoo_native/util/makefile.mk
D instsetoo_native/util/update.xml
M scp2/source/python/file_python.scp
17 files changed, 146 insertions(+), 567 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2242/4
-- 
To view, visit https://gerrit.libreoffice.org/2242
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] instsetoo_native: convert to gbuild

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2242

to look at the new patch set (#5).

Change subject: instsetoo_native: convert to gbuild
..

instsetoo_native: convert to gbuild

Removes:
 * instsetoo_native/inc_openoffice/unix/*
 * instsetoo_native/util/update.xml
- gen_update_info.pl can be removed ?

Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
---
M Makefile.in
A instsetoo_native/CustomTarget_install.mk
A instsetoo_native/Makefile
A instsetoo_native/Module_instsetoo_native.mk
M instsetoo_native/README
R instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
R instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
D instsetoo_native/inc_openoffice/unix/find-requires-gnome.sh
D instsetoo_native/inc_openoffice/unix/find-requires-x11.sh
D instsetoo_native/inc_openoffice/unix/makefile.mk
D instsetoo_native/inc_openoffice/windows/msi_languages/makefile.mk
D instsetoo_native/prj/build.lst
D instsetoo_native/prj/d.lst
D instsetoo_native/prj/dmake
D instsetoo_native/util/makefile.mk
D instsetoo_native/util/update.xml
M scp2/source/python/file_python.scp
17 files changed, 149 insertions(+), 567 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2242/5
-- 
To view, visit https://gerrit.libreoffice.org/2242
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
Gerrit-PatchSet: 5
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] convert odk to gbuild and add to tail_build

2013-02-20 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2288

to look at the new patch set (#2).

Change subject: convert odk to gbuild and add to tail_build
..

convert odk to gbuild and add to tail_build

Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
---
M Module_tail_build.mk
M Repository.mk
M RepositoryModule_ooo.mk
A odk/CustomTarget_check.mk
A odk/CustomTarget_gendocu.mk
A odk/CustomTarget_javadollar.mk
A odk/CustomTarget_odkcommon.mk
A odk/CustomTarget_unowinreg.mk
A odk/Executable_unoapploader.mk
A odk/Library_unowinreg.mk
A odk/Makefile
A odk/Module_odk.mk
A odk/Zip_odkcommon.mk
A odk/Zip_odkexamples.mk
A odk/Zip_uno_loader_classes.mk
R odk/config/cfgWin.js
R odk/config/configure.pl
R odk/config/setsdkenv_unix
R odk/config/setsdkenv_unix.csh.in
R odk/config/setsdkenv_unix.sh.in
R odk/config/setsdkenv_windows.bat
R odk/config/setsdkenv_windows.template
R odk/config/setsdkname.bat
D odk/inc/makefile.mk
D odk/pack/checkbin/makefile.mk
D odk/pack/checkidl/makefile.mk
D odk/pack/checkinc/makefile.mk
D odk/pack/checkinc2/makefile.mk
D odk/pack/copying/makefile.mk
D odk/pack/gendocu/makefile.mk
D odk/pack/unzip_udk/deltree.txt
D odk/pack/unzip_udk/makefile.mk
M odk/prj/build.lst
M odk/prj/d.lst
D odk/prj/dmake
D odk/source/com/sun/star/lib/loader/makefile.mk
D odk/source/unoapploader/unx/makefile.mk
D odk/source/unoapploader/win/makefile.mk
D odk/source/unowinreg/win/makefile.mk
D odk/source/unowinreg/win/unowinreg.dxp
D odk/util/delzip
D odk/util/makefile.mk
D odk/util/makefile.pmk
D odk/util/odk_rules.pmk
M postprocess/prj/build.lst
M solenv/gbuild/Zip.mk
46 files changed, 966 insertions(+), 1,468 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2288/2
-- 
To view, visit https://gerrit.libreoffice.org/2288
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] convert odk to gbuild and add to tail_build

2013-02-20 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2288

to look at the new patch set (#3).

Change subject: convert odk to gbuild and add to tail_build
..

convert odk to gbuild and add to tail_build

Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
---
M Module_tail_build.mk
M Repository.mk
M RepositoryModule_ooo.mk
A odk/CustomTarget_check.mk
A odk/CustomTarget_gendocu.mk
A odk/CustomTarget_javadollar.mk
A odk/CustomTarget_odkcommon.mk
A odk/CustomTarget_unowinreg.mk
A odk/Executable_unoapploader.mk
A odk/Library_unowinreg.mk
A odk/Makefile
A odk/Module_odk.mk
A odk/Zip_odkcommon.mk
A odk/Zip_odkexamples.mk
A odk/Zip_uno_loader_classes.mk
R odk/config/cfgWin.js
R odk/config/configure.pl
R odk/config/setsdkenv_unix
R odk/config/setsdkenv_unix.csh.in
R odk/config/setsdkenv_unix.sh.in
R odk/config/setsdkenv_windows.bat
R odk/config/setsdkenv_windows.template
R odk/config/setsdkname.bat
D odk/inc/makefile.mk
D odk/pack/checkbin/makefile.mk
D odk/pack/checkidl/makefile.mk
D odk/pack/checkinc/makefile.mk
D odk/pack/checkinc2/makefile.mk
D odk/pack/copying/makefile.mk
D odk/pack/gendocu/makefile.mk
D odk/pack/unzip_udk/deltree.txt
D odk/pack/unzip_udk/makefile.mk
M odk/prj/build.lst
M odk/prj/d.lst
D odk/prj/dmake
D odk/source/com/sun/star/lib/loader/makefile.mk
D odk/source/unoapploader/unx/makefile.mk
D odk/source/unoapploader/win/makefile.mk
D odk/source/unowinreg/win/makefile.mk
D odk/source/unowinreg/win/unowinreg.dxp
D odk/util/delzip
D odk/util/makefile.mk
D odk/util/makefile.pmk
D odk/util/odk_rules.pmk
M postprocess/prj/build.lst
M solenv/gbuild/Zip.mk
46 files changed, 966 insertions(+), 1,468 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2288/3
-- 
To view, visit https://gerrit.libreoffice.org/2288
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] [PUSHED] convert sysui to gbuild and add to tail_build

2013-02-17 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2192

Approvals:
  LibreOffice gerrit bot: Verified
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2192
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a
Gerrit-PatchSet: 10
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] proposal: move towards killing UNOLIBS_OOO and merge libs to...

2013-02-16 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2169

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2169
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2106dd2afb71861acf3de7d21a2283473ea2110c
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fix cross compiling with icu 50.1.2

2013-02-12 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2112

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/2112/1

fix cross compiling with icu 50.1.2

Change-Id: Ib112a2d3f9a75890591137a78b46be982b7d43df
---
M configure.ac
1 file changed, 7 insertions(+), 0 deletions(-)



diff --git a/configure.ac b/configure.ac
index 55e4d73..abfd30b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8611,6 +8611,13 @@
 fi
 fi
 
+if test $cross_compiling = yes; then
+   if test $ICU_MAJOR -ge 50; then
+AC_MSG_RESULT([Ignore ICU_MINOR as obviously the libraries don't 
include the minor version in their names any more])
+ICU_MINOR=
+fi
+fi
+
 libo_MINGW_CHECK_DLL([ICUDATA], [icudata][$ICU_MAJOR][$ICU_MINOR])
 libo_MINGW_CHECK_DLL([ICUI18N], [icui18n][$ICU_MAJOR][$ICU_MINOR])
 libo_MINGW_CHECK_DLL([ICUUC], [icuuc][$ICU_MAJOR][$ICU_MINOR])

-- 
To view, visit https://gerrit.libreoffice.org/2112
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib112a2d3f9a75890591137a78b46be982b7d43df
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] xmlsecurity: remove obsolete tools directory

2013-02-11 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1608

Approvals:
  LibreOffice gerrit bot: Verified
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1608
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a1df11c18eb5932651ee381fae29f2ac0697b6a
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] convert setup_native to gbuild and add to tail_build

2013-02-09 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2063

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2063
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie12338dada22c59d55d89ed9611bb1a958b04223
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] ORowSetValue: move float and double to union

2013-02-07 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2021

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/2021/1

ORowSetValue: move float and double to union

Change-Id: Ic5de8ad2cf9ef1143b1a5468e5fc5c9974aca5ec
---
M connectivity/inc/connectivity/FValue.hxx
M connectivity/qa/connectivity/commontools/FValue_test.cxx
M connectivity/source/commontools/FValue.cxx
3 files changed, 98 insertions(+), 75 deletions(-)



diff --git a/connectivity/inc/connectivity/FValue.hxx 
b/connectivity/inc/connectivity/FValue.hxx
index 3f72b41..02b4a4b 100644
--- a/connectivity/inc/connectivity/FValue.hxx
+++ b/connectivity/inc/connectivity/FValue.hxx
@@ -60,9 +60,12 @@
 sal_Int64   m_nInt64;
 sal_uInt64  m_uInt64;
 
+float   m_nFloat;
+double  m_nDouble;
+
 rtl_uString*m_pString;
 
-void*   m_pValue;   // can contains double, etc
+void*   m_pValue;   // date/time/timestamp/sequence
 } m_aValue;
 
 sal_Int32   m_eTypeKind;// the database type
diff --git a/connectivity/qa/connectivity/commontools/FValue_test.cxx 
b/connectivity/qa/connectivity/commontools/FValue_test.cxx
index be3024e..9e1b4dd 100644
--- a/connectivity/qa/connectivity/commontools/FValue_test.cxx
+++ b/connectivity/qa/connectivity/commontools/FValue_test.cxx
@@ -43,6 +43,9 @@
 void test_Int64();
 void test_uInt64();
 
+void test_float();
+void test_double();
+
 CPPUNIT_TEST_SUITE(FValueTest);
 
 CPPUNIT_TEST(test_Bool);
@@ -58,6 +61,9 @@
 
 CPPUNIT_TEST(test_Int64);
 CPPUNIT_TEST(test_uInt64);
+
+CPPUNIT_TEST(test_float);
+CPPUNIT_TEST(test_double);
 
 CPPUNIT_TEST_SUITE_END();
 };
@@ -239,6 +245,44 @@
 CPPUNIT_ASSERT_MESSAGE(sal_uInt64 conversion from Any didn't work, 
src_saluInt64 == trg_saluInt64);
 }
 
+void FValueTest::test_float()
+{
+float src_float = 1.2f;
+ORowSetValue v(src_float);
+float trg_float = v.getFloat();
+
+std::cerr  src_float:   src_float  std::endl;
+std::cerr  trg_float:   trg_float  std::endl;
+
+CPPUNIT_ASSERT_MESSAGE(float conversion to ORowSetValue didn't work, 
src_float == trg_float);
+
+Any any_float = v.makeAny();
+ORowSetValue t;
+t.fill(any_float);
+trg_float = t.getFloat();
+
+CPPUNIT_ASSERT_MESSAGE(float conversion from Any didn't work, src_float 
== trg_float);
+}
+
+void FValueTest::test_double()
+{
+double src_double = 1.23456789d;
+ORowSetValue v(src_double);
+double trg_double = v.getDouble();
+
+std::cerr  src_double:   src_double  std::endl;
+std::cerr  trg_double:   trg_double  std::endl;
+
+CPPUNIT_ASSERT_MESSAGE(double conversion to ORowSetValue didn't work, 
src_double == trg_double);
+
+Any any_double = v.makeAny();
+ORowSetValue t;
+t.fill(any_double);
+trg_double = t.getDouble();
+
+CPPUNIT_ASSERT_MESSAGE(double conversion from Any didn't work, 
src_double == trg_double);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(FValueTest);
 
 }}
diff --git a/connectivity/source/commontools/FValue.cxx 
b/connectivity/source/commontools/FValue.cxx
index e4580dd..fef5087 100644
--- a/connectivity/source/commontools/FValue.cxx
+++ b/connectivity/source/commontools/FValue.cxx
@@ -274,17 +274,6 @@
 rtl_uString_release(m_aValue.m_pString);
 m_aValue.m_pString = NULL;
 break;
-case DataType::FLOAT:
-delete (float*)m_aValue.m_pValue;
-TRACE_FREE( float )
-m_aValue.m_pValue = NULL;
-break;
-case DataType::DOUBLE:
-case DataType::REAL:
-delete (double*)m_aValue.m_pValue;
-TRACE_FREE( double )
-m_aValue.m_pValue = NULL;
-break;
 case DataType::DATE:
 delete (::com::sun::star::util::Date*)m_aValue.m_pValue;
 TRACE_FREE( Date )
@@ -320,6 +309,9 @@
 case DataType::INTEGER:
 case DataType::BIGINT:
 case DataType::BOOLEAN:
+case DataType::FLOAT:
+case DataType::DOUBLE:
+case DataType::REAL:
 break;
 default:
 if ( m_aValue.m_pValue )
@@ -358,15 +350,6 @@
 case DataType::LONGVARCHAR:
 rtl_uString_acquire(_rRH.m_aValue.m_pString);
 m_aValue.m_pString = _rRH.m_aValue.m_pString;
-break;
-case DataType::FLOAT:
-m_aValue.m_pValue   = new 
float(*(float*)_rRH.m_aValue.m_pValue);
-TRACE_ALLOC( float )
-break;
-case DataType::DOUBLE:
-case DataType::REAL:
-m_aValue.m_pValue   = new 
double(*(double*)_rRH.m_aValue.m_pValue);
-TRACE_ALLOC( 

[PATCH libreoffice-4-0] fdo#57417: remove LDAP choice from non windows platform

2013-02-07 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2022

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/2022/1

fdo#57417: remove LDAP choice from non windows platform

Change-Id: I0557a7c9cf0d18fbe5620ef8869bb83d0a6a7904
Reviewed-on: https://gerrit.libreoffice.org/1983
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
---
M extensions/source/abpilot/typeselectionpage.cxx
1 file changed, 10 insertions(+), 15 deletions(-)



diff --git a/extensions/source/abpilot/typeselectionpage.cxx 
b/extensions/source/abpilot/typeselectionpage.cxx
index 6ce6280..e5295e1 100644
--- a/extensions/source/abpilot/typeselectionpage.cxx
+++ b/extensions/source/abpilot/typeselectionpage.cxx
@@ -67,13 +67,12 @@
 // On Linux:
 // - EVOLUTION, EVOLUTION_GROUPWISE, EVOLUTION_LDAP (if applicable)
 // - MORK (via mork driver, which is built unconditionally)
-// - THUNDERBIRD (via mork driver?, which is built unconditionally)
 // - KAB (if applicable)
-// - LDAP (via mork driver?, which is built unconditionally)
 // - OTHER
 //
 // On Mac OS X:
 // - MACAB (if applicable)
+// - MORK (via mork driver, which is built unconditionally)
 // - OTHER
 //
 // On Windows:
@@ -81,22 +80,18 @@
 //   if WITH_MOZILLA)
 // - OTHER
 
-bool bWithMozilla = false, bWindows = false;
-bool bHaveEvolution = false, bHaveKab = false;
+bool bWithMozilla = false;
+bool bHaveEvolution = false;
+bool bHaveKab = false;
 bool bHaveMacab = false;
+bool bWithMork = false;
 
 #if defined WNT
-
 #if defined WITH_MOZILLA
 bWithMozilla = true;
 #endif
-bWindows = true;
-
 #else
-
-#if !defined MACOSX
-bWithMozilla = true;
-#endif
+bWithMork = true;
 
 Reference XDriverAccess 
xManager(_pParent-getORB()-createInstance(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.sdbc.DriverManager))),
 UNO_QUERY);
 
@@ -139,13 +134,13 @@
 m_aAllTypes.push_back( ButtonItem( m_aEvolution, AST_EVOLUTION, 
bHaveEvolution ) );
 m_aAllTypes.push_back( ButtonItem( m_aEvolutionGroupwise, 
AST_EVOLUTION_GROUPWISE, bHaveEvolution ) );
 m_aAllTypes.push_back( ButtonItem( m_aEvolutionLdap, 
AST_EVOLUTION_LDAP, bHaveEvolution ) );
-m_aAllTypes.push_back( ButtonItem( m_aMORK, AST_MORK, bWithMozilla ) 
);
-m_aAllTypes.push_back( ButtonItem( m_aThunderbird, AST_THUNDERBIRD, 
bWithMozilla ) );
+m_aAllTypes.push_back( ButtonItem( m_aMORK, AST_MORK, bWithMozilla || 
bWithMork) );
+m_aAllTypes.push_back( ButtonItem( m_aThunderbird, AST_THUNDERBIRD, 
bWithMozilla || bWithMork) );
 m_aAllTypes.push_back( ButtonItem( m_aKab, AST_KAB, bHaveKab ) );
 m_aAllTypes.push_back( ButtonItem( m_aMacab, AST_MACAB, bHaveMacab ) 
);
 m_aAllTypes.push_back( ButtonItem( m_aLDAP, AST_LDAP, bWithMozilla ) 
);
-m_aAllTypes.push_back( ButtonItem( m_aOutlook, AST_OUTLOOK, 
bWithMozilla  bWindows ) );
-m_aAllTypes.push_back( ButtonItem( m_aOE, AST_OE, bWithMozilla  
bWindows ) );
+m_aAllTypes.push_back( ButtonItem( m_aOutlook, AST_OUTLOOK, 
bWithMozilla ) );
+m_aAllTypes.push_back( ButtonItem( m_aOE, AST_OE, bWithMozilla ) );
 m_aAllTypes.push_back( ButtonItem( m_aOther, AST_OTHER, true ) );
 
 Link aTypeSelectionHandler = LINK(this, TypeSelectionPage, 
OnTypeSelected );

-- 
To view, visit https://gerrit.libreoffice.org/2022
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0557a7c9cf0d18fbe5620ef8869bb83d0a6a7904
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] O(U)String::valueOf don't duplicate code

2013-02-05 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1992

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/1992/1

O(U)String::valueOf don't duplicate code

Change-Id: I586fca181f63999a8f2d19d600b69f6788fd61d9
---
M sal/inc/rtl/string.hxx
M sal/inc/rtl/ustring.hxx
2 files changed, 2 insertions(+), 8 deletions(-)



diff --git a/sal/inc/rtl/string.hxx b/sal/inc/rtl/string.hxx
index 05ba18f..345827c 100644
--- a/sal/inc/rtl/string.hxx
+++ b/sal/inc/rtl/string.hxx
@@ -1540,10 +1540,7 @@
 */
 SAL_DEPRECATED_INTERNAL(use number()) static OString valueOf( sal_Int32 
i, sal_Int16 radix = 10 ) SAL_THROW(())
 {
-sal_Char aBuf[RTL_STR_MAX_VALUEOFINT32];
-rtl_String* pNewData = 0;
-rtl_string_newFromStr_WithLength( pNewData, aBuf, 
rtl_str_valueOfInt32( aBuf, i, radix ) );
-return OString( pNewData, (DO_NOT_ACQUIRE*)0 );
+return number( i, radix );
 }
 
 /**
diff --git a/sal/inc/rtl/ustring.hxx b/sal/inc/rtl/ustring.hxx
index f7d793a..7024bf4 100644
--- a/sal/inc/rtl/ustring.hxx
+++ b/sal/inc/rtl/ustring.hxx
@@ -2191,10 +2191,7 @@
 */
 SAL_DEPRECATED_INTERNAL(use number()) static OUString valueOf( sal_Int32 
i, sal_Int16 radix = 10 ) SAL_THROW(())
 {
-sal_Unicode aBuf[RTL_USTR_MAX_VALUEOFINT32];
-rtl_uString* pNewData = 0;
-rtl_uString_newFromStr_WithLength( pNewData, aBuf, 
rtl_ustr_valueOfInt32( aBuf, i, radix ) );
-return OUString( pNewData, (DO_NOT_ACQUIRE*)0 );
+return number( i, radix );
 }
 
 /**

-- 
To view, visit https://gerrit.libreoffice.org/1992
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I586fca181f63999a8f2d19d600b69f6788fd61d9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] write double/float via union with unsigned type for strict-a...

2013-02-05 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1990

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1990
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4dd1d41e5cde27ec5b144ca4b7c97276ff62479
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] add OUString::toUInt64()

2013-02-04 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1980

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/1980/1

add OUString::toUInt64()

Change-Id: I2051e161219d424d2c2b69faf6f939cfe21fa5f7
---
M sal/inc/rtl/ustring.h
M sal/inc/rtl/ustring.hxx
M sal/rtl/source/strtmpl.cxx
M sal/util/sal.map
4 files changed, 125 insertions(+), 78 deletions(-)



diff --git a/sal/inc/rtl/ustring.h b/sal/inc/rtl/ustring.h
index ab2707d..35be5fe 100644
--- a/sal/inc/rtl/ustring.h
+++ b/sal/inc/rtl/ustring.h
@@ -1073,6 +1073,25 @@
 SAL_DLLPUBLIC sal_Int32 SAL_CALL rtl_ustr_toInt32(
 const sal_Unicode * str, sal_Int16 radix ) SAL_THROW_EXTERN_C();
 
+/** Interpret a string as an unsigned long integer.
+
+This function cannot be used for language-specific conversion.  The string
+must be null-terminated.
+
+@param str
+a null-terminated string.
+
+@param radix
+the radix.  Must be between RTL_USTR_MIN_RADIX (2) and RTL_USTR_MAX_RADIX
+(36), inclusive.
+
+@return
+the long integer value represented by the string, or 0 if the string does
+not represent a long integer.
+ */
+SAL_DLLPUBLIC sal_uInt64 SAL_CALL rtl_ustr_toUInt64(
+const sal_Unicode * str, sal_Int16 radix ) SAL_THROW_EXTERN_C();
+
 /** Interpret a string as a long integer.
 
 This function cannot be used for language-specific conversion.  The string
diff --git a/sal/inc/rtl/ustring.hxx b/sal/inc/rtl/ustring.hxx
index 192ba2b..8190d20 100644
--- a/sal/inc/rtl/ustring.hxx
+++ b/sal/inc/rtl/ustring.hxx
@@ -1843,6 +1843,20 @@
 }
 
 /**
+  Returns the uint64 value from this string.
+
+  This function can't be used for language specific conversion.
+
+  @paramradix   the radix (between 2 and 36)
+  @return   the uint64 represented from this string.
+0 if this string represents no number.
+*/
+sal_uInt64 toUInt64( sal_Int16 radix = 10 ) const SAL_THROW(())
+{
+return rtl_ustr_toUInt64( pData-buffer, radix );
+}
+
+/**
   Returns the float value from this string.
 
   This function can't be used for language specific conversion.
diff --git a/sal/rtl/source/strtmpl.cxx b/sal/rtl/source/strtmpl.cxx
index 619f64e..f5cbddd 100644
--- a/sal/rtl/source/strtmpl.cxx
+++ b/sal/rtl/source/strtmpl.cxx
@@ -24,6 +24,8 @@
 
 #include string.h
 #include sal/log.hxx
+#include limits
+#include boost/static_assert.hpp
 
 /*
 inline void rtl_str_ImplCopy( IMPL_RTL_STRCODE* pDest,
@@ -914,97 +916,108 @@
 }
 
 /* --- */
+namespace {
+template typename T static inline T IMPL_RTL_STRNAME( toInt )( const 
IMPL_RTL_STRCODE* pStr,
+ sal_Int16 
nRadix )
+{
+BOOST_STATIC_ASSERT(std::numeric_limitsT::is_signed);
+sal_BoolbNeg;
+sal_Int16   nDigit;
+T   n = 0;
+
+if ( (nRadix  RTL_STR_MIN_RADIX) || (nRadix  RTL_STR_MAX_RADIX) )
+nRadix = 10;
+
+/* Skip whitespaces */
+while ( *pStr  rtl_ImplIsWhitespace( IMPL_RTL_USTRCODE( *pStr ) ) )
+pStr++;
+
+if ( *pStr == '-' )
+{
+bNeg = sal_True;
+pStr++;
+}
+else
+{
+if ( *pStr == '+' )
+pStr++;
+bNeg = sal_False;
+}
+
+while ( *pStr )
+{
+nDigit = rtl_ImplGetDigit( IMPL_RTL_USTRCODE( *pStr ), nRadix );
+if ( nDigit  0 )
+break;
+
+n *= nRadix;
+n += nDigit;
+
+pStr++;
+}
+
+if ( bNeg )
+return -n;
+else
+return n;
+}
+
+
+template typename T static inline T IMPL_RTL_STRNAME( toUInt )( const 
IMPL_RTL_STRCODE* pStr,
+  
sal_Int16 nRadix )
+{
+BOOST_STATIC_ASSERT(!std::numeric_limitsT::is_signed);
+sal_Int16   nDigit;
+T   n = 0;
+
+if ( (nRadix  RTL_STR_MIN_RADIX) || (nRadix  RTL_STR_MAX_RADIX) )
+nRadix = 10;
+
+/* Skip whitespaces */
+while ( *pStr  rtl_ImplIsWhitespace( IMPL_RTL_USTRCODE( *pStr ) ) )
+++pStr;
+
+// skip optional explicit sign
+if ( *pStr == '+' )
+++pStr;
+
+while ( *pStr )
+{
+nDigit = rtl_ImplGetDigit( IMPL_RTL_USTRCODE( *pStr ), nRadix );
+if ( nDigit  0 )
+break;
+
+n *= nRadix;
+n += nDigit;
+
+++pStr;
+}
+
+return n;
+}
+}
 
 sal_Int32 SAL_CALL IMPL_RTL_STRNAME( toInt32 )( const IMPL_RTL_STRCODE* pStr,
 sal_Int16 nRadix )
 SAL_THROW_EXTERN_C()
 {
-sal_BoolbNeg;
-sal_Int16   nDigit;
-

[PATCH] Strings: boolean() as a replacement for valueOf(sal_Bool)

2013-02-04 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1981

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/1981/1

Strings: boolean() as a replacement for valueOf(sal_Bool)

valueOf(?) has been superseded by number(?).
O(U)String::valueOf(sal_Bool) has been deprecated without providing an
alternative method. Use boolean() method as a replacement for it.

Change-Id: I7eb74574fa8f1a3cf007cb0cbc32e681007ffb92
---
M sal/inc/rtl/string.hxx
M sal/inc/rtl/ustring.hxx
M sal/qa/rtl_strings/rtl_OString.cxx
M sal/qa/rtl_strings/rtl_OUString.cxx
4 files changed, 42 insertions(+), 10 deletions(-)



diff --git a/sal/inc/rtl/string.hxx b/sal/inc/rtl/string.hxx
index 69592f9..79ce923 100644
--- a/sal/inc/rtl/string.hxx
+++ b/sal/inc/rtl/string.hxx
@@ -1492,7 +1492,23 @@
   @return   a string with the string representation of the argument.
   @deprecated there is no replacement, use 'condition ? OString( true ) 
: OString( false )'
 */
-SAL_DEPRECATED_INTERNAL(write explicit code) static OString valueOf( 
sal_Bool b ) SAL_THROW(())
+SAL_DEPRECATED_INTERNAL(use boolean()) static OString valueOf( sal_Bool 
b ) SAL_THROW(())
+{
+return boolean(b);
+}
+
+/**
+  Returns the string representation of the sal_Bool argument.
+
+  If the sal_Bool is true, the string true is returned.
+  If the sal_Bool is false, the string false is returned.
+  This function can't be used for language specific conversion.
+
+  @paramb   a sal_Bool.
+  @return   a string with the string representation of the argument.
+  @since LibreOffice 4.1
+*/
+static OString boolean( sal_Bool b ) SAL_THROW(())
 {
 sal_Char aBuf[RTL_STR_MAX_VALUEOFBOOLEAN];
 rtl_String* pNewData = 0;
diff --git a/sal/inc/rtl/ustring.hxx b/sal/inc/rtl/ustring.hxx
index 192ba2b..eb87152 100644
--- a/sal/inc/rtl/ustring.hxx
+++ b/sal/inc/rtl/ustring.hxx
@@ -2129,7 +2129,23 @@
   @return   a string with the string representation of the argument.
   @deprecated there is no replacement, use 'condition ? OString( true ) 
: OString( false )'
 */
-SAL_DEPRECATED_INTERNAL(write explicit condition) static OUString 
valueOf( sal_Bool b ) SAL_THROW(())
+SAL_DEPRECATED_INTERNAL(use boolean()) static OUString valueOf( sal_Bool 
b ) SAL_THROW(())
+{
+return boolean(b);
+}
+
+/**
+  Returns the string representation of the sal_Bool argument.
+
+  If the sal_Bool is true, the string true is returned.
+  If the sal_Bool is false, the string false is returned.
+  This function can't be used for language specific conversion.
+
+  @paramb   a sal_Bool.
+  @return   a string with the string representation of the argument.
+  @since LibreOffice 4.1
+*/
+static OUString boolean( sal_Bool b ) SAL_THROW(())
 {
 sal_Unicode aBuf[RTL_USTR_MAX_VALUEOFBOOLEAN];
 rtl_uString* pNewData = 0;
diff --git a/sal/qa/rtl_strings/rtl_OString.cxx 
b/sal/qa/rtl_strings/rtl_OString.cxx
index cea3cb1..1934f06 100644
--- a/sal/qa/rtl_strings/rtl_OString.cxx
+++ b/sal/qa/rtl_strings/rtl_OString.cxx
@@ -1785,9 +1785,9 @@
 
 
 //
-// testing the method valueOf( sal_Bool b )
+// testing the method boolean( sal_Bool b )
 //
-sal_Bool SAL_CALL test_rtl_OString_valueOf_sal_Bool(
+sal_Bool SAL_CALL test_rtl_OString_boolean(
 hTestResult hRtlTestResult )
 {
 sal_Char methName[MAXBUFLENGTH];
@@ -1813,7 +1813,7 @@
 for(i = 0; i  (sizeof (arrTestCase))/(sizeof (TestCase)); i++)
 {
 ::rtl::OString aStr1;
-aStr1 = aStr1.valueOf( arrTestCase[i].input1 );
+aStr1 = aStr1.boolean( arrTestCase[i].input1 );
 sal_Bool lastRes = (arrTestCase[i].expVal-compareTo(aStr1) == 0);
 
 c_rtl_tres_state
@@ -2446,7 +2446,7 @@
 hTestResult hRtlTestResult )
 {
 c_rtl_tres_state_start(hRtlTestResult, valueOf);
-sal_Bool bTState = test_rtl_OString_valueOf_sal_Bool( hRtlTestResult );
+sal_Bool bTState = test_rtl_OString_boolean( hRtlTestResult );
 
 bTState = test_rtl_OString_valueOf_sal_Char( hRtlTestResult );
 
diff --git a/sal/qa/rtl_strings/rtl_OUString.cxx 
b/sal/qa/rtl_strings/rtl_OUString.cxx
index 4982f29..3ba20e7 100644
--- a/sal/qa/rtl_strings/rtl_OUString.cxx
+++ b/sal/qa/rtl_strings/rtl_OUString.cxx
@@ -1262,9 +1262,9 @@
 
 
 //
-//   testing the method valueOf( sal_Bool b )
+//   testing the method boolean( sal_Bool b )
 //
-extern C void /* sal_Bool */ SAL_CALL test_rtl_OUString_valueOf_sal_Bool(
+extern C void /* sal_Bool */ 

[PATCH] fdo#57417: remove LDAP choice from non windows platform

2013-02-04 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1983

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/1983/1

fdo#57417: remove LDAP choice from non windows platform

Change-Id: I0557a7c9cf0d18fbe5620ef8869bb83d0a6a7904
---
M extensions/source/abpilot/typeselectionpage.cxx
1 file changed, 10 insertions(+), 15 deletions(-)



diff --git a/extensions/source/abpilot/typeselectionpage.cxx 
b/extensions/source/abpilot/typeselectionpage.cxx
index 1991251..d57fef8 100644
--- a/extensions/source/abpilot/typeselectionpage.cxx
+++ b/extensions/source/abpilot/typeselectionpage.cxx
@@ -69,13 +69,12 @@
 // On Linux:
 // - EVOLUTION, EVOLUTION_GROUPWISE, EVOLUTION_LDAP (if applicable)
 // - MORK (via mork driver, which is built unconditionally)
-// - THUNDERBIRD (via mork driver?, which is built unconditionally)
 // - KAB (if applicable)
-// - LDAP (via mork driver?, which is built unconditionally)
 // - OTHER
 //
 // On Mac OS X:
 // - MACAB (if applicable)
+// - MORK (via mork driver, which is built unconditionally)
 // - OTHER
 //
 // On Windows:
@@ -83,22 +82,18 @@
 //   if WITH_MOZILLA)
 // - OTHER
 
-bool bWithMozilla = false, bWindows = false;
-bool bHaveEvolution = false, bHaveKab = false;
+bool bWithMozilla = false;
+bool bHaveEvolution = false;
+bool bHaveKab = false;
 bool bHaveMacab = false;
+bool bWithMork = false;
 
 #if defined WNT
-
 #if defined WITH_MOZILLA
 bWithMozilla = true;
 #endif
-bWindows = true;
-
 #else
-
-#if !defined MACOSX
-bWithMozilla = true;
-#endif
+bWithMork = true;
 
 Reference XDriverManager2  xManager = DriverManager::create( 
comphelper::getComponentContext( _pParent-getORB() ) );
 
@@ -141,13 +136,13 @@
 m_aAllTypes.push_back( ButtonItem( m_aEvolution, AST_EVOLUTION, 
bHaveEvolution ) );
 m_aAllTypes.push_back( ButtonItem( m_aEvolutionGroupwise, 
AST_EVOLUTION_GROUPWISE, bHaveEvolution ) );
 m_aAllTypes.push_back( ButtonItem( m_aEvolutionLdap, 
AST_EVOLUTION_LDAP, bHaveEvolution ) );
-m_aAllTypes.push_back( ButtonItem( m_aMORK, AST_MORK, bWithMozilla ) 
);
-m_aAllTypes.push_back( ButtonItem( m_aThunderbird, AST_THUNDERBIRD, 
bWithMozilla ) );
+m_aAllTypes.push_back( ButtonItem( m_aMORK, AST_MORK, bWithMozilla || 
bWithMork) );
+m_aAllTypes.push_back( ButtonItem( m_aThunderbird, AST_THUNDERBIRD, 
bWithMozilla || bWithMork) );
 m_aAllTypes.push_back( ButtonItem( m_aKab, AST_KAB, bHaveKab ) );
 m_aAllTypes.push_back( ButtonItem( m_aMacab, AST_MACAB, bHaveMacab ) 
);
 m_aAllTypes.push_back( ButtonItem( m_aLDAP, AST_LDAP, bWithMozilla ) 
);
-m_aAllTypes.push_back( ButtonItem( m_aOutlook, AST_OUTLOOK, 
bWithMozilla  bWindows ) );
-m_aAllTypes.push_back( ButtonItem( m_aOE, AST_OE, bWithMozilla  
bWindows ) );
+m_aAllTypes.push_back( ButtonItem( m_aOutlook, AST_OUTLOOK, 
bWithMozilla ) );
+m_aAllTypes.push_back( ButtonItem( m_aOE, AST_OE, bWithMozilla ) );
 m_aAllTypes.push_back( ButtonItem( m_aOther, AST_OTHER, true ) );
 
 Link aTypeSelectionHandler = LINK(this, TypeSelectionPage, 
OnTypeSelected );

-- 
To view, visit https://gerrit.libreoffice.org/1983
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0557a7c9cf0d18fbe5620ef8869bb83d0a6a7904
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Change in core[master]: WITH_LANG: add en-US if it is missing

2013-01-29 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1919

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1919/1

WITH_LANG: add en-US if it is missing

Change-Id: Ie12913691fa3d01bc7ad2fc0c108821d0937d250
---
M configure.ac
1 file changed, 4 insertions(+), 0 deletions(-)



diff --git a/configure.ac b/configure.ac
index a18eed4..9afbc5f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11808,6 +11808,10 @@
 AC_MSG_ERROR([invalid language: $lang; supported languages are: 
$ALL_LANGS])
 fi
 done
+if test -n $WITH_LANG -a $WITH_LANG != ALL; then
+echo $WITH_LANG | grep en-US 21  /dev/null
+test $? -ne 1 || WITH_LANG=`echo $WITH_LANG en-US`
+fi
 # list with substituted ALL
 WITH_LANG_LIST=`echo $WITH_LANG | sed s/ALL/$ALL_LANGS/`
 test -z $WITH_LANG_LIST  WITH_LANG_LIST=en-US

-- 
To view, visit https://gerrit.libreoffice.org/1919
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie12913691fa3d01bc7ad2fc0c108821d0937d250
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] handle void* to sal_Int64 as real sal_Int64 in ORowSetValue

2012-11-25 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1164

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/1164/1

handle void* to sal_Int64 as real sal_Int64 in ORowSetValue

Change-Id: I3f1f08716127147f077bff4edb6ec558b1b09e09
---
M connectivity/inc/connectivity/FValue.hxx
M connectivity/source/commontools/FValue.cxx
2 files changed, 53 insertions(+), 169 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1164
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f1f08716127147f077bff4edb6ec558b1b09e09
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] enable ado driver unit test again

2012-11-07 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1004

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1004/1

enable ado driver unit test again

The problem is that ado driver creates a link file in the tree
leaving it dirty: tinderbox doesn't like it. Instead of reading
the mdb file direct from srcdir we copy it first to workdir and
read it from there with the new function: getPathFromWorkdir.
Thank you Norbert!

Change-Id: I504bc26b80686db55a505bac19a95cc9c6022fcc
---
M connectivity/CppunitTest_connectivity_ado.mk
M connectivity/Module_connectivity.mk
M connectivity/qa/connectivity/ado/DriverTest.cxx
3 files changed, 10 insertions(+), 9 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1004
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I504bc26b80686db55a505bac19a95cc9c6022fcc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] add --enable-symbols-only as a syntactic sugar

2012-11-03 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/975

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/975/1

add --enable-symbols-only as a syntactic sugar

Change-Id: Ib8a28c6162f47526d6bb33f81f53835cd11894b2
---
M configure.ac
1 file changed, 20 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/975
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8a28c6162f47526d6bb33f81f53835cd11894b2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] don't activate magic linking option per default: -Wl,-S

2012-10-31 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/949

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/949/1

don't activate magic linking option per default: -Wl,-S

The build should not be smarter then it should, at least not
in the default case. But if someone want magic, it can be achived
with a new environment variable: BUILD_MAGIC=YES.

So if someone always wants magic, he should export that variable
in his einvironemnt, i. e. export BUILD_MAGIC=YES. If someone wants
magic only sometimes, he can pass it per command line:

make BUILD_MAGIC=YES target

Currently only stripping of symbols during linking is controled with
that option but feel free to add more magic to the build process.

Change-Id: If8e663e37713acd3b30b562352ef304bc901517a
---
M solenv/gbuild/LinkTarget.mk
1 file changed, 6 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/949
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8e663e37713acd3b30b562352ef304bc901517a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


don't activate magic linking option per default: -Wl,-S

2012-10-31 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change.

Change subject: don't activate magic linking option per default: -Wl,-S
..


Patch Set 1: Abandoned

--
To view, visit https://gerrit.libreoffice.org/949
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If8e663e37713acd3b30b562352ef304bc901517a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fix ambigous template error on VS 2010

2012-10-26 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/914

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/914/1

fix ambigous template error on VS 2010

No constructor could take the source type,
or constructor overload resolution was ambiguous

Change-Id: Iae27a96c1e2ed72d2744fcbe100d6ada7dc41c82
---
M accessibility/source/extended/AccessibleToolPanelDeckTabBar.cxx
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/914
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae27a96c1e2ed72d2744fcbe100d6ada7dc41c82
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fixing VS 2010 error: OutDir property must end with a traili...

2012-10-24 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/905

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/905/1

fixing VS 2010 error: OutDir property must end with a trailing slash

Change-Id: Ic6477adbd8e8eaa24f851befe5d18d34061e88ce
---
M liborcus/ExternalProject_liborcus.mk
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/905
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6477adbd8e8eaa24f851befe5d18d34061e88ce
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] gbuildification of ct2n

2012-10-18 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/884

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/884/1

gbuildification of ct2n

Change-Id: I98ca1bb2af19d99a7a908991cf27a148ee84c543
---
M Makefile.top
M RepositoryModule_ooo.mk
M config_host.mk.in
M configure.in
A ct2n/Makefile
A ct2n/Module_ct2n.mk
A ct2n/UnpackedTarball_ct2n.mk
A ct2n/Zip_ct2n.mk
D ct2n/delzip
D ct2n/makefile.mk
M ct2n/prj/build.lst
D ct2n/prj/dmake
M solenv/gbuild/UnpackedTarball.mk
13 files changed, 116 insertions(+), 72 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/884
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98ca1bb2af19d99a7a908991cf27a148ee84c543
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] comment translations german-english sd fusel.cxx and fusel....

2012-10-15 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/869

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/869
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea730a65e4c3a611e30e0f1ee34d291fbdc98c92
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lennard Wasserthal wassert...@nefkom.net
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: Lennard Wasserthal wassert...@nefkom.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] gbuildification of expat

2012-10-13 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/867

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/867/1

gbuildification of expat

Change-Id: I3b3aa40f39ef82c70f6f28790b582c83e48bdf76
---
M config_host.mk.in
M configure.in
A expat/ExternalPackage_expat.mk
A expat/ExternalProject_expat.mk
A expat/Makefile
A expat/Module_expat.mk
A expat/StaticLibrary_ascii_expat_xmlparse.mk
A expat/StaticLibrary_expat_xmlparse.mk
A expat/StaticLibrary_expat_xmltok.mk
A expat/UnpackedTarball_expat.mk
M expat/expat-2.1.0.patch
M expat/prj/build.lst
M expat/prj/d.lst
D expat/prj/dmake
M ooo.lst.in
15 files changed, 263 insertions(+), 112 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/867
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b3aa40f39ef82c70f6f28790b582c83e48bdf76
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] gbuildification of jpeg

2012-10-11 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/856

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/856/1

gbuildification of jpeg

Change-Id: I466f13f1132103bc20b9918411a54fd3106f4553
---
M Makefile.top
M RepositoryExternal.mk
M config_host.mk.in
M configure.in
A jpeg/Makefile
A jpeg/Module_jpeg.mk
A jpeg/StaticLibrary_jpeg.mk
A jpeg/UnpackedTarball_jpeg.mk
A jpeg/configs/jconfig.h
D jpeg/jpeg-8c.patch
D jpeg/makefile.mk
A jpeg/patches/jpeg-8c-jmorecfg.patch
R jpeg/patches/struct_alignment.patch
M jpeg/prj/build.lst
M jpeg/prj/d.lst
D jpeg/prj/dmake
16 files changed, 223 insertions(+), 261 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/856
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I466f13f1132103bc20b9918411a54fd3106f4553
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] beanshell clean content of d.lst

2012-10-08 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/838

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/838/1

beanshell clean content of d.lst

Change-Id: I2aac9018efa36f24f15088b7702903a422b4a910
---
M beanshell/prj/d.lst
1 file changed, 0 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/838
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2aac9018efa36f24f15088b7702903a422b4a910
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] mork driver: add list tables and unit test

2012-10-08 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/841

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/841/1

mork driver: add list tables and unit test

Change-Id: I594b24341eb38c05523f578c1dc2e43d90544f30
---
A connectivity/CppunitTest_connectivity_mork.mk
M connectivity/Module_connectivity.mk
A connectivity/qa/connectivity/mork/DriverTest.cxx
A connectivity/qa/connectivity/mork/abook_10_john_does.mab
M connectivity/source/drivers/mork/MColumnAlias.cxx
M connectivity/source/drivers/mork/MColumnAlias.hxx
M connectivity/source/drivers/mork/MConnection.cxx
M connectivity/source/drivers/mork/MDatabaseMetaDataHelper.cxx
M connectivity/source/drivers/mork/MQueryHelper.cxx
M connectivity/source/drivers/mork/MQueryHelper.hxx
M connectivity/source/drivers/mork/MResultSet.cxx
M connectivity/source/drivers/mork/MorkParser.cxx
M connectivity/source/drivers/mork/MorkParser.hxx
13 files changed, 621 insertions(+), 32 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/841
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I594b24341eb38c05523f578c1dc2e43d90544f30
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] WORK IN PROGRESS gbuildification of jfreereport

2012-10-04 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/761

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/761/1

WORK IN PROGRESS gbuildification of jfreereport

TODO:
1. add new function gb_ExternalProject_use_packege(s) an use it
to reflect dependency between jar: flow-engine depends on all other.
2. patch build.xml in flow-engine to add alternate location to
commons-logging, in case we have system-apache-commons in place.

Change-Id: I32e39bb5f4f825f182c3bd3cfc1a13ea1c38321e
---
M Makefile.top
M config_host.mk.in
M configure.in
A jfreereport/ExternalProject_jfreereport_flow_engine.mk
A jfreereport/ExternalProject_jfreereport_flute.mk
A jfreereport/ExternalProject_jfreereport_libbase.mk
A jfreereport/ExternalProject_jfreereport_libfonts.mk
A jfreereport/ExternalProject_jfreereport_libformula.mk
A jfreereport/ExternalProject_jfreereport_liblayout.mk
A jfreereport/ExternalProject_jfreereport_libloader.mk
A jfreereport/ExternalProject_jfreereport_librepository.mk
A jfreereport/ExternalProject_jfreereport_libserializer.mk
A jfreereport/ExternalProject_jfreereport_libxml.mk
A jfreereport/ExternalProject_jfreereport_sac.mk
A jfreereport/Makefile
A jfreereport/Module_jfreereport.mk
A jfreereport/Package_jfreereport_flute.mk
A jfreereport/Package_jfreereport_libbase.mk
A jfreereport/Package_jfreereport_libfonts.mk
A jfreereport/Package_jfreereport_libformula.mk
A jfreereport/Package_jfreereport_libloader.mk
A jfreereport/Package_jfreereport_librepository.mk
A jfreereport/Package_jfreereport_libserializer.mk
A jfreereport/Package_jfreereport_libxml.mk
A jfreereport/Package_jfreereport_sac.mk
A jfreereport/UnpackedTarball_jfreereport_flow_engine.mk
A jfreereport/UnpackedTarball_jfreereport_flute.mk
A jfreereport/UnpackedTarball_jfreereport_libbase.mk
A jfreereport/UnpackedTarball_jfreereport_libfonts.mk
A jfreereport/UnpackedTarball_jfreereport_libformula.mk
A jfreereport/UnpackedTarball_jfreereport_liblayout.mk
A jfreereport/UnpackedTarball_jfreereport_libloader.mk
A jfreereport/UnpackedTarball_jfreereport_librepository.mk
A jfreereport/UnpackedTarball_jfreereport_libserializer.mk
A jfreereport/UnpackedTarball_jfreereport_libxml.mk
A jfreereport/UnpackedTarball_jfreereport_sac.mk
A jfreereport/java/sac/build.xml
D jfreereport/prj/dmake
38 files changed, 946 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/761
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32e39bb5f4f825f182c3bd3cfc1a13ea1c38321e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] gbuildification of beanshell

2012-10-02 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/745

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/745/1

gbuildification of beanshell

Change-Id: I1b71796ca95500efeffe5e01dba3e73711f920e7
---
M Makefile.top
M Module_tail_build.mk
A beanshell/ExternalProject_beanshell.mk
A beanshell/Makefile
A beanshell/Module_beanshell.mk
A beanshell/Package_beanshell.mk
A beanshell/UnpackedTarball_beanshell.mk
M beanshell/prj/build.lst
D beanshell/prj/dmake
M config_host.mk.in
M configure.in
M tail_build/prj/build.lst
12 files changed, 104 insertions(+), 5 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/745
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b71796ca95500efeffe5e01dba3e73711f920e7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] gbuildification of languagetool

2012-10-02 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/753

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/753/1

gbuildification of languagetool

It is not clear how to remove a file:
REMOVE_FILES=openoffice/images/dialogh.png.
Let it for now in place.

Change-Id: Ie8739fd207ca7dc9343c92c93cf092b3af674bf0
---
M Makefile.top
M RepositoryModule_ooo.mk
M config_host.mk.in
M configure.in
A languagetool/ExternalProject_languagetool.mk
A languagetool/Makefile
A languagetool/Module_languagetool.mk
A languagetool/Package_languagetool.mk
A languagetool/UnpackedTarball_languagetool.mk
M languagetool/prj/build.lst
M languagetool/prj/d.lst
D languagetool/prj/dmake
12 files changed, 103 insertions(+), 4 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/753
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8739fd207ca7dc9343c92c93cf092b3af674bf0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] gbuildification of saxon

2012-09-30 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/739

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/739/1

gbuildification of saxon

Change-Id: Ic54337f4279daf78b099aab368eade5a6143f586
---
M Makefile.top
M config_host.mk.in
M configure.in
A saxon/ExternalProject_saxon.mk
A saxon/Module_saxon.mk
A saxon/Package_saxon.mk
A saxon/UnpackedTarball_saxon.mk
A saxon/build.xml
D saxon/makefile.mk
M saxon/prj/build.lst
M saxon/prj/d.lst
D saxon/prj/dmake
D saxon/saxon-9.0.0.7-bj.patch
13 files changed, 1,134 insertions(+), 1,103 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/739
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic54337f4279daf78b099aab368eade5a6143f586
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] migrate readlicense_oo to gbuild

2012-09-23 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/676

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/676/1

migrate readlicense_oo to gbuild

Change-Id: I8698d2da889d74a9f806c01f520ac0cbcca67b03
---
M Makefile.top
M Module_tail_build.mk
M filter/Configuration_filter.mk
M filter/prj/build.lst
A readlicense_oo/CustomTarget_license.mk
A readlicense_oo/CustomTarget_readme.mk
A readlicense_oo/Makefile
A readlicense_oo/Module_readlicense_oo.mk
A readlicense_oo/Package_files.mk
A readlicense_oo/Package_license.mk
A readlicense_oo/Package_readme.mk
D readlicense_oo/makefile.mk
M readlicense_oo/prj/build.lst
M readlicense_oo/prj/d.lst
D readlicense_oo/prj/dmake
D readlicense_oo/util/makefile.pmk
M tail_build/prj/build.lst
17 files changed, 218 insertions(+), 160 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/676
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8698d2da889d74a9f806c01f520ac0cbcca67b03
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] introduce new option --disable-cve-tests

2012-09-19 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/653

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/653/1

introduce new option --disable-cve-tests

Change-Id: I288638c4a70396ccb7354b20e901aa0c46ffe442
---
M config_host.mk.in
M configure.in
M filter/Module_filter.mk
M sc/CppunitTest_sc_filters_test.mk
M sc/qa/unit/filters-test.cxx
M sd/CppunitTest_sd_filters_test.mk
M sd/qa/unit/filters-test.cxx
M svtools/Module_svtools.mk
M sw/Module_sw.mk
9 files changed, 44 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/653
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I288638c4a70396ccb7354b20e901aa0c46ffe442
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] prevent mozilla on non Windows platforms to be enabled

2012-09-18 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/637

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/637/1

prevent mozilla on non Windows platforms to be enabled

Change-Id: I54144005e6a284326b45a34eb958d170e872471e
---
M configure.in
1 file changed, 13 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/637
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54144005e6a284326b45a34eb958d170e872471e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] mork driver implementation

2012-09-17 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/635

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/635/1

mork driver implementation

This is a preparation for merge into master, feature/mork
branch is obsoslete and shouldn't be used any more. In
context of this change the usage of old mozilla based mork
driver depends on platform: all non windows platforms use
this new mork driver, windows still uses mozilla.

Because mozilla driver shipping was stripped on feature/mork
branch for all platforms, the corresponding commits were
changed prior to creating this change (the build file changes
are reverted now). So the build and shipping of different mork
driver implementation should be implemented from scratch:
mozilla on windows, new mork dirver on all other platforms.

Currently the new mork dirver is compiled (on all platforms),
but not used. It can be tested with mork_helper executable.

fdo#51004

Change-Id: Ib2413ab6856f163337aa311c4bf7b1182d6c6f63
---
M Repository.mk
A connectivity/Configuration_mork.mk
A connectivity/Executable_mork_helper.mk
A connectivity/Library_mork.mk
M connectivity/Module_connectivity.mk
A connectivity/registry/mork/org/openoffice/Office/DataAccess/Drivers.xcu
A connectivity/source/drivers/mork/MCatalog.cxx
A connectivity/source/drivers/mork/MCatalog.hxx
A connectivity/source/drivers/mork/MColumnAlias.cxx
A connectivity/source/drivers/mork/MColumnAlias.hxx
A connectivity/source/drivers/mork/MColumns.cxx
A connectivity/source/drivers/mork/MColumns.hxx
A connectivity/source/drivers/mork/MConfigAccess.cxx
A connectivity/source/drivers/mork/MConfigAccess.hxx
A connectivity/source/drivers/mork/MConnection.cxx
A connectivity/source/drivers/mork/MConnection.hxx
A connectivity/source/drivers/mork/MDatabaseMetaData.cxx
A connectivity/source/drivers/mork/MDatabaseMetaData.hxx
A connectivity/source/drivers/mork/MDatabaseMetaDataHelper.cxx
A connectivity/source/drivers/mork/MDatabaseMetaDataHelper.hxx
A connectivity/source/drivers/mork/MDriver.cxx
A connectivity/source/drivers/mork/MDriver.hxx
A connectivity/source/drivers/mork/MErrorResource.hxx
A connectivity/source/drivers/mork/MExtConfigAccess.hxx
A connectivity/source/drivers/mork/MNSFolders.cxx
A connectivity/source/drivers/mork/MNSFolders.hxx
A connectivity/source/drivers/mork/MNSINIParser.cxx
A connectivity/source/drivers/mork/MNSINIParser.hxx
A connectivity/source/drivers/mork/MNSProfileDiscover.cxx
A connectivity/source/drivers/mork/MNSProfileDiscover.hxx
A connectivity/source/drivers/mork/MPreparedStatement.cxx
A connectivity/source/drivers/mork/MPreparedStatement.hxx
A connectivity/source/drivers/mork/MQueryHelper.cxx
A connectivity/source/drivers/mork/MQueryHelper.hxx
A connectivity/source/drivers/mork/MResultSet.cxx
A connectivity/source/drivers/mork/MResultSet.hxx
A connectivity/source/drivers/mork/MResultSetMetaData.cxx
A connectivity/source/drivers/mork/MResultSetMetaData.hxx
A connectivity/source/drivers/mork/MServices.cxx
A connectivity/source/drivers/mork/MStatement.cxx
A connectivity/source/drivers/mork/MStatement.hxx
A connectivity/source/drivers/mork/MTable.cxx
A connectivity/source/drivers/mork/MTable.hxx
A connectivity/source/drivers/mork/MTables.cxx
A connectivity/source/drivers/mork/MTables.hxx
A connectivity/source/drivers/mork/MorkParser.cxx
A connectivity/source/drivers/mork/MorkParser.hxx
A connectivity/source/drivers/mork/README
A connectivity/source/drivers/mork/dllapi.h
A connectivity/source/drivers/mork/license.txt
A connectivity/source/drivers/mork/mork.component
A connectivity/source/drivers/mork/mork.xml
A connectivity/source/drivers/mork/mork_helper.cxx
A connectivity/source/drivers/mork/post_include_windows.h
A connectivity/source/drivers/mork/pre_include_windows.h
A connectivity/source/drivers/mork/services.cxx
M connectivity/source/inc/resource/conn_shared_res.hrc
A connectivity/source/inc/resource/mork_res.hrc
58 files changed, 10,651 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/635
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2413ab6856f163337aa311c4bf7b1182d6c6f63
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice