from:"Fridrich Strba \(via Code Review\)"

[PATCH] add automatic git hook setting in autogen.sh

2013-09-02 Thread Fridrich Strba (via Code Review)

Hi,

I would like you to review the following patch:

https://gerrit.libreoffice.org/5748

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/libvisio refs/changes/48/5748/1

add automatic git hook setting in autogen.sh

Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137
---
A .git-hooks/README
A .git-hooks/commit-msg
A .git-hooks/post-merge
A .git-hooks/pre-commit
M autogen.sh
5 files changed, 366 insertions(+), 7 deletions(-)



diff --git a/.git-hooks/README b/.git-hooks/README
new file mode 100644
index 000..c6612bc
--- /dev/null
+++ b/.git-hooks/README
@@ -0,0 +1,9 @@
+Git hooks are executable scripts you can place in $GIT_DIR/hooks directory to 
trigger action at certain points. 
+
+There are two groups of these hooks: client side and server side. 
+The client-side hooks:
+are for client operations such as committing and merging.
+The server-side hooks:
+are for Git server operations such as receiving pushed commits.
+
+See Also [ http://git-scm.com/book/en/Customizing-Git-Git-Hooks ]
\ No newline at end of file
diff --git a/.git-hooks/commit-msg b/.git-hooks/commit-msg
new file mode 100755
index 000..e3dfe69
--- /dev/null
+++ b/.git-hooks/commit-msg
@@ -0,0 +1,181 @@
+#!/bin/sh
+#
+# An example hook script to check the commit log message.
+# Called by git-commit with one argument, the name of the file
+# that has the commit message.  The hook should exit with non-zero
+# status after issuing an appropriate message if it wants to stop the
+# commit.  The hook is allowed to edit the commit message file.
+#
+# To enable this hook, make this file executable.
+
+# Uncomment the below to add a Signed-off-by line to the message.
+# SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*\).*$/Signed-off-by: \1/p')
+# grep -qs ^$SOB $1 || echo $SOB  $1
+
+# This example catches duplicate Signed-off-by lines.
+
+base_dir=$(dirname $0)
+MSG=$1
+
+abort() {
+cp $1 $1.save
+cat 2 EOF
+Commit aborted, your commit message was saved as '$1.save'.
+
+Reason: $2
+
+EOF
+exit 1
+}
+
+test  = $(grep '^Signed-off-by: ' $1 |
+sort | uniq -c | sed -e '/^[   ]*1[]/d') || {
+   abort $1 Duplicate Signed-off-by lines.
+}
+
+# Check that the first line exists, and is not an asterisk
+
+if [ -z `head -n 1 $1 | grep -v '^[[:blank:]]*\*$'` ] ; then
+abort $1 Please provide the general description on the first line.
+fi
+
+# ...and that it is not too long
+
+if [ `head -n 1 $1 | wc -c` -gt 79 ] ; then
+abort $1 The first line is too long, please try to fit into 79 
characters.
+fi
+
+# ...and that it does not continue on the second line
+if [ `wc -l  $1` -gt 1 -a -n `head -n 2 $1 | tail -n 1 | sed 's/^#.*//'` 
] ; then
+abort $1 The second line is not empty - maybe the first line continues 
there?
+fi
+
+# Check that the message is not a ChangeLog-like one
+
+if [ -n `head -n 1 $1 | grep '^[0-9]\{4\}-[0-9]\{2\}-[0-9]\{2\}.*.*@.*'` ] 
; then
+abort $1 The commit message looks like ChangeLog, please use the git 
form.
+fi
+
+# Check for whitespace in front of *'s
+
+if [ -n `sed '/^#/,$d' $1 | grep '^[[:space:]]\+\*.*:'` -a -z `grep '^\*' 
$1` ] ; then
+abort $1 Please don't use whitespace in front of '* file: Description.' 
entries.
+fi
+
+# Check that lines do not start with '#something' (possibly accidental 
commit,
+# such as starting the message with '#ifdef', git commits start with 
'#whitespace'.
+
+if [ -n `grep '^#[^[:blank:]]' $1` ] ; then
+abort $1 Possible accidental comment in the commit message (leading # 
without space).
+fi
+
+
+#-- copied gerrit commit-msg hook to handle ChangeId --
+# From Gerrit Code Review 2.3
+#
+# Part of Gerrit Code Review (http://code.google.com/p/gerrit/)
+#
+# Copyright (C) 2009 The Android Open Source Project
+#
+# Licensed under the Apache License, Version 2.0 (the License);
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an AS IS BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+CHANGE_ID_AFTER=Bug|Issue
+
+# Check for, and add if missing, a unique Change-Id
+#
+add_ChangeId() {
+clean_message=`sed -e '
+/^diff --git a\/.*/{
+s///
+q
+}
+/^Signed-off-by:/d
+/^#/d
+' $MSG | git stripspace`
+if test -z $clean_message
+then
+return
+fi
+
+id=`grep -i '^Change-Id:' $MSG | sed -e s/.*: I//`
+temp_msg=`grep -v -i '^Change-Id:' $MSG`
+echo $temp_msg  $MSG
+
+if  test -z $id
+then
+id=`_gen_ChangeId`
+

[PUSHED] add automatic git hook setting in autogen.sh

2013-09-02 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5745

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5745
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137
Gerrit-PatchSet: 2
Gerrit-Project: libcdr
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] add automatic git hook setting in autogen.sh

2013-09-02 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5748

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5748
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137
Gerrit-PatchSet: 2
Gerrit-Project: libvisio
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] add automatic git hook setting in autogen.sh

2013-09-02 Thread Fridrich Strba (via Code Review)

Hi,

I would like you to review the following patch:

https://gerrit.libreoffice.org/5749

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/libmspub refs/changes/49/5749/1

add automatic git hook setting in autogen.sh

Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137
---
A .git-hooks/README
A .git-hooks/commit-msg
A .git-hooks/post-merge
A .git-hooks/pre-commit
M autogen.sh
5 files changed, 366 insertions(+), 7 deletions(-)



diff --git a/.git-hooks/README b/.git-hooks/README
new file mode 100644
index 000..c6612bc
--- /dev/null
+++ b/.git-hooks/README
@@ -0,0 +1,9 @@
+Git hooks are executable scripts you can place in $GIT_DIR/hooks directory to 
trigger action at certain points. 
+
+There are two groups of these hooks: client side and server side. 
+The client-side hooks:
+are for client operations such as committing and merging.
+The server-side hooks:
+are for Git server operations such as receiving pushed commits.
+
+See Also [ http://git-scm.com/book/en/Customizing-Git-Git-Hooks ]
\ No newline at end of file
diff --git a/.git-hooks/commit-msg b/.git-hooks/commit-msg
new file mode 100755
index 000..e3dfe69
--- /dev/null
+++ b/.git-hooks/commit-msg
@@ -0,0 +1,181 @@
+#!/bin/sh
+#
+# An example hook script to check the commit log message.
+# Called by git-commit with one argument, the name of the file
+# that has the commit message.  The hook should exit with non-zero
+# status after issuing an appropriate message if it wants to stop the
+# commit.  The hook is allowed to edit the commit message file.
+#
+# To enable this hook, make this file executable.
+
+# Uncomment the below to add a Signed-off-by line to the message.
+# SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*\).*$/Signed-off-by: \1/p')
+# grep -qs ^$SOB $1 || echo $SOB  $1
+
+# This example catches duplicate Signed-off-by lines.
+
+base_dir=$(dirname $0)
+MSG=$1
+
+abort() {
+cp $1 $1.save
+cat 2 EOF
+Commit aborted, your commit message was saved as '$1.save'.
+
+Reason: $2
+
+EOF
+exit 1
+}
+
+test  = $(grep '^Signed-off-by: ' $1 |
+sort | uniq -c | sed -e '/^[   ]*1[]/d') || {
+   abort $1 Duplicate Signed-off-by lines.
+}
+
+# Check that the first line exists, and is not an asterisk
+
+if [ -z `head -n 1 $1 | grep -v '^[[:blank:]]*\*$'` ] ; then
+abort $1 Please provide the general description on the first line.
+fi
+
+# ...and that it is not too long
+
+if [ `head -n 1 $1 | wc -c` -gt 79 ] ; then
+abort $1 The first line is too long, please try to fit into 79 
characters.
+fi
+
+# ...and that it does not continue on the second line
+if [ `wc -l  $1` -gt 1 -a -n `head -n 2 $1 | tail -n 1 | sed 's/^#.*//'` 
] ; then
+abort $1 The second line is not empty - maybe the first line continues 
there?
+fi
+
+# Check that the message is not a ChangeLog-like one
+
+if [ -n `head -n 1 $1 | grep '^[0-9]\{4\}-[0-9]\{2\}-[0-9]\{2\}.*.*@.*'` ] 
; then
+abort $1 The commit message looks like ChangeLog, please use the git 
form.
+fi
+
+# Check for whitespace in front of *'s
+
+if [ -n `sed '/^#/,$d' $1 | grep '^[[:space:]]\+\*.*:'` -a -z `grep '^\*' 
$1` ] ; then
+abort $1 Please don't use whitespace in front of '* file: Description.' 
entries.
+fi
+
+# Check that lines do not start with '#something' (possibly accidental 
commit,
+# such as starting the message with '#ifdef', git commits start with 
'#whitespace'.
+
+if [ -n `grep '^#[^[:blank:]]' $1` ] ; then
+abort $1 Possible accidental comment in the commit message (leading # 
without space).
+fi
+
+
+#-- copied gerrit commit-msg hook to handle ChangeId --
+# From Gerrit Code Review 2.3
+#
+# Part of Gerrit Code Review (http://code.google.com/p/gerrit/)
+#
+# Copyright (C) 2009 The Android Open Source Project
+#
+# Licensed under the Apache License, Version 2.0 (the License);
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an AS IS BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+CHANGE_ID_AFTER=Bug|Issue
+
+# Check for, and add if missing, a unique Change-Id
+#
+add_ChangeId() {
+clean_message=`sed -e '
+/^diff --git a\/.*/{
+s///
+q
+}
+/^Signed-off-by:/d
+/^#/d
+' $MSG | git stripspace`
+if test -z $clean_message
+then
+return
+fi
+
+id=`grep -i '^Change-Id:' $MSG | sed -e s/.*: I//`
+temp_msg=`grep -v -i '^Change-Id:' $MSG`
+echo $temp_msg  $MSG
+
+if  test -z $id
+then
+id=`_gen_ChangeId`
+

[PUSHED] add automatic git hook setting in autogen.sh

2013-09-02 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5749

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5749
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137
Gerrit-PatchSet: 2
Gerrit-Project: libmspub
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Changed the Corel Draw versions for udta

2013-08-30 Thread Fridrich Strba (via Code Review)

Hi,

I would like you to review the following patch:

https://gerrit.libreoffice.org/5716

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/libcdr refs/changes/16/5716/1

Changed the Corel Draw versions for udta

Change-Id: I56858984c6ce67d732294020669687053b7b8b50
---
M src/lib/CDRParser.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/lib/CDRParser.cpp b/src/lib/CDRParser.cpp
index 9308ff3..06280b7 100644
--- a/src/lib/CDRParser.cpp
+++ b/src/lib/CDRParser.cpp
@@ -3285,7 +3285,7 @@
 void libcdr::CDRParser::readUdta(WPXInputStream *input)
 {
   CDR_DEBUG_MSG((libcdr::CDRParser::readUdta\n));
-  if (m_version == 1400)
+  if (m_version = 1300  m_version = 1500)
   {
 input-seek(6, WPX_SEEK_CUR); // Not sure what these bytes are for.  Field 
id?
 std::vectorunsigned char name;

-- 
To view, visit https://gerrit.libreoffice.org/5716
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56858984c6ce67d732294020669687053b7b8b50
Gerrit-PatchSet: 1
Gerrit-Project: libcdr
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Little tiny nit

2013-08-30 Thread Fridrich Strba (via Code Review)

Hi,

I would like you to review the following patch:

https://gerrit.libreoffice.org/5717

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/libcdr refs/changes/17/5717/1

Little tiny nit

Change-Id: Ib4fed604412afdaeb3ec0b03c1c8328eae554842
---
M src/lib/CDRParser.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/lib/CDRParser.cpp b/src/lib/CDRParser.cpp
index 06280b7..1b1dcc9 100644
--- a/src/lib/CDRParser.cpp
+++ b/src/lib/CDRParser.cpp
@@ -3285,7 +3285,7 @@
 void libcdr::CDRParser::readUdta(WPXInputStream *input)
 {
   CDR_DEBUG_MSG((libcdr::CDRParser::readUdta\n));
-  if (m_version = 1300  m_version = 1500)
+  if (m_version = 1300  m_version  1600)
   {
 input-seek(6, WPX_SEEK_CUR); // Not sure what these bytes are for.  Field 
id?
 std::vectorunsigned char name;

-- 
To view, visit https://gerrit.libreoffice.org/5717
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4fed604412afdaeb3ec0b03c1c8328eae554842
Gerrit-PatchSet: 1
Gerrit-Project: libcdr
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Little tiny nit

2013-08-30 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5717

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5717
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4fed604412afdaeb3ec0b03c1c8328eae554842
Gerrit-PatchSet: 2
Gerrit-Project: libcdr
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Fix windows libo crash with graphite fonts.

2013-08-28 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5644

Approvals:
  LibreOffice gerrit bot: Verified
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5644
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c5825420d9ea5768564253789a28412f3c1900a
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Martin Hosken martin_hos...@sil.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] fdo#67093 Change traduction of Header in it to avoid conflic...

2013-07-25 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5093

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5093
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2c7d4c7df2f492a6a10081c9ed4e99ac9e61e73
Gerrit-PatchSet: 2
Gerrit-Project: translations
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#67093 Change traduction of Header in it to avoid conflic...

2013-07-25 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5092

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5092
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2c7d4c7df2f492a6a10081c9ed4e99ac9e61e73
Gerrit-PatchSet: 2
Gerrit-Project: translations
Gerrit-Branch: master
Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Downgraded the Dutch spellchecker to version 2.00 ( fdo#6303...

2013-07-22 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4987

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4987
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e21a40f03b44a336355500bb617865ca2704125
Gerrit-PatchSet: 4
Gerrit-Project: dictionaries
Gerrit-Branch: master
Gerrit-Owner: Thomas van der meulen meulentho...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#67093 Change traduction of Title for some more languages

2013-07-22 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5038

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5038
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcd7d03c9ea7608c8963d1cb9b7c2d7cbe2415d5
Gerrit-PatchSet: 2
Gerrit-Project: translations
Gerrit-Branch: master
Gerrit-Owner: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] fdo#67093 Change traduction of Title in french to avoid conf...

2013-07-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4995

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4995
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5
Gerrit-PatchSet: 3
Gerrit-Project: translations
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#67093 Change traduction of Title in french to avoid conf...

2013-07-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4994

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4994
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5
Gerrit-PatchSet: 3
Gerrit-Project: translations
Gerrit-Branch: master
Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] updated Spanish dictionary pack to 0.7

2013-07-19 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4985

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4985
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c852b6b7796822cb5c72c4633fab48003fdc147
Gerrit-PatchSet: 2
Gerrit-Project: dictionaries
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Andras Timar ati...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] updated Spanish dictionary pack to 0.7

2013-07-19 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4986

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4986
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae6fef300292f1df2753f7bdb45040d66c168bb6
Gerrit-PatchSet: 2
Gerrit-Project: dictionaries
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Andras Timar ati...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] module sot: String, bool and other clean-up

2013-07-04 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4710

Approvals:
  LibreOffice gerrit bot: Verified
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4710
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe2bfdf20c500e9fd98c3baef66d36aa79ca4b52
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] OUString convertion for unotools

2013-07-02 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4659

Approvals:
  LibreOffice gerrit bot: Verified
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4659
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] MSVC build fixes

2013-06-28 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4581

Approvals:
  LibreOffice gerrit bot: Verified
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4581
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I189fe3635f94fdd6b91bd7930c7abf02e70368aa
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Tor Lillqvist t...@iki.fi
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#43460 sc: use isEmpty()

2013-06-28 Thread Fridrich Strba (via Code Review)

Hello Tor Lillqvist, LibreOffice gerrit bot,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/4316

to look at the new rebased patch set (#3).

Change subject: fdo#43460 sc: use isEmpty()
..

fdo#43460 sc: use isEmpty()

Change-Id: I062570091ebea0ad30f09b0358ab664a3ff949ef
---
M sc/source/core/data/documen3.cxx
M sc/source/core/data/postit.cxx
M sc/source/core/tool/compiler.cxx
M sc/source/core/tool/dbdata.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/oox/pagesettings.cxx
M sc/source/filter/oox/querytablebuffer.cxx
M sc/source/filter/xml/XMLStylesExportHelper.cxx
M sc/source/filter/xml/xmlexprt.cxx
M sc/source/filter/xml/xmltabi.cxx
M sc/source/ui/docshell/docsh.cxx
M sc/source/ui/unoobj/chart2uno.cxx
M sc/source/ui/vba/vbafont.cxx
M sc/source/ui/view/dbfunc3.cxx
14 files changed, 26 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/4316/3
-- 
To view, visit https://gerrit.libreoffice.org/4316
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I062570091ebea0ad30f09b0358ab664a3ff949ef
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jelle van der Waa je...@vdwaa.nl
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#43460 sc: use isEmpty()

2013-06-28 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4316

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4316
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I062570091ebea0ad30f09b0358ab664a3ff949ef
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jelle van der Waa je...@vdwaa.nl
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] Add Amharic (am) auxiliary files

2013-06-26 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4551

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4551
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ef1018e8b40b3c1626d5add7ffa217da6419a0c
Gerrit-PatchSet: 3
Gerrit-Project: help
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Andras Timar ati...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] copy values from the original item set

2013-06-03 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4145

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4145
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9100dbe05c418a9dd1b819534a08076c9a4aed1c
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] jvmfwk: de-Pascalize do_msvcr71_magic

2013-06-03 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4135

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4135
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77b3b591a94f4dfbb373938e3787f75e6a8e09c5
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove Tango icon duplicates using symlinks

2013-06-03 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4113

Approvals:
  Mathias M: Looks good to me, but someone else must approve
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4113
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a4c09cdf6d60b90236663a4b7f30456a8c32e86
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Mathias M m...@gmx.fr
Gerrit-Reviewer: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#60924 autoinstall - gbuild/scp2: add math module

2013-06-01 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4065

Approvals:
  LibreOffice gerrit bot: Verified
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4065
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I466dd68069576d57740ef34b8f6fcd8f9025c5c8
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Marcos Souza marcos.souza@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fix copying of MSVC2008 runtime DLLs

2013-05-31 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4110

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4110
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id3ba5bdb1f28b619add7d2e255cd9e1edc0d1bd1
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] libcdr: fix build with MSVC2008

2013-05-31 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4109

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4109
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I70731e13ab4ef0d6eadd803b8f6a24f565be5346
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix crash with ooo120774-1.doc

2013-05-31 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4114

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/4114/1

Fix crash with ooo120774-1.doc

Do not try to remove line breaks from empty string

Change-Id: Ieb12c541d42944aac813cee10ce479207b1c674b
---
M sw/source/core/doc/doctxm.cxx
1 file changed, 2 insertions(+), 0 deletions(-)



diff --git a/sw/source/core/doc/doctxm.cxx b/sw/source/core/doc/doctxm.cxx
index d56cf61..f5372a7 100644
--- a/sw/source/core/doc/doctxm.cxx
+++ b/sw/source/core/doc/doctxm.cxx
@@ -1533,6 +1533,8 @@
 /// to a single space, and trailing space removed.
 String lcl_RemoveLineBreaks( String sRet )
 {
+if (!sRet.Len())
+return sRet;
 xub_StrLen nOffset = 0;
 sRet.SearchAndReplaceAll('\n', ' ');
 for (xub_StrLen i = 1; i  sRet.Len(); i++)

-- 
To view, visit https://gerrit.libreoffice.org/4114
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb12c541d42944aac813cee10ce479207b1c674b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Fix crash with ooo120774-1.doc

2013-05-31 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4114

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4114
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb12c541d42944aac813cee10ce479207b1c674b
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix crash with fdo60063-1.docx

2013-05-30 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4091

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/4091/1

Fix crash with fdo60063-1.docx

Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
---
M oox/source/docprop/docprophandler.cxx
1 file changed, 11 insertions(+), 27 deletions(-)



diff --git a/oox/source/docprop/docprophandler.cxx 
b/oox/source/docprop/docprophandler.cxx
index d81199f..60e425f 100644
--- a/oox/source/docprop/docprophandler.cxx
+++ b/oox/source/docprop/docprophandler.cxx
@@ -25,6 +25,8 @@
 
 #include osl/time.h
 
+#include boost/algorithm/string.hpp
+
 #include oox/helper/attributelist.hxx
 
 using namespace ::com::sun::star;
@@ -158,37 +160,19 @@
 {
 if ( !aChars.isEmpty() )
 {
-uno::Sequence OUString  aResult( 20 );
-sal_Int32 nCounter = 0;
+std::string aUtf8Chars = OUStringToOString(aChars, 
RTL_TEXTENCODING_UTF8).getStr();
+std::vectorstd::string aUtf8Result;
+boost::split(aUtf8Result, aUtf8Chars, boost::is_any_of( ,;:\t));
 
-const sal_Unicode* pStr = aChars.getStr();
-for( sal_Int32 nInd = 0; nInd  aChars.getLength()  pStr[nInd] != 0; 
nInd++ )
+if (!aUtf8Result.empty())
 {
-switch( pStr[nInd] )
-{
-case (sal_Unicode)' ':
-case (sal_Unicode)',':
-case (sal_Unicode)';':
-case (sal_Unicode)':':
-case (sal_Unicode)'\t':
-// this is a delimiter
-// unfortunately I did not find any specification for the 
possible delimiters
-if ( !aResult[nCounter].isEmpty() )
-{
-if ( nCounter = aResult.getLength() )
-aResult.realloc( nCounter + 10 );
-nCounter++;
-}
-break;
+uno::Sequence OUString  aResult(aUtf8Result.size());
+OUString* pResultValues = aResult.getArray();
+for (std::vectorstd::string::const_iterator i = 
aUtf8Result.begin(); i != aUtf8Result.end(); ++i, ++pResultValues)
+*pResultValues = OUString(i-c_str(), 
static_castsal_Int32(i-size()),RTL_TEXTENCODING_UTF8);
 
-default:
-// this should be a part of keyword
-aResult[nCounter] += OUString( (sal_Unicode)pStr[nInd] );
-}
+return aResult;
 }
-
-aResult.realloc( nCounter + 1 );
-return aResult;
 }
 
 return uno::Sequence OUString ();

-- 
To view, visit https://gerrit.libreoffice.org/4091
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Fix crash with fdo60063-1.docx

2013-05-30 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4091

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4091
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Fix crash with fdo60063-1.docx

2013-05-30 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4093

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/4093/1

Fix crash with fdo60063-1.docx

Compared to the original version, this one tries hard
not to produce empty keywords.

Reviewed-on: https://gerrit.libreoffice.org/4091
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
(cherry picked from commit b2f97d77237cde249b4c40acc8ad3f7f8755e768)
(cherry picked from commit 693707e338922d8dc7578975a1990e8a1cba6a53)

Conflicts:
oox/source/docprop/docprophandler.cxx

Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
---
M oox/source/docprop/docprophandler.cxx
1 file changed, 13 insertions(+), 28 deletions(-)



diff --git a/oox/source/docprop/docprophandler.cxx 
b/oox/source/docprop/docprophandler.cxx
index 1067315..ff6d170 100644
--- a/oox/source/docprop/docprophandler.cxx
+++ b/oox/source/docprop/docprophandler.cxx
@@ -25,6 +25,9 @@
 
 #include osl/time.h
 
+#include vector
+#include boost/algorithm/string.hpp
+
 #include oox/helper/attributelist.hxx
 
 using namespace ::com::sun::star;
@@ -157,39 +160,21 @@
 {
 if ( !aChars.isEmpty() )
 {
-uno::Sequence ::rtl::OUString  aResult( 20 );
-sal_Int32 nCounter = 0;
+std::string aUtf8Chars = rtl::OUStringToOString( aChars, 
RTL_TEXTENCODING_UTF8 ).getStr();
+std::vectorstd::string aUtf8Result;
+boost::split( aUtf8Result, aUtf8Chars, boost::is_any_of( ,;:\t), 
boost::token_compress_on );
 
-const sal_Unicode* pStr = aChars.getStr();
-for( sal_Int32 nInd = 0; nInd  aChars.getLength()  pStr[nInd] != 0; 
nInd++ )
+if (!aUtf8Result.empty())
 {
-switch( pStr[nInd] )
-{
-case (sal_Unicode)' ':
-case (sal_Unicode)',':
-case (sal_Unicode)';':
-case (sal_Unicode)':':
-case (sal_Unicode)'\t':
-// this is a delimiter
-// unfortunately I did not find any specification for the 
possible delimiters
-if ( !aResult[nCounter].isEmpty() )
-{
-if ( nCounter = aResult.getLength() )
-aResult.realloc( nCounter + 10 );
-nCounter++;
-}
-break;
+uno::Sequence rtl::OUString  aResult( aUtf8Result.size() );
+OUString* pResultValues = aResult.getArray();
+for ( std::vector std::string ::const_iterator i = 
aUtf8Result.begin();
+  i != aUtf8Result.end(); ++i, ++pResultValues )
+*pResultValues = rtl::OUString( i-c_str(), static_cast 
sal_Int32 ( i-size() ),RTL_TEXTENCODING_UTF8 );
 
-default:
-// this should be a part of keyword
-aResult[nCounter] += ::rtl::OUString( 
(sal_Unicode)pStr[nInd] );
-}
+return aResult;
 }
-
-aResult.realloc( nCounter + 1 );
-return aResult;
 }
-
 return uno::Sequence ::rtl::OUString ();
 }
 // 

-- 
To view, visit https://gerrit.libreoffice.org/4093
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Accept even more corrupted zip documents as long as we can r...

2013-05-30 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4094

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/4094/1

Accept even more corrupted zip documents as long as we can read them

Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710
(cherry picked from commit 1b049bd2dae52dc154ea6bee075a254a9b6cc318)
(cherry picked from commit d360333f83e3115219c3928525060c6c2a8711db)
---
M package/source/zipapi/ZipFile.cxx
1 file changed, 0 insertions(+), 1 deletion(-)



diff --git a/package/source/zipapi/ZipFile.cxx 
b/package/source/zipapi/ZipFile.cxx
index 0da4c33..23d33c0 100644
--- a/package/source/zipapi/ZipFile.cxx
+++ b/package/source/zipapi/ZipFile.cxx
@@ -694,7 +694,6 @@
 // with timestamp difference in the central directory entry and local
 // file header.
 bBroken = rEntry.nVersion != nVersion
-|| (rEntry.nFlag  ~6L) != (nFlag  ~6L)
 || rEntry.nPathLen != nPathLen
 || !rEntry.sPath.equals( sLOCPath );
 }

-- 
To view, visit https://gerrit.libreoffice.org/4094
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0-4] Fix crash with fdo60063-1.docx

2013-05-30 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4103

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/4103/1

Fix crash with fdo60063-1.docx

Compared to the original version, this one tries hard
not to produce empty keywords.

Reviewed-on: https://gerrit.libreoffice.org/4091
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
(cherry picked from commit b2f97d77237cde249b4c40acc8ad3f7f8755e768)
(cherry picked from commit 693707e338922d8dc7578975a1990e8a1cba6a53)

Conflicts:
oox/source/docprop/docprophandler.cxx

Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
Reviewed-on: https://gerrit.libreoffice.org/4093
Reviewed-by: Miklos Vajna vmik...@suse.cz
Tested-by: Miklos Vajna vmik...@suse.cz
(cherry picked from commit d60f81a3e9d020ff1ae0db2e73551bff45c43256)
---
M oox/source/docprop/docprophandler.cxx
1 file changed, 13 insertions(+), 28 deletions(-)



diff --git a/oox/source/docprop/docprophandler.cxx 
b/oox/source/docprop/docprophandler.cxx
index 1067315..ff6d170 100644
--- a/oox/source/docprop/docprophandler.cxx
+++ b/oox/source/docprop/docprophandler.cxx
@@ -25,6 +25,9 @@
 
 #include osl/time.h
 
+#include vector
+#include boost/algorithm/string.hpp
+
 #include oox/helper/attributelist.hxx
 
 using namespace ::com::sun::star;
@@ -157,39 +160,21 @@
 {
 if ( !aChars.isEmpty() )
 {
-uno::Sequence ::rtl::OUString  aResult( 20 );
-sal_Int32 nCounter = 0;
+std::string aUtf8Chars = rtl::OUStringToOString( aChars, 
RTL_TEXTENCODING_UTF8 ).getStr();
+std::vectorstd::string aUtf8Result;
+boost::split( aUtf8Result, aUtf8Chars, boost::is_any_of( ,;:\t), 
boost::token_compress_on );
 
-const sal_Unicode* pStr = aChars.getStr();
-for( sal_Int32 nInd = 0; nInd  aChars.getLength()  pStr[nInd] != 0; 
nInd++ )
+if (!aUtf8Result.empty())
 {
-switch( pStr[nInd] )
-{
-case (sal_Unicode)' ':
-case (sal_Unicode)',':
-case (sal_Unicode)';':
-case (sal_Unicode)':':
-case (sal_Unicode)'\t':
-// this is a delimiter
-// unfortunately I did not find any specification for the 
possible delimiters
-if ( !aResult[nCounter].isEmpty() )
-{
-if ( nCounter = aResult.getLength() )
-aResult.realloc( nCounter + 10 );
-nCounter++;
-}
-break;
+uno::Sequence rtl::OUString  aResult( aUtf8Result.size() );
+OUString* pResultValues = aResult.getArray();
+for ( std::vector std::string ::const_iterator i = 
aUtf8Result.begin();
+  i != aUtf8Result.end(); ++i, ++pResultValues )
+*pResultValues = rtl::OUString( i-c_str(), static_cast 
sal_Int32 ( i-size() ),RTL_TEXTENCODING_UTF8 );
 
-default:
-// this should be a part of keyword
-aResult[nCounter] += ::rtl::OUString( 
(sal_Unicode)pStr[nInd] );
-}
+return aResult;
 }
-
-aResult.realloc( nCounter + 1 );
-return aResult;
 }
-
 return uno::Sequence ::rtl::OUString ();
 }
 // 

-- 
To view, visit https://gerrit.libreoffice.org/4103
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0-4
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0-4] Accept even more corrupted zip documents as long as we can r...

2013-05-30 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4104

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/4104/1

Accept even more corrupted zip documents as long as we can read them

Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710
(cherry picked from commit 1b049bd2dae52dc154ea6bee075a254a9b6cc318)
(cherry picked from commit d360333f83e3115219c3928525060c6c2a8711db)
(cherry picked from commit 0ed9f3a30ae2069d88d6a45d4f73817aa8596fbf)
---
M package/source/zipapi/ZipFile.cxx
1 file changed, 0 insertions(+), 1 deletion(-)



diff --git a/package/source/zipapi/ZipFile.cxx 
b/package/source/zipapi/ZipFile.cxx
index 0da4c33..23d33c0 100644
--- a/package/source/zipapi/ZipFile.cxx
+++ b/package/source/zipapi/ZipFile.cxx
@@ -694,7 +694,6 @@
 // with timestamp difference in the central directory entry and local
 // file header.
 bBroken = rEntry.nVersion != nVersion
-|| (rEntry.nFlag  ~6L) != (nFlag  ~6L)
 || rEntry.nPathLen != nPathLen
 || !rEntry.sPath.equals( sLOCPath );
 }

-- 
To view, visit https://gerrit.libreoffice.org/4104
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0-4
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-3-6] fdo#65039 UI: Oxygen theme has wrong icon for Power regressi...

2013-05-28 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4064

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4064
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86b927d5c2e6a643beac8b9a151f572c028c18f3
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Andras Timar ati...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Source files shouldn't have executable bit set.

2013-05-28 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4070

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4070
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafad6249a7998d7c749c1ca2979a606078cfcb5e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard m...@klomp.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Uploading libwps 0.2.9

2013-05-25 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4033

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4033
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Uploading libwps 0.2.9

2013-05-25 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4033

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/4033/1

Uploading libwps 0.2.9

Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758
---
M download.lst
M libwps/UnpackedTarball_libwps.mk
2 files changed, 1 insertion(+), 8 deletions(-)



diff --git a/download.lst b/download.lst
index 50ecc7f..5398cc2 100644
--- a/download.lst
+++ b/download.lst
@@ -86,7 +86,7 @@
 export VIGRA_TARBALL := ea91f2fb4212a21d708aced277e6e85a-vigra1.4.0.tar.gz
 export WPD_TARBALL := 972afb8fdf02d9e7517e258b7fa7f0eb-libwpd-0.9.8.tar.bz2
 export WPG_TARBALL := b85436266b2ac91d351ab5684b181151-libwpg-0.2.2.tar.bz2
-export WPS_TARBALL := 78196c097db366fac66841d032b1ddac-libwps-0.2.8.tar.bz2
+export WPS_TARBALL := 46eb0e7f213ad61bd5dee0c494132cb0-libwps-0.2.9.tar.bz2
 export XPDF_TARBALL := 599dc4cc65a07ee868cf92a667a913d2-xpdf-3.02.tar.gz
 export XSLTML_TARBALL := a7983f859eafb2677d7ff386a023bc40-xsltml_2.1.2.zip
 export ZLIB_TARBALL := 2ab442d169156f34c379c968f3f482dd-zlib-1.2.7.tar.bz2
diff --git a/libwps/UnpackedTarball_libwps.mk b/libwps/UnpackedTarball_libwps.mk
index 7c31bf8..1fd633a 100644
--- a/libwps/UnpackedTarball_libwps.mk
+++ b/libwps/UnpackedTarball_libwps.mk
@@ -11,11 +11,4 @@
 
 $(eval $(call gb_UnpackedTarball_set_tarball,libwps,$(WPS_TARBALL)))
 
-# HACK to avoid the need to deliver the headers to $(OUTDIR). This
-# should be removed when libwps is updated.
-$(eval $(call gb_UnpackedTarball_set_post_action,libwps,\
-   mkdir -p inc/libwps  \
-   cp -f src/lib/libwps.h src/lib/WPSDocument.h inc/libwps \
-))
-
 # vim: set noet sw=4 ts=4:

-- 
To view, visit https://gerrit.libreoffice.org/4033
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-1] Uploading libwps 0.2.9

2013-05-25 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4034

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/4034/1

Uploading libwps 0.2.9

Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758
Reviewed-on: https://gerrit.libreoffice.org/4033
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
(cherry picked from commit 989da70779af441436fc46bbe7b95902e1da837e)
---
M download.lst
M libwps/ExternalPackage_libwps.mk
2 files changed, 3 insertions(+), 3 deletions(-)



diff --git a/download.lst b/download.lst
index 38466ab..040b6b4 100644
--- a/download.lst
+++ b/download.lst
@@ -86,7 +86,7 @@
 export VIGRA_TARBALL := ea91f2fb4212a21d708aced277e6e85a-vigra1.4.0.tar.gz
 export WPD_TARBALL := 972afb8fdf02d9e7517e258b7fa7f0eb-libwpd-0.9.8.tar.bz2
 export WPG_TARBALL := b85436266b2ac91d351ab5684b181151-libwpg-0.2.2.tar.bz2
-export WPS_TARBALL := 78196c097db366fac66841d032b1ddac-libwps-0.2.8.tar.bz2
+export WPS_TARBALL := 46eb0e7f213ad61bd5dee0c494132cb0-libwps-0.2.9.tar.bz2
 export XPDF_TARBALL := 599dc4cc65a07ee868cf92a667a913d2-xpdf-3.02.tar.gz
 export XSLTML_TARBALL := a7983f859eafb2677d7ff386a023bc40-xsltml_2.1.2.zip
 export ZLIB_TARBALL := 2ab442d169156f34c379c968f3f482dd-zlib-1.2.7.tar.bz2
diff --git a/libwps/ExternalPackage_libwps.mk b/libwps/ExternalPackage_libwps.mk
index 995ec7c..5bf77ff 100644
--- a/libwps/ExternalPackage_libwps.mk
+++ b/libwps/ExternalPackage_libwps.mk
@@ -10,8 +10,8 @@
 $(eval $(call gb_ExternalPackage_ExternalPackage,libwps,libwps))
 
 $(eval $(call 
gb_ExternalPackage_add_unpacked_files,libwps,inc/external/libwps,\
-   src/lib/libwps.h \
-   src/lib/WPSDocument.h \
+   inc/libwps/libwps.h \
+   inc/libwps/WPSDocument.h \
 ))
 
 $(eval $(call gb_ExternalPackage_use_external_project,libwps,libwps))

-- 
To view, visit https://gerrit.libreoffice.org/4034
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] Uploading libwps 0.2.9

2013-05-25 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4034

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4034
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Splitter::ImplInitHorVer(bool) should always initialize all ...

2013-05-23 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4007

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4007
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If84e8bff4c87d208416de3583202ce88d6982a99
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard m...@klomp.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#52540 fix hyphenation of Graphite ligatures

2013-05-22 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3999

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3999
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c6aef6d845a7494d54b3c902654b21f3939e8cf
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Németh László nem...@numbertext.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] fdo#52540 fix hyphenation of Graphite ligatures

2013-05-22 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4000

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4000
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c6aef6d845a7494d54b3c902654b21f3939e8cf
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Németh László nem...@numbertext.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] Ensure SolarMutex is locked at DBG_TESTSOLARMUTEX checkpoint...

2013-05-22 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4003

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4003
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I017acf2886b813adb4d44562c5f1e22dd24aa884
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#64870 Duplicate shortcut on Text Import dialogue

2013-05-22 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4004

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4004
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia25f03e437378c49e90376dff8aa0826d53265a6
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] fdo#64870 Duplicate shortcut on Text Import dialogue

2013-05-22 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4005

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4005
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia25f03e437378c49e90376dff8aa0826d53265a6
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Add mouse rollover effect to menubar on KDE and Windows

2013-05-22 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3856

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3856
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ececd8a7089918ac63c5f2027c0c2f361a9d227
Gerrit-PatchSet: 34
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Isamu Mogi saturda...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Isamu Mogi saturda...@gmail.com
Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] AppendAscii cleanup

2013-05-22 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3974

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3974
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7398272de0bd340ebfb5f31b314d32fcff007eec
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: Matteo Casalin matteo.casa...@yahoo.com
Gerrit-Reviewer: Ricardo Montania rica...@linuxafundo.com.br

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED libreoffice-4-0] fdo#64870 Duplicate shortcut on Text Import dialogue

2013-05-22 Thread Fridrich Strba (via Code Review)

Fridrich Strba has abandoned this change.

Change subject: fdo#64870 Duplicate shortcut on Text Import dialogue
..


Patch Set 1: Abandoned

This file does not exist in libreoffice-4-0 branch

-- 
To view, visit https://gerrit.libreoffice.org/4006
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia25f03e437378c49e90376dff8aa0826d53265a6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#64652 remove length restriction of Replace edit box

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3986

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3986
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0141dc06d940e64244909ddcb8b7e5bb797c337f
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Andras Timar ati...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Fix two SfxFilterMatcher_Impl memory leaks.

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3989

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3989
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7840aaddc861f609fbe14d5b6c0ea20d997f690f
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard m...@klomp.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#46553 Update embedded manifest on win32 builds to declar...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3987

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3987
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I71a3960b21f2c996b97e1a5707f20b30819fd6bd
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Andras Timar ati...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Re-add PNG file that used to have a pathological (LF) filena...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3985

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3985
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id91c9d5cd462e73a243d9c5670572a9c2293798e
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Isamu Mogi saturda...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Avoid pathological filename, breaking checkout on some syste...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3984

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3984
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I125e506531248c167cda20714228777e102a24e9
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Isamu Mogi saturda...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] move DBG_UNHANDLED_EXCEPTION out of line

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3988

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3988
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2827aa3618ba966fbc85a4a56e0e794a55630730
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Noel Grandin noelgran...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Little cleanup in image loader internal functions

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3950

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3950
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6def704dc22d7a536849a9e4b51a08bf68778329
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] make 64-bit shell extensions work, put 64-bit VC runtime in ...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3990

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3990
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I47060f8ff764ca1156596139ecbec003f964bc60
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Andras Timar ati...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#64826: fix for exporting to DOCX that didnt save track '...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3991

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3991
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5b3198769a08cc751d542f8305fd7f41c73ec26
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Adam CloudOn rattles2...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#47951 flat text table: update m_nRowPos when moving by b...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3961

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3961
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-3-6] fdo#47951 flat text table: update m_nRowPos when moving by b...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3962

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3962
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#47951 work around underlying cause

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3959

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3959
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I628d9b870df2bbc402637818f987637d3bd62897
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-3-6] fdo#47951 work around underlying cause

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3963

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3963
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I628d9b870df2bbc402637818f987637d3bd62897
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Loader's ImageTree doesn't store multiple image paths anymor...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3951

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3951
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd13039a76c46bfccad5f54e3357dde952508211
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#62483 missing default button in format - aligment dialo...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3995

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3995
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05a079cacf6e5ac73861aff4a7dab7a455f3f181
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#62483 missing default button in format - aligment dialo...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3994

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3994
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05a079cacf6e5ac73861aff4a7dab7a455f3f181
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Update HarfBuzz to 0.9.17

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3993

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3993
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If84a1eb7dbd54b4f1e3d876eb63cc3f2f8e51938
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Khaled Hosny khaledho...@eglug.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removal of includes not needed anymore

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3952

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3952
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5dccad8629a59e92dc2864e2b3630732a631ee96
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Allow 'textual links' on icon theme packages

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3953

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3953
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia65a1ba18f93297fae47fa520104821f6f336694
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] fdo#62483 missing default button in format - aligment dialo...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3996

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3996
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05a079cacf6e5ac73861aff4a7dab7a455f3f181
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] valgrind: Initialize all of struct sockaddr_rc for binding A...

2013-05-21 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3998

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3998
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05d2f221a5794228dae3077e8ea1bcda5ba1f8b0
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard m...@klomp.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Thread-safe version of osl_getGlobalTime

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3960

Approvals:
  LibreOffice gerrit bot: Verified
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3960
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb9d23780600437f607d866ff3d396b96879245d
Gerrit-PatchSet: 11
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Create liblcms2.so.2 as a real library in solver.

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3973

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3973
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7425131373a6521e802c85d53fbee6a792b1604
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fix wildcard handling regression( for basic functions like D...

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3975

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3975
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3932bdb441fe6b08cefa6331870956664ade77bd
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Noel Power noel.po...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Make some uses of OUStrings a little more readable

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3949

Approvals:
  Luboš Luňák: Verified; Looks good to me, approved
  Fridrich Strba: 


-- 
To view, visit https://gerrit.libreoffice.org/3949
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e85fa39abbff86918464aae67b4b9eacd3bf7a4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#46553 Update embedded manifest on win32 builds to declar...

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3981

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3981
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I71a3960b21f2c996b97e1a5707f20b30819fd6bd
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Andras Timar ati...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Fix memory leak in mapToFontConfigLangTag.

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3967

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3967
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7fe0dd160fa59077d6a90878e70d0e034680812
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard m...@klomp.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] valgrind support is useful independent from DBGUTIL support.

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3966

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3966
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7d2ac5476ba8561ce6afbf8c9472550fbe959c76
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard m...@klomp.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#30715 Several commands are under the wrong category

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3854

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3854
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib322aaace39cd160cc81ef4945abd2047e6c4c12
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] resolve fdo#64446 Repeat shortcut isn't showed correctly in ...

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3850

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3850
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I991185f6b4efd305dc55c9ad85f9f706f8a0
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3917

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3917
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0054bc90fdcaa2fef7e1d98a0528277be4fc341e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ioan Radu ioan.rad...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] sw: convert some usage of Point::X/Y to Point::set/getX/Y, t...

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3929

Approvals:
  Miklos Vajna: Looks good to me, but someone else must approve
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3929
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I79fe610e4cc8bbbddbd8415198d6309a93f4ba18
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Miklos Vajna vmik...@suse.cz
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Fix fdo#64751 – Header footer blue tags empty

2013-05-20 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3980

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3980
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic467e56ed6b8d245ac7800f94e6d40030833328b
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Khaled Hosny khaledho...@eglug.org
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] resolved fdo#56772 keep track of HTML ON/OFF tokens

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3925

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3925
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b3190d297a35ee3dfda95f9a4841f7c53ed4a92
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Eike Rathke er...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-3-6] resolved fdo#56772 keep track of HTML ON/OFF tokens

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3926

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3926
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b3190d297a35ee3dfda95f9a4841f7c53ed4a92
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Eike Rathke er...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-3-6] fdo#60967: re-enable deletion of paragraph following table

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3927

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3927
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia88b3c8958798fd9c64ee75b56c61d787079133e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] Revert fdo#63878 fix the zoom problem when the sheet are RT...

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3932

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3932
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1165ab1a2c0059e40c4963c99cabfcadb7d0bcb4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Noel Power noel.po...@suse.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] No need for the soffice.bin identical copy of soffice on OS ...

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3931

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3931
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e133fb53e58da4ad5e3eb02163eb6082d895b15
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Tor Lillqvist t...@iki.fi
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Let's assume nobody needs the sbase, scalc etc scripts on OS...

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3930

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3930
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iceea270c03a63f674e7dfdfa95117cb3bdd15184
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Tor Lillqvist t...@iki.fi
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Make libcdr build a little bit less verbose

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3943

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3943/1

Make libcdr build a little bit less verbose

(cherry picked from commit 4c3ad94c70f98f5062bf96a6f1339992b7ec2bd1)

Conflicts:
libcdr/ExternalProject_libcdr.mk

Change-Id: I8e70cd72e8c7934b2a04fbe6b9ed5f662c494960
---
M libcdr/ExternalProject_libcdr.mk
1 file changed, 1 insertion(+), 0 deletions(-)



diff --git a/libcdr/ExternalProject_libcdr.mk b/libcdr/ExternalProject_libcdr.mk
index d7e7693..56378ab 100644
--- a/libcdr/ExternalProject_libcdr.mk
+++ b/libcdr/ExternalProject_libcdr.mk
@@ -73,6 +73,7 @@
--without-docs \
--disable-debug \
--disable-werror \
+   --disable-weffc \
$(if $(filter 
NO,$(SYSTEM_BOOST)),CXXFLAGS=-I$(OUTDIR)/inc/external) \
$(if $(filter YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) 
--host=$(HOST_PLATFORM)) \
 (cd $(EXTERNAL_WORKDIR)/src/lib  $(MAKE)) \

-- 
To view, visit https://gerrit.libreoffice.org/3943
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e70cd72e8c7934b2a04fbe6b9ed5f662c494960
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Silence a bit libcdr build

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3944

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3944/1

Silence a bit libcdr build

Change-Id: I9bae7d0ea71072168ba53d7376e816bcd05722fa
(cherry picked from commit 6389bf38961d84fd3e1c8fbdc78040e1b1be3ba9)
---
M boost/UnpackedTarball_boost.mk
A boost/boost.libcdr.warnings.patch.1
2 files changed, 695 insertions(+), 0 deletions(-)



diff --git a/boost/UnpackedTarball_boost.mk b/boost/UnpackedTarball_boost.mk
index b7c22f5..0682306 100644
--- a/boost/UnpackedTarball_boost.mk
+++ b/boost/UnpackedTarball_boost.mk
@@ -35,6 +35,7 @@
 
 boost_patches += boost.windows.patch
 boost_patches += boost.vc2012.patch
+boost_patches += boost.libcdr.warnings.patch.1
 
 # Help static analysis tools (see SAL_UNUSED_PARAMETER in sal/types.h):
 ifeq (GCC,$(COM))
diff --git a/boost/boost.libcdr.warnings.patch.1 
b/boost/boost.libcdr.warnings.patch.1
new file mode 100644
index 000..2df0e3b
--- /dev/null
+++ b/boost/boost.libcdr.warnings.patch.1
@@ -0,0 +1,694 @@
+--- boost/boost/archive/basic_archive.hpp  2010-08-11 20:15:46.0 
+0200
 boost/boost/archive/basic_archive.hpp  2013-05-17 15:39:58.62469 
+0200
+@@ -54,7 +54,7 @@
+ return *this;
+ }
+ // used for text output
+-operator const base_type () const {
++operator base_type () const {
+ return t;
+ }
+ // used for text input
+@@ -90,7 +90,7 @@
+ return *this;
+ }
+ // used for text output
+-operator const base_type () const {
++operator base_type () const {
+ return t;
+ }
+ // used for text intput
+@@ -127,7 +127,7 @@
+ }
+ 
+ // used for text output
+-operator const int () const {
++operator int () const {
+ return t;
+ }
+ // used for text input
+@@ -161,7 +161,7 @@
+ return *this;
+ }
+ // used for text output
+-operator const uint_least32_t () const {
++operator uint_least32_t () const {
+ return t;
+ }
+ // used for text input
+@@ -254,7 +254,7 @@
+ #define BOOST_ARCHIVE_STRONG_TYPEDEF(T, D) \
+ class D : public T {   \
+ public:\
+-explicit D(const T t) : T(t){} \
++explicit D(const T t_) : T(t_){} \
+ }; \
+ /**/
+ 
+--- boost/boost/multi_index/detail/index_matcher.hpp   2008-07-03 
18:51:53.0 +0200
 boost/boost/multi_index/detail/index_matcher.hpp   2013-05-17 
15:30:12.539099597 +0200
+@@ -132,17 +132,17 @@
+ entries(),entries()+size_,
+ entry(node),entry::less_by_node()); /* localize entry */
+ ent-ordered=false;
+-std::size_t n=ent-pos; /* get its position */
++std::size_t n_=ent-pos; /* get its position */
+ 
+ entry dummy(0);
+-dummy.pile_top=n;
++dummy.pile_top=n_;
+ 
+ entry* pile_ent=/* find the first available pile 
*/
+   std::lower_bound( /* to stack the entry
*/
+ entries(),entries()+num_piles,
+ dummy,entry::less_by_pile_top());
+ 
+-pile_ent-pile_top=n;   /* stack the entry */
++pile_ent-pile_top=n_;   /* stack the entry */
+ pile_ent-pile_top_entry=ent;
+ 
+ /* if not the first pile, link entry to top of the preceding pile */
+@@ -164,7 +164,7 @@
+*/
+ 
+   entry* ent=entries()[num_piles-1].pile_top_entry;
+-  for(std::size_t n=num_piles;n--;){
++  for(std::size_t n_=num_piles;n_--;){
+ ent-ordered=true;
+ ent=ent-previous;
+   }
+--- boost/boost/multi_index/ordered_index.hpp  2010-07-25 12:44:55.0 
+0200
 boost/boost/multi_index/ordered_index.hpp  2013-05-17 15:33:42.785182819 
+0200
+@@ -436,9 +436,9 @@
+ 
+   templatetypename CompatibleKey,typename CompatibleCompare
+   iterator find(
+-const CompatibleKey x,const CompatibleCompare comp)const
++const CompatibleKey x,const CompatibleCompare comp_)const
+   {
+-return make_iterator(ordered_index_find(root(),header(),key,x,comp));
++return make_iterator(ordered_index_find(root(),header(),key,x,comp_));
+   }
+ 
+   templatetypename CompatibleKey
+@@ -448,9 +448,9 @@
+   }
+ 
+   templatetypename CompatibleKey,typename CompatibleCompare
+-  size_type count(const CompatibleKey x,const CompatibleCompare comp)const
++  size_type count(const CompatibleKey x,const CompatibleCompare comp_)const
+   {
+-std::pairiterator,iterator p=equal_range(x,comp);
++std::pairiterator,iterator p=equal_range(x,comp_);
+ size_type n=std::distance(p.first,p.second);
+ return n;
+   }
+@@ -464,10 +464,10 @@
+ 
+   templatetypename CompatibleKey,typename CompatibleCompare
+   iterator

[PATCH libreoffice-4-0] Uploading new libcdr 0.0.14

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3942

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3942/1

Uploading new libcdr 0.0.14

(cherry picked from commit 0f28a2a5e29499b62074dad4442fafa57858677d)

Conflicts:
download.lst
libcdr/UnpackedTarball_libcdr.mk
libcdr/libcdr-0.0.13.patch

Change-Id: Ifb3f8a7b0e40ee8b33fab4dded3f75f040e75f72
---
M download.lst
M libcdr/ExternalPackage_libcdr.mk
M libcdr/UnpackedTarball_cdr.mk
D libcdr/libcdr-0.0.13.patch
4 files changed, 6 insertions(+), 24 deletions(-)



diff --git a/download.lst b/download.lst
index 657a418..aa1f98c 100644
--- a/download.lst
+++ b/download.lst
@@ -1,5 +1,5 @@
-CDR_MD5SUM := 75700c61b3a8e7d49a1f04c62048ff00
-export CDR_TARBALL := libcdr-0.0.13.tar.bz2
+CDR_MD5SUM := d88f9b94df880d2c05be943b000ca112
+export CDR_TARBALL := libcdr-0.0.14.tar.bz2
 MSPUB_MD5SUM := 1120705cd0f0d9bd5506360bf57b6c2e
 export MSPUB_TARBALL := libmspub-0.0.6.tar.bz2
 VISIO_MD5SUM := 4e9a029d8390a1707eb49a1a918797ff
diff --git a/libcdr/ExternalPackage_libcdr.mk b/libcdr/ExternalPackage_libcdr.mk
index d032e8f..b163eed 100644
--- a/libcdr/ExternalPackage_libcdr.mk
+++ b/libcdr/ExternalPackage_libcdr.mk
@@ -10,10 +10,10 @@
 $(eval $(call gb_ExternalPackage_ExternalPackage,libcdr,cdr))
 
 $(eval $(call 
gb_ExternalPackage_add_unpacked_files,libcdr,inc/external/libcdr,\
-   src/lib/libcdr.h \
-   src/lib/CDRDocument.h \
-   src/lib/CDRStringVector.h \
-   src/lib/CMXDocument.h \
+   inc/libcdr/libcdr.h \
+   inc/libcdr/CDRDocument.h \
+   inc/libcdr/CDRStringVector.h \
+   inc/libcdr/CMXDocument.h \
 ))
 
 $(eval $(call gb_ExternalPackage_use_external_project,libcdr,libcdr))
diff --git a/libcdr/UnpackedTarball_cdr.mk b/libcdr/UnpackedTarball_cdr.mk
index a4a427d..be1e7d7 100644
--- a/libcdr/UnpackedTarball_cdr.mk
+++ b/libcdr/UnpackedTarball_cdr.mk
@@ -11,10 +11,4 @@
 
 $(eval $(call gb_UnpackedTarball_set_tarball,cdr,$(CDR_TARBALL)))
 
-$(eval $(call gb_UnpackedTarball_set_patchlevel,cdr,1))
-
-$(eval $(call gb_UnpackedTarball_add_patches,cdr,\
-   libcdr/libcdr-0.0.13.patch \
-))
-
 # vim: set noet sw=4 ts=4:
diff --git a/libcdr/libcdr-0.0.13.patch b/libcdr/libcdr-0.0.13.patch
deleted file mode 100644
index 29b2b28..000
--- a/libcdr/libcdr-0.0.13.patch
+++ /dev/null
@@ -1,12 +0,0 @@
 a/src/lib/CDRParser.cpp
-+++ b/src/lib/CDRParser.cpp
-@@ -32,6 +32,9 @@
- #include string.h
- #include sstream
- #include set
-+#ifndef BOOST_ALL_NO_LIB
-+#define BOOST_ALL_NO_LIB 1
-+#endif
- #include boost/property_tree/json_parser.hpp
- #include boost/property_tree/ptree.hpp
- #include boost/spirit/include/classic.hpp

-- 
To view, visit https://gerrit.libreoffice.org/3942
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb3f8a7b0e40ee8b33fab4dded3f75f040e75f72
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] resolved fdo#63805 max day of month of the intended month

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3938

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3938
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6b007675104f8e134b278f216c3bb48b72f061c
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Eike Rathke er...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-3-6] resolved fdo#63805 max day of month of the intended month

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3939

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3939
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6b007675104f8e134b278f216c3bb48b72f061c
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Eike Rathke er...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#62965: fix crash in Edit Contour dialog

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3936

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3936
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib20e1806518f7b3b33d3fb4472d79d531ea9f1de
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-3-6] fdo#62965: fix crash in Edit Contour dialog

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3940

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3940
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib20e1806518f7b3b33d3fb4472d79d531ea9f1de
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#57079: SvxSuperContourDlg: unregister configuration list...

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3937

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3937
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3ab7ddf19fb1086f0b7d824555ab6b063e2b9ad
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-3-6] fdo#57079: SvxSuperContourDlg: unregister configuration list...

2013-05-17 Thread Fridrich Strba (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3941

Approvals:
  Fridrich Strba: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3941
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3ab7ddf19fb1086f0b7d824555ab6b063e2b9ad
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

1 2 3 4 5 >

1 - 100 of 467 matches

Mail list logo