core.git: odk/examples

[Ilmari Lauhakangas (via logerrit)]

 odk/examples/DevelopersGuide/Components/Addons/JobsAddon/AsyncJob.java 
   |4 ++--
 odk/examples/DevelopersGuide/Forms/ControlValidator.java   
   |2 +-
 odk/examples/DevelopersGuide/Forms/RowSet.java 
   |2 +-
 odk/examples/DevelopersGuide/Forms/TableCellTextBinding.java   
   |4 ++--
 odk/examples/DevelopersGuide/Forms/WaitForInput.java   
   |2 +-
 
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/JavaWindowPeerFake.java
 |2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 8a73c5725f0ef0494e0a933cbfc22a8f04328ddd
Author: Ilmari Lauhakangas 
AuthorDate: Sun May 12 20:34:09 2024 +0300
Commit: Noel Grandin 
CommitDate: Mon May 13 14:44:47 2024 +0200

odk: classes in java.lang package do not need to be fully qualified

Change-Id: Idcc8af34095496aa6e7f516d9b2b975f7e58799f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167555
Reviewed-by: Noel Grandin 
Tested-by: Jenkins

diff --git 
a/odk/examples/DevelopersGuide/Components/Addons/JobsAddon/AsyncJob.java 
b/odk/examples/DevelopersGuide/Components/Addons/JobsAddon/AsyncJob.java
index 9b55929d870a..c47244b9abbb 100644
--- a/odk/examples/DevelopersGuide/Components/Addons/JobsAddon/AsyncJob.java
+++ b/odk/examples/DevelopersGuide/Components/Addons/JobsAddon/AsyncJob.java
@@ -198,7 +198,7 @@ public class AsyncJob extendsWeakBase implements 
XServiceInfo, XAsyncJob
 ++c;
 aDeactivation   = new com.sun.star.beans.NamedValue();
 aDeactivation.Name  = "Deactivate";
-aDeactivation.Value = java.lang.Boolean.TRUE;
+aDeactivation.Value = Boolean.TRUE;
 }
 
 // Sending of result events is useful inside DISPATCH environment only
@@ -284,7 +284,7 @@ public class AsyncJob extendsWeakBase implements 
XServiceInfo, XAsyncJob
 xInfoBox.setMessageText(sMessage);
 xInfoBox.execute();
 }
-catch(java.lang.Throwable exIgnore)
+catch(Throwable exIgnore)
 {
 // ignore any problem, which can occur here.
 // It's not really a bug for this example job, if
diff --git a/odk/examples/DevelopersGuide/Forms/ControlValidator.java 
b/odk/examples/DevelopersGuide/Forms/ControlValidator.java
index c29dec5585ee..c7afdf369aa7 100644
--- a/odk/examples/DevelopersGuide/Forms/ControlValidator.java
+++ b/odk/examples/DevelopersGuide/Forms/ControlValidator.java
@@ -42,7 +42,7 @@ public abstract class ControlValidator implements 
com.sun.star.form.validation.X
 return ( 
com.sun.star.uno.AnyConverter.getType(Value).getTypeClass()
  == com.sun.star.uno.TypeClass.VOID );
 }
-catch( java.lang.ClassCastException e )
+catch( ClassCastException e )
 {
 }
 return false;
diff --git a/odk/examples/DevelopersGuide/Forms/RowSet.java 
b/odk/examples/DevelopersGuide/Forms/RowSet.java
index 93e62cacf088..37eacaefff0c 100644
--- a/odk/examples/DevelopersGuide/Forms/RowSet.java
+++ b/odk/examples/DevelopersGuide/Forms/RowSet.java
@@ -58,7 +58,7 @@ public class RowSet implements XRowSet, XRow
 catch ( Exception e )
 {
 e.printStackTrace(System.err);
-throw new java.lang.InstantiationError();
+throw new InstantiationError();
 }
 }
 
diff --git a/odk/examples/DevelopersGuide/Forms/TableCellTextBinding.java 
b/odk/examples/DevelopersGuide/Forms/TableCellTextBinding.java
index 23a9e4226231..c1464c4b1ae3 100644
--- a/odk/examples/DevelopersGuide/Forms/TableCellTextBinding.java
+++ b/odk/examples/DevelopersGuide/Forms/TableCellTextBinding.java
@@ -37,7 +37,7 @@ import com.sun.star.text.XTextRange;
 content to other interested parties.
 */
 public class TableCellTextBinding
-extends java.lang.Thread
+extends Thread
 implements  com.sun.star.form.binding.XValueBinding,
 com.sun.star.util.XModifyBroadcaster
 {
@@ -95,7 +95,7 @@ public class TableCellTextBinding
 {
 text = (String)obj;
 }
-catch( java.lang.ClassCastException e )
+catch( ClassCastException e )
 {
 throw new com.sun.star.form.binding.IncompatibleTypesException();
 }
diff --git a/odk/examples/DevelopersGuide/Forms/WaitForInput.java 
b/odk/examples/DevelopersGuide/Forms/WaitForInput.java
index e5891ada4afd..b05544f1fb4f 100644
--- a/odk/examples/DevelopersGuide/Forms/WaitForInput.java
+++ b/odk/examples/DevelopersGuide/Forms/WaitForInput.java
@@ -16,7 +16,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-class WaitForInput extends java.lang.Thread
+class WaitForInput extends Thread
 {
 priv

Re: Windows build broken.

[Ilmari Lauhakangas]

On 13.5.2024 11.09, Regis Perdreau wrote:


Hi,

I follow carefully again windows build instruction wiki, but the windows 
build does not work again. Could you we expect that it will work for 
everybody not only on developper's computer ? (i know it's sometimes 
difficult, but if we could have some news, it's better)


Please share the text output showing how the build fails.

Ilmari

core.git: external/hunspell external/hyphen external/mythes

[Ilmari Lauhakangas (via logerrit)]

 external/hunspell/README |2 +-
 external/hyphen/README   |2 +-
 external/mythes/README   |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 75ff14d9cba2fca20d8ff958bdd9f6a931f88333
Author: Ilmari Lauhakangas 
AuthorDate: Sat May 11 14:26:23 2024 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Sat May 11 13:28:17 2024 +0200

Update Hunspell URL in readmes

Change-Id: Ic1a993029060a1260dffa126a930e29d4135fe61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167506
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/external/hunspell/README b/external/hunspell/README
index 1221735cad65..4ec341fc1414 100644
--- a/external/hunspell/README
+++ b/external/hunspell/README
@@ -1,4 +1,4 @@
 Library for spell checking.
 
 From:
-[http://hunspell.sourceforge.net/].
+[https://hunspell.github.io/].
diff --git a/external/hyphen/README b/external/hyphen/README
index 327b5b6e8954..ec03fb1319ce 100644
--- a/external/hyphen/README
+++ b/external/hyphen/README
@@ -1 +1 @@
-Hyphenator library from [http://hunspell.sourceforge.net]
+Hyphenator library from [https://hunspell.github.io/]
diff --git a/external/mythes/README b/external/mythes/README
index 8a1792ee05b3..1195dee836f7 100644
--- a/external/mythes/README
+++ b/external/mythes/README
@@ -1 +1 @@
-Library for handling thesaurus files from [http://hunspell.sourceforge.net].
+Library for handling thesaurus files from [https://hunspell.github.io/].

core.git: odk/README.md

[Ilmari Lauhakangas (via logerrit)]

 odk/README.md |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 69980bb2f951f780e63718215ca522a69676febf
Author: Ilmari Lauhakangas 
AuthorDate: Wed May 8 11:46:40 2024 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Fri May 10 07:18:25 2024 +0200

odk/README.md: easy way to build examples on Linux and macOS

Change-Id: Ib511e81830a3e4b83f391d3f2d771dc657ee12b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167333
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas 
Tested-by: Ilmari Lauhakangas 

diff --git a/odk/README.md b/odk/README.md
index ee54679bb13c..c6499cf6801d 100644
--- a/odk/README.md
+++ b/odk/README.md
@@ -8,7 +8,9 @@ Part of the SDK; to build you need to add `--enable-odk`.
 
 ## Testing the Examples:
 
-* Go to `instdir/sdk` (Don't try directly in `odk/`)
+* The easiest way on Linux and macOS is to run `make odk.subsequentcheck`
+
+* The way that also works on Windows is to go to `instdir/sdk` (don't try 
directly in `odk/`)
 
 * See <https://api.libreoffice.org/docs/install.html> how to set up the SDK.
 

core.git: odk/examples

[Ilmari Lauhakangas (via logerrit)]

 odk/examples/DevelopersGuide/Database/sdbcx.java |   18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 3d1a96d85d1a0e54e37cc8cd83c6216709360729
Author: Ilmari Lauhakangas 
AuthorDate: Thu May 9 21:02:06 2024 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Fri May 10 07:17:35 2024 +0200

odk/examples: grammar and comment fixes

Change-Id: I86174573d9f59135865496a4f3ee5efb86141ffb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167410
Reviewed-by: Ilmari Lauhakangas 
Tested-by: Ilmari Lauhakangas 
Tested-by: Jenkins

diff --git a/odk/examples/DevelopersGuide/Database/sdbcx.java 
b/odk/examples/DevelopersGuide/Database/sdbcx.java
index 8d7bcab93a78..e4e53a3db7e9 100644
--- a/odk/examples/DevelopersGuide/Database/sdbcx.java
+++ b/odk/examples/DevelopersGuide/Database/sdbcx.java
@@ -180,7 +180,7 @@ public class sdbcx
 public static void printColumns(XColumnsSupplier xColumnsSup)
 {
 System.out.println("Example printColumns");
-// the table must be at least support a XColumnsSupplier interface
+// the table must at least support a XColumnsSupplier interface
 System.out.println("--- Columns ---");
 XNameAccess xColumns = xColumnsSup.getColumns();
 String [] aColumnNames = xColumns.getElementNames();
@@ -189,7 +189,7 @@ public class sdbcx
 }
 
 // 16. example
-// print all keys inclusive the columns of a key
+// print all keys including the columns of a key
 
 public static void printKeys(XColumnsSupplier xColumnsSup) throws 
com.sun.star.uno.Exception
 {
@@ -211,7 +211,7 @@ public class sdbcx
 }
 
 // 17. example
-// print all keys inclusive the columns of a key
+// print all indexes including the columns of an index
 
 public static void printIndexes(XColumnsSupplier xColumnsSup) throws 
com.sun.star.uno.Exception
 {
@@ -346,29 +346,29 @@ public class sdbcx
 xCol.setPropertyValue("Type",Integer.valueOf(DataType.INTEGER));
 
xCol.setPropertyValue("IsNullable",Integer.valueOf(ColumnValue.NO_NULLS));
 xAppend.appendByDescriptor(xCol);
-// 2nd only set the properties which differs
+// 2nd only set the properties which differ
 xCol.setPropertyValue("Name","FIRSTNAME");
 xCol.setPropertyValue("Type",Integer.valueOf(DataType.VARCHAR));
 
xCol.setPropertyValue("IsNullable",Integer.valueOf(ColumnValue.NULLABLE));
 xCol.setPropertyValue("Precision",Integer.valueOf(50));
 xAppend.appendByDescriptor(xCol);
-// 3nd only set the properties which differs
+// 3rd only set the properties which differ
 xCol.setPropertyValue("Name","LASTNAME");
 xCol.setPropertyValue("Precision",Integer.valueOf(100));
 xAppend.appendByDescriptor(xCol);
-// 4nd only set the properties which differs
+// 4th only set the properties which differ
 xCol.setPropertyValue("Name","STREET");
 xCol.setPropertyValue("Precision",Integer.valueOf(50));
 xAppend.appendByDescriptor(xCol);
-// 5nd only set the properties which differs
+// 5th only set the properties which differ
 xCol.setPropertyValue("Name","STATE");
 xAppend.appendByDescriptor(xCol);
-// 6nd only set the properties which differs
+// 6th only set the properties which differ
 xCol.setPropertyValue("Name","ZIP");
 xCol.setPropertyValue("Type",Integer.valueOf(DataType.INTEGER));
 xCol.setPropertyValue("Precision",Integer.valueOf(10)); // default 
value integer
 xAppend.appendByDescriptor(xCol);
-// 7nd only set the properties which differs
+// 7th only set the properties which differ
 xCol.setPropertyValue("Name","BIRTHDATE");
 xCol.setPropertyValue("Type",Integer.valueOf(DataType.DATE));
 xCol.setPropertyValue("Precision",Integer.valueOf(10)); // default 
value integer

core.git: pyuno/source

[Ilmari Lauhakangas (via logerrit)]

 pyuno/source/loader/pyuno_loader.cxx |   22 +++---
 1 file changed, 19 insertions(+), 3 deletions(-)

New commits:
commit da0e9240bf6505ac3a67ff985705950566c66144
Author: Ilmari Lauhakangas 
AuthorDate: Thu Dec 21 12:01:50 2023 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Thu May 9 09:32:47 2024 +0200

tdf#158447 Use PyConfig for setting Python home directory with Python >= 3.8

Change-Id: Ic5b7c60613b22f5215cb1a2a13fecf3e0946ca49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161089
Reviewed-by: Ilmari Lauhakangas 
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
Tested-by: Ilmari Lauhakangas 

diff --git a/pyuno/source/loader/pyuno_loader.cxx 
b/pyuno/source/loader/pyuno_loader.cxx
index 008d58634947..1e00773761e7 100644
--- a/pyuno/source/loader/pyuno_loader.cxx
+++ b/pyuno/source/loader/pyuno_loader.cxx
@@ -114,7 +114,11 @@ static PyRef getObjectFromLoaderModule( const char * func )
 return object;
 }
 
+#if PY_VERSION_HEX >= 0x0308
+static void setPythonHome ( const OUString & pythonHome, PyConfig * config )
+#else
 static void setPythonHome ( const OUString & pythonHome )
+#endif
 {
 OUString systemPythonHome;
 osl_getSystemPathFromFileURL( pythonHome.pData, &(systemPythonHome.pData) 
);
@@ -138,9 +142,11 @@ static void setPythonHome ( const OUString & pythonHome )
 PyErr_SetString(PyExc_SystemError, "python home path is too long");
 return;
 }
-SAL_WNODEPRECATED_DECLARATIONS_PUSH
-Py_SetPythonHome(wide); // deprecated since python 3.11
-SAL_WNODEPRECATED_DECLARATIONS_POP
+#if PY_VERSION_HEX >= 0x0308
+config->home = wide;
+#else
+Py_SetPythonHome(wide);
+#endif
 }
 
 static void prependPythonPath( std::u16string_view pythonPathBootstrap )
@@ -192,11 +198,17 @@ void pythonInit() {
 if ( Py_IsInitialized()) // may be inited by getComponentContext() already
 return;
 
+#if PY_VERSION_HEX >= 0x0308
+PyConfig config;
+#endif
 OUString pythonPath;
 OUString pythonHome;
 OUString path( "$BRAND_BASE_DIR/" LIBO_ETC_FOLDER "/" 
SAL_CONFIGFILE("pythonloader.uno" ));
 rtl::Bootstrap::expandMacros(path); //TODO: detect failure
 rtl::Bootstrap bootstrap(path);
+#if PY_VERSION_HEX >= 0x0308
+PyConfig_InitPythonConfig(  );
+#endif
 
 // look for pythonhome
 bootstrap.getFrom( "PYUNO_LOADER_PYTHONHOME", pythonHome );
@@ -205,7 +217,11 @@ void pythonInit() {
 // pythonhome+pythonpath must be set before Py_Initialize(), otherwise 
there appear warning on the console
 // sadly, there is no api for setting the pythonpath, we have to use the 
environment variable
 if( !pythonHome.isEmpty() )
+#if PY_VERSION_HEX >= 0x0308
+setPythonHome( pythonHome,  );
+#else
 setPythonHome( pythonHome );
+#endif
 
 if( !pythonPath.isEmpty() )
 prependPythonPath( pythonPath );

core.git: odk/examples

[Ilmari Lauhakangas (via logerrit)]

 
odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
 |   10 +-
 odk/examples/DevelopersGuide/ProfUNO/CppBinding/string_samples.cxx 
   |8 ++--
 2 files changed, 7 insertions(+), 11 deletions(-)

New commits:
commit 971eb758132994b5dfacf0af456fbb96f1863534
Author: Ilmari Lauhakangas 
AuthorDate: Mon May 6 18:49:34 2024 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Tue May 7 07:42:35 2024 +0200

odk/examples: grammar fixes

Also remove outdated comment related to RTL_CONSTASCII_STRINGPARAM
(only the first line was removed in the past)

Change-Id: Iebef1bf83ab049a96c846e714cb700df4dacd878
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167233
Tested-by: Ilmari Lauhakangas 
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas 

diff --git 
a/odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
 
b/odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
index 426caaf361b8..943bf623d109 100644
--- 
a/odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
+++ 
b/odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
@@ -108,7 +108,7 @@ void SAL_CALL Addon::initialize( const Sequence< Any >& 
aArguments )
 
 /**
   * Called by the Office framework.
-  * We are ask to query the given URL and return a dispatch object if the URL
+  * We are asked to query the given URL and return a dispatch object if the URL
   * contains an Add-On command.
   */
 Reference< XDispatch > SAL_CALL Addon::queryDispatch( const URL& aURL, const 
::rtl::OUString& sTargetFrameName, sal_Int32 nSearchFlags )
@@ -129,7 +129,7 @@ Reference< XDispatch > SAL_CALL Addon::queryDispatch( const 
URL& aURL, const ::r
 
 /**
   * Called by the Office framework.
-  * We are ask to execute the given Add-On command URL.
+  * We are asked to execute the given Add-On command URL.
   */
 void SAL_CALL Addon::dispatch( const URL& aURL, const Sequence < PropertyValue 
>& lArgs )
 {
@@ -159,7 +159,7 @@ void SAL_CALL Addon::dispatch( const URL& aURL, const 
Sequence < PropertyValue >
 
 /**
   * Called by the Office framework.
-  * We are ask to query the given sequence of URLs and return dispatch objects 
if the URLs
+  * We are asked to query the given sequence of URLs and return dispatch 
objects if the URLs
   * contain Add-On commands.
   */
 Sequence < Reference< XDispatch > > SAL_CALL Addon::queryDispatches( const 
Sequence < DispatchDescriptor >& seqDescripts )
@@ -175,7 +175,7 @@ Sequence < Reference< XDispatch > > SAL_CALL 
Addon::queryDispatches( const Seque
 
 /**
   * Called by the Office framework.
-  * We are ask to query the given sequence of URLs and return dispatch objects 
if the URLs
+  * We are asked to query the given sequence of URLs and return dispatch 
objects if the URLs
   * contain Add-On commands.
   */
 void SAL_CALL Addon::addStatusListener( const Reference< XStatusListener >& 
xControl, const URL& aURL )
@@ -184,7 +184,7 @@ void SAL_CALL Addon::addStatusListener( const Reference< 
XStatusListener >& xCon
 
 /**
   * Called by the Office framework.
-  * We are ask to query the given sequence of URLs and return dispatch objects 
if the URLs
+  * We are asked to query the given sequence of URLs and return dispatch 
objects if the URLs
   * contain Add-On commands.
   */
 void SAL_CALL Addon::removeStatusListener( const Reference< XStatusListener >& 
xControl, const URL& aURL )
diff --git a/odk/examples/DevelopersGuide/ProfUNO/CppBinding/string_samples.cxx 
b/odk/examples/DevelopersGuide/ProfUNO/CppBinding/string_samples.cxx
index f8bb34f97cd4..7de5d36a2025 100644
--- a/odk/examples/DevelopersGuide/ProfUNO/CppBinding/string_samples.cxx
+++ b/odk/examples/DevelopersGuide/ProfUNO/CppBinding/string_samples.cxx
@@ -59,10 +59,6 @@ SAL_IMPLEMENT_MAIN()
 
 // numbers can be simply appended
 buf.append(M_PI);
-
-// lets the compiler count the stringlength, so this is more efficient than
-// the above appendAscii call, where length of the string must be 
calculated at
-// runtime
 buf.append(" ) multiplied with ");
 buf.append(n);
 buf.append(" gives ");
@@ -70,10 +66,10 @@ SAL_IMPLEMENT_MAIN()
 buf.append(".");
 
 // now transfer the buffer into the string.
-// afterwards buffer is empty and may be reused again !
+// afterwards buffer is empty and may be reused again!
 OUString string = buf.makeStringAndClear();
 
-// I could of course also used the OStringBuffer directly
+// You could of course use the OStringBuffer directly to get an OString
 OString oString = rtl::OUStringToOString(string, 
RTL_TEXTENCODING_ASCII_US);
 
 // just to print something

Gerrit upgrade goodies (3.6 -> 3.8)

[Ilmari Lauhakangas]

Recently TDF's infra team upgraded Gerrit from 3.6 to 3.8, which 
involved quite a bit of wrangling with a new build system. I encourage 
everyone to study the release notes and spot improvements which might 
otherwise fly under the radar:

https://www.gerritcodereview.com/3.7.html
https://www.gerritcodereview.com/3.8.html

If you like to use a dark theme, Gerrit now by default picks it up from 
system preferences and you can control it further via Settings - 
Preferences - Theme.


Some might find the new bulk actions feature useful:
https://www.gerritcodereview.com/3.7.html#bulk-actions-on-search-results-and-dashboard

Not mentioned in the notes, we now see an "(executable)" label in the 
file list of a change for files with that bit set, which helps in 
noticing an unwanted mode change.


Ilmari

core.git: officecfg/registry vcl/source

[Ilmari Lauhakangas (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/Accelerators.xcu |6 +
 vcl/source/app/svapp.cxx   |   34 
++
 2 files changed, 13 insertions(+), 27 deletions(-)

New commits:
commit e1c59fd539222973410dc6adcb8eac4abeeb9e6a
Author: Ilmari Lauhakangas 
AuthorDate: Tue Apr 23 14:02:00 2024 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Thu Apr 25 11:01:17 2024 +0200

Improve documentation on reserved shortcuts

Ctrl+F1 can be dropped from the reserved ones. It used to point to Context
help, but at some point the shortcuts were switched around.

Ctrl+Shift+F6 used to have references "activate splitter" and
SV_SHORTCUT_SPLITTER, but it is not clear what this means. Related to
vcl/source/window/split.cxx perhaps? One guess is that this is related to
StarOffice's Window - Tile feature:

https://www.oreilly.com/library/view/starofficetm-52-calc/013029389X/013029389X_ch02lev1sec8.html

The Ctrl+Shift+F6 shortcut doesn't seem to do anything, so let's drop it
from the reserved ones.

Remove Unix-specific shortcuts Ctrl+Shift+1 through 0, Ctrl+Shift+Plus 
added in
2003 without explanation in commit 2f382d6c2579a25c68dbd121af7f1f5dc7ec9852

Ctrl+Shift+E is no longer used by IBus:
https://github.com/ibus/ibus/commit/b952d30a1b7c741052c168fe1081ecb4d4b1c034
https://github.com/ibus/ibus/commit/1520c39d0d6036da725fcecd932883be3f3d3575

Change-Id: I19766c85871a56c4ba3cebc56e29c99e1f9a8f4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166530
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 
Tested-by: Jenkins

diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu 
b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
index 56eb20da6bd3..73419dee1102 100644
--- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
@@ -16,9 +16,11 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  -->
-
 
 http://openoffice.org/2001/registry; 
xmlns:xs="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:install="http://openoffice.org/2004/installation; oor:name="Accelerators" 
oor:package="org.openoffice.Office">
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 72f6afcb3b01..21de9dfc0f16 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -98,31 +98,15 @@ void InitSettings(ImplSVData* pSVData);
 // keycodes handled internally by VCL
 vcl::KeyCode const ReservedKeys[]
 {
-vcl::KeyCode(KEY_F1,0)  ,
-vcl::KeyCode(KEY_F1,KEY_SHIFT)  ,
-vcl::KeyCode(KEY_F1,KEY_MOD1)   ,
-vcl::KeyCode(KEY_F2,KEY_SHIFT)  ,
-vcl::KeyCode(KEY_F4,KEY_MOD1)   ,
-vcl::KeyCode(KEY_F4,KEY_MOD2)   ,
-vcl::KeyCode(KEY_F6,0)  ,
-vcl::KeyCode(KEY_F6,KEY_MOD1)   ,
-vcl::KeyCode(KEY_F6,KEY_SHIFT)  ,
-vcl::KeyCode(KEY_F6,KEY_MOD1|KEY_SHIFT) ,
-vcl::KeyCode(KEY_F10,0)
-#ifdef UNX
-,
-vcl::KeyCode(KEY_1,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_2,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_3,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_4,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_5,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_6,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_7,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_8,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_9,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_0,KEY_SHIFT|KEY_MOD1),
-vcl::KeyCode(KEY_ADD,KEY_SHIFT|KEY_MOD1)
-#endif
+vcl::KeyCode(KEY_F1,0)  , // Help
+vcl::KeyCode(KEY_F1,KEY_SHIFT)  , // Context help
+vcl::KeyCode(KEY_F2,KEY_SHIFT)  , // Activate extended 
tooltips
+vcl::KeyCode(KEY_F4,KEY_MOD1)   , // Close document
+vcl::KeyCode(KEY_F4,KEY_MOD2)   , // Close document
+vcl::KeyCode(KEY_F6,0)  , // Set focus to next 
visible subwindow
+vcl::KeyCode(KEY_F6,KEY_MOD1)   , // Set focus to the 
document canvas/data source
+vcl::KeyCode(KEY_F6,KEY_SHIFT)  , // Set focus to 
previous subwindow
+vcl::KeyCode(KEY_F10,0)   // Activate the 
first menu
 };
 
 extern "C" {

core.git: vcl/source

[Ilmari Lauhakangas (via logerrit)]

 vcl/source/window/split.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 7d13e62c3d468bd249db62cfdde14f28f74b3f59
Author: Ilmari Lauhakangas 
AuthorDate: Tue Apr 23 19:39:12 2024 +0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Apr 23 20:30:46 2024 +0200

tdf#39468 Translate German comments in vcl

Change-Id: I783d924bffddb637eac1a3d89f4ee956955e0044
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166558
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Jenkins

diff --git a/vcl/source/window/split.cxx b/vcl/source/window/split.cxx
index df631b270bbf..d25e2b677e36 100644
--- a/vcl/source/window/split.cxx
+++ b/vcl/source/window/split.cxx
@@ -460,10 +460,10 @@ void Splitter::StartDrag()
 
 StartSplit();
 
-// Tracking starten
+// Start tracking
 StartTracking();
 
-// Start-Position ermitteln
+// Determine start position
 maDragPos = mpRefWin->GetPointerPosPixel();
 ImplSplitMousePos( maDragPos );
 if ( mbHorzSplit )

Live streaming LibreOffice bug triaging (week 17)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Wed, 24 April 2024 at 15:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

Re: Fix 165948

[Ilmari Lauhakangas]

On 15.4.2024 10.41, Pierre Vacher wrote:

Hi all,

I need your help.I would like cherry pick tdf#156471 
 to 7.6.7


So I created Fix#165948 
, however there are only 
a few days left to validate it.


Thank you if you can validate it.


Julien already gave an explanation in his comment 47 in January. I see 
Mike and Lionel also commented on it in the cherry pick patch. No 
features / enhancements should be pushed to minor releases.


Ilmari

dev-tools.git: scripts/regression-hotspots.py

[Ilmari Lauhakangas (via logerrit)]

 scripts/regression-hotspots.py |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit e4c3bf95610bf2995326c0a7a3a2f2a2e9b75c1e
Author: Ilmari Lauhakangas 
AuthorDate: Fri Apr 12 18:19:53 2024 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Fri Apr 12 17:20:35 2024 +0200

regression-hotspots: don't print counts below 10

Change-Id: Ic6b52077bd6a343461aba35640498de1422a18ed
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/166036
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/scripts/regression-hotspots.py b/scripts/regression-hotspots.py
index 150cb9bd..5cca55f8 100755
--- a/scripts/regression-hotspots.py
+++ b/scripts/regression-hotspots.py
@@ -52,7 +52,9 @@ def print_counts(counts):
 # wiki page uses a widget to clamp the output while offering a button to 
expand
 print('')
 for count in printorder:
-print('%5d %s' % (count[0], count[1]))
+# we are mainly interested in the hottest spots, so skip counts below 
10
+if count[0] >= 10:
+print('%5d %s' % (count[0], count[1]))
 print('')
 
 if __name__ == '__main__':

dev-tools.git: scripts/regression-hotspots.py

[Ilmari Lauhakangas (via logerrit)]

 scripts/regression-hotspots.py |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 9a568801c8d78b4d3faced5afc89fbb2bfd1a21a
Author: Ilmari Lauhakangas 
AuthorDate: Fri Apr 12 13:03:19 2024 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Fri Apr 12 12:04:23 2024 +0200

regression-hotspots: allow tdf1234 style IDs, exclude some components

Change-Id: Id7ab2bd48a3fa1047798d28e102c1d8059eadd17
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/166030
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/scripts/regression-hotspots.py b/scripts/regression-hotspots.py
index 27a684fe..150cb9bd 100755
--- a/scripts/regression-hotspots.py
+++ b/scripts/regression-hotspots.py
@@ -19,7 +19,7 @@ from urllib.request import urlopen, URLError
 from io import BytesIO
 
 def get_fixed_regression_bugs():
-url = 
'https://bugs.documentfoundation.org/buglist.cgi?columnlist==regression%2C%20_type=allwords=0=LibreOffice=FIXED=csv=0'
+url = 
'https://bugs.documentfoundation.org/buglist.cgi?f1=component=component=component=component=component=1=1=1=1=1=equals=equals=equals=equals=equals=ci-infra=deletionRequest=FirefoxOS%20app=SI-GUI=WWW==regression%2C%20_type=allwords=0=LibreOffice=FIXED=csv=0'
 
 ctx = ssl.create_default_context()
 ctx.check_hostname = False
@@ -63,14 +63,15 @@ if __name__ == '__main__':
 
 # build a dictionary of hashes and bug IDs from all commits targeting a 
report in FDO/TDF Bugzilla
 # (first commit with fdo# aka freedesktop.org is from 1 Oct 2010)
+# sometimes people accidentally leave out the #, so take that into account 
in the regexes
 gitbugs = {}
-buglog = git.Git('.').execute(['git', 'log', '--grep=(fdo|tdf)#', '-E', 
'--oneline', '--since=1.10.2010'])
+buglog = git.Git('.').execute(['git', 'log', '--grep=(fdo|tdf)#*', '-E', 
'--oneline', '--since=1.10.2010'])
 if buglog:
 for line in buglog.split('
'):
 githash = line.partition(' ')[0]
 # the regex search will ignore any commits hit by the grep where 
fdo|tdf# occurred below
 # the first line - this is desirable as the referred bug ID should 
appear in the subject line
-bugid = re.search(r"(?:fdo|tdf)#([0-9]+)", line)
+bugid = re.search(r"(?:fdo|tdf)#*([0-9]+)", line)
 if bugid:
 gitbugs[githash] = int(bugid.group(1))
 

dev-tools.git: scripts/regression-hotspots.py

[Ilmari Lauhakangas (via logerrit)]

 scripts/regression-hotspots.py |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 1e0969a8c1ac9c0cb0a1b30f3de73a11583f20d9
Author: Ilmari Lauhakangas 
AuthorDate: Fri Apr 12 10:11:14 2024 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Fri Apr 12 09:13:30 2024 +0200

regression-hotspots: improve output, exclusions, comments and names

Change-Id: If548e67b7f39b24ccfc78c5d76d18f8fdc90fd80
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/166021
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/scripts/regression-hotspots.py b/scripts/regression-hotspots.py
index 8a4fb76d..27a684fe 100755
--- a/scripts/regression-hotspots.py
+++ b/scripts/regression-hotspots.py
@@ -8,7 +8,7 @@
 #
 # Uses https://github.com/gitpython-developers/GitPython
 # Results published in 
https://wiki.documentfoundation.org/Development/RegressionHotspots
-# Run in LibreOffice core directory. Shouldn't take more than a minute.
+# Run in LibreOffice core directory directing output to a text file. Shouldn't 
take more than a minute.
 
 import sys
 import re
@@ -49,16 +49,20 @@ def get_dir_counts(file_counts, level):
 
 def print_counts(counts):
 printorder = reversed(sorted((count, name) for (name, count) in 
counts.items()))
+# wiki page uses a widget to clamp the output while offering a button to 
expand
+print('')
 for count in printorder:
 print('%5d %s' % (count[0], count[1]))
+print('')
 
 if __name__ == '__main__':
 file_counts = {}
-excluderegex = 
re.compile(r'qa/|icon-themes/|extras/source/gallery/|extras/source/palettes/|extras/source/templates/|extras/source/truetype/|helpcontent2|dictionaries|translations|download\.lst|\.png|\.patch')
+excluderegex = 
re.compile(r'qa/|qadevOOo/|icon-themes/|extras/source/gallery/|extras/source/palettes/|extras/source/templates/|extras/source/truetype/|\.git-hooks|helpcontent2|dictionaries|translations|download\.lst|\.png|\.patch')
 fixed_regression_ids = get_fixed_regression_bugs()
 sys.stderr.write('found %d fixed regressions: %s
' % (len(fixed_regression_ids), fixed_regression_ids))
 
 # build a dictionary of hashes and bug IDs from all commits targeting a 
report in FDO/TDF Bugzilla
+# (first commit with fdo# aka freedesktop.org is from 1 Oct 2010)
 gitbugs = {}
 buglog = git.Git('.').execute(['git', 'log', '--grep=(fdo|tdf)#', '-E', 
'--oneline', '--since=1.10.2010'])
 if buglog:
@@ -70,10 +74,10 @@ if __name__ == '__main__':
 if bugid:
 gitbugs[githash] = int(bugid.group(1))
 
-# filter by the bug IDs we got from the Bugzilla query
-regression_hashes = [key for key, value in gitbugs.items() if value in 
fixed_regression_ids]
+# create a list of bug fix hashes by filtering with the bug IDs we got 
from the Bugzilla query
+fix_hashes = [key for key, value in gitbugs.items() if value in 
fixed_regression_ids]
 
-for githash in regression_hashes:
+for githash in fix_hashes:
 lognames = git.Git('.').execute(['git', 'show', githash, 
'--pretty=tformat:', '--name-only'])
 if lognames:
 for filename in lognames.split('
'):

dev-tools.git: scripts/regression-hotspots.py

[Ilmari Lauhakangas (via logerrit)]

 scripts/regression-hotspots.py |   23 +++
 1 file changed, 19 insertions(+), 4 deletions(-)

New commits:
commit a0176ee710a845567fff9c61608bd2393160c895
Author: Ilmari Lauhakangas 
AuthorDate: Thu Apr 11 22:50:48 2024 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Thu Apr 11 21:59:57 2024 +0200

regression-hotspots: optimise by running git log only once instead of

eight thousand times. Takes running time from 10 hours to 30 seconds for me.
Also more accurate results as previously the bug tracker ID in the commit
message was accepted even when only appearing after the first line.

Change-Id: I75f77eb0e3f5c884f35d639608752225f5085c4c
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/166014
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/scripts/regression-hotspots.py b/scripts/regression-hotspots.py
index 6ea80ba6..8a4fb76d 100755
--- a/scripts/regression-hotspots.py
+++ b/scripts/regression-hotspots.py
@@ -8,6 +8,7 @@
 #
 # Uses https://github.com/gitpython-developers/GitPython
 # Results published in 
https://wiki.documentfoundation.org/Development/RegressionHotspots
+# Run in LibreOffice core directory. Shouldn't take more than a minute.
 
 import sys
 import re
@@ -18,7 +19,7 @@ from urllib.request import urlopen, URLError
 from io import BytesIO
 
 def get_fixed_regression_bugs():
-url = 
'https://bugs.documentfoundation.org/buglist.cgi?bug_status=UNCONFIRMED_status=NEW_status=ASSIGNED_status=REOPENED_status=RESOLVED_status=VERIFIED_status=CLOSED_status=NEEDINFO_status=PLEASETEST==regression%2C%20_type=allwords=0_id=354018=LibreOffice_format=advanced=FIXED=csv=0'
+url = 
'https://bugs.documentfoundation.org/buglist.cgi?columnlist==regression%2C%20_type=allwords=0=LibreOffice=FIXED=csv=0'
 
 ctx = ssl.create_default_context()
 ctx.check_hostname = False
@@ -57,9 +58,23 @@ if __name__ == '__main__':
 fixed_regression_ids = get_fixed_regression_bugs()
 sys.stderr.write('found %d fixed regressions: %s
' % (len(fixed_regression_ids), fixed_regression_ids))
 
-for bug_id in fixed_regression_ids:
-sys.stderr.write('working on bug %d
' % bug_id)
-lognames = git.Git('.').execute(['git', 'log', 
'--grep=[fdo|tdf]#'+str(bug_id), '--pretty=tformat:', '--name-only'])
+# build a dictionary of hashes and bug IDs from all commits targeting a 
report in FDO/TDF Bugzilla
+gitbugs = {}
+buglog = git.Git('.').execute(['git', 'log', '--grep=(fdo|tdf)#', '-E', 
'--oneline', '--since=1.10.2010'])
+if buglog:
+for line in buglog.split('
'):
+githash = line.partition(' ')[0]
+# the regex search will ignore any commits hit by the grep where 
fdo|tdf# occurred below
+# the first line - this is desirable as the referred bug ID should 
appear in the subject line
+bugid = re.search(r"(?:fdo|tdf)#([0-9]+)", line)
+if bugid:
+gitbugs[githash] = int(bugid.group(1))
+
+# filter by the bug IDs we got from the Bugzilla query
+regression_hashes = [key for key, value in gitbugs.items() if value in 
fixed_regression_ids]
+
+for githash in regression_hashes:
+lognames = git.Git('.').execute(['git', 'show', githash, 
'--pretty=tformat:', '--name-only'])
 if lognames:
 for filename in lognames.split('
'):
 if not excluderegex.search(filename):

Re: Ynt: Unsubscribe from the Mailing List

[Ilmari Lauhakangas]

On 30.3.2024 19.56, alper akyol wrote:
I'm sorry to bother everyone. I'm still getting emails. How can I 
unsubscribe from the mailing list?


Read the instructions on 
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Ilmari

Cygwin build fails with /usr/bin/sh: line 1: /usr/bin/mkdir: Bad address

[Ilmari Lauhakangas]

A new developer is facing this issue:

$ make check 2>&1 | tee build.log
C:/cygwin64/home/user/lode/opt/bin/make -j 12  -rs -f 
C:/cygwin64/home/user/lode/dev/core/Makefile.gbuild  unitcheck slowcheck 
subsequentcheck  check

/usr/bin/sh: line 1: /usr/bin/mkdir: Bad address
[build XCD] main
make[1]: *** 
[C:/cygwin64/home/user/lode/dev/core/canvas/Library_vclcanvas.mk:27: 
C:/cygwin64/home/user/lode/dev/core/workdir/PrecompiledHeader/debug/precompiled_vclcanvas.hxx.pch.flags] 
Error -1073741819
make[1]: *** Deleting file 
'C:/cygwin64/home/user/lode/dev/core/workdir/PrecompiledHeader/debug/precompiled_vclcanvas.hxx.pch.flags'

make[1]: *** Waiting for unfinished jobs
make: *** [Makefile:290: build] Error 2

Does it sound familiar to anyone? I couldn't find anything useful 
related to it.


Ilmari

Proper way to solve known problem ".NET exception occurred: System.IO.IOException: Access is denied"

[Ilmari Lauhakangas]

A new developer hit this known problem 
https://wiki.documentfoundation.org/Development/BuildingOnWindows#.NET_exception_occurred:_System.IO.IOException:_Access_is_denied


Permissions for the C:\ProgramData\Microsoft\Crypto were changed as 
evidenced by this screenshot: https://pasteboard.co/cjAj4V1PoRFw.png


Checking in PowerShell with

cd C:\ProgramData\Microsoft\Crypto
Get-Acl | fl

this is the output:

Path   : 
Microsoft.PowerShell.Core\FileSystem::C:\ProgramData\Microsoft\Crypto

Owner  : NT AUTHORITY\SYSTEM
Group  : NT AUTHORITY\SYSTEM
Access : BUILTIN\Users Allow  Modify, Synchronize
 NT AUTHORITY\SYSTEM Allow  FullControl
 BUILTIN\Administrators Allow  FullControl
 BUILTIN\Users Allow  ReadAndExecute, Synchronize
 Everyone Allow  ReadAndExecute, Synchronize
Audit  :
Sddl   : 
O:SYG:SYD:AI(A;OICI;0x1301bf;;;BU)(A;OICIID;FA;;;SY)(A;OICIID;FA;;;BA)(A;OICIID;0x1200a9;;;BU)(A;OICIID;0x1200a9;;;WD)


Yet the error kept appearing. Any ideas?

Ilmari

Re: autosave errors

[Ilmari Lauhakangas]

On 22.3.2024 4.25, jax...@kabelmail.dk wrote:
When LibreOfficeWriter makes an automatic back-up save ... the text you 
write while this is happening, is lost. For most users, this might be a 
small problem, but when you, like me, work with rather large files and 
write relatively quickly, sometimes whole words end up missing that way 
... and I have to be extra careful reading afterwards to find these 
'holes' in the text.


Other word processing systems I have used so far have a buffer function, 
where the text that is written during auto-save is saved and then when 
the auto-save is over, inserted in the right place. I would think such a 
feature would be a great improvement for Libre.


Unfortunately, I don't know enough programming to fix the problem 
myself... but I saw a while ago that you asked for user feedback, so 
this is my contribution.


For anyone interested, the report for this is 
https://bugs.documentfoundation.org/show_bug.cgi?id=48416


Ilmari

Re: Official support for windows-arm64

[Ilmari Lauhakangas]

On 16.3.2024 17.41, Sophia Schröder wrote:

Hi all,

Just a side note from a community member:

I don't know how much the hassle and the costs are,
but LibreOffice wants to switch to Cmake anyway.
(I saw Cmake mentioned at Linaro's webpage).


There has been quite a lot of work toward building LibreOffice with 
Meson. There has not been discussion about investing time into building 
with CMake.


Ilmari

Re: NEWBIE 1 Where can I find the sourcecode for the asian phonetic guide? 2 Where can I find the sourcecode for specific language packs?

[Ilmari Lauhakangas]

On 6.3.2024 4.47, Kevin Suo wrote:

在 2024/3/6 04:04, Ben Engbers 写道:

3
And since I also often create texts in French, German and Japanese, I 
guess that I also have to install those langpacks.


Where in the developerssite can I find all the needed materials and 
instructions?
Langpacks are actually sub-modules in LibreOffice source code. The repo 
is in:

https://git.libreoffice.org/translations
The translation work is done on Weblate:
https://translation.documentfoundation.org/languages/zh_hans/


The translations repository will be automatically cloned as a submodule, 
if you add to your autogen.input


--with-lang=nl fr de ja

More about working with submodules:
https://wiki.documentfoundation.org/Development/Submodules

Ilmari

Live streaming LibreOffice bug triaging (week 10)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Tue, 5 March 2024 at 18:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

Re: Hoping to be part of GSoC 2024

[Ilmari Lauhakangas]

On 4.3.2024 5.08, Jonah Janzen wrote:
Hi there! My name is Jonah, and I'm a Canadian engineering student. I 
recently found out about Google Summer of Code, and after doing some 
more reading about it, it seems like a wonderful opportunity that I 
would love to be a part of. As a longtime user of LibreOffice, it's high 
on my list of organizations I want to give back to, and hence I'm 
reaching out to you today to start a conversation about doing so.
I've been programming since I was 8 doing everything from amateur 
gamedev to competitive programming. This past year, I worked as a web 
developer building a full-stack application with C#/Blazor, and I've 
also made occasional contributions to FOSS like Godot and LMMS.


There are a couple of ideas that I would be most interested in working 
on, which I'll list below:

_UNO Rust Bindings
_
I have vague familiarity with the Rust language and the ideas behind it, 
but I have little hands-on experience with it.
My initial thoughts about this idea are that it would almost certainly 
involve the use of the CXX.RS  utility, and that I would 
hope to be able to auto-generate as much of the code as possible, by 
using the public API specification.
I have a strong desire to get more familiar with Rust, and I love 
working on low-level backend stuff so this would probably be my top choice.


_Forgejo Migration (my own idea)_
 From the perspective of a newcomer to the project, between Gitiles, 
Gerrit, Bugzilla, Jenkins, etc., the different parts of LibreOffice 
development feel disjointed and initially challenging to grasp. I 
sincerely don't mean to cause offense, and I don't come across as 
abrasive rather than reflective.
What I would propose is to move the LibreOffice repository, issue 
tracker, code review process, and CI all onto the Forgejo platform. This 
would offer a more centralized experience for all aspects of project 
management that I think would make core developers' lives much easier, 
and provide another, more superficial benefit: young (and occasionally 
foolish) individuals like myself are used to the GitHub style of Git 
server, and things like Gitiles tend to feel outdated and 
unapproachable. Forgejo would provide a more familiar UX that would ease 
the process of onboarding new contributors.
Gitea is another possibility, because it seems to be more active and 
it's used by high-profile projects like Blender, although it's owned by 
a for-profit now. I've also heard about OneDev, but don't know as much 
about it.


Since this is my own idea, there are a couple potential challenges I'm 
not sure about that I'd appreciate input on:
- This would require transferring account data, and I understand that 
you might not be willing to entrust me with the power to access that.
- I would like for my GSoC project to be 350 hours, and I don't have an 
estimate for how long this would take. I guess we could tack on other 
stuff under the migration umbrella as well, like a shift from IRC to 
Matrix, for example.


_LibreOffice Theme_
Although I'm personally not as interested in this idea, it seems like it 
would offer a significant leap forward in LibreOffice's UI capabilities, 
and might make the software more appealing to a lot of people. If you 
think this would do the most good for the project overall, then I'd be 
glad to take it on for that reason. I would want to consider what the 
best way to store custom styles is (CSS? XML? and so on), and how this 
can be integrated as tightly as possible with the way Mozilla themes are 
used, so that the new setup can do all the same things.


-
I would really appreciate feedback on what you think the best of those 
ideas (or any others) might be for me to work on. I would also be 
curious to know how much interest from other GSoC applicants you have 
had thus far, and whether I would have a significant chance of being 
accepted if I actually were to work on a proposal. If the answer to that 
is yes, then I will start working on an easy hack as soon as possible, 
and collaborating with potential mentors to shape my proposal.


Thank you so much, and I hope to work with you soon!


I have invited you to an interview.

Ilmari

Re: Enquiry Regarding GSoC 2024 Participation: Potential Collaboration Opportunity

[Ilmari Lauhakangas]

On 27.2.2024 15.24, Akshay Kumar Dubey wrote:

Hello,

I hope this email finds you well. I am writing to express my keen 
interest in contributing to Google Summer of Code (GSoC) 2024 with this 
esteemed organization. I am enthusiastic about the opportunity to 
collaborate and contribute to meaningful projects aligned with your 
mission. I look forward to the possibility of working together.


i assure you that I will be passionate about the tasks given to me.

I would greatly appreciate any suggestions or guidance on how I can best 
align my skills and interests with your projects.


I have invited you to an interview.

Ilmari

Live streaming LibreOffice bug triaging (week 9)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Wed, 28 February 2024 at 16:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

core.git: Branch 'libreoffice-24-2-1' - officecfg/registry reportbuilder/registry

[Ilmari Lauhakangas (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/Accelerators.xcu | 2720 
+-
 reportbuilder/registry/data/org/openoffice/Office/Accelerators.xcu |   34 
 2 files changed, 1377 insertions(+), 1377 deletions(-)

New commits:
commit 8d52be7d87c3be4a4792a0fab36835a8a2680e59
Author: Ilmari Lauhakangas 
AuthorDate: Wed Dec 13 21:24:28 2023 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Feb 23 18:23:37 2024 +0100

Fix typo: I10N -> L10N

Change-Id: I20a0eb54a85a9dea5c7d4cd91ff3632574b14802
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160714
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Jenkins
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163481
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163808
Tested-by: Adolfo Jayme Barrientos 

diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu 
b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
index b6178a1d9f70..2265ec7c436a 100644
--- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
@@ -26,44 +26,44 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some 
emoji thing
 
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SelectAll
   .uno:Open
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   vnd.sun.star.findbar:FocusToFindbar
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SearchDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:Copy
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ZoomMinus
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ZoomPlus
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:InsertAnnotation
   
   
@@ -72,207 +72,207 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some 
emoji thing
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:InsertAnnotation
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:EditDoc
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SpellOnline
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:HyperlinkDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:Delete
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SelectAll
   .uno:CommonAlignHorizontalCenter
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:MacroDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ViewDataSourceBrowser
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ToggleControlFocus
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:HangulHanjaConversion
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   vnd.sun.star.findbar:FocusToFindbar
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SearchDialog
   .uno:SearchDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SearchDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:Save
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:CommonAlignJustified
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSL

Live streaming LibreOffice bug triaging (week 8)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Thu, 22 February 2024 at 14:00 UTC
Fri, 23 February 2024 at 13:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

Guidelines for LibreOffice release notes published

[Ilmari Lauhakangas]

Based on ideas from Ady and Stéphane, I wrote a meta level page about 
release notes: https://wiki.documentfoundation.org/ReleaseNotes/Guidelines


Ilmari

core.git: Branch 'libreoffice-24-2' - officecfg/registry reportbuilder/registry

[Ilmari Lauhakangas (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/Accelerators.xcu | 2720 
+-
 reportbuilder/registry/data/org/openoffice/Office/Accelerators.xcu |   34 
 2 files changed, 1377 insertions(+), 1377 deletions(-)

New commits:
commit 684729cbd565129cdc6d3be09a864551fc6908c6
Author: Ilmari Lauhakangas 
AuthorDate: Wed Dec 13 21:24:28 2023 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Fri Feb 16 13:36:48 2024 +0100

Fix typo: I10N -> L10N

Change-Id: I20a0eb54a85a9dea5c7d4cd91ff3632574b14802
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160714
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Jenkins
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163481
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu 
b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
index b6178a1d9f70..2265ec7c436a 100644
--- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
@@ -26,44 +26,44 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some 
emoji thing
 
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SelectAll
   .uno:Open
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   vnd.sun.star.findbar:FocusToFindbar
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SearchDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:Copy
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ZoomMinus
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ZoomPlus
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:InsertAnnotation
   
   
@@ -72,207 +72,207 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some 
emoji thing
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:InsertAnnotation
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:EditDoc
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SpellOnline
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:HyperlinkDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:Delete
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SelectAll
   .uno:CommonAlignHorizontalCenter
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:MacroDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ViewDataSourceBrowser
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ToggleControlFocus
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:HangulHanjaConversion
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   vnd.sun.star.findbar:FocusToFindbar
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SearchDialog
   .uno:SearchDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SearchDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:Save
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:CommonAlignJustified
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:CommonAlignLeft
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTC

core.git: xmloff/qa

[Ilmari Lauhakangas (via logerrit)]

 xmloff/qa/unit/style.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 9798f383f82897b0021665f50f3a9f8153febbe8
Author: Ilmari Lauhakangas 
AuthorDate: Tue Feb 13 14:41:13 2024 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Wed Feb 14 08:22:29 2024 +0100

tdf#141908 replace usage of sal_Int32 with colors in xmloff

Change-Id: Ia2661fa0f6864d6553e5cca7469e1d351bb06d17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163305
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/xmloff/qa/unit/style.cxx b/xmloff/qa/unit/style.cxx
index 178b0f216154..3bf1391d842a 100644
--- a/xmloff/qa/unit/style.cxx
+++ b/xmloff/qa/unit/style.cxx
@@ -371,8 +371,8 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest, testMCGR_OldToNew)
 CPPUNIT_ASSERT_EQUAL(u"red2yellow"_ustr, sGradientName);
 awt::Gradient2 aGradient;
 xShapeProperties->getPropertyValue("FillGradient") >>= aGradient;
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xFF), aGradient.StartColor);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00), aGradient.EndColor);
+CPPUNIT_ASSERT_EQUAL(COL_LIGHTRED, Color(ColorTransparency, 
aGradient.StartColor));
+CPPUNIT_ASSERT_EQUAL(COL_YELLOW, Color(ColorTransparency, 
aGradient.EndColor));
 
 // Test new properties
 auto aColorStopSeq = aGradient.ColorStops;
@@ -427,8 +427,8 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest, 
testMCGR_OldToNew_opacity)
 // The old properties need to be still available, as they might be used in 
macros.
 awt::Gradient2 aGradient;
 xShapeProperties->getPropertyValue("FillTransparenceGradient") >>= 
aGradient;
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xE5E5E5), aGradient.StartColor);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aGradient.EndColor);
+CPPUNIT_ASSERT_EQUAL(Color(0xE5E5E5), Color(ColorTransparency, 
aGradient.StartColor));
+CPPUNIT_ASSERT_EQUAL(COL_BLACK, Color(ColorTransparency, 
aGradient.EndColor));
 CPPUNIT_ASSERT_EQUAL(sal_Int16(20), aGradient.Border);
 CPPUNIT_ASSERT_EQUAL(sal_Int16(50), aGradient.XOffset);
 CPPUNIT_ASSERT_EQUAL(sal_Int16(50), aGradient.YOffset);
@@ -493,8 +493,8 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest, testMCGR_threeStops)
 CPPUNIT_ASSERT_EQUAL(u"threeStops"_ustr, sGradientName);
 awt::Gradient2 aGradient;
 xShapeProperties->getPropertyValue("FillGradient") >>= aGradient;
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xFF), aGradient.StartColor);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00), aGradient.EndColor);
+CPPUNIT_ASSERT_EQUAL(COL_LIGHTRED, Color(ColorTransparency, 
aGradient.StartColor));
+CPPUNIT_ASSERT_EQUAL(COL_YELLOW, Color(ColorTransparency, 
aGradient.EndColor));
 CPPUNIT_ASSERT_EQUAL(awt::GradientStyle_SQUARE, aGradient.Style);
 CPPUNIT_ASSERT_EQUAL(sal_Int16(0), aGradient.XOffset);
 CPPUNIT_ASSERT_EQUAL(sal_Int16(50), aGradient.YOffset);

Re: Live streaming LibreOffice bug triaging (week 7)

[Ilmari Lauhakangas]

On 12.2.2024 22.38, Ilmari Lauhakangas wrote:
I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Wed, 14 February 2024 at 14:00 UTC
Thu, 15 February 2024 at 13:00 UTC
Fri, 16 February 2024 at 14:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Should have titled it week 7...

Ilmari

Live streaming LibreOffice bug triaging (week 6)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Wed, 14 February 2024 at 14:00 UTC
Thu, 15 February 2024 at 13:00 UTC
Fri, 16 February 2024 at 14:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

Re: Latest (2024) Afrikaans Hunspell

[Ilmari Lauhakangas]

On 12.2.2024 4.43, kris wrote:

Every few years I submit an update to the spellchecker: Hunspell files for 
Afrikaans.

I have created an improved Afrikaans Hunspell af_ZA.aff and af_ZA.dic files in 
attached zip file.

It would be appreciated if someone could submit the af_ZA updates on my behalf.

I once tried to register on gerrit, but could never get the authentication to 
work.


If you can log into https://user.documentfoundation.org/ and can see 
Gerrit there, it means you have an account. An authentication problem 
can be related to cookies, so you might try clearing them in your 
browser for documentfoundation.org


If all else fails, you can email hostmas...@documentfoundation.org

More about the login system: 
https://wiki.documentfoundation.org/Infra/SingleSignOn


Ilmari

Re: stuck at building code. Please suggest what to try next.

[Ilmari Lauhakangas]

On 6.2.2024 9.45, Ajay Dhar wrote:

I am trying to start developing libreoffice.
I tried to


  configure and build the code

I gave the following command in cygbin
...
c:/sources/libo-core/autogen.sh \
  --with-external-tar=c:/sources/lo-externalsrc \
  --with-junit=c:/sources/junit-4.10.jar \
  --with-ant-home=c:/sources/apache-ant-1.9.5 \
  --enable-pch --disable-ccache \
  --disable-ccache \
  --with-jdk-home
...
I got the following error.

Error running configure at c:/sources/libo-core/autogen.sh line 321.
configure: error: No JDK found, pass the --with-jdk-home option (or fix 
the path) pointing to a 64-bit JDK >= 17

.
Now I am stuck. Please suggest something.
My Java is at following, I think
...
C:\Program Files\Microsoft\jdk-11.0.21.9-hotspot\bin
.


You have not defined a path for --with-jdk-home. It is explained here: 
https://wiki.documentfoundation.org/Development/BuildingOnWindows#Install_Java


I notice that you seem to be following the instructions on the Windows 
article that go beyond the point that says:


"The Easiest way to perform the following is to use LODE , which 
automates all that is necessary, beyond installing Visual Studio and Java.


If you want to do it the hard way, continue reading."

It would be good to use an autogen.input as I advised you.

Also, Miklos has a point about JDK version in his email.

Ilmari

Re: Attention Windows developers: do not upgrade Cygwin to version 3.5.0

[Ilmari Lauhakangas]

On 6.2.2024 13.30, Ilmari Lauhakangas wrote:
Unfortunately Cygwin 3.5.0 has a change that causes LibreOffice builds 
to fail with messages like this:


321 [main] sh 1280 dofork: child 1288 - died waiting for dll loading, 
errno 11


Please hold off on upgrading to Cygwin 3.5.0.

If you have already installed Cygwin 3.5.0, run the Cygwin installer 
again. In the screen "Select Packages", change the version of the cygwin 
package from 3.5.0 to 3.4.10 and finish the installation.


At this moment, the root cause of this problem is not known.

Another important note about 3.5.0 is found on Cygwin's home page: 
"Cygwin 3.4.10 was the last Cygwin version supporting Windows 7, Windows 
8, Windows Server 2008 R2 and Windows Server 2012."


Now there are some indications that the issue might only affect Windows 
11 while building works on Win 10. More anecdotes are welcome.


Ilmari

Attention Windows developers: do not upgrade Cygwin to version 3.5.0

[Ilmari Lauhakangas]

Unfortunately Cygwin 3.5.0 has a change that causes LibreOffice builds 
to fail with messages like this:


321 [main] sh 1280 dofork: child 1288 - died waiting for dll loading, 
errno 11


Please hold off on upgrading to Cygwin 3.5.0.

If you have already installed Cygwin 3.5.0, run the Cygwin installer 
again. In the screen "Select Packages", change the version of the cygwin 
package from 3.5.0 to 3.4.10 and finish the installation.


At this moment, the root cause of this problem is not known.

Another important note about 3.5.0 is found on Cygwin's home page: 
"Cygwin 3.4.10 was the last Cygwin version supporting Windows 7, Windows 
8, Windows Server 2008 R2 and Windows Server 2012."


Ilmari

Re: Error building on MacOS

[Ilmari Lauhakangas]

On 4.2.2024 15.15, Stanisław Jeśmanowicz wrote:

Hello Adlair,

I had also problems to install LibreOffice on MacOS.
But after many tries and errors, I made it.
Here's how it was:

- My Mac is: MacBook Pro
- chip: Apple M2 Max chip
- macOS: Sonoma 14.2.1

I use  MacPorts base version 2.9.1 for open source software tools.
- run:
   xcode-select -s /Applications/Xcode.app/Contents/Developer

In addition to the packages I use, I also had to install:
- port install gperf
- install java: 
https://download.oracle.com/java/21/latest/jdk-21_macos-aarch64_bin.dmg 
(sha256)

- port install apache-ant
- ~/.zprofile contains:

   export DYLD_LIBRARY_PATH="/opt/local/lib:$DYLD_LIBRARY_PATH"
   export 
DYLD_FALLBACK_LIBRARY_PATH="/opt/local/lib:$DYLD_FALLBACK_LIBRARY_PATH"

   export PATH="/opt/local/bin:$PATH"
   export PATH="/opt/local/sbin:$PATH"
   export PATH="/opt/local/libexec/gnubin:$PATH"
   export PATH="./:$PATH"

- download LibreOffice sources:
   git clone https://github.com/LibreOffice/core.git

- since the sed program is here /opt/local/libexec/gnubin/sed, I had to 
correct two files:

  1.  ./core/editeng/CustomTarget_generated.mk :
#    sed -i $(if $(filter MACOSX,$(OS_FOR_BUILD)),'') -e 
"s/(char\*)0/(char\*)0, XML_TOKEN_INVALID/g" $(editeng_INC)/tokens.cxx
       sed -i -e "s/(char\*)0/(char\*)0, XML_TOKEN_INVALID/g" 
$(editeng_INC)/tokens.cxx
#    sed -i $(if $(filter MACOSX,$(OS_FOR_BUILD)),'') -e "/^#line/d" 
$(editeng_INC)/tokens.cxx

   sed -i -e "/^#line/d" $(editeng_INC)/tokens.cxx
2. ./core/workdir/UnpackedTarball/firebird/gen/make.rules
   sed -i -e "1,2s/:/: \$$(wildcard/" -e "\$$s/\(.*\)/\\1)/" 
$(patsubst %.o,%.d,$@)
#    @sed $(INLINE_EDIT_SED) -e "1,2s/:/: \$$(wildcard/" -e 
"\$$s/\(.*\)/\\1)/" $(patsubst %.o,%.d,$@)

  ( don't forget  before sed, because these are makefiles )

- in directory core I did:
./autogen.sh \
  --prefix=/opt/local \
  --with-macosx-version-min-required=14.0 \
  --enable-bogus-pkg-config \
  --without-fonts \
  --without-junit \
  --disable-sdremote \
  --disable-firebird-sdbc \
  --disable-postgresql-sdbc \

./configure \
  --prefix=/opt/local \
  --with-macosx-version-min-required=14.0 \
  --enable-bogus-pkg-config \
  --without-fonts \
  --without-junit \
  --disable-sdremote \
  --disable-firebird-sdbc \
  --disable-postgresql-sdbc \

( correct your macos's version in --with-macosx-version-min-required )

- and then in core directory do:
   make

It took 25 minutes on my box.


The normal instructions are at 
https://wiki.documentfoundation.org/Development/BuildingOnMac


Note that GitHub is just a mirror and not used for development.

Ilmari

core.git: icon-themes/karasa_jaga_svg

[Ilmari Lauhakangas (via logerrit)]

 icon-themes/karasa_jaga_svg/cmd/32/autopilotmenu.svg|2 +-
 icon-themes/karasa_jaga_svg/cmd/32/dbnewreport.svg  |2 +-
 icon-themes/karasa_jaga_svg/cmd/32/dbnewreportautopilot.svg |2 +-
 icon-themes/karasa_jaga_svg/cmd/32/dbreportdelete.svg   |2 +-
 icon-themes/karasa_jaga_svg/cmd/32/dbreportedit.svg |2 +-
 icon-themes/karasa_jaga_svg/cmd/32/dbreportopen.svg |2 +-
 icon-themes/karasa_jaga_svg/cmd/32/dbreportrename.svg   |2 +-
 icon-themes/karasa_jaga_svg/cmd/32/dbviewreports.svg|2 +-
 icon-themes/karasa_jaga_svg/cmd/32/dsbinsertcolumns.svg |2 +-
 icon-themes/karasa_jaga_svg/cmd/32/dsbinsertcontent.svg |2 +-
 icon-themes/karasa_jaga_svg/cmd/32/executereport.svg|2 +-
 icon-themes/karasa_jaga_svg/cmd/32/reportnavigator.svg  |2 +-
 icon-themes/karasa_jaga_svg/cmd/lc_autopilotmenu.svg|2 +-
 icon-themes/karasa_jaga_svg/cmd/sc_autopilotmenu.svg|2 +-
 icon-themes/karasa_jaga_svg/dbaccess/res/reports_32.svg |2 +-
 icon-themes/karasa_jaga_svg/sd/res/doctext.svg  |2 +-
 16 files changed, 16 insertions(+), 16 deletions(-)

New commits:
commit 3be785e088cc0aa726509cf6b52b1d3b03817172
Author: Ilmari Lauhakangas 
AuthorDate: Sun Jan 28 14:43:36 2024 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sun Jan 28 22:48:55 2024 +0100

tdf#158939 icon-themes/karasa_jaga_svg: simplify some db icons

Remove subtle image mask with very small details.
Saves 1,722,744 bytes.

Change-Id: Iee00918a7baf1f13594636490e7602cc2d505e00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162658
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/karasa_jaga_svg/cmd/32/autopilotmenu.svg 
b/icon-themes/karasa_jaga_svg/cmd/32/autopilotmenu.svg
index ccdcb3cea90a..e955677b8130 100644
--- a/icon-themes/karasa_jaga_svg/cmd/32/autopilotmenu.svg
+++ b/icon-themes/karasa_jaga_svg/cmd/32/autopilotmenu.svg
@@ -1 +1 @@
-e 
... etc. - the rest is truncated

Live streaming LibreOffice bug triaging (week 5)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Mon, 29 January 2024 at 13:00 UTC
Tue, 30 January 2024 at 10:00 UTC
Wed, 31 January 2024 at 12:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

core.git: icon-themes/colibre_dark_svg icon-themes/colibre_svg icon-themes/karasa_jaga_svg icon-themes/sukapura_dark_svg icon-themes/sukapura_svg

[Ilmari Lauhakangas (via logerrit)]

 icon-themes/colibre_dark_svg/vcl/res/pen.svg  |
2 
 icon-themes/colibre_svg/vcl/res/pen.svg   |
2 
 icon-themes/karasa_jaga_svg/sd/res/chart.svg  |
2 
 icon-themes/karasa_jaga_svg/svx/res/pr010.svg |
8 
 icon-themes/karasa_jaga_svg/svx/res/pr05.svg  |
8 
 icon-themes/karasa_jaga_svg/vcl/res/pen.svg   |
6 
 icon-themes/sukapura_dark_svg/chart2/res/donut3d_52x60.svg|
2 
 icon-themes/sukapura_dark_svg/chart2/res/donut3dexploded_52x60.svg|
2 
 icon-themes/sukapura_dark_svg/chart2/res/donut_52x60.svg  |
2 
 icon-themes/sukapura_dark_svg/chart2/res/donutexploded_52x60.svg  |
2 
 icon-themes/sukapura_dark_svg/chart2/res/pie3d_52x60.svg  |   
16 
 icon-themes/sukapura_dark_svg/chart2/res/pie3dexploded_52x60.svg  |   
16 
 icon-themes/sukapura_dark_svg/chart2/res/pie_52x60.svg|   
16 
 icon-themes/sukapura_dark_svg/chart2/res/pieexploded_52x60.svg|   
16 
 icon-themes/sukapura_dark_svg/chart2/res/valueaxisstepped3d_52x60.svg |   
25 
 icon-themes/sukapura_dark_svg/chart2/res/valueaxissteppedboth_52x60.svg   |   
25 
 icon-themes/sukapura_dark_svg/chart2/res/valueaxissteppedlines_52x60.svg  |   
25 
 icon-themes/sukapura_dark_svg/cmd/sc_bmpmask.svg  |
2 
 icon-themes/sukapura_dark_svg/sd/res/presenterscreen-BorderToolbarTop.svg |
2 
 icon-themes/sukapura_dark_svg/svx/res/a11y_check_issues_found.svg | 
3136 --
 icon-themes/sukapura_svg/chart2/res/donut3d_52x60.svg |
2 
 icon-themes/sukapura_svg/chart2/res/donut3dexploded_52x60.svg |
2 
 icon-themes/sukapura_svg/chart2/res/donut_52x60.svg   |
2 
 icon-themes/sukapura_svg/chart2/res/donutexploded_52x60.svg   |
2 
 icon-themes/sukapura_svg/chart2/res/pie3d_52x60.svg   |   
16 
 icon-themes/sukapura_svg/chart2/res/pie3dexploded_52x60.svg   |   
16 
 icon-themes/sukapura_svg/chart2/res/pie_52x60.svg |   
16 
 icon-themes/sukapura_svg/chart2/res/pieexploded_52x60.svg |   
16 
 icon-themes/sukapura_svg/chart2/res/valueaxisstepped3d_52x60.svg  |   
25 
 icon-themes/sukapura_svg/chart2/res/valueaxissteppedboth_52x60.svg|   
25 
 icon-themes/sukapura_svg/chart2/res/valueaxissteppedlines_52x60.svg   |   
25 
 icon-themes/sukapura_svg/cmd/sc_bmpmask.svg   |
2 
 icon-themes/sukapura_svg/sd/res/presenterscreen-BorderToolbarTop.svg  |
2 
 icon-themes/sukapura_svg/svx/res/a11y_check_issues_found.svg  | 
3136 --
 34 files changed, 34 insertions(+), 6568 deletions(-)

New commits:
commit ace5f5cbee7ea2c21ff9a3fe9b859b83a006edd6
Author: Ilmari Lauhakangas 
AuthorDate: Fri Jan 26 18:41:27 2024 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jan 27 20:46:31 2024 +0100

tdf#158939 icon-themes: remove leftover reference images from SVGs

Change-Id: Iccb7eaa0999f351cc365b52b5ce543f177ab00aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162631
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/colibre_dark_svg/vcl/res/pen.svg 
b/icon-themes/colibre_dark_svg/vcl/res/pen.svg
index b94a62aaac5f..7068f03aa614 100644
--- a/icon-themes/colibre_dark_svg/vcl/res/pen.svg
+++ b/icon-themes/colibre_dark_svg/vcl/res/pen.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
+http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
diff --git a/icon-themes/colibre_svg/vcl/res/pen.svg 
b/icon-themes/colibre_svg/vcl/res/pen.svg
index 332b3428f669..b4ee5cc555c9 100644
--- a/icon-themes/colibre_svg/vcl/res/pen.svg
+++ b/icon-themes/colibre_svg/vcl/res/pen.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
\ No newline at end of file
+http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
diff --git a/icon-themes/karasa_jaga_svg/sd/res/chart.svg 
b/icon-themes/karasa_jaga_svg/sd/res/chart.svg
index 574780dba8da..2bced015bcbf 100644
--- a/icon-themes/karasa_jaga_svg/sd/res/chart.svg
+++ b/icon-themes/karasa_jaga_svg/sd/res/chart.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink;>x2="14.287499" xlink:href="#b" y1="288.268737" 
 >y2="293.560387"/>x1="11.641666" x2="11.641666" xlink:href="#b" y1="282.977067" 
 >y2="288.268717"/>x1="8.995833" x2="8.995833" xlink:href="#b" y1="285.6229" 
 >y2=

Live streaming LibreOffice bug triaging (week 4)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Mon, 22 January 2024 at 15:00 UTC
Wed, 24 January 2024 at 15:00 UTC
Thu, 25 January 2024 at 16:00 UTC
Fri, 26 January 2024 at 14:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

Re: Java a11y test not executed

[Ilmari Lauhakangas]

On 18.1.2024 18.52, Martin Gube wrote:


Hi everyone,

I'm quite new to the project and currently converting the following Java
a11y test to C++ (Bugzilla: bug 157003):

sw/qa/complex/indeterminateState/CheckIndeterminateState.java

Now I would like to check the C++ unit test results against the old Java
version. The problem is, that this particular Java unit test is being
compiled, but not executed. workdir/JunitTest/sw_complex/done.log is
generated, but showing "OK (0 tests)". Other Java unit tests do run,
e.g. sc_complex, ridl_bridgefactory and others.

The Makefile for CheckIndeterminateState.java is located here:

sw/JunitTest_sw_complex.mk

Does anyone has a clue for how to execute this unit test? Is there
something wrong with its Makefile?

Thanks a lot for your help! :-)


And to clarify, me and Martin have been trying to run it with

make JunitTest_sw_complex

Ilmari

Live streaming LibreOffice bug triaging (week 3)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Mon, 15 January 2024 at 15:00 UTC
Tue, 16 January 2024 at 17:00 UTC
Wed, 17 January 2024 at 17:00 UTC
Thu, 18 January 2024 at 18:00 UTC
Fri, 19 January 2024 at 17:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

Re: no JDK found

[Ilmari Lauhakangas]

On 14.1.2024 12.16, jh276 wrote:

Am 14.01.24 um 10:28 schrieb drei97:

Why then no autogen.input is created, I don't know


Am 14.01.24 um 08:20 schrieb Ilmari Lauhakangas:

On 13.1.2024 19.24, y27p6e3vu...@web.de wrote:

If you had used the LODE method, an autogen.input file would have been
created. Now you have to create it yourself. More about the file:
https://wiki.documentfoundation.org/Development/GenericBuildingHints#autogen_help


I had used LODE.


the important part is:

 "The Easiest way to perform the following is to use LODE, which
automates all that is necessary, beyond installing Visual Studio and
Java"  ;-)


>
> autogen.sh is now running even with none existing autogen.input.

autogen.input is not required, but it is convenient for keeping your 
build options "saved" and so you can always share them with others.


Ilmari

Re: no JDK found

[Ilmari Lauhakangas]

On 13.1.2024 19.24, y27p6e3vu...@web.de wrote:

Hi,
I am trying to compile LO for the first time on windows and do follow 
the official guide

https://wiki.documentfoundation.org/Development/BuildingOnWindows
Nevertheless I am runnning into several issues while configuring the build.
Running autogen.sh gives errors,
it is not finding C++ build tools (Win 10 SDK), even if Visual Studio is 
available. I have to use the option "--with-visual-studio=2022"
it is not finding JDK, even if it is available. Option 
"--with-jdk-home=/cygdrive/c/jdk-21.0.1/bin" is not solving the issue.
The JDK was downloaded from Microsoft server as 64bit version and the 
PATH is set correctly.
There are hints in the documentation given above for Java installation 
and to eventually modify the "--with-jdk-home" in "autogen.input". There 
is no file "autogen.input"!
What is going wrong? Is the documentaion not up-to-date or do I am 
missing some details?


You have apparently skipped the green note that is under the Cygwin 
section and reads:


"The Easiest way to perform the following is to use LODE, which 
automates all that is necessary, beyond installing Visual Studio and Java.


If you want to do it the hard way, continue reading."

If you had used the LODE method, an autogen.input file would have been 
created. Now you have to create it yourself. More about the file: 
https://wiki.documentfoundation.org/Development/GenericBuildingHints#autogen_help


Ilmari

Re: How to get started with contributions

[Ilmari Lauhakangas]

On 11.1.2024 15.06, A.P Singh wrote:

Respected sir/madam,

I am Aman Pratap Singh, a computer science undergrad, I’m second year 
student at J.C. Bose University of Science and Technology, YMCA. I am 
new to open source contributions but I am well aware of C,C++,JavaScript 
and react.js. I would love to contribute to your organization but could 
you please tell me how to get started ?


Hoping to hear from you soon.


I have invited you to an interview.

Ilmari

Re: Bug 148857

[Ilmari Lauhakangas]

On 11.1.2024 11.15, y27p6e3vu...@web.de wrote:

Hi,
I recently faced bug 148857 (Bugzilla)
*Bug 148857* 
 - Handle is 
not initialized exception when bootstrapping with .Net (but not in .Net 
Framework


Since the bug is not yet assigned to anybody since one and a half year 
it seems that the bug is not with high priority.

My question is if there is a workaround?
I tried to comment the bug report on Bugzilla but have problems to log 
in. My credentials seem to be not working and resetting my password 
stucks. I receive no related mail fom the server.


For login problems, contact hostmas...@documentfoundation.org with all 
relevant details.


Ilmari

Re: How to remove a file containing CR/LF from source

[Ilmari Lauhakangas]

On 8.1.2024 9.41, Heiko Tietze wrote:

On 07.01.24 10:26, Andras Timar wrote:

1. git rm extras/source/templates/presnt/Growing_Liberty/readme.txt

I wonder if there is a difference between rm + git add and git rm.


We can read the manual and check: https://git-scm.com/docs/git-rm

Remove files matching pathspec from the index, or from the working tree 
and the index. git rm will not remove a file from just your working 
directory. (There is no option to remove a file only from the working 
tree and yet keep it in the index; use /bin/rm if you want to do that.)


Ilmari

Re: master build broken on macOS due to Firebird update

[Ilmari Lauhakangas]

On 7.1.2024 18.38, Patrick Luby wrote:

On 2024-01-06 3:46 p.m., Caolán McNamara wrote:

On Sat, 2024-01-06 at 12:03 -0500, Patrick Luby wrote:

I have submitted a revert for the Firebird update here:


The previous version was 3.0.7 and the current is 3.0.11 which suggests
there probably wasn't massive changes. So reading through the upgrade
commit I see a macosx specific hunk in one of our patches got dropped,
presumably because it didn't apply.

Does https://gerrit.libreoffice.org/c/core/+/161727 which restores that
hunk make any difference?

>
> Thank you Caolán for finding the cause of the macOS build failures! I
> can now build and run the unit tests successfully running "make clean &&
> make && make check"
>
> Although the following Gerrit change mostly only affects macOS, I did
> add a fix for another problem that I found: the Firebird build runs the
> isql command in its build directory and it can't find libfbclient:
>
> https://gerrit.libreoffice.org/c/core/+/161727
>
> With the above patch, are there still build failures on Windows or Linux.

Yes, even with the patch the (debug) build fails for me on Linux with 
Clang 16.


Ilmari

core.git: extras/source

[Ilmari Lauhakangas (via logerrit)]

 extras/source/templates/presnt/Growing_Liberty/readme.txt |   13 -
 1 file changed, 13 deletions(-)

New commits:
commit 4fe9fab476c5e7d4e56696e237e1b4034989c156
Author: Ilmari Lauhakangas 
AuthorDate: Sun Jan 7 11:01:58 2024 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Sun Jan 7 12:38:40 2024 +0100

tdf#158863 Remove obsolete readme.txt file from Growing Liberty template

Change-Id: If74ac04d0401d7d40e436153bdb3be8dc1f350c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161735
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/extras/source/templates/presnt/Growing_Liberty/readme.txt 
b/extras/source/templates/presnt/Growing_Liberty/readme.txt
deleted file mode 100644
index 82fb015c9693..
--- a/extras/source/templates/presnt/Growing_Liberty/readme.txt
+++ /dev/null
@@ -1,13 +0,0 @@
-Growing Liberty template by Budi Aryo @tokofoss
-Licensed under Creative Common Attribution ShareAlike 4.0 International 
(CC-BY-SA 4.0).
-
-
-
-Images included inside template:
-
-White Flower Background 2 by MALIZ ONG
-https://publicdomainpictures.net/en/view-image.php?image=38846=white-flower-background-2
-
-
-Icon set by Garik Barseghyan from Pixabay
-https://pixabay.com/users/insspirito-1851261/

Re: How to remove a file containing CR/LF from source

[Ilmari Lauhakangas]

On 7.1.2024 10.33, Laurent Balland wrote:

Hello,

In change [1], I moved the content of some README files to meta.xml of 
some templates. These README files should now be removed from source. 
However, I did not succeed to delete one [2] because it contains CR/LF 
for new line and I'm building on Linux. Can anyone delete this file:


extras/source/templates/presnt/Growing_Liberty/readme.txt

Or explain me the procedure?

Regards,

Laurent Balland


[1] https://gerrit.libreoffice.org/c/core/+/161501

[2] 
https://cgit.freedesktop.org/libreoffice/core/tree/extras/source/templates/presnt/Growing_Liberty/readme.txt


https://gerrit.libreoffice.org/c/core/+/161735

Procedure:

rm extras/source/templates/presnt/Growing_Liberty/readme.txt
git add extras/source/templates/presnt/Growing_Liberty/readme.txt
git commit
./logerrit submit master

Ilmari

Re: master build broken on macOS due to Firebird update

[Ilmari Lauhakangas]

On 6.1.2024 17.53, Patrick Luby wrote:

On 2024-01-06 10:20 a.m., Patrick Luby wrote:

All,

I am not sure how this update built successfully on macOS on Jenkins, 
but the Firebird update is filled with hundreds of sprintf calls like 
the following. Xcode has marked sprintf as deprecated since a couple 
of versions ago:


/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/temp/Debug/isql/show.cpp:6986:5:
 warning: 'sprintf' is deprecated: This function is provided for compatibility 
reasons only.  Due to security concerns inherent in the design of sprintf(3), 
it is highly recommended that you use snprintf(3) instead. 
[-Wdeprecated-declarations]
 sprintf(info, "Number of DB pages 
free = %" SQUADFORMAT"%s", value_out, separator);


So how do we suppress these "en masse" when doing debug builds?

>
Bad news: this update is worse than I thought when doing a clean debug 
build after doing a make clean. I am seeing a lengthy list of all sorts 
of different warnings being converted to errors. There are still a lot 
of sprintf errors, but now there are even more other, different warnings.


See attached build log for a list of warnings converted to errors that I 
am seeing.


Can anyone actually do a debug build on any other platform on master 
with this update? IIRC Windows also has to suppress deprecation 
warnings, at least for sprintf, but maybe I am wrong.


I am getting a build failure with Clang and --enable-dbgutil:
https://gerrit.libreoffice.org/c/core/+/152016/40#message-9baf3396b2a8714dabf6fbf6eec72d8f9a318ee2

mold: fatal: cannot open loader_path/../Debug/firebird: No such file or 
directory
clang-16: error: linker command failed with exit code 1 (use -v to see 
invocation)

make[6]: *** [Makefile.examples:138: ../../gen/examples/empbuild] Error 1
make[5]: *** [Makefile:600: examples] Error 2
make[4]: *** [Makefile:201: master_process] Error 2
make[3]: *** [Makefile:72: Debug] Error 2
make[2]: *** [Makefile:6: Debug] Error 2
make[1]: *** 
[/home/user/libreoffice/external/firebird/ExternalProject_firebird.mk:30: 
/home/user/libreoffice/workdir/ExternalProject/firebird/build] Error 1


Ilmari

core.git: Branch 'libreoffice-7-6' - helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 28e9ab0ed6fc0c5f4ddf590d50c26b2c467bab7a
Author: Ilmari Lauhakangas 
AuthorDate: Fri Jan 5 14:06:53 2024 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jan 5 13:06:53 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-6'
  to 219add06db0e2193170b462ef74956d559ffcbaa
  - tdf#158961 Remove a z-index: 100 rule to keep Safari happy

Modules navigation was not showing up in Safari because it had too
few elements to overflow. For some reason the z-index: 100 rule for
the containing div triggered this buggy behaviour.

Change-Id: I50776401b567d125d086e826ec7a23694bdf6774
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161651
Tested-by: Jenkins
Reviewed-by: Juan José González 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 
(cherry picked from commit 7f6876711ed991c8cf83edcc47980639b58c2c7a)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161647
(cherry picked from commit c903a5157e0b9fe44a624965b642d1af57ec2b28)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161648

diff --git a/helpcontent2 b/helpcontent2
index 81ebb8bbf768..219add06db0e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 81ebb8bbf768326011406dc4a1e5bc7bbed6dc14
+Subproject commit 219add06db0e2193170b462ef74956d559ffcbaa

help.git: Branch 'libreoffice-7-6' - help3xsl/default.css

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/default.css |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 219add06db0e2193170b462ef74956d559ffcbaa
Author: Ilmari Lauhakangas 
AuthorDate: Thu Jan 4 23:05:27 2024 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Fri Jan 5 13:06:53 2024 +0100

tdf#158961 Remove a z-index: 100 rule to keep Safari happy

Modules navigation was not showing up in Safari because it had too
few elements to overflow. For some reason the z-index: 100 rule for
the containing div triggered this buggy behaviour.

Change-Id: I50776401b567d125d086e826ec7a23694bdf6774
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161651
Tested-by: Jenkins
Reviewed-by: Juan José González 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 
(cherry picked from commit 7f6876711ed991c8cf83edcc47980639b58c2c7a)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161647
(cherry picked from commit c903a5157e0b9fe44a624965b642d1af57ec2b28)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161648

diff --git a/help3xsl/default.css b/help3xsl/default.css
index f01f567484..54cf36daca 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -680,7 +680,6 @@ li.disabled a {
 .modules {
 border-bottom: 2px solid #f3f3f3;
 background-color: #26;
-z-index: 100;
 }
 #modules:after, #langs:after {
 font-size: 30px;

core.git: Branch 'libreoffice-24-2' - helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d370398fc082846e73ca9bfb680e2f42512a62c2
Author: Ilmari Lauhakangas 
AuthorDate: Fri Jan 5 14:03:54 2024 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jan 5 13:03:54 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-24-2'
  to c903a5157e0b9fe44a624965b642d1af57ec2b28
  - tdf#158961 Remove a z-index: 100 rule to keep Safari happy

Modules navigation was not showing up in Safari because it had too
few elements to overflow. For some reason the z-index: 100 rule for
the containing div triggered this buggy behaviour.

Change-Id: I50776401b567d125d086e826ec7a23694bdf6774
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161651
Tested-by: Jenkins
Reviewed-by: Juan José González 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 
(cherry picked from commit 7f6876711ed991c8cf83edcc47980639b58c2c7a)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161647

diff --git a/helpcontent2 b/helpcontent2
index 3c77843503d8..c903a5157e0b 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3c77843503d8aa93a874e5d9271c5dd52dc62efe
+Subproject commit c903a5157e0b9fe44a624965b642d1af57ec2b28

help.git: Branch 'libreoffice-24-2' - help3xsl/default.css

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/default.css |1 -
 1 file changed, 1 deletion(-)

New commits:
commit c903a5157e0b9fe44a624965b642d1af57ec2b28
Author: Ilmari Lauhakangas 
AuthorDate: Thu Jan 4 23:05:27 2024 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Fri Jan 5 13:03:54 2024 +0100

tdf#158961 Remove a z-index: 100 rule to keep Safari happy

Modules navigation was not showing up in Safari because it had too
few elements to overflow. For some reason the z-index: 100 rule for
the containing div triggered this buggy behaviour.

Change-Id: I50776401b567d125d086e826ec7a23694bdf6774
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161651
Tested-by: Jenkins
Reviewed-by: Juan José González 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 
(cherry picked from commit 7f6876711ed991c8cf83edcc47980639b58c2c7a)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161647

diff --git a/help3xsl/default.css b/help3xsl/default.css
index 5f3276fb5b..5bcd2c28f1 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -699,7 +699,6 @@ li.disabled a {
 .modules {
 border-bottom: 2px solid #f3f3f3;
 background-color: #26;
-z-index: 100;
 }
 #modules:after, #langs:after {
 font-size: 30px;

core.git: helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 43ec43154c05aa19d7ec5b631634b9a843689c9e
Author: Ilmari Lauhakangas 
AuthorDate: Fri Jan 5 14:00:32 2024 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jan 5 13:00:32 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 27088ec11fbefefff49820050a411d5d21e32c6d
  - tdf#158961 Remove a z-index: 100 rule to keep Safari happy

Modules navigation was not showing up in Safari because it had too
few elements to overflow. For some reason the z-index: 100 rule for
the containing div triggered this buggy behaviour.

Change-Id: I50776401b567d125d086e826ec7a23694bdf6774
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161651
Tested-by: Jenkins
Reviewed-by: Juan José González 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/helpcontent2 b/helpcontent2
index c8244945b9d3..27088ec11fbe 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c8244945b9d36822a2a35edca7bb9111f39ef282
+Subproject commit 27088ec11fbefefff49820050a411d5d21e32c6d

help.git: help3xsl/default.css

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/default.css |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 27088ec11fbefefff49820050a411d5d21e32c6d
Author: Ilmari Lauhakangas 
AuthorDate: Thu Jan 4 23:05:27 2024 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Fri Jan 5 13:00:32 2024 +0100

tdf#158961 Remove a z-index: 100 rule to keep Safari happy

Modules navigation was not showing up in Safari because it had too
few elements to overflow. For some reason the z-index: 100 rule for
the containing div triggered this buggy behaviour.

Change-Id: I50776401b567d125d086e826ec7a23694bdf6774
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161651
Tested-by: Jenkins
Reviewed-by: Juan José González 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index 5f3276fb5b..5bcd2c28f1 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -699,7 +699,6 @@ li.disabled a {
 .modules {
 border-bottom: 2px solid #f3f3f3;
 background-color: #26;
-z-index: 100;
 }
 #modules:after, #langs:after {
 font-size: 30px;

Re: How to force Jenkins to verify if failing probability is too high

[Ilmari Lauhakangas]

On 1.1.2024 11.20, Laurent Balland wrote:

Hello,

My change [1] did not pass Jenkins verification due to a failing 
probability of 0.45. I did not find any helpful information in Jenkins 
report [2].


I am almost sure that my change should pass. What should I modify in my 
change? How to tell Jenkins to go ahead?


Thanks for your help.

Laurent Balland


[1] https://gerrit.libreoffice.org/c/core/+/161513

[2] 
https://ci.libreoffice.org/job/gerrit_master_ml/9114/consoleFull#-355731841d24ee341-16ff-442b-9671-37df50e21a67


See the log of the actual builder: 
https://ci.libreoffice.org/job/gerrit_linux_gcc_release/156425/consoleFull


[build CPY] templates/presnt/Yellow_Idea/Thumbnails/thumbnail.png
/usr/bin/cp: cannot stat 
'/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/CustomTarget/extras/source/templates/wizard/agenda/10grey.ott': 
No such file or directory
make[1]: *** 
[/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/solenv/gbuild/Package.mk:35: 
/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/instdir/share/template/common/wizard/agenda/10grey.ott] 
Error 1

make[1]: *** Waiting for unfinished jobs
/usr/bin/cp: cannot stat 
'/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/CustomTarget/extras/source/templates/wizard/agenda/1simple.ott': 
No such file or directory
make[1]: *** 
[/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/solenv/gbuild/Package.mk:35: 
/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/instdir/share/template/common/wizard/agenda/1simple.ott] 
Error 1

[build XSL] templates/presnt/Yellow_Idea/content.xml
/usr/bin/cp: cannot stat 
'/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/CustomTarget/extras/source/templates/wizard/agenda/2elegant.ott': 
No such file or directory
make[1]: *** 
[/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/solenv/gbuild/Package.mk:35: 
/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/instdir/share/template/common/wizard/agenda/2elegant.ott] 
Error 1

[build XSL] templates/presnt/Yellow_Idea/styles.xml
make: *** [Makefile:290: build] Error 2
Build step 'Execute shell' marked build as failure
[Checks API] No suitable checks publisher found.
Finished: FAILURE

Ilmari

Re: language and dictionary

[Ilmari Lauhakangas]

On 24.12.2023 14.05, nikow wrote:

Forgive novice question: I am using libreoffice to learn / read / write an 
unsupported language -a dialect of Franco-Norman. Is it possible to use a null 
dictionary and add all the words from scratch? If I can get a few hundred words 
into it, my learning process would be greatly enhanced. I guess conlang writers 
must do something like this when they create new langages. Thanks for reading. 
Nick


We have this wiki page for how to add a new language: 
https://wiki.documentfoundation.org/LibreOffice_Localization_Guide/Adding_a_New_Language_or_Locale


I hope it helps.

Ilmari

core.git: helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b763e68a5641933d1ea2fd449b1faf0e4097b7a4
Author: Ilmari Lauhakangas 
AuthorDate: Wed Dec 20 11:15:19 2023 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Dec 20 10:15:19 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 1ba5e041e6e4e259a69160b90afed882c8c0f664
  - tdf#158105 Change character "background" to "highlighting color"

Change-Id: I9352093a3dfa4af8f763aba6bf2b5914b1f2b071
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161051
Tested-by: Jenkins
    Tested-by: Ilmari Lauhakangas 
    Reviewed-by: Ilmari Lauhakangas 

diff --git a/helpcontent2 b/helpcontent2
index 8d2a9b80fbb8..1ba5e041e6e4 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 8d2a9b80fbb89596185c5b6863713eb696af7140
+Subproject commit 1ba5e041e6e4e259a69160b90afed882c8c0f664

help.git: source/text

[Ilmari Lauhakangas (via logerrit)]

 source/text/shared/01/02100200.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 1ba5e041e6e4e259a69160b90afed882c8c0f664
Author: Ilmari Lauhakangas 
AuthorDate: Wed Dec 20 11:12:44 2023 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Wed Dec 20 10:15:18 2023 +0100

tdf#158105 Change character "background" to "highlighting color"

Change-Id: I9352093a3dfa4af8f763aba6bf2b5914b1f2b071
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161051
Tested-by: Jenkins
    Tested-by: Ilmari Lauhakangas 
    Reviewed-by: Ilmari Lauhakangas 

diff --git a/source/text/shared/01/02100200.xhp 
b/source/text/shared/01/02100200.xhp
index 2d67988836..16347d4ef9 100644
--- a/source/text/shared/01/02100200.xhp
+++ b/source/text/shared/01/02100200.xhp
@@ -154,8 +154,8 @@
   Finds 
characters with the Individual Words attribute, which can be set 
when using Underlining, Strikethrough and 
Overlining.
 
 
-Character background
-  Finds 
characters that use the Background attribute.
+Character highlighting color
+  Finds 
characters that use the highlighting color attribute.
 
 
 Line Spacing

Live streaming LibreOffice bug triaging (week 51)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Tue, 19 December 2023 at 16:00 UTC
Wed, 20 December 2023 at 15:00 UTC
Thu, 21 December 2023 at 12:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

help.git: Branch 'libreoffice-24-2' - help3xsl/default.css help3xsl/help2.js help3xsl/online_transform.xsl help3xsl/paginathing.js help3xsl/xap_templ_query.xsl source/text

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/default.css|  183 
 help3xsl/help2.js   |   15 --
 help3xsl/online_transform.xsl   |   86 +++
 help3xsl/paginathing.js |3 
 help3xsl/xap_templ_query.xsl|9 -
 source/text/shared/help/browserhelp.xhp |   22 +--
 6 files changed, 157 insertions(+), 161 deletions(-)

New commits:
commit 6d45710a35698fbab9b416b728d6cf0c78549542
Author: Ilmari Lauhakangas 
AuthorDate: Sat Dec 16 15:49:32 2023 +0200
Commit: Olivier Hallot 
CommitDate: Sun Dec 17 15:38:57 2023 +0100

Make Help navigation layout less busy

Bookmarks don't have to be visible all the time, so make them a
dropdown and move the search box to header.

Move Xapian search to the top of the content area.

Make Contents tree appear on the left side in 960px and wider screens.

Simplify/clean up some CSS and JS, for example for module colours.

Change-Id: Ic50a834b758d50098868866e4b8d3e8085755423
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160870
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 25f39b53fb292ec90368f2afd3678884a1a8bb27)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160860

diff --git a/help3xsl/default.css b/help3xsl/default.css
index b54f9fe725..5f3276fb5b 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -32,6 +32,7 @@ do not break anything related to layout by scaling.
   --font_mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
   --font_body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
   --background-color: #f7f8f7;
+  --module-color: #18A303;
 }
 
 body,
@@ -226,6 +227,7 @@ html[dir=ltr] th {
 margin-top: 0px;
 }
 .tableheadcell {
+background: var(--module-color);
 color: white;
 vertical-align:top;
 }
@@ -252,7 +254,8 @@ h4,
 h5,
 h6 {
 margin-bottom: 0.67rem;
-color: #148603;
+color: var(--module-color);
+border-bottom-color: var(--module-color);
 }
 p,
 ol,
@@ -263,7 +266,7 @@ td {
 h1 {
 font-size: 1.83rem;
 font-weight: 300;
-border-bottom: 2px solid #148603;
+border-bottom: 2px solid;
 margin-bottom: 1.67rem;
 }
 h1 a {
@@ -326,14 +329,15 @@ h6 {
 margin-top: 15px;
 margin-bottom: 15px;
 }
-
 #DisplayArea {
 background-color: #FCFCFC;
 overflow: auto;
 padding: 10px 10px 40px 10px;
 grid-area: main;
 }
-
+#omega-autofocus {
+width: 274px;
+}
 .mediabutton {
 background-color: cyan;
 }
@@ -360,6 +364,7 @@ h6 {
 
 .embedded {}
 #TopLeftHeader {
+background: var(--module-color);
 grid-area: header;
 position: sticky;
 top: 0px;
@@ -379,6 +384,7 @@ h6 {
 display: flex;
 justify-content: space-between;
 flex-direction: column;
+width: 100%;
 }
 .symbol, .logo, .logo:hover, .logo:visited {
 color: #fff;
@@ -495,9 +501,8 @@ footer p {
 label[for=accordion-1] {
 color: #26;
 display: block;
-padding: 10px 0 10px 20px;
+margin: 0 0 10px 10px;
 font-size: 22px;
-line-height: .6;
 }
 label[for=accordion-1]:after {
 font-size: 44px;
@@ -510,7 +515,7 @@ aside input[type=checkbox]:checked ~ .contents-treeview {
 color: #333;
 z-index: 6;
 display: block;
-margin: 0 20px 0 20px;
+margin: 0 20px 20px 20px;
 }
 .index-label {
 font-size: 22px;
@@ -518,7 +523,7 @@ aside input[type=checkbox]:checked ~ .contents-treeview {
 padding-left: 20px;
 margin: 20px 0 0 0;
 }
-#Index, .index {
+.index {
 margin-top: 10px;
 }
 .index {
@@ -532,7 +537,8 @@ aside input[type=checkbox]:checked ~ .contents-treeview {
 display: none;
 }
 #Bookmarks {
-padding: 0 20px;
+width: 300px;
+margin-left: 10px;
 }
 #Bookmarks p {
 font-size: 22px;
@@ -628,7 +634,6 @@ li.disabled a {
 box-shadow: inset 0 1px 1px rgba(0,0,0,0.1);
 box-sizing: border-box;
 line-height: 1.5em;
-margin-top: 10px;
 outline: none;
 padding: 0 .25em;
 transition: all 0.30s ease-in-out;
@@ -642,13 +647,25 @@ li.disabled a {
 #search-bar::placeholder {
 font-style: italic;
 }
+#SearchFrame .nav-container {
+display: none;
+position: absolute;
+background-color: var(--background-color);
+overflow-y: auto;
+-webkit-overflow-scrolling: touch;
+max-height: 80svh;
+width: 300px;
+}
+#SearchFrame:focus-within .nav-container {
+display: block;
+}
 .xapian-donation {
 border-top: 2px solid #148603;
 background-color: #FCFCFC;
 box-shadow: 0 2px 8px 0 rgba(0,0,0,.05);
 }
 #DonationFrame {
-background: #18A303;
+background: var(--module-color);
 position: sticky;
 top: 0px;
 }
@@ -672,10 +689,9 @@ li.disabl

help.git: help3xsl/default.css help3xsl/help2.js help3xsl/online_transform.xsl help3xsl/paginathing.js help3xsl/xap_templ_query.xsl source/text

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/default.css|  183 
 help3xsl/help2.js   |   15 --
 help3xsl/online_transform.xsl   |   86 +++
 help3xsl/paginathing.js |3 
 help3xsl/xap_templ_query.xsl|9 -
 source/text/shared/help/browserhelp.xhp |   22 +--
 6 files changed, 157 insertions(+), 161 deletions(-)

New commits:
commit 25f39b53fb292ec90368f2afd3678884a1a8bb27
Author: Ilmari Lauhakangas 
AuthorDate: Sat Dec 16 15:49:32 2023 +0200
Commit: Olivier Hallot 
CommitDate: Sat Dec 16 22:11:42 2023 +0100

Make Help navigation layout less busy

Bookmarks don't have to be visible all the time, so make them a
dropdown and move the search box to header.

Move Xapian search to the top of the content area.

Make Contents tree appear on the left side in 960px and wider screens.

Simplify/clean up some CSS and JS, for example for module colours.

Change-Id: Ic50a834b758d50098868866e4b8d3e8085755423
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160870
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index b54f9fe725..5f3276fb5b 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -32,6 +32,7 @@ do not break anything related to layout by scaling.
   --font_mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
   --font_body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
   --background-color: #f7f8f7;
+  --module-color: #18A303;
 }
 
 body,
@@ -226,6 +227,7 @@ html[dir=ltr] th {
 margin-top: 0px;
 }
 .tableheadcell {
+background: var(--module-color);
 color: white;
 vertical-align:top;
 }
@@ -252,7 +254,8 @@ h4,
 h5,
 h6 {
 margin-bottom: 0.67rem;
-color: #148603;
+color: var(--module-color);
+border-bottom-color: var(--module-color);
 }
 p,
 ol,
@@ -263,7 +266,7 @@ td {
 h1 {
 font-size: 1.83rem;
 font-weight: 300;
-border-bottom: 2px solid #148603;
+border-bottom: 2px solid;
 margin-bottom: 1.67rem;
 }
 h1 a {
@@ -326,14 +329,15 @@ h6 {
 margin-top: 15px;
 margin-bottom: 15px;
 }
-
 #DisplayArea {
 background-color: #FCFCFC;
 overflow: auto;
 padding: 10px 10px 40px 10px;
 grid-area: main;
 }
-
+#omega-autofocus {
+width: 274px;
+}
 .mediabutton {
 background-color: cyan;
 }
@@ -360,6 +364,7 @@ h6 {
 
 .embedded {}
 #TopLeftHeader {
+background: var(--module-color);
 grid-area: header;
 position: sticky;
 top: 0px;
@@ -379,6 +384,7 @@ h6 {
 display: flex;
 justify-content: space-between;
 flex-direction: column;
+width: 100%;
 }
 .symbol, .logo, .logo:hover, .logo:visited {
 color: #fff;
@@ -495,9 +501,8 @@ footer p {
 label[for=accordion-1] {
 color: #26;
 display: block;
-padding: 10px 0 10px 20px;
+margin: 0 0 10px 10px;
 font-size: 22px;
-line-height: .6;
 }
 label[for=accordion-1]:after {
 font-size: 44px;
@@ -510,7 +515,7 @@ aside input[type=checkbox]:checked ~ .contents-treeview {
 color: #333;
 z-index: 6;
 display: block;
-margin: 0 20px 0 20px;
+margin: 0 20px 20px 20px;
 }
 .index-label {
 font-size: 22px;
@@ -518,7 +523,7 @@ aside input[type=checkbox]:checked ~ .contents-treeview {
 padding-left: 20px;
 margin: 20px 0 0 0;
 }
-#Index, .index {
+.index {
 margin-top: 10px;
 }
 .index {
@@ -532,7 +537,8 @@ aside input[type=checkbox]:checked ~ .contents-treeview {
 display: none;
 }
 #Bookmarks {
-padding: 0 20px;
+width: 300px;
+margin-left: 10px;
 }
 #Bookmarks p {
 font-size: 22px;
@@ -628,7 +634,6 @@ li.disabled a {
 box-shadow: inset 0 1px 1px rgba(0,0,0,0.1);
 box-sizing: border-box;
 line-height: 1.5em;
-margin-top: 10px;
 outline: none;
 padding: 0 .25em;
 transition: all 0.30s ease-in-out;
@@ -642,13 +647,25 @@ li.disabled a {
 #search-bar::placeholder {
 font-style: italic;
 }
+#SearchFrame .nav-container {
+display: none;
+position: absolute;
+background-color: var(--background-color);
+overflow-y: auto;
+-webkit-overflow-scrolling: touch;
+max-height: 80svh;
+width: 300px;
+}
+#SearchFrame:focus-within .nav-container {
+display: block;
+}
 .xapian-donation {
 border-top: 2px solid #148603;
 background-color: #FCFCFC;
 box-shadow: 0 2px 8px 0 rgba(0,0,0,.05);
 }
 #DonationFrame {
-background: #18A303;
+background: var(--module-color);
 position: sticky;
 top: 0px;
 }
@@ -672,10 +689,9 @@ li.disabled a {
 text-align: center;
 }
 #SearchFrame {
-background: #18A303;
 top: 0px;
 position: sticky;
-z-in

core.git: officecfg/registry reportbuilder/registry

[Ilmari Lauhakangas (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/Accelerators.xcu | 2722 
+-
 reportbuilder/registry/data/org/openoffice/Office/Accelerators.xcu |   34 
 2 files changed, 1378 insertions(+), 1378 deletions(-)

New commits:
commit bcffed442b308a01e31fe8c832a12b47ec774290
Author: Ilmari Lauhakangas 
AuthorDate: Wed Dec 13 21:24:28 2023 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Thu Dec 14 09:04:26 2023 +0100

Fix typo: I10N -> L10N

Change-Id: I20a0eb54a85a9dea5c7d4cd91ff3632574b14802
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160714
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Jenkins

diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu 
b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
index 156dde567262..65fa7fcd25f3 100644
--- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
@@ -26,44 +26,44 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some 
emoji thing
 
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SelectAll
   .uno:Open
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   vnd.sun.star.findbar:FocusToFindbar
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SearchDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:Copy
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ZoomMinus
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ZoomPlus
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:InsertAnnotation
   
   
@@ -72,207 +72,207 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some 
emoji thing
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:InsertAnnotation
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:EditDoc
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SpellOnline
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:HyperlinkDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:Delete
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SelectAll
   .uno:CommonAlignHorizontalCenter
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:MacroDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ViewDataSourceBrowser
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:ToggleControlFocus
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:HangulHanjaConversion
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   vnd.sun.star.findbar:FocusToFindbar
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SearchDialog
   .uno:SearchDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:SearchDialog
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:Save
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:CommonAlignJustified
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:CommonAlignLeft
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSLATE
   .uno:AddDirect
 
   
   
 
-  I10N SHORTCUTS - NO 
TRANSLATE
+  L10N SHORTCUTS - NO 
TRANSL

Re: Build problems with Skia

[Ilmari Lauhakangas]

On 8.12.2023 20.38, Regina Henschel wrote:

Hi all,

I get a build problem with Skia in a clean build.

My autogen.sh parameters are
/cygdrive/c/BuildLO/core/autogen.sh \
--with-external-tar=/cygdrive/c/BuildLO/externalsrc \
--with-junit=/cygdrive/c/cygwin64/junit/junit-4.10.jar \
--with-ant-home=/cygdrive/c/cygwin64/ant/apache-ant-1.9.5 \
--disable-ccache \
--with-visual-studio=2022 \
--enable-debug \
--enable-werror \
--enable-odk \
--disable-cve-tests \
--disable-online-update \
--without-fonts \
--with-jdk-home=/cygdrive/c/Program\ Files/Microsoft/jdk-21.0.1.12-hotspot

The error messages are:

C:/BuildLO/core/external/skia/source/SkMemory_malloc.cxx(6,10): fatal 
error: cannot open file 
'C:/BuildLO/core/include\include/core/SkTypes.h': The file cannot

   be accessed by the system.
#include "include/core/SkTypes.h"
  ^
In file included from 
C:/BuildLO/core/external/skia/source/skia_compiler.cxx:6:
C:/BuildLO/core/external/skia/inc\skia_compiler.hxx(9,10): fatal error: 
cannot open file 'C:/BuildLO/core/include\include/core/SkTypes.h': The 
file cannot[build CXX] 
workdir/UnpackedTarball/skia/src/base/SkMalloc.cpp be


   accessed by the system.
#include 
  ^
In file included from C:/BuildLO/core/external/skia/source/skia_opts.cxx:6:
C:/BuildLO/core/external/skia/inc\skia_opts.hxx(9,10): fatal error: 
cannot open file 'C:/BuildLO/core/include\include/core/SkTypes.h': The 
file cannot be

   accessed by the system.
#include 
  ^
[build CXX] workdir/UnpackedTarball/skia/src/base/SkMathPriv.cpp
[build CXX] workdir/UnpackedTarball/skia/src/base/SkQuads.cpp
1 error generated.
[build CXX] workdir/UnpackedTarball/skia/src/base/SkSafeMath.cpp
[build CXX] workdir/UnpackedTarball/skia/src/base/SkSemaphore.cpp
[build CXX] workdir/UnpackedTarball/skia/src/base/SkSharedMutex.cpp
[build CXX] workdir/UnpackedTarball/skia/src/base/SkSpinlock.cpp
In file included from 
C:/buildLO/core/workdir/UnpackedTarball/skia/src/base/SkArenaAlloc.cpp:8:

C:/buildLO/core/workdir/UnpackedTarball/skia\src/base/SkArenaAlloc.h(11,10): 
fatal error: cannot open file
   'C:/BuildLO/core/include\include/private/base/SkAssert.h': The 
file cannot be accessed by the system.

#include "include/private/base/SkAssert.h"
  ^
make[1]: *** [C:/BuildLO/core/solenv/gbuild/LinkTarget.mk:340: 
C:/buildLO/core/workdir/CxxObject/external/skia/source/skia_compiler.o] 
Error 1

make[1]: *** Waiting for unfinished jobs
In file included from 
C:/buildLO/core/workdir/UnpackedTarball/skia/src/base/SkBezierCurves.cpp:8:
In file included from 
C:/buildLO/core/workdir/UnpackedTarball/skia/src/base/SkBlockAllocator.cpp:8:

C:/buildLO/core/workdir/UnpackedTarball/skia\src/base/SkBlockAllocator.h(11,10)C:/buildLO/core/workdir/UnpackedTarball/skia\src/base/SkBezierCurves.h:
 fatal error: cannot open (file
   'C:/BuildLO/core/include\include/private/base/SkAlign.h': The 
file cannot be accessed by the system.10

,#include "include/private/base/SkAlign.h"10
): ^

and so on.


This message from September 2023 seems to describe the same issue, with 
paths getting strangely mixed up: 
https://lists.freedesktop.org/archives/libreoffice/2023-September/090956.html


But it got no replies.

Ilmari

Re: [Libreoffice-qa] QA Weekly Focus: RTL

[Ilmari Lauhakangas]

On 5.12.2023 10.13, Stéphane Guillou wrote:

On 05/12/2023 00:01, Eyal Rozenberg wrote:

On 04/12/2023 21:43, Stéphane Guillou wrote:

  * RTL issues on the Wiki: https://wiki.documentfoundation.org/RTL_Bugs


This one is out-of-data - help is appreciated in bringing it in line
with updates over the past several years. You may be interested in my
2022 presentation about the state of RTL, which is itself a bit outdated
already: https://t.ly/MoHF_ (mind the underscore).


Yes, edits on this page are welcome.

I think the list of fixed bugs is a bit of an un-maintainable section, 
so would replace it with links to Bugzilla, if no one objects to it?


The page should be moved under the QA namespace.

Ilmari

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Ilmari Lauhakangas (via logerrit)]

 include/sfx2/thumbnailview.hxx  |1 +
 sfx2/source/control/recentdocsview.cxx  |1 +
 sfx2/source/control/templatedefaultview.cxx |1 +
 sfx2/source/control/thumbnailview.cxx   |3 ++-
 4 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 5584980493fd599054cc5bbdb9911ae2c70cd60f
Author: Ilmari Lauhakangas 
AuthorDate: Mon Nov 27 18:40:57 2023 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Mon Dec 4 20:16:06 2023 +0100

tdf#158404 Start Center: remove ability to do multiselections

in Recent Documents and Templates views using Shift+arrow keys as
no actions can be executed for multiple selected files.

Multiselection still works as normal in Manage Templates dialog.

Change-Id: I03b9e54abb7772881139763a0c97f36637d01f85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160003
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/include/sfx2/thumbnailview.hxx b/include/sfx2/thumbnailview.hxx
index 655aa3ba13e5..54e8440ad363 100644
--- a/include/sfx2/thumbnailview.hxx
+++ b/include/sfx2/thumbnailview.hxx
@@ -309,6 +309,7 @@ protected:
 bool mbShowTooltips : 1;
 bool mbDrawMnemonics : 1;
 bool mbSelectOnFocus : 1;
+bool mbAllowMultiSelection : 1;
 Color maFillColor;  ///< Background color of the thumbnail 
view widget.
 Color maTextColor;  ///< Text color.
 Color maHighlightColor; ///< Color of the highlight (background) 
of the hovered item.
diff --git a/sfx2/source/control/recentdocsview.cxx 
b/sfx2/source/control/recentdocsview.cxx
index 6df534788a32..f6ea1278390a 100644
--- a/sfx2/source/control/recentdocsview.cxx
+++ b/sfx2/source/control/recentdocsview.cxx
@@ -68,6 +68,7 @@ 
RecentDocsView::RecentDocsView(std::unique_ptr xWindow, st
 , mpLoadRecentFile(nullptr)
 , m_nExecuteHdlId(nullptr)
 {
+mbAllowMultiSelection = false;
 AbsoluteScreenPixelRectangle aScreen = 
Application::GetScreenPosSizePixel(Application::GetDisplayBuiltInScreen());
 mnItemMaxSize = std::min(aScreen.GetWidth(),aScreen.GetHeight()) > 800 ? 
256 : 192;
 
diff --git a/sfx2/source/control/templatedefaultview.cxx 
b/sfx2/source/control/templatedefaultview.cxx
index 909545e423ce..eef46f1817fd 100644
--- a/sfx2/source/control/templatedefaultview.cxx
+++ b/sfx2/source/control/templatedefaultview.cxx
@@ -25,6 +25,7 @@ 
TemplateDefaultView::TemplateDefaultView(std::unique_ptr x
  std::unique_ptr xMenu)
 : TemplateLocalView(std::move(xWindow), std::move(xMenu))
 {
+mbAllowMultiSelection = false;
 AbsoluteScreenPixelRectangle aScreen = 
Application::GetScreenPosSizePixel(Application::GetDisplayBuiltInScreen());
 tools::Long nItemMaxSize = 
std::min(aScreen.GetWidth(),aScreen.GetHeight()) > 800 ? 256 : 192;
 ThumbnailView::setItemDimensions( nItemMaxSize, nItemMaxSize, 
gnTextHeight, gnItemPadding );
diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index abb9f9799e34..1ae47016935e 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -246,6 +246,7 @@ void ThumbnailView::ImplInit()
 mbHasVisibleItems = false;
 mbShowTooltips = false;
 mbDrawMnemonics = false;
+mbAllowMultiSelection = true;
 maFilterFunc = ViewFilterAll();
 
 const StyleSettings& rSettings = 
Application::GetSettings().GetStyleSettings();
@@ -681,7 +682,7 @@ bool ThumbnailView::KeyInput( const KeyEvent& rKEvt )
 
 if ( pNext )
 {
-if (aKeyCode.IsShift() && bValidRange)
+if (aKeyCode.IsShift() && bValidRange && mbAllowMultiSelection)
 {
 std::pair aRange;
 size_t nSelPos = mpStartSelRange - mFilteredItemList.begin();

Re: Source code comment appears in UI?

[Ilmari Lauhakangas]

On 27.11.2023 18.54, Daniel Toschläger wrote:

Hello
I am using LibreOffice 7.6. I have a Word document that when I save it 
in Word docx 2007 format it fills the document with !!br0ken!! comments. 
I attached the document.


I am doing a training for game programming with unity in Germany. The 
training is suited for 2018. Maybe the docx is as old as that. I altered 
it by answering the questions inside.


No sensitive data inside as far as I know.


You have broken macro references in your fields.

Please in the future use https://ask.libreoffice.org/ or a user question 
mailing list.


Ilmari

[Libreoffice-qa] Live streaming LibreOffice bug triaging (week 48)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Mon, 27 November 2023 at 09:00 UTC
Tue, 28 November 2023 at 12:00 UTC
Wed, 29 November 2023 at 14:00 UTC
Thu, 30 November 2023 at 12:00 UTC
Fri, 1 December 2023 at 15:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

Re: Mentor LibreOffice at CodePeak 2023!

[Ilmari Lauhakangas]

On 26.11.2023 1.27, gautam.sha...@iitg.ac.in wrote:

Greetings from the community of programmers of IIT Guwahati and IIT Patna!

This is Gautam Sharma, pursuing a BTech in the Department of Computer 
Science and Engineering at the Indian Institute of Technology, Guwahati. 
I am also Competitive Programming Head at Coding Club, IIT Guwahati. We 
at Coding Club, IIT Guwahati were truly awe-inspired by your project 
LibreOffice ! Apart from the wonderful 
open-source community that constantly improves and develops LibreOffice, 
we would like to invite you to put LibreOffice at CodePeak-2023 
 for contributions!


Every year, the Coding Club, IITG organizes CodePeak, which is a 
month-long open-source event organized in collaboration with NJACK, IIT 
Patna. The event invites participants to contribute to various projects, 
aiming to lay a foundation for future involvement in larger programs 
like GSoC and Outreachy. The event targets first-timers who wish to 
participate in Free and Open Source(FOSS) Contributions and the 
experienced developers who want to show their skills by contributing to 
real-world projects.


CodePeak 2023, now in it's third iteration is one of the *biggest 
open-source events for Indian college students*, serving as a pre-cursor 
for many prestigious events like GSoC and Outreachy. We have had *over 
6000 participants*, with *over 150 projects*, and *3800 pull requests* 
in the past iterations of CodePeak! The contributors and mentors are 
also rewarded handsomely for their efforts towards open source by the 
organizers and our respected sponsors! This year, the winners will get a 
chance to visit Oxford!


Mentoring LibreOffice at CodePeak 2023 can go a long way, making it 
mainstream/known to the untapped talent pool of open-source enthusiasts 
who would definitely enjoy contributing to LibreOffice during and after 
CodePeak 2023.


Kindly refer to the mentor guide of CodePeak 2023 here 
.


Looking forward to your reply and involvement in CodePeak 2023!

CodePeak 2023: www.codepeak.tech 
Coding Club IITG Instagram Page: www.instagram.com/codingclubiitg/ 



Have GSoC organisers confirmed that participating in CodePeak does not 
void eligibility for GSoC?


Ilmari

[Libreoffice-commits] core.git: helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 10b1babef046c686de279fefbb70aafcc2dd3d83
Author: Ilmari Lauhakangas 
AuthorDate: Fri Nov 24 16:45:38 2023 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Nov 24 15:45:38 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to b1830be3caa3fae67973f8370aaf1a5e820e3caa
  - tdf#157716 Rename "Language settings" to "Languages and Locales"

Change-Id: I73a7d291d997ac14074b88433b14fa755e888a68
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159928
Tested-by: Jenkins
Reviewed-by: Stéphane Guillou 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index d85fa4e10f11..b1830be3caa3 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d85fa4e10f1156978c2f21aeab4e7d6ad7f80ab0
+Subproject commit b1830be3caa3fae67973f8370aaf1a5e820e3caa

[Libreoffice-commits] help.git: source/text

[Ilmari Lauhakangas (via logerrit)]

 source/text/sbasic/shared/0003.xhp|2 +-
 source/text/sbasic/shared/03030102.xhp|2 +-
 source/text/sbasic/shared/03100300.xhp|2 +-
 source/text/sbasic/shared/03100900.xhp|6 +++---
 source/text/scalc/01/12030100.xhp |   10 +-
 source/text/scalc/01/12050200.xhp |4 ++--
 source/text/scalc/guide/currency_format.xhp   |2 +-
 source/text/schart/01/0402.xhp|2 +-
 source/text/shared/00/0005.xhp|2 +-
 source/text/shared/00/0007.xhp|2 +-
 source/text/shared/00/0406.xhp|   16 
 source/text/shared/01/05020100.xhp|2 +-
 source/text/shared/01/05020300.xhp|2 +-
 source/text/shared/01/05020301.xhp|2 +-
 source/text/shared/01/05020700.xhp|4 ++--
 source/text/shared/01/06010600.xhp|2 +-
 source/text/shared/01/0620.xhp|2 +-
 source/text/shared/01/ref_pdf_export_initial_view.xhp |2 +-
 source/text/shared/guide/ctl.xhp  |4 ++--
 source/text/shared/guide/language_select.xhp  |6 +++---
 source/text/shared/optionen/0100.xhp  |2 +-
 source/text/shared/optionen/01030500.xhp  |2 +-
 source/text/shared/optionen/0104.xhp  |4 ++--
 source/text/shared/optionen/01040300.xhp  |2 +-
 source/text/shared/optionen/01040400.xhp  |2 +-
 source/text/shared/optionen/0114.xhp  |8 
 source/text/shared/optionen/languagetools.xhp |2 +-
 source/text/shared/optionen/translatetools.xhp|2 +-
 source/text/swriter/01/05040800.xhp   |2 +-
 source/text/swriter/01/0603.xhp   |2 +-
 source/text/swriter/01/translate.xhp  |4 ++--
 source/text/swriter/guide/delete_from_dict.xhp|2 +-
 source/text/swriter/guide/finding.xhp |2 +-
 source/text/swriter/guide/hyphen_prevent.xhp  |2 +-
 source/text/swriter/librelogo/LibreLogo.xhp   |2 +-
 35 files changed, 58 insertions(+), 58 deletions(-)

New commits:
commit b1830be3caa3fae67973f8370aaf1a5e820e3caa
Author: Ilmari Lauhakangas 
AuthorDate: Fri Nov 24 15:45:05 2023 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Nov 24 15:45:37 2023 +0100

tdf#157716 Rename "Language settings" to "Languages and Locales"

Change-Id: I73a7d291d997ac14074b88433b14fa755e888a68
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159928
Tested-by: Jenkins
Reviewed-by: Stéphane Guillou 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/sbasic/shared/0003.xhp 
b/source/text/sbasic/shared/0003.xhp
index 538ce5a35e..72b0f59d1b 100644
--- a/source/text/sbasic/shared/0003.xhp
+++ b/source/text/sbasic/shared/0003.xhp
@@ -27,7 +27,7 @@
 Information
 
 You can set 
the locale used for controlling the formatting numbers, dates and currencies in 
$[officename] Basic in %PRODUCTNAME - Preferences
-Tools - 
Options - Language Settings - 
Languages. In Basic format codes, the decimal point (.) is 
always used as placeholder for the decimal separator defined in 
your locale and will be replaced by the corresponding character.
+Tools - 
Options - Languages and Locales - 
General. In Basic format codes, the decimal point (.) is 
always used as placeholder for the decimal separator defined in 
your locale and will be replaced by the corresponding character.
 The same 
applies to the locale settings for date, time and currency formats. The Basic 
format code will be interpreted and displayed according to your locale 
setting.
 
 
diff --git a/source/text/sbasic/shared/03030102.xhp 
b/source/text/sbasic/shared/03030102.xhp
index 967ec67a14..e523630e5b 100644
--- a/source/text/sbasic/shared/03030102.xhp
+++ b/source/text/sbasic/shared/03030102.xhp
@@ -44,7 +44,7 @@
 
 
   date: A string 
that contains the date that will be converted to a Date 
object.
-  The string passed to 
DateValue must be expressed in one of the date formats 
defined by your locale setting (see %PRODUCTNAME - 
PreferencesTools - 
Options - Language Settings 
- Languages) or using the ISO date format "-mm-dd" (year, month 
and day separated by hyphens).
+  The string passed to 
DateValue must be expressed in one of the date formats 
defined by your locale setting (see %PRODUCTNAME - 
PreferencesTools - 
Options - Languages and 
Locales - General) or using the ISO date format "-mm-dd" (year, 
month and day separated by hyphens).
 
 
 Date.
diff --git a/source/text/sbasic/shared/03100300.xhp 
b/source/text/sbasic/shared/03100300.xhp
index 23a22419ce..d40df84cd3 100644

[Libreoffice-qa] Live streaming LibreOffice bug triaging (week 46)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Mon, 13 November 2023 at 17:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

[Libreoffice-qa] Live streaming LibreOffice bug triaging (week 45)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Tue, 7 November 2023 at 16:00 UTC
Wed, 8 November 2023 at 16:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

[Libreoffice-commits] core.git: officecfg/registry

[Ilmari Lauhakangas (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a18174e807e8704c385637b8a53c45b9608bfa42
Author: Ilmari Lauhakangas 
AuthorDate: Mon Oct 30 15:25:22 2023 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Mon Oct 30 20:24:02 2023 +0100

tdf#14 Use title case Toggle Point Edit Mode

Change-Id: I5ee2bd22e73262e61e49b98773bc18e1ca1b1783
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158661
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 4f56a16e59e8..5235cfea8946 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -2507,7 +2507,7 @@ bit 3 (0x8): #define 
UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8
   
   
 
-  Toggle point edit mode
+  Toggle Point Edit Mode
 
 
   1

[Libreoffice-commits] core.git: helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 86f0d88025262b0cfb519545ae7956f6ecea16f9
Author: Ilmari Lauhakangas 
AuthorDate: Mon Oct 30 15:31:43 2023 +0200
Commit: Gerrit Code Review 
CommitDate: Mon Oct 30 14:31:43 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to acb9fd45cdf33a7ad567dad95dfea0ad33a6b915
  - tdf#14 Use title case Toggle Point Edit Mode

Change-Id: Ia40726ec51351fdaf159aa843413583ea183047e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158662
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/helpcontent2 b/helpcontent2
index b8d3fdc2402f..acb9fd45cdf3 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit b8d3fdc2402fbb7a2e0ebff6921e310d9a7b74af
+Subproject commit acb9fd45cdf33a7ad567dad95dfea0ad33a6b915

[Libreoffice-commits] help.git: source/text

[Ilmari Lauhakangas (via logerrit)]

 source/text/shared/00/00040502.xhp |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit acb9fd45cdf33a7ad567dad95dfea0ad33a6b915
Author: Ilmari Lauhakangas 
AuthorDate: Mon Oct 30 15:28:35 2023 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Mon Oct 30 14:31:42 2023 +0100

tdf#14 Use title case Toggle Point Edit Mode

Change-Id: Ia40726ec51351fdaf159aa843413583ea183047e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158662
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/source/text/shared/00/00040502.xhp 
b/source/text/shared/00/00040502.xhp
index b0abc5cb6f..ac3d7edaa1 100644
--- a/source/text/shared/00/00040502.xhp
+++ b/source/text/shared/00/00040502.xhp
@@ -294,21 +294,21 @@
 
 
 
-Choose Edit - 
Toggle point edit mode.
+Choose Edit - 
Toggle Point Edit Mode.
 
-Toggle point 
edit mode
+Toggle Point 
Edit Mode
 
-Choose 
Draw - Toggle point edit mode.
-On the 
Draw menu of the Draw tab, choose 
Toggle point edit mode.
+Choose 
Draw - Toggle Point Edit Mode.
+On the 
Draw menu of the Draw tab, choose 
Toggle Point Edit Mode.
 
 
 
 
 
-Icon Toggle point edit 
mode
+Icon Toggle Point Edit 
Mode
 
 
-Toggle 
point edit mode
+Toggle 
Point Edit Mode
 
 
 

[Libreoffice-qa] Live streaming LibreOffice bug triaging (week 44)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Mon, 30 October 2023 at 18:00 UTC
Tue, 31 October 2023 at 17:00 UTC
Wed, 1 November 2023 at 18:00 UTC
Thu, 2 November 2023 at 18:00 UTC
Fri, 3 November 2023 at 15:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 138a441b108ea97f7873b633eb579b779f2cf748
Author: Ilmari Lauhakangas 
AuthorDate: Wed Oct 25 19:05:55 2023 +0300
Commit: Gerrit Code Review 
CommitDate: Wed Oct 25 18:05:55 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-6'
  to 4f4db70a67558885482ba33892910f8123f00c03
  - Improve accessibility of dropdown menus

Now the opened menus can be closed with Esc key, so we conform
to the dismissible success criterion in WCAG 2.1:

https://www.w3.org/WAI/WCAG21/Understanding/content-on-hover-or-focus.html

To simplify things, now the navigation lists are populated upon
page load in all cases.

Change-Id: I0a7daaea122d3e03de36c322ccb012c546b271e0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158429
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 69f85cbf17c5acb8fb9b38772139c34eea96a772)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158436
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index c10e043fdaf6..4f4db70a6755 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c10e043fdaf6ed01727d99dfa3bcccd49ba9c527
+Subproject commit 4f4db70a67558885482ba33892910f8123f00c03

[Libreoffice-commits] help.git: Branch 'libreoffice-7-6' - help3xsl/a11y-toggle.js help3xsl/default.css help3xsl/help2.js help3xsl/help.js help3xsl/online_transform.xsl help3xsl/xap_templ_query.xsl

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/a11y-toggle.js   |  146 ++
 help3xsl/default.css  |6 -
 help3xsl/help.js  |1 
 help3xsl/help2.js |   27 ---
 help3xsl/online_transform.xsl |8 +-
 help3xsl/xap_templ_query.xsl  |4 -
 6 files changed, 75 insertions(+), 117 deletions(-)

New commits:
commit 4f4db70a67558885482ba33892910f8123f00c03
Author: Ilmari Lauhakangas 
AuthorDate: Wed Oct 25 18:20:13 2023 +0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Oct 25 18:05:54 2023 +0200

Improve accessibility of dropdown menus

Now the opened menus can be closed with Esc key, so we conform
to the dismissible success criterion in WCAG 2.1:
https://www.w3.org/WAI/WCAG21/Understanding/content-on-hover-or-focus.html

To simplify things, now the navigation lists are populated upon
page load in all cases.

Change-Id: I0a7daaea122d3e03de36c322ccb012c546b271e0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158429
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 69f85cbf17c5acb8fb9b38772139c34eea96a772)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158436
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/help3xsl/a11y-toggle.js b/help3xsl/a11y-toggle.js
index 821a8e0272..62e1032b02 100644
--- a/help3xsl/a11y-toggle.js
+++ b/help3xsl/a11y-toggle.js
@@ -1,100 +1,54 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
-MIT License
-
-Copyright (c) 2016 Edenspiekermann
-
-*/
-
-(function () {
-  'use strict';
-
-  var internalId = 0;
-  var togglesMap = {};
-  var targetsMap = {};
-
-  function $ (selector, context) {
-return Array.prototype.slice.call(
-  (context || document).querySelectorAll(selector)
-);
-  }
-
-  function getClosestToggle (element) {
-if (element.closest) {
-  return element.closest('[data-a11y-toggle]');
-}
-
-while (element) {
-  if (element.nodeType === 1 && element.hasAttribute('data-a11y-toggle')) {
-return element;
-  }
-
-  element = element.parentNode;
-}
-
-return null;
-  }
-
-  function handleToggle (toggle) {
-var target = toggle && targetsMap[toggle.getAttribute('aria-controls')];
-
-if (!target) {
-  return false;
-}
-
-var toggles = togglesMap['#' + target.id];
-var isExpanded = target.getAttribute('aria-hidden') === 'false';
-
-target.setAttribute('aria-hidden', isExpanded);
-toggles.forEach(function (toggle) {
-  toggle.setAttribute('aria-expanded', !isExpanded);
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+function hideNavs() {
+let navs = document.querySelectorAll('[data-a11y-toggle] + nav');
+navs.forEach((nav) => {
+if (!nav.hasAttribute('hidden')) {
+nav.previousElementSibling.setAttribute('aria-expanded', 'false');
+nav.setAttribute('hidden', 'true');
+}
 });
-  }
-
-  var initA11yToggle = function (context) {
-togglesMap = $('[data-a11y-toggle]', context).reduce(function (acc, 
toggle) {
-  var selector = '#' + toggle.getAttribute('data-a11y-toggle');
-  acc[selector] = acc[selector] || [];
-  acc[selector].push(toggle);
-  return acc;
-}, togglesMap);
-
-var targets = Object.keys(togglesMap);
-targets.length && $(targets).forEach(function (target) {
-  var toggles = togglesMap['#' + target.id];
-  var isExpanded = target.hasAttribute('data-a11y-toggle-open');
-  var labelledby = [];
-
-  toggles.forEach(function (toggle) {
-toggle.id || toggle.setAttribute('id', 'a11y-toggle-' + internalId++);
-toggle.setAttribute('aria-controls', target.id);
-toggle.setAttribute('aria-expanded', isExpanded);
-labelledby.push(toggle.id);
-  });
-
-  target.setAttribute('aria-hidden', !isExpanded);
-  target.hasAttribute('aria-labelledby') || 
target.setAttribute('aria-labelledby', labelledby.join(' '));
-
-  targetsMap[target.id] = target;
-});
-  };
-
-  document.addEventListener('DOMContentLoaded', function () {
-initA11yToggle();
-  });
-
-  document.addEventListener('click', function (event) {
-var toggle = getClosestToggle(event.target);
-handleToggle(toggle);
-  });
-
-  document.addEventListener('keyup', function (event) {
-if (event.which === 13 || event.which === 32) {
-  var toggle = getClosestToggle(event.target);
-  if (toggle && toggle.getAttribute('role') === 'button') {
-handleToggle(toggle);
-  }
+}
+const navToggle = document.querySelectorAll('[data-a11y-toggle]');
+navToggle.forEach((toggle) => {
+  let navList = toggle.n

[Libreoffice-commits] core.git: helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 725c543c3b1c91d6656e6ed58006d886f83456dc
Author: Ilmari Lauhakangas 
AuthorDate: Wed Oct 25 18:53:36 2023 +0300
Commit: Gerrit Code Review 
CommitDate: Wed Oct 25 17:53:36 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 69f85cbf17c5acb8fb9b38772139c34eea96a772
  - Improve accessibility of dropdown menus

Now the opened menus can be closed with Esc key, so we conform
to the dismissible success criterion in WCAG 2.1:

https://www.w3.org/WAI/WCAG21/Understanding/content-on-hover-or-focus.html

To simplify things, now the navigation lists are populated upon
page load in all cases.

Change-Id: I0a7daaea122d3e03de36c322ccb012c546b271e0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158429
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 3c0331071035..69f85cbf17c5 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3c0331071035ec78359ec8a4e5919164a31ec879
+Subproject commit 69f85cbf17c5acb8fb9b38772139c34eea96a772

[Libreoffice-commits] help.git: help3xsl/a11y-toggle.js help3xsl/default.css help3xsl/help2.js help3xsl/help.js help3xsl/online_transform.xsl help3xsl/xap_templ_query.xsl

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/a11y-toggle.js   |  146 ++
 help3xsl/default.css  |6 -
 help3xsl/help.js  |1 
 help3xsl/help2.js |   27 ---
 help3xsl/online_transform.xsl |8 +-
 help3xsl/xap_templ_query.xsl  |4 -
 6 files changed, 75 insertions(+), 117 deletions(-)

New commits:
commit 69f85cbf17c5acb8fb9b38772139c34eea96a772
Author: Ilmari Lauhakangas 
AuthorDate: Wed Oct 25 18:20:13 2023 +0300
Commit: Olivier Hallot 
CommitDate: Wed Oct 25 17:53:36 2023 +0200

Improve accessibility of dropdown menus

Now the opened menus can be closed with Esc key, so we conform
to the dismissible success criterion in WCAG 2.1:
https://www.w3.org/WAI/WCAG21/Understanding/content-on-hover-or-focus.html

To simplify things, now the navigation lists are populated upon
page load in all cases.

Change-Id: I0a7daaea122d3e03de36c322ccb012c546b271e0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158429
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/help3xsl/a11y-toggle.js b/help3xsl/a11y-toggle.js
index 821a8e0272..62e1032b02 100644
--- a/help3xsl/a11y-toggle.js
+++ b/help3xsl/a11y-toggle.js
@@ -1,100 +1,54 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
-MIT License
-
-Copyright (c) 2016 Edenspiekermann
-
-*/
-
-(function () {
-  'use strict';
-
-  var internalId = 0;
-  var togglesMap = {};
-  var targetsMap = {};
-
-  function $ (selector, context) {
-return Array.prototype.slice.call(
-  (context || document).querySelectorAll(selector)
-);
-  }
-
-  function getClosestToggle (element) {
-if (element.closest) {
-  return element.closest('[data-a11y-toggle]');
-}
-
-while (element) {
-  if (element.nodeType === 1 && element.hasAttribute('data-a11y-toggle')) {
-return element;
-  }
-
-  element = element.parentNode;
-}
-
-return null;
-  }
-
-  function handleToggle (toggle) {
-var target = toggle && targetsMap[toggle.getAttribute('aria-controls')];
-
-if (!target) {
-  return false;
-}
-
-var toggles = togglesMap['#' + target.id];
-var isExpanded = target.getAttribute('aria-hidden') === 'false';
-
-target.setAttribute('aria-hidden', isExpanded);
-toggles.forEach(function (toggle) {
-  toggle.setAttribute('aria-expanded', !isExpanded);
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+function hideNavs() {
+let navs = document.querySelectorAll('[data-a11y-toggle] + nav');
+navs.forEach((nav) => {
+if (!nav.hasAttribute('hidden')) {
+nav.previousElementSibling.setAttribute('aria-expanded', 'false');
+nav.setAttribute('hidden', 'true');
+}
 });
-  }
-
-  var initA11yToggle = function (context) {
-togglesMap = $('[data-a11y-toggle]', context).reduce(function (acc, 
toggle) {
-  var selector = '#' + toggle.getAttribute('data-a11y-toggle');
-  acc[selector] = acc[selector] || [];
-  acc[selector].push(toggle);
-  return acc;
-}, togglesMap);
-
-var targets = Object.keys(togglesMap);
-targets.length && $(targets).forEach(function (target) {
-  var toggles = togglesMap['#' + target.id];
-  var isExpanded = target.hasAttribute('data-a11y-toggle-open');
-  var labelledby = [];
-
-  toggles.forEach(function (toggle) {
-toggle.id || toggle.setAttribute('id', 'a11y-toggle-' + internalId++);
-toggle.setAttribute('aria-controls', target.id);
-toggle.setAttribute('aria-expanded', isExpanded);
-labelledby.push(toggle.id);
-  });
-
-  target.setAttribute('aria-hidden', !isExpanded);
-  target.hasAttribute('aria-labelledby') || 
target.setAttribute('aria-labelledby', labelledby.join(' '));
-
-  targetsMap[target.id] = target;
-});
-  };
-
-  document.addEventListener('DOMContentLoaded', function () {
-initA11yToggle();
-  });
-
-  document.addEventListener('click', function (event) {
-var toggle = getClosestToggle(event.target);
-handleToggle(toggle);
-  });
-
-  document.addEventListener('keyup', function (event) {
-if (event.which === 13 || event.which === 32) {
-  var toggle = getClosestToggle(event.target);
-  if (toggle && toggle.getAttribute('role') === 'button') {
-handleToggle(toggle);
-  }
+}
+const navToggle = document.querySelectorAll('[data-a11y-toggle]');
+navToggle.forEach((toggle) => {
+  let navList = toggle.nextElementSibling;
+  let navLinks = navList.querySelectorAll('a');
+  toggle.addEventListener('click', (event) => {
+  if (navList.hasAttribute('hidden')) {
+  t

[Libreoffice-qa] Live streaming LibreOffice bug triaging (week 43)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Tue, 24 October 2023 at 11:00 UTC
Wed, 25 October 2023 at 11:00 UTC
Fri, 27 October 2023 at 13:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

[Libreoffice-commits] core.git: helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 66cf022ec61e1afe49acb4d5248e640fb075e649
Author: Ilmari Lauhakangas 
AuthorDate: Wed Oct 11 20:24:35 2023 +0300
Commit: Gerrit Code Review 
CommitDate: Wed Oct 11 19:24:35 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to e7ec227d83792bdaf88cb53be5a5a8849f7f576a
  - tdf#155044 Help: Description -> Alt Text and Text Alternative -> Text

Change-Id: I3c8317f4b747b05c7fbbf7119f9210627aaacd48
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157643
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/helpcontent2 b/helpcontent2
index 379510d74d95..e7ec227d8379 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 379510d74d95dd4e7878e8e86401a3b60a6ef107
+Subproject commit e7ec227d83792bdaf88cb53be5a5a8849f7f576a

[Libreoffice-commits] help.git: source/text

[Ilmari Lauhakangas (via logerrit)]

 source/text/shared/00/00040502.xhp  |8 +--
 source/text/shared/01/05190100.xhp  |   16 +++---
 source/text/swriter/01/05060900.xhp |   96 ++--
 3 files changed, 59 insertions(+), 61 deletions(-)

New commits:
commit e7ec227d83792bdaf88cb53be5a5a8849f7f576a
Author: Ilmari Lauhakangas 
AuthorDate: Fri Oct 6 16:47:57 2023 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Wed Oct 11 19:24:35 2023 +0200

tdf#155044 Help: Description -> Alt Text and Text Alternative -> Text

Change-Id: I3c8317f4b747b05c7fbbf7119f9210627aaacd48
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157643
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/source/text/shared/00/00040502.xhp 
b/source/text/shared/00/00040502.xhp
index c31247393b..2d32400294 100644
--- a/source/text/shared/00/00040502.xhp
+++ b/source/text/shared/00/00040502.xhp
@@ -238,12 +238,10 @@
 
 
 
-Choose 
Format - Description.
-
-Choose 
Description.
+Choose 
Format - Alt Text.
 
-On the 
Image menu of the Image tab, choose 
Description.
-On the 
Object menu of the Object tab, choose 
Description.
+On the 
Image menu of the Image tab, choose 
Alt Text.
+On the 
Object menu of the Object tab, choose 
Alt Text.
 
 
 Click on textbox or 
shape to select, then...
diff --git a/source/text/shared/01/05190100.xhp 
b/source/text/shared/01/05190100.xhp
index 9108312f41..5a30aa4679 100644
--- a/source/text/shared/01/05190100.xhp
+++ b/source/text/shared/01/05190100.xhp
@@ -20,12 +20,12 @@
 
 
   
- Description
+ Alt Text
  /text/shared/01/05190100.xhp
   
 
 
-objects;text 
alternative and description
+objects;text and 
alt text
 descriptions for objects
 text alternative;objects
 
@@ -33,22 +33,22 @@
 
 
 
-Description
-Assigns a text 
alternative and a description to the selected object. These texts are available 
as alternative tags in your document for use by accessibility tools. They are 
also available as tags for images when you export the 
document.
+Alt Text
+Assigns a 
text and an alt text to the selected object. These 
texts are available as alternative tags in your document for use by 
accessibility tools. They are also available as tags for images when you export 
the document.
 
 
   
 
 
-Text Alternative
 
+Text
 Enter a short 
description of the essential details of the selected object for a person who 
cannot see the object. This text is available for use by assistive 
technologies.
 
 
 
-Description
-Enter a longer 
description of the object, especially if the object is too complex or contains 
too much detail to be described adequately with the short Text 
Alternative. Use Description to add 
additional information to the short description found in Text 
Alternative. This text is available for use by assistive 
technologies.
- For images, Text 
Alternative and Description are exported with 
an appropriate tag in HTML and PDF format (remember to enable the Universal
 Accessibility (PDF/UA) option in PDF export).
+Alt Text
+Enter a longer 
description of the object, especially if the object is too complex or contains 
too much detail to be described adequately with the short 
Text. Use Alt Text to add 
additional information to the short description found in 
Text. This text is available for use by assistive 
technologies.
+ For images, Text and 
Alt Text are exported with an appropriate tag in HTML and 
PDF format (remember to enable the Universal
 Accessibility (PDF/UA) option in PDF export).
 
 
 Decorative
diff --git a/source/text/swriter/01/05060900.xhp 
b/source/text/swriter/01/05060900.xhp
index 8d6cf91703..ddb0ddc9f9 100644
--- a/source/text/swriter/01/05060900.xhp
+++ b/source/text/swriter/01/05060900.xhp
@@ -20,7 +20,7 @@
 
 
 
-Options
+Options
 /text/swriter/01/05060900.xhp
 
 
@@ -29,63 +29,63 @@
 
 
 
-
-
-Options
-Specify properties for the 
selected image, frame or OLE object.
+
+
+Options
+Specify properties for the 
selected image, frame or OLE object.
 
 
   
 
-Accessibility
-
-Name
-Enter a name for the selected 
item.
-Assign an object, graphic or frame a 
meaningful name, so that you can quickly locate it afterwards in long 
documents.
-
-Text Alternative (images and OLE 
objects only)
+Accessibility
+
+Name
+Enter a name for the selected 
item.
+Assign an object, graphic or frame a meaningful name, 
so that you can quickly locate it afterwards in long documents.
+
 
+
 
-
-Decorative
-Marks the item as 
purely decorative, not part of the document content, and ignorable by assistive 
technologies.
+
+
+
 Sequences (frames only)
-
-Previous link
-Displays the frame that comes before 
the selected frame in a linked sequence. To add or change the previous link, 
select a name from the list. If you are linking frames, the selected frame and 
the target frame must be empty.
-
-Next link
-Di

[Libreoffice-commits] core.git: cui/uiconfig

[Ilmari Lauhakangas (via logerrit)]

 cui/uiconfig/ui/objecttitledescdialog.ui |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 20f1da9c698023cdf76d35bb4a34b2fee094
Author: Ilmari Lauhakangas 
AuthorDate: Wed Oct 11 17:27:32 2023 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Wed Oct 11 19:23:38 2023 +0200

tdf#155044 Missed one Description to Alt Text spot

Change-Id: I4e454b1e3966007b04d6f50acf4249b9b80f5526
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157840
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/cui/uiconfig/ui/objecttitledescdialog.ui 
b/cui/uiconfig/ui/objecttitledescdialog.ui
index bcb121dc7797..3085ac6124d2 100644
--- a/cui/uiconfig/ui/objecttitledescdialog.ui
+++ b/cui/uiconfig/ui/objecttitledescdialog.ui
@@ -124,8 +124,8 @@
   
 True
 False
-Give longer explanation 
of non-text content that is too complex to be described briefly in “Text 
Alternative”
-_Description:
+Give longer explanation 
of non-text content that is too complex to be described briefly in 
“Text”
+_Alt Text:
 True
 0
   

[Libreoffice-commits] core.git: sfx2/source

[Ilmari Lauhakangas (via logerrit)]

 sfx2/source/commandpopup/CommandPopup.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 72d6287c586a2481c62bf21d88bb363ce584b8dd
Author: Ilmari Lauhakangas 
AuthorDate: Sun Oct 8 22:34:15 2023 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Mon Oct 9 17:47:34 2023 +0200

tdf#142524 Search Commands: use ▸ to indicate sequence

Change-Id: I2a3a7c4db03dbfe53f2b71de7ee9b3df42a22866
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157689
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/sfx2/source/commandpopup/CommandPopup.cxx 
b/sfx2/source/commandpopup/CommandPopup.cxx
index 8d68bd62bd76..0d948a4e84e6 100644
--- a/sfx2/source/commandpopup/CommandPopup.cxx
+++ b/sfx2/source/commandpopup/CommandPopup.cxx
@@ -51,6 +51,7 @@ 
MenuContentHandler::MenuContentHandler(uno::Reference const& xFra
 void MenuContentHandler::gatherMenuContent(
 uno::Reference const& xIndexAccess, MenuContent& 
rMenuContent)
 {
+std::u16string_view aMenuLabelSeparator = AllSettings::GetLayoutRTL() ? u" 
◂ " : u" ▸ ";
 for (sal_Int32 n = 0; n < xIndexAccess->getCount(); n++)
 {
 MenuContent aNewContent;
@@ -85,7 +86,8 @@ void MenuContentHandler::gatherMenuContent(
 aNewContent.m_aMenuLabel = aLabel;
 
 if (!rMenuContent.m_aFullLabelWithPath.isEmpty())
-aNewContent.m_aFullLabelWithPath = 
rMenuContent.m_aFullLabelWithPath + " / ";
+aNewContent.m_aFullLabelWithPath
+= rMenuContent.m_aFullLabelWithPath + aMenuLabelSeparator;
 aNewContent.m_aFullLabelWithPath += aNewContent.m_aMenuLabel;
 aNewContent.m_aSearchableMenuLabel = 
toLower(aNewContent.m_aFullLabelWithPath);
 

Re: Bug in CSV import column type

[Ilmari Lauhakangas]

On 9.10.2023 17.54, Jakob Schöttl wrote:
I tried to login to redmine but my account (this mail address) does not 
log me in.


Anyway, I'd like to report this bug in calc:

sample csv file:

1,1
2,"foo"
3,

In the CSV import dialog when I select the column type "Text" for the 
second column:


-> Only the B1 cell ("1") has the type Text. B2 and B3 have type Decimal

It look like the type is only applied to number fields.


LibreOffice bugs are reported in Bugzilla: 
https://wiki.documentfoundation.org/QA/BugReport


Redmine is for issues related to web applications and websites.

Ilmari

[Libreoffice-qa] Live streaming LibreOffice bug triaging (week 41)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Tue, 10 October 2023 at 10:00 UTC
Wed, 11 October 2023 at 10:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

[Libreoffice-commits] core.git: helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit aafde177d68b97ebd90587603eaad014ba89d337
Author: Ilmari Lauhakangas 
AuthorDate: Fri Oct 6 16:39:40 2023 +0300
Commit: Gerrit Code Review 
CommitDate: Fri Oct 6 15:39:40 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to a79a6e02003a1dd220e2c03add548758f928795b
  - tdf#146609 Rename line width to thickness in Help

The ones that were easy to find. Probably missed something.

Change-Id: I6dbb72b42c07fc8859be733dc6419dfb7a5d0d65
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157642
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/helpcontent2 b/helpcontent2
index e09f381a645a..a79a6e02003a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit e09f381a645a2731e38bfff4a573ee25ccd488b7
+Subproject commit a79a6e02003a1dd220e2c03add548758f928795b

[Libreoffice-commits] help.git: source/text

[Ilmari Lauhakangas (via logerrit)]

 source/text/sbasic/guide/calc_borders.xhp |4 ++--
 source/text/scalc/01/sparklines.xhp   |2 +-
 source/text/scalc/main0203.xhp|4 ++--
 source/text/shared/00/0004.xhp|6 +++---
 source/text/shared/01/05200100.xhp|6 +++---
 source/text/shared/01/05200200.xhp|2 +-
 source/text/shared/guide/fontwork.xhp |2 +-
 source/text/shared/guide/line_intext.xhp  |6 +++---
 source/text/shared/guide/linestyle_define.xhp |8 
 source/text/shared/guide/linestyles.xhp   |8 
 source/text/simpress/main0202.xhp |6 +++---
 source/text/swriter/librelogo/LibreLogo.xhp   |4 ++--
 source/text/swriter/main0205.xhp  |4 ++--
 13 files changed, 31 insertions(+), 31 deletions(-)

New commits:
commit a79a6e02003a1dd220e2c03add548758f928795b
Author: Ilmari Lauhakangas 
AuthorDate: Fri Oct 6 16:37:10 2023 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Fri Oct 6 15:39:39 2023 +0200

tdf#146609 Rename line width to thickness in Help

The ones that were easy to find. Probably missed something.

Change-Id: I6dbb72b42c07fc8859be733dc6419dfb7a5d0d65
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157642
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/source/text/sbasic/guide/calc_borders.xhp 
b/source/text/sbasic/guide/calc_borders.xhp
index 8295c0ad98..f0a9f06381 100644
--- a/source/text/sbasic/guide/calc_borders.xhp
+++ b/source/text/sbasic/guide/calc_borders.xhp
@@ -51,7 +51,7 @@
 newStyle is an integer value that corresponds to 
the border line style (see Line Styles 
below).
 
 
-newWidth is an integer value that defines the line 
width.
+newWidth is an integer value that defines the line 
thickness.
 
 
 newColor is an integer value corresponding to a 
color defined using the RGB 
function.
@@ -102,7 +102,7 @@
   
 Line Styles
   
-  Line styles are 
defined as integer constants. The table below lists the constants for the line 
styles available in Format - Cells - Borders:  
+  Line styles are 
defined as integer constants. The table below lists the constants for the line 
styles available in Format - Cells - Borders:
   


diff --git a/source/text/scalc/01/sparklines.xhp 
b/source/text/scalc/01/sparklines.xhp
index a50521ccca..3671605cc8 100644
--- a/source/text/scalc/01/sparklines.xhp
+++ b/source/text/scalc/01/sparklines.xhp
@@ -46,7 +46,7 @@
 Stacked: also known as win/loss. Displays equally 
sized bars indicating positive and negative values.
 
 
-Line 
width: enter the line width number manually or use the spin 
button.
+Line 
thickness: enter the line thickness number manually or use the spin 
button.
 Display empty 
cells as: choices are available in the drop-down list:
 
 
diff --git a/source/text/scalc/main0203.xhp b/source/text/scalc/main0203.xhp
index 5a769e5bd8..c040a41529 100644
--- a/source/text/scalc/main0203.xhp
+++ b/source/text/scalc/main0203.xhp
@@ -39,9 +39,9 @@
 Line 
Style
 
 
-Line 
Width
+Line 
Thickness
 
-
+
 Line 
Color
 
 
diff --git a/source/text/shared/00/0004.xhp 
b/source/text/shared/00/0004.xhp
index 3008ea016c..7822349b31 100644
--- a/source/text/shared/00/0004.xhp
+++ b/source/text/shared/00/0004.xhp
@@ -157,15 +157,15 @@
 
 
 
-
+
 
 
 
 
-Icon Line 
Width
+Icon Line 
Thickness
 
 
-Line Width
+Line Thickness
 
 
 
diff --git a/source/text/shared/01/05200100.xhp 
b/source/text/shared/01/05200100.xhp
index dd2309e70c..aeaa5600c6 100644
--- a/source/text/shared/01/05200100.xhp
+++ b/source/text/shared/01/05200100.xhp
@@ -49,10 +49,10 @@
 
 
 
-Widths
-Select the width for the line. You can append a 
measurement unit. A zero line width results in a hairline with a width of one 
pixel of the output medium.
+Thickness
+Select the thickness for the line. You can 
append a measurement unit. A zero line thickness results in a hairline with a 
thickness of one pixel of the output medium.
 
-
+
 
 Transparency
 Enter the transparency of the 
line, where 100% corresponds to completely transparent and 0% to completely 
opaque. 
diff --git a/source/text/shared/01/05200200.xhp 
b/source/text/shared/01/05200200.xhp
index 00784834ce..809ec2f846 100644
--- a/source/text/shared/01/05200200.xhp
+++ b/source/text/shared/01/05200200.xhp
@@ -56,7 +56,7 @@
 Spacing
 Enter the amount of space that 
you want to leave between dots or dashes.
 
-Fit to line width
+Fit to line thickness
 Automatically adjusts the entries 
relative to the length of the line.
 
 Add
diff --git a/source/text/shared/guide/fontwork.xhp 
b/source/text/shared/guide/fontwork.xhp
index 8646e33e0d..656285b5d4 100644
--- a/source/text/shared/guide/fontwork.xhp
+++ b/source/text/shared/guide/fontwork.xhp
@@ -113,7 +113,7 @@
 Click the Fontwork 
object

[Libreoffice-commits] core.git: emfio/qa include/test test/source

[Ilmari Lauhakangas (via logerrit)]

 emfio/qa/cppunit/wmf/wmfimporttest.cxx |   26 +-
 include/test/xmltesttools.hxx  |8 
 test/source/xmltesttools.cxx   |8 
 3 files changed, 29 insertions(+), 13 deletions(-)

New commits:
commit b693d19884a09b5f841b30f2e8b586778584ed16
Author: Ilmari Lauhakangas 
AuthorDate: Thu Sep 28 16:42:18 2023 +0300
Commit: Ilmari Lauhakangas 
CommitDate: Fri Oct 6 12:48:17 2023 +0200

xmltesttools: add assertXPathDoubleValue that takes a double with delta

and use it to make WmfTest::testSetTextAlignWmf independent of DPI

Change-Id: I2048239088a8dcc3e3ab1db96413894b5bcc56d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157377
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/emfio/qa/cppunit/wmf/wmfimporttest.cxx 
b/emfio/qa/cppunit/wmf/wmfimporttest.cxx
index 172d20d99fed..de9be9ba0a52 100644
--- a/emfio/qa/cppunit/wmf/wmfimporttest.cxx
+++ b/emfio/qa/cppunit/wmf/wmfimporttest.cxx
@@ -207,70 +207,70 @@ void WmfTest::testSetTextAlignWmf()
 assertXPathContent(pDoc, "/metafile/push[2]/textarray[2]/text", 
"textalignment:default");
 
 assertXPath(pDoc, "/metafile/push[2]/textalign[3]", "align", "top");
-assertXPath(pDoc, "/metafile/push[2]/textarray[3]", "x", "12700");
+assertXPathDoubleValue(pDoc, "/metafile/push[2]/textarray[3]", "x", 12700, 
30);
 assertXPath(pDoc, "/metafile/push[2]/textarray[3]", "y", "212");
 assertXPathContent(pDoc, "/metafile/push[2]/textarray[3]/text", 
"textalignment:0x00");
 
 assertXPath(pDoc, "/metafile/push[2]/textalign[4]", "align", "top");
-assertXPath(pDoc, "/metafile/push[2]/textarray[4]", "x", "12026");
+assertXPathDoubleValue(pDoc, "/metafile/push[2]/textarray[4]", "x", 12026, 
30);
 assertXPath(pDoc, "/metafile/push[2]/textarray[4]", "y", "423");
 assertXPathContent(pDoc, "/metafile/push[2]/textarray[4]/text", 
"textalignment:0x02");
 
 assertXPath(pDoc, "/metafile/push[2]/textalign[5]", "align", "top");
 // Fails without the fix: Expected: 12026, Actual: 12350
-assertXPath(pDoc, "/metafile/push[2]/textarray[5]", "x", "12026");
+assertXPathDoubleValue(pDoc, "/metafile/push[2]/textarray[5]", "x", 12026, 
30);
 assertXPath(pDoc, "/metafile/push[2]/textarray[5]", "y", "635");
 assertXPathContent(pDoc, "/metafile/push[2]/textarray[5]/text", 
"textalignment:0x04");
 
 assertXPath(pDoc, "/metafile/push[2]/textalign[6]", "align", "top");
-assertXPath(pDoc, "/metafile/push[2]/textarray[6]", "x", "12363");
+assertXPathDoubleValue(pDoc, "/metafile/push[2]/textarray[6]", "x", 12363, 
30);
 assertXPath(pDoc, "/metafile/push[2]/textarray[6]", "y", "847");
 assertXPathContent(pDoc, "/metafile/push[2]/textarray[6]/text", 
"textalignment:0x06");
 
 assertXPath(pDoc, "/metafile/push[2]/textalign[7]", "align", "top");
-assertXPath(pDoc, "/metafile/push[2]/textarray[7]", "x", "12700");
+assertXPathDoubleValue(pDoc, "/metafile/push[2]/textarray[7]", "x", 12700, 
30);
 assertXPath(pDoc, "/metafile/push[2]/textarray[7]", "y", "1058");
 assertXPathContent(pDoc, "/metafile/push[2]/textarray[7]/text", 
"textalignment:0x08");
 
 assertXPath(pDoc, "/metafile/push[2]/textalign[8]", "align", "top");
-assertXPath(pDoc, "/metafile/push[2]/textarray[8]", "x", "12026");
+assertXPathDoubleValue(pDoc, "/metafile/push[2]/textarray[8]", "x", 12026, 
30);
 assertXPath(pDoc, "/metafile/push[2]/textarray[8]", "y", "1270");
 assertXPathContent(pDoc, "/metafile/push[2]/textarray[8]/text", 
"textalignment:0x0A");
 
 assertXPath(pDoc, "/metafile/push[2]/textalign[9]", "align", "bottom");
 // Fails without the fix: Expected: 12026, Actual: 12350
-assertXPath(pDoc, "/metafile/push[2]/textarray[9]", "x", "12026");
+assertXPathDoubleValue(pDoc, "/metafile/push[2]/textarray[9]", "x", 12026, 
30);
 assertXPath(pDoc, "/metafile/push[2]/textarray[9]", "y", "1482");
 assertXPathContent(pDoc, "/metafile/push[2]/textarr

[Libreoffice-qa] Live streaming LibreOffice bug triaging (week 40)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Mon, 2 October 2023 at 06:00 UTC
Tue, 3 October 2023 at 15:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

Re: Guidance needed to start contributing

[Ilmari Lauhakangas]

On 29.9.2023 14.11, Mohak Agrawal wrote:

Hello,

I'm Mohak Agrawal, a 2nd year Computer Science student at KIIT 
Bhubaneswar interested in open source development. I saw your 
organization's projects and would appreciate guidance for a beginner.


I have 2 years of Java experience and currently learning DevOps. While 
new to open source, I'm a fast learner willing to make meaningful 
contributions.


Could you recommend starting points? Any initial tasks to teach me? I 
would appreciate any advice.


Thank you for your time. I look forward to hearing from you.

Mohak Agrawal


I have invited you to an interview.

Ilmari

Re: Orcus 0.19.0, Apache Arrow and CMake

[Ilmari Lauhakangas]

On 29.9.2023 4.16, Kohei Yoshida wrote:

Hi there,

I just upgraded on the master branch the orcus library to the latest 
version of 0.19.0.  This version includes an experimental support for 
Apache Parquet format import, but it relies on an external library 
called Apache Arrow[1].  The support for this file format is disabled in 
the libreoffice build.


To enable support for Parquet, we would need to also build the Apache 
Arrow library and its dependency libraries, all of which use CMake as 
their build systems.


Now, it's my understanding that we still don't support use of CMake to 
build our external libraries. My question is, what do people think of 
adding support for CMake in our build system? Would that be too much 
effort and not worth it, or would it be worthwhile to add support for 
it, but so far it has not been anybody's priority, or ... ?


Please let me know what your opinions are.

As an aside, if someone wants to try out this experimental parquet 
import filter, one can build orcus independently with 
--with-parquet-filter passed to configure after also having built the 
apache arrow library, apply this change


https://github.com/kohei-us/core/commit/ae1390947246e44a6cd3d9b8af8c46b60619a698

then build libreoffice with --with-system-orcus.  Then you should be 
able to simply open a parquet file and Calc should open.


Kohei

[1] https://github.com/apache/arrow


Hi,

I would be happy to see work on Meson support continue and its CMake 
module should solve what you propose.

https://mesonbuild.com/CMake-module.html#cmake-module
"It also supports the usage of CMake based subprojects"

Ilmari

[Libreoffice-qa] Live streaming LibreOffice bug triaging (week 39)

[Ilmari Lauhakangas]

I will be live streaming a 1 hour LibreOffice bug triaging session in 
the Jitsi room https://jitsi.documentfoundation.org/ilmaritriages on


Tue, 26 September 2023 at 06:00 UTC
Wed, 27 September 2023 at 06:00 UTC
Thu, 28 September 2023 at 10:00 UTC

Times are in 24-hour notation.

Anyone is welcome to interrupt me during the session and ask questions 
about the process or request me to test something specific.


Note: if you want to record the session for your own use, ask me to make 
you a moderator and then you can click the "meatball menu" in Jitsi's 
bottom bar and select "Start recording". TDF members can become 
moderators simply by authenticating (Settings - Profile). Recording only 
works in Chrome and derivative browsers at the moment.


Ilmari

Re: LO 24.2 C++20 baseline

[Ilmari Lauhakangas]

On 22.9.2023 18.36, Andreas Mantke wrote:

Am 22.09.23 um 09:20 schrieb Stephan Bergmann:

I just submitted

"Bump baseline to C++20" to master.  I will let it sit like that for a
few more days, to see if anything breaks (Coverity? Linux distros'
needs? etc.), before cleaning up now-unnecessary `#if __cplusplus <
202002L` etc., and before potentially unleashing the rewriting Clang
plugin to mass-introduce uses of u""_ustr that I talked about
yesterday at 


"If I Had C++20".


> Hi Stephan,
>
> I tried to compile from master on openSUSE 15.4 without success yet. It
> complains about the compiler (the current tool chain is gcc 7).
>
> Regards,
> Andreas

You can upgrade to Leap 15.5 and compiling should work again:
https://build.opensuse.org/package/show/openSUSE:Leap:15.5:Update/gcc12

Ilmari