[Libreoffice-commits] core.git: Changes to 'refs/changes/12/1212/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/12/1212/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/59/1259/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/34/1334/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/22/1122/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/52/1052/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/69/1969/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/52/1052/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/56/6356/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/02/6602/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/11/1211/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/56/6356/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/02/6602/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/69/1969/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/46/1146/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/34/1334/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/29/6529/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/11/1211/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/29/6529/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/29/6529/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/10/1210/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/35/1335/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/21/1121/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/83/1083/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/00/1200/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/56/1556/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/56/1556/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/61/1261/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/00/1200/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/20/1520/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/58/6458/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/20/1520/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/58/6458/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/77/1977/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/20/1520/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/58/6458/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/30/1430/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/60/1260/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/pipe.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
New commits:
commit f6141d884b7a89a856a34dc93991dbe01ded0b6b
Author: José Guilherme Vanz v...@libreoffice.org
Date: Sat Nov 2 17:49:16 2013 -0200
fdo#71043 - Use STACK lint tool to clean code
The code is using a pointer without check if it is not null.
Change-Id: Icb2dcf8d41a35514e18a5881f59399951b3e0493
Reviewed-on: https://gerrit.libreoffice.org/6529
Tested-by: Caolán McNamara caol...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
diff --git a/sal/osl/unx/pipe.c b/sal/osl/unx/pipe.c
index e271e94..79e847e 100644
--- a/sal/osl/unx/pipe.c
+++ b/sal/osl/unx/pipe.c
@@ -98,6 +98,8 @@ oslPipe __osl_createPipeImpl()
oslPipe pPipeImpl;
pPipeImpl = (oslPipe)calloc(1, sizeof(struct oslPipeImpl));
+if (pPipeImpl == NULL)
+return NULL;
pPipeImpl-m_nRefCount =1;
pPipeImpl-m_bClosed = sal_False;
#if defined(LINUX)
@@ -230,7 +232,13 @@ oslPipe SAL_CALL osl_psz_createPipe(const sal_Char
*pszPipeName, oslPipeOptions
}
/* alloc memory */
-pPipe= __osl_createPipeImpl();
+pPipe = __osl_createPipeImpl();
+
+if (pPipe == NULL)
+{
+OSL_TRACE(__osl_createPipe socket failed);
+return NULL;
+}
/* create socket */
pPipe-m_Socket = socket(AF_UNIX, SOCK_STREAM, 0);
@@ -467,7 +475,7 @@ oslPipe SAL_CALL osl_acceptPipe(oslPipe pPipe)
else
{
/* alloc memory */
-pAcceptedPipe= __osl_createPipeImpl();
+pAcceptedPipe = __osl_createPipeImpl();
OSL_ASSERT(pAcceptedPipe);
if(pAcceptedPipe==NULL)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: starmath/source
starmath/source/edit.cxx | 10 ++ 1 file changed, 10 insertions(+) New commits: commit 67311738157bced7b49e94b24845091995edb142 Author: José Guilherme Vanz v...@libreoffice.org Date: Thu Nov 7 02:53:09 2013 -0200 fdo#65588 - Elements Dock: Scrollbar moves into input window This change solves the visual problem. But I don't think so this is the best solution Change-Id: I658f7a4182578e49644ae6de281f221499d61ad3 Reviewed-on: https://gerrit.libreoffice.org/6602 Reviewed-by: Marcos Souza marcos.souza@gmail.com Tested-by: Marcos Souza marcos.souza@gmail.com diff --git a/starmath/source/edit.cxx b/starmath/source/edit.cxx index e95e85f..ee8e05d 100644 --- a/starmath/source/edit.cxx +++ b/starmath/source/edit.cxx @@ -1033,7 +1033,17 @@ void SmEditWindow::InsertText(const OUString rText) if (aSelection.nStartPos 0 aCurrentFormula[nStartIndex - 1] != ' ') string = + string; +/* + fdo#65588 - Elements Dock: Scrollbar moves into input window + This change solves the visual problem. But I don't think so + this is the best solution. +*/ +pVScrollBar-Hide(); +pHScrollBar-Hide(); pEditView-InsertText(string); +AdjustScrollBars(); +pVScrollBar-Show(); +pHScrollBar-Show(); // Remember start of the selection and move the cursor there afterwards. aSelection.nEndPara = aSelection.nStartPara; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: avmedia/source connectivity/source
avmedia/source/gstreamer/gstframegrabber.cxx |4 +++-
avmedia/source/gstreamer/gstmanager.cxx |4 +++-
avmedia/source/gstreamer/gstplayer.cxx|4 +++-
avmedia/source/gstreamer/gstwindow.cxx|4 +++-
connectivity/source/commontools/ConnectionWrapper.cxx |3 ++-
5 files changed, 14 insertions(+), 5 deletions(-)
New commits:
commit 2bb5f4773cc73a13bcd1460c02bc33bb4e60225c
Author: José Guilherme Vanz v...@libreoffice.org
Date: Mon Oct 28 00:53:45 2013 -0200
fdo#54938: Convert to use cppu::supportsService
Change-Id: I5b8e08bad3d83b6df23127377c0700fcd27ff084
Signed-off-by: Stephan Bergmann sberg...@redhat.com
diff --git a/avmedia/source/gstreamer/gstframegrabber.cxx
b/avmedia/source/gstreamer/gstframegrabber.cxx
index 36a7365..63a29ca 100644
--- a/avmedia/source/gstreamer/gstframegrabber.cxx
+++ b/avmedia/source/gstreamer/gstframegrabber.cxx
@@ -20,6 +20,8 @@
#include gstframegrabber.hxx
#include gstplayer.hxx
+#include cppuhelper/supportsservice.hxx
+
#include gst/gstbuffer.h
#include gst/video/video.h
#include gst/video/gstvideosink.h
@@ -210,7 +212,7 @@ OUString SAL_CALL FrameGrabber::getImplementationName( )
sal_Bool SAL_CALL FrameGrabber::supportsService( const OUString ServiceName )
throw (uno::RuntimeException)
{
-return ServiceName == AVMEDIA_GST_FRAMEGRABBER_SERVICENAME;
+return cppu::supportsService(this, ServiceName);;
}
uno::Sequence OUString SAL_CALL FrameGrabber::getSupportedServiceNames()
diff --git a/avmedia/source/gstreamer/gstmanager.cxx
b/avmedia/source/gstreamer/gstmanager.cxx
index e23419f..a9aafca 100644
--- a/avmedia/source/gstreamer/gstmanager.cxx
+++ b/avmedia/source/gstreamer/gstmanager.cxx
@@ -17,6 +17,8 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include cppuhelper/supportsservice.hxx
+
#include gstmanager.hxx
#include gstplayer.hxx
@@ -82,7 +84,7 @@ OUString SAL_CALL Manager::getImplementationName( )
sal_Bool SAL_CALL Manager::supportsService( const OUString ServiceName )
throw (uno::RuntimeException)
{
-return ServiceName == AVMEDIA_GST_MANAGER_SERVICENAME;
+return cppu::supportsService(this, ServiceName);
}
//
--
diff --git a/avmedia/source/gstreamer/gstplayer.cxx
b/avmedia/source/gstreamer/gstplayer.cxx
index 14fecf3..201c2ef 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -19,6 +19,8 @@
#include math.h
+#include cppuhelper/supportsservice.hxx
+
#include rtl/string.hxx
#include vcl/syschild.hxx
@@ -711,7 +713,7 @@ OUString SAL_CALL Player::getImplementationName()
sal_Bool SAL_CALL Player::supportsService( const OUString ServiceName )
throw (uno::RuntimeException)
{
-return ServiceName == AVMEDIA_GST_PLAYER_SERVICENAME;
+return cppu::supportsService(this, ServiceName);
}
//
--
diff --git a/avmedia/source/gstreamer/gstwindow.cxx
b/avmedia/source/gstreamer/gstwindow.cxx
index f1d4a96..39da016 100644
--- a/avmedia/source/gstreamer/gstwindow.cxx
+++ b/avmedia/source/gstreamer/gstwindow.cxx
@@ -19,6 +19,8 @@
#include com/sun/star/awt/SystemPointer.hpp
+#include cppuhelper/supportsservice.hxx
+
#include gstwindow.hxx
#include gstplayer.hxx
@@ -228,7 +230,7 @@ OUString SAL_CALL Window::getImplementationName( )
sal_Bool SAL_CALL Window::supportsService( const OUString ServiceName )
throw (uno::RuntimeException)
{
-return ServiceName == AVMEDIA_GST_WINDOW_SERVICENAME;
+return cppu::supportsService(this, ServiceName);
}
uno::Sequence OUString SAL_CALL Window::getSupportedServiceNames( )
diff --git a/connectivity/source/commontools/ConnectionWrapper.cxx
b/connectivity/source/commontools/ConnectionWrapper.cxx
index 1287acf..3fc14b8 100644
--- a/connectivity/source/commontools/ConnectionWrapper.cxx
+++ b/connectivity/source/commontools/ConnectionWrapper.cxx
@@ -23,6 +23,7 @@
#include com/sun/star/lang/DisposedException.hpp
#include comphelper/uno3.hxx
#include comphelper/sequence.hxx
+#include cppuhelper/supportsservice.hxx
#include cppuhelper/typeprovider.hxx
#include com/sun/star/reflection/ProxyFactory.hpp
#include rtl/digest.h
@@ -133,7 +134,7 @@ OUString SAL_CALL
OConnectionWrapper::getImplementationName( ) throw (::com::su
//
sal_Bool SAL_CALL OConnectionWrapper::supportsService( const OUString
_rServiceName ) throw(::com::sun::star::uno::RuntimeException)
{
-return ::comphelper::findValue( getSupportedServiceNames(), _rServiceName,
sal_True ).getLength() != 0;
+return cppu::supportsService(this, _rServiceName);
}
//
Re: cppunit framework
Ok. Thank you for explanation. :-) On Oct 22, 2013 5:41 AM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey, On Mon, Oct 21, 2013 at 06:20:01PM -0200, José Guilherme Vanz v...@libreoffice.org wrote: has libo its own cppunit? I was thinking that it uses the old project of cppunit in the sourceforge.com Markus knows the details, but in short the new upstream is on freedesktop.org. So no, this is not our cppunit, even Debian plans to package from this tree, etc. OTOH yes, we can build our own cppunit during the build of LO, which is useful if the system cppunit is not built using debug STL, and LO is, for example. So more or less we are upstream now. Debian, Gentoo, Ubuntu (as Debian's downstream), Arch Linux, some BSD versions, ... already switched. We already maintained a number of patches that were not included into the upstream builds and fixed another set of problems since then. I explored different testing frameworks when we faced the decision whether to fork cppunit or switch to a different testing framework and decided that it is better to stay with cppunit. It is mature and well tested and except for a few nice to have features more or less what we need. Additionally switching testing frameworks requires to rewrite quite a large piece of our code base that is better spend improving the existing tests. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: cui/source editeng/source include/vcl sfx2/source sw/source vcl/source
cui/source/dialogs/SpellDialog.cxx | 15 +--
editeng/source/editeng/editview.cxx | 22 +-
include/vcl/image.hxx |1 +
sfx2/source/menu/mnumgr.cxx | 23 +--
sw/source/ui/lingu/olmenu.cxx | 22 +++---
vcl/source/gdi/image.cxx| 16
6 files changed, 23 insertions(+), 76 deletions(-)
New commits:
commit 288f0029c69ab0532165877637a146f774d5e740
Author: José Guilherme Vanz v...@libreoffice.org
Date: Sun Oct 20 01:43:00 2013 -0200
fdo#52622 - Reduce copy and paste code
This commit removes copy and paste code, creating a constructor for it
Change-Id: I7a66cfda7fc7c11308d155a7a890352fdacfaacc
Reviewed-on: https://gerrit.libreoffice.org/6356
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com
diff --git a/cui/source/dialogs/SpellDialog.cxx
b/cui/source/dialogs/SpellDialog.cxx
index 0686caf..d32a172 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -802,19 +802,6 @@ void SpellDialog::SetLanguage( sal_uInt16 nLang )
m_pLanguageLB-SelectLanguage( nLang );
}
-static Image lcl_GetImageFromPngUrl( const OUString rFileUrl )
-{
-Image aRes;
-OUString aTmp;
-osl::FileBase::getSystemPathFromFileURL( rFileUrl, aTmp );
-Graphic aGraphic;
-const OUString aFilterName( IMP_PNG );
-if( GRFILTER_OK == GraphicFilter::LoadGraphic( aTmp, aFilterName, aGraphic
) )
-{
-aRes = Image( aGraphic.GetBitmapEx() );
-}
-return aRes;
-}
void SpellDialog::SetTitle_Impl(LanguageType nLang)
{
OUString sTitle = rParent.HasGrammarChecking() ? m_sTitleSpellingGrammar :
m_sTitleSpelling;
@@ -876,7 +863,7 @@ int SpellDialog::InitUserDicts()
xSvcInfo-getImplementationName()) );
if (!aDictionaryImageUrl.isEmpty())
{
-Image aImage( lcl_GetImageFromPngUrl( aDictionaryImageUrl
) );
+Image aImage( aDictionaryImageUrl );
pMenu-SetItemImage( nItemId, aImage );
}
}
diff --git a/editeng/source/editeng/editview.cxx
b/editeng/source/editeng/editview.cxx
index 8f331c8..18b0c9a 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -862,26 +862,6 @@ sal_Bool EditView::IsWrongSpelledWordAtPos( const Point
rPosPixel, sal_Bool bMa
return pImpEditView-IsWrongSpelledWord( aPaM , bMarkIfWrong );
}
-
-static Image lcl_GetImageFromPngUrl( const OUString rFileUrl )
-{
-Image aRes;
-OUString aTmp;
-osl::FileBase::getSystemPathFromFileURL( rFileUrl, aTmp );
-//OString aPath = OString( aTmp.getStr(), aTmp.getLength(),
osl_getThreadTextEncoding() );
-#if defined(WNT)
-//aTmp = lcl_Win_GetShortPathName( aTmp );
-#endif
-Graphic aGraphic;
-const OUString aFilterName( IMP_PNG );
-if( GRFILTER_OK == GraphicFilter::LoadGraphic( aTmp, aFilterName, aGraphic
) )
-{
-aRes = Image( aGraphic.GetBitmapEx() );
-}
-return aRes;
-}
-
-
void EditView::ExecuteSpellPopup( const Point rPosPixel, Link* pCallBack )
{
DBG_CHKTHIS( EditView, 0 );
@@ -1036,7 +1016,7 @@ void EditView::ExecuteSpellPopup( const Point rPosPixel,
Link* pCallBack )
xSvcInfo-getImplementationName()) );
if (!aDictionaryImageUrl.isEmpty() )
{
-Image aImage( lcl_GetImageFromPngUrl(
aDictionaryImageUrl ) );
+Image aImage( aDictionaryImageUrl );
pInsertMenu-SetItemImage( nPos, aImage );
}
}
diff --git a/include/vcl/image.hxx b/include/vcl/image.hxx
index dc027f4..f7b34e7 100644
--- a/include/vcl/image.hxx
+++ b/include/vcl/image.hxx
@@ -58,6 +58,7 @@ public:
Image( const Bitmap rBitmap, const Bitmap rMaskBitmap );
Image( const Bitmap rBitmap, const Color rColor );
Image( const ::com::sun::star::uno::Reference
::com::sun::star::graphic::XGraphic rxGraphic );
+Image( const OUString rFileUrl );
~Image();
SizeGetSizePixel() const;
diff --git a/sfx2/source/menu/mnumgr.cxx b/sfx2/source/menu/mnumgr.cxx
index 23c917c..344834a 100644
--- a/sfx2/source/menu/mnumgr.cxx
+++ b/sfx2/source/menu/mnumgr.cxx
@@ -128,27 +128,6 @@ void InsertVerbs_Impl( SfxBindings* pBindings, const
com::sun::star::uno::Sequen
}
}
-
-//
-
-
-static Image lcl_GetImageFromPngUrl( const OUString rFileUrl )
-{
-Image aRes;
-
-OUString aTmp;
-osl::FileBase::getSystemPathFromFileURL( rFileUrl, aTmp );
-
-Graphic aGraphic;
-const OUString
cppunit framework
Hello, everybody! I was looking for some task to work on and I found this one: *Bug 48024* https://bugs.freedesktop.org/show_bug.cgi?id=48024 - Convert C++ unit test from JUnit to CppUnit Reading about cppunit I read this on its wiki: Notes: this wiki as been recently (December 2008) resurected from an old backup, so some information may be out of date. Why Libreoffice uses cppunit, considering that is abandoned project? Is legacy? Thank you! -- Att. José Guilherme Vanz br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/ O sofrimento é passageiro, desistir é para sempre - Bernardo Fonseca, recordista da Antarctic Ice Marathon. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Performance profiling
Hello everybody! The Brazilian comunity is in the FISL14. Today a Intel employee talked with me and Marcos Paulo looking for a test case for Intel performance profiling tool. He provided for us the tool that we can runs the Libreoffice and test it permofance, identifing problems. We talked about some problems importing some huge files in calc, problems reported in bugzilla. But are we interesting in your suggestions, maybe some specific. Do you have some ? Waiting anxiously for your suggestions. All the best! -- Att. José Guilherme Vanz br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/ O sofrimento é passageiro, desistir é para sempre - Bernardo Fonseca, recordista da Antarctic Ice Marathon. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Performance profiling tool
Hello everybody! The Brazilian comunity is in the FISL14. Today a Intel employee talked with me and Marcos Paulo looking for a test case for Intel performance profiling tool. He provided for us the tool that we can runs the Libreoffice and test it permofance, identifing problems. We talked about some problems importing some huge files in calc, problems reported in bugzilla. But are we interesting in your suggestions, maybe some specific. Do you have some ? Waiting anxiously for your suggestions. All the best! -- Att. José Guilherme Vanz br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/ O sofrimento é passageiro, desistir é para sempre - Bernardo Fonseca, recordista da Antarctic Ice Marathon. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: GSOC 2013
Can I try some of these ideias outside gsoc? hehe Thank you On 27 March 2013 13:45, Cedric Bosdonnat cedric.bosdonnat@free.frwrote: Hello José, On Wed, 2013-03-27 at 13:36 -0300, José Guilherme Vanz wrote: I'm interested to participate GSOC 2013. Looking the ideas in the wiki I found 3 that catched my attention. There are: Welcome then :) 1. Connection to SharePoint and/or Google Drive and/or Microsoft SkyDrive 2. More integration with Document Management Systems 3. Crash reporter service Link for wiki page I have some questions... On the first idea, I saw that Ngo Cao Cuong started the implementation for Google Drive ( I would like implement Google Drive integration ). This implementation started for him is almost done? He made pretty big progress on the Google Drive integration, so I guess there isn't room enough for two on this task. But the SharePoint protocol or SkyDrive implementation are still possible (for the SharePoint protocol implementation, you'll need to have an MSDN license). Do you have some tips for me? And I have an important doubt, I'm university and work with systems development. So my free time for implement this project will be weekends and during the nights. In your opinion, is enough? :x It's way too short as GSoC is meant to be a full-time job. That doesn't prevent you to participate in LibreOffice hacking outside GSoC though ;) Regards, -- Cedric -- Att. José Guilherme Vanz br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/ O sofrimento é passageiro, desistir é para sempre - Bernardo Fonseca, recordista da Antarctic Ice Marathon. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
GSOC 2013
Hi, Folk! I'm interested to participate GSOC 2013. Looking the ideas in the wiki I found 3 that catched my attention. There are: 1. Connection to SharePoint and/or Google Drive and/or Microsoft SkyDrive 2. More integration with Document Management Systems 3. Crash reporter service Link https://wiki.documentfoundation.org/Development/Gsoc/Ideas for wiki page I have some questions... On the first idea, I saw that Ngo Cao Cuong started the implementation for Google Drive ( I would like implement Google Drive integration ). This implementation started for him is almost done? Do you have some tips for me? And I have an important doubt, I'm university and work with systems development. So my free time for implement this project will be weekends and during the nights. In your opinion, is enough? :x Thank you a lot -- Att. José Guilherme Vanz br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/ O sofrimento é passageiro, desistir é para sempre - Bernardo Fonseca, recordista da Antarctic Ice Marathon. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
New laptop
Hi all Well, I would like to ask a tip for you. I have a dell vostro laptop, but I cannot use it for contribute in the LO project. The laptop turns off because of the temperature. So I can do my contributions only in my desktop PC. But I can use it only when I'm home. So, I wanna buy another laptop. Do you have some to indicate for me? Thank you -- Att. José Guilherme Vanz br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/ http://blog.pt-br.libreoffice.org/ https://groups.google.com/d/forum/openqg ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Bug #47065
Hi
I started work in this bug. I created the first simple source file, just
for test.
My doubt is, is necessary add my source file in some config file?
In my test I created a object of my thread in the docfile.cxx. Nothing
special...
When I build the module occours the following fail:
[build LNK] Library/libsfxlo.so
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/docfile.o: In function
`SfxMedium::LockOrigFileOnDemand(unsigned char, unsigned char)':
/home/vanz/gitroot/libo/sfx2/source/doc/docfile.cxx:1188: undefined
reference to `salhelper::Thread::launch()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/docfile.o: In function
`salhelper::Thread::operator delete(void*)':
/home/vanz/gitroot/libo/solver/unxlngx6.pro/inc/salhelper/thread.hxx:89:
undefined reference to `salhelper::SimpleReferenceObject::operator
delete(void*)'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/docfile.o: In function
`WatchFileThread::WatchFileThread(char const*)':
/home/vanz/gitroot/libo/sfx2/source/doc/watchfilethread.hxx:28: undefined
reference to `salhelper::Thread::Thread(char const*)'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/docfile.o: In function
`WatchFileThread::~WatchFileThread()':
/home/vanz/gitroot/libo/sfx2/source/doc/watchfilethread.hxx:25: undefined
reference to `salhelper::Thread::~Thread()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTV15WatchFileThread[_ZTV15WatchFileThread]+0x28):
undefined reference to `salhelper::Thread::run()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTV15WatchFileThread[_ZTV15WatchFileThread]+0x30):
undefined reference to `salhelper::Thread::onTerminated()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTV15WatchFileThread[_ZTV15WatchFileThread]+0x80):
undefined reference to `non-virtual thunk to salhelper::Thread::run()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTV15WatchFileThread[_ZTV15WatchFileThread]+0x88):
undefined reference to `non-virtual thunk to
salhelper::Thread::onTerminated()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTI15WatchFileThread[_ZTI15WatchFileThread]+0x10):
undefined reference to `typeinfo for salhelper::Thread'
collect2: error: ld returned 1 exit status
make[1]: *** [/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/LinkTarget/Library/libsfxlo.so] Error 1
make: *** [sfx2] Error 2
What is my error? The build creates a .so of the module ( [build LNK]
Library/libsfxlo.so ) ?
Thank you!
On 4 February 2013 11:35, Michael Stahl mst...@redhat.com wrote:
On 04/02/13 14:30, Jan Holesovsky wrote:
Regarding your question in the bug - LO has its own threading API, you
can use class Thread from sal/inc/osl/thread.hxx
http://cgit.freedesktop.org/libreoffice/core/tree/sal/inc/osl/thread.hxx
You basically want to derive your class SomeGoodNameThread: class Thread
{}; where you overload the virtual run(); method.
no, you should not derive from osl::Thread but instead from
salhelper::Thread which avoids some pitfalls automatically.
salhelper/inc/salhelper/thread.hxx
--
Att. José Guilherme Vanz
br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/
http://blog.pt-br.libreoffice.org/
https://groups.google.com/d/forum/openqg
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Bug #47065
Hi Markus
Yeap, your tip solved my problem.
Thank you for your explanation
All the best
:)
On 6 February 2013 23:24, Markus Mohrhard markus.mohrh...@googlemail.comwrote:
Hey,
2013/2/7 José Guilherme Vanz guilherme@gmail.com:
Hi
I started work in this bug. I created the first simple source file, just
for
test.
My doubt is, is necessary add my source file in some config file?
In my test I created a object of my thread in the docfile.cxx. Nothing
special...
When I build the module occours the following fail:
[build LNK] Library/libsfxlo.so
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/docfile.o:
In function `SfxMedium::LockOrigFileOnDemand(unsigned char, unsigned
char)':
/home/vanz/gitroot/libo/sfx2/source/doc/docfile.cxx:1188: undefined
reference to `salhelper::Thread::launch()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/docfile.o:
In function `salhelper::Thread::operator delete(void*)':
/home/vanz/gitroot/libo/solver/unxlngx6.pro/inc/salhelper/thread.hxx:89:
undefined reference to `salhelper::SimpleReferenceObject::operator
delete(void*)'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/docfile.o:
In function `WatchFileThread::WatchFileThread(char const*)':
/home/vanz/gitroot/libo/sfx2/source/doc/watchfilethread.hxx:28: undefined
reference to `salhelper::Thread::Thread(char const*)'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/docfile.o:
In function `WatchFileThread::~WatchFileThread()':
/home/vanz/gitroot/libo/sfx2/source/doc/watchfilethread.hxx:25: undefined
reference to `salhelper::Thread::~Thread()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTV15WatchFileThread[_ZTV15WatchFileThread]+0x28)
:
undefined reference to `salhelper::Thread::run()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTV15WatchFileThread[_ZTV15WatchFileThread]+0x30)
:
undefined reference to `salhelper::Thread::onTerminated()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTV15WatchFileThread[_ZTV15WatchFileThread]+0x80)
:
undefined reference to `non-virtual thunk to salhelper::Thread::run()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTV15WatchFileThread[_ZTV15WatchFileThread]+0x88)
:
undefined reference to `non-virtual thunk to
salhelper::Thread::onTerminated()'
/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/CxxObject/sfx2/source/doc/watchfilethread.o:(.data.rel.ro._ZTI15WatchFileThread[_ZTI15WatchFileThread]+0x10)
:
undefined reference to `typeinfo for salhelper::Thread'
collect2: error: ld returned 1 exit status
make[1]: ***
[/home/vanz/gitroot/libo/workdir/
unxlngx6.pro/LinkTarget/Library/libsfxlo.so]
Error 1
make: *** [sfx2] Error 2
What is my error? The build creates a .so of the module ( [build LNK]
Library/libsfxlo.so ) ?
Thank you!
On 4 February 2013 11:35, Michael Stahl mst...@redhat.com wrote:
On 04/02/13 14:30, Jan Holesovsky wrote:
Regarding your question in the bug - LO has its own threading API, you
can use class Thread from sal/inc/osl/thread.hxx
http://cgit.freedesktop.org/libreoffice/core/tree/sal/inc/osl/thread.hxx
You basically want to derive your class SomeGoodNameThread: class
Thread
{}; where you overload the virtual run(); method.
no, you should not derive from osl::Thread but instead from
salhelper::Thread which avoids some pitfalls automatically.
salhelper/inc/salhelper/thread.hxx
You should add salhelper to gb_Library_use_libraries in sfx2/Library_sfx.mk
It seems that sfx2 is not yet depending on salhelper but it looks like
there is no problem in linking against salhelper in sfx2. Since we are
not mentioning salhelper linking fails because it can't find the
symbols. I hope that helps you resolve your problems.
Regards,
Markus
--
Att. José Guilherme Vanz
br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/
http://blog.pt-br.libreoffice.org/
https://groups.google.com/d/forum/openqg
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build development environment
Hi! If the problem is dependencies, I think I have something can help you. Some time ago Marcos Paulo de Souza, Ricardo Montania and I prepared a shell script to use in the first hackday in Brazil. The .sh downloads all dependencies and prepare the local repository necessary for compile LO. You can find it in github: https://github.com/marcosps/lo_useful.git I tested in my Fedora 17 and ran fine. :D I hope helped you Thank you! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Bug #47065
Hi! I am interested to try to resolve the bug #47065https://bugs.freedesktop.org/show_bug.cgi?id=47065. It is assigned to Benoit, but I don't see any news since it was assigned. Can I try solve it? If Benoit give us a news, I won't do nothing. Thank you! -- Att. José Guilherme Vanz br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/ http://blog.pt-br.libreoffice.org/ https://groups.google.com/d/forum/openqg ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: oox/source
oox/source/mathml/importutils.cxx | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
New commits:
commit 1749eac1d0e7983a39c32ace9da429a74f95695d
Author: José Guilherme Vanz guilherme@gmail.com
Date: Sat Feb 2 18:23:45 2013 -0200
String cleanup in oox
Change-Id: Ib06b6defdb82c5d62be9cbd59f02827c07a320d8
Signed-off-by: José Guilherme Vanz guilherme@gmail.com
Reviewed-on: https://gerrit.libreoffice.org/1969
Reviewed-by: Norbert Thiebaud nthieb...@gmail.com
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
diff --git a/oox/source/mathml/importutils.cxx
b/oox/source/mathml/importutils.cxx
index d3c4782..5350d58 100644
--- a/oox/source/mathml/importutils.cxx
+++ b/oox/source/mathml/importutils.cxx
@@ -41,7 +41,6 @@
#define CLOSING( token ) XML_STREAM_CLOSING( token )
using namespace com::sun::star;
-using rtl::OUString;
namespace oox
{
@@ -117,7 +116,7 @@ OUString XmlStream::AttributeList::operator[] (int token)
rtl::OUString XmlStream::AttributeList::attribute( int token, const
rtl::OUString def ) const
{
-std::map int, rtl::OUString ::const_iterator find = attrs.find( token );
+std::map int, OUString ::const_iterator find = attrs.find( token );
if( find != attrs.end())
return find-second;
return def;
@@ -125,19 +124,19 @@ rtl::OUString XmlStream::AttributeList::attribute( int
token, const rtl::OUStrin
bool XmlStream::AttributeList::attribute( int token, bool def ) const
{
-std::map int, rtl::OUString ::const_iterator find = attrs.find( token );
+std::map int, OUString ::const_iterator find = attrs.find( token );
if( find != attrs.end())
{
-const rtl::OUString sValue = find-second;
-if(
sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(true)) ||
-
sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(on)) ||
-
sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(t)) ||
-
sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(1)) )
+const OUString sValue = find-second;
+if( sValue.equalsIgnoreAsciiCaseAscii(true) ||
+sValue.equalsIgnoreAsciiCaseAscii(on) ||
+sValue.equalsIgnoreAsciiCaseAscii(t) ||
+sValue.equalsIgnoreAsciiCaseAscii(1) )
return true;
-if(
sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(false)) ||
-
sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(off)) ||
-
sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(f)) ||
-
sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(0)) )
+if( sValue.equalsIgnoreAsciiCaseAscii(false) ||
+sValue.equalsIgnoreAsciiCaseAscii(off) ||
+sValue.equalsIgnoreAsciiCaseAscii(f) ||
+sValue.equalsIgnoreAsciiCaseAscii(0) )
return false;
SAL_WARN( oox.xmlstream, Cannot convert \' sValue \' to
bool. );
}
@@ -146,7 +145,7 @@ bool XmlStream::AttributeList::attribute( int token, bool
def ) const
sal_Unicode XmlStream::AttributeList::attribute( int token, sal_Unicode def )
const
{
-std::map int, rtl::OUString ::const_iterator find = attrs.find( token );
+std::map int, OUString ::const_iterator find = attrs.find( token );
if( find != attrs.end())
{
if( !find-second.isEmpty() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source
oox/source/ppt/extdrawingfragmenthandler.hxx |2 -
oox/source/ppt/pptfilterhelpers.hxx |2 -
oox/source/shape/ShapeContextHandler.cxx | 40 +++
oox/source/shape/ShapeContextHandler.hxx | 28
oox/source/shape/ShapeDrawingFragmentHandler.cxx |1
oox/source/shape/ShapeDrawingFragmentHandler.hxx |2 -
oox/source/shape/ShapeFilterBase.cxx |4 +-
oox/source/shape/ShapeFilterBase.hxx |2 -
oox/source/token/namespacemap.cxx|2 -
oox/source/token/propertynames.cxx |2 -
oox/source/token/tokenmap.cxx|5 --
oox/source/vml/vmldrawing.cxx|1
oox/source/vml/vmldrawingfragment.cxx|2 -
oox/source/vml/vmlformatting.cxx |2 -
oox/source/vml/vmlinputstream.cxx|3 -
oox/source/vml/vmlshape.cxx |4 --
oox/source/vml/vmlshapecontainer.cxx |2 -
oox/source/vml/vmlshapecontext.cxx |7 +---
oox/source/vml/vmltextbox.cxx|2 -
oox/source/vml/vmltextboxcontext.cxx |1
20 files changed, 47 insertions(+), 67 deletions(-)
New commits:
commit b48948201486c5367b5ff313cf49b56b4fa366ed
Author: José Guilherme Vanz guilherme@gmail.com
Date: Sun Feb 3 18:18:37 2013 -0200
String cleanup in oox
Change-Id: Ica69f655f3777fe37a51e313218ae12aa7d012a2
Signed-off-by: José Guilherme Vanz guilherme@gmail.com
Reviewed-on: https://gerrit.libreoffice.org/1977
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: Norbert Thiebaud nthieb...@gmail.com
diff --git a/oox/source/ppt/extdrawingfragmenthandler.hxx
b/oox/source/ppt/extdrawingfragmenthandler.hxx
index 3751e4d..9236f93 100644
--- a/oox/source/ppt/extdrawingfragmenthandler.hxx
+++ b/oox/source/ppt/extdrawingfragmenthandler.hxx
@@ -43,7 +43,7 @@ namespace oox { namespace ppt {
class ExtDrawingFragmentHandler : public ::oox::core::FragmentHandler
{
public:
-ExtDrawingFragmentHandler( oox::core::XmlFilterBase rFilter, const
::rtl::OUString rFragmentPath,
+ExtDrawingFragmentHandler( oox::core::XmlFilterBase rFilter, const
OUString rFragmentPath,
const oox::ppt::SlidePersistPtr pSlidePersistPtr,
const oox::ppt::ShapeLocation eShapeLocation,
oox::drawingml::ShapePtr pMasterShapePtr,
diff --git a/oox/source/ppt/pptfilterhelpers.hxx
b/oox/source/ppt/pptfilterhelpers.hxx
index 3924b2d..67efbbf 100644
--- a/oox/source/ppt/pptfilterhelpers.hxx
+++ b/oox/source/ppt/pptfilterhelpers.hxx
@@ -86,7 +86,7 @@ namespace oox { namespace ppt {
// BEGIN CUTPASTE from sd pptinanimation.cxx
-bool convertMeasure( ::rtl::OUString rString );
+bool convertMeasure( OUString rString );
// END CUTPASTE from sd pptinanimation.cxx
diff --git a/oox/source/shape/ShapeContextHandler.cxx
b/oox/source/shape/ShapeContextHandler.cxx
index 11bab21..6b62396 100644
--- a/oox/source/shape/ShapeContextHandler.cxx
+++ b/oox/source/shape/ShapeContextHandler.cxx
@@ -31,15 +31,15 @@ using namespace ::com::sun::star;
using namespace core;
using namespace drawingml;
-::rtl::OUString SAL_CALL ShapeContextHandler_getImplementationName()
+OUString SAL_CALL ShapeContextHandler_getImplementationName()
{
return OUString( com.sun.star.comp.oox.ShapeContextHandler );
}
-uno::Sequence ::rtl::OUString SAL_CALL
+uno::Sequence OUString SAL_CALL
ShapeContextHandler_getSupportedServiceNames()
{
-uno::Sequence ::rtl::OUString s(1);
+uno::Sequence OUString s(1);
s[0] = com.sun.star.xml.sax.FastShapeContextHandler;
return s;
}
@@ -154,8 +154,8 @@ void SAL_CALL ShapeContextHandler::startFastElement
const uno::Reference xml::sax::XFastAttributeList Attribs)
throw (uno::RuntimeException, xml::sax::SAXException)
{
-static const ::rtl::OUString sInputStream
-(RTL_CONSTASCII_USTRINGPARAM (InputStream));
+static const OUString sInputStream
+(InputStream);
uno::Sequencebeans::PropertyValue aSeq(1);
aSeq[0].Name = sInputStream;
@@ -170,7 +170,7 @@ void SAL_CALL ShapeContextHandler::startFastElement
if (!msRelationFragmentPath.isEmpty())
{
FragmentHandlerRef rFragmentHandler(new
ShapeFragmentHandler(*mxFilterBase, msRelationFragmentPath));
-rtl::OUString aThemeFragmentPath =
rFragmentHandler-getFragmentPathFromFirstType( CREATE_OFFICEDOC_RELATION_TYPE(
theme ) );
+OUString aThemeFragmentPath =
rFragmentHandler-getFragmentPathFromFirstType( CREATE_OFFICEDOC_RELATION_TYPE(
theme ) );
uno::Referencexml::sax::XFastSAXSerializable
xDoc(mxFilterBase-importFragment(aThemeFragmentPath), uno::UNO_QUERY_THROW);
mxFilterBase-importFragment(new
ThemeFragmentHandler(*mxFilterBase, aThemeFragmentPath, *mpThemePtr ), xDoc);
Re: Help with #fdo52622
2012/11/27 Marcos Souza marcos.souza@gmail.com Hi Michael! 2012/11/27 Michael Meeks michael.me...@suse.com Hi Marcos, On Tue, 2012-11-27 at 00:13 -0200, Marcos Souza wrote: After take a look in bugzilla, I reached a simple work: Remove duplicated code. Ah - so, by now this task is very nearly done and the remaining bits tend to be rather less easy than expected (compiled on different platforms). I suspect it might be a good time to close that bug / un-mark it as an easy-hack :-) Hum, OK :) On the other hand, there are many other really rather good easy hacks to be working on that have more impact. One in particular is the UI re-work to use better automated layout; you can read about it here: http://wiki.documentfoundation.org/Development/WidgetLayout That is a mix of hacking, and using glade to draw dialogs; interested ? :-) Yes, I'm! Olivier was talking about convert these dialogs. This Friday, we'll have our first LO HackDay in Brazil, so, if one of us(Me, Olivier, Ricardo or José Vanz) knows how to do at least one of this UI reworks, I belive we can do a very nice work, teaching the new devs, and converting some dialogs for all day along :) Thanks for the quick answer! Yes, Marcos! Let's do it ASAP! :) ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot -- Att, Marcos Paulo de Souza Acadêmico de Ciencia da Computação - FURB - SC Github: https://github.com/marcosps/ Uma vida sem desafios é uma vida sem razão A life without challenges, is a non reason life ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Att. José Guilherme Vanz Se você é capaz de tremer de indignação cada vez que se comete uma injustiça no mundo, então somos companheiros - Che Guevara ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Bug 46808
Hi, Everybody!
I'm analizing some things new to do and I started to do this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=46808
Well, When I was working in some sources I found something like this:
published service PropertySet
{
interface com::sun::star::beans::XPropertySet;
[optional] interface com::sun::star::beans::XFastPropertySet;
[optional] interface com::sun::star::beans::XMultiPropertySet;
[optional] interface com::sun::star::beans::XPropertyAccess;
[optional] interface com::sun::star::beans::XPropertyState;
};
The bug's description guides to do something like that:
service Foo { interface XBar; };
Transform for:
service Foo: XBar;
In this case, what I do with [optional] when transform for new style? Where
could I find more documentation of .idl files?
Thanks!!!
--
Att. José Guilherme Vanz
Se você é capaz de tremer de indignação cada vez que se comete uma
injustiça no mundo, então somos companheiros - Che Guevara
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code
Hi! I unterstood... Thanks for comment! I'll do more and better next time :-) 2012/10/1 Thorsten Behrens t...@documentfoundation.org guilherme@gmail.com wrote: This patch removes '@author' annotation, code in comments and adjust some empty catches. It's cleanup patch Hi José Guilherme, partially pushed - I left the hunks commenting empty methods as FIXME instead of removing them straight away unapplied. If the method is pointless, why not remove them in one go? I also did not apply your printStackTrace() logging calls, I think at least some of them report on exceptions that were seemingly previously ignored on purpose? Stephan, or anyone else more up-to-date with contemporary java idiom, any opinions here? Thanks for the nice cleanup anyways! :) Cheers, -- Thorsten -- Att. José Guilherme Vanz Se você é capaz de tremer de indignação cada vez que se comete uma injustiça no mundo, então somos companheiros - Che Guevara ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
license
All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL / LGPLv3+. José Guilherme Vanz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
