Re: [PUSHED] Remove unused methods from PDFI
Hi, On 20 February 2012 11:00, Michael Meeks michael.me...@suse.com wrote: On Sat, 2012-02-18 at 21:18 +, Kate Goss wrote: Quick question - Can anyone point me to list of supported browsers for the bug submission assistant? I don't believe we have one :-) but I would say - whatever makes most sense, ie. forget IE6, and anything else old that causes significant grief complexity ;-) There is little point in doing lots of heavy lifting for ancient browsers with small market share I think. Does that help ? Yes - thanks for that. I'll use that as a rule of thumb. Kate Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Remove unused methods from PDFI
Hi, Quick question - Can anyone point me to list of supported browsers for the bug submission assistant? Kate On 17 February 2012 23:11, Kate Goss katherine.g...@gmail.com wrote: On 17 February 2012 11:21, Thorsten Behrens t...@documentfoundation.orgwrote: Kate Goss wrote: Yes, he did - thanks Thorsten. Christian - if you are able to set me up with access, that would be lovely :) Hi Kate, glad you hear you want to look into this - first step is to clone the git repo git clone git://anongit.freedesktop.org/libreoffice/website (stay on the master branch) , and then look into the bug/ subdir. Please *do* ask questions! :) Thanks - I will look at this tomorrow. Expect questions! :) Kate Cheers, -- Thorsten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Remove unused methods from PDFI
On 17 February 2012 11:21, Thorsten Behrens t...@documentfoundation.orgwrote: Kate Goss wrote: Yes, he did - thanks Thorsten. Christian - if you are able to set me up with access, that would be lovely :) Hi Kate, glad you hear you want to look into this - first step is to clone the git repo git clone git://anongit.freedesktop.org/libreoffice/website (stay on the master branch) , and then look into the bug/ subdir. Please *do* ask questions! :) Thanks - I will look at this tomorrow. Expect questions! :) Kate Cheers, -- Thorsten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEWED] Remove unused (hopefully!) methods from l10ntools Export
Hi Michael, On 16 February 2012 11:00, Michael Meeks michael.me...@suse.com wrote: On Wed, 2012-02-15 at 20:34 +, Kate Goss wrote: Another patch to remove methods listed as unused in unusedcode.easy Gosh; sorry about this one too ! Caolan seemed to remove those yesterday himself. It looks like he re-generated the unusedcode.easy list too (from a compilation with gtk3 enabled) - so hopefully the list there is more accurate. It'd be best to pull-up to master I suspect, if you can ? I usually do - I tried yesterday but had some errors - the remote connection did not want to play, it seems. I'll try again. Sorry about that, Michael. No problem, Kate -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Remove unused methods from PDFI
Hi On 15 February 2012 13:38, Michael Meeks michael.me...@suse.com wrote: On Mon, 2012-02-13 at 19:48 +, Kate Goss wrote: I'm also contemplating tackling bugs in bugzilla assistant, if that would be helpful. Oh ! cool :-) yes very much so, Rainer has a number of tweaks and issues in there queued up for fixing if I remember correctly, it'd be just lovely to have someone to own and help maintain that beastie. I suspect you'll need to get access to the page from the website team too, perhaps Christian can get you setup, I believe Thorsten pointed you at the git repository. Yes, he did - thanks Thorsten. Christian - if you are able to set me up with access, that would be lovely :) Kate This would be most valuable, there is a lot of improvement possible there, from translation, through better instructions for subsetting documents to the minimum necessary to show the bug, to improving the authentication synchronisation ;-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused (hopefully!) methods from l10ntools Export
Hi, Another patch to remove methods listed as unused in unusedcode.easy Kate From e1934638ebc6f8456921c3b371997e878b414b28 Mon Sep 17 00:00:00 2001 From: Kate Goss katherine.g...@gmail.com Date: Wed, 15 Feb 2012 20:19:18 + Subject: [PATCH] Remove unused code from l10ntools Export Remove getCurrentDir( std::string dir ); Remove GetNativeFile( rtl::OString const sSource ); --- l10ntools/inc/export.hxx |3 --- l10ntools/source/export2.cxx | 18 -- unusedcode.easy |2 -- 3 files changed, 0 insertions(+), 23 deletions(-) diff --git a/l10ntools/inc/export.hxx b/l10ntools/inc/export.hxx index 5e08239..8866cbe 100644 --- a/l10ntools/inc/export.hxx +++ b/l10ntools/inc/export.hxx @@ -317,9 +317,6 @@ public: static void Languages( std::vectorrtl::OString::const_iterator begin , std::vectorrtl::OString::const_iterator end ); static rtl::OString getRandomName(const rtl::OString rPrefix, const rtl::OString sPostfix); -static void getCurrentDir( std::string dir ); - -static rtl::OString GetNativeFile( rtl::OString const sSource ); static void DumpExportList(const rtl::OString rListName, ExportList aList); diff --git a/l10ntools/source/export2.cxx b/l10ntools/source/export2.cxx index 1a1ae91..1c0681c 100644 --- a/l10ntools/source/export2.cxx +++ b/l10ntools/source/export2.cxx @@ -335,14 +335,6 @@ void Export::InitForcedLanguages( bool bMergeMode ){ while ( nIndex = 0 ); } -/*/ -rtl::OString Export::GetNativeFile( rtl::OString const sSource ) -/*/ -{ -//TODO: Drop this completely unless line end conversion *is* an issue -return sSource; -} - const char* Export::GetEnv( const char *pVar ) { char *pRet = getenv( pVar ); @@ -351,16 +343,6 @@ const char* Export::GetEnv( const char *pVar ) return pRet; } -void Export::getCurrentDir( std::string dir ) -{ -char buffer[64000]; -if( getcwd( buffer , sizeof( buffer ) ) == 0 ){ -std::cerr Error: getcwd failed!\n; -exit( -1 ); -} -dir = std::string( buffer ); -} - // Stolen from sal/osl/unx/tempfile.c diff --git a/unusedcode.easy b/unusedcode.easy index f5d4b3e..ec07a43 100755 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -24,8 +24,6 @@ CharPosArray::Replace(int const*, unsigned short, unsigned short) CharPosArray::_ForEach(unsigned short, unsigned short, unsigned char (*)(int const, void*), void*) Dialog::Dialog(Window*, ResId const) DirEntry::SetBase(String const, char) -Export::GetNativeFile(rtl::OString const) -Export::getCurrentDir(std::basic_stringchar, std::char_traitschar, std::allocatorchar ) FileStream::FileStream(rtl::OString const, FileAccessMode) FmEntryDataArray::DeleteAndDestroy(unsigned short, unsigned short) FmEntryDataArray::Insert(FmEntryData* const, unsigned short) -- 1.7.9 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code from gtkframe
Hi, Please find attached a patch to remove a couple of methods listed in unusedcode.easy, from gtkframe. Kate From 85b2e98cb31fc7d8968136bf91c01b5589e7a0dd Mon Sep 17 00:00:00 2001 From: Kate Goss katherine.g...@gmail.com Date: Tue, 14 Feb 2012 21:10:14 + Subject: [PATCH] Remove unused methods from gtkframe Remove GtkSalFrame::popIgnoreDamage() and GtkSalFrame::pushIgnoreDamage() --- unusedcode.easy |2 -- vcl/inc/unx/gtk/gtkframe.hxx|2 -- vcl/unx/gtk/window/gtkframe.cxx | 14 -- 3 files changed, 0 insertions(+), 18 deletions(-) diff --git a/unusedcode.easy b/unusedcode.easy index f1476f8..f5d4b3e 100755 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -40,8 +40,6 @@ FontStyleBox::FontStyleBox(Window*, long) FormattedField::SetValidateText(String const, String const*) FuncData::FuncData(rtl::OUString const) GraphCtrl::GraphCtrl(Window*, long) -GtkSalFrame::popIgnoreDamage() -GtkSalFrame::pushIgnoreDamage() HTMLControls::Insert(HTMLControl const*, unsigned short) HTMLControls::Insert(HTMLControl const**, unsigned short) HTMLControls::Insert(HTMLControls const*, unsigned short, unsigned short) diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx index 1d84ca2..c59fcde 100644 --- a/vcl/inc/unx/gtk/gtkframe.hxx +++ b/vcl/inc/unx/gtk/gtkframe.hxx @@ -326,8 +326,6 @@ public: void updateScreenNumber(); // only for gtk3 ... -void pushIgnoreDamage(); -void popIgnoreDamage(); #if GTK_CHECK_VERSION(3,0,0) void renderArea( cairo_t *cr, cairo_rectangle_t *src ); #endif diff --git a/vcl/unx/gtk/window/gtkframe.cxx b/vcl/unx/gtk/window/gtkframe.cxx index e4856bd..e320ca8 100644 --- a/vcl/unx/gtk/window/gtkframe.cxx +++ b/vcl/unx/gtk/window/gtkframe.cxx @@ -2994,20 +2994,6 @@ gboolean GtkSalFrame::signalCrossing( GtkWidget*, GdkEventCrossing* pEvent, gpoi return sal_True; } -void GtkSalFrame::pushIgnoreDamage() -{ -#if GTK_CHECK_VERSION(3,0,0) -m_nDuringRender++; -#endif -} - -void GtkSalFrame::popIgnoreDamage() -{ -#if GTK_CHECK_VERSION(3,0,0) -m_nDuringRender--; -#endif -} - void GtkSalFrame::damaged (const basegfx::B2IBox rDamageRect) { #if !GTK_CHECK_VERSION(3,0,0) -- 1.7.9 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License Statement
Hi all, for reference: All contributions past, present and future made by me to LibreOffice are available under the terms of the MPL / LGPLv3+. Best Regards, Kate Goss ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Remove unused methods from PDFI
Hi Michael, On 13 February 2012 15:22, Michael Meeks michael.me...@suse.com wrote: Hi Kate, On Sat, 2012-02-11 at 17:37 +, kate goss wrote: Made available under the MPL/LGPLv3+ They look lovely - thanks for that ! :-) Welcome to the project. Incidentally, it'd be quite useful to have a blanket license mail for your contributions we can link into here: http://wiki.documentfoundation.org/Development/Developers Thanks for the welcome - I have sent a blanket license mail to the list. Do you have any pet peeves that you'd like to hack on ? :-) are the easy hacks tempting ? or perhaps you're happy with unusedcode ? The easy hacks do look tempting, but I am new to free software contributing, and also to git, so I'm getting up to speed on unused code as a starting point! I enjoyed the 'easy hacks' talk you gave at FOSDEM, which inspired me to join in. I'm also contemplating tackling bugs in bugzilla assistant, if that would be helpful. All the best, -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot Michael. Best regards, Kate. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code from connectivity::odbc
Hi, Please see attached. Best Regards, Kate Goss From 099415fb77eddd7d211ae6ed547cb31b10484a37 Mon Sep 17 00:00:00 2001 From: Kate Goss katherine.g...@gmail.com Date: Sun, 12 Feb 2012 13:57:46 + Subject: [PATCH 1/2] Remove unused method ODatabaseMetaDataResultSet::openTablesTypes( ) --- .../odbcbase/ODatabaseMetaDataResultSet.cxx| 17 - .../source/inc/odbc/ODatabaseMetaDataResultSet.hxx |1 - unusedcode.easy|1 - 3 files changed, 0 insertions(+), 19 deletions(-) diff --git a/connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx b/connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx index 6dd7881..64e9409 100644 --- a/connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx +++ b/connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx @@ -896,24 +896,7 @@ void ODatabaseMetaDataResultSet::openTables(const Any catalog, const ::rtl::OUS checkColumnCount(); } -//- -void ODatabaseMetaDataResultSet::openTablesTypes( ) throw(SQLException, RuntimeException) -{ -m_bFreeHandle = sal_True; -SQLRETURN nRetcode = N3SQLTables(m_aStatementHandle, -0,0, -0,0, -0,0, -(SDB_ODBC_CHAR *) SQL_ALL_TABLE_TYPES,SQL_NTS); -OTools::ThrowException(m_pConnection,nRetcode,m_aStatementHandle,SQL_HANDLE_STMT,*this); -m_aColMapping.clear(); -m_aColMapping.push_back(-1); -m_aColMapping.push_back(4); -m_xMetaData = new OResultSetMetaData(m_pConnection,m_aStatementHandle,m_aColMapping); -checkColumnCount(); -} -// - void ODatabaseMetaDataResultSet::openCatalogs() throw(SQLException, RuntimeException) { m_bFreeHandle = sal_True; diff --git a/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx b/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx index 7a17249..56130be 100644 --- a/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx +++ b/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx @@ -204,7 +204,6 @@ namespace connectivity const ::connectivity::TIntVector getColumnMapping() { return m_aColMapping; } -void openTablesTypes( ) throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); void openTypeInfo() throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); void openCatalogs() throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); void openSchemas() throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); diff --git a/unusedcode.easy b/unusedcode.easy index 9a40c2f..e4e6714 100755 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -1175,7 +1175,6 @@ connectivity::mozab::OCatalog::getDot() connectivity::mozab::OPreparedStatement::checkParameterIndex(int) connectivity::mozab::OResultSet::initializeRow(rtl::Referenceconnectivity::ODeleteVectorconnectivity::ORowSetValue , int) connectivity::mozab::OTable::OTable(connectivity::sdbcx::OCollection*, connectivity::mozab::OConnection*) -connectivity::odbc::ODatabaseMetaDataResultSet::openTablesTypes() connectivity::odbc::OPreparedStatement::getDataBuf(int) connectivity::odbc::OPreparedStatement::getParamLength(int) connectivity::odbc::OPreparedStatement::getPrecision(int) -- 1.7.9 From 43f49e146696d38358891638c53a95de4e7667de Mon Sep 17 00:00:00 2001 From: Kate Goss katherine.g...@gmail.com Date: Mon, 13 Feb 2012 21:53:08 + Subject: [PATCH 2/2] Remove unused code from connectivity::odbc::OPreparedStatement Remove methods getDataBuf(int), getParamLength(int), getPrecision(int). --- .../source/drivers/odbcbase/OPreparedStatement.cxx | 77 .../source/inc/odbc/OPreparedStatement.hxx |4 - unusedcode.easy|3 - 3 files changed, 0 insertions(+), 84 deletions(-) diff --git a/connectivity/source/drivers/odbcbase/OPreparedStatement.cxx b/connectivity/source/drivers/odbcbase/OPreparedStatement.cxx index 2dbde52..b47fe2f1 100644 --- a/connectivity/source/drivers/odbcbase/OPreparedStatement.cxx +++ b/connectivity/source/drivers/odbcbase/OPreparedStatement.cxx @@ -675,27 +675,6 @@ sal_Int8* OPreparedStatement::allocBindBuf( sal_Int32 index,sal_Int32 bufLen) // - // -// getDataBuf -// Gets the data buffer for the given parameter index -// - -sal_Int8* OPreparedStatement::getDataBuf (sal_Int32 index) -{ -sal_Int8* b = NULL; - -// Sanity check the parameter
[PATCH] Remove unused methods from PDFI
Made available under the MPL/LGPLv3+ From 4e1c72fa61e3e8d754ff3e47afe435286dcf467b Mon Sep 17 00:00:00 2001 From: Kate Goss katherine.g...@gmail.com Date: Sat, 11 Feb 2012 16:31:27 + Subject: [PATCH 1/3] Remove unused pdfi::DrawXmlEmitter::GetBreakIterator() --- sdext/source/pdfimport/tree/drawtreevisiting.cxx | 12 sdext/source/pdfimport/tree/drawtreevisiting.hxx |1 - unusedcode.easy |1 - 3 files changed, 0 insertions(+), 14 deletions(-) diff --git a/sdext/source/pdfimport/tree/drawtreevisiting.cxx b/sdext/source/pdfimport/tree/drawtreevisiting.cxx index fd08894..2913878 100644 --- a/sdext/source/pdfimport/tree/drawtreevisiting.cxx +++ b/sdext/source/pdfimport/tree/drawtreevisiting.cxx @@ -68,18 +68,6 @@ const ::com::sun::star::uno::Reference ::com::sun::star::i18n::XBreakIterator return mxBreakIter; } -const ::com::sun::star::uno::Reference ::com::sun::star::i18n::XBreakIterator DrawXmlEmitter::GetBreakIterator() -{ -if ( !mxBreakIter.is() ) -{ -Reference XComponentContext xContext( m_rEmitContext.m_xContext, uno::UNO_SET_THROW ); -Reference XMultiComponentFactory xMSF( xContext-getServiceManager(), uno::UNO_SET_THROW ); -Reference XInterface xInterface = xMSF-createInstanceWithContext(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.i18n.BreakIterator)), xContext); -mxBreakIter = uno::Reference i18n::XBreakIterator ( xInterface, uno::UNO_QUERY ); -} -return mxBreakIter; -} - const ::com::sun::star::uno::Reference ::com::sun::star::i18n::XCharacterClassification DrawXmlEmitter::GetCharacterClassification() { if ( !mxCharClass.is() ) diff --git a/sdext/source/pdfimport/tree/drawtreevisiting.hxx b/sdext/source/pdfimport/tree/drawtreevisiting.hxx index e957448..eb9bc23 100644 --- a/sdext/source/pdfimport/tree/drawtreevisiting.hxx +++ b/sdext/source/pdfimport/tree/drawtreevisiting.hxx @@ -107,7 +107,6 @@ namespace pdfi ); public: -const ::com::sun::star::uno::Reference ::com::sun::star::i18n::XBreakIterator GetBreakIterator(); const ::com::sun::star::uno::Reference ::com::sun::star::i18n::XCharacterClassification GetCharacterClassification(); enum DocType{ DRAW_DOC, IMPRESS_DOC }; explicit DrawXmlEmitter(EmitContext rEmitContext, DocType eDocType, PDFIProcessor rProc ) : diff --git a/unusedcode.easy b/unusedcode.easy index 0b128a6..3e65bce 100755 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -1386,7 +1386,6 @@ oox::xls::WorksheetHelper::getRow(int) const oox::xls::WorksheetHelper::getRows(oox::ValueRange const) const oox::xls::WorksheetHelper::putFormulaString(com::sun::star::table::CellAddress const, rtl::OUString const) const oox::xls::Xf::hasAnyUsedFlags() const -pdfi::DrawXmlEmitter::GetBreakIterator() pdfi::PDFIProcessor::sortDocument(bool) pdfi::PDFIRawAdaptor::odfConvert(rtl::OUString const, com::sun::star::uno::Referencecom::sun::star::io::XOutputStream const, com::sun::star::uno::Referencecom::sun::star::task::XStatusIndicator const) psp::GetCommandLineTokenCount(rtl::OString const) -- 1.7.9 From 481c35cf2b6cc3a0c0f1914a265544619d75010e Mon Sep 17 00:00:00 2001 From: Kate Goss katherine.g...@gmail.com Date: Sat, 11 Feb 2012 16:44:09 + Subject: [PATCH 2/3] Remove unused pdfi::PDFIProcessor::sortDocument(bool) --- sdext/source/pdfimport/tree/pdfiprocessor.cxx | 10 -- sdext/source/pdfimport/tree/pdfiprocessor.hxx |1 - unusedcode.easy |1 - 3 files changed, 0 insertions(+), 12 deletions(-) diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.cxx b/sdext/source/pdfimport/tree/pdfiprocessor.cxx index 2e933e5..985e5f0 100644 --- a/sdext/source/pdfimport/tree/pdfiprocessor.cxx +++ b/sdext/source/pdfimport/tree/pdfiprocessor.cxx @@ -908,16 +908,6 @@ void PDFIProcessor::endIndicator() m_xStatusIndicator-end(); } -void PDFIProcessor::sortDocument( bool bDeep ) -{ -for( std::list Element* ::iterator it = m_pDocument-Children.begin(); - it != m_pDocument-Children.end(); ++it ) -{ -if( dynamic_castPageElement*(*it) != NULL ) -sortElements( *it, bDeep ); -} -} - static bool lr_tb_sort( Element* pLeft, Element* pRight ) { // first: top-bottom sorting diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.hxx b/sdext/source/pdfimport/tree/pdfiprocessor.hxx index 349a4a9..314988d 100644 --- a/sdext/source/pdfimport/tree/pdfiprocessor.hxx +++ b/sdext/source/pdfimport/tree/pdfiprocessor.hxx @@ -109,7 +109,6 @@ namespace pdfi sal_Int32 getFontId( const FontAttributes rAttr ) const; void sortElements( Element* pElement, bool bDeep = false ); -void sortDocument( bool bDeep = false ); rtl::OUString mirrorString( const rtl::OUString i_rInString ); diff --git a/unusedcode.easy b/unusedcode.easy index 3e65bce..b3a6ddd 100755 --- a/unusedcode.easy +++ b