from:"Lionel Elie Mamane \(via Code Review\)"

[PATCH] fdo#67235 adapt form control code to time nanosecond API cha...

2013-08-04 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/5270

to look at the new patch set (#2).

Change subject: fdo#67235 adapt form control code to time nanosecond API 
change, step 3
..

fdo#67235 adapt form control code to time nanosecond API change, step 3

Change-Id: I4899c89ee5b2a54c9c05b531ab284365f1558e3d
---
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M forms/source/component/Date.cxx
M forms/source/component/Time.cxx
M framework/source/services/license.cxx
M include/toolkit/awt/vclxwindows.hxx
M include/toolkit/controls/unocontrolbase.hxx
M include/toolkit/controls/unocontrols.hxx
M include/toolkit/helper/property.hxx
M include/tools/date.hxx
M include/tools/time.hxx
M odk/examples/DevelopersGuide/GUI/UnoDialogSample.java
M offapi/com/sun/star/awt/UnoControlDateFieldModel.idl
M offapi/com/sun/star/awt/UnoControlTimeFieldModel.idl
M offapi/com/sun/star/awt/XDateField.idl
M offapi/com/sun/star/awt/XTimeField.idl
M offapi/type_reference/offapi.rdb
M qadevOOo/tests/java/ifc/awt/_XDateField.java
M qadevOOo/tests/java/ifc/awt/_XTimeField.java
M svx/source/fmcomp/gridcell.cxx
M svx/source/form/fmobjfac.cxx
M toolkit/source/awt/vclxwindows.cxx
M toolkit/source/controls/unocontrolbase.cxx
M toolkit/source/controls/unocontrolmodel.cxx
M toolkit/source/controls/unocontrols.cxx
M toolkit/source/helper/property.cxx
M tools/source/datetime/ttime.cxx
M xmloff/source/forms/handler/vcl_date_handler.cxx
M xmloff/source/forms/handler/vcl_time_handler.cxx
29 files changed, 368 insertions(+), 367 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/5270/2
-- 
To view, visit https://gerrit.libreoffice.org/5270
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4899c89ee5b2a54c9c05b531ab284365f1558e3d
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Petr Mladek pmla...@suse.cz
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#67235 adapt form control code to time nanosecond API cha...

2013-08-04 Thread Lionel Elie Mamane (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5270

Approvals:
  Lionel Elie Mamane: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5270
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4899c89ee5b2a54c9c05b531ab284365f1558e3d
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Petr Mladek pmla...@suse.cz
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#67235 adapt form control code to time nanosecond API cha...

2013-08-02 Thread Lionel Elie Mamane (via Code Review)

Lionel Elie Mamane has created a new patch set by issuing a rebase in Gerrit 
(#2).

Change subject: fdo#67235 adapt form control code to time nanosecond API change
..

fdo#67235 adapt form control code to time nanosecond API change

Conflicts:
offapi/type_reference/offapi.rdb

Change-Id: If68ecf0691919d71d06d7b97d46db115013f9805
---
M include/toolkit/awt/vclxwindows.hxx
M include/toolkit/controls/unocontrolbase.hxx
M include/toolkit/controls/unocontrols.hxx
M include/toolkit/helper/property.hxx
M offapi/com/sun/star/awt/XTimeField.idl
M offapi/type_reference/offapi.rdb
M qadevOOo/tests/java/ifc/awt/_XTimeField.java
M svx/source/fmcomp/gridcell.cxx
M svx/source/form/fmobjfac.cxx
M toolkit/source/awt/vclxwindows.cxx
M toolkit/source/controls/unocontrolbase.cxx
M toolkit/source/controls/unocontrolmodel.cxx
M toolkit/source/controls/unocontrols.cxx
M toolkit/source/helper/property.cxx
M vcl/source/control/field2.cxx
M xmloff/source/forms/handler/vcl_time_handler.cxx
16 files changed, 155 insertions(+), 150 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/5149/2
-- 
To view, visit https://gerrit.libreoffice.org/5149
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If68ecf0691919d71d06d7b97d46db115013f9805
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Petr Mladek pmla...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#67235 adapt form control code to time nanosecond API cha...

2013-08-02 Thread Lionel Elie Mamane (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5149

Approvals:
  Lionel Elie Mamane: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5149
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If68ecf0691919d71d06d7b97d46db115013f9805
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Petr Mladek pmla...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.

2013-07-14 Thread Lionel Elie Mamane (via Code Review)

Lionel Elie Mamane has uploaded a new patch set (#3).

Change subject: i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.
..

i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.

Add IsUTC member to:

com.sun.star.util.DateTime
com.sun.star.util.DateTimeRange
com.sun.star.util.Time

Add new stucts with explicit time zones:

com.sun.star.util.DateTimeWithTimeZone
com.sun.star.util.DateWithTimeZone
com.sun.star.util.TimeWithTimeZone

Adapt the sax::Converter to read/write timezones, and fix the unit test.

Everything else just uses default (no time zone), this commit is just
to fix the API.

Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18
STRUCT: /UCR/com/sun/star/util/DateTime
nFields1 = 7  !=  nFields2 = 8
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/DateTimeRange
nFields1 = 14  !=  nFields2 = 15
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/Time
nFields1 = 4  !=  nFields2 = 5
Registry2 contains 1 more fields
---
M comphelper/source/misc/anycompare.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M forms/source/xforms/convert.cxx
M offapi/UnoApi_offapi.mk
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
A offapi/com/sun/star/util/DateTimeWithTimeZone.idl
A offapi/com/sun/star/util/DateWithTimeZone.idl
M offapi/com/sun/star/util/Time.idl
A offapi/com/sun/star/util/TimeWithTimeZone.idl
M offapi/type_reference/offapi.rdb
M oox/source/docprop/docprophandler.cxx
M qadevOOo/tests/java/ifc/sdbc/_XParameters.java
M reportdesign/source/core/sdr/RptObject.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/source/filter/oox/unitconverter.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/filter/ww8/ww8par.cxx
M toolkit/source/controls/unocontrols.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M ucb/source/ucp/gio/gio_content.cxx
M unotools/source/misc/datetime.cxx
M writerfilter/source/rtftok/rtfdocumentimpl.cxx
M xmloff/source/chart/SchXMLExport.cxx
40 files changed, 446 insertions(+), 109 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/4833/3
-- 
To view, visit https://gerrit.libreoffice.org/4833
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Eike Rathke er...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Michael Stahl mst...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.

2013-07-14 Thread Lionel Elie Mamane (via Code Review)

Lionel Elie Mamane has uploaded a new patch set (#4).

Change subject: i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.
..

i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.

Add IsUTC member to:

com.sun.star.util.DateTime
com.sun.star.util.DateTimeRange
com.sun.star.util.Time

Add new stucts with explicit time zones:

com.sun.star.util.DateTimeWithTimezone
com.sun.star.util.DateWithTimezone
com.sun.star.util.TimeWithTimezone

Adapt the sax::Converter to read/write timezones, and fix the unit test.

Everything else just uses default (no time zone), this commit is just
to fix the API.

Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18
STRUCT: /UCR/com/sun/star/util/DateTime
nFields1 = 7  !=  nFields2 = 8
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/DateTimeRange
nFields1 = 14  !=  nFields2 = 15
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/Time
nFields1 = 4  !=  nFields2 = 5
Registry2 contains 1 more fields
---
M comphelper/source/misc/anycompare.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M forms/source/xforms/convert.cxx
M offapi/UnoApi_offapi.mk
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
A offapi/com/sun/star/util/DateTimeWithTimezone.idl
A offapi/com/sun/star/util/DateWithTimezone.idl
M offapi/com/sun/star/util/Time.idl
A offapi/com/sun/star/util/TimeWithTimezone.idl
M offapi/type_reference/offapi.rdb
M oox/source/docprop/docprophandler.cxx
M qadevOOo/tests/java/ifc/sdbc/_XParameters.java
M reportdesign/source/core/sdr/RptObject.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/source/filter/oox/unitconverter.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/filter/ww8/ww8par.cxx
M toolkit/source/controls/unocontrols.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M ucb/source/ucp/gio/gio_content.cxx
M unotools/source/misc/datetime.cxx
M writerfilter/source/rtftok/rtfdocumentimpl.cxx
M xmloff/source/chart/SchXMLExport.cxx
40 files changed, 446 insertions(+), 109 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/4833/4
-- 
To view, visit https://gerrit.libreoffice.org/4833
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Eike Rathke er...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Michael Stahl mst...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-1] Revert fdo#65653, fdo#65619, fdo#65216: Missing check

2013-06-18 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4337

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/4337/1

Revert fdo#65653, fdo#65619, fdo#65216: Missing check

This reverts commit 10777b37536be16c6d2e167b59e9e31e37ba3517.

The problem has been fixed in a more safe way by making columnMatchP
treat the case where rParam.xField is not set instead of requiring
it from all callers.

Change-Id: Ic68a764e08446a7b669c6030c2bcd55c7d31772b
---
M connectivity/source/parse/sqlnode.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/connectivity/source/parse/sqlnode.cxx 
b/connectivity/source/parse/sqlnode.cxx
index bcc72fc..07c2daf 100644
--- a/connectivity/source/parse/sqlnode.cxx
+++ b/connectivity/source/parse/sqlnode.cxx
@@ -755,7 +755,7 @@
 SQLParseNodeParameter aNewParam(rParam);
 //aNewParam.bQuote = sal_True; // why setting this to true? @see 
http://www.openoffice.org/issues/show_bug.cgi?id=75557
 
-if (bSimple  (!rParam.xField.is() || !columnMatchP(m_aChildren[0], 
rParam)))
+if (bSimple  !columnMatchP(m_aChildren[0], rParam))
 m_aChildren[0]-impl_parseNodeToString_throw( rString, aNewParam, 
bSimple );
 
 const OSQLParseNode* pPart2 = m_aChildren[1];

-- 
To view, visit https://gerrit.libreoffice.org/4337
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic68a764e08446a7b669c6030c2bcd55c7d31772b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-1] Revert fdo#65653, fdo#65619, fdo#65216: Missing check

2013-06-18 Thread Lionel Elie Mamane (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4337


-- 
To view, visit https://gerrit.libreoffice.org/4337
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic68a764e08446a7b669c6030c2bcd55c7d31772b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-1] fdo#65653 make columnMatchP safer

2013-06-18 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4338

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/4338/1

fdo#65653 make columnMatchP safer

Change-Id: Id994ab5aed6172d8a93fd331a366fca10a663a48
---
M connectivity/source/parse/sqlnode.cxx
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/connectivity/source/parse/sqlnode.cxx 
b/connectivity/source/parse/sqlnode.cxx
index f0590c1..272deb1 100644
--- a/connectivity/source/parse/sqlnode.cxx
+++ b/connectivity/source/parse/sqlnode.cxx
@@ -135,6 +135,9 @@
 using namespace connectivity;
 assert(SQL_ISRULE(pSubTree,column_ref));
 
+if(!rParam.xField.is())
+return false;
+
 // retrieve the field's name  table range
 OUString aFieldName;
 try

-- 
To view, visit https://gerrit.libreoffice.org/4338
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id994ab5aed6172d8a93fd331a366fca10a663a48
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-1] setPropertyValue can throw PropertyVetoException

2013-05-30 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4095

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/4095/1

setPropertyValue can throw PropertyVetoException

fixes abort in report design when entering e.g. invalid positions or size for 
control

Change-Id: I38835ed79d5bee15c4d7b57ab6780050d250732a
---
M extensions/source/propctrlr/propertycomposer.cxx
M extensions/source/propctrlr/propertycomposer.hxx
2 files changed, 4 insertions(+), 2 deletions(-)



diff --git a/extensions/source/propctrlr/propertycomposer.cxx 
b/extensions/source/propctrlr/propertycomposer.cxx
index f3706dc..2fe8c56 100644
--- a/extensions/source/propctrlr/propertycomposer.cxx
+++ b/extensions/source/propctrlr/propertycomposer.cxx
@@ -129,7 +129,7 @@
 }
 
 //
-void SAL_CALL PropertyComposer::setPropertyValue( const OUString 
_rPropertyName, const Any _rValue ) throw (UnknownPropertyException, 
RuntimeException)
+void SAL_CALL PropertyComposer::setPropertyValue( const OUString 
_rPropertyName, const Any _rValue ) throw (UnknownPropertyException, 
RuntimeException, PropertyVetoException)
 {
 MethodGuard aGuard( *this );
 ::std::for_each( m_aSlaveHandlers.begin(), m_aSlaveHandlers.end(), 
SetPropertyValue( _rPropertyName, _rValue ) );
diff --git a/extensions/source/propctrlr/propertycomposer.hxx 
b/extensions/source/propctrlr/propertycomposer.hxx
index 5191239..1ed6c77 100644
--- a/extensions/source/propctrlr/propertycomposer.hxx
+++ b/extensions/source/propctrlr/propertycomposer.hxx
@@ -27,6 +27,8 @@
 #include com/sun/star/beans/XPropertySet.hpp
 #include com/sun/star/inspection/XPropertyHandler.hpp
 #include com/sun/star/lang/DisposedException.hpp
+#include com/sun/star/beans/UnknownPropertyException.hpp
+#include com/sun/star/beans/PropertyVetoException.hpp
 #include cppuhelper/compbase2.hxx
 #include comphelper/broadcasthelper.hxx
 #include comphelper/listenernotification.hxx
@@ -78,7 +80,7 @@
 // XPropertyHandler overridables
 virtual voidSAL_CALL inspect( const 
::com::sun::star::uno::Reference ::com::sun::star::uno::XInterface  
_rxIntrospectee ) throw (::com::sun::star::lang::NullPointerException, 
::com::sun::star::uno::RuntimeException);
 virtual ::com::sun::star::uno::Any  SAL_CALL getPropertyValue( 
const OUString _rPropertyName ) throw 
(::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException);
-virtual voidSAL_CALL setPropertyValue( 
const OUString _rPropertyName, const ::com::sun::star::uno::Any _rValue ) 
throw (::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException);
+virtual voidSAL_CALL setPropertyValue( 
const OUString _rPropertyName, const ::com::sun::star::uno::Any _rValue ) 
throw (::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException, 
::com::sun::star::beans::PropertyVetoException);
 virtual ::com::sun::star::uno::Any SAL_CALL convertToPropertyValue( 
const OUString _rPropertyName, const ::com::sun::star::uno::Any 
_rControlValue ) throw (::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException);
 virtual ::com::sun::star::uno::Any SAL_CALL convertToControlValue( 
const OUString _rPropertyName, const ::com::sun::star::uno::Any 
_rPropertyValue, const ::com::sun::star::uno::Type _rControlValueType ) throw 
(::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException);
 virtual ::com::sun::star::beans::PropertyState

-- 
To view, visit https://gerrit.libreoffice.org/4095
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38835ed79d5bee15c4d7b57ab6780050d250732a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-1
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] setPropertyValue can throw PropertyVetoException

2013-05-30 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4096

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/4096/1

setPropertyValue can throw PropertyVetoException

fixes abort in report design when entering e.g. invalid positions or size for 
control

Change-Id: I38835ed79d5bee15c4d7b57ab6780050d250732a
---
M extensions/source/propctrlr/propertycomposer.cxx
M extensions/source/propctrlr/propertycomposer.hxx
2 files changed, 4 insertions(+), 2 deletions(-)



diff --git a/extensions/source/propctrlr/propertycomposer.cxx 
b/extensions/source/propctrlr/propertycomposer.cxx
index c80bdf7..0629d70 100644
--- a/extensions/source/propctrlr/propertycomposer.cxx
+++ b/extensions/source/propctrlr/propertycomposer.cxx
@@ -129,7 +129,7 @@
 }
 
 //
-void SAL_CALL PropertyComposer::setPropertyValue( const ::rtl::OUString 
_rPropertyName, const Any _rValue ) throw (UnknownPropertyException, 
RuntimeException)
+void SAL_CALL PropertyComposer::setPropertyValue( const ::rtl::OUString 
_rPropertyName, const Any _rValue ) throw (UnknownPropertyException, 
RuntimeException, PropertyVetoException)
 {
 MethodGuard aGuard( *this );
 ::std::for_each( m_aSlaveHandlers.begin(), m_aSlaveHandlers.end(), 
SetPropertyValue( _rPropertyName, _rValue ) );
diff --git a/extensions/source/propctrlr/propertycomposer.hxx 
b/extensions/source/propctrlr/propertycomposer.hxx
index 68e4cee..0f9ac5f 100644
--- a/extensions/source/propctrlr/propertycomposer.hxx
+++ b/extensions/source/propctrlr/propertycomposer.hxx
@@ -27,6 +27,8 @@
 #include com/sun/star/beans/XPropertySet.hpp
 #include com/sun/star/inspection/XPropertyHandler.hpp
 #include com/sun/star/lang/DisposedException.hpp
+#include com/sun/star/beans/UnknownPropertyException.hpp
+#include com/sun/star/beans/PropertyVetoException.hpp
 #include cppuhelper/compbase2.hxx
 #include comphelper/broadcasthelper.hxx
 #include comphelper/listenernotification.hxx
@@ -78,7 +80,7 @@
 // XPropertyHandler overridables
 virtual voidSAL_CALL inspect( const 
::com::sun::star::uno::Reference ::com::sun::star::uno::XInterface  
_rxIntrospectee ) throw (::com::sun::star::lang::NullPointerException, 
::com::sun::star::uno::RuntimeException);
 virtual ::com::sun::star::uno::Any  SAL_CALL getPropertyValue( 
const ::rtl::OUString _rPropertyName ) throw 
(::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException);
-virtual voidSAL_CALL setPropertyValue( 
const ::rtl::OUString _rPropertyName, const ::com::sun::star::uno::Any 
_rValue ) throw (::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException);
+virtual voidSAL_CALL setPropertyValue( 
const ::rtl::OUString _rPropertyName, const ::com::sun::star::uno::Any 
_rValue ) throw (::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException, 
::com::sun::star::beans::PropertyVetoException);
 virtual ::com::sun::star::uno::Any SAL_CALL convertToPropertyValue( 
const ::rtl::OUString _rPropertyName, const ::com::sun::star::uno::Any 
_rControlValue ) throw (::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException);
 virtual ::com::sun::star::uno::Any SAL_CALL convertToControlValue( 
const ::rtl::OUString _rPropertyName, const ::com::sun::star::uno::Any 
_rPropertyValue, const ::com::sun::star::uno::Type _rControlValueType ) throw 
(::com::sun::star::beans::UnknownPropertyException, 
::com::sun::star::uno::RuntimeException);
 virtual ::com::sun::star::beans::PropertyState

-- 
To view, visit https://gerrit.libreoffice.org/4096
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38835ed79d5bee15c4d7b57ab6780050d250732a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] fdo#47951 work around underlying cause

2013-05-19 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3959

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/3959/1

fdo#47951 work around underlying cause

The true cause is that the flat text file database driver mishandles
the case of two ResultSets being open on the same table: the moving
commands of one impact the other.

Since in this case:

 - one ResultSet is open by the dispatch of
   .component:DB/DataSourceBrowser, that is the grid UI shown to the
   user, and that ResultSet is kept open to serve requests by the user
   to scroll;

 - the second ResultSet is opened by the call to
   pNewDBMgr-GetColumnNames
   and that ResultSet is closed by the time GetColumnNames returns

We just swap the order of these calls to work around the underlying
driver bug.

Change-Id: I628d9b870df2bbc402637818f987637d3bd62897
---
M sw/source/ui/envelp/mailmrge.cxx
1 file changed, 8 insertions(+), 8 deletions(-)



diff --git a/sw/source/ui/envelp/mailmrge.cxx b/sw/source/ui/envelp/mailmrge.cxx
index 4a675dc..d2a1d49 100644
--- a/sw/source/ui/envelp/mailmrge.cxx
+++ b/sw/source/ui/envelp/mailmrge.cxx
@@ -210,6 +210,14 @@
 aAttachED.Show(sal_False);
 aAttachPB.Show(sal_False);
 
+SwNewDBMgr* pNewDBMgr = rSh.GetNewDBMgr();
+if(_xConnection.is())
+pNewDBMgr-GetColumnNames(aAddressFldLB, _xConnection, rTableName);
+else
+pNewDBMgr-GetColumnNames(aAddressFldLB, rDBName, rTableName);
+for(sal_uInt16 nEntry = 0; nEntry  aAddressFldLB.GetEntryCount(); 
nEntry++)
+aColumnLB.InsertEntry(aAddressFldLB.GetEntry(nEntry));
+
 Point aMailPos = aMailingRB.GetPosPixel();
 Point aFilePos = aFileRB.GetPosPixel();
 aFilePos.X() -= (aFilePos.X() - aMailPos.X()) /2;
@@ -360,14 +368,6 @@
 aToNF.SetModifyHdl(aLk);
 aFromNF.SetMax(SAL_MAX_INT32);
 aToNF.SetMax(SAL_MAX_INT32);
-
-SwNewDBMgr* pNewDBMgr = rSh.GetNewDBMgr();
-if(_xConnection.is())
-pNewDBMgr-GetColumnNames(aAddressFldLB, _xConnection, rTableName);
-else
-pNewDBMgr-GetColumnNames(aAddressFldLB, rDBName, rTableName);
-for(sal_uInt16 nEntry = 0; nEntry  aAddressFldLB.GetEntryCount(); 
nEntry++)
-aColumnLB.InsertEntry(aAddressFldLB.GetEntry(nEntry));
 
 aAddressFldLB.SelectEntry(rtl::OUString(EMAIL));
 

-- 
To view, visit https://gerrit.libreoffice.org/3959
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I628d9b870df2bbc402637818f987637d3bd62897
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] fdo#47951 flat text table: update m_nRowPos when moving by b...

2013-05-19 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3961

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/3961/1

fdo#47951 flat text table: update m_nRowPos when moving by bookmark

Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
---
M connectivity/source/drivers/flat/ETable.cxx
1 file changed, 14 insertions(+), 0 deletions(-)



diff --git a/connectivity/source/drivers/flat/ETable.cxx 
b/connectivity/source/drivers/flat/ETable.cxx
index 9fe48f0..8ae7935 100644
--- a/connectivity/source/drivers/flat/ETable.cxx
+++ b/connectivity/source/drivers/flat/ETable.cxx
@@ -869,15 +869,29 @@
 break;
 case IResultSetHelper::BOOKMARK:
 {
+m_nRowPos = 0;
 TRowPositionsInFile::const_iterator aFind = 
m_aFilePosToEndLinePos.find(nOffset);
 m_bNeedToReadLine = aFind != m_aFilePosToEndLinePos.end();
 if ( m_bNeedToReadLine )
 {
 m_nFilePos  = aFind-first;
 nCurPos = aFind-second;
+for(::std::mapsal_Int32, 
TRowPositionsInFile::iterator::const_iterator p = m_aRowPosToFilePos.begin();
+p != m_aRowPosToFilePos.end();
+++p)
+{
+assert(p-second-first = nOffset);
+if(p-second-first == nOffset)
+{
+m_nRowPos = p-first;
+break;
+}
+}
+assert(m_nRowPos  0);
 }
 else
 {
+assert(false);
 m_nFilePos = nOffset;
 m_pFileStream-Seek(nOffset);
 if (m_pFileStream-IsEof() || !readLine(nCurPos) )

-- 
To view, visit https://gerrit.libreoffice.org/3961
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-3-6] fdo#47951 flat text table: update m_nRowPos when moving by b...

2013-05-19 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3962

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3962/1

fdo#47951 flat text table: update m_nRowPos when moving by bookmark

Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
---
M connectivity/source/drivers/flat/ETable.cxx
1 file changed, 14 insertions(+), 0 deletions(-)



diff --git a/connectivity/source/drivers/flat/ETable.cxx 
b/connectivity/source/drivers/flat/ETable.cxx
index b7f61ed..fc1124e 100644
--- a/connectivity/source/drivers/flat/ETable.cxx
+++ b/connectivity/source/drivers/flat/ETable.cxx
@@ -873,15 +873,29 @@
 break;
 case IResultSetHelper::BOOKMARK:
 {
+m_nRowPos = 0;
 TRowPositionsInFile::const_iterator aFind = 
m_aFilePosToEndLinePos.find(nOffset);
 m_bNeedToReadLine = aFind != m_aFilePosToEndLinePos.end();
 if ( m_bNeedToReadLine )
 {
 m_nFilePos  = aFind-first;
 nCurPos = aFind-second;
+for(::std::mapsal_Int32, 
TRowPositionsInFile::iterator::const_iterator p = m_aRowPosToFilePos.begin();
+p != m_aRowPosToFilePos.end();
+++p)
+{
+assert(p-second-first = nOffset);
+if(p-second-first == nOffset)
+{
+m_nRowPos = p-first;
+break;
+}
+}
+assert(m_nRowPos  0);
 }
 else
 {
+assert(false);
 m_nFilePos = nOffset;
 m_pFileStream-Seek(nOffset);
 if (m_pFileStream-IsEof() || !readLine(nCurPos) )

-- 
To view, visit https://gerrit.libreoffice.org/3962
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-3-6] fdo#47951 work around underlying cause

2013-05-19 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3963

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3963/1

fdo#47951 work around underlying cause

The true cause is that the flat text file database driver mishandles
the case of two ResultSets being open on the same table: the moving
commands of one impact the other.

Since in this case:

 - one ResultSet is open by the dispatch of
   .component:DB/DataSourceBrowser, that is the grid UI shown to the
   user, and that ResultSet is kept open to serve requests by the user
   to scroll;

 - the second ResultSet is opened by the call to
   pNewDBMgr-GetColumnNames
   and that ResultSet is closed by the time GetColumnNames returns

We just swap the order of these calls to work around the underlying
driver bug.

Change-Id: I628d9b870df2bbc402637818f987637d3bd62897
---
M sw/source/ui/envelp/mailmrge.cxx
1 file changed, 8 insertions(+), 8 deletions(-)



diff --git a/sw/source/ui/envelp/mailmrge.cxx b/sw/source/ui/envelp/mailmrge.cxx
index 14cc5b2..2c04b06 100644
--- a/sw/source/ui/envelp/mailmrge.cxx
+++ b/sw/source/ui/envelp/mailmrge.cxx
@@ -224,6 +224,14 @@
 aAttachED.Show(sal_False);
 aAttachPB.Show(sal_False);
 
+SwNewDBMgr* pNewDBMgr = rSh.GetNewDBMgr();
+if(_xConnection.is())
+pNewDBMgr-GetColumnNames(aAddressFldLB, _xConnection, rTableName);
+else
+pNewDBMgr-GetColumnNames(aAddressFldLB, rDBName, rTableName);
+for(sal_uInt16 nEntry = 0; nEntry  aAddressFldLB.GetEntryCount(); 
nEntry++)
+aColumnLB.InsertEntry(aAddressFldLB.GetEntry(nEntry));
+
 Point aMailPos = aMailingRB.GetPosPixel();
 Point aFilePos = aFileRB.GetPosPixel();
 aFilePos.X() -= (aFilePos.X() - aMailPos.X()) /2;
@@ -374,14 +382,6 @@
 aToNF.SetModifyHdl(aLk);
 aFromNF.SetMax(SAL_MAX_INT32);
 aToNF.SetMax(SAL_MAX_INT32);
-
-SwNewDBMgr* pNewDBMgr = rSh.GetNewDBMgr();
-if(_xConnection.is())
-pNewDBMgr-GetColumnNames(aAddressFldLB, _xConnection, rTableName);
-else
-pNewDBMgr-GetColumnNames(aAddressFldLB, rDBName, rTableName);
-for(sal_uInt16 nEntry = 0; nEntry  aAddressFldLB.GetEntryCount(); 
nEntry++)
-aColumnLB.InsertEntry(aAddressFldLB.GetEntry(nEntry));
 
 aAddressFldLB.SelectEntry(C2S(EMAIL));
 

-- 
To view, visit https://gerrit.libreoffice.org/3963
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I628d9b870df2bbc402637818f987637d3bd62897
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] fdo#63398 hardcode former list of oneway method

2013-05-11 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3863

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3863/1

fdo#63398 hardcode former list of oneway method

adapt to disappearance of oneway qualifier for method
by hardcoding list of methods that were oneway.

Autogenerated by the following script:
SKIP=1; git log -p -1   90eac3e69749a9227c4b6902b1f3cef1e338c6d1 | while read 
f0 f1 f2 f3 f4; do if [[ $f0 == --- ]]; then if printf '%s' $f1 | egrep 
-q '^a/(off|udk)api/.*\.idl$'; then LISTENER=$(printf '%s' $f1 | sed  -re 
's@^a/(udk|off)api/@@' -e 's|/|.|g' -e 's@\.idl$@@'); SKIP=0; else SKIP=1; fi; 
elif [[ $SKIP -eq 0 ]]  [[ $f1 == '[oneway]' ]]; then printf 
$'(pairOUString,OUString(%s,%s))
' $LISTENER $(echo -n $f3 | sed -r -e 's@\(.*@@'); fi; done

This is rather atrocious, but ensures the behaviour is exactly the
same as before.

Left to do:

remove methods that are irrelevant here
(that is, impl_allowAsynchronousCall_nothrow will never be called
 with them as argument)

(cherry picked from commit 9dfc3807dbff1a40f487d020446265bb85d0ac16)

Conflicts:
svx/source/form/fmscriptingenv.cxx

Change-Id: If4fea164a2fe727048645cd853a9850e59469ba5
---
M svx/source/form/fmscriptingenv.cxx
1 file changed, 535 insertions(+), 17 deletions(-)



diff --git a/svx/source/form/fmscriptingenv.cxx 
b/svx/source/form/fmscriptingenv.cxx
index c6bf945..e8cf061 100644
--- a/svx/source/form/fmscriptingenv.cxx
+++ b/svx/source/form/fmscriptingenv.cxx
@@ -40,6 +40,10 @@
 #include basic/basmgr.hxx
 
 #include boost/shared_ptr.hpp
+#include boost/assign/list_of.hpp
+#include utility
+using std::pair;
+#include set
 
 //
 namespace svxform
@@ -195,24 +199,538 @@
 //
 bool FormScriptListener::impl_allowAsynchronousCall_nothrow( const 
::rtl::OUString _rListenerType, const ::rtl::OUString _rMethodName ) const
 {
-bool bAllowAsynchronousCall = false;
-try
-{
-::comphelper::ComponentContext aContext( 
::comphelper::getProcessServiceFactory() );
-Reference XHierarchicalNameAccess  xTypeDescriptions( 
aContext.getSingleton( com.sun.star.reflection.theTypeDescriptionManager ), 
UNO_QUERY_THROW );
+// This used to be implemented as:
+// is (_rListenerType + :: + _rMethodName) a oneway function?
+// since we got rid of the notion of oneway, this is the list
+// of oneway methods, autogenerated by postprocessing of
+// commitdiff 90eac3e69749a9227c4b6902b1f3cef1e338c6d1
+static std::set pair OUString, OUString   delayed_event_listeners =
+boost::assign::list_of
+
(pairOUString,OUString(com.sun.star.accessibility.XAccessibleComponent,grabFocus))
+
(pairOUString,OUString(com.sun.star.accessibility.XAccessibleEventBroadcaster,addAccessibleEventListener))
+
(pairOUString,OUString(com.sun.star.accessibility.XAccessibleEventBroadcaster,removeAccessibleEventListener))
+
(pairOUString,OUString(com.sun.star.accessibility.XAccessibleSelection,clearAccessibleSelection))
+
(pairOUString,OUString(com.sun.star.accessibility.XAccessibleSelection,selectAllAccessibleChildren))
+
(pairOUString,OUString(com.sun.star.awt.XActionListener,actionPerformed))
+
(pairOUString,OUString(com.sun.star.awt.XActivateListener,windowActivated))
+
(pairOUString,OUString(com.sun.star.awt.XActivateListener,windowDeactivated))
+
(pairOUString,OUString(com.sun.star.awt.XAdjustmentListener,adjustmentValueChanged))
+
(pairOUString,OUString(com.sun.star.awt.XButton,addActionListener))
+
(pairOUString,OUString(com.sun.star.awt.XButton,removeActionListener))
+(pairOUString,OUString(com.sun.star.awt.XButton,setLabel))
+
(pairOUString,OUString(com.sun.star.awt.XButton,setActionCommand))
+
(pairOUString,OUString(com.sun.star.awt.XCheckBox,addItemListener))
+
(pairOUString,OUString(com.sun.star.awt.XCheckBox,removeItemListener))
+(pairOUString,OUString(com.sun.star.awt.XCheckBox,setState))
+(pairOUString,OUString(com.sun.star.awt.XCheckBox,setLabel))
+
(pairOUString,OUString(com.sun.star.awt.XCheckBox,enableTriState))
+
(pairOUString,OUString(com.sun.star.awt.XComboBox,addItemListener))
+
(pairOUString,OUString(com.sun.star.awt.XComboBox,removeItemListener))
+
(pairOUString,OUString(com.sun.star.awt.XComboBox,addActionListener))
+
(pairOUString,OUString(com.sun.star.awt.XComboBox,removeActionListener))
+(pairOUString,OUString(com.sun.star.awt.XComboBox,addItem))
+(pairOUString,OUString(com.sun.star.awt.XComboBox,addItems))
+

[PATCH libreoffice-4-0] fdo#63695 revert hackish fix to i#51621

2013-05-11 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3864

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/3864/1

fdo#63695 revert hackish fix to i#51621

Change-Id: I688a659207c4b95cc98ff5dc5c5622d4592b3f89
(cherry picked from commit 7fd1cc18130464a9f09cb7a866e88c4d52e4716d)
---
M svx/source/form/fmtextcontrolshell.cxx
1 file changed, 3 insertions(+), 2 deletions(-)



diff --git a/svx/source/form/fmtextcontrolshell.cxx 
b/svx/source/form/fmtextcontrolshell.cxx
index a4551af..47e5e7d 100644
--- a/svx/source/form/fmtextcontrolshell.cxx
+++ b/svx/source/form/fmtextcontrolshell.cxx
@@ -1271,8 +1271,9 @@
 // shells too much (In theory, nearly every slot could have an own 
shell then).
 //
 // #i51621# / 2005-08-19 / frank.schoenh...@sun.com
-bool bHaveAnyServeableSlots = m_xActiveTextComponent.is() || 
!m_aControlFeatures.empty();
-if ( m_aControlActivationHandler.IsSet()  bHaveAnyServeableSlots )
+// bool bHaveAnyServeableSlots = m_xActiveTextComponent.is() || 
!m_aControlFeatures.empty();
+// LEM: not calling m_aControlActivatonHandler causes fdo#63695, so 
disable this hack for now.
+if ( m_aControlActivationHandler.IsSet() /*  bHaveAnyServeableSlots 
*/ )
 m_aControlActivationHandler.Call( NULL );
 
 m_bNeedClipboardInvalidation = true;

-- 
To view, visit https://gerrit.libreoffice.org/3864
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I688a659207c4b95cc98ff5dc5c5622d4592b3f89
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] commit subforms before moving in parent form

2013-05-11 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3865

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/3865/1

commit subforms before moving in parent form

else, all pending changes in the subforms are lost

(cherry picked from commit 28cacb44009a1d2cb5fdb3b81c1a7c665463d38d)

Conflicts:
forms/source/component/errorbroadcaster.cxx
forms/source/runtime/formoperations.cxx
sal/inc/sal/log-areas.dox

Change-Id: I82b0967729c71a4f01eff9f823a1961fad999679
---
M forms/source/runtime/formoperations.cxx
M sal/inc/sal/log-areas.dox
2 files changed, 141 insertions(+), 36 deletions(-)



diff --git a/forms/source/runtime/formoperations.cxx 
b/forms/source/runtime/formoperations.cxx
index 6ba363e..1ea05d2 100644
--- a/forms/source/runtime/formoperations.cxx
+++ b/forms/source/runtime/formoperations.cxx
@@ -80,6 +80,7 @@
 using ::com::sun::star::sdbc::XRowSet;
 using ::com::sun::star::sdbc::XResultSetUpdate;
 using ::com::sun::star::form::runtime::XFormController;
+using ::com::sun::star::form::runtime::XFormOperations;
 using ::com::sun::star::form::runtime::XFeatureInvalidation;
 using ::com::sun::star::form::runtime::FeatureState;
 using ::com::sun::star::lang::IllegalArgumentException;
@@ -452,8 +453,128 @@
 {
 return ( _nFeature != FormFeature::TotalRecords );
 }
-}
 
+template  typename TYPE 
+TYPE lcl_safeGetPropertyValue_throw( const Reference XPropertySet  
_rxProperties, const OUString _rPropertyName, TYPE _Default )
+{
+TYPE value( _Default );
+OSL_PRECOND( _rxProperties.is(), FormOperations::foo: no cursor 
(already disposed?)! );
+if ( _rxProperties.is() )
+OSL_VERIFY( _rxProperties-getPropertyValue( _rPropertyName ) 
= value );
+return value;
+}
+
+// returns false if parent should *abort* (user pressed cancel)
+bool checkConfirmation(bool needConfirmation, bool shouldCommit)
+{
+if(needConfirmation)
+{
+// TODO: shouldn't this be done with an interaction handler?
+QueryBox aQuery( NULL, WB_YES_NO_CANCEL | WB_DEF_YES, 
FRM_RES_STRING( RID_STR_QUERY_SAVE_MODIFIED_ROW ) );
+switch ( aQuery.Execute() )
+{
+case RET_NO:
+shouldCommit = false;
+// no break on purpose: don't ask again!
+case RET_YES:
+needConfirmation = false;
+return true;
+case RET_CANCEL:
+return false;
+}
+}
+return true;
+}
+
+bool commit1Form(Reference XFormController  xCntrl, bool 
needConfirmation, bool shouldCommit)
+{
+Reference XFormOperations  xFrmOps(xCntrl-getFormOperations());
+if (!xFrmOps-commitCurrentControl())
+return false;
+
+if(xFrmOps-isModifiedRow())
+{
+if(!checkConfirmation(needConfirmation, shouldCommit))
+return false;
+sal_Bool _;
+if (shouldCommit  !xFrmOps-commitCurrentRecord(_))
+return false;
+}
+return true;
+}
+
+bool commitFormAndSubforms(Reference XFormController  xCntrl, bool 
needConfirmation)
+{
+bool shouldCommit(true);
+assert(xCntrl.is());
+Reference XIndexAccess  xSubForms(xCntrl, UNO_QUERY);
+assert(xSubForms.is());
+if(xSubForms.is())
+{
+const sal_Int32 cnt = xSubForms-getCount();
+for(int i=0; i  cnt; ++i)
+{
+Reference XFormController  
xSubForm(xSubForms-getByIndex(i), UNO_QUERY);
+assert(xSubForm.is());
+if (xSubForm.is())
+{
+if (!commit1Form(xSubForm, needConfirmation, 
shouldCommit))
+return false;
+}
+}
+}
+
+if(!commit1Form(xCntrl, needConfirmation, shouldCommit))
+return false;
+
+return true;
+}
+
+bool commit1Form(Reference XForm  xFrm, bool needConfirmation, bool 
shouldCommit)
+{
+Reference XPropertySet  xProps(xFrm, UNO_QUERY_THROW);
+// nothing to do if the record is not modified
+if(!lcl_safeGetPropertyValue_throw( xProps, PROPERTY_ISMODIFIED, 
false ))
+return true;
+
+if(!checkConfirmation(needConfirmation, shouldCommit))
+return false;
+if(shouldCommit)
+{
+Reference XResultSetUpdate  xUpd(xFrm, UNO_QUERY_THROW);
+// insert

[PATCH libreoffice-4-0] fdo#48056 revert part of return correct name for shapetype

2013-05-03 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3766

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3766/1

fdo#48056 revert part of return correct name for shapetype

Keep hardcoded values as *fallback* only, but trust 
m_aProps.aComponent.m_xShape-getShapeType when present.

Change-Id: I5a024a9bc5f87d226ab3c857817dfe91ad975acb
---
M reportdesign/source/core/api/FixedLine.cxx
M reportdesign/source/core/api/FixedText.cxx
M reportdesign/source/core/api/FormattedField.cxx
M reportdesign/source/core/api/ImageControl.cxx
M reportdesign/source/core/api/ReportDefinition.cxx
M reportdesign/source/core/api/Shape.cxx
6 files changed, 23 insertions(+), 4 deletions(-)



diff --git a/reportdesign/source/core/api/FixedLine.cxx 
b/reportdesign/source/core/api/FixedLine.cxx
index 51dff9d..f211053 100644
--- a/reportdesign/source/core/api/FixedLine.cxx
+++ b/reportdesign/source/core/api/FixedLine.cxx
@@ -526,7 +526,10 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OFixedLine::getShapeType(  ) throw 
(uno::RuntimeException)
 {
-   return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
+::osl::MutexGuard aGuard(m_aMutex);
+if ( m_aProps.aComponent.m_xShape.is() )
+return m_aProps.aComponent.m_xShape-getShapeType();
+return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
 }
 // 
-
 ::rtl::OUString SAL_CALL OFixedLine::getHyperLinkURL() throw 
(uno::RuntimeException, beans::UnknownPropertyException)
diff --git a/reportdesign/source/core/api/FixedText.cxx 
b/reportdesign/source/core/api/FixedText.cxx
index 2d127a1..215b89c 100644
--- a/reportdesign/source/core/api/FixedText.cxx
+++ b/reportdesign/source/core/api/FixedText.cxx
@@ -321,7 +321,10 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OFixedText::getShapeType(  ) throw 
(uno::RuntimeException)
 {
-   return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
+::osl::MutexGuard aGuard(m_aMutex);
+if ( m_aProps.aComponent.m_xShape.is() )
+return m_aProps.aComponent.m_xShape-getShapeType();
+return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
 }
 // 
-
 // 
-
diff --git a/reportdesign/source/core/api/FormattedField.cxx 
b/reportdesign/source/core/api/FormattedField.cxx
index a05fc55..9b47924 100644
--- a/reportdesign/source/core/api/FormattedField.cxx
+++ b/reportdesign/source/core/api/FormattedField.cxx
@@ -364,6 +364,9 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OFormattedField::getShapeType(  ) throw 
(uno::RuntimeException)
 {
+::osl::MutexGuard aGuard(m_aMutex);
+if ( m_aProps.aComponent.m_xShape.is() )
+return m_aProps.aComponent.m_xShape-getShapeType();
return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
 }
 // 
-
diff --git a/reportdesign/source/core/api/ImageControl.cxx 
b/reportdesign/source/core/api/ImageControl.cxx
index 99081f7..8c71eb7 100644
--- a/reportdesign/source/core/api/ImageControl.cxx
+++ b/reportdesign/source/core/api/ImageControl.cxx
@@ -458,7 +458,10 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OImageControl::getShapeType(  ) throw 
(uno::RuntimeException)
 {
-   return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
+::osl::MutexGuard aGuard(m_aMutex);
+if ( m_aProps.aComponent.m_xShape.is() )
+return m_aProps.aComponent.m_xShape-getShapeType();
+return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
 }
 // 
-
 ::sal_Int16 SAL_CALL OImageControl::getScaleMode() throw 
(uno::RuntimeException)
diff --git a/reportdesign/source/core/api/ReportDefinition.cxx 
b/reportdesign/source/core/api/ReportDefinition.cxx
index 1ae1719..1825836 100644
--- a/reportdesign/source/core/api/ReportDefinition.cxx
+++ b/reportdesign/source/core/api/ReportDefinition.cxx
@@ -2432,6 +2432,10 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OReportDefinition::getShapeType(  ) throw 
(uno::RuntimeException)
 {
+::osl::MutexGuard aGuard(m_aMutex);
+::connectivity::checkDisposed(ReportDefinitionBase::rBHelper.bDisposed);
+if ( m_aProps-m_xShape.is() )
+return m_aProps-m_xShape-getShapeType();
return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.OLE2Shape));
 }
 // 
-
diff --git a/reportdesign/source/core/api/Shape.cxx 
b/reportdesign/source/core/api/Shape.cxx
index

[PATCH libreoffice-4-0] fdo#64150 don't segfault when there is no line

2013-05-03 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3765

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/3765/1

fdo#64150 don't segfault when there is no line

Change-Id: Iab36de3d407925cdb0e092afae457907f0261b3e
---
M editeng/source/items/frmitems.cxx
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/editeng/source/items/frmitems.cxx 
b/editeng/source/items/frmitems.cxx
index 35c04bb..275ef73f 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -1966,7 +1966,8 @@
 for (int n(0); n != SAL_N_ELEMENTS(aBorders); ++n)
 {
 editeng::SvxBorderLine* pLine = const_cast 
editeng::SvxBorderLine* ( GetLine( aBorders[n] ) );
-pLine-SetWidth( nWidth );
+if( pLine )
+pLine-SetWidth( nWidth );
 }
 }
 return sal_True;

-- 
To view, visit https://gerrit.libreoffice.org/3765
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab36de3d407925cdb0e092afae457907f0261b3e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] fdo#48056 treat report chart as draw chart

2013-05-03 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3767

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3767/1

fdo#48056 treat report chart as draw chart

Change-Id: I0a716b4339747f1994e5c8710e15474807aea4a2
---
M comphelper/inc/comphelper/classids.hxx
M xmloff/source/draw/shapeexport.cxx
2 files changed, 8 insertions(+), 1 deletion(-)



diff --git a/comphelper/inc/comphelper/classids.hxx 
b/comphelper/inc/comphelper/classids.hxx
index 416715b..4a16e44 100644
--- a/comphelper/inc/comphelper/classids.hxx
+++ b/comphelper/inc/comphelper/classids.hxx
@@ -405,6 +405,12 @@
 // #110743#
 #define BF_SO3_SCH_CLASSID  BF_SO3_SCH_CLASSID_50
 
+// Report chart
+
+#define SO3_RPTCH_CLASSID \
+0x80243D39, 0x6741, 0x46C5, 0x92, 0x6E, 0x06, \
+0x91, 0x64, 0xFF, 0x87, 0xBB
+
 /
 * StarImage
 /
diff --git a/xmloff/source/draw/shapeexport.cxx 
b/xmloff/source/draw/shapeexport.cxx
index a4c71b4..c7d812b 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -1079,7 +1079,8 @@
 rtl::OUString sCLSID;
 if(xPropSet-getPropertyValue(OUString(CLSID)) = 
sCLSID)
 {
-if 
(sCLSID.equals(mrExport.GetChartExport()-getChartCLSID()))
+if 
(sCLSID.equals(mrExport.GetChartExport()-getChartCLSID()) ||
+sCLSID.equals(rtl::OUString( SvGlobalName( 
SO3_RPTCH_CLASSID ).GetHexName(
 {
 eShapeType = XmlShapeTypeDrawChartShape;
 }

-- 
To view, visit https://gerrit.libreoffice.org/3767
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a716b4339747f1994e5c8710e15474807aea4a2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-3-6] fdo#64150 don't segfault when there is no line

2013-05-03 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3768

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3768/1

fdo#64150 don't segfault when there is no line

Change-Id: Iab36de3d407925cdb0e092afae457907f0261b3e
---
M editeng/source/items/frmitems.cxx
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/editeng/source/items/frmitems.cxx 
b/editeng/source/items/frmitems.cxx
index da4ca7d..2afb045 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -1980,7 +1980,8 @@
 for (int n(0); n != SAL_N_ELEMENTS(aBorders); ++n)
 {
 editeng::SvxBorderLine* pLine = const_cast 
editeng::SvxBorderLine* ( GetLine( aBorders[n] ) );
-pLine-SetWidth( nWidth );
+if( pLine )
+pLine-SetWidth( nWidth );
 }
 }
 return sal_True;

-- 
To view, visit https://gerrit.libreoffice.org/3768
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab36de3d407925cdb0e092afae457907f0261b3e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-3-6] fdo#48056 revert part of return correct name for shapetype

2013-05-03 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3769

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3769/1

fdo#48056 revert part of return correct name for shapetype

Keep hardcoded values as *fallback* only, but trust 
m_aProps.aComponent.m_xShape-getShapeType when present.

Change-Id: I5a024a9bc5f87d226ab3c857817dfe91ad975acb
---
M reportdesign/source/core/api/FixedLine.cxx
M reportdesign/source/core/api/FixedText.cxx
M reportdesign/source/core/api/FormattedField.cxx
M reportdesign/source/core/api/ImageControl.cxx
M reportdesign/source/core/api/ReportDefinition.cxx
M reportdesign/source/core/api/Shape.cxx
6 files changed, 23 insertions(+), 4 deletions(-)



diff --git a/reportdesign/source/core/api/FixedLine.cxx 
b/reportdesign/source/core/api/FixedLine.cxx
index dee328a..9c52a5f 100644
--- a/reportdesign/source/core/api/FixedLine.cxx
+++ b/reportdesign/source/core/api/FixedLine.cxx
@@ -531,7 +531,10 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OFixedLine::getShapeType(  ) throw 
(uno::RuntimeException)
 {
-   return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
+::osl::MutexGuard aGuard(m_aMutex);
+if ( m_aProps.aComponent.m_xShape.is() )
+return m_aProps.aComponent.m_xShape-getShapeType();
+return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
 }
 // 
-
 ::rtl::OUString SAL_CALL OFixedLine::getHyperLinkURL() throw 
(uno::RuntimeException, beans::UnknownPropertyException)
diff --git a/reportdesign/source/core/api/FixedText.cxx 
b/reportdesign/source/core/api/FixedText.cxx
index aff7ff7..02336fd 100644
--- a/reportdesign/source/core/api/FixedText.cxx
+++ b/reportdesign/source/core/api/FixedText.cxx
@@ -330,7 +330,10 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OFixedText::getShapeType(  ) throw 
(uno::RuntimeException)
 {
-   return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
+::osl::MutexGuard aGuard(m_aMutex);
+if ( m_aProps.aComponent.m_xShape.is() )
+return m_aProps.aComponent.m_xShape-getShapeType();
+return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
 }
 // 
-
 // 
-
diff --git a/reportdesign/source/core/api/FormattedField.cxx 
b/reportdesign/source/core/api/FormattedField.cxx
index 95a2243..979fd2a 100644
--- a/reportdesign/source/core/api/FormattedField.cxx
+++ b/reportdesign/source/core/api/FormattedField.cxx
@@ -373,6 +373,9 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OFormattedField::getShapeType(  ) throw 
(uno::RuntimeException)
 {
+::osl::MutexGuard aGuard(m_aMutex);
+if ( m_aProps.aComponent.m_xShape.is() )
+return m_aProps.aComponent.m_xShape-getShapeType();
return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
 }
 // 
-
diff --git a/reportdesign/source/core/api/ImageControl.cxx 
b/reportdesign/source/core/api/ImageControl.cxx
index 71d2a22..6d0c375 100644
--- a/reportdesign/source/core/api/ImageControl.cxx
+++ b/reportdesign/source/core/api/ImageControl.cxx
@@ -467,7 +467,10 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OImageControl::getShapeType(  ) throw 
(uno::RuntimeException)
 {
-   return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
+::osl::MutexGuard aGuard(m_aMutex);
+if ( m_aProps.aComponent.m_xShape.is() )
+return m_aProps.aComponent.m_xShape-getShapeType();
+return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape));
 }
 // 
-
 ::sal_Int16 SAL_CALL OImageControl::getScaleMode() throw 
(uno::RuntimeException)
diff --git a/reportdesign/source/core/api/ReportDefinition.cxx 
b/reportdesign/source/core/api/ReportDefinition.cxx
index c5189dc..4da53df 100644
--- a/reportdesign/source/core/api/ReportDefinition.cxx
+++ b/reportdesign/source/core/api/ReportDefinition.cxx
@@ -2445,6 +2445,10 @@
 // XShapeDescriptor
 ::rtl::OUString SAL_CALL OReportDefinition::getShapeType(  ) throw 
(uno::RuntimeException)
 {
+::osl::MutexGuard aGuard(m_aMutex);
+::connectivity::checkDisposed(ReportDefinitionBase::rBHelper.bDisposed);
+if ( m_aProps-m_xShape.is() )
+return m_aProps-m_xShape-getShapeType();
return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.OLE2Shape));
 }
 // 
-
diff --git a/reportdesign/source/core/api/Shape.cxx 
b/reportdesign/source/core/api/Shape.cxx
index

[PATCH libreoffice-3-6] fdo#48056 treat report chart as draw chart

2013-05-03 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3770

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3770/1

fdo#48056 treat report chart as draw chart

Change-Id: I0a716b4339747f1994e5c8710e15474807aea4a2
---
M comphelper/inc/comphelper/classids.hxx
M xmloff/source/draw/shapeexport.cxx
2 files changed, 8 insertions(+), 1 deletion(-)



diff --git a/comphelper/inc/comphelper/classids.hxx 
b/comphelper/inc/comphelper/classids.hxx
index dcfe502..a6c304a 100644
--- a/comphelper/inc/comphelper/classids.hxx
+++ b/comphelper/inc/comphelper/classids.hxx
@@ -414,6 +414,12 @@
 // #110743#
 #define BF_SO3_SCH_CLASSID  BF_SO3_SCH_CLASSID_50
 
+// Report chart
+
+#define SO3_RPTCH_CLASSID \
+0x80243D39, 0x6741, 0x46C5, 0x92, 0x6E, 0x06, \
+0x91, 0x64, 0xFF, 0x87, 0xBB
+
 /
 * StarImage
 /
diff --git a/xmloff/source/draw/shapeexport.cxx 
b/xmloff/source/draw/shapeexport.cxx
index bec909b..22891c4 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -1091,7 +1091,8 @@
 rtl::OUString sCLSID;
 if(xPropSet-getPropertyValue(OUString(CLSID)) = 
sCLSID)
 {
-if 
(sCLSID.equals(mrExport.GetChartExport()-getChartCLSID()))
+if 
(sCLSID.equals(mrExport.GetChartExport()-getChartCLSID()) ||
+sCLSID.equals(rtl::OUString( SvGlobalName( 
SO3_RPTCH_CLASSID ).GetHexName(
 {
 eShapeType = XmlShapeTypeDrawChartShape;
 }

-- 
To view, visit https://gerrit.libreoffice.org/3770
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a716b4339747f1994e5c8710e15474807aea4a2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] pgsql-sdbc: conninfo keywords as static table instead of ser...

2013-04-29 Thread Lionel Elie Mamane (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3614

Objections:
  Tor Lillqvist: Do not merge


-- 
To view, visit https://gerrit.libreoffice.org/3614
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib581b3e834a57e0dfa9d139bcb4ae7a0a52a5472
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Anthony Youngman anth...@youngman.org.uk
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] Change j type to size_t

2013-04-29 Thread Lionel Elie Mamane (via Code Review)

Lionel Elie Mamane has abandoned this change.

Change subject: Change j type to size_t
..


Patch Set 1: Abandoned

Squashed into change 3614

-- 
To view, visit https://gerrit.libreoffice.org/3616
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If04e33228162baab392906903a574f1a6e7a6110
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Anthony Youngman anth...@youngman.org.uk
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] Rewrite as a static table of keywords and loop over them

2013-04-29 Thread Lionel Elie Mamane (via Code Review)

Lionel Elie Mamane has abandoned this change.

Change subject: Rewrite as a static table of keywords and loop over them
..


Patch Set 1: Abandoned

Squashed into change 3614

-- 
To view, visit https://gerrit.libreoffice.org/3615
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8aa4ff0f39166014c299783203eb646817b1399c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Anthony Youngman anth...@youngman.org.uk
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] fdo#330191 a NULL value of float type is not NaN

2013-04-24 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3599

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/3599/1

fdo#330191 a NULL value of float type is not NaN

but it is *still* NULL.

This was initially done to fix i#108092,
but i#112652 comment 13 suggests this may have been fixed more cleanly.

Change-Id: I2b76af2182715bc489cb89dd45d6b77d5038b506
---
M 
reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java
1 file changed, 0 insertions(+), 5 deletions(-)



diff --git 
a/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java
 
b/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java
index 1489098..9f0340a 100644
--- 
a/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java
+++ 
b/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java
@@ -73,11 +73,6 @@
 {
 FormatValueUtility.applyValueForCell(value.getValue(), 
attributeMap, valueType);
 }
-else if ( float.equals(valueType))
-{
-attributeMap.setAttribute(OfficeNamespaces.OFFICE_NS,
-FormatValueUtility.VALUE, NaN);
-}
 // #i114108#: except on form elements, the only value-type that can
 // occur without an accomanying value attribute is string
 else if (!string.equals(valueType))

-- 
To view, visit https://gerrit.libreoffice.org/3599
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b76af2182715bc489cb89dd45d6b77d5038b506
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] date/time IDL datatypes incompatible change

2013-04-19 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2783

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/2783/24

date/time IDL datatypes incompatible change

 - nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx
M vcl/source/control/field2.cxx
M wizards/com/sun/star/wizards/common/JavaTools.java
M xmloff/source/core/xmluconv.cxx
M xmloff/source/draw/animationimport.cxx
M

[PATCH] fdo#61725 workaround

2013-04-18 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3462

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3462/1

fdo#61725 workaround

Change-Id: I7d25f293020f366b20ddb9cade1854013857bed2
---
M vcl/source/app/dbggui.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/vcl/source/app/dbggui.cxx b/vcl/source/app/dbggui.cxx
index 00e3d03..4434a7c 100644
--- a/vcl/source/app/dbggui.cxx
+++ b/vcl/source/app/dbggui.cxx
@@ -1748,7 +1748,7 @@
 bool bCheck = ImplGetSVData()-mpDefInst-CheckYieldMutex();
 (void)bCheck;
 OSL_ENSURE( bCheck, SolarMutex not locked );
-assert(bCheck);
+//assert(bCheck);
 }
 
 // ===

-- 
To view, visit https://gerrit.libreoffice.org/3462
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d25f293020f366b20ddb9cade1854013857bed2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] date/time IDL datatypes incompatible change

2013-04-18 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#22).

Change subject: date/time IDL datatypes incompatible change
..

date/time IDL datatypes incompatible change

 - nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx
M vcl/source/control/field2.cxx
M

[ABANDONED] fdo#61725 workaround

2013-04-18 Thread Lionel Elie Mamane (via Code Review)

Lionel Elie Mamane has abandoned this change.

Change subject: fdo#61725 workaround
..


Patch Set 1: Abandoned

not intended to be committed; pushed to gerrit by error.

-- 
To view, visit https://gerrit.libreoffice.org/3462
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I7d25f293020f366b20ddb9cade1854013857bed2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] date/time IDL datatypes incompatible change

2013-04-18 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#23).

Change subject: date/time IDL datatypes incompatible change
..

date/time IDL datatypes incompatible change

 - nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx
M vcl/source/control/field2.cxx
M

[PUSHED] date/time IDL datatypes incompatible change

2013-04-18 Thread Lionel Elie Mamane (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2783


-- 
To view, visit https://gerrit.libreoffice.org/2783
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
Gerrit-PatchSet: 24
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Eike Rathke er...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] date/time IDL datatypes incompatible change

2013-04-18 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#24).

Change subject: date/time IDL datatypes incompatible change
..

date/time IDL datatypes incompatible change

 - nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx
M vcl/source/control/field2.cxx
M

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-16 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#21).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-16 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#20).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-15 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#16).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-15 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#17).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-15 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#18).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-15 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#19).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH libreoffice-4-0] fdo#52179 on copy kb-shortcut, from current row, not last ...

2013-04-14 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3378

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3378/1

fdo#52179 on copy kb-shortcut, from *current* row, not last painted row (!)

Change-Id: I39be862abb7c72234adad9c517d4a0570a1d71ae
---
M svx/source/fmcomp/gridctrl.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/svx/source/fmcomp/gridctrl.cxx b/svx/source/fmcomp/gridctrl.cxx
index 9a40816..2663b8f 100644
--- a/svx/source/fmcomp/gridctrl.cxx
+++ b/svx/source/fmcomp/gridctrl.cxx
@@ -3397,7 +3397,7 @@
 {
 size_t Location = GetModelColumnPos( nColId );
 DbGridColumn* pColumn = ( Location  m_aColumns.size() ) ? 
m_aColumns[ Location ] : NULL;
-OStringTransfer::CopyString( GetCurrentRowCellText( 
pColumn,m_xPaintRow ), this );
+OStringTransfer::CopyString( GetCurrentRowCellText( pColumn, 
m_xCurrentRow ), this );
 return;
 }
 }

-- 
To view, visit https://gerrit.libreoffice.org/3378
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39be862abb7c72234adad9c517d4a0570a1d71ae
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-3-6] fdo#52179 on copy kb-shortcut, from current row, not last ...

2013-04-14 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3379

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/3379/1

fdo#52179 on copy kb-shortcut, from *current* row, not last painted row (!)

Change-Id: I39be862abb7c72234adad9c517d4a0570a1d71ae
---
M svx/source/fmcomp/gridctrl.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/svx/source/fmcomp/gridctrl.cxx b/svx/source/fmcomp/gridctrl.cxx
index 13c8f3e..528881b 100644
--- a/svx/source/fmcomp/gridctrl.cxx
+++ b/svx/source/fmcomp/gridctrl.cxx
@@ -3397,7 +3397,7 @@
 {
 size_t Location = GetModelColumnPos( nColId );
 DbGridColumn* pColumn = ( Location  m_aColumns.size() ) ? 
m_aColumns[ Location ] : NULL;
-OStringTransfer::CopyString( GetCurrentRowCellText( 
pColumn,m_xPaintRow ), this );
+OStringTransfer::CopyString( GetCurrentRowCellText( pColumn, 
m_xCurrentRow ), this );
 return;
 }
 }

-- 
To view, visit https://gerrit.libreoffice.org/3379
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39be862abb7c72234adad9c517d4a0570a1d71ae
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#12).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#13).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#14).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-14 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#15).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH libreoffice-4-0] fdo#61142 mixup between size and length

2013-04-14 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3385

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/3385/1

fdo#61142 mixup between size and length

Change-Id: Ia2903d5139378e97bb2e8d00ccb2c213d3e1dee6
---
M connectivity/source/drivers/odbcbase/OTools.cxx
1 file changed, 9 insertions(+), 5 deletions(-)



diff --git a/connectivity/source/drivers/odbcbase/OTools.cxx 
b/connectivity/source/drivers/odbcbase/OTools.cxx
index d568b7f..7165c4d 100644
--- a/connectivity/source/drivers/odbcbase/OTools.cxx
+++ b/connectivity/source/drivers/odbcbase/OTools.cxx
@@ -424,11 +424,15 @@
 // we assume everyone (LibO  ODBC) uses UTF-16; see 
OPreparedStatement::setParameter
 BOOST_STATIC_ASSERT(sizeof(sal_Unicode) == 2);
 BOOST_STATIC_ASSERT(sizeof(SQLWCHAR)== 2);
-// read the unicode data
-const SQLLEN nMaxLen = sizeof(waCharArray) / sizeof(sal_Unicode);
-SQLLEN pcbValue = SQL_NO_TOTAL;
+BOOST_STATIC_ASSERT(sizeof(waCharArray) % 2 == 0);
+// Size == number of bytes, Len == number of UTF-16 code units
+const SQLLEN nMaxSize = sizeof(waCharArray);
+const SQLLEN nMaxLen  = sizeof(waCharArray) / sizeof(sal_Unicode);
+BOOST_STATIC_ASSERT(nMaxLen * sizeof(sal_Unicode) == nMaxSize);
 
-while ((pcbValue == SQL_NO_TOTAL ) || (pcbValue = nMaxLen) )
+// read the unicode data
+SQLLEN pcbValue = SQL_NO_TOTAL;
+while ((pcbValue == SQL_NO_TOTAL ) || (pcbValue = nMaxSize) )
 {
 OTools::ThrowException(_pConnection,

(*(T3SQLGetData)_pConnection-getOdbcFunction(ODBC3SQLGetData))(
@@ -446,7 +450,7 @@
 SQLLEN nReadChars;
 OSL_ENSURE( (pcbValue  0) || (pcbValue % 2 == 0),
 ODBC: SQLGetData of SQL_C_WCHAR returned odd number 
of bytes);
-if ( (pcbValue == SQL_NO_TOTAL) || (pcbValue = nMaxLen) )
+if ( (pcbValue == SQL_NO_TOTAL) || (pcbValue = nMaxSize) )
 {
 // we filled the buffer; remove the terminating null character
 nReadChars = nMaxLen-1;

-- 
To view, visit https://gerrit.libreoffice.org/3385
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2903d5139378e97bb2e8d00ccb2c213d3e1dee6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] gcc -dumpversion has only MAJOR.MINOR, not MAJOR.MINOR.PATCH...

2013-04-13 Thread Lionel Elie Mamane (via Code Review)

Lionel Elie Mamane has abandoned this change.

Change subject: gcc -dumpversion has only MAJOR.MINOR, not 
MAJOR.MINOR.PATCHLEVEL
..


Patch Set 1: Abandoned

-- 
To view, visit https://gerrit.libreoffice.org/3362
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I94ea73628d8aac107e3ada1dc5a63e51e79ccdb2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-04-13 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#11).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/formcomponenthandler.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/inc/chgtrack.hxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/chgtrack.cxx
M sc/source/core/tool/chgviset.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/oox/unitconverter.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xcl97/XclImpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/docshell/docsh3.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/doc/docredln.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/Library_tl.mk
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx

[PATCH] gcc -dumpversion has only MAJOR.MINOR, not MAJOR.MINOR.PATCH...

2013-04-12 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3362

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3362/1

gcc -dumpversion has only MAJOR.MINOR, not MAJOR.MINOR.PATCHLEVEL

Change-Id: I94ea73628d8aac107e3ada1dc5a63e51e79ccdb2
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/configure.ac b/configure.ac
index 6e45005..b7ed6ec 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2710,7 +2710,7 @@
 dnl ===
 if test $GCC = yes; then
 AC_MSG_CHECKING([the GCC version])
-_gcc_version=`$CC -dumpversion`
+_gcc_version=`$CC --version|head -n1|sed 's/^.* //g'`
 _gcc_major=`echo $_gcc_version | $AWK -F. '{ print \$1 }'`
 GCCVER=`echo $_gcc_version | $AWK -F. '{ print \$1*1+\$2*100+\$3 }'`
 

-- 
To view, visit https://gerrit.libreoffice.org/3362
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94ea73628d8aac107e3ada1dc5a63e51e79ccdb2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] fdo#36858

2013-04-12 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3363

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3363/1

fdo#36858

1) No valueType (Format/Number/General) is like float valueType 
(Format/Number/any other)
2) We use 1/1/1900 as startdate for number-from-date, stick to it more 
consistently

Change-Id: Ib1008d1c30be602d8173457738c915087ed17391
---
M 
reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
1 file changed, 8 insertions(+), 3 deletions(-)



diff --git 
a/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
 
b/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
index 99ff3e5..f82d890 100644
--- 
a/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
+++ 
b/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
@@ -126,9 +126,10 @@
 }
 else if (value instanceof java.sql.Date)
 {
-if (float.equals(valueType))//@see 
http://qa.openoffice.org/issues/show_bug.cgi?id=108954
+if (float.equals(valueType) || valueType == null)
 {
-variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, 
VALUE, HSSFDateUtil.getExcelDate((Date) value, false, 2).toString());
+// This is to work around fdo#63478
+variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, 
VALUE, HSSFDateUtil.getExcelDate((Date) value, false, 0).toString());
 }
 else
 {
@@ -137,8 +138,12 @@
 }
 else if (value instanceof Date)
 {
+// This is what we *should* do, but see fdo#63478
+// variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, 
VALUE_TYPE, date);
+// variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, 
date-value, formatDate((Date) value));
+// so we do that instead to work around:
 variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, 
VALUE_TYPE, float);
-variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, VALUE, 
HSSFDateUtil.getExcelDate((Date) value, false, 2).toString());
+variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, VALUE, 
HSSFDateUtil.getExcelDate((Date) value, false, 0).toString());
 }
 else if (value instanceof BigDecimal)
 {

-- 
To view, visit https://gerrit.libreoffice.org/3363
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1008d1c30be602d8173457738c915087ed17391
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] reportbuilder: do not use empty tablename

2013-04-11 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3341

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3341/1

reportbuilder: do not use empty tablename

Change-Id: I03ed5e810468ee206820a250c740b80c0ceda432
---
M reportbuilder/java/com/sun/star/report/SDBCReportDataFactory.java
1 file changed, 9 insertions(+), 1 deletion(-)



diff --git a/reportbuilder/java/com/sun/star/report/SDBCReportDataFactory.java 
b/reportbuilder/java/com/sun/star/report/SDBCReportDataFactory.java
index d0168a6..d940718 100644
--- a/reportbuilder/java/com/sun/star/report/SDBCReportDataFactory.java
+++ b/reportbuilder/java/com/sun/star/report/SDBCReportDataFactory.java
@@ -253,7 +253,15 @@
 try
 {
 column = 
UnoRuntime.queryInterface(XPropertySet.class, columns.getByName(expression));
-expression = quote + 
column.getPropertyValue(TableName) + quote + . + quote + expression + quote;
+String prefix;
+prefix = 
(String)column.getPropertyValue(TableName);
+if (prefix == null)
+prefix = ;
+if (prefix.length()  0)
+{
+prefix = quote + prefix + quote + .;
+}
+expression = prefix + quote + expression + 
quote;
 }
 catch (Exception ex)
 {

-- 
To view, visit https://gerrit.libreoffice.org/3341
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03ed5e810468ee206820a250c740b80c0ceda432
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] pgsql-sdbc: set tablename even if we do not know the schema

2013-04-11 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3342

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3342/1

pgsql-sdbc: set tablename even if we do not know the schema

Change-Id: I74c04e1262cc413696a12aca9af603beded7b07f
---
M connectivity/source/drivers/postgresql/pq_statement.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
2 files changed, 13 insertions(+), 3 deletions(-)



diff --git a/connectivity/source/drivers/postgresql/pq_statement.cxx 
b/connectivity/source/drivers/postgresql/pq_statement.cxx
index 7304b15..edf7dc3 100644
--- a/connectivity/source/drivers/postgresql/pq_statement.cxx
+++ b/connectivity/source/drivers/postgresql/pq_statement.cxx
@@ -654,7 +654,7 @@
 }
 
 }
-else if( sourceTable.getLength()  -1 != sourceTable.indexOf( '.' ) )
+else if( sourceTable.getLength()  0)
 {
 splitConcatenatedIdentifier( sourceTable, schema, table );
 }
diff --git a/connectivity/source/drivers/postgresql/pq_tools.cxx 
b/connectivity/source/drivers/postgresql/pq_tools.cxx
index 84d9741..86872a7 100644
--- a/connectivity/source/drivers/postgresql/pq_tools.cxx
+++ b/connectivity/source/drivers/postgresql/pq_tools.cxx
@@ -673,10 +673,20 @@
 {
 OStringVector vec;
 tokenizeSQL( rtl::OUStringToOString( source, RTL_TEXTENCODING_UTF8 ), vec 
);
-if( vec.size() == 3 )
+switch (vec.size())
 {
-*first = rtl::OStringToOUString( vec[0] , RTL_TEXTENCODING_UTF8 );
+case 1:
+*first  = OUString();
+*second = rtl::OStringToOUString( vec[0], RTL_TEXTENCODING_UTF8 );
+break;
+case 3:
+*first  = rtl::OStringToOUString( vec[0], RTL_TEXTENCODING_UTF8 );
 *second = rtl::OStringToOUString( vec[2], RTL_TEXTENCODING_UTF8 );
+break;
+default:
+ SAL_WARN(connectivity.drivers.postgresql,
+  pq_tools::splitConcatenatedIdentifier unexpected number of 
tokens in identifier: 
+   vec.size());
 }
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/3342
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74c04e1262cc413696a12aca9af603beded7b07f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] pgsql-sdbc: ResultSetMetaData::getTableName return tablename...

2013-04-11 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3343

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3343/1

pgsql-sdbc: ResultSetMetaData::getTableName return tablename (without schema)

Change-Id: I319ba91045fa43922d7b694a4f13322295590c81
---
M connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
1 file changed, 1 insertion(+), 10 deletions(-)



diff --git a/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx 
b/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
index f6089cc..6d9abf9 100644
--- a/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
+++ b/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
@@ -407,16 +407,7 @@
 {
 (void) column;
 // LEM TODO This is very fishy.. Should probably return the table to which 
that column belongs!
-rtl::OUString ret;
-if( m_tableName.getLength() )
-{
-OUStringBuffer buf( 128 );
-buf.append( m_schemaName );
-buf.appendAscii( . );
-buf.append( m_tableName );
-ret = buf.makeStringAndClear();
-}
-return ret;
+return m_tableName;
 }
 
 ::rtl::OUString ResultSetMetaData::getCatalogName( sal_Int32 column )

-- 
To view, visit https://gerrit.libreoffice.org/3343
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I319ba91045fa43922d7b694a4f13322295590c81
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63391 deadlock on opening .odb file that auto-connects t...

2013-04-10 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3310

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/3310/1

fdo#63391 deadlock on opening .odb file that auto-connects to the database

Let foo.odb be a database file that has a macro that connects to the
Database on Open Document event (and needs to prompt user for
user/password).

There was a race condition between two actions:

 1) the asynchronous treatment of OnFirstControllerConnected in 
dbaui::OApplicationController,
which tries to get dbaui::OApplicationController's mutex

 2) the StarBasic macro calling dbaui::OApplicationController::connect
which needs to display a dialog (to get username and password),
and thus puts that dialog in the main thread's event queue
and waits for it ... with dbaui::OApplicationController's mutex held

Now, if 1) is before 2) in the event queue of the the main thread,
*but* 1) is executed *after* 2) has taken the lock, there is a deadlock.

Fix:

 1) Make OnFirstControllerConnected synchronous.
Make sure (by taking mutex in dbaui::OApplicationController::attachFrame, 
its ancestor in the call graph)
that nothing else will happen with the OApplicationController as long as it 
is not finished.
--- it does not need to take mutex itself anymore

This avoids the order in the asynchronous events dependency.

 2) Change dbaui::OApplicationController::ensureConnection to do the user 
prompting
WITHOUT HOLDING the mutex, and use the mutex only to protect actually 
assigning
the connection to m_xDataSourceConnection.

Theoretically, in some race condition, we could connect twice and then 
discard one connection shrug.
ensureConnection will never return the discarded connection, though.

(I think I got that right with respect to 
http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html)

This keeps it from locking on another condition while holding the mutex.

Change-Id: Iab1bbec5d5df12bb89d027d43e498c78c92ffc32
---
M dbaccess/source/ui/app/AppController.cxx
M dbaccess/source/ui/app/AppController.hxx
M dbaccess/source/ui/app/AppControllerDnD.cxx
M dbaccess/source/ui/app/AppControllerGen.cxx
4 files changed, 63 insertions(+), 22 deletions(-)



diff --git a/dbaccess/source/ui/app/AppController.cxx 
b/dbaccess/source/ui/app/AppController.cxx
index 53b6555..c943ed3 100644
--- a/dbaccess/source/ui/app/AppController.cxx
+++ b/dbaccess/source/ui/app/AppController.cxx
@@ -304,7 +304,6 @@
 ,m_aTableCopyHelper(this)
 ,m_pClipbordNotifier(NULL)
 ,m_nAsyncDrop(0)
-,m_aControllerConnectedEvent( LINK( this, OApplicationController, 
OnFirstControllerConnected ) )
 ,m_aSelectContainerEvent( LINK( this, OApplicationController, 
OnSelectContainer ) )
 ,m_ePreviewMode(E_PREVIEWNONE)
 ,m_eCurrentType(E_NONE)
@@ -361,8 +360,6 @@
 //
 void SAL_CALL OApplicationController::disposing()
 {
-m_aControllerConnectedEvent.CancelCall();
-
 
::std::for_each(m_aCurrentContainers.begin(),m_aCurrentContainers.end(),XContainerFunctor(this));
 m_aCurrentContainers.clear();
 m_pSubComponentManager-disposing();
@@ -2644,14 +2641,12 @@
 return;
 }
 
-m_aControllerConnectedEvent.Call();
+OnFirstControllerConnected();
 }
 
 // 
-
-IMPL_LINK( OApplicationController, OnFirstControllerConnected, void*, /**/ )
+void OApplicationController::OnFirstControllerConnected()
 {
-::osl::MutexGuard aGuard( getMutex() );
-
 if ( !m_xModel.is() )
 {
 OSL_FAIL( OApplicationController::OnFirstControllerConnected: too 
late! );
@@ -2665,7 +2660,7 @@
 // no need to show this warning, obviously the document supports 
embedding scripts
 // into itself, so there are no old-style forms/reports which have 
macros/scripts
 // themselves
-return 0L;
+return;
 }
 
 try
@@ -2674,12 +2669,12 @@
 // In this case, we should not show the warning, again.
 ::comphelper::NamedValueCollection aModelArgs( m_xModel-getArgs() );
 if ( aModelArgs.getOrDefault( SuppressMigrationWarning, sal_False ) )
-return 0L;
+return;
 
 // also, if the document is read-only, then no migration is possible, 
and the
 // respective menu entry is hidden. So, don't show the warning in this 
case, too.
 if ( Reference XStorable ( m_xModel, UNO_QUERY_THROW )-isReadonly() 
)
-return 0L;
+return;
 
 SQLWarning aWarning;
 aWarning.Message = OUString( ModuleRes( STR_SUB_DOCS_WITH_SCRIPTS ) );
@@ -2695,12 +2690,14 @@
 DBG_UNHANDLED_EXCEPTION();
 }
 
-return 1L;
+return;
 }
 
 // 
-
 void SAL_CALL

[PATCH libreoffice-4-0] work around fdo#62147

2013-04-10 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3311

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/3311/1

work around fdo#62147

don't emit string-value attribute

Change-Id: I3668b88437451523f2b6bb3c2c82e1929f7ba3d8
---
M 
reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git 
a/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
 
b/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
index 99ff3e5..ad303af 100644
--- 
a/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
+++ 
b/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/FormatValueUtility.java
@@ -189,7 +189,8 @@
 {
 variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, 
VALUE_TYPE, string);
 }
-variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, 
STRING_VALUE, String.valueOf(value));
+// work around fdo#62147
+//variableSection.setAttribute(OfficeNamespaces.OFFICE_NS, 
STRING_VALUE, String.valueOf(value));
 }
 else
 {

-- 
To view, visit https://gerrit.libreoffice.org/3311
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3668b88437451523f2b6bb3c2c82e1929f7ba3d8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] WIP: date/time IDL datatypes incompatible change

2013-03-23 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot, Eike Rathke,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2783

to look at the new patch set (#10).

Change subject: WIP: date/time IDL datatypes incompatible change
..

WIP: date/time IDL datatypes incompatible change

Done:
 - nanosecond precision
 - signed (allowed negative) year

TODO: timezone

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
---
M basic/source/runtime/methods.cxx
M comphelper/source/misc/anycompare.cxx
M comphelper/source/misc/types.cxx
M connectivity/inc/connectivity/dbconversion.hxx
M connectivity/source/commontools/FValue.cxx
M connectivity/source/commontools/dbconversion.cxx
M connectivity/source/drivers/calc/CTable.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FDateFunctions.cxx
M connectivity/source/drivers/jdbc/ConnectionLog.cxx
M connectivity/source/drivers/kab/KResultSet.cxx
M connectivity/source/drivers/macab/macabutilities.hxx
M connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx
M connectivity/source/drivers/odbcbase/OPreparedStatement.cxx
M connectivity/source/drivers/odbcbase/OResultSet.cxx
M connectivity/source/drivers/postgresql/pq_tools.cxx
M connectivity/source/inc/odbc/OTools.hxx
M editeng/source/items/flditem.cxx
M editeng/source/uno/unofield.cxx
M extensions/source/logging/csvformatter.cxx
M extensions/source/logging/logrecord.cxx
M extensions/source/logging/plaintextformatter.cxx
M extensions/source/propctrlr/standardcontrol.cxx
M filter/source/msfilter/svdfppt.cxx
M forms/qa/integration/forms/TimeValidator.java
M forms/source/component/Time.cxx
M forms/source/xforms/convert.cxx
M forms/source/xforms/datatypes.cxx
M framework/source/jobs/jobdata.cxx
M odk/examples/DevelopersGuide/Forms/TimeValidator.java
M offapi/com/sun/star/util/Date.idl
M offapi/com/sun/star/util/DateTime.idl
M offapi/com/sun/star/util/DateTimeRange.idl
M offapi/com/sun/star/util/Duration.idl
M offapi/com/sun/star/util/Time.idl
M offapi/type_reference/types.rdb
M oox/source/core/xmlfilterbase.cxx
M oox/source/dump/dumperbase.cxx
M oox/source/ppt/comments.cxx
M qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
M reportbuilder/java/org/libreoffice/report/SDBCReportData.java
M reportdesign/source/filter/xml/xmlControlProperty.cxx
M sax/qa/cppunit/test_converter.cxx
M sax/source/tools/converter.cxx
M sc/source/core/data/dbdocutl.cxx
M sc/source/core/data/dpobject.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/xcl97/XclExpChangeTrack.cxx
M sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
M sc/source/filter/xml/XMLConverter.cxx
M sc/source/ui/miscdlgs/sharedocdlg.cxx
M sc/source/ui/unoobj/fielduno.cxx
M sc/source/ui/view/viewfun6.cxx
M scripting/source/pyprov/pythonscript.py
M sd/source/filter/eppt/eppt.cxx
M sd/source/filter/eppt/pptx-epptooxml.cxx
M sd/source/ui/annotations/annotationmanager.cxx
M sd/source/ui/dlg/animobjs.cxx
M sfx2/qa/complex/sfx2/DocumentProperties.java
M sfx2/source/appl/sfxpicklist.cxx
M sfx2/source/bastyp/frmhtmlw.cxx
M sfx2/source/bastyp/helper.cxx
M sfx2/source/dialog/dinfdlg.cxx
M sfx2/source/dialog/versdlg.cxx
M sfx2/source/doc/SfxDocumentMetaData.cxx
M sfx2/source/doc/objcont.cxx
M sfx2/source/doc/oleprops.cxx
M sfx2/source/view/viewprn.cxx
M svl/source/items/dateitem.cxx
M svl/source/misc/fstathelper.cxx
M svtools/source/contnr/DocumentInfoPreview.cxx
M svtools/source/contnr/contentenumeration.cxx
M svtools/source/misc/templatefoldercache.cxx
M svtools/source/svhtml/parhtml.cxx
M svtools/source/table/cellvalueconversion.cxx
M svx/source/fmcomp/gridcell.cxx
M sw/source/core/doc/doccomp.cxx
M sw/source/core/doc/docglbl.cxx
M sw/source/core/fields/docufld.cxx
M sw/source/core/fields/flddat.cxx
M sw/source/core/unocore/swunohelper.cxx
M sw/source/core/unocore/unoredline.cxx
M sw/source/filter/ww8/wrtww8.cxx
M sw/source/filter/ww8/ww8par.cxx
M sw/source/filter/xml/XMLRedlineImportHelper.cxx
M tools/inc/tools/datetime.hxx
M tools/inc/tools/time.hxx
M tools/source/datetime/datetime.cxx
M tools/source/datetime/ttime.cxx
M tools/source/inet/inetmsg.cxx
M tools/source/rc/rc.cxx
M ucb/source/sorter/sortresult.cxx
M ucb/source/ucp/cmis/cmis_content.cxx
M ucb/source/ucp/file/shell.cxx
M ucb/source/ucp/ftp/ftpdirp.cxx
M ucb/source/ucp/ftp/ftpdirp.hxx
M unotools/inc/unotools/datetime.hxx
M unotools/source/i18n/localedatawrapper.cxx
M unotools/source/misc/datetime.cxx
M unotools/source/ucbhelper/ucbhelper.cxx
M vcl/source/control/field2.cxx
M wizards/com/sun/star/wizards/common/JavaTools.java
M xmloff/source/core/xmluconv.cxx
M xmloff/source/draw/animationimport.cxx
M xmloff/source/forms/elementexport.cxx
M xmloff/source/forms/elementimport.cxx
M xmloff/source/forms/handler/vcl_time_handler.cxx
M

[PATCH libreoffice-4-0] fdo#61564 when WrappedTargetException not in specification, ...

2013-03-12 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2684

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/2684/1

fdo#61564 when WrappedTargetException not in specification, do not throw it!

Change-Id: Id3c995557f320b1d0241f0ef5d94b1c9aeb66528
---
M dbaccess/source/core/dataaccess/documentcontainer.cxx
1 file changed, 3 insertions(+), 2 deletions(-)



diff --git a/dbaccess/source/core/dataaccess/documentcontainer.cxx 
b/dbaccess/source/core/dataaccess/documentcontainer.cxx
index 54cda92..8b8116a 100644
--- a/dbaccess/source/core/dataaccess/documentcontainer.cxx
+++ b/dbaccess/source/core/dataaccess/documentcontainer.cxx
@@ -38,6 +38,7 @@
 #include core_resource.hxx
 #include core_resource.hrc
 #include comphelper/namedvaluecollection.hxx
+#include com/sun/star/lang/WrappedTargetRuntimeException.hpp
 
 #include vcl/svapp.hxx
 #include osl/mutex.hxx
@@ -557,9 +558,9 @@
 {
 throw IllegalArgumentException();
 }
-catch(const WrappedTargetException)
+catch(const WrappedTargetException e)
 {
-throw;
+throw WrappedTargetRuntimeException(e.Message, e.Context, 
e.TargetException);
 }
 return xComp;
 }

-- 
To view, visit https://gerrit.libreoffice.org/2684
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3c995557f320b1d0241f0ef5d94b1c9aeb66528
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] fdo#61166 text format: correctly chain the formatter-getOut...

2013-03-06 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2570

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2570/1

fdo#61166 text format: correctly chain the formatter-getOutputString calls

cf commit 271b11a3d56ba0c5f542a142ab859a0819530dba, copy/paste error

Change-Id: I9a5391cd9d77d181026abffa3ea2f036c7009ade
---
M svtools/source/control/fmtfield.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/svtools/source/control/fmtfield.cxx 
b/svtools/source/control/fmtfield.cxx
index 181bc71..6c0258b 100644
--- a/svtools/source/control/fmtfield.cxx
+++ b/svtools/source/control/fmtfield.cxx
@@ -954,7 +954,7 @@
 ImplGetFormatter()-GetOutputString(dVal, 0, sTemp, 
m_pLastOutputColor);
 // dann den String entsprechend dem Text-Format
 {
-OUString sTempIn(m_sCurrentTextValue);
+OUString sTempIn(sTemp);
 OUString sTempOut;
 ImplGetFormatter()-GetOutputString(sTempIn, m_nFormatKey, sTempOut, 
m_pLastOutputColor);
 sNewText = sTempOut;

-- 
To view, visit https://gerrit.libreoffice.org/2570
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a5391cd9d77d181026abffa3ea2f036c7009ade
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Add new dialog to Query Design View

2013-03-04 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2508

to look at the new patch set (#3).

Change subject: Add new dialog to Query Design View
..

Add new dialog to Query Design View

In Query Properties Dialog can be set properties like
distinct values and limit.
To open choose Edit\Query Properties.

Steps of implementation:
- Add new slot to Edit menu (menubar.xml): delete the slot of distinct values,
  because it can set in this dialog too
- Separate LimitBox class from limitboxcontroller.cxx (LimitBox.hxx\cxx)
  With it only LimitBox header is included in the dialog source.
- Extend LimitBox class to work with new layout widget (make... and 
GetOptimalSize())
  and add it to the galde catalog
- Make a class for the new dialog (QueryPropertiesDialog.hxx\cxx) and
  write the .ui file. (querypropertiesdialog.ui)
- Syncronize the two LimitBox (querycontroller.cxx)

Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
---
M dbaccess/Library_dbu.mk
M dbaccess/Module_dbaccess.mk
A dbaccess/UI_dbaccess.mk
M dbaccess/inc/dbaccess_slotid.hrc
A dbaccess/source/ui/dlg/QueryPropertiesDialog.cxx
A dbaccess/source/ui/inc/LimitBox.hxx
A dbaccess/source/ui/inc/QueryPropertiesDialog.hxx
M dbaccess/source/ui/inc/querycontroller.hxx
A dbaccess/source/ui/querydesign/LimitBox.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.hxx
M dbaccess/source/ui/querydesign/querycontroller.cxx
M dbaccess/uiconfig/dbquery/menubar/menubar.xml
A dbaccess/uiconfig/ui/querypropertiesdialog.ui
M extras/source/glade/libreoffice-catalog.xml
M officecfg/registry/data/org/openoffice/Office/UI/DbuCommands.xcu
16 files changed, 617 insertions(+), 135 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2508/3
-- 
To view, visit https://gerrit.libreoffice.org/2508
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Zolnai Tamás zolnaitamas2...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Add new dialog to Query Design View

2013-03-04 Thread Lionel Elie Mamane (via Code Review)

Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2508

to look at the new patch set (#4).

Change subject: Add new dialog to Query Design View
..

Add new dialog to Query Design View

In Query Properties Dialog can be set properties like
distinct values and limit.
To open choose Edit\Query Properties.

Steps of implementation:
- Add new slot to Edit menu (menubar.xml): delete the slot of distinct values,
  because it can set in this dialog too
- Separate LimitBox class from limitboxcontroller.cxx (LimitBox.hxx\cxx)
  With it only LimitBox header is included in the dialog source.
- Extend LimitBox class to work with new layout widget (make... and 
GetOptimalSize())
  and add it to the galde catalog
- Make a class for the new dialog (QueryPropertiesDialog.hxx\cxx) and
  write the .ui file. (querypropertiesdialog.ui)
- Syncronize the two LimitBox (querycontroller.cxx)

Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
---
M dbaccess/Library_dbu.mk
M dbaccess/Module_dbaccess.mk
A dbaccess/UI_dbaccess.mk
M dbaccess/inc/dbaccess_slotid.hrc
A dbaccess/source/ui/dlg/QueryPropertiesDialog.cxx
A dbaccess/source/ui/inc/LimitBox.hxx
A dbaccess/source/ui/inc/QueryPropertiesDialog.hxx
M dbaccess/source/ui/inc/querycontroller.hxx
A dbaccess/source/ui/querydesign/LimitBox.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.hxx
M dbaccess/source/ui/querydesign/querycontroller.cxx
M dbaccess/uiconfig/dbquery/menubar/menubar.xml
A dbaccess/uiconfig/ui/querypropertiesdialog.ui
M extras/source/glade/libreoffice-catalog.xml
M officecfg/registry/data/org/openoffice/Office/UI/DbuCommands.xcu
16 files changed, 617 insertions(+), 135 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2508/4
-- 
To view, visit https://gerrit.libreoffice.org/2508
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Zolnai Tamás zolnaitamas2...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Add new dialog to Query Design View

2013-03-04 Thread Lionel Elie Mamane (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2508


-- 
To view, visit https://gerrit.libreoffice.org/2508
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Zolnai Tamás zolnaitamas2...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] ORowSetValue: clean up sign/unsigned union member

2013-02-05 Thread Lionel Elie Mamane (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1164

Objections:
  Luboš Luňák: Do not submit


-- 
To view, visit https://gerrit.libreoffice.org/1164
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f1f08716127147f077bff4edb6ec558b1b09e09
Gerrit-PatchSet: 17
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-4-0]: OSQLParser::RuleIDToRule should not silently change s_aRever...

2013-01-25 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1826

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/1826/1

OSQLParser::RuleIDToRule should not silently change s_aReverseRuleIDLookup

Change-Id: I2b408a23162b1200bbcd530be7acb42435388b04
---
M connectivity/source/parse/sqlbison.y
M sal/inc/sal/log-areas.dox
2 files changed, 13 insertions(+), 1 deletion(-)



diff --git a/connectivity/source/parse/sqlbison.y 
b/connectivity/source/parse/sqlbison.y
index 96d0782..a0f7d43 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -4772,7 +4772,18 @@
 //-
 OSQLParseNode::Rule OSQLParser::RuleIDToRule( sal_uInt32 _nRule )
 {
-return s_aReverseRuleIDLookup[ _nRule ];
+OSQLParser::RuleIDMap::const_iterator i 
(s_aReverseRuleIDLookup.find(_nRule));
+if (i == s_aReverseRuleIDLookup.end())
+{
+SAL_WARN(connectivity.parse,
+connectivity::OSQLParser::RuleIDToRule cannot reverse-lookup 
rule. 
+Reverse mapping incomplete? 
+_nRule='  _nRule  ' 
+yytname[_nRule]='  yytname[_nRule]  ');
+return OSQLParseNode::UNKNOWN_RULE;
+}
+else
+return i-second;
 }
 
 //-
diff --git a/sal/inc/sal/log-areas.dox b/sal/inc/sal/log-areas.dox
index c167267..b5fa6f9 100644
--- a/sal/inc/sal/log-areas.dox
+++ b/sal/inc/sal/log-areas.dox
@@ -37,6 +37,7 @@
 @section connectivity
 
 @li @c connectivity.mork
+@li @c connectivity.parse
 
 @section cui
 

-- 
To view, visit https://gerrit.libreoffice.org/1826
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b408a23162b1200bbcd530be7acb42435388b04
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-4-0]: fix handling of subqueries in query design

2013-01-25 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1827

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/1827/1

fix handling of subqueries in query design

 - don't remove parentheses around subqueries
   (without the parentheses, it is not valid SQL)
   * when saving a Field (name value) typed by the user interactively
   * when parsing SQL and constructing the initial Query Design view

 - automatically add the necessary parentheses
   when a SELECT statement is entered as column name

Also:

In code saving a Field (name value) typed by the user interactively,
factorise some common code

Assorted minor fixes (typos in comments, etc)

Change-Id: I3843258323c903cba23238b0730ec4eb5875f792
---
M dbaccess/source/ui/querydesign/QueryDesignView.cxx
M dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
M dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx
3 files changed, 50 insertions(+), 35 deletions(-)



diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx 
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 3c386db..8264152 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -2198,7 +2198,8 @@
 pColumnRef = pColumnRef-getChild(0);
 OTableFieldDescRef aInfo = new OTableFieldDesc();
 
-if (pColumnRef-count() == 3 
+if (pColumnRef-getKnownRuleID() != 
OSQLParseNode::subquery 
+pColumnRef-count() == 3 
 SQL_ISPUNCTUATION(pColumnRef-getChild(0),() 
 SQL_ISPUNCTUATION(pColumnRef-getChild(2),))
 )
diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx 
b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index 5544549..e85cb29 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -649,7 +649,7 @@
 return bError;
 }
 // 
-
-sal_Bool OSelectionBrowseBox::saveField(const String 
_sFieldName,OTableFieldDescRef _pEntry,sal_Bool _bListAction)
+sal_Bool OSelectionBrowseBox::saveField(String _sFieldName 
,OTableFieldDescRef _pEntry, sal_Bool _bListAction)
 {
 sal_Bool bError = sal_False;
 
@@ -680,50 +680,63 @@
 // we have to look which entries  we should quote
 
 const ::rtl::OUString sFieldAlias = _pEntry-GetFieldAlias();
-size_t nPass = 4;
 ::connectivity::OSQLParser rParser( rController.getParser() );
-OSQLParseNode* pParseNode = NULL;
-// 4 passes in trying to interprete the field name
-// - don't quote the field name, parse internationally
-// - don't quote the field name, parse en-US
-// - quote the field name, parse internationally
-// - quote the field name, parse en-US
-do
 {
-bool bQuote = ( nPass = 2 );
-bool bInternational = ( nPass % 2 ) == 0;
+// automatically add parentheses around subqueries
+OSQLParseNode *pParseNode = NULL;
+OUString devnull;
+pParseNode = rParser.parseTree( devnull, _sFieldName, true );
+if (pParseNode == NULL)
+pParseNode = rParser.parseTree( devnull, _sFieldName, false );
+if (pParseNode != NULL  SQL_ISRULE(pParseNode, select_statement))
+_sFieldName = ::rtl::OUString(() + _sFieldName + );
+}
 
-::rtl::OUString sSql;
-if ( bQuote )
-sSql += ::dbtools::quoteName( 
xMetaData-getIdentifierQuoteString(), _sFieldName );
-else
-sSql += _sFieldName;
+OSQLParseNode* pParseNode = NULL;
+{
+// 4 passes in trying to interprete the field name
+// - don't quote the field name, parse internationally
+// - don't quote the field name, parse en-US
+// - quote the field name, parse internationally
+// - quote the field name, parse en-US
+size_t nPass = 4;
+::rtl::OUString sQuotedFullFieldName(::dbtools::quoteName( 
xMetaData-getIdentifierQuoteString(), _sFieldName ));
+::rtl::OUString sFullFieldName(_sFieldName);
 
 if  ( _pEntry-isAggreateFunction() )
 {
 OSL_ENSURE(!_pEntry-GetFunction().isEmpty(),Functionname darf 
hier nicht leer sein! ;-();
-::rtl::OUStringBuffer aTmpStr2( _pEntry-GetFunction());
-aTmpStr2.appendAscii(();
-aTmpStr2.append(sSql);
-aTmpStr2.appendAscii());
-sSql = aTmpStr2.makeStringAndClear();
+sQuotedFullFieldName = _pEntry-GetFunction() + ( + 
sQuotedFullFieldName + );
+sFullFieldName = _pEntry-GetFunction() + ( + sFullFieldName + 
);
 }
 
-sSql = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(SELECT )) + sSql;
-if ( !sFieldAlias.isEmpty() )
-{ // always

[PATCH] Change in core[libreoffice-4-0]: mark all tables of a nested join as added

2013-01-18 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1756

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/1756/1

mark *all* tables of a nested join as added

Else, if the n^{th} (with n2) table also appears in a (non-NATURAL) INNER 
JOIN, it is repeated later, leading to an error from the database engine

Change-Id: I03e0f0ef51f45be9d7ddfa63a9dbe09dc500f8dd
---
M dbaccess/source/ui/querydesign/QueryDesignView.cxx
1 file changed, 33 insertions(+), 18 deletions(-)



diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx 
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 816991a..3c386db 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -476,10 +476,29 @@
 return BuildJoin(_xConnection, rRh, BuildTable(_xConnection,pLh), 
data);
 }
 
//--
+typedef ::std::map ::rtl::OUString,sal_Bool,::comphelper::UStringMixLess 
tableNames_t;
+
//--
+void addConnectionTableNames( const Reference XConnection _xConnection,
+  const OQueryTableConnection* const 
pEntryConn,
+  tableNames_t _rTableNames )
+{
+// insert tables into table list to avoid double entries
+const OQueryTableWindow* const pEntryTabFrom = 
static_castOQueryTableWindow*(pEntryConn-GetSourceWin());
+const OQueryTableWindow* const pEntryTabTo = 
static_castOQueryTableWindow*(pEntryConn-GetDestWin());
+
+::rtl::OUString sTabName(BuildTable(_xConnection,pEntryTabFrom));
+if(_rTableNames.find(sTabName) == _rTableNames.end())
+_rTableNames[sTabName] = sal_True;
+sTabName = BuildTable(_xConnection,pEntryTabTo);
+if(_rTableNames.find(sTabName) == _rTableNames.end())
+_rTableNames[sTabName] = sal_True;
+}
+
//--
 void GetNextJoin(   const Reference XConnection _xConnection,
 OQueryTableConnection* pEntryConn,
 OQueryTableWindow* pEntryTabTo,
-::rtl::OUString aJoin)
+::rtl::OUString aJoin,
+tableNames_t _rTableNames)
 {
 OQueryTableConnectionData* pEntryConnData = 
static_castOQueryTableConnectionData*(pEntryConn-GetData().get());
 if ( pEntryConnData-GetJoinType() == INNER_JOIN  
!pEntryConnData-isNatural() )
@@ -487,15 +506,18 @@
 
 if(aJoin.isEmpty())
 {
+addConnectionTableNames(_xConnection, pEntryConn, _rTableNames);
 OQueryTableWindow* pEntryTabFrom = 
static_castOQueryTableWindow*(pEntryConn-GetSourceWin());
 aJoin = 
BuildJoin(_xConnection,pEntryTabFrom,pEntryTabTo,pEntryConnData);
 }
 else if(pEntryTabTo == pEntryConn-GetDestWin())
 {
+addConnectionTableNames(_xConnection, pEntryConn, _rTableNames);
 aJoin = BuildJoin(_xConnection,aJoin,pEntryTabTo,pEntryConnData);
 }
 else if(pEntryTabTo == pEntryConn-GetSourceWin())
 {
+addConnectionTableNames(_xConnection, pEntryConn, _rTableNames);
 aJoin = BuildJoin(_xConnection,pEntryTabTo,aJoin,pEntryConnData);
 }
 
@@ -514,7 +536,7 @@
 // exists there a connection to a OQueryTableWindow that holds 
a connection that has been already visited
 JoinCycle(_xConnection,pNext,pEntryTab,aJoin);
 if(!pNext-IsVisited())
-GetNextJoin(_xConnection,pNext,pEntryTab,aJoin);
+GetNextJoin(_xConnection, pNext, pEntryTab, aJoin, 
_rTableNames);
 }
 }
 
@@ -532,7 +554,7 @@
 // exists there a connection to a OQueryTableWindow that 
holds a connection that has been already visited
 JoinCycle(_xConnection,pNext,pEntryTab,aJoin);
 if(!pNext-IsVisited())
-GetNextJoin(_xConnection,pNext,pEntryTab,aJoin);
+GetNextJoin(_xConnection, pNext, pEntryTab, aJoin, 
_rTableNames);
 }
 }
 }
@@ -1014,7 +1036,7 @@
 
//--
 void searchAndAppendName(const Reference XConnection _xConnection,
  const OQueryTableWindow* _pTableWindow,
- ::std::map 
::rtl::OUString,sal_Bool,::comphelper::UStringMixLess _rTableNames,
+ tableNames_t _rTableNames,
  ::rtl::OUString _rsTableListStr
  )
 {
@@

[PATCH] Change in core[libreoffice-3-6]: mark all tables of a nested join as added

2013-01-18 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1764

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/1764/1

mark *all* tables of a nested join as added

Else, if the n^{th} (with n2) table also appears in a (non-NATURAL) INNER 
JOIN, it is repeated later, leading to an error from the database engine

Change-Id: I03e0f0ef51f45be9d7ddfa63a9dbe09dc500f8dd
---
M dbaccess/source/ui/querydesign/QueryDesignView.cxx
1 file changed, 33 insertions(+), 18 deletions(-)



diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx 
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 7b33375..e1d7427 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -485,10 +485,29 @@
 return BuildJoin(_xConnection, rRh, BuildTable(_xConnection,pLh), 
data);
 }
 
//--
+typedef ::std::map ::rtl::OUString,sal_Bool,::comphelper::UStringMixLess 
tableNames_t;
+
//--
+void addConnectionTableNames( const Reference XConnection _xConnection,
+  const OQueryTableConnection* const 
pEntryConn,
+  tableNames_t _rTableNames )
+{
+// insert tables into table list to avoid double entries
+const OQueryTableWindow* const pEntryTabFrom = 
static_castOQueryTableWindow*(pEntryConn-GetSourceWin());
+const OQueryTableWindow* const pEntryTabTo = 
static_castOQueryTableWindow*(pEntryConn-GetDestWin());
+
+::rtl::OUString sTabName(BuildTable(_xConnection,pEntryTabFrom));
+if(_rTableNames.find(sTabName) == _rTableNames.end())
+_rTableNames[sTabName] = sal_True;
+sTabName = BuildTable(_xConnection,pEntryTabTo);
+if(_rTableNames.find(sTabName) == _rTableNames.end())
+_rTableNames[sTabName] = sal_True;
+}
+
//--
 void GetNextJoin(   const Reference XConnection _xConnection,
 OQueryTableConnection* pEntryConn,
 OQueryTableWindow* pEntryTabTo,
-::rtl::OUString aJoin)
+::rtl::OUString aJoin,
+tableNames_t _rTableNames)
 {
 OQueryTableConnectionData* pEntryConnData = 
static_castOQueryTableConnectionData*(pEntryConn-GetData().get());
 if ( pEntryConnData-GetJoinType() == INNER_JOIN  
!pEntryConnData-isNatural() )
@@ -496,15 +515,18 @@
 
 if(aJoin.isEmpty())
 {
+addConnectionTableNames(_xConnection, pEntryConn, _rTableNames);
 OQueryTableWindow* pEntryTabFrom = 
static_castOQueryTableWindow*(pEntryConn-GetSourceWin());
 aJoin = 
BuildJoin(_xConnection,pEntryTabFrom,pEntryTabTo,pEntryConnData);
 }
 else if(pEntryTabTo == pEntryConn-GetDestWin())
 {
+addConnectionTableNames(_xConnection, pEntryConn, _rTableNames);
 aJoin = BuildJoin(_xConnection,aJoin,pEntryTabTo,pEntryConnData);
 }
 else if(pEntryTabTo == pEntryConn-GetSourceWin())
 {
+addConnectionTableNames(_xConnection, pEntryConn, _rTableNames);
 aJoin = BuildJoin(_xConnection,pEntryTabTo,aJoin,pEntryConnData);
 }
 
@@ -523,7 +545,7 @@
 // exists there a connection to a OQueryTableWindow that holds 
a connection that has been already visited
 JoinCycle(_xConnection,pNext,pEntryTab,aJoin);
 if(!pNext-IsVisited())
-GetNextJoin(_xConnection,pNext,pEntryTab,aJoin);
+GetNextJoin(_xConnection, pNext, pEntryTab, aJoin, 
_rTableNames);
 }
 }
 
@@ -541,7 +563,7 @@
 // exists there a connection to a OQueryTableWindow that 
holds a connection that has been already visited
 JoinCycle(_xConnection,pNext,pEntryTab,aJoin);
 if(!pNext-IsVisited())
-GetNextJoin(_xConnection,pNext,pEntryTab,aJoin);
+GetNextJoin(_xConnection, pNext, pEntryTab, aJoin, 
_rTableNames);
 }
 }
 }
@@ -1024,7 +1046,7 @@
 
//--
 void searchAndAppendName(const Reference XConnection _xConnection,
  const OQueryTableWindow* _pTableWindow,
- ::std::map 
::rtl::OUString,sal_Bool,::comphelper::UStringMixLess _rTableNames,
+ tableNames_t _rTableNames,
  ::rtl::OUString _rsTableListStr
  )
 {
@@

[PATCH] Change in core[libreoffice-3-6]: Catch all exceptions to respect specification

2012-12-02 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1226

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/1226/1

Catch all exceptions to respect specification

In particular, getMaxRows() can throw SQLException

Change-Id: I1f49afe8258d98000bff34e18f4d98967c46e1b3
---
M connectivity/source/drivers/jdbc/JStatement.cxx
1 file changed, 13 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1226
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f49afe8258d98000bff34e18f4d98967c46e1b3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6]: fdo#42165 make nested joins as per strict ANSI SQL

2012-12-02 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1225

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1225/1

fdo#42165 make nested joins as per strict ANSI SQL

Change-Id: I605d3811b27c33e35670306bb03b5a796ab72bc0
---
M dbaccess/source/ui/inc/TableConnectionData.hxx
M dbaccess/source/ui/querydesign/QueryDesignView.cxx
2 files changed, 31 insertions(+), 14 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1225
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I605d3811b27c33e35670306bb03b5a796ab72bc0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6]: fdo#57611 do not crash when setting too small size

2012-11-29 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1197

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/1197/1

fdo#57611 do not crash when setting too small size

The caller's exception specifications are lacking,
but fixing this in a stable release line is too invasive

Change-Id: I8ae2048a6c0acc6b6cf2beece9e630c87caac39f
---
M reportdesign/source/core/api/FixedLine.cxx
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1197
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ae2048a6c0acc6b6cf2beece9e630c87caac39f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Do not override the message of an underlying PropertyVetoExc...

2012-11-29 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1198

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/1198/1

Do not override the message of an underlying PropertyVetoException

Change-Id: I9c1026ad87f3031f1c56066ab24d23d3a6d8782b
---
M cppuhelper/source/propertysetmixin.cxx
1 file changed, 6 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1198
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c1026ad87f3031f1c56066ab24d23d3a6d8782b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] detect even more memory mismanagement on glibc

2012-11-02 Thread Lionel Elie Mamane (via Code Review)

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/940


--
To view, visit https://gerrit.libreoffice.org/940
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idba21b12582e9ae7d240d9d3527f9ac5893252f7
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6]: Don't abort when column has no (Catalog|Schema|Table)Name

2012-11-02 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/968

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/968/1

Don't abort when column has no (Catalog|Schema|Table)Name

Especially since the rest of the function is prepared to handle
no/empty (Catalog|Schema|Table)Name.

Change-Id: Ic0bb59ead5789e671c90887ef850588f4924f5e7
---
M dbaccess/source/core/api/SingleSelectQueryComposer.cxx
1 file changed, 6 insertions(+), 3 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/968
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0bb59ead5789e671c90887ef850588f4924f5e7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] detect even more memory mismanagement on glibc

2012-11-02 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/969

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/969/1

detect even more memory mismanagement on glibc

Change-Id: I3a06e5970638c755e89f8ffdf96b68d3c6cdbe61
---
M solenv/bin/linkoo
1 file changed, 16 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/969
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a06e5970638c755e89f8ffdf96b68d3c6cdbe61
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] detect even more memory mismanagement on glibc

2012-10-30 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/940

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/940/1

detect even more memory mismanagement on glibc

Change-Id: Idba21b12582e9ae7d240d9d3527f9ac5893252f7
---
M solenv/bin/linkoo
1 file changed, 13 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/940
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idba21b12582e9ae7d240d9d3527f9ac5893252f7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6]: fdo#52392 dbase: correctly NULL out non-filled in fields in ...

2012-10-26 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/923

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/923/1

fdo#52392 dbase: correctly NULL out non-filled in fields in inserted rows

Change-Id: Id2e8ad5b6bed1c184de6dccf7fa43254099fb958
---
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/inc/dbase/DTable.hxx
2 files changed, 9 insertions(+), 9 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/923
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2e8ad5b6bed1c184de6dccf7fa43254099fb958
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6]: fdo#44721 protect against negative calculated height value

2012-09-14 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/622

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/622/1

fdo#44721 protect against negative calculated height value

Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360
---
M reportdesign/source/core/sdr/RptObject.cxx
1 file changed, 4 insertions(+), 2 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/622
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-5]: fdo#44721 protect against negative calculated height value

2012-09-14 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/623

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/623/1

fdo#44721 protect against negative calculated height value

Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360
---
M reportdesign/source/core/sdr/RptObject.cxx
1 file changed, 4 insertions(+), 2 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/623
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-5
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6-2]: fdo#44721 protect against negative calculated height value

2012-09-14 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/624

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/624/1

fdo#44721 protect against negative calculated height value

Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360
---
M reportdesign/source/core/sdr/RptObject.cxx
1 file changed, 4 insertions(+), 2 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/624
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-2
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6]: fdo#37529 clear DataColumns read-only information when we cl...

2012-09-13 Thread Lionel Elie Mamane (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/608

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/608/1

fdo#37529 clear DataColumns read-only information when we clear DataColumns

Change-Id: I6f3b4f1646df1244d97ae98f56ba054bc26e3314
---
M dbaccess/source/core/api/RowSet.cxx
1 file changed, 3 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/608
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f3b4f1646df1244d97ae98f56ba054bc26e3314
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

81 matches

Mail list logo