[PATCH] Add Flat Document and MathML MIME types

2013-06-11 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4230

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/4230/1

Add Flat Document and MathML MIME types

Change-Id: If9affe0e230ebcd4dbec9d4dcc8dc88fb8cde513
---
M sysui/desktop/menus/calc.desktop
M sysui/desktop/menus/draw.desktop
M sysui/desktop/menus/impress.desktop
M sysui/desktop/menus/math.desktop
M sysui/desktop/menus/writer.desktop
5 files changed, 6 insertions(+), 6 deletions(-)



diff --git a/sysui/desktop/menus/calc.desktop b/sysui/desktop/menus/calc.desktop
index 6ce104c..bbea04e 100755
--- a/sysui/desktop/menus/calc.desktop
+++ b/sysui/desktop/menus/calc.desktop
@@ -22,7 +22,7 @@
 Type=Application
 
Categories=Office;Spreadsheet;X-Red-Hat-Base;X-MandrivaLinux-Office-Spreadsheets;
 Exec=${UNIXBASISROOTNAME} --calc %%FILE%%
-MimeType=application/vnd.oasis.opendocument.spreadsheet;application/vnd.oasis.opendocument.spreadsheet-template;application/vnd.sun.xml.calc;application/vnd.sun.xml.calc.template;application/msexcel;application/vnd.ms-excel;application/vnd.openxmlformats-officedocument.spreadsheetml.sheet;application/vnd.ms-excel.sheet.macroenabled.12;application/vnd.openxmlformats-officedocument.spreadsheetml.template;application/vnd.ms-excel.template.macroenabled.12;application/vnd.ms-excel.sheet.binary.macroenabled.12;text/csv;application/x-dbf;text/spreadsheet;application/csv;application/excel;application/tab-separated-values;application/vnd.lotus-1-2-3;application/vnd.oasis.opendocument.chart;application/vnd.oasis.opendocument.chart-template;application/x-dbase;application/x-dos_ms_excel;application/x-excel;application/x-msexcel;application/x-ms-excel;application/x-quattropro;application/x-123;text/comma-separated-values;text/tab-separated-values;text/x-comma-separated-values;text/x-csv
 ;
+MimeType=application/vnd.oasis.opendocument.spreadsheet;application/vnd.oasis.opendocument.spreadsheet-template;application/vnd.sun.xml.calc;application/vnd.sun.xml.calc.template;application/msexcel;application/vnd.ms-excel;application/vnd.openxmlformats-officedocument.spreadsheetml.sheet;application/vnd.ms-excel.sheet.macroenabled.12;application/vnd.openxmlformats-officedocument.spreadsheetml.template;application/vnd.ms-excel.template.macroenabled.12;application/vnd.ms-excel.sheet.binary.macroenabled.12;text/csv;application/x-dbf;text/spreadsheet;application/csv;application/excel;application/tab-separated-values;application/vnd.lotus-1-2-3;application/vnd.oasis.opendocument.chart;application/vnd.oasis.opendocument.chart-template;application/x-dbase;application/x-dos_ms_excel;application/x-excel;application/x-msexcel;application/x-ms-excel;application/x-quattropro;application/x-123;text/comma-separated-values;text/tab-separated-values;text/x-comma-separated-values;text/x-csv
 ;application/vnd.oasis.opendocument.spreadsheet-flat-xml;
 Name=%PRODUCTNAME Calc
 GenericName=Spreadsheet
 Comment=Perform calculations, analyze information and manage lists in 
spreadsheets by using Calc.
diff --git a/sysui/desktop/menus/draw.desktop b/sysui/desktop/menus/draw.desktop
index 23306a0..4558bf0 100755
--- a/sysui/desktop/menus/draw.desktop
+++ b/sysui/desktop/menus/draw.desktop
@@ -22,7 +22,7 @@
 Type=Application
 
Categories=Office;FlowChart;Graphics;2DGraphics;VectorGraphics;X-Red-Hat-Base;X-MandrivaLinux-Office-Drawing;
 Exec=${UNIXBASISROOTNAME} --draw %%FILE%%
-MimeType=application/vnd.oasis.opendocument.graphics;application/vnd.oasis.opendocument.graphics-template;application/vnd.sun.xml.draw;application/vnd.sun.xml.draw.template;application/vnd.visio;application/x-wpg;application/vnd.corel-draw;application/vnd.ms-publisher;
+MimeType=application/vnd.oasis.opendocument.graphics;application/vnd.oasis.opendocument.graphics-flat-xml;application/vnd.oasis.opendocument.graphics-template;application/vnd.sun.xml.draw;application/vnd.sun.xml.draw.template;application/vnd.visio;application/x-wpg;application/vnd.corel-draw;application/vnd.ms-publisher;
 Name=%PRODUCTNAME Draw
 GenericName=Drawing Program
 Comment=Create and edit drawings, flow charts and logos by using Draw.
diff --git a/sysui/desktop/menus/impress.desktop 
b/sysui/desktop/menus/impress.desktop
index 4e84c62..fa284d3 100755
--- a/sysui/desktop/menus/impress.desktop
+++ b/sysui/desktop/menus/impress.desktop
@@ -22,7 +22,7 @@
 Type=Application
 
Categories=Office;Presentation;X-Red-Hat-Base;X-MandrivaLinux-Office-Presentations;
 Exec=${UNIXBASISROOTNAME} --impress %%FILE%%

[PATCH] Add Corel Draw and MS Publisher MIME Types to Draw

2013-05-24 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4022

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/4022/1

Add Corel Draw and MS Publisher MIME Types to Draw

Change-Id: Idbaa8cea7427db3103954c6c60aa7caa6784a3ba
---
M sysui/desktop/menus/draw.desktop
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/sysui/desktop/menus/draw.desktop b/sysui/desktop/menus/draw.desktop
index 7de198b..9e56d05 100755
--- a/sysui/desktop/menus/draw.desktop
+++ b/sysui/desktop/menus/draw.desktop
@@ -22,7 +22,7 @@
 Type=Application
 
Categories=Office;FlowChart;Graphics;2DGraphics;VectorGraphics;X-Red-Hat-Base;X-MandrivaLinux-Office-Drawing;
 Exec=${UNIXBASISROOTNAME} --draw %%FILE%%
-MimeType=application/vnd.oasis.opendocument.graphics;application/vnd.oasis.opendocument.graphics-template;application/vnd.sun.xml.draw;application/vnd.sun.xml.draw.template;application/vnd.visio;application/x-wpg;
+MimeType=application/vnd.oasis.opendocument.graphics;application/vnd.oasis.opendocument.graphics-template;application/vnd.sun.xml.draw;application/vnd.sun.xml.draw.template;application/vnd.visio;application/x-wpg;application/vnd.corel-draw;application/vnd.ms-publisher;
 Name=%PRODUCTNAME Draw
 GenericName=Drawing Program
 Comment=Create and edit drawings, flow charts and logos by using Draw.

-- 
To view, visit https://gerrit.libreoffice.org/4022
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbaa8cea7427db3103954c6c60aa7caa6784a3ba
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] Fix inconsistent names: Image instead of Picture or Graphic

2013-05-23 Thread Samuel Mehrbrodt (via Code Review) 
Samuel Mehrbrodt has abandoned this change.

Change subject: Fix inconsistent names: Image instead of Picture or Graphic
..


Patch Set 2: Abandoned

I don't have the time to work on this currently.

-- 
To view, visit https://gerrit.libreoffice.org/3603
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I30ccca5dba5d65c8ee47f92fd3dfd1dcd46219b4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Samuel Mehrbrodt s.mehrbr...@gmail.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Related fdo#35546: Further improve Layout of Photo Album Dia...

2013-05-11 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3852

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/3852/1

Related fdo#35546: Further improve Layout of Photo Album Dialog

With suggestions from 
http://nabble.documentfoundation.org/Streamlining-the-Photo-Album-Creator-td4054397.html

* Moved Album Layout to the right
* Changed buttons to GTK Stock buttons, added VCL equivalents
* Improved the wording of the Layout options

Change-Id: Icfb24a8678d096bb596bcdeabbf539e9fe1835db
---
M sd/uiconfig/simpress/ui/photoalbum.ui
M vcl/inc/svids.hrc
M vcl/source/src/btntext.src
M vcl/source/window/builder.cxx
4 files changed, 252 insertions(+), 248 deletions(-)



diff --git a/sd/uiconfig/simpress/ui/photoalbum.ui 
b/sd/uiconfig/simpress/ui/photoalbum.ui
index 352d4a2..13760d3 100644
--- a/sd/uiconfig/simpress/ui/photoalbum.ui
+++ b/sd/uiconfig/simpress/ui/photoalbum.ui
@@ -58,173 +58,100 @@
   /packing
 /child
 child
-  object class=GtkBox id=box1
+  object class=GtkFrame id=frame1
 property name=visibleTrue/property
 property name=can_focusFalse/property
-property name=orientationvertical/property
-property name=spacing12/property
+property name=vexpandTrue/property
+property name=label_xalign0/property
+property name=shadow_typenone/property
 child
-  object class=GtkFrame id=frame1
+  object class=GtkBox id=box2
 property name=visibleTrue/property
 property name=can_focusFalse/property
+property name=margin_left12/property
+property name=margin_top6/property
 property name=vexpandTrue/property
-property name=label_xalign0/property
-property name=shadow_typenone/property
+property name=orientationvertical/property
 child
-  object class=GtkBox id=box2
+  object class=GtkButtonBox id=buttonbox2
 property name=visibleTrue/property
 property name=can_focusFalse/property
-property name=margin_left12/property
-property name=margin_top6/property
-property name=vexpandTrue/property
-property name=orientationvertical/property
+property name=spacing6/property
+property name=layout_stylestart/property
 child
-  object class=GtkButtonBox id=buttonbox2
+  object class=GtkButton id=file_btn
+property name=label translatable=yesInsert 
Images/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
-property name=can_focusFalse/property
-property name=spacing6/property
-property name=layout_stylestart/property
-child
-  object class=GtkButton id=file_btn
-property name=label translatable=yesInsert 
Images/property
-property 
name=use_action_appearanceFalse/property
-property name=visibleTrue/property
-property name=can_focusTrue/property
-property name=receives_defaultTrue/property
-property 
name=use_action_appearanceFalse/property
-  /object
-  packing
-property name=expandFalse/property
-property name=fillTrue/property
-property name=position0/property
-  /packing
-/child
-child
-  object class=GtkButton id=textbox_btn
-property name=label translatable=yesInsert 
Text Slide/property
-property 
name=use_action_appearanceFalse/property
-property name=visibleTrue/property
-property name=can_focusTrue/property
-property name=receives_defaultTrue/property
-property 
name=use_action_appearanceFalse/property
-  /object
-  packing
-property name=expandFalse/property
-property name=fillTrue/property
-property name=position1/property
-  /packing
-/child
+property name=can_focusTrue/property
+property

[PATCH] Related fdo#35546: Simplyfy Code in Photo Album Dialog

2013-05-11 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3855

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/3855/1

Related fdo#35546: Simplyfy Code in Photo Album Dialog

Create a method for enabling/disabling the Up/Down/Remove buttons.
This also fixes some wrong behavior.

Change-Id: Ie40a4f3bb4402b988071b315617404c802b7e92a
---
M sd/source/ui/dlg/PhotoAlbumDialog.cxx
M sd/source/ui/dlg/PhotoAlbumDialog.hxx
2 files changed, 17 insertions(+), 71 deletions(-)



diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.cxx 
b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
index 2771166..351a9d8 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.cxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
@@ -597,19 +597,6 @@
 OSL_FAIL(Could not find config for Create Photo Album 
function);
 }
 
-if( aFilesArr.getLength() == 1)
-{
-pRemoveBtn-Enable();
-pUpBtn-Disable();
-pDownBtn-Disable();
-}
-else
-{
-pRemoveBtn-Enable();
-pUpBtn-Enable();
-pDownBtn-Enable();
-}
-
 for ( sal_Int32 i = 0; i  aFilesArr.getLength(); i++ )
 {
 // Store full path, show filename only. Use INetURLObject to 
display spaces in filename correctly
@@ -619,6 +606,7 @@
 }
 }
 }
+EnableDisableButtons();
 return 0;
 }
 
@@ -634,12 +622,7 @@
 OUString sStr(SD_RESSTR(STR_PHOTO_ALBUM_TEXTBOX));
 pImagesLst-SetEntryData(nPos, (void*)new OUString(sStr));
 
-if(pImagesLst-GetEntryCount() = 1)
-{
-pRemoveBtn-Enable();
-pUpBtn-Disable();
-pDownBtn-Disable();
-}
+EnableDisableButtons();
 return 0;
 }
 
@@ -669,16 +652,9 @@
 pImagesLst-SetEntryData( nActPos, (void*) new OUString(sUpper));
 
 pImagesLst-SelectEntryPos(nActPos - 1);
-
-pDownBtn-Enable();
-
 }
 
-if(pImagesLst-GetSelectEntryPos() == 0)
-{
-pDownBtn-Enable();
-pUpBtn-Disable();
-}
+EnableDisableButtons();
 return 0;
 }
 
@@ -707,16 +683,7 @@
 pImagesLst-SelectEntryPos(nActPos + 1);
 
 }
-
-if(pImagesLst-GetEntry(pImagesLst-GetSelectEntryPos() + 1) != 
OUString())
-{
-pDownBtn-Enable();
-pUpBtn-Enable();
-}
-else
-{
-pDownBtn-Disable();
-}
+EnableDisableButtons();
 return 0;
 }
 
@@ -725,18 +692,7 @@
 pImagesLst-RemoveEntry( pImagesLst-GetSelectEntryPos() );
 pImg-SetImage(Image());
 
-if(pImagesLst-GetEntryCount() = 1)
-{
-pRemoveBtn-Enable();
-pUpBtn-Disable();
-pDownBtn-Disable();
-}
-else
-{
-pRemoveBtn-Disable();
-pUpBtn-Disable();
-pDownBtn-Disable();
-}
+EnableDisableButtons();
 return 0;
 }
 
@@ -744,27 +700,6 @@
 {
 OUString* pData = (OUString*) 
pImagesLst-GetEntryData(pImagesLst-GetSelectEntryPos());
 OUString sImgUrl = pData ? OUString(*pData) : ;
-// Some UI functionality: if you select the first/last item in the list,
-// the Up/Down button gets enabled/diabled (meaning: you cannot move 
up/down the item)
-// disable/enable moving up
-if(pImagesLst-GetSelectEntryPos() == 0)
-{
-pUpBtn-Disable();
-}
-else
-{
-pUpBtn-Enable();
-}
-
-// disable/enable moving down
-if(pImagesLst-GetEntry(pImagesLst-GetSelectEntryPos() + 1) == 
OUString())
-{
-pDownBtn-Disable();
-}
-else
-{
-pDownBtn-Enable();
-}
 
 if (sImgUrl != SD_RESSTR(STR_PHOTO_ALBUM_TEXTBOX))
 {
@@ -817,7 +752,7 @@
 {
 pImg-SetImage(Image());
 }
-
+EnableDisableButtons();
 return 0;
 }
 
@@ -893,6 +828,15 @@
 return ModalDialog::Execute();
 }
 
+void SdPhotoAlbumDialog::EnableDisableButtons()
+{
+pRemoveBtn-Enable(pImagesLst-GetSelectEntryCount()  0);
+pUpBtn-Enable(pImagesLst-GetSelectEntryCount()  0 
+   pImagesLst-GetSelectEntryPos() != 0);
+pDownBtn-Enable(pImagesLst-GetSelectEntryCount()  0 
+ pImagesLst-GetSelectEntryPos()  
pImagesLst-GetEntryCount()-1);
+}
+
 
 } // end of namespace sd
 
diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.hxx 
b/sd/source/ui/dlg/PhotoAlbumDialog.hxx
index 9a68ba9..3e75128 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.hxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.hxx
@@ -93,6 +93,8 @@
 Reference graphic::XGraphic createXGraphicFromUrl(const OUString sUrl,
 Reference graphic::XGraphicProvider xProvider);
 
+void EnableDisableButtons();
+
 enum SlideImageLayout
 {
 FIT_TO_SLIDE=0,

-- 
To view, visit https://gerrit.libreoffice.org/3855
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie40a4f3bb4402b988071b315617404c802b7e92a
Gerrit-PatchSet: 1

[PATCH] Related fdo#35546: Remove the Text box function from Photo...

2013-05-11 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3857

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/3857/1

Related fdo#35546: Remove the Text box function from Photo Album Dialog

This has been discussed and approved in the Design Team IRC Chat on 2013-05-11

Change-Id: I70b861c09af2dfa79c9f773a47791b101888c8f9
---
M sd/source/ui/dlg/PhotoAlbumDialog.cxx
M sd/source/ui/dlg/PhotoAlbumDialog.hxx
M sd/uiconfig/simpress/ui/photoalbum.ui
3 files changed, 216 insertions(+), 295 deletions(-)



diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.cxx 
b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
index 351a9d8..ba11647 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.cxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
@@ -45,8 +45,7 @@
 get(pCancelBtn, cancel_btn);
 get(pCreateBtn, create_btn);
 
-get(pFileBtn, file_btn);
-get(pTextBtn, textbox_btn);
+get(pAddBtn, add_btn);
 get(pUpBtn, up_btn);
 get(pDownBtn, down_btn);
 get(pRemoveBtn, rem_btn);
@@ -60,8 +59,7 @@
 pCancelBtn-SetClickHdl(LINK(this, SdPhotoAlbumDialog, CancelHdl));
 pCreateBtn-SetClickHdl(LINK(this, SdPhotoAlbumDialog, CreateHdl));
 
-pFileBtn-SetClickHdl(LINK(this, SdPhotoAlbumDialog, FileHdl));
-pTextBtn-SetClickHdl(LINK(this, SdPhotoAlbumDialog, TextHdl));
+pAddBtn-SetClickHdl(LINK(this, SdPhotoAlbumDialog, FileHdl));
 pUpBtn-SetClickHdl(LINK(this, SdPhotoAlbumDialog, UpHdl));
 pUpBtn-Disable();
 pDownBtn-SetClickHdl(LINK(this, SdPhotoAlbumDialog, DownHdl));
@@ -72,7 +70,7 @@
 
 mpGraphicFilter = new GraphicFilter;
 sDirUrl = ;
-pFileBtn-GrabFocus();
+pAddBtn-GrabFocus();
 pImagesLst-Clear();
 }
 
@@ -606,22 +604,6 @@
 }
 }
 }
-EnableDisableButtons();
-return 0;
-}
-
-IMPL_LINK_NOARG(SdPhotoAlbumDialog, TextHdl)
-{
-sal_Int16 nPos;
-sal_Int16 nInsertPos = pImagesLst-GetSelectEntryPos();
-if (nInsertPos  0)
-nPos = pImagesLst-InsertEntry( 
OUString(SD_RESSTR(STR_PHOTO_ALBUM_TEXTBOX)));
-else
-nPos = pImagesLst-InsertEntry( 
OUString(SD_RESSTR(STR_PHOTO_ALBUM_TEXTBOX)), nInsertPos);
-
-OUString sStr(SD_RESSTR(STR_PHOTO_ALBUM_TEXTBOX));
-pImagesLst-SetEntryData(nPos, (void*)new OUString(sStr));
-
 EnableDisableButtons();
 return 0;
 }
diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.hxx 
b/sd/source/ui/dlg/PhotoAlbumDialog.hxx
index 3e75128..d49ec34 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.hxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.hxx
@@ -54,8 +54,7 @@
 CancelButton*   pCancelBtn;
 PushButton* pCreateBtn;
 
-PushButton* pFileBtn;
-PushButton* pTextBtn;
+PushButton* pAddBtn;
 PushButton* pUpBtn;
 PushButton* pDownBtn;
 PushButton* pRemoveBtn;
diff --git a/sd/uiconfig/simpress/ui/photoalbum.ui 
b/sd/uiconfig/simpress/ui/photoalbum.ui
index 13760d3..d1e7a6c 100644
--- a/sd/uiconfig/simpress/ui/photoalbum.ui
+++ b/sd/uiconfig/simpress/ui/photoalbum.ui
@@ -58,57 +58,40 @@
   /packing
 /child
 child
-  object class=GtkFrame id=frame1
+  object class=GtkBox id=box4
 property name=visibleTrue/property
 property name=can_focusFalse/property
+property name=margin_top6/property
 property name=vexpandTrue/property
-property name=label_xalign0/property
-property name=shadow_typenone/property
 child
-  object class=GtkBox id=box2
+  object class=GtkBox id=box1
 property name=visibleTrue/property
 property name=can_focusFalse/property
-property name=margin_left12/property
-property name=margin_top6/property
-property name=vexpandTrue/property
 property name=orientationvertical/property
 child
-  object class=GtkButtonBox id=buttonbox2
+  object class=GtkScrolledWindow id=scrolledwindow1
+property name=width_request300/property
+property name=height_request200/property
 property name=visibleTrue/property
-property name=can_focusFalse/property
-property name=spacing6/property
-property name=layout_stylestart/property
+property name=can_focusTrue/property
+property name=hexpandTrue/property
+property name=vexpandTrue/property
+property name=shadow_typein/property
 child
-  object class=GtkButton id=file_btn
-property name=label translatable=yesInsert 
Images/property
-property name=use_action_appearanceFalse/property
+  object class=GtkTreeView id=images_tree
+

[PATCH] Related fdo#35546: Remove 1 Image with Title Layout for Ph...

2013-05-11 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3858

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/3858/1

Related fdo#35546: Remove 1 Image with Title Layout for Photo Album Dialog

There will be an option for all Slide Layouts to have a title.
Discussed and decided here: 
https://wiki.documentfoundation.org/Design/Meetings/2013-05-11

Change-Id: I891511d6cf8183e45b41a9358f4821f7de551836
---
M sd/source/ui/dlg/PhotoAlbumDialog.cxx
M sd/source/ui/dlg/PhotoAlbumDialog.hxx
M sd/uiconfig/simpress/ui/photoalbum.ui
3 files changed, 54 insertions(+), 162 deletions(-)



diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.cxx 
b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
index ba11647..2c49e36 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.cxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
@@ -95,111 +95,64 @@
 {
 Reference drawing::XDrawPagesSupplier  xDPS( pDoc-getUnoModel(), 
uno::UNO_QUERY );
 Reference drawing::XDrawPages  xDrawPages( xDPS-getDrawPages(), 
uno::UNO_QUERY );
-Reference lang::XMultiServiceFactory  xShapeFactory( 
pDoc-getUnoModel(), uno::UNO_QUERY  );
+Reference lang::XMultiServiceFactory  xShapeFactory( 
pDoc-getUnoModel(), uno::UNO_QUERY );
 
 Reference XComponentContext  
xContext(::comphelper::getProcessComponentContext());
 Reference graphic::XGraphicProvider 
xProvider(graphic::GraphicProvider::create(xContext));
 
 // get the option
 sal_uInt16 nOpt = pInsTypeCombo-GetSelectEntryPos();
-if ( nOpt == FIT_TO_SLIDE )
+if ( nOpt == ONE_IMAGE )
 {
 OUString sUrl;
-
 for( sal_Int16 i = 0; i  pImagesLst-GetEntryCount(); ++i )
 {
 OUString* pData = (OUString*) pImagesLst-GetEntryData(i);
 sUrl = *pData;
-if (sUrl != Text Box)
+
+Reference drawing::XDrawPage  xSlide = 
appendNewSlide(AUTOLAYOUT_NONE, xDrawPages);
+Reference beans::XPropertySet  xSlideProps( xSlide, 
uno::UNO_QUERY );
+
+Reference graphic::XGraphic  xGraphic = 
createXGraphicFromUrl(sUrl, xProvider);
+
+Image aImg(xGraphic);
+// Save the original size, multiplied with 100
+::awt::Size aPicSize(aImg.GetSizePixel().Width()*100, 
aImg.GetSizePixel().Height()*100);
+
+Reference drawing::XShape  xShape(
+
xShapeFactory-createInstance(com.sun.star.drawing.GraphicObjectShape),
+uno::UNO_QUERY);
+
+Reference beans::XPropertySet  xProps( xShape, 
uno::UNO_QUERY );
+xProps-setPropertyValue(Graphic, ::uno::Any(xGraphic));
+
+
+::awt::Size aPageSize;
+
+xSlideProps-getPropertyValue(
+OUString(Width)) = aPageSize.Width;
+xSlideProps-getPropertyValue(
+OUString(Height)) = aPageSize.Height;
+
+::awt::Point aPicPos;
+
+if(pASRCheck-IsChecked())
 {
-Reference drawing::XDrawPage  xSlide = 
appendNewSlide(AUTOLAYOUT_NONE, xDrawPages);
-Reference beans::XPropertySet  xSlideProps( xSlide, 
uno::UNO_QUERY );
-
-Reference graphic::XGraphic  xGraphic = 
createXGraphicFromUrl(sUrl, xProvider);
-
-Image aImg(xGraphic);
-// Save the original size, multiplied with 100
-::awt::Size aPicSize(aImg.GetSizePixel().Width()*100, 
aImg.GetSizePixel().Height()*100);
-
-Reference drawing::XShape  xShape(
-
xShapeFactory-createInstance(com.sun.star.drawing.GraphicObjectShape),
-uno::UNO_QUERY);
-
-Reference beans::XPropertySet  xProps( xShape, 
uno::UNO_QUERY );
-xProps-setPropertyValue(Graphic, ::uno::Any(xGraphic));
-
-
-::awt::Size aPageSize;
-
-xSlideProps-getPropertyValue(
-OUString(Width)) = aPageSize.Width;
-xSlideProps-getPropertyValue(
-OUString(Height)) = aPageSize.Height;
-
-::awt::Point aPicPos;
-
-if(pASRCheck-IsChecked())
-{
-// Resize the image, with keeping ASR
-aPicSize = createASRSize(aPicSize, aPageSize);
-}
-else
-{
-aPicSize.Width = aPageSize.Width;
-aPicSize.Height = aPageSize.Height;
-}
-xShape-setSize(aPicSize);
-aPicPos.X = (aPageSize.Width - aPicSize.Width)/2;
-aPicPos.Y = (aPageSize.Height - aPicSize.Height)/2;
-
-xShape-setPosition(aPicPos);
-

[PATCH] Related fdo#35546 Improve Layout of Insert Photo Album Dia...

2013-05-09 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3833

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/3833/1

Related fdo#35546 Improve Layout of Insert Photo Album Dialog

No Objections from the Design list: 
http://nabble.documentfoundation.org/Streamlining-the-Photo-Album-Creator-td4054397.html

Change-Id: Ib880023b956c6d94d8110829d0c32281854a0705
---
M sd/source/ui/app/strings.src
M sd/uiconfig/simpress/ui/photoalbum.ui
2 files changed, 139 insertions(+), 156 deletions(-)



diff --git a/sd/source/ui/app/strings.src b/sd/source/ui/app/strings.src
index 928e03e..eb6b959 100644
--- a/sd/source/ui/app/strings.src
+++ b/sd/source/ui/app/strings.src
@@ -1270,12 +1270,12 @@
 
 String STR_PHOTO_ALBUM_EMPTY_WARNING
 {
- Text [ en-US ] = Please add images to the album. ;
+ Text [ en-US ] = Please add Images to the Album. ;
 };
 
 String STR_PHOTO_ALBUM_TEXTBOX
 {
-Text [ en-US ] = Text Box;
+Text [ en-US ] = Text Slide;
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/uiconfig/simpress/ui/photoalbum.ui 
b/sd/uiconfig/simpress/ui/photoalbum.ui
index e8423ad..87304e3 100644
--- a/sd/uiconfig/simpress/ui/photoalbum.ui
+++ b/sd/uiconfig/simpress/ui/photoalbum.ui
@@ -4,11 +4,9 @@
   object class=GtkDialog id=PhotoAlbumCreatorDialog
 property name=can_focusFalse/property
 property name=border_width6/property
-property name=title translatable=yesPhoto Album Creator/property
-property name=resizableFalse/property
+property name=title translatable=yesCreate Photo Album/property
 property name=window_positioncenter/property
 property name=type_hintdialog/property
-property name=has_resize_gripFalse/property
 child internal-child=vbox
   object class=GtkBox id=dialog-vbox1
 property name=can_focusFalse/property
@@ -20,12 +18,14 @@
 property name=layout_styleend/property
 child
   object class=GtkButton id=create_btn
-property name=label translatable=yesCreate/property
+property name=label translatable=yesInsert 
Slides/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=can_defaultTrue/property
 property name=has_defaultTrue/property
 property name=receives_defaultTrue/property
+property name=use_action_appearanceFalse/property
   /object
   packing
 property name=expandFalse/property
@@ -36,9 +36,11 @@
 child
   object class=GtkButton id=cancel_btn
 property name=labelgtk-cancel/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
+property name=use_action_appearanceFalse/property
 property name=use_stockTrue/property
   /object
   packing
@@ -65,83 +67,73 @@
   object class=GtkFrame id=frame1
 property name=visibleTrue/property
 property name=can_focusFalse/property
+property name=vexpandTrue/property
 property name=label_xalign0/property
 property name=shadow_typenone/property
 child
-  object class=GtkAlignment id=alignment1
+  object class=GtkBox id=box2
 property name=visibleTrue/property
 property name=can_focusFalse/property
-property name=top_padding6/property
-property name=left_padding12/property
+property name=margin_left6/property
+property name=margin_top6/property
+property name=vexpandTrue/property
+property name=orientationvertical/property
 child
-  object class=GtkGrid id=grid1
+  object class=GtkButtonBox id=buttonbox2
 property name=visibleTrue/property
 property name=can_focusFalse/property
-property name=column_spacing6/property
-property name=row_homogeneousTrue/property
+property name=spacing6/property
+property name=layout_stylestart/property
 child
-  object class=GtkGrid id=grid2
+  object class=GtkButton id=file_btn
+property name=label translatable=yesInsert 
Images/property
+property

[PATCH] Related fdo#35546: Cosmetic fixes for Photo Album Dialog

2013-05-09 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3834

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/3834/1

Related fdo#35546: Cosmetic fixes for Photo Album Dialog

* Display spaces in filenames correctly
* Adjust Spacing in Dialog
* Remove the label showing the full path

Change-Id: I5c5d3d54b7e21063628c4cdb4a92f534ec4a3088
---
M sd/source/ui/dlg/PhotoAlbumDialog.cxx
M sd/uiconfig/simpress/ui/photoalbum.ui
2 files changed, 57 insertions(+), 83 deletions(-)



diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.cxx 
b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
index fc4b256..2771166 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.cxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
@@ -55,9 +55,7 @@
 get(pImg, preview_img);
 
 get(pInsTypeCombo, opt_combo);
-
 get(pASRCheck, asr_check);
-get(pFilenameLab, filename_lab);
 
 pCancelBtn-SetClickHdl(LINK(this, SdPhotoAlbumDialog, CancelHdl));
 pCreateBtn-SetClickHdl(LINK(this, SdPhotoAlbumDialog, CreateHdl));
@@ -614,10 +612,10 @@
 
 for ( sal_Int32 i = 0; i  aFilesArr.getLength(); i++ )
 {
-// Store full path, show filename only
-OUString sFileName = 
aFilesArr[i].copy(aFilesArr[i].lastIndexOf(/)).replaceAll(/,);
-sal_Int16 nPos = pImagesLst-InsertEntry( sFileName );
-pImagesLst-SetEntryData(nPos, (void*)new 
OUString(aFilesArr[i]));
+// Store full path, show filename only. Use INetURLObject to 
display spaces in filename correctly
+INetURLObject aUrl = INetURLObject(aFilesArr[i]);
+sal_Int16 nPos = pImagesLst-InsertEntry( 
aUrl.GetLastName(INetURLObject::DECODE_WITH_CHARSET, RTL_TEXTENCODING_UTF8) );
+pImagesLst-SetEntryData(nPos, (OUString*) new 
OUString(aUrl.GetMainURL(INetURLObject::DECODE_WITH_CHARSET, 
RTL_TEXTENCODING_UTF8)));
 }
 }
 }
@@ -726,7 +724,6 @@
 {
 pImagesLst-RemoveEntry( pImagesLst-GetSelectEntryPos() );
 pImg-SetImage(Image());
-pFilenameLab-SetText();
 
 if(pImagesLst-GetEntryCount() = 1)
 {
@@ -774,7 +771,6 @@
 GraphicFilter aCurFilter;
 Graphic aGraphic;
 INetURLObject aURLObj( sImgUrl );
-pFilenameLab-SetText(sImgUrl);
 
 sal_uInt16 nFilter = GRFILTER_FORMAT_DONTKNOW;
 
@@ -820,7 +816,6 @@
 else
 {
 pImg-SetImage(Image());
-pFilenameLab-SetText();
 }
 
 return 0;
diff --git a/sd/uiconfig/simpress/ui/photoalbum.ui 
b/sd/uiconfig/simpress/ui/photoalbum.ui
index 87304e3..352d4a2 100644
--- a/sd/uiconfig/simpress/ui/photoalbum.ui
+++ b/sd/uiconfig/simpress/ui/photoalbum.ui
@@ -74,7 +74,7 @@
   object class=GtkBox id=box2
 property name=visibleTrue/property
 property name=can_focusFalse/property
-property name=margin_left6/property
+property name=margin_left12/property
 property name=margin_top6/property
 property name=vexpandTrue/property
 property name=orientationvertical/property
@@ -305,93 +305,72 @@
   /packing
 /child
 child
-  object class=GtkLabel id=filename_lab
-property name=visibleTrue/property
-property name=can_focusFalse/property
-property name=valignend/property
-property name=margin_left6/property
-property name=xalign0/property
-property name=justifyright/property
-  /object
-  packing
-property name=expandFalse/property
-property name=fillTrue/property
-property name=position1/property
-  /packing
-/child
-child
   object class=GtkFrame id=frame3
 property name=visibleTrue/property
 property name=can_focusFalse/property
 property name=label_xalign0/property
 property name=shadow_typenone/property
 child
-  object class=GtkAlignment id=alignment2
+  object class=GtkGrid id=grid5
 property name=visibleTrue/property
 property name=can_focusFalse/property
-property name=top_padding6/property
-property name=left_padding12/property
+property name=margin_left12/property
+property name=margin_top6/property
+property name=column_spacing12/property
 child
-  object class=GtkGrid id=grid5
+  object class=GtkLabel id=label7
 property name=visibleTrue/property
 property name=can_focusFalse/property
-

[PATCH] Show only filename in Recent Files list

2013-04-30 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3700

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/3700/1

Show only filename in Recent Files list

As discussed here: 
http://nabble.documentfoundation.org/Libreoffice-ux-advise-Recent-files-dropdown-td4052945.html#a4052996

The changes are (inspired by Gedit):
* Display only the filename, not the (abbreviated) path
* Show the protocol name before the file, if not local (e.g. ftp: myfile.odt)
* After the keyboard shortcut (a number from 1 to 10) display a '.' instead of 
a ':' (because the protocol has a ':')

Change-Id: I47472c901aa866adb76c7c7ab36bc871f82ad8df
---
M framework/source/uielement/recentfilesmenucontroller.cxx
M include/tools/urlobj.hxx
M tools/source/fsys/urlobj.cxx
3 files changed, 23 insertions(+), 19 deletions(-)



diff --git a/framework/source/uielement/recentfilesmenucontroller.cxx 
b/framework/source/uielement/recentfilesmenucontroller.cxx
index 3d8d9c9..6259924 100644
--- a/framework/source/uielement/recentfilesmenucontroller.cxx
+++ b/framework/source/uielement/recentfilesmenucontroller.cxx
@@ -40,13 +40,12 @@
 using namespace com::sun::star::beans;
 using namespace com::sun::star::util;
 
-#define MAX_STR_WIDTH   46
 #define MAX_MENU_ITEMS  99
 
 static const char SFX_REFERER_USER[] = private:user;
 static const char CMD_CLEAR_LIST[]   = .uno:ClearRecentFileList;
 static const char CMD_PREFIX[]   = 
vnd.sun.star.popup:RecentFileList?entry=;
-static const char MENU_SHOTCUT[] = ~N: ;
+static const char MENU_SHORTCUT[] = ~N. ;
 
 namespace framework
 {
@@ -133,17 +132,17 @@
 if ( i = 9 )
 {
 if ( i == 9 )
-aMenuShortCut.append( 1~0:  );
+aMenuShortCut.append( 1~0.  );
 else
 {
-aMenuShortCut.append( MENU_SHOTCUT );
+aMenuShortCut.append( MENU_SHORTCUT );
 aMenuShortCut[ 1 ] = sal_Unicode( i + '1' );
 }
 }
 else
 {
 aMenuShortCut.append( sal_Int32( i + 1 ) );
-aMenuShortCut.append( :  );
+aMenuShortCut.append( .  );
 }
 
 OUStringBuffer aStrBuffer;
@@ -152,28 +151,19 @@
 OUString  aURLString( aStrBuffer.makeStringAndClear() );
 
 // Abbreviate URL
-OUString   aTipHelpText;
 OUString   aMenuTitle;
 INetURLObject   aURL( m_aRecentFilesItems[i].aURL );
+OUString aTipHelpText( aURL.getFSysPath( 
INetURLObject::FSYS_DETECT ) );
 
 if ( aURL.GetProtocol() == INET_PROT_FILE )
 {
-// Do handle file URL differently = convert it to a system
-// path and abbreviate it with a special function:
-OUString aSystemPath( aURL.getFSysPath( 
INetURLObject::FSYS_DETECT ) );
-aTipHelpText = aSystemPath;
-
-OUString aCompactedSystemPath;
-if ( osl_abbreviateSystemPath( aSystemPath.pData, 
aCompactedSystemPath.pData, MAX_STR_WIDTH, NULL ) == osl_File_E_None )
-aMenuTitle = aCompactedSystemPath;
-else
-aMenuTitle = aSystemPath;
+// Do handle file URL differently: don't show the 
protocol, just the file name
+aMenuTitle = aURL.getName();
 }
 else
 {
-// Use INetURLObject to abbreviate all other URLs
-aMenuTitle   = aURL.getAbbreviated( xStringLength, 
MAX_STR_WIDTH, INetURLObject::DECODE_UNAMBIGUOUS );
-aTipHelpText = aURLString;
+// In all other URLs show the protocol name before the 
file name
+aMenuTitle   = aURL.GetSchemeName(aURL.GetProtocol()) + : 
 + aURL.getName();
 }
 
 aMenuShortCut.append( aMenuTitle );
diff --git a/include/tools/urlobj.hxx b/include/tools/urlobj.hxx
index fef9f46..8905334 100644
--- a/include/tools/urlobj.hxx
+++ b/include/tools/urlobj.hxx
@@ -484,6 +484,14 @@
  */
 static OUString GetScheme(INetProtocol eTheScheme);
 
+/** Return the a human-readable name for a given scheme.
+
+@param eTheScheme  One of the supported URL schemes.
+
+@return  The protocol name of URLs of the given scheme.
+ */
+static OUString GetSchemeName(INetProtocol eTheScheme);
+
 static inline INetProtocol CompareProtocolScheme(const OString
  rTheAbsURIRef)
 { return CompareProtocolScheme(extend(rTheAbsURIRef)); }
diff --git a/tools/source/fsys/urlobj.cxx

[PATCH] Better text for Insert as Link Checkbox

2013-04-25 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3602

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/3602/1

Better text for Insert as Link Checkbox

This Checkbox is shown in the File picker dialog and does not embed the file in 
the document, if checked.

Change-Id: I84fbc182cc9b432cd38ccb044c0479ced119d97f
---
M vcl/source/src/fpicker.src
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/vcl/source/src/fpicker.src b/vcl/source/src/fpicker.src
index be40726..324cffb 100644
--- a/vcl/source/src/fpicker.src
+++ b/vcl/source/src/fpicker.src
@@ -41,7 +41,7 @@
 
 String STR_FPICKER_INSERT_AS_LINK
 {
-Text [ en-US ] = ~Link ;
+Text [ en-US ] = Insert as ~Link ;
 };
 
 String STR_FPICKER_SHOW_PREVIEW

-- 
To view, visit https://gerrit.libreoffice.org/3602
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84fbc182cc9b432cd38ccb044c0479ced119d97f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix inconsistent names: Image instead of Picture or Graphic

2013-04-25 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3603

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/3603/1

Fix inconsistent names: Image instead of Picture or Graphic

Graphical objects were sometimes named Picture and sometimes Graphic.
Image is more generic and implies both other words.

Change-Id: I30ccca5dba5d65c8ee47f92fd3dfd1dcd46219b4
---
M officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
M officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
M officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu
M officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu
M officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState.xcu
M officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu
M officecfg/registry/schema/org/openoffice/Office/Writer.xcs
M officecfg/registry/schema/org/openoffice/Office/WriterWeb.xcs
M officecfg/registry/schema/org/openoffice/TypeDetection/GraphicFilter.xcs
M svx/inc/globlmn_tmpl.hrc
M svx/source/core/graphichelper.src
M sw/source/core/undo/undo.src
M sw/source/ui/app/mn.src
M sw/source/ui/config/optload.src
M sw/source/ui/frmdlg/frmpage.src
M sw/source/ui/shells/shells.src
M sw/source/ui/utlui/poolfmt.src
17 files changed, 62 insertions(+), 62 deletions(-)



diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 925d513..394ecfb 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -1840,7 +1840,7 @@
 /node
 node oor:name=.uno:GrafAttrCrop oor:op=replace
 prop oor:name=Label oor:type=xs:string
-value xml:lang=en-USCrop Picture.../value
+value xml:lang=en-USCrop Image.../value
 /prop
 prop oor:name=Properties oor:type=xs:int
 value1/value
@@ -1848,7 +1848,7 @@
 /node
 node oor:name=.uno:Crop oor:op=replace
 prop oor:name=Label oor:type=xs:string
-value xml:lang=en-USCrop Picture/value
+value xml:lang=en-USCrop Image/value
 /prop
 prop oor:name=Properties oor:type=xs:int
 value1/value
@@ -5292,7 +5292,7 @@
 /node
 node oor:name=.uno:GraphicMenu oor:op=replace
 prop oor:name=Label oor:type=xs:string
-value xml:lang=en-USPict~ure/value
+value xml:lang=en-US~Image/value
 /prop
 /node
 node oor:name=.uno:WindowList oor:op=replace
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index 2fc7502..33099ad 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -875,10 +875,10 @@
 /node
 node oor:name=.uno:GraphicDialog oor:op=replace
 prop oor:name=Label oor:type=xs:string
-value xml:lang=en-USPicture.../value
+value xml:lang=en-USImage.../value
 /prop
 prop oor:name=ContextLabel oor:type=xs:string
-value xml:lang=en-USPict~ure.../value
+value xml:lang=en-US~Image.../value
 /prop
 /node
 node oor:name=.uno:TableDialog oor:op=replace
@@ -1838,7 +1838,7 @@
 /node
 node oor:name=.uno:MirrorGraphicOnEvenPages oor:op=replace
 prop oor:name=Label oor:type=xs:string
-value xml:lang=en-USFlip Graphics on Even Pages/value
+value xml:lang=en-USFlip Images on Even Pages/value
 /prop
 /node
 node oor:name=.uno:SplitTable oor:op=replace
@@ -2055,7 +2055,7 @@
 /node
 node oor:name=.uno:Graphic oor:op=replace
 prop oor:name=Label oor:type=xs:string
-value xml:lang=en-USGraphics On/Off/value
+value xml:lang=en-USImages On/Off/value
 /prop
 prop oor:name=Properties oor:type=xs:int
 value1/value
@@ -2294,7 +2294,7 @@
 /node
 node oor:name=.uno:SaveGraphic oor:op=replace
 prop oor:name=Label oor:type=xs:string
-value xml:lang=en-USSave Graphics.../value
+value xml:lang=en-USSave Image.../value
 /prop
 /node
 node oor:name=.uno:ContinueNumbering oor:op=replace
diff --git

[PATCH] Better wording for Impress Start from first/current Slide

2013-04-25 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3604

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/3604/1

Better wording for Impress Start from first/current Slide

The menu is now:
Slide Show
  Start from first Slide
  Start from current Slide
  ...
instead of:
Slide Show
  Slide Show
  Slide Show From This Slide
  ...

I also changed the recently introduced function name/uno command for Start 
from current Slide.
This should make no trouble, since this function has not seen a release so far.

Change-Id: I248c9d63ec28071b2887f89912aa90fa1e4afcb5
---
M officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
M officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
M sd/inc/sdcommands.h
M sd/sdi/SlideSorterController.sdi
M sd/sdi/sdraw.sdi
M sd/source/ui/slidesorter/controller/SlsSlotManager.cxx
M sd/source/ui/view/drviewse.cxx
M sd/source/ui/view/outlnvs2.cxx
M sd/uiconfig/simpress/menubar/menubar.xml
M svx/inc/svx/svxids.hrc
10 files changed, 12 insertions(+), 18 deletions(-)



diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu 
b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
index 6cf3ae3..afb17b0 100644
--- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
@@ -2234,7 +2234,7 @@
 /node
 node oor:name=F5_SHIFT oor:op=replace
  prop oor:name=Commandvalue xml:lang=x-no-translateI10N SHORTCUTS 
- NO TRANSLATE/value
-  value xml:lang=en-US.uno:PresentationThisSlide/value
+  value xml:lang=en-US.uno:PresentationCurrentSlide/value
  /prop
 /node
 node oor:name=F5_SHIFT_MOD2 oor:op=replace
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
index 9efa408..d31e6a4 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
@@ -31,15 +31,15 @@
   /node
   node oor:name=.uno:Presentation oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-US~Slide Show/value
+  value xml:lang=en-USStart from ~first Slide/value
 /prop
 prop oor:name=Properties oor:type=xs:int
   value1/value
 /prop
   /node
-  node oor:name=.uno:PresentationThisSlide oor:op=replace
+  node oor:name=.uno:PresentationCurrentSlide oor:op=replace
 prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-USSl~ide Show From This Slide/value
+  value xml:lang=en-USStart from c~urrent Slide/value
 /prop
 prop oor:name=Properties oor:type=xs:int
   value1/value
@@ -1534,11 +1534,6 @@
   value xml:lang=en-US~Slide Show/value
 /prop
   /node
-  !--node oor:name=.uno:ReviewMenu oor:op=replace
-prop oor:name=Label oor:type=xs:string
-  value xml:lang=en-US~Review/value
-/prop
-  /node--
   node oor:name=.uno:GroupMenu oor:op=replace
 prop oor:name=Label oor:type=xs:string
   value xml:lang=en-US~Group/value
diff --git a/sd/inc/sdcommands.h b/sd/inc/sdcommands.h
index f64e686..abd03ce 100644
--- a/sd/inc/sdcommands.h
+++ b/sd/inc/sdcommands.h
@@ -94,7 +94,7 @@
 #define CMD_SID_OUTLINE_TEXT_AUTOFIT.uno.OutlineTextAutofit
 #define CMD_SID_PAGESETUP   .uno:PageSetup
 #define CMD_SID_PRESENTATION.uno:Presentation
-#define CMD_SID_PRESENTATION_THIS_SLIDE 
.uno:PresentationThisSlide
+#define CMD_SID_PRESENTATION_CURRENT_SLIDE  
.uno:PresentationCurrentSlide
 #define CMD_SID_REMOTE_DLG  .uno:Remote
 #define CMD_SID_PRESENTATION_LAYOUT .uno:PresentationLayout
 #define CMD_SID_RENAMELAYER .uno:RenameLayer
diff --git a/sd/sdi/SlideSorterController.sdi b/sd/sdi/SlideSorterController.sdi
index 5b717d1..36ddbd8 100644
--- a/sd/sdi/SlideSorterController.sdi
+++ b/sd/sdi/SlideSorterController.sdi
@@ -136,7 +136,7 @@
 ExecMethod = FuTemporary ;
 StateMethod = GetMenuState ;
 ]
-SID_PRESENTATION_THIS_SLIDE // ole : no, status : ?
+SID_PRESENTATION_CURRENT_SLIDE // ole : no, status : ?
 [
 ExecMethod = FuTemporary ;
 StateMethod = GetMenuState ;
diff --git a/sd/sdi/sdraw.sdi b/sd/sdi/sdraw.sdi
index 5e913a2..60c22ff 100644
--- a/sd/sdi/sdraw.sdi
+++ b/sd/sdi/sdraw.sdi
@@ -5196,7 +5196,7 @@
 ]
 
 //--
-SfxVoidItem PresentationThisSlide SID_PRESENTATION_THIS_SLIDE
+SfxVoidItem PresentationCurrentSlide SID_PRESENTATION_CURRENT_SLIDE
 ()
 [
 /* flags: */
diff --git a/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx

[PATCH] fdo#56832 Explicitly mention Ogg Audio and Video

2013-04-25 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3609

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/3609/1

fdo#56832 Explicitly mention Ogg Audio and Video

.ogx is also a valid extension, see 
http://wiki.xiph.org/MIME_Types_and_File_Extensions

Change-Id: Ieb5f3b7016b58beaf915673181369530a3d0709e
---
M avmedia/source/viewer/mediawindow.cxx
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/avmedia/source/viewer/mediawindow.cxx 
b/avmedia/source/viewer/mediawindow.cxx
index 41d2ca8..c75b4d9 100644
--- a/avmedia/source/viewer/mediawindow.cxx
+++ b/avmedia/source/viewer/mediawindow.cxx
@@ -223,7 +223,8 @@
   MIDI Audio, mid;midi,
   MPEG Audio, mp2;mp3;mpa,
   MPEG Video, mpg;mpeg;mpv;mp4,
-  Ogg bitstream, ogg;oga;ogv,
+  Ogg Audio, ogg;oga;,
+  Ogg Video, ogv;ogx;,
   Quicktime Video, mov,
   Vivo Video, viv,
   WAVE Audio, wav,

-- 
To view, visit https://gerrit.libreoffice.org/3609
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb5f3b7016b58beaf915673181369530a3d0709e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Add PDF Mimetype to Draw

2013-03-04 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2549

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/2549/1

Add PDF Mimetype to Draw

PDF Import is now a Core Component

Change-Id: I1313a7e7ea1c2409cb40cb8058e3b4ab78601fe4
---
M sysui/desktop/menus/draw.desktop
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/sysui/desktop/menus/draw.desktop b/sysui/desktop/menus/draw.desktop
index 2ffee61..a57d988 100755
--- a/sysui/desktop/menus/draw.desktop
+++ b/sysui/desktop/menus/draw.desktop
@@ -22,7 +22,7 @@
 Type=Application
 
Categories=Office;FlowChart;Graphics;2DGraphics;VectorGraphics;X-Red-Hat-Base;X-MandrivaLinux-Office-Drawing;
 Exec=${UNIXBASISROOTNAME} --draw %U
-MimeType=application/vnd.oasis.opendocument.graphics;application/vnd.oasis.opendocument.graphics-template;application/vnd.sun.xml.draw;application/vnd.sun.xml.draw.template;application/vnd.visio;application/x-wpg;
+MimeType=application/vnd.oasis.opendocument.graphics;application/vnd.oasis.opendocument.graphics-template;application/vnd.sun.xml.draw;application/vnd.sun.xml.draw.template;application/vnd.visio;application/x-wpg;application/pdf;
 Name=%PRODUCTNAME Draw
 GenericName=Drawing Program
 Comment=Create and edit drawings, flow charts and logos by using Draw.

-- 
To view, visit https://gerrit.libreoffice.org/2549
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1313a7e7ea1c2409cb40cb8058e3b4ab78601fe4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Better wording for several Actions

2013-02-02 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1967

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/1967/1

Better wording for several Actions

Change-Id: I948f10518510d017d69a883c68d4e9dda94b7bb6
---
M sc/source/ui/src/hdrcont.src
M sw/source/ui/lingu/olmenu.src
2 files changed, 9 insertions(+), 9 deletions(-)



diff --git a/sc/source/ui/src/hdrcont.src b/sc/source/ui/src/hdrcont.src
index 6447271..7a7d070 100644
--- a/sc/source/ui/src/hdrcont.src
+++ b/sc/source/ui/src/hdrcont.src
@@ -77,19 +77,19 @@
 {
 Identifier = FID_INS_ROW ;
 HelpId = CMD_FID_INS_ROW ;
-Text [ en-US ] = ~Insert Rows ;
+Text [ en-US ] = ~Insert Rows above ;
 };
 MenuItem
 {
 Identifier = SID_DEL_ROWS ;
 HelpId = CMD_SID_DEL_ROWS ;
-Text [ en-US ] = ~Delete Rows ;
+Text [ en-US ] = ~Delete selected Rows ;
 };
 MenuItem
 {
 Identifier = SID_DELETE ;
 HelpId = CMD_SID_DELETE ;
-Text [ en-US ] = De~lete Contents... ;
+Text [ en-US ] = De~lete Row Contents... ;
 };
  //--
 MenuItem { Separator = TRUE ; };
@@ -148,19 +148,19 @@
 {
 Identifier = FID_INS_COLUMN ;
 HelpId = CMD_FID_INS_COLUMN ;
-Text [ en-US ] = ~Insert Columns ;
+Text [ en-US ] = ~Insert Columns left ;
 };
 MenuItem
 {
 Identifier = SID_DEL_COLS ;
 HelpId = CMD_SID_DEL_COLS ;
-Text [ en-US ] = ~Delete Columns ;
+Text [ en-US ] = ~Delete selected Columns ;
 };
 MenuItem
 {
 Identifier = SID_DELETE ;
 HelpId = CMD_SID_DELETE ;
-Text [ en-US ] = D~elete Contents... ;
+Text [ en-US ] = D~elete Column Contents... ;
 };
  //--
 MenuItem { Separator = TRUE ; };
diff --git a/sw/source/ui/lingu/olmenu.src b/sw/source/ui/lingu/olmenu.src
index c5da211..e5f2dd3 100644
--- a/sw/source/ui/lingu/olmenu.src
+++ b/sw/source/ui/lingu/olmenu.src
@@ -40,13 +40,13 @@
 SubMenu = Menu
 {
 };
-Text [ en-US ] = ~Add to dictionary ;
+Text [ en-US ] = ~Add to Dictionary ;
 };
 MenuItem
 {
 Identifier = MN_ADD_TO_DIC_SINGLE ;
 HelpID = HID_LINGU_ADD_WORD ;
-Text [ en-US ] = ~Add to dictionary ;
+Text [ en-US ] = ~Add to Dictionary ;
 };
 MenuItem
 {
@@ -87,7 +87,7 @@
 SubMenu = Menu
 {
 };
-Text [ en-US ] = Set Language for all Text ;
+Text [ en-US ] = Set Language for the Document ;
 };
 */
 };

-- 
To view, visit https://gerrit.libreoffice.org/1967
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I948f10518510d017d69a883c68d4e9dda94b7bb6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] This also removes an English text in the Master page: Click...

2013-01-16 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1725

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1725/1

This also removes an English text in the Master page: Click here to edit... 
and replaces it with a placeholder

It would be nice to have this in 4.0 branch also.

Change-Id: I1aadc20aa9916e40bbaf1b6f66ec58dfd02a35bb
---
M extras/source/templates/layout/BrightBlue.otp
1 file changed, 0 insertions(+), 0 deletions(-)



diff --git a/extras/source/templates/layout/BrightBlue.otp 
b/extras/source/templates/layout/BrightBlue.otp
index 3cb8c16..2366b03 100644
--- a/extras/source/templates/layout/BrightBlue.otp
+++ b/extras/source/templates/layout/BrightBlue.otp
Binary files differ

-- 
To view, visit https://gerrit.libreoffice.org/1725
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aadc20aa9916e40bbaf1b6f66ec58dfd02a35bb
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Better wording for Spellcheck buttons/context menu

2013-01-04 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1541

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/1541/1

Better wording for Spellcheck buttons/context menu

Change-Id: Iddf82427c17a1caf72897e7af7592052c8e4fa71
---
M cui/uiconfig/ui/spellingdialog.ui
M sw/source/ui/lingu/olmenu.src
2 files changed, 5 insertions(+), 5 deletions(-)



diff --git a/cui/uiconfig/ui/spellingdialog.ui 
b/cui/uiconfig/ui/spellingdialog.ui
index 26bfdfe..155f01e 100644
--- a/cui/uiconfig/ui/spellingdialog.ui
+++ b/cui/uiconfig/ui/spellingdialog.ui
@@ -164,7 +164,7 @@
 /child
 child
   object class=GtkButton id=change
-property name=label translatable=yes_Change/property
+property name=label translatable=yes_Correct/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -180,7 +180,7 @@
 /child
 child
   object class=GtkButton id=changeall
-property name=label translatable=yesChange 
A_ll/property
+property name=label translatable=yesCorrect 
A_ll/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -196,7 +196,7 @@
 /child
 child
   object class=GtkButton id=autocorrect
-property name=label 
translatable=yesAutoCor_rect/property
+property name=label translatable=yesAlwa_ys 
correct/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -212,7 +212,7 @@
 /child
 child
   object class=GtkCheckButton id=checkgrammar
-property name=label translatable=yesCheck 
_grammar/property
+property name=label translatable=yesCheck 
_Grammar/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultFalse/property
diff --git a/sw/source/ui/lingu/olmenu.src b/sw/source/ui/lingu/olmenu.src
index ae0897f..360692a 100644
--- a/sw/source/ui/lingu/olmenu.src
+++ b/sw/source/ui/lingu/olmenu.src
@@ -55,7 +55,7 @@
 SubMenu = Menu
 {
 };
-Text [ en-US ] = AutoCorrect ;
+Text [ en-US ] = Always correct to ;
 };
 MenuItem
 {

-- 
To view, visit https://gerrit.libreoffice.org/1541
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddf82427c17a1caf72897e7af7592052c8e4fa71
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change 'Add' to 'Add to Dictionary' in the Dialog also

2013-01-04 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1542

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/1542/1

Change 'Add' to 'Add to Dictionary' in the Dialog also

Change-Id: I4bcf53239f001ed2d6ea08a743257ed0d6428752
---
M cui/uiconfig/ui/spellingdialog.ui
1 file changed, 18 insertions(+), 4 deletions(-)



diff --git a/cui/uiconfig/ui/spellingdialog.ui 
b/cui/uiconfig/ui/spellingdialog.ui
index 155f01e..165fff7 100644
--- a/cui/uiconfig/ui/spellingdialog.ui
+++ b/cui/uiconfig/ui/spellingdialog.ui
@@ -18,6 +18,7 @@
 child
   object class=GtkButton id=help
 property name=labelgtk-help/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -33,6 +34,7 @@
 child
   object class=GtkButton id=options
 property name=label 
translatable=yesO_ptions.../property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -47,6 +49,7 @@
 child
   object class=GtkButton id=undo
 property name=label translatable=yes_Undo/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -61,6 +64,7 @@
 child
   object class=GtkButton id=close
 property name=labelgtk-close/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=can_defaultTrue/property
@@ -120,6 +124,7 @@
 child
   object class=GtkButton id=ignore
 property name=label translatable=yes_Ignore 
Once/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -165,6 +170,7 @@
 child
   object class=GtkButton id=change
 property name=label translatable=yes_Correct/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -181,6 +187,7 @@
 child
   object class=GtkButton id=changeall
 property name=label translatable=yesCorrect 
A_ll/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -197,6 +204,7 @@
 child
   object class=GtkButton id=autocorrect
 property name=label translatable=yesAlwa_ys 
correct/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
@@ -213,6 +221,7 @@
 child
   object class=GtkCheckButton id=checkgrammar
 property name=label translatable=yesCheck 
_Grammar/property
+property name=use_action_appearanceFalse/property
 property name=visibleTrue/property
 property name=can_focusTrue/property
 property name=receives_defaultFalse/property
@@ -230,6 +239,7 @@
 child
   object class=GtkButton id=ignoreall
 property name=label translatable=yesI_gnore 
All/property
+property name=use_action_appearanceFalse/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
 property name=no_show_allTrue/property
@@ -246,6 +256,7 @@
 child
   object class=GtkButton id=ignorerule
 property name=label translatable=yesI_gnore 
Rule/property
+property name=use_action_appearanceFalse/property
 property name=can_focusTrue/property
 property name=receives_defaultTrue/property
 property name=no_show_allTrue/property
@@ -292,6 +303,7 @@
 child
   object class=GtkLinkButton

[PATCH] Spellcheck menu: Rename 'Add' to 'Add to Dictionary'

2013-01-03 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1539

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/1539/1

Spellcheck menu: Rename 'Add' to 'Add to Dictionary'

Change-Id: I601bf1fc34f3e4cccef02d1d4a5ecd1959007cf7
---
M editeng/source/editeng/editeng.src
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/editeng/source/editeng/editeng.src 
b/editeng/source/editeng/editeng.src
index 2bea4aa..655861b 100644
--- a/editeng/source/editeng/editeng.src
+++ b/editeng/source/editeng/editeng.src
@@ -82,13 +82,13 @@
 SubMenu = Menu
 {
 };
-Text [ en-US ] = ~Add ;
+Text [ en-US ] = ~Add to Dictionary ;
 };
 MenuItem
 {
 Identifier = MN_INSERT_SINGLE ;
 HelpId = HID_EDITENG_SPELLER_ADDWORD;
-Text [ en-US ] = ~Add ;
+Text [ en-US ] = ~Add to Dictionary ;
 };
 MenuItem
 {

-- 
To view, visit https://gerrit.libreoffice.org/1539
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I601bf1fc34f3e4cccef02d1d4a5ecd1959007cf7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Changed Writer follow-up Styles for Title and Quotations

2012-12-15 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1349

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/1349/1

Changed Writer follow-up Styles for Title and Quotations

Text body is the most sensible follower for these I think.

Change-Id: I4fc091446ada5f4aea82ba79dba84f2874bca760
---
M sw/source/core/doc/poolfmt.cxx
1 file changed, 3 insertions(+), 4 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1349
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fc091446ada5f4aea82ba79dba84f2874bca760
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Modify the default Style list in Writer, give them a custom ...

2012-12-06 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1248

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/1248/1

Modify the default Style list in Writer, give them a custom order.

Asking on UX-Advise, there were no negative voices for this change:
http://nabble.documentfoundation.org/Libreoffice-ux-advise-Default-Styles-in-Writer-td4020441.html

Change-Id: I780eaecc29c88493f09194399dfc00be1484c549
---
M svx/source/tbxctrls/tbcontrl.cxx
1 file changed, 10 insertions(+), 8 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1248
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I780eaecc29c88493f09194399dfc00be1484c549
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] New Layout for 'Insert Table' Dialog

2012-11-26 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1172

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/1172/1

New Layout for 'Insert Table' Dialog

As discussed in 
http://nabble.documentfoundation.org/Libreoffice-ux-advise-New-Layout-for-Insert-Table-Dialog-td4020074.html

Change-Id: Icd1a77d845aa14a918077ccefd7f9892ad05f199
---
M sw/uiconfig/swriter/ui/inserttable.ui
1 file changed, 121 insertions(+), 131 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1172
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd1a77d845aa14a918077ccefd7f9892ad05f199
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] New Layout for Word Count Dialog

2012-11-06 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/995

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/995/1

New Layout for Word Count Dialog

Change-Id: I653b0546fc677bf8cfceac38cb0f98a1b106d0e2
---
M sw/uiconfig/swriter/ui/wordcount.ui
1 file changed, 37 insertions(+), 93 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/995
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I653b0546fc677bf8cfceac38cb0f98a1b106d0e2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Hide the rulers in Writer by default for a cleaner look

2012-11-01 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/956

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/956/1

Hide the rulers in Writer by default for a cleaner look

This is consistent with Impress. Might need to be discussed with ux-advise

Change-Id: Icbe719207410d952c76d96c84450fd5a5831ea15
---
M officecfg/registry/schema/org/openoffice/Office/Writer.xcs
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/956
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbe719207410d952c76d96c84450fd5a5831ea15
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#47157 Add more keywords to .desktop files

2012-10-31 Thread Samuel Mehrbrodt (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/953

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/953/1

fdo#47157 Add more keywords to .desktop files

Change-Id: I34d0bf75d7cf8c5ec764a1bfa0ad0e4c5ab8ae4e
---
M sysui/desktop/menus/calc.desktop
M sysui/desktop/menus/draw.desktop
M sysui/desktop/menus/impress.desktop
M sysui/desktop/menus/math.desktop
M sysui/desktop/menus/writer.desktop
5 files changed, 6 insertions(+), 6 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/953
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34d0bf75d7cf8c5ec764a1bfa0ad0e4c5ab8ae4e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice