[PUSHED] Remove xml2cmp leftovers: Remove FlatXmlFilter_cpp.uno.xml f...

2012-12-14 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1336

Approvals:
  Stephan Bergmann: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1336
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I816c9dd797fbf49d300cd0442c87f343bd1308d4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lior Kaplan kaplanl...@gmail.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: Take extra cache/uno_packages/*.tmp_/*properties files into ...

2012-12-13 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1313

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1313/1

Take extra cache/uno_packages/*.tmp_/*properties files into account

...when migrating user extensions from an old user profile.

Change-Id: I4425eba1e840bfdb33782bb3ed0542ce48b2f75f
(cherry picked from commit bd9c4510ff13ab7e935ed12c5b6d1f132c6f2b79)
---
M desktop/source/migration/services/oo3extensionmigration.cxx
1 file changed, 14 insertions(+), 11 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1313
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4425eba1e840bfdb33782bb3ed0542ce48b2f75f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] startup: more reliable startup of multiple instances

2012-12-13 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1089


--
To view, visit https://gerrit.libreoffice.org/1089
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e099a5804e1e8dd535cfd31ef454cffa44efa62
Gerrit-PatchSet: 5
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com
Gerrit-Reviewer: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Introduce SAL_DELETE

2012-12-11 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1299

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/1299/1

Introduce SAL_DELETE

Change-Id: I7ac7392646ea34fb2e6a9f15990aca05a2c1e484
---
M sal/inc/rtl/ustrbuf.hxx
M sal/inc/sal/types.h
M sfx2/inc/sfx2/docfile.hxx
3 files changed, 21 insertions(+), 4 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1299
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ac7392646ea34fb2e6a9f15990aca05a2c1e484
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Introduce SAL_DELETE

2012-12-11 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1299


--
To view, visit https://gerrit.libreoffice.org/1299
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ac7392646ea34fb2e6a9f15990aca05a2c1e484
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


-Werror,-Wtautological-constant-out-of-range-compare

2012-12-07 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change.

Change subject: -Werror,-Wtautological-constant-out-of-range-compare
..


Patch Set 1: Abandoned

--
To view, visit https://gerrit.libreoffice.org/1255
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I1c9cf55e2a0ca9d725ce65d8f0a0748e4ca13886
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Change in core[libreoffice-3-6]: Resolves: fdo#51638 In unopkg gui dispose component contex...

2012-12-07 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1263


--
To view, visit https://gerrit.libreoffice.org/1263
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibec3d19040fdae23f492cd1e29084e673403e00b
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#57927: Clarify msi installer only installs subset of dic...

2012-12-06 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1254

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/1254/1

fdo#57927: Clarify msi installer only installs subset of dicts by default

...since this was changed with fdo#53009 in LO 3.6.3.

Change-Id: I95b8da1311c666945e9bbe15d22da59add6b6227
(cherry picked from commit d35849b6f718990869b01209865bb70cb7343ceb)
---
M instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
1 file changed, 2 insertions(+), 2 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1254
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95b8da1311c666945e9bbe15d22da59add6b6227
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] -Werror,-Wtautological-constant-out-of-range-compare

2012-12-06 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1255

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/1255/1

-Werror,-Wtautological-constant-out-of-range-compare

...so assuming this was meant instead?

Change-Id: I1c9cf55e2a0ca9d725ce65d8f0a0748e4ca13886
---
M sw/source/ui/shells/txtattr.cxx
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1255
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c9cf55e2a0ca9d725ce65d8f0a0748e4ca13886
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: -Werror=unused-parameter

2012-12-03 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1228

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/1228/1

-Werror=unused-parameter

Change-Id: If1aad98965a90ac6b2e5488f21fe0d84c9b4af47
(cherry picked from commit c2500a004dbb4830202b49d8031e35e66c7c739d)
---
M desktop/unx/source/splashx.c
1 file changed, 3 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1228
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1aad98965a90ac6b2e5488f21fe0d84c9b4af47
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: --without-system-libpng for universal Linux builds

2012-12-03 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1229

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/1229/1

--without-system-libpng for universal Linux builds

...so that e.g. Fedora 17 does not require installation of libpng-compat package
for old libpng12.so.

Change-Id: I45cf3928b30dbbb815f70cde1972dc4972007c05
(cherry picked from commit 2a6980107015a30e01873a45f8798b8a20ccfd73)
---
M distro-configs/LibreOfficeLinux.conf
1 file changed, 1 insertion(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1229
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45cf3928b30dbbb815f70cde1972dc4972007c05
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Do not override the message of an underlying PropertyVetoExc...

2012-11-30 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1198


--
To view, visit https://gerrit.libreoffice.org/1198
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1026ad87f3031f1c56066ab24d23d3a6d8782b
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Change in core[libreoffice-3-6]: fdo#57611 do not crash when setting too small size

2012-11-30 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1197


--
To view, visit https://gerrit.libreoffice.org/1197
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ae2048a6c0acc6b6cf2beece9e630c87caac39f
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] add SAL_WARN_UNUSED_RESULT in OString and OUString where app...

2012-11-28 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1186


--
To view, visit https://gerrit.libreoffice.org/1186
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a9c0b4c7d0b75ad8850ac23b86e8508a334f5fe
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Change in core[libreoffice-3-6]: Resolves: fdo#53909 STG_FREE sector locations rejected

2012-11-22 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1150

Approvals:
  Stephan Bergmann: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1150
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f71c7e3cfeeba8a76096d5be68838b8d401c580
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#57224: Preserve disabled-state across reinstallDeployedE...

2012-11-19 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1115

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1115/1

fdo#57224: Preserve disabled-state across reinstallDeployedExtensions

Change-Id: I8d65b76fd93b63b51db88b7b09902ba64732dd97
(cherry picked from commit 6f9c3bc8edc93be07273d9de13dda19ea6c1da4a)
---
M desktop/source/deployment/manager/dp_extensionmanager.cxx
1 file changed, 29 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1115
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d65b76fd93b63b51db88b7b09902ba64732dd97
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Change in core[libreoffice-3-6]: fdo#57224: Preserve disabled-state across reinstallDeployedE...

2012-11-19 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change.

Change subject: fdo#57224: Preserve disabled-state across 
reinstallDeployedExtensions
..


Patch Set 1: Abandoned

doesn't work after all

--
To view, visit https://gerrit.libreoffice.org/1115
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8d65b76fd93b63b51db88b7b09902ba64732dd97
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6-4]: fdo#57224: Preserve disabled-state across reinstallDeployedE...

2012-11-19 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1120

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/1120/1

fdo#57224: Preserve disabled-state across reinstallDeployedExtensions

(cherry picked from commit 6f9c3bc8edc93be07273d9de13dda19ea6c1da4a plus follow-
up a05e1e4967a21f3dd5a49215d97df99a7ec84f18 fdo#57224: Fix logic of considering
optional/ambiguous value as 'disabled')

Change-Id: Ic4f6cda4de758df4789e80b48b30f11ef810d2bd
---
M desktop/source/deployment/manager/dp_extensionmanager.cxx
1 file changed, 29 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1120
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4f6cda4de758df4789e80b48b30f11ef810d2bd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-4
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#57224: Preserve disabled-state across reinstallDeployedE...

2012-11-19 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1119

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1119/1

fdo#57224: Preserve disabled-state across reinstallDeployedExtensions

(cherry picked from commit 6f9c3bc8edc93be07273d9de13dda19ea6c1da4a plus follow-
up a05e1e4967a21f3dd5a49215d97df99a7ec84f18 fdo#57224: Fix logic of considering
optional/ambiguous value as 'disabled')

Change-Id: Ic4f6cda4de758df4789e80b48b30f11ef810d2bd
---
M desktop/source/deployment/manager/dp_extensionmanager.cxx
1 file changed, 29 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1119
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4f6cda4de758df4789e80b48b30f11ef810d2bd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Drop the check for unordered_map.hxx

2012-11-15 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1075


--
To view, visit https://gerrit.libreoffice.org/1075
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iedff10f3b2562f731063107df7220efa124aca08
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Tomáš Chvátal tchva...@suse.cz
Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: Tomáš Chvátal tchva...@suse.cz
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: Enable NPP_Initialize/Shutdown again

2012-11-13 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1042

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/1042/1

Enable NPP_Initialize/Shutdown again

...calling which had erroneously been dropped in
bdead69dd3c947743907681c8a2f16ca1f50cd9c Add switch for system/internal
npapi.h.  This makes the npsoplugin browser plugin work again.

(Also, init write_fd to -1 instead of 0, so that a missing do_init_pipe does not
accidentally cause writing to write_fd succeed in writing to stdin.)

(cherry picked from commit 9081e07c9c92267d86a90752b28bd42b592782a8 plus follow-
up 6ce21d57d9a627a95bfb2f10519ae3cd032f521b Typo)

Conflicts:
extensions/Library_npsoplugin.mk

Change-Id: Iced734512a43c8dfea46088f7ac16f159e7dd807
---
M extensions/Library_npsoplugin.mk
M extensions/source/nsplugin/source/npshell.cxx
M np_sdk/Package_inc.mk
M np_sdk/mozsrc/npunix.c
M np_sdk/mozsrc/npwin.cxx
A np_sdk/mozsrc/plugin.h
6 files changed, 60 insertions(+), 7 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1042
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iced734512a43c8dfea46088f7ac16f159e7dd807
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] add indexOf family of function to OUStringBuffer

2012-11-09 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1006


--
To view, visit https://gerrit.libreoffice.org/1006
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2de818e6317a94ed520f338ebc9ed08d5f17765c
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#55138: Do not double-expand bootstrap variables

2012-11-06 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/994

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/994/1

fdo#55138: Do not double-expand bootstrap variables

For some reason that escapes me now, the old code double-expanded URLs in
CONFIGURATION_LAYERS and in extension layer's configmgr.ini SCHEMA/DATA.  That
produced wrong results when the pathnames represented by those URLs contain
any $ characters, as apparently routinely happens on Windows with roaming
profiles.

Change-Id: Iff149e7d8736cbcda579376cdc89e24cf99ccc97
(cherry picked from commit 8246bdb500a6d83ea9b61f58fb74e051432e32d7)
---
M configmgr/source/components.cxx
M configmgr/source/components.hxx
2 files changed, 7 insertions(+), 13 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/994
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff149e7d8736cbcda579376cdc89e24cf99ccc97
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Change in core[libreoffice-3-6]: fdo#53474: Fix Windows Java Accessibility Bridge

2012-10-26 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change.

Change subject: fdo#53474: Fix Windows Java Accessibility Bridge
..


Patch Set 1: Abandoned

has already been integrated into libreoffice-3-6 as 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=44653d129f909a026b91fa4df6e1bd931638d620g=libreoffice-3-6,
 but in a way that made gerrit not aware of it, so abandoning this now

--
To view, visit https://gerrit.libreoffice.org/906
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9b582ba22667b1dae635828e85c4cc5b530353ac
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#49517: Revert fdo#46102: Load Java scripts with class l...

2012-10-26 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/922

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/922/1

fdo#49517: Revert fdo#46102: Load Java scripts with class loaders [...]

This reverts commit dd6c4f4db1d62268d73e09ae52d23f760a967dcc fdo#46102: Load
Java scripts with class loaders that actually find them.  That commit broke
support for macros embedded in documents (as
new java.net.URL(vnd.sun.star.tdoc:...) throws a MalformedURLExcetpion), and
it looks like that commit was not necessary after all -- or rather that what it
tried to work around must have been some other problem that has been fixed
meanwhile.  It is unclear to me how the Java script provider shall ever have
found the script jars in the past indicates that something must have been
fishy, and what I failed to notice back then is that createURL creates
java.net.URL instances with a UCBStreamHandler that does allow to obtain content
from weird-looking URLs.

Anyway, with that reverted, all three following scenarios work on both current
master (towards LO 3.7) and libreoffice-3-6 (towards LO 3.6.4); I haven't yet
come around to test on libreoffice-3-5:

1  Stock macros, Tools - Macros - Run Macro... - LibreOffice Macros -
HelloWorld, running all of the four helloworld.bsh, helloworld.js,
HelloWorldPyhton, and
org.libreoffice.example.java_scripts.HelloWorld.printHW.

2  Per-document macros, loading test.odt attached to fdo#49517, then Tools -
Macros - Run Macro... - test.odt - HelloWorld, running
org.libreoffice.example.java_scripts.HelloWorld.printHW.

3  Extension macros, installing ScriptDispatch.oxt attached to fdo#46012 as
shared extension, then loading StartScriptDispatch.odt attached to fdo#46012 and
pressing the Start Java via ScriptProvider button.

Change-Id: I31cd16b3720ffeb1058722d4d1fdffb773f8a067
(cherry picked from commit 7ea7fb009ddcfb0723e88ba0c5778b5fdbe2b553)
---
M scripting/java/com/sun/star/script/framework/container/ScriptMetaData.java
M scripting/java/com/sun/star/script/framework/provider/ClassLoaderFactory.java
M 
scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptEditorForBeanShell.java
M 
scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptProviderForBeanShell.java
M 
scripting/java/com/sun/star/script/framework/provider/java/ScriptProviderForJava.java
M 
scripting/java/com/sun/star/script/framework/provider/javascript/ScriptProviderForJavaScript.java
6 files changed, 9 insertions(+), 54 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/922
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31cd16b3720ffeb1058722d4d1fdffb773f8a067
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#53474: Fix Windows Java Accessibility Bridge

2012-10-25 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/906

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/906/1

fdo#53474: Fix Windows Java Accessibility Bridge

...by folding the contents of java_accessibility.jar back into
java_uno_accessbridge.jar.

In the old build system there were two jars, java_uno_accessbridge.jar
containing the handful of org.openoffice.accessibility classes and all
org.openoffice.java.accessibility classes (though how the latter got included
was fairly obscure in the makefile.mk) and unused java_accessibility.jar that
contained all org.openoffice.java.accessibility classes.  When adapting this to
gbuild, the unused java_accessibility.jar was carried over, but all its
org.openoffice.accessibility classes were inadvertently droped from
java_uno_accessbridge.jar.

(cherry picked from commit 5ba1694606577f9cda2b773d82ae765118bfc9e1)

Conflicts:
Repository.mk
accessibility/Jar_accessibility.mk
accessibility/Jar_uno_accessbridge.mk

Change-Id: I9b582ba22667b1dae635828e85c4cc5b530353ac
---
D accessibility/Jar_accessibility.mk
M accessibility/Jar_uno_accessbridge.mk
M accessibility/Module_accessibility.mk
3 files changed, 49 insertions(+), 92 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/906
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b582ba22667b1dae635828e85c4cc5b530353ac
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6-3]: fdo#53474: Fix Windows Java Accessibility Bridge

2012-10-25 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/907

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/907/1

fdo#53474: Fix Windows Java Accessibility Bridge

...by folding the contents of java_accessibility.jar back into
java_uno_accessbridge.jar.

In the old build system there were two jars, java_uno_accessbridge.jar
containing the handful of org.openoffice.accessibility classes and all
org.openoffice.java.accessibility classes (though how the latter got included
was fairly obscure in the makefile.mk) and unused java_accessibility.jar that
contained all org.openoffice.java.accessibility classes.  When adapting this to
gbuild, the unused java_accessibility.jar was carried over, but all its
org.openoffice.accessibility classes were inadvertently droped from
java_uno_accessbridge.jar.

(cherry picked from commit 5ba1694606577f9cda2b773d82ae765118bfc9e1)

Conflicts:
Repository.mk
accessibility/Jar_accessibility.mk
accessibility/Jar_uno_accessbridge.mk

Change-Id: I9b582ba22667b1dae635828e85c4cc5b530353ac
---
D accessibility/Jar_accessibility.mk
M accessibility/Jar_uno_accessbridge.mk
M accessibility/Module_accessibility.mk
3 files changed, 49 insertions(+), 92 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/907
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b582ba22667b1dae635828e85c4cc5b530353ac
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-3
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] WaE: 'xChartType$D57056$_pInterface' may be used uninitializ...

2012-10-25 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/911

Approvals:
  Stephan Bergmann: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/911
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a389530d51ae0ddd38418159ca4234016bf93ba
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Gerrit-Reviewer: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Change in core[libreoffice-3-6-3]: fdo#55800: fix hex color conversion

2012-10-23 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/897

Approvals:
  Markus Mohrhard: Looks good to me, but someone else must approve
  Stephan Bergmann: Verified; Looks good to me, approved
  Eike Rathke: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.libreoffice.org/897
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e60837b3cc557e1df3d7e1312ed083f2b267dde
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-3
Gerrit-Owner: Eike Rathke er...@redhat.com
Gerrit-Reviewer: Eike Rathke er...@redhat.com
Gerrit-Reviewer: Ivan Timofeev timofeev@gmail.com
Gerrit-Reviewer: Markus Mohrhard markus.mohrh...@googlemail.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#46071: Do not hide windows based on nil Visible proper...

2012-10-05 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/773

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/773/1

fdo#46071: Do not hide windows based on nil Visible property

This appears to be messy:  The /org.openoffice.Office.Views/WindowType
configuration group template has both a nilable bool Visible property and a
UserData/Data string property that encodes various things like geometry---but
also visibility---in a string.

Now, likely due to the problem that has meanwhile been fixed through
f3f79cc9e6c265baf48955d53f7e888205e0b3e0 Resolves fdo#46074: Fix
Partial::contains for paths that go past a leaf node, some
registrymodification.xcu files in the wild contain such WindowType entries in
default state, without a UserData/Data string and with a nil Visible
property.

The way SfxChildWindow::InitializeChildWinFactory_Impl and
SvtViewOptions::IsVisible are implemented, they will always lead to an invisible
window for such broken registrymodification.xcu data (as IsVisible unhelpfully
returns false for a nil value, and InitializeChildWinFactory_Impl uses that
value when there is no UserData/Data string).

For the Math formula editor window (ID 30378) this means that it can disappear
from the UI completely, as there appears to be no UI trigger for the user to
show it in case it is hidden.

The fix is to introdue SvtViewOptions::HasVisible (which only returns true if
the property is not nil) and change InitializeChidlWinFactory_Impl to only use
the value of IsVisible() if HasVisible() returns true.  This makes the code even
more baroque, but this is a rather central, generic piece of code for all sorts
of windows, so I do not want to break any other uses by e.g. changing IsVisible
to return true for a nil property.

Change-Id: Iae40075a7116a8aabd2d25aa9334709522e23d8f
(cherry picked from commit 9db74c6133ede2a28af077fd563398176ff0d858)
---
M sfx2/source/appl/childwin.cxx
M unotools/inc/unotools/viewoptions.hxx
M unotools/source/config/viewoptions.cxx
3 files changed, 41 insertions(+), 8 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/773
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae40075a7116a8aabd2d25aa9334709522e23d8f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#52022: Simple/LargeControlPoints actually can have nil v...

2012-10-04 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/765

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/765/1

fdo#52022: Simple/LargeControlPoints actually can have nil values

...in old LO 3.5 registrymodifications.xcu, which causes trouble when migrating
to = LO 3.6, see https://bugs.freedesktop.org/show_bug.cgi?id=52022#c23 for
all the details.

Change-Id: I8fa1e67998c9588b9d8bf3a3b52e4b0684d3d705
(cherry picked from commit a51833bf79eed21a7cddd6da45dc9d3dc07b4983)
---
M officecfg/registry/schema/org/openoffice/Office/Calc.xcs
M officecfg/registry/schema/org/openoffice/Office/Writer.xcs
M officecfg/registry/schema/org/openoffice/Office/WriterWeb.xcs
3 files changed, 6 insertions(+), 6 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/765
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fa1e67998c9588b9d8bf3a3b52e4b0684d3d705
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: No dictionaries were preselected for en_US langpack

2012-09-27 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/707

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/707/1

No dictionaries were preselected for en_US langpack

...as gm_Langpack_r_en_US was explicitly excluded from langs[] in
SelectLanguage, so addMatchingDictionaries was never called for it.  (This was
only evident in installation sets conaining only few langpacks, as the
official multi-lang installation set also contains en_GB etc., so appropriate
dictionaries were selected through those.)

Reworked the logic of chosing which langpacks to preselect (see the comment in
SelectLanguage); hope it still works as intended for the various cases (of which
the official multi-lang installation set is the only truly relevant one, for
now).

Change-Id: I31f531194c79e49c9c09e33454a7b0a82d9ff02f
(cherry picked from commit 8cb7464130634551fd2f043efc14f8f8f8bdf447)
---
M setup_native/source/win32/customactions/sellang/sellang.cxx
1 file changed, 71 insertions(+), 91 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/707
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31f531194c79e49c9c09e33454a7b0a82d9ff02f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: Clean up option processing

2012-09-26 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/700

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/700/1

Clean up option processing

* Support --version on non-UNX, too.

* Consistently show the first unknown option and the help blob in the presence
  of any unknown options.

* There is no need to tunnel --help/--version past oosplash in the soffice
  script, as oosplash is prepared to treat them adequately (esp. not pass them
  over any pipe); this only added unnecessary variance to what spellings exactly
  are supported and how mixtures of --help, --version, and unknown options are
  handled.

(cherry picked from commit f4a4ba9ac1b58b4726825400e1edd1bf47d4080a)

Change-Id: I617f2e727e2f0eafd34a2de3b85d441c6783ec4f
---
M desktop/scripts/soffice.sh
M desktop/source/app/app.cxx
M desktop/source/app/cmdlineargs.cxx
M desktop/source/app/cmdlineargs.hxx
M desktop/source/app/cmdlinehelp.cxx
M desktop/source/app/cmdlinehelp.hxx
M desktop/source/app/officeipcthread.cxx
M desktop/source/app/sofficemain.cxx
M desktop/unx/source/args.c
M desktop/unx/source/args.h
M desktop/unx/source/start.c
M vcl/inc/vcl/svapp.hxx
12 files changed, 272 insertions(+), 260 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/700
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I617f2e727e2f0eafd34a2de3b85d441c6783ec4f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Change in core[libreoffice-3-6-2]: fdo#54385: Displaying help/version early on UNX requires ser...

2012-09-25 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/695

Approvals:
  Stephan Bergmann: Verified
  Tor Lillqvist: Looks good to me, approved
  David Tardon: Looks good to me, approved
  Fridrich Strba: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.libreoffice.org/695
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If22ea3ac6474188bf0792246620e5c705a813445
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-2
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: David Tardon dave.tar...@gmail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#55019: Cope with empty TrustedAuthor entries

2012-09-25 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/696

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/696/1

fdo#55019: Cope with empty TrustedAuthor entries

Change-Id: I9c01c1c718897a4be992150170a6ed9b5bd8a0a0
(cherry picked from commit b0c9f3b5f6cc86a94991c5970278f69df15aa7c1)
---
M unotools/source/config/securityoptions.cxx
1 file changed, 11 insertions(+), 2 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/696
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c01c1c718897a4be992150170a6ed9b5bd8a0a0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: rhbz#836827: SQLFeatureNotSupportedException only in Java 6

2012-09-24 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/690

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/690/1

rhbz#836827: SQLFeatureNotSupportedException only in Java 6

...so if the patched hsqldb.jar is compiled with Java 7, it creates instances of
SQLFeatureNotSupportedException, and when at LO runtime a Java 5 gcj is used,
loading the relevant hsqldb.jar classes will fail with a NoClassDefFoundError
caused by a ClassNotFoundException.

Adding java.sql.Driver.getParentLogger in Java 7 was an incompatible change, but
it appears that the java.sql framework is prepared to handle old implementations
(for which the JVM will throw AbstractMethodError), so it appears that it works
to fake that AbstractMethodError here.

Change-Id: Id1fddc9cbdd8c88cd68fb5877ec59fe8d61e1562
(cherry picked from commit 93a0d9eee0f4dced348b040961f44f977e9504a7)
---
M hsqldb/patches/jdbc-4.1.patch
1 file changed, 10 insertions(+), 4 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/690
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1fddc9cbdd8c88cd68fb5877ec59fe8d61e1562
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: fdo#54385: Displaying help/version early on UNX requires ser...

2012-09-24 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/694

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/694/1

fdo#54385: Displaying help/version early on UNX requires service manager

This regression was introduced with 6c6358a6822d3562b9b8c7668a7d60d6c644dfe8
Related fdo#53006: Do not instantiate service manager too early.

Change-Id: If22ea3ac6474188bf0792246620e5c705a813445
(cherry picked from commit 2f14e2e67c58fe6948501d57a38cd0d2ad84dfff)
---
M desktop/inc/app.hxx
M desktop/source/app/app.cxx
M desktop/source/app/appinit.cxx
M desktop/source/app/sofficemain.cxx
4 files changed, 11 insertions(+), 8 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/694
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If22ea3ac6474188bf0792246620e5c705a813445
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6-2]: fdo#54385: Displaying help/version early on UNX requires ser...

2012-09-24 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/695

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/695/1

fdo#54385: Displaying help/version early on UNX requires service manager

This regression was introduced with 6c6358a6822d3562b9b8c7668a7d60d6c644dfe8
Related fdo#53006: Do not instantiate service manager too early.

(cherry picked from commit 2f14e2e67c58fe6948501d57a38cd0d2ad84dfff)
(cherry picked from commit 7b33d564bc0079e5d8309e4b5081b1d44e1efd12)

Conflicts:
desktop/inc/app.hxx
desktop/source/app/app.cxx
desktop/source/app/appinit.cxx
desktop/source/app/sofficemain.cxx
(with ensureProcessServiceManager still available in libreoffice-3-6-2, this
cherry-pick shrinks up dramatically)

Change-Id: If22ea3ac6474188bf0792246620e5c705a813445
---
M desktop/source/app/sofficemain.cxx
1 file changed, 2 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/695
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If22ea3ac6474188bf0792246620e5c705a813445
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-2
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: Properly check cmdline args in oosplash

2012-09-21 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/666

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/666/1

Properly check cmdline args in oosplash

...so that e.g. --headless (starting with a h) is not also mistaken as -h and
disables pagein and javaldx.

Change-Id: I8a7b2b0373d96ec586975e07e17e7eabe201dcd0
(cherry picked from commit b247950eeeb2ea2345633ee018fbe2c55c1942c0)
---
M desktop/unx/source/args.c
1 file changed, 5 insertions(+), 3 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/666
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a7b2b0373d96ec586975e07e17e7eabe201dcd0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: Don't access broken service mgr during bootstrap failure

2012-09-20 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/654

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/654/1

Don't access broken service mgr during bootstrap failure

...so that displaying a (non-translated) error box upon BE_UNO_SERVICEMANAGER
works after all.  Augment the error text with an exception message where
appropriate.  This allows to revert fdfb7a3c4b3a89b73ab5546b9620348bc4984d8f
Related fdo#51252: Report uncaught exceptions with MessageBox on Windows as
that was to catch and display failures from instantiating the service mgr.

(cherry picked from commit 6bcfa095121c91e8bbc396f5bcf7e95424b9)

Change-Id: I049a38e95342634796eb0e940e2ee8e55193c9d3
---
M desktop/inc/app.hxx
M desktop/source/app/app.cxx
M desktop/source/app/desktop.hrc
M desktop/source/app/desktop.src
M desktop/source/app/sofficemain.cxx
M vcl/aqua/source/app/salsys.cxx
M vcl/generic/app/gensys.cxx
M vcl/inc/aqua/salsys.h
M vcl/inc/generic/gensys.h
M vcl/inc/ios/salsys.h
M vcl/inc/salsys.hxx
M vcl/inc/win/salsys.h
M vcl/ios/source/app/salsys.cxx
M vcl/source/app/svapp.cxx
M vcl/source/app/svdata.cxx
M vcl/win/source/app/salinfo.cxx
16 files changed, 172 insertions(+), 142 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/654
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I049a38e95342634796eb0e940e2ee8e55193c9d3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: Add RPATH to liblangtag

2012-09-20 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/661

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/661/1

Add RPATH to liblangtag

...so that it consistenly uses the LO versions of libxml2/glibc libs at runtime.

Change-Id: I89b7fd13a8b5b7e697ec21db74fdf8ef088fdb92
(cherry picked from commit 179a6db61ee30cf776747802f06edeef45fec461)
---
M liblangtag/makefile.mk
1 file changed, 8 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/661
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I89b7fd13a8b5b7e697ec21db74fdf8ef088fdb92
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: Do not call xmlCleanupParser from liblangtag

2012-09-20 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/662

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/662/1

Do not call xmlCleanupParser from liblangtag

Despite its name, it is a cleanup function for libxml2 that must only be called
when the process as a whole no longer needs libxml2.  Calling it from a library
like liblangtag is not appropriate (just like liblangtag does not call
xmlInitParser, either).

In LibreOffice, this caused confusion about pthread keys for thread-local
storage (xmlCleanupParser calls pthread_key_delete, but apparently if libxml2 is
later used by unrelated code in LibreOffice again, it still uses the stale key,
and if that key is now reused via an unrelated pthread_key_create, arbitrary
crashes happen during thread termination in pthread's __nptl_deallocate_tsd).

(cherry picked from commit 5e6c595e9d698caf23ae68d38b9cab30ff9c9b94)

Conflicts:
liblangtag/makefile.mk

Change-Id: I82cef8bc400d48f19eaa94f26d50d4b8589da106
---
A liblangtag/liblangtag-0.2-xmlCleanupParser.patch
M liblangtag/makefile.mk
2 files changed, 21 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/662
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82cef8bc400d48f19eaa94f26d50d4b8589da106
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Change in core[libreoffice-3-6]: Make rtl::O[U]String::isEmpty return true bool

2012-09-19 Thread Stephan Bergmann (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/650

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/650/1

Make rtl::O[U]String::isEmpty return true bool

...instead of sal_Bool, to work around MSVC warning C4805: unsafe mix of type
'sal_Bool' and type 'bool'.

Change-Id: Ia3477539ccc23aa9daec49d633f023d414f2b4bf
(cherry picked from commit 8ee7c47404cdf408bcd3b6ea0267fbe54193c93f)
---
M sal/inc/rtl/string.hxx
M sal/inc/rtl/ustring.hxx
2 files changed, 4 insertions(+), 10 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/650
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3477539ccc23aa9daec49d633f023d414f2b4bf
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] fdo#54858: fix UNO service conversion

2012-09-17 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/628


--
To view, visit https://gerrit.libreoffice.org/628
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3fbba4da0d293659d8521c768d34de18cd6bc634
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ivan Timofeev timofeev@gmail.com
Gerrit-Reviewer: Ivan Timofeev timofeev@gmail.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] add osl_atomic_* api to allow for inlined atomic increment/d...

2012-09-17 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/631


--
To view, visit https://gerrit.libreoffice.org/631
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4dcbf94ea6f62eb6d55d30613fe65878ffb8023
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] fix bug fdo#53520, pt-PT and pt-BR better split

2012-09-11 Thread Stephan Bergmann (via Code Review)
Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/592


--
To view, visit https://gerrit.libreoffice.org/592
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff10cfee1da2c4775e4cf9050ec154052ee18ac9
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot olivier.hal...@alta.org.br
Gerrit-Reviewer: Olivier Hallot olivier.hal...@alta.org.br
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


<    1   2