[PATCH] fdo#40100 corect result for calc function YEARFRAC

2013-04-13 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3375

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/3375/1

fdo#40100 corect result for calc function YEARFRAC

Change-Id: Ief5e5c89b7fb69fb9849cf2d6efe2b4c5b7f5391
---
M scaddins/source/analysis/analysishelper.cxx
1 file changed, 18 insertions(+), 13 deletions(-)



diff --git a/scaddins/source/analysis/analysishelper.cxx 
b/scaddins/source/analysis/analysishelper.cxx
index 278b26f..100b86f 100644
--- a/scaddins/source/analysis/analysishelper.cxx
+++ b/scaddins/source/analysis/analysishelper.cxx
@@ -366,21 +366,15 @@
 nDay2, nMonth2, nYear2, nMode == 0 ) - 
nYears * nDaysInYear;
 break;
 case 1: // 1=exact/exact
-nYears = nYear2 - nYear1;
+//fdo40100 because of possible leap years calculate number
+//of days separately for year1 and year2 and let nYears
+//contain only number of full calendar years
+nYears = nYear2 - nYear1 - 1;
 
 nDaysInYear = IsLeapYear( nYear1 )? 366 : 365;
 
-if( nYears  ( nMonth1  nMonth2 || ( nMonth1 == nMonth2  nDay1 
 nDay2 ) ) )
-nYears--;
-
-if( nYears )
-nDayDiff = nDate2 - DateToDays( nDay1, nMonth1, nYear2 );
-else
-nDayDiff = nDate2 - nDate1;
-
-if( nDayDiff  0 )
-nDayDiff += nDaysInYear;
-
+nDayDiff = ( nDate2 - DateToDays( 1, 1, nYear2 ) ) +
+( DateToDays( 31, 12, nYear1 ) - nDate1 ) + 1; //plus 1 for 
Dec 31 to Jan 1
 break;
 case 2: // 2=exact/360
 nDaysInYear = 360;
@@ -508,6 +502,18 @@
 }
 
 
+//TODO: In the case of nMode == 1 (exact), there still remains a small error
+//  in the result because of leap years. nDaysInYear is an integer and
+//  returns the days in the year of nStartDate. If nEndDate is not a
+//  leap year, the year fraction of the days in the year of nEndDate is
+//  a little bit too small. If nStardate is not in a leap year, but
+//  nEndDate is, then year fraction of the days in the year of nEndDate
+//  is a little bit too large.
+//  This could be corrected when nDaysInYear is a float and the value
+//  reflects the number of days in the leap year and the non-leap year.
+//  Example: If there are 80 days in the leap year and 80 days in the
+//  non-leap year, then nDaysInYear would be 365.5, resulting in a more
+//  or less exact year fraction.
 double GetYearFrac( sal_Int32 nNullDate, sal_Int32 nStartDate, sal_Int32 
nEndDate, sal_Int32 nMode ) throw( uno::RuntimeException, 
lang::IllegalArgumentException )
 {
 if( nStartDate == nEndDate )
@@ -517,7 +523,6 @@
 sal_Int32   nDayDiff, nDaysInYear;
 
 GetDiffParam( nNullDate, nStartDate, nEndDate, nMode, nYears, nDayDiff, 
nDaysInYear );
-
 return double( nYears ) + double( nDayDiff ) / double( nDaysInYear );
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/3375
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief5e5c89b7fb69fb9849cf2d6efe2b4c5b7f5391
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] some refinements on label configurations in writer

2013-02-28 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2473

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/2473/1

some refinements on label configurations in writer

Change-Id: I94ad02972b0fae1327f72a41373f34962452b8ef
---
M extras/source/labels/labels.xml
M sw/source/ui/envelp/labelcfg.cxx
M sw/source/ui/envelp/labfmt.cxx
M sw/source/ui/envelp/labfmt.hrc
M sw/source/ui/envelp/labfmt.src
M sw/source/ui/inc/labelcfg.hxx
6 files changed, 155 insertions(+), 164 deletions(-)



diff --git a/extras/source/labels/labels.xml b/extras/source/labels/labels.xml
index a9f81ba..8ed02b9 100644
--- a/extras/source/labels/labels.xml
+++ b/extras/source/labels/labels.xml
@@ -651,7 +651,7 @@
 measureS;4064;2117;3810;2117;467;1090;5;13;21000;29700/measure
 /label
 label id=L125
-nameJ8654 Miini Address/name
+nameJ8654 Mini Address/name
 measureS;4826;2540;4572;2540;975;2143;4;10;21000;29700/measure
 /label
 label id=L126
@@ -1199,7 +1199,7 @@
 measureS;4064;2117;3810;2117;467;1090;5;13;21000;29700/measure
 /label
 label id=L262
-nameL7652 Miini Address/name
+nameL7652 Mini Address/name
 measureS;4826;1693;4572;1693;975;1299;4;16;21000;29700/measure
 /label
 label id=L263
@@ -1207,7 +1207,7 @@
 measureS;4572;1693;2200;1270;2542;4902;4;12;21000;29700/measure
 /label
 label id=L264
-nameL7654 Miini Address/name
+nameL7654 Mini Address/name
 measureS;4826;2540;4572;2540;975;2143;4;10;21000;29700/measure
 /label
 label id=L265
diff --git a/sw/source/ui/envelp/labelcfg.cxx b/sw/source/ui/envelp/labelcfg.cxx
index 28d4074..785eff6 100644
--- a/sw/source/ui/envelp/labelcfg.cxx
+++ b/sw/source/ui/envelp/labelcfg.cxx
@@ -59,6 +59,18 @@
 return sTmp;
 }
 
+static SequenceOUString lcl_CreatePropertyNames(const OUString rPrefix)
+{
+SequenceOUString aProperties(2);
+OUString* pProperties = aProperties.getArray();
+for(sal_Int32 nProp = 0; nProp  2; nProp++)
+pProperties[nProp] = rPrefix;
+
+pProperties[ 0] += Name;
+pProperties[ 1] += Measure;
+return aProperties;
+}
+
 SwLabelConfig::SwLabelConfig() :
 ConfigItem(Office.Labels/Manufacturer)
 {
@@ -72,6 +84,7 @@
 OUString sName;
 OUString sMeasure;
 
+// fill m_aLabels and m_aManufacturers with the predefined labels
 res = reader.nextItem(
 xmlreader::XmlReader::TEXT_NONE, name, nsId);
 assert(res == xmlreader::XmlReader::RESULT_BEGIN 
@@ -105,7 +118,10 @@
 xmlreader::Span(RTL_CONSTASCII_STRINGPARAM(measure)));
 // Ending label mark
 lcl_assertEndingItem(reader);
-m_aLabels[sManufacturer][sName] = sMeasure;
+if ( m_aLabels.find( sManufacturer ) == m_aLabels.end() )
+m_aManufacturers.push_back( sManufacturer );
+m_aLabels[sManufacturer][sName].m_aMeasure = sMeasure;
+m_aLabels[sManufacturer][sName].m_bPredefined = true;
 }
 // Get next manufacturer or end
 res = reader.nextItem(
@@ -115,7 +131,35 @@
 xmlreader::XmlReader::TEXT_NONE, name, nsId);
 assert(res == xmlreader::XmlReader::RESULT_DONE);
 
-FillManufacturers();
+// add to m_aLabels and m_aManufacturers the custom labels
+const Sequencertl::OUString rMan = GetNodeNames( OUString() );
+const rtl::OUString* pMan = rMan.getConstArray();
+for ( sal_Int32 nMan = 0; nMan  rMan.getLength(); nMan++ )
+{
+sManufacturer = pMan[nMan];
+const SequenceOUString aLabels = GetNodeNames( sManufacturer );
+const OUString* pLabels = aLabels.getConstArray();
+for( sal_Int32 nLabel = 0; nLabel  aLabels.getLength(); nLabel++ )
+{
+OUString sPrefix( sManufacturer );
+sPrefix += /;
+sPrefix += pLabels[nLabel];
+sPrefix += /;
+SequenceOUString aPropNames = lcl_CreatePropertyNames( sPrefix );
+SequenceAny   aValues = GetProperties( aPropNames );
+const Any* pValues = aValues.getConstArray();
+if (aValues.getLength() = 1)
+if(pValues[0].hasValue())
+pValues[0] = sName;
+if (aValues.getLength() = 2)
+if(pValues[1].hasValue())
+pValues[1] = sMeasure;
+if ( m_aLabels.find( sManufacturer ) == m_aLabels.end() )
+m_aManufacturers.push_back( sManufacturer );
+m_aLabels[sManufacturer][sName].m_aMeasure = sMeasure;
+m_aLabels[sManufacturer][sName].m_bPredefined = false;
+}
+}
 }
 
 SwLabelConfig::~SwLabelConfig()
@@ -127,32 +171,6 @@
 
 void SwLabelConfig::Notify( const ::com::sun::star::uno::Sequence 
rtl::OUString  ) {}
 
-void SwLabelConfig::FillManufacturers()
-{
-m_aManufacturers.clear();
-for (std::map OUString,

[PATCH] translate German comments, remove obsolete code

2013-02-09 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2049

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/2049/1

translate German comments, remove obsolete code

Change-Id: I4d6e3149f94234e2b884ab81e752805d07a63712
---
M sw/source/core/view/viewimp.cxx
1 file changed, 115 insertions(+), 97 deletions(-)



diff --git a/sw/source/core/view/viewimp.cxx b/sw/source/core/view/viewimp.cxx
index 6b114a2..8ae0086 100644
--- a/sw/source/core/view/viewimp.cxx
+++ b/sw/source/core/view/viewimp.cxx
@@ -43,18 +43,20 @@
 #include IDocumentDeviceAccess.hxx
 #include IDocumentSettingAccess.hxx
 
-/*
-|*
-|*  SwViewImp::Init()
-|*
-|*  Ersterstellung  MA 25. Jul. 94
-|*  Letzte AenderungMA 03. Nov. 95
-|*
-|*/
+/**
+
+  SwViewImp::Init()
+
+  Created  MA 25. Jul. 94
+  Last change  MA 03. Nov. 95
+
+  @author MA
+
+*/
 void SwViewImp::Init( const SwViewOption *pNewOpt )
 {
 OSL_ENSURE( pDrawView, SwViewImp::Init without DrawView );
-//Jetzt die PageView erzeugen wenn sie noch nicht existiert.
+//Create PageView if it doesn't exist
 SwRootFrm *pRoot = pSh-GetLayout();//swmod 071108//swmod 071225
 if ( !pSdrPageView )
 {
@@ -95,14 +97,16 @@
 pDrawView-SetMarkHdlSizePixel(9);
 }
 
-/*
-|*
-|*  SwViewImp::SwViewImp()  CTor fuer die Core-Internas
-|*
-|*  Ersterstellung  MA 25. Jul. 94
-|*  Letzte AenderungMA 06. Sep. 96
-|*
-|*/
+/**
+
+  SwViewImp::SwViewImp()  CTor for the core internals
+
+  Created  MA 25. Jul. 94
+  Last change  MA 06. Sep. 96
+
+  @author MA
+
+*/
 
 SwViewImp::SwViewImp( ViewShell *pParent ) :
 pSh( pParent ),
@@ -118,21 +122,21 @@
 // OD 12.12.2002 #103492#
 mpPgPrevwLayout( 0 )
 {
-//bResetXorVisibility =
-//HMHbShowHdlPaint =
 bResetHdlHiddenPaint =
 bSmoothUpdate = bStopSmooth = bStopPrt = sal_False;
 bFirstPageInvalid = sal_True;
 }
 
-/**
-|*
-|*  SwViewImp::~SwViewImp()
-|*
-|*  Ersterstellung  MA 25. Jul. 94
-|*  Letzte AenderungMA 16. Dec. 94
-|*
-**/
+/**
+
+  SwViewImp::~SwViewImp()
+
+  Created  MA 25. Jul. 94
+  Last change  MA 16. Dec. 94
+
+  @author MA
+
+*/
 
 SwViewImp::~SwViewImp()
 {
@@ -141,7 +145,7 @@
 // OD 12.12.2002 #103492#
 delete mpPgPrevwLayout;
 
-//JP 29.03.96: nach ShowSdrPage muss auch HideSdrPage gemacht werden!!!
+//JP 29.03.96: after ShowSdrPage  HideSdrPage must also be executed!!!
 if( pDrawView )
  pDrawView-HideSdrPage();
 
@@ -153,28 +157,32 @@
 OSL_ENSURE( !pIdleAct,Be idle for the rest of your life. );
 }
 
-/**
-|*
-|*  SwViewImp::DelRegions()
-|*
-|*  Ersterstellung  MA 14. Apr. 94
-|*  Letzte AenderungMA 14. Apr. 94
-|*
-**/
+/**
+
+  SwViewImp::DelRegions()
+
+  Created  MA 14. Apr. 94
+  Last change  MA 14. Apr. 94
+
+  @author MA
+
+*/
 
 void SwViewImp::DelRegion()
 {
 DELETEZ(pRegion);
 }
 
-/**
-|*
-|*  SwViewImp::AddPaintRect()
-|*
-|*  Ersterstellung  MA ??
-|*  Letzte AenderungMA 27. Jul. 94
-|*
-**/
+/**
+
+  SwViewImp::AddPaintRect()
+
+  Created  MA ??
+  Last change  MA 27. Jul. 94
+
+  @author MA
+
+*/
 
 sal_Bool SwViewImp::AddPaintRect( const SwRect rRect )
 {
@@ -188,14 +196,16 @@
 return sal_False;
 }
 
-/**
-|*
-|*  ViewImp::CheckWaitCrsr()
-|*
-|*  Ersterstellung  MA 10. Aug. 94
-|*  Letzte AenderungMA 10. Aug. 94
-|*
-**/
+/**
+
+  ViewImp::CheckWaitCrsr()
+
+  Created  MA 10. Aug. 94
+  Last change  MA 10. Aug. 94
+
+  @author MA
+
+*/
 
 void SwViewImp::CheckWaitCrsr()
 {
@@ -203,14 +213,16 @@
 pLayAct-CheckWaitCrsr();
 }
 
-/**
-|*
-|*  ViewImp::IsCalcLayoutProgress()
-|*
-|*  Ersterstellung  MA 12. Aug. 94
-|*  Letzte AenderungMA 12. Aug. 94
-|*
-**/
+/**
+
+  ViewImp::IsCalcLayoutProgress()
+
+  Created  MA 12. Aug. 94
+  Last change  MA 12. Aug. 94
+
+  @author MA
+
+*/
 
 sal_Bool SwViewImp::IsCalcLayoutProgress() const
 {
@@ -219,14

[PATCH] translate German comments, remove obsolete code

2013-02-09 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2054

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/2054/1

translate German comments, remove obsolete code

Change-Id: Icfb1e2985f746d7a451037e2d411ebbfeed26a54
---
M sw/source/core/view/viewsh.cxx
1 file changed, 96 insertions(+), 118 deletions(-)



diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 8d8d333..bec7c75 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -199,7 +199,7 @@
 }
 
 bInEndAction = sal_True;
-//Laeuft hiermit das EndAction der Letzten Shell im Ring?
+//will this put the EndAction of the last shell in the sequence?
 
 ViewShell::bLstAct = sal_True;
 ViewShell *pSh = (ViewShell*)this-GetNext();
@@ -238,9 +238,8 @@
 if ( bIsShellForCheckViewLayout )
 GetLayout()-CheckViewLayout( GetViewOptions(), aVisArea );
 
-//Wenn wir selbst keine Paints erzeugen, so warten wir auf das Paint
-//vom System. Dann ist das Clipping korrekt gesetzt; Beispiel: verschieben
-//eines DrawObjektes.
+//If we don't call Paints, we wait for the Paint of the system.
+//Then the clipping is set correctly; e.g. shifting of a Draw object
 if ( Imp()-GetRegion() ||
  aInvalidRect.HasArea() ||
  bExtraData )
@@ -263,12 +262,11 @@
 
 SwRegionRects *pRegion = Imp()-GetRegion();
 
-//JP 27.11.97: wer die Selection hided, muss sie aber auch
-//  wieder Showen. Sonst gibt es Paintfehler!
-//  z.B.: addional Mode, Seite vertikal hab zu sehen, in der
-// Mitte eine Selektion und mit einem anderen Cursor an linken
-// rechten Rand springen. Ohne ShowCrsr verschwindet die
-// Selektion
+//JP 27.11.97: what hid the selection, must also Show it,
+// else we get Paint errors!
+// e.g. additional mode, page half visible vertically, in the
+// middle a selection and with an other cursor jump to left
+// right border. Without ShowCrsr the selection disappears.
 bool bShowCrsr = pRegion  IsA( TYPE(SwCrsrShell) );
 if( bShowCrsr )
 ((SwCrsrShell*)this)-HideCrsrs();
@@ -279,7 +277,7 @@
 
 Imp()-pRegion = NULL;
 
-//Erst Invert dann Compress, niemals andersherum!
+//First Invert then Compress, never the other way round!
 pRegion-Invert();
 
 pRegion-Compress();
@@ -293,7 +291,7 @@
 bool bPaint = true;
 if ( IsEndActionByVirDev() )
 {
-//virtuelles device erzeugen und einstellen.
+//create virtual device and set.
 if ( !pVout )
 pVout = new VirtualDevice( *GetOut() );
 MapMode aMapMode( GetOut()-GetMapMode() );
@@ -423,10 +421,10 @@
 Imp()-EndAction();
 
 
-//Damit sich die automatischen Scrollbars auch richtig anordnen k?nnen
-//muessen wir die Aktion hier kuenstlich beenden (EndAction loesst ein
-//Notify aus, und das muss Start-/EndAction rufen um die  Scrollbars
-//klarzubekommen.
+//We artificially end the action here to enable the automatic scrollbars
+//to adjust themselves correctly
+//EndAction sends a Notify, and that must call Start-/EndAction to
+//adjust the scrollbars correctly
 --nStartAction;
 UISizeNotify();
 ++nStartAction;
@@ -446,7 +444,7 @@
 void ViewShell::ImplLockPaint()
 {
 if ( GetWin()  GetWin()-IsVisible() )
-GetWin()-EnablePaint( sal_False ); //Auch die Controls abklemmen.
+GetWin()-EnablePaint( sal_False ); //Also cut off the controls.
 Imp()-LockPaint();
 }
 
@@ -458,7 +456,7 @@
 {
 if ( (bInSizeNotify || bVirDev )  VisArea().HasArea() )
 {
-//Refresh mit virtuellem Device um das Flackern zu verhindern.
+//Refresh with virtual device to avoid flickering.
 VirtualDevice *pVout = new VirtualDevice( *pOut );
 pVout-SetMapMode( pOut-GetMapMode() );
 Size aSize( VisArea().SSize() );
@@ -568,7 +566,7 @@
 #if OSL_DEBUG_LEVEL  0
 else
 {
-//MA: 04. Nov. 94, braucht doch keiner oder??
+//MA: 04. Nov. 94, no one needs this, does one?
 OSL_ENSURE( !this, MakeVisible fuer Drucker wird doch 
gebraucht? );
 }
 
@@ -601,8 +599,8 @@
 
 sal_uInt16 ViewShell::GetNumPages()
 {
-//Es kann sein, das noch kein Layout existiert weil die Methode vom
-//Root-Ctor gerufen wird.
+//It is possible that no layout exists when the method from
+//root-Ctor is called.
 return GetLayout() ? GetLayout()-GetPageNum() : 0;
 }
 
@@ -666,14 +664,14 @@
 void

[PATCH] fdo#60322 add calc function SKEWP as in ODFF v1.2

2013-02-07 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2020

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/2020/1

fdo#60322 add calc function SKEWP as in ODFF v1.2

Change-Id: I4851df1473fc7788af1ac642bb0fb527ec872821
---
M formula/inc/formula/compiler.hrc
M formula/inc/formula/opcode.hxx
M formula/source/core/resource/core_resource.src
M sc/inc/helpids.h
M sc/qa/unit/ucalc.cxx
M sc/source/core/inc/interpre.hxx
M sc/source/core/tool/interpr3.cxx
M sc/source/core/tool/interpr4.cxx
M sc/source/core/tool/parclass.cxx
M sc/source/filter/excel/xlformula.cxx
M sc/source/filter/oox/formulabase.cxx
M sc/source/ui/src/scfuncs.src
12 files changed, 75 insertions(+), 4 deletions(-)



diff --git a/formula/inc/formula/compiler.hrc b/formula/inc/formula/compiler.hrc
index 7f976ae..da27a19 100644
--- a/formula/inc/formula/compiler.hrc
+++ b/formula/inc/formula/compiler.hrc
@@ -398,8 +398,9 @@
 #define SC_OPCODE_SUM_IFS   403
 #define SC_OPCODE_AVERAGE_IFS   404
 #define SC_OPCODE_COUNT_IFS 405
-#define SC_OPCODE_STOP_2_PAR406
-#define SC_OPCODE_LAST_OPCODE_ID405 /* last OpCode */
+#define SC_OPCODE_SKEWP 406
+#define SC_OPCODE_STOP_2_PAR407
+#define SC_OPCODE_LAST_OPCODE_ID406 /* last OpCode */
 
 /*** Internal ***/
 #define SC_OPCODE_INTERNAL_BEGIN   
diff --git a/formula/inc/formula/opcode.hxx b/formula/inc/formula/opcode.hxx
index 007bcd92..b94c066 100644
--- a/formula/inc/formula/opcode.hxx
+++ b/formula/inc/formula/opcode.hxx
@@ -328,6 +328,7 @@
 ocStandard  = SC_OPCODE_STANDARD,
 ocAveDev= SC_OPCODE_AVE_DEV,
 ocSchiefe   = SC_OPCODE_SCHIEFE,
+ocSkewp = SC_OPCODE_SKEWP,
 ocDevSq = SC_OPCODE_DEV_SQ,
 ocMedian= SC_OPCODE_MEDIAN,
 ocModalValue= SC_OPCODE_MODAL_VALUE,
diff --git a/formula/source/core/resource/core_resource.src 
b/formula/source/core/resource/core_resource.src
index f02f806..de8e8d4 100644
--- a/formula/source/core/resource/core_resource.src
+++ b/formula/source/core/resource/core_resource.src
@@ -284,6 +284,7 @@
 String SC_OPCODE_STANDARD { Text = STANDARDIZE ; };
 String SC_OPCODE_AVE_DEV { Text = AVEDEV ; };
 String SC_OPCODE_SCHIEFE { Text = SKEW ; };
+String SC_OPCODE_SKEWP   { Text = SKEWP ; };
 String SC_OPCODE_DEV_SQ { Text = DEVSQ ; };
 String SC_OPCODE_MEDIAN { Text = MEDIAN ; };
 String SC_OPCODE_MODAL_VALUE { Text = MODE ; };
@@ -624,6 +625,7 @@
 String SC_OPCODE_STANDARD { Text = STANDARDIZE ; };
 String SC_OPCODE_AVE_DEV { Text = AVEDEV ; };
 String SC_OPCODE_SCHIEFE { Text = SKEW ; };
+String SC_OPCODE_SKEWP   { Text = SKEWP ; };
 String SC_OPCODE_DEV_SQ { Text = DEVSQ ; };
 String SC_OPCODE_MEDIAN { Text = MEDIAN ; };
 String SC_OPCODE_MODAL_VALUE { Text = MODE ; };
@@ -1675,6 +1677,10 @@
 {
 Text [ en-US ] = SKEW ;
 };
+String SC_OPCODE_SKEWP
+{
+Text [ en-US ] = SKEWP ;
+};
 String SC_OPCODE_DEV_SQ
 {
 Text [ en-US ] = DEVSQ ;
diff --git a/sc/inc/helpids.h b/sc/inc/helpids.h
index e273ce4..d556337 100644
--- a/sc/inc/helpids.h
+++ b/sc/inc/helpids.h
@@ -530,6 +530,7 @@
 #define HID_FUNC_SUMQUADABW 
SC_HID_FUNC_SUMQUADABW
 #define HID_FUNC_MITTELABW  
SC_HID_FUNC_MITTELABW
 #define HID_FUNC_SCHIEFE
SC_HID_FUNC_SCHIEFE
+#define HID_FUNC_SKEWP  
SC_HID_FUNC_SKEWP
 #define HID_FUNC_KURT   
SC_HID_FUNC_KURT
 #define HID_FUNC_GEOMITTEL  
SC_HID_FUNC_GEOMITTEL
 #define HID_FUNC_HARMITTEL  
SC_HID_FUNC_HARMITTEL
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index ed67ad1..58fde7a 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -4560,6 +4560,7 @@
 RANK,
 RSQ,
 SKEW,
+SKEWP,
 SLOPE,
 SMALL,
 STANDARDIZE,
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index cd44780..64d48be 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -762,6 +762,7 @@
 void ScGeoMean();
 void ScStandard();
 void ScSkew();
+void ScSkewp();
 void ScMedian();
 double GetMedian( ::std::vectordouble  rArray );
 double GetPercentile( ::std::vectordouble  rArray, double fPercentile );
diff --git a/sc/source/core/tool/interpr3.cxx b/sc/source/core/tool/interpr3.cxx
index 1b0e85a..df78713 100644
--- a/sc/source/core/tool/interpr3.cxx
+++ b/sc/source/core/tool/interpr3.cxx
@@ -3038,6 +3038,39 @@
 PushDouble(((xcube * fCount) / (fCount - 1.0)) / (fCount - 2.0));
 }
 
+//fdo#60322
+void ScInterpreter::ScSkewp()
+{
+RTL_LOGFILE_CONTEXT_AUTHOR( aLogger,

Change in core[master]: fdo#56098 paste special shift options incorrect/incomplete

2013-01-28 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1903

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/1903/1

fdo#56098 paste special shift options incorrect/incomplete

Change-Id: Ic84ec07f4e0963ad1759036f1d7cbfa295289375
---
M sc/source/ui/view/cellsh1.cxx
1 file changed, 62 insertions(+), 20 deletions(-)



diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index c22d91d..1d92f46 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -1259,29 +1259,71 @@
 pDlg-SetOtherDoc( bOtherDoc );
 // if ChangeTrack MoveMode disable
 pDlg-SetChangeTrack( pDoc-GetChangeTrack() != 
NULL );
-// cut/move references may disable shift
-// directions if source and destination ranges 
intersect
-if ( !bOtherDoc )
+// fdo#56098  disable shift if source and 
destination ranges intersect
+if ( !bOtherDoc   pOwnClip )
 {
-if ( pOwnClip  
pOwnClip-GetDocument()-IsCutMode() )
+ScViewData* pData = GetViewData();
+if ( pData-GetMarkData().GetTableSelect( 
pData-GetTabNo() ) )
 {
-ScViewData* pData = GetViewData();
-if ( pData-GetMarkData().GetTableSelect(
-pData-GetTabNo() ) )
+SCCOL nStartX, nEndX, nClipStartX, 
nClipSizeX, nRangeSizeX;
+SCROW nStartY, nEndY, nClipStartY, 
nClipSizeY, nRangeSizeY;
+SCTAB nStartTab, nEndTab;
+pOwnClip-GetDocument()-GetClipStart( 
nClipStartX, nClipStartY );
+pOwnClip-GetDocument()-GetClipArea( 
nClipSizeX, nClipSizeY, sal_True );
+
+if ( !( pData-GetSimpleArea( nStartX, 
nStartY, nStartTab, nEndX, nEndY, nEndTab ) == SC_MARK_SIMPLE  nStartTab == 
nEndTab ) )
 {
-SCCOL nPosX = pData-GetCurX();
-SCROW nPosY = pData-GetCurY();
-SCCOL nClipSizeX;
-SCROW  nClipSizeY;
-// for CutMode, filtered rows can 
always be included
-pOwnClip-GetDocument()-GetClipArea( 
nClipSizeX, nClipSizeY, sal_True );
-int nDisableShift = 0;
-if ( nPosX + 2 * nClipSizeX + 1  
MAXCOL )  // fdo#56098
- nDisableShift |= 
SC_CELL_SHIFT_DISABLE_RIGHT;
-if ( nPosY + 2 * nClipSizeY + 1  
MAXROW )  // fdo#56098
-nDisableShift |= 
SC_CELL_SHIFT_DISABLE_DOWN;
-if ( nDisableShift )
-pDlg-SetCellShiftDisabled( 
nDisableShift );
+// the destination is not a simple 
range, so assume the destination as the current cell
+nStartX = nEndX = pData-GetCurX();
+nStartY = nEndY = pData-GetCurY();
+}
+// we now have clip- and range dimensions
+// the size of the destination area is the 
larger of the two
+nRangeSizeX = nClipSizeX = nEndX - 
nStartX ? nClipSizeX : nEndX - nStartX;
+nRangeSizeY = nClipSizeY = nEndY - 
nStartY ? nClipSizeY : nEndY - nStartY;
+if ( nStartX + nRangeSizeX = nClipStartX 

+ nStartX = nClipStartX + nRangeSizeX 

+ nStartY + nRangeSizeY = nClipStartY 

+ nStartY = nClipStartY + nRangeSizeY )
+pDlg-SetCellShiftDisabled( 
SC_CELL_SHIFT_DISABLE_DOWN | SC_CELL_SHIFT_DISABLE_RIGHT );
+else
+{
+//no conflict with intersecting ranges,
+//check if paste plus shift will fit 
on sheet
+//and disable shift-option if so
+int nDisableShiftX =

[PATCH] fdo#40465 solve regression when zooming with cursor not visi...

2013-01-15 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1694

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/1694/1

fdo#40465 solve regression when zooming with cursor not visible

Change-Id: If8dfff1a27218c7821823fcad04bab9f924fec70
---
M dictionaries
M sw/source/ui/uiview/viewmdi.cxx
2 files changed, 5 insertions(+), 2 deletions(-)



diff --git a/dictionaries b/dictionaries
index 0f7aa36..9cfd428 16
--- a/dictionaries
+++ b/dictionaries
-Subproject commit 0f7aa36b2804a7934b4089e50f4225264c46c806
+Subproject commit 9cfd4282a7a522bed2dc4f4b9ede2c8ee444c29b
diff --git a/sw/source/ui/uiview/viewmdi.cxx b/sw/source/ui/uiview/viewmdi.cxx
index 17a1ac5..a60c6f5 100644
--- a/sw/source/ui/uiview/viewmdi.cxx
+++ b/sw/source/ui/uiview/viewmdi.cxx
@@ -64,10 +64,13 @@
 
 void SwView::SetZoom( SvxZoomType eZoomType, short nFactor, sal_Bool bViewOnly 
)
 {
+bool bCrsrIsVisible = ( pWrtShell-IsCrsrVisible() == sal_True );
+
 _SetZoom( GetEditWin().GetOutputSizePixel(), eZoomType, nFactor, bViewOnly 
);
 
-//fdo40465 force the cursor to stay in view whilst zooming
-pWrtShell-ShowCrsr();
+//fdo#40465 force the cursor to stay in view whilst zooming
+if ( bCrsrIsVisible )
+pWrtShell-ShowCrsr();
 }
 
 void SwView::_SetZoom( const Size rEditSize, SvxZoomType eZoomType,

-- 
To view, visit https://gerrit.libreoffice.org/1694
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8dfff1a27218c7821823fcad04bab9f924fec70
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#56098 Paste Special options after cut incorrect

2013-01-14 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1671

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/1671/1

fdo#56098 Paste Special options after cut incorrect

Change-Id: Icf6aa698e69a2271cf68f420ceaec4aaffe94ad0
---
M sc/source/ui/view/cellsh1.cxx
1 file changed, 5 insertions(+), 8 deletions(-)



diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index 6d434ce..82f969c 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -1271,18 +1271,15 @@
 {
 SCCOL nPosX = pData-GetCurX();
 SCROW nPosY = pData-GetCurY();
-SCCOL nClipStartX, nClipSizeX;
-SCROW  nClipStartY, nClipSizeY;
-pOwnClip-GetDocument()-GetClipStart( 
nClipStartX, nClipStartY );
+SCCOL nClipSizeX;
+SCROW  nClipSizeY;
 // for CutMode, filtered rows can 
always be included
 pOwnClip-GetDocument()-GetClipArea( 
nClipSizeX, nClipSizeY, sal_True );
 int nDisableShift = 0;
-if ( nClipStartX = nPosX + nClipSizeX 

-nPosX = nClipStartX + 
nClipSizeX )
+if ( nPosX + 2 * nClipSizeX + 1  
MAXCOL )  // fdo#56098
+ nDisableShift |= 
SC_CELL_SHIFT_DISABLE_RIGHT;
+if ( nPosY + 2 * nClipSizeY + 1  
MAXROW )  // fdo#56098
 nDisableShift |= 
SC_CELL_SHIFT_DISABLE_DOWN;
-if ( nClipStartY = nPosY + nClipSizeY 

-nPosY = nClipStartY + 
nClipSizeY )
-nDisableShift |= 
SC_CELL_SHIFT_DISABLE_RIGHT;
 if ( nDisableShift )
 pDlg-SetCellShiftDisabled( 
nDisableShift );
 }

-- 
To view, visit https://gerrit.libreoffice.org/1671
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf6aa698e69a2271cf68f420ceaec4aaffe94ad0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

fdo#56098 Paste Special options after cut incorrect

2013-01-14 Thread Winfried Donkers (via Code Review) 
Winfried Donkers has abandoned this change.

Change subject: fdo#56098 Paste Special options after cut incorrect
..


Patch Set 1: Abandoned

Patch has been submitted again under gerrit #1671, this time without submodule 
noise.

-- 
To view, visit https://gerrit.libreoffice.org/1475
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib196cf88905de8f8e7488c14964dfd7a56236356
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

fdo#40465 fix to maintain focus whilst zooming

2013-01-04 Thread Winfried Donkers (via Code Review) 
Winfried Donkers has abandoned this change.

Change subject: fdo#40465 fix to maintain focus whilst zooming
..


Patch Set 1: Abandoned

I finally managed to upload a Patch Set 2 to gerrit 1278, so this one (1533) 
can be closed.

-- 
To view, visit https://gerrit.libreoffice.org/1533
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3fab5d62d8f479a5efe242693d2fbe33375206f8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl
Gerrit-Reviewer: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#40465 fix to maintain focus whilst zooming

2013-01-02 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1533

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1533/1

fdo#40465 fix to maintain focus whilst zooming

Change-Id: I3fab5d62d8f479a5efe242693d2fbe33375206f8
---
M dictionaries
M helpcontent2
M sw/source/ui/uiview/viewmdi.cxx
3 files changed, 3 insertions(+), 0 deletions(-)



diff --git a/dictionaries b/dictionaries
index f0c914a..1595bf1 16
--- a/dictionaries
+++ b/dictionaries
-Subproject commit f0c914a43e7e6540300da25c935a77aebb672094
+Subproject commit 1595bf11e295d96123fcb327ba9919307aa5b127
diff --git a/helpcontent2 b/helpcontent2
index d5d84f0..1909df0 16
--- a/helpcontent2
+++ b/helpcontent2
-Subproject commit d5d84f0ec4584e32147eeab355d0ab73e7dd9172
+Subproject commit 1909df07cbd54bf753514cc6dc4137b7b69af63c
diff --git a/sw/source/ui/uiview/viewmdi.cxx b/sw/source/ui/uiview/viewmdi.cxx
index 286435e..17a1ac5 100644
--- a/sw/source/ui/uiview/viewmdi.cxx
+++ b/sw/source/ui/uiview/viewmdi.cxx
@@ -65,6 +65,9 @@
 void SwView::SetZoom( SvxZoomType eZoomType, short nFactor, sal_Bool bViewOnly 
)
 {
 _SetZoom( GetEditWin().GetOutputSizePixel(), eZoomType, nFactor, bViewOnly 
);
+
+//fdo40465 force the cursor to stay in view whilst zooming
+pWrtShell-ShowCrsr();
 }
 
 void SwView::_SetZoom( const Size rEditSize, SvxZoomType eZoomType,

-- 
To view, visit https://gerrit.libreoffice.org/1533
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fab5d62d8f479a5efe242693d2fbe33375206f8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#56124 add functions IFERROR and IFNA to calc as in ODFF1...

2012-12-31 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1522

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/1522/1

fdo#56124 add functions IFERROR and IFNA to calc as in ODFF1.2

Change-Id: I6403b51ac8c710ad3b8d2625e1482971f50e6b1d
---
M dictionaries
M formula/inc/formula/compiler.hrc
M formula/inc/formula/opcode.hxx
M formula/source/core/api/FormulaCompiler.cxx
M formula/source/core/api/token.cxx
M formula/source/core/resource/core_resource.src
M helpcontent2
M sc/inc/helpids.h
M sc/qa/unit/ucalc.cxx
M sc/source/core/inc/interpre.hxx
M sc/source/core/tool/interpr1.cxx
M sc/source/core/tool/interpr4.cxx
M sc/source/core/tool/parclass.cxx
M sc/source/core/tool/token.cxx
M sc/source/ui/src/scfuncs.src
M sc/util/hidother.src
16 files changed, 284 insertions(+), 40 deletions(-)



diff --git a/dictionaries b/dictionaries
index f0c914a..1595bf1 16
--- a/dictionaries
+++ b/dictionaries
-Subproject commit f0c914a43e7e6540300da25c935a77aebb672094
+Subproject commit 1595bf11e295d96123fcb327ba9919307aa5b127
diff --git a/formula/inc/formula/compiler.hrc b/formula/inc/formula/compiler.hrc
index 582e3a5..7f976ae 100644
--- a/formula/inc/formula/compiler.hrc
+++ b/formula/inc/formula/compiler.hrc
@@ -29,26 +29,28 @@
 #define SC_OPCODE_NAME4
 #define SC_OPCODE_EXTERNAL_REF5
 #define SC_OPCODE_IF  6 /* jump commands */
-#define SC_OPCODE_CHOSE   7
-#define SC_OPCODE_OPEN8 /* parentheses and separators */
-#define SC_OPCODE_CLOSE   9
-#define SC_OPCODE_SEP10
-#define SC_OPCODE_MISSING11 /* special OpCodes */
-#define SC_OPCODE_BAD12
-#define SC_OPCODE_STRINGXML  13
-#define SC_OPCODE_SPACES 14
-#define SC_OPCODE_MAT_REF15
-#define SC_OPCODE_DB_AREA16 /* additional access operators */
-#define SC_OPCODE_MACRO  17
-#define SC_OPCODE_COL_ROW_NAME   18
-#define SC_OPCODE_COL_ROW_NAME_AUTO  19
-#define SC_OPCODE_PERCENT_SIGN   20 /* operator _follows_ value */
-#define SC_OPCODE_ARRAY_OPEN 21
-#define SC_OPCODE_ARRAY_CLOSE22
-#define SC_OPCODE_ARRAY_ROW_SEP  23
-#define SC_OPCODE_ARRAY_COL_SEP  24 /* some convs use sep != col_sep */
-#define SC_OPCODE_STOP_DIV   25
-#define SC_OPCODE_SKIP   26 /* used to skip raw tokens during 
string compilation */
+#define SC_OPCODE_IF_ERROR7
+#define SC_OPCODE_IF_NA   8
+#define SC_OPCODE_CHOSE   9
+#define SC_OPCODE_OPEN   10 /* parentheses and separators */
+#define SC_OPCODE_CLOSE  11
+#define SC_OPCODE_SEP12
+#define SC_OPCODE_MISSING13 /* special OpCodes */
+#define SC_OPCODE_BAD14
+#define SC_OPCODE_STRINGXML  15
+#define SC_OPCODE_SPACES 16
+#define SC_OPCODE_MAT_REF17
+#define SC_OPCODE_DB_AREA18 /* additional access operators */
+#define SC_OPCODE_MACRO  19
+#define SC_OPCODE_COL_ROW_NAME   20
+#define SC_OPCODE_COL_ROW_NAME_AUTO  21
+#define SC_OPCODE_PERCENT_SIGN   22 /* operator _follows_ value */
+#define SC_OPCODE_ARRAY_OPEN 23
+#define SC_OPCODE_ARRAY_CLOSE24
+#define SC_OPCODE_ARRAY_ROW_SEP  25
+#define SC_OPCODE_ARRAY_COL_SEP  26 /* some convs use sep != col_sep */
+#define SC_OPCODE_STOP_DIV   27
+#define SC_OPCODE_SKIP   28 /* used to skip raw tokens during 
string compilation */
 
 /*** error constants #... ***/
 #define SC_OPCODE_START_ERRORS   30
diff --git a/formula/inc/formula/opcode.hxx b/formula/inc/formula/opcode.hxx
index cd1831b..e37395e 100644
--- a/formula/inc/formula/opcode.hxx
+++ b/formula/inc/formula/opcode.hxx
@@ -34,6 +34,8 @@
 ocExternalRef   = SC_OPCODE_EXTERNAL_REF,
 // Jump commands
 ocIf= SC_OPCODE_IF,
+ocIfError   = SC_OPCODE_IF_ERROR,
+ocIfNA  = SC_OPCODE_IF_NA,
 ocChose = SC_OPCODE_CHOSE,
 // Parentheses and separators
 ocOpen  = SC_OPCODE_OPEN,
diff --git a/formula/source/core/api/FormulaCompiler.cxx 
b/formula/source/core/api/FormulaCompiler.cxx
index 29b6694..f51f606 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -824,7 +824,7 @@
 {
 switch ((*iLook).second)
 {
-// Not all may make sense in a formula, but these we know as 
+// Not all may make sense in a formula, but these we know as
 // opcodes.
 case ocErrNull:
 nError = errNoCode;
@@ -1125,7 +1125,8 @@
 || eOp == ocOr
 || eOp == ocBad
 || ( eOp = ocInternalBegin  eOp = ocInternalEnd )
-||

WIP fdo#56124 add IFERROR and IFNA to calc

2012-12-24 Thread Winfried Donkers (via Code Review) 
Winfried Donkers has abandoned this change.

Change subject: WIP fdo#56124 add IFERROR and IFNA to calc
..


Patch Set 1: Abandoned

final code will be submitted separately

--
To view, visit https://gerrit.libreoffice.org/1343
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If0145363ed7495a6633d80dabbbfac30af9a0301
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl
Gerrit-Reviewer: Eike Rathke er...@redhat.com
Gerrit-Reviewer: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#56098 Paste Special options after cut incorrect

2012-12-23 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1475

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/1475/1

fdo#56098 Paste Special options after cut incorrect

Change-Id: Ib196cf88905de8f8e7488c14964dfd7a56236356
---
M helpcontent2
M sc/source/ui/view/cellsh1.cxx
2 files changed, 5 insertions(+), 8 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1475
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib196cf88905de8f8e7488c14964dfd7a56236356
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57180 add calc function NUMBERVALUE as defined in ODFF1....

2012-12-23 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1477

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/1477/1

fdo#57180 add calc function NUMBERVALUE as defined in ODFF1.2

Change-Id: I6ee01764ae9fc27854fd3bd8a630b9d3560192e5
---
M formula/inc/formula/opcode.hxx
M helpcontent2
M sc/qa/unit/ucalc.cxx
M sc/source/core/inc/interpre.hxx
M sc/source/core/tool/interpr1.cxx
M sc/source/core/tool/interpr4.cxx
M sc/source/filter/oox/formulabase.cxx
M sc/source/ui/src/scfuncs.src
M sc/util/hidother.src
9 files changed, 155 insertions(+), 3 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1477
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ee01764ae9fc27854fd3bd8a630b9d3560192e5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] WIP fdo#56124 add IFERROR and IFNA to calc

2012-12-14 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1343

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/1343/1

WIP fdo#56124 add IFERROR and IFNA to calc

Change-Id: If0145363ed7495a6633d80dabbbfac30af9a0301
---
M formula/inc/formula/compiler.hrc
M formula/inc/formula/opcode.hxx
M formula/source/core/api/FormulaCompiler.cxx
M formula/source/core/resource/core_resource.src
M sc/inc/helpids.h
M sc/qa/unit/ucalc.cxx
M sc/source/core/inc/interpre.hxx
M sc/source/core/tool/interpr1.cxx
M sc/source/core/tool/interpr4.cxx
M sc/source/core/tool/parclass.cxx
M sc/source/core/tool/token.cxx
M sc/source/ui/src/scfuncs.src
M sc/util/hidother.src
13 files changed, 132 insertions(+), 14 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1343
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0145363ed7495a6633d80dabbbfac30af9a0301
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#40465 fix to maintain correct focus whilst zooming

2012-12-09 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1278

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/1278/1

fdo#40465 fix to maintain correct focus whilst zooming

Change-Id: Ifed6e9a1fcb23e3565843842c3db695ab51b3d54
---
M sw/source/ui/uiview/viewmdi.cxx
1 file changed, 3 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1278
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifed6e9a1fcb23e3565843842c3db695ab51b3d54
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

fdo#50950 add/modify calc formula WEEKNUM and ISOWEEKNUM as ...

2012-11-19 Thread Winfried Donkers (via Code Review) 
Winfried Donkers has abandoned this change.

Change subject: fdo#50950 add/modify calc formula WEEKNUM and ISOWEEKNUM as in 
ODFF1.2
..


Patch Set 2: Abandoned

Patch description is incorrect (refers to wrong bug number).
I will try to resubmit later with correct description.

--
To view, visit https://gerrit.libreoffice.org/1095
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2af326c1052c1c8d47d1fea956b332c73ebe12e4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl
Gerrit-Reviewer: Eike Rathke er...@redhat.com
Gerrit-Reviewer: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#56124 add calc functions IFERROR and IFNA as in ODFF1.2

2012-11-19 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1116

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/1116/1

fdo#56124 add calc functions IFERROR and IFNA as in ODFF1.2

Change-Id: I82c90b7bec9f648f84d3551f64144e5cab5ceff8
---
M formula/inc/formula/compiler.hrc
M formula/inc/formula/opcode.hxx
M formula/source/core/resource/core_resource.src
M sc/inc/helpids.h
M sc/qa/unit/ucalc.cxx
M sc/source/core/inc/interpre.hxx
M sc/source/core/tool/interpr1.cxx
M sc/source/core/tool/interpr4.cxx
M sc/source/ui/src/scfuncs.src
M sc/util/hidother.src
10 files changed, 261 insertions(+), 3 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1116
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82c90b7bec9f648f84d3551f64144e5cab5ceff8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#50950 add/modify calc formula WEEKNUM and ISOWEEKNUM as ...

2012-11-17 Thread Winfried Donkers (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1095

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/1095/1

fdo#50950 add/modify calc formula WEEKNUM and ISOWEEKNUM as in ODFF1.2

Change-Id: I2af326c1052c1c8d47d1fea956b332c73ebe12e4
---
M formula/inc/formula/compiler.hrc
M formula/inc/formula/opcode.hxx
M formula/source/core/resource/core_resource.src
M sc/inc/helpids.h
M sc/qa/unit/ucalc.cxx
M sc/source/core/inc/interpre.hxx
M sc/source/core/tool/interpr1.cxx
M sc/source/core/tool/interpr4.cxx
M sc/source/ui/src/scfuncs.src
M sc/util/hidother.src
10 files changed, 261 insertions(+), 3 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1095
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2af326c1052c1c8d47d1fea956b332c73ebe12e4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers o...@dci-electronics.nl

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice