Re: MacOS build fail "SSE4.2 instruction set not enabled"

2017-05-11 Thread sberg 
On 05/11/2017 10:57 AM, Stephan Bergmann wrote:
> On 05/11/2017 10:17 AM, julien2412 [via Document Foundation Mail 
> Archive] wrote:
>> Would it be possible to enable SSE4.2 on Jenkins MacOs machine or have 
>> we got some compatibility constraint to fulfil?
> 
> I'm not a maintainer of that machine, nor have I got any idea how to 
> access it.  Please ask on the LO mailing list.

...nor do I know what the LO baseline wrt macOS SSE support is; one more 
reason this needs to be discussed on the mailing list




--
View this message in context: 
http://nabble.documentfoundation.org/MacOS-build-fail-SSE4-2-instruction-set-not-enabled-tp4214246p4214248.html
Sent from the Dev mailing list archive at Nabble.com.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: MacOS build fail "SSE4.2 instruction set not enabled"

2017-05-11 Thread sberg 
On 05/11/2017 10:17 AM, julien2412 [via Document Foundation Mail 
Archive] wrote:
> Would it be possible to enable SSE4.2 on Jenkins MacOs machine or have 
> we got some compatibility constraint to fulfil?

I'm not a maintainer of that machine, nor have I got any idea how to 
access it.  Please ask on the LO mailing list.




--
View this message in context: 
http://nabble.documentfoundation.org/MacOS-build-fail-SSE4-2-instruction-set-not-enabled-tp4214246p4214247.html
Sent from the Dev mailing list archive at Nabble.com.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Singleton is never a service?

2015-02-23 Thread sberg 
On 02/22/2015 05:42 PM, julien2412 [via Document Foundation Mail 
Archive] wrote:
> Noticing by chance
> http://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=a94390d20c50125e25e29431ca15ca2ca6683d17,
> I noticed with Opengrok that there were some similar cases, see
> http://opengrok.libreoffice.org/search?q=%22singleton+name%22&project=core&defs=&refs=&path=&hist=
> eg:
> http://opengrok.libreoffice.org/xref/core/framework/util/fwk.component#33
>
> Should we clean these too or we can't generalize this rule?

No, a94390d20c50125e25e29431ca15ca2ca6683d17 is about cases where the 
name of a UNOIDL singleton (cf. the .idl files in offapi) is erroneously 
also used for a service declaration in a .component file.

In general, in implementation described in a .component file can list an 
arbitrary number of services and singletons.





--
View this message in context: 
http://nabble.documentfoundation.org/Singleton-is-never-a-service-tp4141020p4141072.html
Sent from the Dev mailing list archive at Nabble.com.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

2014-05-18 Thread sberg 
On 05/17/2014 01:42 AM, julien2412 [via Document Foundation Mail 
Archive] wrote:
> I noticed that if I did this:
> diff --git a/cppu/qa/test_unotype.cxx b/cppu/qa/test_unotype.cxx
> index bbea200..f0d2b03 100644
> --- a/cppu/qa/test_unotype.cxx
> +++ b/cppu/qa/test_unotype.cxx
> @@ -271,8 +271,8 @@ void Test::testUnoType() {
>   void Test::testGetTypeFavourUnsigned() {
>   CPPUNIT_ASSERT(typeid(::sal_Unicode) == typeid(::sal_uInt16));
>   CPPUNIT_ASSERT(
> -::getCppuType(static_cast< ::sal_Unicode * >(0)) ==
> -::getCppuType(static_cast< ::sal_uInt16 * >(0)));
> +cppu::UnoType::get() ==
> +cppu::UnoType::get() );
>
> make cppu gives this:
> /home/julien/compile-libreoffice/libreoffice/cppu/qa/test_unotype.cxx:275:(anonymous
> namespace)::Test::testGetTypeFavourUnsigned
> assertion failed
> - Expression: cppu::UnoType::get() ==
> cppu::UnoType::get()
>
> test_unotype.cxx:275:Assertion
> Test name: (anonymous namespace)::Test::testGetTypeFavourUnsigned
> assertion failed
> - Expression: cppu::UnoType::get() ==
> cppu::UnoType::get()
>
> Failures !!!
> Run: 3   Failure total: 1   Failures: 1   Errors: 0
>
> I don't understand why it's failing in this case.
> Any idea?

That code is a test that getCppuType (mis-)behaves as advertised, and 
conflates sal_Unicode/sal_uInt16.  Do not change code testing 
getCppuType/getTypeFavourUnsigned/getTypeFavourChar to use UnoType instead.

Stephan




--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4109307.html
Sent from the Dev mailing list archive at Nabble.com.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Question unoType for getXmlToken (dbaccess/reportdesign module)

2014-05-18 Thread sberg 
On 05/16/2014 07:30 PM, julien2412 [via Document Foundation Mail 
Archive] wrote:
> I noticed this:
> s_aTypeNameMap[GetXMLToken( XML_FLOAT)] = ::cppu::UnoType::get();
> present at 2 locations:
> See
> http://opengrok.libreoffice.org/search?q=%22GetXMLToken%28+XML_FLOAT%29%22&project=core&defs=&refs=&path=&hist=
>
> Why shouldn't be this:
> s_aTypeNameMap[GetXMLToken( XML_FLOAT)] = ::cppu::UnoType::get();
> ?

Why should it, because of the "FLOAT" in XML_FLOAT?  I don't know 
anything about that dbaccess/reportbuilder code.  You might want to ask 
on the ML instead (maybe Lionel knows), but I'd assume the code is fine 
as is.

Stephan




--
View this message in context: 
http://nabble.documentfoundation.org/Question-unoType-for-getXmlToken-dbaccess-reportdesign-module-tp4109071p4109306.html
Sent from the Dev mailing list archive at Nabble.com.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Questions about getCppuType

2014-05-05 Thread sberg 
On 04/25/2014 11:06 PM, julien2412 [via Document Foundation Mail 
Archive] wrote:
> I've begun to replace some parts and had this when I've changed this:
> else if ( pType == ::getCppuType((const sal_uInt16*)0) )
> into this:
> else if ( pType == cppu::UnoType::get() )

That's the problem with getCppuType, that sal_uInt16 (representing UNO 
UNSIGNED SHORT) and sal_Unicode (representing UNO CHAR) can be typedefs 
for one and the same type, so getCppuType arbitrarily has to decide for 
one of those.

With cppu::UnoType, instead use cppu::UnoUnsignedShortType and 
cppu::UnoCharType as template arguments, respectively.  (And do get rid 
of the useless "const" in the template arguments.)

Stephan




--
View this message in context: 
http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4107618.html
Sent from the Dev mailing list archive at Nabble.com.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice