Re: 'master' 'make check' lcov code coverage report
On Fri, Nov 7, 2014 at 8:55 PM, Norbert Thiebaud nthieb...@gmail.com wrote: This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script. and prolly the best is to find a place for it in 'buildbot.git' (accessble via gerrit) So where does this 'buildbot.git' live, and how do I set up submit access to that so I can commit the script ? as I said :-) gerrit. gerrit.libreoffice.org/buildbot Okay, so did 'git clone git://gerrit.libreoffice.org/buildbot', and registered for an account over at gerrit and committed my public ssh key. S same process to upload patches than core.git :-) Which is ? Pointer to some docs or an explanation would be appreciated. Thanks. - Maarten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Sat, Nov 8, 2014 at 9:50 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Fri, Nov 7, 2014 at 8:55 PM, Norbert Thiebaud nthieb...@gmail.com wrote: This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script. and prolly the best is to find a place for it in 'buildbot.git' (accessble via gerrit) So where does this 'buildbot.git' live, and how do I set up submit access to that so I can commit the script ? as I said :-) gerrit. gerrit.libreoffice.org/buildbot Okay, so did 'git clone git://gerrit.libreoffice.org/buildbot', and registered for an account over at gerrit and committed my public ssh key. S same process to upload patches than core.git :-) Which is ? Pointer to some docs or an explanation would be appreciated. Thanks. nevermind, I guess this is it: https://wiki.documentfoundation.org/Development/gerrit one more question: is it possible to change your gerrit username after you have set it to something ? Id like to change it, but it seems the gerrit html gui doesnt allow you to change it. Deleting and creating the account again is fine I guess, but I cant find options to delete the account anywhere either. Thanks. - Maarten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Sat, Nov 8, 2014 at 3:03 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Sat, Nov 8, 2014 at 9:50 AM, Maarten Hoes hoes.maar...@gmail.com wrote: nevermind, I guess this is it: https://wiki.documentfoundation.org/Development/gerrit yep :-) one more question: is it possible to change your gerrit username after you have set it to something ? Id like to change it, but it seems the gerrit html gui doesnt allow you to change it. Deleting and creating the account again is fine I guess, but I cant find options to delete the account anywhere either. I can take care of that for you (you mean the 'username' as in the one used by ssh right? ) send me an email with: 1/ The email you used to register to gerrit (so I can find your account) 2/ the old username (to double check with the above :-) ) 3/ the new username you want I'll take care of changing it Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise it will only be done from time to time without a plan. Hrm. Good point. Even weekly would not hurt as we have neither a problem with disk space or build hardware. Cool. You can choose whatever technology is a good fit and that you know. Of course something that other people can understand and maintain is preferred. A shell script sounds like a good idea for this task and would simplify the handling. Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the hostname/ip of the machine I would be allowed to royally mess up for this purpose ? ;) Hi, So I have something now that seems to work (doing a first test run now) on the vm cloph kindly provided, but has no logging, error notification, source updating, error handling, or uploading of reports. Time for a few questions: 1.) Where do the reports have to be uploaded to ? 2.) What do you want the script to do when it detects a failure ? Log an error ? Send an email to an admin ? 3.) Does the script have to handle its own source code updating ? git pull ? 4.) If the make check (run the tests) fails, do you want the script to: a) continue running the other tests, do a 'make -k' a1) upload the report anyway; we rather have an incomplete report than nothing b) stop running the other tests, like a regular make b1) dont upload the report; we dont want incomplete reports. log an error or send an notification or something 5.) Should the script log its output somewhere ? 6.) Should I send a license/code statement to the list for the 'code', even though this is just a shell script ? Also, I am currently running into an lcov/gcov issue (either lcov or gcc/gcov is giving problems) on my own Fedora vm's. It does not seem to be triggered with the version on the vm cloph provided, so it seems I can write the script but the issue needs to be investigated (sort of working on it as we speak) as it might be triggered sometime in the future with that gcc version as well I guess. - Maarten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Fri, Nov 7, 2014 at 10:38 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise it will only be done from time to time without a plan. Hrm. Good point. Even weekly would not hurt as we have neither a problem with disk space or build hardware. Cool. You can choose whatever technology is a good fit and that you know. Of course something that other people can understand and maintain is preferred. A shell script sounds like a good idea for this task and would simplify the handling. Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the hostname/ip of the machine I would be allowed to royally mess up for this purpose ? ;) Hi, So I have something now that seems to work (doing a first test run now) on the vm cloph kindly provided, but has no logging, error notification, source updating, error handling, or uploading of reports. Time for a few questions: 1.) Where do the reports have to be uploaded to ? 2.) What do you want the script to do when it detects a failure ? Log an error ? Send an email to an admin ? 3.) Does the script have to handle its own source code updating ? git pull ? all these 3 point could be solved by putting that job under jenkins control.. I'll have a look at doing that. 4.) If the make check (run the tests) fails, do you want the script to: Ideally I would chain that job behind a sucessful build, so that this does not happen iow first fidn a 'good' commit, then submit the job but before that happen, the msot usefull way would be I think to just drop that build, and retry a bit latter with hopefully a good build at that time 6.) Should I send a license/code statement to the list for the 'code', even though this is just a shell script ? This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script. and prolly the best is to find a place for it in 'buildbot.git' (accessble via gerrit) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Fri, Nov 7, 2014 at 7:29 PM, Norbert Thiebaud nthieb...@gmail.com wrote: On Fri, Nov 7, 2014 at 10:38 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise it will only be done from time to time without a plan. Hrm. Good point. Even weekly would not hurt as we have neither a problem with disk space or build hardware. Cool. You can choose whatever technology is a good fit and that you know. Of course something that other people can understand and maintain is preferred. A shell script sounds like a good idea for this task and would simplify the handling. Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the hostname/ip of the machine I would be allowed to royally mess up for this purpose ? ;) Hi, So I have something now that seems to work (doing a first test run now) on the vm cloph kindly provided, but has no logging, error notification, source updating, error handling, or uploading of reports. Time for a few questions: 1.) Where do the reports have to be uploaded to ? 2.) What do you want the script to do when it detects a failure ? Log an error ? Send an email to an admin ? 3.) Does the script have to handle its own source code updating ? git pull ? all these 3 point could be solved by putting that job under jenkins control.. I'll have a look at doing that. Alright, so no complex error handling code then. But I guess you still will want the script to exit with a non-zero exit code if a single one of the commands in it fails (so jenkins can pick up on the failure) instead of it just blindly continuing as if nothing happened ? 4.) If the make check (run the tests) fails, do you want the script to: Ideally I would chain that job behind a sucessful build, so that this does not happen iow first fidn a 'good' commit, then submit the job but before that happen, the msot usefull way would be I think to just drop that build, and retry a bit latter with hopefully a good build at that time So in other words: instead of 'make -k check' do a 'make check', and have the script exit with a non zero exit code if the make command fails ? 6.) Should I send a license/code statement to the list for the 'code', even though this is just a shell script ? This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script. and prolly the best is to find a place for it in 'buildbot.git' (accessble via gerrit) So where does this 'buildbot.git' live, and how do I set up submit access to that so I can commit the script ? - Maarten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Fri, Nov 7, 2014 at 1:28 PM, Maarten Hoes hoes.maar...@gmail.com wrote: all these 3 point could be solved by putting that job under jenkins control.. I'll have a look at doing that. Alright, so no complex error handling code then. But I guess you still will want the script to exit with a non-zero exit code if a single one of the commands in it fails (so jenkins can pick up on the failure) instead of it just blindly continuing as if nothing happened ? yes. Ideally I would chain that job behind a sucessful build, so that this does not happen iow first fidn a 'good' commit, then submit the job but before that happen, the msot usefull way would be I think to just drop that build, and retry a bit latter with hopefully a good build at that time So in other words: instead of 'make -k check' do a 'make check', and have the script exit with a non zero exit code if the make command fails ? yes 6.) Should I send a license/code statement to the list for the 'code', even though this is just a shell script ? This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script. and prolly the best is to find a place for it in 'buildbot.git' (accessble via gerrit) So where does this 'buildbot.git' live, and how do I set up submit access to that so I can commit the script ? as I said :-) gerrit. gerrit.libreoffice.org/buildbot same process to upload patches than core.git :-) see content at https://gerrit.libreoffice.org/gitweb?p=buildbot.git;a=tree you can prolly just create a lcov directory and put stuff in there... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On 11/04/2014 11:45 AM, Michael Stahl wrote: On 04.11.2014 10:49, Maarten Hoes wrote: Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? : src/libreoffice/workdir/ExternalProject/libfoo src/libreoffice/external/libfoo easily 98% of it is; arguably it should be 100% but sometimes people take short-cuts... Is there anything in workdir/ExternalProject/ at all (apart from some zero-size marker files)? I thought all the meat goes to workdir/UnpackedTarball/. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On 06.11.2014 12:03, Stephan Bergmann wrote: On 11/04/2014 11:45 AM, Michael Stahl wrote: On 04.11.2014 10:49, Maarten Hoes wrote: Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? : src/libreoffice/workdir/ExternalProject/libfoo src/libreoffice/external/libfoo easily 98% of it is; arguably it should be 100% but sometimes people take short-cuts... Is there anything in workdir/ExternalProject/ at all (apart from some zero-size marker files)? I thought all the meat goes to workdir/UnpackedTarball/. that is of course true and i didn't notice the mistake. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Wed, 2014-11-05 at 16:21 +0100, Maarten Hoes wrote: On Wed, Nov 5, 2014 at 4:07 PM, Caolán McNamara caol...@redhat.com wrote: On Tue, 2014-11-04 at 12:15 +0100, Maarten Hoes wrote: I can easily export some pictures to the psd format for you. Just point me to the location of the source files you want converted Oh anything at all, even a blank square in the .psd format is a good start, and you can just mail it to me :-) C. Well here's a blank square, then. Oh wait, we got mixed up there. Its image/x-photo-cd pcd we were missing not psd which we have. Anyway added a pcd regression test now with a sample dumb pcd. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Mon, Nov 3, 2014 at 12:44 PM, Maarten Hoes hoes.maar...@gmail.com
wrote:
Hi,
I ran an gcov/lcov report of 'make check' on master
('sccomp_lpsolver.test' and 'sw_tox.test' failed for some reason with a
core dump, and therefore are excluded from the results), which I could (if
interested) upload (if given access) to
dev-builds.libreoffice.org/lcov_reports/ for comparison with the report
generated for master on 11-Apr-2014.
Well I finally uploaded the results, so now you can compare the code
covered when running the tests (make -k check) on master between :
2014-04-11: commit 0e63ca4fde4e446f346e35849c756a30ca294aab
http://dev-builds.libreoffice.org/lcov_reports/master~2014-04-11_00.55.10/
and
2014-11-03: commit 10e77ab3ff6f4314137acd6e2702a6e5c1ce1fae
http://dev-builds.libreoffice.org/lcov_reports/master~2014-11-02_22.37.32/
So looking at the overall coverage, although there still is room for
improvement, there has been an overall improvement from 38.9% lines / 47.3%
functions of libreoffice code covered by the tests, to 40.8% lines / 50.1%
functions covered.
Sounds like nice progress to me.
:)
- Maarten
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Tue, 2014-11-04 at 12:15 +0100, Maarten Hoes wrote: I can easily export some pictures to the psd format for you. Just point me to the location of the source files you want converted Oh anything at all, even a blank square in the .psd format is a good start, and you can just mail it to me :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Wed, Nov 5, 2014 at 4:07 PM, Caolán McNamara caol...@redhat.com wrote: On Tue, 2014-11-04 at 12:15 +0100, Maarten Hoes wrote: I can easily export some pictures to the psd format for you. Just point me to the location of the source files you want converted Oh anything at all, even a blank square in the .psd format is a good start, and you can just mail it to me :-) C. Well here's a blank square, then. - Maarten blank-square.psd Description: application/photoshop ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? : src/libreoffice/workdir/ExternalProject/libfoo src/libreoffice/external/libfoo In that case, it may simply be the case of excluding these two top directory's: 'workdir/ExternalProject/*' and 'external/*' from the report to get the desired behavior of not seeing non-libreoffice code in the lcov report. Ill give it a go. - Maarten. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On 04.11.2014 10:49, Maarten Hoes wrote: Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? : src/libreoffice/workdir/ExternalProject/libfoo src/libreoffice/external/libfoo easily 98% of it is; arguably it should be 100% but sometimes people take short-cuts... that is true for the source code (hoping you can filter at that level?); there are some externals that are built with our own build system so the object files end up in workdir/*Object like all the LO code. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Mon, Nov 3, 2014 at 5:59 PM, Caolán McNamara caol...@redhat.com wrote: The catch apparently is that we don't have a single image/x-photo-cd pcd attachment in any of the Red Hat, Freedesktop, legacy OpenOffice.org, etc bugzillas to use as a test now that I look into my local horde from ./bin/get-bugzilla-attachments-by-mimetype So there's got to be some (non-offensive) examples out there somewhere else we can use or make some from scratch with ImageMagick or something that can export to the format. I can easily export some pictures to the psd format for you. Just point me to the location of the source files you want converted, and a place I can upload the converted images. - Maarten. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Tue, Nov 4, 2014 at 11:45 AM, Michael Stahl mst...@redhat.com wrote: On 04.11.2014 10:49, Maarten Hoes wrote: Hrm. Looks like I may have made a silly (and wrong) assumption. Is all non-libreoffice code located in these two directory's in the source tree ? : src/libreoffice/workdir/ExternalProject/libfoo src/libreoffice/external/libfoo easily 98% of it is; arguably it should be 100% but sometimes people take short-cuts... that is true for the source code (hoping you can filter at that level?); there are some externals that are built with our own build system so the object files end up in workdir/*Object like all the LO code. Okay, the filter should work out fine then. By the way, the wiki already states the command needed to filter out those directories. Although at the moment I ran into an 'unexpected end of foo.gcno' error, so im having a little fun with that right now. - Maarten. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
'master' 'make check' lcov code coverage report
Hi,
I ran an gcov/lcov report of 'make check' on master ('sccomp_lpsolver.test'
and 'sw_tox.test' failed for some reason with a core dump, and therefore
are excluded from the results), which I could (if interested) upload (if
given access) to dev-builds.libreoffice.org/lcov_reports/ for comparison
with the report generated for master on 11-Apr-2014.
- Maarten
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Mon, 2014-11-03 at 12:44 +0100, Maarten Hoes wrote:
Hi,
I ran an gcov/lcov report of 'make check' on master
('sccomp_lpsolver.test' and 'sw_tox.test' failed for some reason with
a core dump, and therefore are excluded from the results), which I
could (if interested) upload (if given access) to
dev-builds.libreoffice.org/lcov_reports/ for comparison with the
report generated for master on 11-Apr-2014.
Maybe cloph or moggi could sort our some type of access there. I'd be
interested especially interested in which dirs in
filter/source/graphicfilter have 0 coverage and are import filters.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Mon, 2014-11-03 at 16:57 +0100, Maarten Hoes wrote: On Mon, Nov 3, 2014 at 4:10 PM, Caolán McNamara caol...@redhat.com wrote: I'd be interested especially interested in which dirs in filter/source/graphicfilter have 0 coverage and are import filters. Does this list handle attachments gracefully ? Here's a screenshot of just those directory's. Yeah, so in that screenshot, the import ones are the iFOO dirs. So that clearly states we don't have a single pcd filter import case :-( It should be super easy to add a pcd import test, e.g. http://cgit.freedesktop.org/libreoffice/core/log/0445a0ea1b11c78f03272d42e5a8829b1bd107e2 i.e. take one of the other ones, copy and paste it and change e.g. eps to pcd and Eps to Eps and ips to whatever the pcd library is called (probably ipd). The catch apparently is that we don't have a single image/x-photo-cd pcd attachment in any of the Red Hat, Freedesktop, legacy OpenOffice.org, etc bugzillas to use as a test now that I look into my local horde from ./bin/get-bugzilla-attachments-by-mimetype So there's got to be some (non-offensive) examples out there somewhere else we can use or make some from scratch with ImageMagick or something that can export to the format. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
Hey Maarten,
On Mon, Nov 3, 2014 at 4:10 PM, Caolán McNamara caol...@redhat.com wrote:
On Mon, 2014-11-03 at 12:44 +0100, Maarten Hoes wrote:
Hi,
I ran an gcov/lcov report of 'make check' on master
('sccomp_lpsolver.test' and 'sw_tox.test' failed for some reason with
a core dump, and therefore are excluded from the results), which I
could (if interested) upload (if given access) to
dev-builds.libreoffice.org/lcov_reports/ for comparison with the
report generated for master on 11-Apr-2014.
Maybe cloph or moggi could sort our some type of access there. I'd be
interested especially interested in which dirs in
filter/source/graphicfilter have 0 coverage and are import filters.
That is in general no problem. Just send your public ssh key to cloph.
In general I think it makes sense to move that to one of the TDF VMs
and implement a script similar to the coverity one that is more or
less run once a week. If you are interested in working on that we can
surely work something out to get you access to one of the VMs to
automated the generation of the reports.
Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Mon, Nov 3, 2014 at 6:09 PM, Markus Mohrhard
markus.mohrh...@googlemail.com wrote:
Hey Maarten,
On Mon, Nov 3, 2014 at 4:10 PM, Caolán McNamara caol...@redhat.com
wrote:
On Mon, 2014-11-03 at 12:44 +0100, Maarten Hoes wrote:
Hi,
I ran an gcov/lcov report of 'make check' on master
('sccomp_lpsolver.test' and 'sw_tox.test' failed for some reason with
a core dump, and therefore are excluded from the results), which I
could (if interested) upload (if given access) to
dev-builds.libreoffice.org/lcov_reports/ for comparison with the
report generated for master on 11-Apr-2014.
Maybe cloph or moggi could sort our some type of access there. I'd be
interested especially interested in which dirs in
filter/source/graphicfilter have 0 coverage and are import filters.
That is in general no problem. Just send your public ssh key to cloph.
public key is mailed.
In general I think it makes sense to move that to one of the TDF VMs
and implement a script similar to the coverity one that is more or
less run once a week.
Looking briefly at the differences (or lack thereof) in the reports of both
11-Apr-2014 and today, I cannot help but wonder if running the report as
often as weekly would be beneficial at this point. Doing it manually once
every few months seems often enough for now ? Of course, I would be glad to
be wrong here.
;)
If you are interested in working on that we can
surely work something out to get you access to one of the VMs to
automated the generation of the reports.
If bourne/korn shell is considered acceptable, Im willing to try to hack up
a script that runs a git pull/lcov report and scp uploads the results
somewhere. If it needs to be written in something else (buildbot, python,
whatever) I may not be the best man for the job. However, I was able to
generate the report quite easily by following the guidelines for it in the
wiki, so it shouldnt be too hard to do for someone that is able to write a
script for it in other languages I guess.
- Maarten
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
Hey,
On Mon, Nov 3, 2014 at 7:38 PM, Maarten Hoes hoes.maar...@gmail.com wrote:
On Mon, Nov 3, 2014 at 6:09 PM, Markus Mohrhard
markus.mohrh...@googlemail.com wrote:
Hey Maarten,
On Mon, Nov 3, 2014 at 4:10 PM, Caolán McNamara caol...@redhat.com
wrote:
On Mon, 2014-11-03 at 12:44 +0100, Maarten Hoes wrote:
Hi,
I ran an gcov/lcov report of 'make check' on master
('sccomp_lpsolver.test' and 'sw_tox.test' failed for some reason with
a core dump, and therefore are excluded from the results), which I
could (if interested) upload (if given access) to
dev-builds.libreoffice.org/lcov_reports/ for comparison with the
report generated for master on 11-Apr-2014.
Maybe cloph or moggi could sort our some type of access there. I'd be
interested especially interested in which dirs in
filter/source/graphicfilter have 0 coverage and are import filters.
That is in general no problem. Just send your public ssh key to cloph.
public key is mailed.
In general I think it makes sense to move that to one of the TDF VMs
and implement a script similar to the coverity one that is more or
less run once a week.
Looking briefly at the differences (or lack thereof) in the reports of both
11-Apr-2014 and today, I cannot help but wonder if running the report as
often as weekly would be beneficial at this point. Doing it manually once
every few months seems often enough for now ? Of course, I would be glad to
be wrong here.
;)
Maybe not weekly but bi-weekly or monthly. Otherwise it will only be
done from time to time without a plan. Even weekly would not hurt as
we have neither a problem with disk space or build hardware.
If you are interested in working on that we can
surely work something out to get you access to one of the VMs to
automated the generation of the reports.
If bourne/korn shell is considered acceptable, Im willing to try to hack up
a script that runs a git pull/lcov report and scp uploads the results
somewhere. If it needs to be written in something else (buildbot, python,
whatever) I may not be the best man for the job. However, I was able to
generate the report quite easily by following the guidelines for it in the
wiki, so it shouldnt be too hard to do for someone that is able to write a
script for it in other languages I guess.
You can choose whatever technology is a good fit and that you know. Of
course something that other people can understand and maintain is
preferred. A shell script sounds like a good idea for this task and
would simplify the handling.
Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Mon, Nov 3, 2014 at 12:38 PM, Maarten Hoes hoes.maar...@gmail.com wrote: Looking briefly at the differences (or lack thereof) in the reports of both 11-Apr-2014 and today, I cannot help but wonder if running the report as often as weekly would be beneficial at this point. Doing it manually once every few months seems often enough for now ? Of course, I would be glad to be wrong here. ;) It's a catch-22 problem... if this is run rarely, it is on the mind of people rarely, it is unlikely to attract the attention of new blood and even less likely to kkep their attention. If it run say weekly... they there is a 'instant' gratification associated with putting some effort to improve the coverage in some part of the code that in turn often motivate to do even more... Surely much of the coverage could be tacckled as easy hacks.. but positive feedback is very important, to motivate new contributor and show them the result of their good work in a tangible way. If bourne/korn shell is considered acceptable, Im willing to try to hack up a script that runs a git pull/lcov report and scp uploads the results somewhere. Sure bash is fine.. and a properly scripted bash script can be tuck under almost any automation system we can think of. for the record buidbot's client are pure bash :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise it will only be done from time to time without a plan. Hrm. Good point. Even weekly would not hurt as we have neither a problem with disk space or build hardware. Cool. You can choose whatever technology is a good fit and that you know. Of course something that other people can understand and maintain is preferred. A shell script sounds like a good idea for this task and would simplify the handling. Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the hostname/ip of the machine I would be allowed to royally mess up for this purpose ? ;) - Maarten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
Hi Maarten, *, On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the hostname/ip of the machine I would be allowed to royally mess up for this purpose ? ;) That would be me - and IP/hostename will be decided once I created it :-) - what kind of specs does it need? Does running it needs lots of RAM? Does it benefit of many cores? ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Mon, Nov 3, 2014 at 8:25 PM, Christian Lohmaier cl...@documentfoundation.org wrote: Hi Maarten, *, On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the hostname/ip of the machine I would be allowed to royally mess up for this purpose ? ;) That would be me - and IP/hostename will be decided once I created it :-) - what kind of specs does it need? Does running it needs lots of RAM? Does it benefit of many cores? It basically needs to be able to run 'make build-nocheck' and 'make -k check', which benefit from multiple cores and memory. Running lcov is a single threaded thing as far as I can determine, so that would not benefit. Ive created the report on a 4 cpu 8 GB ram vmware vm in about a few hours I guess, so that would be more than sufficient if you ask me. Furthermore, it needs to be able to run 'git clone/pull' to get the latest code. And lastly, it needs to be able to run './configure --with-system-libs make build-nocheck' without problems, so the prerequisite non-libreoffice libs can be easily filtered out of the resulting report. - Maarten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
