Fwd: "[PATCH] Removed unused method from core listed in unusedcode.easy"

2013-04-19 Thread Tor Lillqvist 
unusedcode.easy is not to be trusted blindly. As unusedcode.README says:

a) It's possible that some other platform or configuration uses the code,
   so manual inspection is always required.

And you in fact suggested to *remove* a *use* of the function in
question. (Which was in a file that is platform-specific, used only
for Android.) Didn't you at all find it odd to be removing a line of
code that clearly *used* the allegedly "unused" function?

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: "[PATCH] Removed unused method from core listed in unusedcode.easy"

2013-04-19 Thread Tor Lillqvist 
What does "unused" mean?

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

"[PATCH] Removed unused method from core listed in unusedcode.easy"

2013-04-19 Thread Sameer Deshmukh 
Regards,
Sameer Deshmukh


0001-PATCH-Removed-useless-method.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice