[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillCpp SkillDebug |SkillCpp SkillDebug ||target:4.4.0 --- Comment #14 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Laurent Balland-Poirier committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=31432c4469e7e0d05516143533d6b5e0b411dda3 fdo#53920 Switch back tab at RefButton closure time The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillCpp SkillDebug |SkillCpp SkillDebug |target:4.4.0|target:4.4.0 target:4.3.3 --- Comment #15 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Laurent Balland-Poirier committed a patch related to this issue. It has been pushed to libreoffice-4-3: http://cgit.freedesktop.org/libreoffice/core/commit/?id=50eac342603ca08d808f53dc9a32bb9d1dfba372h=libreoffice-4-3 fdo#53920 Switch back tab at RefButton closure time It will be available in LibreOffice 4.3.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillCpp SkillDebug |SkillCpp SkillDebug |target:4.4.0 target:4.3.3 |target:4.4.0 target:4.3.3 ||target:4.2.7 --- Comment #16 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Laurent Balland-Poirier committed a patch related to this issue. It has been pushed to libreoffice-4-2: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8cdb25a38530319e0b08d97d2706ff019797fe08h=libreoffice-4-2 fdo#53920 Switch back tab at RefButton closure time It will be available in LibreOffice 4.2.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Kohei Yoshida libreoff...@kohei.us changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #17 from Kohei Yoshida libreoff...@kohei.us --- I'll mark this fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #13 from Laurent BP jumbo4...@yahoo.fr --- I tried to debug what is happening at closure time after OK click. in sc/source/ui/view/cellsh2.cxx:928 pTabViewShell-SetValidation( aData ); should copy ValidationData to all selected cells. But in sc/source/ui/view/viewfunc.cxx:1092 function ScViewFunc::ApplySelectionPattern( creates aFuncMark with ScMarkData aFuncMark( rViewData.GetMarkData() ); aFuncMark.bMarked should be true but is set to false if visible tab is not where selected cells are (in debugger, forcing it to true avoid the bug). I tried to force to apply tab modification after sc/source/ui/view/cellsh2.cxx#851 pTabViewShell-SetTabNo( nTab ); with pTabViewShell-PaintExtras(); but it has no effect. So I propose to avoid the bug by just switching back tab earlier: at RefButton shrink box closure. In commit 11560, https://gerrit.libreoffice.org/#/c/11660/ I propose to: - switching back tab in ScTPValidationValue::RefInputDonePostHdl - remove unnecessary switch back tab in cellsh2.cxx -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr |desktop.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #12 from Laurent BP jumbo4...@yahoo.fr --- Hi, The bug seems to come from the fact that visible tab is not the initial tab. Some easy workarounds: - don't use the picker: - either use a named reference (as mentioned previously) - or type the reference - after using the picker, click on tab where the cells to be validated are - apply twice Data Validity: second time the dialog is pre-filled, you just need to click on OK It is quite strange because after executing dialog, tab is forced to go back to initial one. See http://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh2.cxx#849 849 short nResult = pDlg-Execute(); 850 //When picking Cell Range, other Tab may be switched. Need restore the correct tab 851 pTabViewShell-SetTabNo( nTab ); nTab value is correct. Why it is not enough? What else can be done? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #12 from Laurent BP jumbo4...@yahoo.fr --- Hi, The bug seems to come from the fact that visible tab is not the initial tab. Some easy workarounds: - don't use the picker: - either use a named reference (as mentioned previously) - or type the reference - after using the picker, click on tab where the cells to be validated are - apply twice Data Validity: second time the dialog is pre-filled, you just need to click on OK It is quite strange because after executing dialog, tab is forced to go back to initial one. See http://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh2.cxx#849 849 short nResult = pDlg-Execute(); 850 //When picking Cell Range, other Tab may be switched. Need restore the correct tab 851 pTabViewShell-SetTabNo( nTab ); nTab value is correct. Why it is not enough? What else can be done? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #66064|application/octet-stream|application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #66064|application/octet-stream|application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #9 from Doug Naphas douglasnap...@gmail.com --- I would like to attempt this, but I am new to LibreOffice and want to have a better understanding of the code base before assigning this to myself. Can anyone offer some pointers on getting started? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #10 from Markus Mohrhard markus.mohrh...@googlemail.com --- (In reply to comment #9) I would like to attempt this, but I am new to LibreOffice and want to have a better understanding of the code base before assigning this to myself. Can anyone offer some pointers on getting started? so most of the calc specific code is inside sc/ sc is split into 3 parts: sc/source/core contain mostly the model sc/source/filter containing mostly the calc specific parts of the filters sc/source/ui containing the ui related code + some other non model parts ScValidationData is the main class for the validation feature. Cell ranges are represented by ScAddress a single cell address ScRange a continuous cell range ScRangeList a list of ScRange ScMarkData also able to contain multi-selection Please ask more detailed question if you need more details. You can use opengrok.libreoffice.org for browsing the Libreoffice source code. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #11 from Joel Madero jmadero@gmail.com --- also don't forget that you can jump into the dev IRC channel or email the list to get help :) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #9 from Doug Naphas douglasnap...@gmail.com --- I would like to attempt this, but I am new to LibreOffice and want to have a better understanding of the code base before assigning this to myself. Can anyone offer some pointers on getting started? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #10 from Markus Mohrhard markus.mohrh...@googlemail.com --- (In reply to comment #9) I would like to attempt this, but I am new to LibreOffice and want to have a better understanding of the code base before assigning this to myself. Can anyone offer some pointers on getting started? so most of the calc specific code is inside sc/ sc is split into 3 parts: sc/source/core contain mostly the model sc/source/filter containing mostly the calc specific parts of the filters sc/source/ui containing the ui related code + some other non model parts ScValidationData is the main class for the validation feature. Cell ranges are represented by ScAddress a single cell address ScRange a continuous cell range ScRangeList a list of ScRange ScMarkData also able to contain multi-selection Please ask more detailed question if you need more details. You can use opengrok.libreoffice.org for browsing the Libreoffice source code. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #11 from Joel Madero jmadero@gmail.com --- also don't forget that you can jump into the dev IRC channel or email the list to get help :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #8 from Björn Michaelsen bjoern.michael...@canonical.com --- adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #8 from Björn Michaelsen bjoern.michael...@canonical.com --- adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #7 from Armin C mydeem2012-...@yahoo.com --- Still present in Linux in 4.0.4.2 (Build ID: 9e9821abd0ffdbc09cd8c52eaa574fa09eb08f2) and 4.1.0.1 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Markus Mohrhard markus.mohrh...@googlemail.com changed: What|Removed |Added Whiteboard|BSA ProposedEasyHack|EasyHack DifficultyBeginner ||SkillCpp SkillDebug CC||markus.mohrhard@googlemail. ||com --- Comment #6 from Markus Mohrhard markus.mohrh...@googlemail.com --- code pointers: ScValidationData is the class that contains the validation information. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Joel Madero jmadero@gmail.com changed: What|Removed |Added Whiteboard|BSA |BSA ProposedEasyHack -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Priority|medium |low CC||jmadero@gmail.com Ever confirmed|0 |1 --- Comment #5 from Joel Madero jmadero@gmail.com --- Also confirming. Marking as NEW and prioritizing. Normal - Could make it more difficult to create professional quality documents. Raised from minor to normal because it's not consistent (as Rainer has pointed out, if the validity check values are on the same sheet, there is no problem), if a user didn't know this they could end up going round and round trying to figure out how to apply the validity check to a large range of cells or worse, do the validity check one by one Low - Not a ton of users use validity checks. Only happens under specific circumstances @Rainer - if you think it deserves different priority, feel free to changes @Bug Reporter - thanks for reporting this one -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-08-24 11:34:45 UTC --- I currently only can reproduce the problem for criteria in diffenret sheet, works fine with criteria in the same sheet. @Reporter: can you please attach a sample document with some examples works / works not? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #4 from t...@jagenberg.info 2012-08-24 12:25:20 UTC --- Created attachment 66064 -- https://bugs.freedesktop.org/attachment.cgi?id=66064 A sheet trying combinations of named/unnamed references to same/other sheet. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-08-23 20:30:05 UTC --- [Reproducible] with LibreOffice 3.6.1.2 German UI/Locale [Build-ID: e29a214] on German WIN7 Home Premium (64bit), I will do some further research tomorrow -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #2 from t...@jagenberg.info 2012-08-23 23:02:37 UTC --- The problem does not appear when accessing the cell range via a named range. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
