Re: [LATE FEATURE] Regression curve / trendline custom name
Hi, On Thu, Nov 28, 2013 at 4:20 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey Tomaz, Has been discussed just now during the ESC. Thorsten and Bjoern volunteered to review it ;) Can you please push a patch for review to gerrit and post the link here for Bjoern and Thorsten? Done.. https://gerrit.libreoffice.org/6871 https://gerrit.libreoffice.org/6872 https://gerrit.libreoffice.org/6873 https://gerrit.libreoffice.org/6874 https://gerrit.libreoffice.org/6875 https://gerrit.libreoffice.org/6876 https://gerrit.libreoffice.org/6877 Thanks for the great work. Regards, Markus Regards, Tomaž ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [LATE FEATURE] Regression curve / trendline custom name
Hi, On Mon, Nov 25, 2013 at 5:54 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: However I would like to ask you to add an import test for XLS/XLSX and ODF as a help for the future. Done in [1]. I still need volunteers for further reviews.. :) Regards, Tomaž [1]: http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ead27dc7026fc4789323f8849f43c5cafcec2fe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [LATE FEATURE] Regression curve / trendline custom name
Hey Tomaz, 2013/11/28 Tomaž Vajngerl qui...@gmail.com Hi, On Mon, Nov 25, 2013 at 5:54 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: However I would like to ask you to add an import test for XLS/XLSX and ODF as a help for the future. Done in [1]. I still need volunteers for further reviews.. :) Regards, Tomaž [1]: http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ead27dc7026fc4789323f8849f43c5cafcec2fe Has been discussed just now during the ESC. Thorsten and Bjoern volunteered to review it ;) Can you please push a patch for review to gerrit and post the link here for Bjoern and Thorsten? Thanks for the great work. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[LATE FEATURE] Regression curve / trendline custom name
Hi, I have implemented applying custom names to trendlines / regression curves (show in legend) for charts in master. I would also like this for LO 4.2 but I didn't make until feature freeze. This is important for 2 reasons: - old MS binary format and OOXML support this already, so this is an compatibility improvement. - in LO 4.2, the ODF format has been extended with additional properties for regression curves and this change also needs a new property. It would be easier if all the changes would be released in one LO release as all the changes will also be together in the specification proposal to OASIS. Relevant commits are: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3af08dd27d45302d162974e671f50af8a11a9cea http://cgit.freedesktop.org/libreoffice/core/commit/?id=f58e03e7bb0016c1ca789f7e7b35933c95378121 for dry cleanup http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f62f3f0af9ae8c1b00d0d620f306cae914a3861 main implementation http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b243ba51e786b0993e66232144fd6a6ee9ef724 ODF import/export http://cgit.freedesktop.org/libreoffice/core/commit/?id=c86aed38b67ee5d1b842a7765e363015aea22fcc OOXML import/export http://cgit.freedesktop.org/libreoffice/core/commit/?id=288719571eb617613ba9724f394a257a17d43a81 MS binary 2000/XP/2003 import/export Regards, Tomaž ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [LATE FEATURE] Regression curve / trendline custom name
Hey Tomaz, 2013/11/25 Tomaž Vajngerl qui...@gmail.com Hi, I have implemented applying custom names to trendlines / regression curves (show in legend) for charts in master. I would also like this for LO 4.2 but I didn't make until feature freeze. This is important for 2 reasons: - old MS binary format and OOXML support this already, so this is an compatibility improvement. - in LO 4.2, the ODF format has been extended with additional properties for regression curves and this change also needs a new property. It would be easier if all the changes would be released in one LO release as all the changes will also be together in the specification proposal to OASIS. Relevant commits are: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3af08dd27d45302d162974e671f50af8a11a9cea http://cgit.freedesktop.org/libreoffice/core/commit/?id=f58e03e7bb0016c1ca789f7e7b35933c95378121 for dry cleanup http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f62f3f0af9ae8c1b00d0d620f306cae914a3861 main implementation http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b243ba51e786b0993e66232144fd6a6ee9ef724 ODF import/export http://cgit.freedesktop.org/libreoffice/core/commit/?id=c86aed38b67ee5d1b842a7765e363015aea22fcc OOXML import/export http://cgit.freedesktop.org/libreoffice/core/commit/?id=288719571eb617613ba9724f394a257a17d43a81 MS binary 2000/XP/2003 import/export It looks good to me so you have already 1 review. However I would like to ask you to add an import test for XLS/XLSX and ODF as a help for the future. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [LATE FEATURE] Regression curve / trendline custom name
Hi, On Mon, Nov 25, 2013 at 5:54 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey Tomaz, It looks good to me so you have already 1 review. Great, thanks. However I would like to ask you to add an import test for XLS/XLSX and ODF as a help for the future. OK, I will look into this next... Regards, Markus Regards, Tomaž ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
