Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Hi Stefan, Stefan Knorr (Astron) wrote (06-03-12 14:40) What specifically doesn't work for you? For me it's about okay ~today. (I remember August promised you a better solution for later, though.) It is about navigating through the various sections (left) with the arrow keys. If that does not work, you'll notice immediately :-) Now I had a daily build yesterday (Linux x86) and the problem is gone there. Same for a build from master that I did last night. So all fine now again... -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Hi Cor, What specifically doesn't work for you? For me it's about okay ~today. (I remember August promised you a better solution for later, though.) Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Hi all, Regarding this change, I remember I had some discussion (or a bug) about the fact that navigation of the option page was broken by the patch. And I see this commit in git: 064065985a24e2454234e929969cc2b1649b3d01 However, when I work in a build from last week (1), I see that navigating the option pages (sections, left panel of the window) with arrow keys does not work. Anyone an idea? Thanks, Cor 1) LibreOffice master 120116 3.6.0alpha0+ a9ebfbc-9eed775-f061262-libreoffice-3-5 branch-point Stefan Knorr (Astron) wrote (21-12-11 11:10) Hi August, On 21 December 2011 10:12, Cedric Bosdonnatcbosdon...@suse.com wrote: All three of your patches have been pushed on master. Hehe, yeah, I think he pushed them himself, right? In any case, many thanks for the pony, just did a first build, works beautifully and you also got a mention here now: http://wiki.documentfoundation.org/Whiteboards/KillOptions#Filler_Pages -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Cor Nouws wrote (03-03-12 22:29) However, when I work in a build from last week (1), I see that navigating the option pages (sections, left panel of the window) with arrow keys does not work. 1) LibreOffice master 120116 3.6.0alpha0+ a9ebfbc-9eed775-f061262-libreoffice-3-5 branch-point I happen to test something on Windows in LOdev 3.6.0alpha0+ Build ID: 9518535-d09cf17-8a74106-c695ecd-16afab And the navigation does work there ... Strange, interesting ? -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Hi August, All three of your patches have been pushed on master. Many thanks for these: don't hesitate to provide other nice patches ;) -- Cedric On Sun, 2011-12-18 at 14:39 -0500, August Sodora wrote: I split the work into three patches in case part of this needed to be rejected. The first patch implements the actual functionality and the second patch cleans up what is unnecessary after the changes. For the third patch, I noticed that there was a strange timer that would delay loading the option page by 300ms each time a user would select something in the tree on the left. I dispensed with it and the options should load instantly now. August Sodora aug...@gmail.com (201) 280-8138 On Sun, Dec 18, 2011 at 2:09 PM, Stefan Knorr (Astron) heinzless...@googlemail.com wrote: Hi Cor, August, so, that doesn't seem too controversial, then, I guess. Or is there just no one else on UX-advise? August, you said that this is still a bit of a WIP, should this then be pushed or should we wait for a larger patch? Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Hi August, On 21 December 2011 10:12, Cedric Bosdonnat cbosdon...@suse.com wrote: All three of your patches have been pushed on master. Hehe, yeah, I think he pushed them himself, right? In any case, many thanks for the pony, just did a first build, works beautifully and you also got a mention here now: http://wiki.documentfoundation.org/Whiteboards/KillOptions#Filler_Pages . Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Great, I'd love to implement more of the things on that page too. August Sodora aug...@gmail.com (201) 280-8138 On Wed, Dec 21, 2011 at 5:10 AM, Stefan Knorr (Astron) heinzless...@googlemail.com wrote: Hi August, On 21 December 2011 10:12, Cedric Bosdonnat cbosdon...@suse.com wrote: All three of your patches have been pushed on master. Hehe, yeah, I think he pushed them himself, right? In any case, many thanks for the pony, just did a first build, works beautifully and you also got a mention here now: http://wiki.documentfoundation.org/Whiteboards/KillOptions#Filler_Pages . Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Hi August, Astron, On 2011-12-21 at 11:10 +0100, Stefan Knorr (Astron) wrote: All three of your patches have been pushed on master. Hehe, yeah, I think he pushed them himself, right? In any case, many thanks for the pony, just did a first build, works beautifully and you also got a mention here now: http://wiki.documentfoundation.org/Whiteboards/KillOptions#Filler_Pages Very nice, thanks for that! :-) Can we get a mention of that on the 3.6 features page too, please? http://wiki.documentfoundation.org/ReleaseNotes/3.6 Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Hi August, All three of your patches have been pushed on master. Many thanks for these: don't hesitate to provide other nice patches ;) -- Cedric On Sun, 2011-12-18 at 14:39 -0500, August Sodora wrote: I split the work into three patches in case part of this needed to be rejected. The first patch implements the actual functionality and the second patch cleans up what is unnecessary after the changes. For the third patch, I noticed that there was a strange timer that would delay loading the option page by 300ms each time a user would select something in the tree on the left. I dispensed with it and the options should load instantly now. August Sodora aug...@gmail.com (201) 280-8138 On Sun, Dec 18, 2011 at 2:09 PM, Stefan Knorr (Astron) heinzless...@googlemail.com wrote: Hi Cor, August, so, that doesn't seem too controversial, then, I guess. Or is there just no one else on UX-advise? August, you said that this is still a bit of a WIP, should this then be pushed or should we wait for a larger patch? Astron. ___ LibreOffice mailing list libreoff...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category
Hi August, Astron, On 2011-12-21 at 11:10 +0100, Stefan Knorr (Astron) wrote: All three of your patches have been pushed on master. Hehe, yeah, I think he pushed them himself, right? In any case, many thanks for the pony, just did a first build, works beautifully and you also got a mention here now: http://wiki.documentfoundation.org/Whiteboards/KillOptions#Filler_Pages Very nice, thanks for that! :-) Can we get a mention of that on the 3.6 features page too, please? http://wiki.documentfoundation.org/ReleaseNotes/3.6 Thank you, Kendy ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
