[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 4

2010-11-01 Thread Caolán McNamara 
On Mon, 2010-11-01 at 20:28 +0100, Gert Faller wrote:
 Hi,
 
 more of that...
 

Mostly good, though createFromAscii_7.patch has...

OUString::createFromAscii( GetWindowState( WINDOWSTATE_MASK_POS ).GetBuffer() ) 
);

that one can't be changed to use RTL_CONSTASCII_USTRINGPARAM because
GetWindowState is a method rather than a string literal, so that one is
best left alone. Dropped that part, but otherwise pushed.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 4

2010-11-01 Thread Gert Faller 
Selon Caolán McNamara caol...@redhat.com:

 Mostly good, though createFromAscii_7.patch has...

 OUString::createFromAscii( GetWindowState( WINDOWSTATE_MASK_POS ).GetBuffer()
 ) );

 that one can't be changed to use RTL_CONSTASCII_USTRINGPARAM because
 GetWindowState is a method rather than a string literal, so that one is
 best left alone. Dropped that part, but otherwise pushed.

 C.



oops !!!

Regards.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice