[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code

2011-01-11 Thread Caolán McNamara 
On Tue, 2011-01-11 at 22:23 +0100, Anders Jonsson wrote:
 Some more commented code, this time in calc. All code has been commented
 out at least since 2005.

Looks good, pushed, thanks for this.

From the patch, it seems that means that ScRedlineOptionsTabPage is now
an empty function that just returns 0 which suggests a follow up patch
to remove it and all references to it, (note IMPL_LINK generally have a
matching DECL_LINK somewhere).

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code and fix typos

2011-01-09 Thread Caolán McNamara 
On Sun, 2011-01-09 at 02:06 +0900, Takeshi Abe wrote:
 Hi,
 
 Here is a bunch of cleanup on base.

Looks good to me, pushed, thanks for this.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code

2010-12-18 Thread Caolán McNamara 
On Sat, 2010-12-18 at 14:06 +0100, Anders Jonsson wrote:
 Some more blocks of unused code in libs-gui and libs-core. All have been
 commented out since at least 2006.

All looks good, into the bin with it, thanks for this. Pushed now.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice