Re: [Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7
See fdo#36950 for discussion. It doesn't seem to make sense to push a backport of the commit to the 3-4 branch, as we don't know if it actually helps the problem. OK, now some more people have verified that the fix helps for them in the situation it actually was supposed to help. So, I guess, it might make sense then to do the cherry-pick... Three reviews needed now, I guess. Patch at https://bugs.freedesktop.org/show_bug.cgi?id=36950#c21 --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7
On 25/10/11 09:37, Tor Lillqvist wrote: See fdo#36950 for discussion. It doesn't seem to make sense to push a backport of the commit to the 3-4 branch, as we don't know if it actually helps the problem. OK, now some more people have verified that the fix helps for them in the situation it actually was supposed to help. So, I guess, it might make sense then to do the cherry-pick... Three reviews needed now, I guess. Patch at https://bugs.freedesktop.org/show_bug.cgi?id=36950#c21 --tml your patch looks good to me, it should only have an effect for x86_64 windows so is unlikely to break stuff. regards, michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7
Hi Tor, Tor Lillqvist píše v St 19. 10. 2011 v 10:42 +0300: OK, so technically not possible as cherry-pick because of the git repo combination, I guess, but anyway, should this fix be cherry-picked to the 3.4 branch? It is supposed to fix the Windows build so that a 64-bit Explorer extension is also built, to get the Explorer extension also on a 64-bit OS. Requested by fdo#36950 . Note that I have never actually tested whether this fix helps... So I will do that before actually cherry-picking, if signed off in principle. The patch looks safe and could go into libreoffice-3-4 branch. Have you tested the build? Did it succeed? ;-) Could you please back port it for libreoffice-3-4? There are conflicts. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7
See fdo#36950 for discussion. It doesn't seem to make sense to push a backport of the commit to the 3-4 branch, as we don't know if it actually helps the problem. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7
OK, so technically not possible as cherry-pick because of the git repo combination, I guess, but anyway, should this fix be cherry-picked to the 3.4 branch? It is supposed to fix the Windows build so that a 64-bit Explorer extension is also built, to get the Explorer extension also on a 64-bit OS. Requested by fdo#36950 . Note that I have never actually tested whether this fix helps... So I will do that before actually cherry-picking, if signed off in principle. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
