Re: [Libreoffice] 3.4.4rc1 fails to build in kde4 vcl

2011-11-01 Thread Petr Mladek
Andreas Radke píše v Po 31. 10. 2011 v 18:15 +0100:
 Am Mon, 31 Oct 2011 09:50:31 +0100
 schrieb David Tardon dtar...@redhat.com:
  It has been done already. That code should only be used if
  QT_UNIX_EVENT_LOOP_SUPPORT is defined, which, in turn, should only be
  defined if Qt version is at least 4.8.1 . If there is no chance that
  http://bugreports.qt.nokia.com/browse/QTBUG-16934 could be fixed in Qt
  4.8.1, we should IMHO bump the check to 4.9.0.

We managed to get the proposed fix into 3.4.4-rc2. If the bug is not
fixed in qt-4.8.1, we will need to bump the check again.

 Any chance you post a fix for 3.4.4 branch? Or I would have to disable
 the qt vcl for this release.

You need not wait for official LO-release. You might patch the official
sources. See
http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?h=libreoffice-3-4-4id=9f55aac9e3e8f96249d23d392c553afe56f6411d
for inspiration.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] 3.4.4rc1 fails to build in kde4 vcl

2011-10-31 Thread David Tardon
On Sun, Oct 30, 2011 at 10:55:34PM +0100, Rene Engelhard wrote:
 On Sun, Oct 30, 2011 at 03:15:49AM +0100, Andrea Scarpino wrote:
  On Saturday 29 October 2011 21:30:29 Andreas Radke wrote:
   Compiling: vcl/unx/source/dtrans/config.cxx
   /build/src/build/vcl/unx/kde4/KDEXLib.cxx: In member function 'void
   KDEXLib::setupEventLoop()':
   /build/src/build/vcl/unx/kde4/KDEXLib.cxx:252:34: error:
   'GetUnixSelectFunction' is not a member of 'QInternal'
   /build/src/build/vcl/unx/kde4/KDEXLib.cxx:253:34: error:
   'SetUnixSelectFunction' is not a member of 'QInternal'
  This is probably due to Qt 4.8 and not our bug I guess.
 
 Eh, no? If it needs fixes due to Qt 4.8, that should be done here
 so we compile against newer Qts.
 

It has been done already. That code should only be used if
QT_UNIX_EVENT_LOOP_SUPPORT is defined, which, in turn, should only be
defined if Qt version is at least 4.8.1 . If there is no chance that
http://bugreports.qt.nokia.com/browse/QTBUG-16934 could be fixed in Qt
4.8.1, we should IMHO bump the check to 4.9.0.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] 3.4.4rc1 fails to build in kde4 vcl

2011-10-31 Thread Andreas Radke
Am Mon, 31 Oct 2011 09:50:31 +0100
schrieb David Tardon dtar...@redhat.com:

 On Sun, Oct 30, 2011 at 10:55:34PM +0100, Rene Engelhard wrote:
  On Sun, Oct 30, 2011 at 03:15:49AM +0100, Andrea Scarpino wrote:
   On Saturday 29 October 2011 21:30:29 Andreas Radke wrote:
Compiling: vcl/unx/source/dtrans/config.cxx
/build/src/build/vcl/unx/kde4/KDEXLib.cxx: In member function
'void KDEXLib::setupEventLoop()':
/build/src/build/vcl/unx/kde4/KDEXLib.cxx:252:34: error:
'GetUnixSelectFunction' is not a member of 'QInternal'
/build/src/build/vcl/unx/kde4/KDEXLib.cxx:253:34: error:
'SetUnixSelectFunction' is not a member of 'QInternal'
   This is probably due to Qt 4.8 and not our bug I guess.
  
  Eh, no? If it needs fixes due to Qt 4.8, that should be done here
  so we compile against newer Qts.
  
 
 It has been done already. That code should only be used if
 QT_UNIX_EVENT_LOOP_SUPPORT is defined, which, in turn, should only be
 defined if Qt version is at least 4.8.1 . If there is no chance that
 http://bugreports.qt.nokia.com/browse/QTBUG-16934 could be fixed in Qt
 4.8.1, we should IMHO bump the check to 4.9.0.
 
 D.

Any chance you post a fix for 3.4.4 branch? Or I would have to disable
the qt vcl for this release.

-Andy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] 3.4.4rc1 fails to build in kde4 vcl

2011-10-30 Thread Rene Engelhard
On Sun, Oct 30, 2011 at 03:15:49AM +0100, Andrea Scarpino wrote:
 On Saturday 29 October 2011 21:30:29 Andreas Radke wrote:
  Compiling: vcl/unx/source/dtrans/config.cxx
  /build/src/build/vcl/unx/kde4/KDEXLib.cxx: In member function 'void
  KDEXLib::setupEventLoop()':
  /build/src/build/vcl/unx/kde4/KDEXLib.cxx:252:34: error:
  'GetUnixSelectFunction' is not a member of 'QInternal'
  /build/src/build/vcl/unx/kde4/KDEXLib.cxx:253:34: error:
  'SetUnixSelectFunction' is not a member of 'QInternal'
 This is probably due to Qt 4.8 and not our bug I guess.

Eh, no? If it needs fixes due to Qt 4.8, that should be done here
so we compile against newer Qts.

That said, WTF are we using Qt*Internal*? Looks quite internal
to Qt for me :), not something which is public and should be used?

$ grep -r QInternal *
unx/kde4/KDEXLib.cxx:QInternal::callFunction( 
QInternal::GetUnixSelectFunction, reinterpret_cast void** ( qt_select ));
unx/kde4/KDEXLib.cxx:QInternal::callFunction( 
QInternal::SetUnixSelectFunction, reinterpret_cast void** ( lo_select ));

in boith 3.4.4 and master.

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  r...@debian.org | GnuPG-Key ID: D03E3E70
   `-   Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] 3.4.4rc1 fails to build in kde4 vcl

2011-10-29 Thread Andreas Radke
Compiling: vcl/unx/source/dtrans/config.cxx
/build/src/build/vcl/unx/kde4/KDEXLib.cxx: In member function 'void 
KDEXLib::setupEventLoop()':
/build/src/build/vcl/unx/kde4/KDEXLib.cxx:252:34: error: 
'GetUnixSelectFunction' is not a member of 'QInternal'
/build/src/build/vcl/unx/kde4/KDEXLib.cxx:253:34: error: 
'SetUnixSelectFunction' is not a member of 'QInternal'
R=/build/src  S=$R/build  O=$S/solver/340/unxlngx6.pro  W=$O/workdir   
mkdir -p $W/CxxObject/xmloff/source/text/  mkdir -p 
$W/Dep/CxxObject/xmloff/source/text/  g++ -DCPPU_ENV=gcc3 -DCUI -DENABLE_GRAPH
ITE -DENABLE_GTK -DENABLE_KDE4 -DENABLE_LAYOUT=0 -DENABLE_LAYOUT_EXPERIMENTAL=0 
-DGCC -DGXX_INCLUDE_PATH=/usr/include/c++/4.6.2 -DHAVE_GCC_VISIBILITY_FEATURE 
-DLINUX -DNDEBUG -DOPTIMIZE -DOSL_DEBUG_LEVEL=0 -DPRODU
CT -DPRODUCT_FULL -DSOLAR_JAVA -DSUPD=340 -DUNIX -DUNX -DVCL -DX86_64 
-D_PTHREADS -D_REENTRANT   -DXMLOFF_DLLIMPLEMENTATION  -Wall -Wendif-labels 
-Wextra -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Woverloaded-v
irtual -Wshadow -fPIC -fmessage-length=0 -fno-common 
-fvisibility-inlines-hidden -fvisibility=hidden -pipe   -march=x86-64 
-mtune=generic -O2 -pipe -DEXCEPTIONS_ON -fexceptions -fno-enforce-eh-specs  
-O2 -c $S/xml
off/source/text/XMLIndexObjectSourceContext.cxx -o 
$W/CxxObject/xmloff/source/text/XMLIndexObjectSourceContext.o -MMD -MT 
$W/CxxObject/xmloff/source/text/XMLIndexObjectSourceContext.o -MF 
$W/Dep/CxxObject/xmloff/s
ource/text/XMLIndexObjectSourceContext.d -I$S/xmloff/source/text/ -I$O/inc/stl  
-I. -I$O/inc/stl -I$O/inc/external -I$O/inc -I$S/solenv/unxlngx6/inc 
-I$S/solenv/inc -I$S/res -I$S/solenv/inc/Xp31 -I/usr/lib/jvm/jav
a-7-openjdk/include -I/usr/lib/jvm/java-7-openjdk/include/linux 
-I/usr/lib/jvm/java-7-openjdk/include/native_threads/include  -I$S/xmloff/inc 
-I$S/xmloff/inc/pch -I$O/inc/offuh 
[ build CXX ] xmloff/source/text/XMLIndexSimpleEntryContext
R=/build/src  S=$R/build  O=$S/solver/340/unxlngx6.pro  W=$O/workdir   
mkdir -p $W/CxxObject/xmloff/source/text/  mkdir -p 
$W/Dep/CxxObject/xmloff/source/text/  g++ -DCPPU_ENV=gcc3 -DCUI -DENABLE_GRAPH
ITE -DENABLE_GTK -DENABLE_KDE4 -DENABLE_LAYOUT=0 -DENABLE_LAYOUT_EXPERIMENTAL=0 
-DGCC -DGXX_INCLUDE_PATH=/usr/include/c++/4.6.2 -DHAVE_GCC_VISIBILITY_FEATURE 
-DLINUX -DNDEBUG -DOPTIMIZE -DOSL_DEBUG_LEVEL=0 -DPRODU
CT -DPRODUCT_FULL -DSOLAR_JAVA -DSUPD=340 -DUNIX -DUNX -DVCL -DX86_64 
-D_PTHREADS -D_REENTRANT   -DXMLOFF_DLLIMPLEMENTATION  -Wall -Wendif-labels 
-Wextra -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Woverloaded-v
irtual -Wshadow -fPIC -fmessage-length=0 -fno-common 
-fvisibility-inlines-hidden -fvisibility=hidden -pipe   -march=x86-64 
-mtune=generic -O2 -pipe -DEXCEPTIONS_ON -fexceptions -fno-enforce-eh-specs  
-O2 -c $S/xml
off/source/text/XMLIndexSimpleEntryContext.cxx -o 
$W/CxxObject/xmloff/source/text/XMLIndexSimpleEntryContext.o -MMD -MT 
$W/CxxObject/xmloff/source/text/XMLIndexSimpleEntryContext.o -MF 
$W/Dep/CxxObject/xmloff/sour
ce/text/XMLIndexSimpleEntryContext.d -I$S/xmloff/source/text/ -I$O/inc/stl  -I. 
-I$O/inc/stl -I$O/inc/external -I$O/inc -I$S/solenv/unxlngx6/inc 
-I$S/solenv/inc -I$S/res -I$S/solenv/inc/Xp31 -I/usr/lib/jvm/java-7-
openjdk/include -I/usr/lib/jvm/java-7-openjdk/include/linux 
-I/usr/lib/jvm/java-7-openjdk/include/native_threads/include  -I$S/xmloff/inc 
-I$S/xmloff/inc/pch -I$O/inc/offuh 
[ build CXX ] xmloff/source/text/XMLIndexSourceBaseContext
dmake:  Error code 1, while making '../../unxlngx6.pro/slo/KDEXLib.obj'


ArchLinux
gcc 4.6.2
qt 4.8.0rc1
kdelibs 4.7.2

Any fix known?
CC'ing our qt/kde maintainers

-Andy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] 3.4.4rc1 fails to build in kde4 vcl

2011-10-29 Thread Andrea Scarpino
On Saturday 29 October 2011 21:30:29 Andreas Radke wrote:
 Compiling: vcl/unx/source/dtrans/config.cxx
 /build/src/build/vcl/unx/kde4/KDEXLib.cxx: In member function 'void
 KDEXLib::setupEventLoop()':
 /build/src/build/vcl/unx/kde4/KDEXLib.cxx:252:34: error:
 'GetUnixSelectFunction' is not a member of 'QInternal'
 /build/src/build/vcl/unx/kde4/KDEXLib.cxx:253:34: error:
 'SetUnixSelectFunction' is not a member of 'QInternal'
This is probably due to Qt 4.8 and not our bug I guess.

-- 
Andrea
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice