Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
Hi Pierre, On Wed, 2011-02-16 at 22:39 +0100, Pierre-André Jacquod wrote: > after quite a long time, I have done a push again concerning this topic. > Sorry, I was very busy at work and had barely the time to go ahead. Nice ! :-) if this is right: git diff --numstat LIBREOFFICE_3_3_FREEZE..master binfilter > /tmp/changes.csv it seems to suggest we lost a net 55k lines out of that code since the 3.3 branch, ~5% of the code size at least - it sounds small, but lots of our problems require this sort of rock chipping solution :-) > So I will start on the next StarOffice format. Neato :-) it also looks like a good place for easy hacks I guess - if we could remove the functions that start the call tree, I wonder if we can publish a list of un-used functions from callcatcher ? Anyhow - great work, and good to get in for 3.4 before we freeze ! ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
Hello, On 03/25/2011 10:12 PM, Caolán McNamara wrote: On Fri, 2011-03-25 at 22:09 +0100, Pierre-André Jacquod wrote: something... Hopefully my tests are good And make check was successful,.. at last :- ) in case you're relying on it as some oracle :-) No, the other way around: I run make check to be sure not to break it, as I did once:- ) More seriously: I have my set of files for testing, but will nerveless be happy and thankful if other are also sometimes trying to use binfilter. regards ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
On Fri, 2011-03-25 at 22:09 +0100, Pierre-André Jacquod wrote: > something... Hopefully my tests are good And make check was > successful,.. at last :- ) FWIW make check doesn't do a *huge* amount, its a smoketest to ensure that basic functionality isn't broken. So for the binfilter side of things it just opens one .sdw, one .sdd, etc. So its very minimal, just in case you're relying on it as some oracle :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
Hello, after working, hibernating, rebasing after changes,... and changing my way of doing this, I push again some deletions. I have done some deletions of functions that are not used any more within the binfilter and replaced theyre return value. All the code is not yet cleaned. I have done testing as far as I can, and I did not find out that I broke something... Hopefully my tests are good And make check was successful,.. at last :- ) regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
Hello, after quite a long time, I have done a push again concerning this topic. Sorry, I was very busy at work and had barely the time to go ahead. Here is the following work in cleaning within binfilter/bf_sw the code allowing to write in StarWriter format. Without touching dependencies outside of binfilter/bf_sw (which I want to avoid currently), I can’t remove more parts. So I will start on the next StarOffice format. Best regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
On Tue, 2011-01-25 at 08:18 +0100, Pierre-André Jacquod wrote: > Hello, > > On 01/24/2011 03:43 PM, Caolán McNamara wrote: > > > > You also needed to adjust the smoketest "make check" because that has a > > save as staroffice binary file format test in it. I noticed this failed > > this morning and bodged it up to work again. > > Oops, sorry, I was not aware of it. make check is your friend. > Could you just give me a hint where > the code is, so I can have a look? Its actually just a starbasic macro strapped onto some cppunit infrastructure, so the relevant bits is in smoketestoo_native/data which contains the guts of an unpacked .sxw full of some macros to open/save etc some docs. If you just run "build" in smoketestoo_native the test is run non-headless so you can see everything it does. If you run "make check" in the toplevel then the same test is done but headless. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
Hello, > Wonderful :-) do you want help with this ? we could add an easy hack, > and ask people to contact you, for impress / calc etc. > Thanks for this point. I will think if this is easily feasible. But I am still myself on the (intensive) learning part, so I currently do not feel me yet enough confident to describe an easy hack :- ) regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
Hello, On 01/24/2011 03:43 PM, Caolán McNamara wrote: > > You also needed to adjust the smoketest "make check" because that has a > save as staroffice binary file format test in it. I noticed this failed > this morning and bodged it up to work again. Oops, sorry, I was not aware of it. Could you just give me a hint where the code is, so I can have a look? Thanks Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
On Mon, 2011-01-24 at 07:26 +0100, Pierre-André Jacquod wrote: > Hello, > from now I have started to delete within binfilter the code allowing to > *save* using the StarOffice file format. The import (read) is > still possible and will remain. Bye bye saving sdw, sxw > > This will of course not happens in one go... > > With this push, I have done the following changes: > * StarWriter does not export anymore > * start of deletion of functions within binfilter/bf_sw, i.e StarWriter > format You also needed to adjust the smoketest "make check" because that has a save as staroffice binary file format test in it. I noticed this failed this morning and bodged it up to work again. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving
Hi Pierre, On Mon, 2011-01-24 at 07:26 +0100, Pierre-André Jacquod wrote: > from now I have started to delete within binfilter the code allowing to > *save* using the StarOffice file format. The import (read) is > still possible and will remain. Bye bye saving sdw, sxw Wonderful :-) do you want help with this ? we could add an easy hack, and ask people to contact you, for impress / calc etc. > This will of course not happens in one go... :-) > With this push, I have done the following changes: > * StarWriter does not export anymore > * start of deletion of functions within binfilter/bf_sw, i.e StarWriter > format Wonderful. > In order to allow interested to test easily, I will push my changes to > master at periodic intervals (each 2-3 weeks, I think/hope if free time > allows), grouping them and making a short announce as reply to this mail. Thanks for this great work. All the best, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Announcement: StarOffice file-format not available any more for saving
Hello, from now I have started to delete within binfilter the code allowing to *save* using the StarOffice file format. The import (read) is still possible and will remain. Bye bye saving sdw, sxw This will of course not happens in one go... With this push, I have done the following changes: * StarWriter does not export anymore * start of deletion of functions within binfilter/bf_sw, i.e StarWriter format For testing: I have my set of files created with those formats, allowing me to test the reading functionality while deleting code. But if other wants to test it to ensure also that nothing has been broken, I would be happy. In order to allow interested to test easily, I will push my changes to master at periodic intervals (each 2-3 weeks, I think/hope if free time allows), grouping them and making a short announce as reply to this mail. Best regards Pierre-André PS: do not forget the --enable-binfilter flag, if you want to check it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
