Re: [Libreoffice] Recording changes: Deleted lines 'misbehaving'.
... with recorded changes on MSWord shows ... should be read as ... with recorded changes, previously *made* on MSWord, shows ... to resolve any ambiguity! Andy On Feb 2, 2011 10:59 PM, Andy Hearn cuviers...@gmail.com wrote: All, Here's another issue affecting collaborative authors. (FWIW: I'm on master branch, pulled today, around 1900GMT) SW: when an author deletes an existing body of text whilst 'Record Changes' is running, the strike-through'ed text soon disintegrates, leaving swathes of meaningless long lines. And, if the deleted sentence continues to an end of a paragraph, the entire text plus strike-through disappears, leaving a small vertical bar at the LHS as the remaining indicator. Reproducing: 1. New odt. Fill a page of text, say four or five paragraphs. 2. Start recording changes (enable 'Show' changes too). 3. Delete, I use highlight + del key, a number of words, sentences, and at least the last sentence of a paragraph. 4. Watch the strike-throughs while hovering mouse cursor over them - the bubble 'erases' text. Sometimes the text disappear on their 'own accord' after a while. 5. Hit Ctrl-S. Some strike-thoughs disappear completely. Also, loading a .doc with recorded changes on MSWord shows same behaviour for deleted text. Inserted text appear to be unaffected. This behaviour cannot be replicated on OOo, nor MSWord. Is anyone already aware of this, or is working on/with Recording Changes? If not, then I want to dive in. Cheers Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Recording changes: Deleted lines 'misbehaving'.
Hi Andy, On Wed, 2011-02-02 at 22:59 +, Andy Hearn wrote: Here's another issue affecting collaborative authors. Nice catch :-) (FWIW: I'm on master branch, pulled today, around 1900GMT) Glad you're up-to-speed. 1. New odt. Fill a page of text, say four or five paragraphs. ... Sounds like this needs turning into a unit test; any chance you could start with that ? the whole redlining world is in desparate need of deep torture testing :-) I would hack at: sw/qa/core/swdoc-test.cpp Where you should have a near full Writer instance run headless as a unit test, and replicate what the key-entries are doing (I suppose) programatically (manipulating the document). Interestingly, if you are showing the red-lining (with strikethrough) I would expect things to be more reliable ;-) when it is not shown, per-key-stroke (or so) we re-insert all the red-lining, add the keystroke, then remove all the red-lining from the model [ this is not wonderful for performance, as perhaps you can imagine ;-]. Anyhow, I would dig into: sw/inc/redline.hxx and its uses around the place (the feature is called 'redlining') traditionally. Also, loading a .doc with recorded changes on MSWord shows same behaviour for deleted text. Inserted text appear to be unaffected. Great. Is anyone already aware of this, or is working on/with Recording Changes? If not, then I want to dive in. It would be just great to have you working on it, and its all yours :-) All the best, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Recording changes: Deleted lines 'misbehaving'.
All, Here's another issue affecting collaborative authors. (FWIW: I'm on master branch, pulled today, around 1900GMT) SW: when an author deletes an existing body of text whilst 'Record Changes' is running, the strike-through'ed text soon disintegrates, leaving swathes of meaningless long lines. And, if the deleted sentence continues to an end of a paragraph, the entire text plus strike-through disappears, leaving a small vertical bar at the LHS as the remaining indicator. Reproducing: 1. New odt. Fill a page of text, say four or five paragraphs. 2. Start recording changes (enable 'Show' changes too). 3. Delete, I use highlight + del key, a number of words, sentences, and at least the last sentence of a paragraph. 4. Watch the strike-throughs while hovering mouse cursor over them - the bubble 'erases' text. Sometimes the text disappear on their 'own accord' after a while. 5. Hit Ctrl-S. Some strike-thoughs disappear completely. Also, loading a .doc with recorded changes on MSWord shows same behaviour for deleted text. Inserted text appear to be unaffected. This behaviour cannot be replicated on OOo, nor MSWord. Is anyone already aware of this, or is working on/with Recording Changes? If not, then I want to dive in. Cheers Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice