Re: [Libreoffice] StarCalc 1.0 to 5.0 filters
Hi Caolán, *, On Thu, Feb 2, 2012 at 11:10 AM, Caolán McNamara caol...@redhat.com wrote: On Thu, 2012-02-02 at 09:26 +0100, Jan Holesovsky wrote: On 2012-02-01 at 22:21 -0500, Kohei Yoshida wrote: http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docsh.cxx#162 [...] This is only the filter detection code (if I'm not mistaken?), and as such, I think this should still remain there, until we kill binfilter for good; we still use the import functionality, and for that we need the filter detection. binfilter has its *own* typedetection implementation, i.e. binfilter/binfilterdetect/source/bindetect BinFilterDetect::detect so, in theory at least, it self-contains what it needs to detect the formats it imports. So you should be able to hack sc happily without caring about it. Hmm. Not sure whether I got you all correctly. Are you saying that when binfilter is dropped/not shipped anymore, the corresponding filter-selection is dropped as well? I.e. the user will be presented with the choose a filter dialog for those old formats instead of something like those formats are no longer supported - use previous version to convert them? Showing a filter dialog for formats where it is known that no filter exists anymore is not really a nice experience for the user ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] StarCalc 1.0 to 5.0 filters
Hi Kohei, On 2012-02-01 at 22:21 -0500, Kohei Yoshida wrote: Looking at this http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docsh.cxx#162 We still have some code left in sc that appears to handle import of the now defunct StarCalc binary file format. I believe this stuff has been moved to binfilter so I guess it's okay to remove these? This is only the filter detection code (if I'm not mistaken?), and as such, I think this should still remain there, until we kill binfilter for good; we still use the import functionality, and for that we need the filter detection. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] StarCalc 1.0 to 5.0 filters
On Thu, 2012-02-02 at 09:26 +0100, Jan Holesovsky wrote: Hi Kohei, On 2012-02-01 at 22:21 -0500, Kohei Yoshida wrote: Looking at this http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docsh.cxx#162 We still have some code left in sc that appears to handle import of the now defunct StarCalc binary file format. I believe this stuff has been moved to binfilter so I guess it's okay to remove these? This is only the filter detection code (if I'm not mistaken?), and as such, I think this should still remain there, until we kill binfilter for good; we still use the import functionality, and for that we need the filter detection. binfilter has its *own* typedetection implementation, i.e. binfilter/binfilterdetect/source/bindetect BinFilterDetect::detect so, in theory at least, it self-contains what it needs to detect the formats it imports. So you should be able to hack sc happily without caring about it. e.g. filter/source/config/fragments/types/calc_StarCalc_30.xcu has a DetectService of com.sun.star.comp.sfx2.BinaryFormatDetector which is the above BinFilterDetect::detect so .sdc files should be sent to the binfilter to verify that they are .sdc files and handled by the binfilter for import That said, there appears to be a specific quirk/bug with Star Calc 1.0 format, calc_StarCalc_10.xcu still has com.sun.star.comp.calc.FormatDetector as its DetectService instead of com.sun.star.comp.sfx2.BinaryFormatDetector The use of binfilter to typedetect Calc 1.0 files was reverted for https://issues.apache.org/ooo/show_bug.cgi?id=44706 And it looks on a casual viewing that sc/source/filter/starcalc/*cxx is the implementation for importing StarCalc 1.0 files that somehow didn't actually get moved into binfilter and has stayed behind in sc ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] StarCalc 1.0 to 5.0 filters
Hi, On Thursday, 2012-02-02 10:10:08 +, Caolán McNamara wrote: That said, there appears to be a specific quirk/bug with Star Calc 1.0 format, calc_StarCalc_10.xcu still has com.sun.star.comp.calc.FormatDetector as its DetectService instead of com.sun.star.comp.sfx2.BinaryFormatDetector The use of binfilter to typedetect Calc 1.0 files was reverted for https://issues.apache.org/ooo/show_bug.cgi?id=44706 And it looks on a casual viewing that sc/source/filter/starcalc/*cxx is the implementation for importing StarCalc 1.0 files that somehow didn't actually get moved into binfilter and has stayed behind in sc ? Right, SC 1.0 is a different format not related to later binfilter SC formats, just another import filter. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpDgZViZUNc2.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] StarCalc 1.0 to 5.0 filters
Hi Caolan, On Thu, 2012-02-02 at 10:10 +, Caolán McNamara wrote: binfilter has its *own* typedetection implementation, i.e. binfilter/binfilterdetect/source/bindetect BinFilterDetect::detect so, in theory at least, it self-contains what it needs to detect the formats it imports. So you should be able to hack sc happily without caring about it. Great to hear that. Will do. That said, there appears to be a specific quirk/bug with Star Calc 1.0 format, calc_StarCalc_10.xcu still has com.sun.star.comp.calc.FormatDetector as its DetectService instead of com.sun.star.comp.sfx2.BinaryFormatDetector Ok. I'll keep the StarCalc 1.0 filter for the time being. I was really hoping to remove this one among all of them especially because this one still is a major user of the old in-house string container StrData/ScStrCollection, and I'm trying to get rid of them. But oh well. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] StarCalc 1.0 to 5.0 filters
On Thu, 2012-02-02 at 11:01 -0500, Kohei Yoshida wrote: Hi Caolan, On Thu, 2012-02-02 at 10:10 +, Caolán McNamara wrote: binfilter has its *own* typedetection implementation, i.e. binfilter/binfilterdetect/source/bindetect BinFilterDetect::detect so, in theory at least, it self-contains what it needs to detect the formats it imports. So you should be able to hack sc happily without caring about it. Great to hear that. Will do. Actually those filter names are used only to compare the filter names, and the actual meat of the filter code is already gone from sc. ;-) The only code left there is of StarCalc 1.0 which apparently we can't get rid of yet. I'll just leave the whole thing alone. Case closed. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] StarCalc 1.0 to 5.0 filters
Hi there, Looking at this http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docsh.cxx#162 We still have some code left in sc that appears to handle import of the now defunct StarCalc binary file format. I believe this stuff has been moved to binfilter so I guess it's okay to remove these? Even if we need to keep it (for whatever crazy reasons), perhaps we could at least remove the StarCalc 1.0 filter code, maybe? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
