Re: [Libreoffice-commits] core.git: #i121577# Allow setting toolbar name in Addons.xcu
On Tue, Jul 23, 2013 at 07:09:36PM +0200, Stephan Bergmann sberg...@redhat.com wrote: Do we really want the below commits introduce an incompatible change in LO 4.2? They modify officecfg/registry/schema/org/openoffice/Office/Addons.xcs in an incompatible way so that any extension containing toolbars (as /org.openoffice.org.Office.Addons/AddonUI/OfficeToolBar configuration set elements) needs to be changed to keep its toolbars working. For example, in an --enable-ext-numbertext build, Calc View - Toolbars - CT2N is missing now. That is also the reason why the logo toolbar is missing as well: https://bugs.freedesktop.org/show_bug.cgi?id=66691 That even affects default builds. signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-commits] core.git: #i121577# Allow setting toolbar name in Addons.xcu
Hi, On Wednesday, 2013-07-24 09:59:27 +0200, Miklos Vajna wrote: On Tue, Jul 23, 2013 at 07:09:36PM +0200, Stephan Bergmann sberg...@redhat.com wrote: Do we really want the below commits introduce an incompatible change in LO 4.2? They modify officecfg/registry/schema/org/openoffice/Office/Addons.xcs in an incompatible way so that any extension containing toolbars (as /org.openoffice.org.Office.Addons/AddonUI/OfficeToolBar configuration set elements) needs to be changed to keep its toolbars working. For example, in an --enable-ext-numbertext build, Calc View - Toolbars - CT2N is missing now. That is also the reason why the logo toolbar is missing as well: https://bugs.freedesktop.org/show_bug.cgi?id=66691 That even affects default builds. Let's revert the commit(s) please. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A For key transition see http://erack.de/key-transition-2013-01-10.txt.asc Support the FSFE, care about Free Software! https://fsfe.org/support/?erack pgpeKW43LH5G6.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-commits] core.git: #i121577# Allow setting toolbar name in Addons.xcu
Hi Stephan, On Tue, Jul 23, 2013 at 07:09:36PM +0200, Stephan Bergmann wrote: Do we really want the below commits introduce an incompatible change in LO 4.2? This change should only be applied on a major release - if ever (in retrospective, I wouldn't even commit this code, but not because I don't think it is an improvement...); in context: http://markmail.org/message/jpn4e3no4jgv3n4d http://markmail.org/message/fhsepy2a56yhubi2 On 06/24/2013 12:58 PM, Ariel Constenla-Haile wrote: Regards -- Ariel Constenla-Haile La Plata, Argentina pgpKd4CYN57xU.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
