connectivity/source/drivers/dbase/DTable.cxx | 4 +-- filter/source/msfilter/eschesdo.cxx | 4 +-- framework/source/jobs/jobresult.cxx | 2 + framework/source/layoutmanager/toolbarlayoutmanager.hxx | 7 +++++- framework/source/uielement/langselectionmenucontroller.cxx | 9 ++++---- include/svx/svdocirc.hxx | 4 --- sc/source/ui/docshell/impex.cxx | 2 - svx/source/svdraw/svdhdl.cxx | 14 ++++++------- svx/source/svdraw/svdoedge.cxx | 2 + svx/source/svdraw/svdopath.cxx | 1 10 files changed, 28 insertions(+), 21 deletions(-)
New commits: commit c66a649a2d9c65b1b0101e404f751255273111c7 Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:55:02 2014 +0000 coverity#707884 Uninitialized scalar field Change-Id: I21810eac9579b536017b8187497d04dbbc0109c6 diff --git a/framework/source/uielement/langselectionmenucontroller.cxx b/framework/source/uielement/langselectionmenucontroller.cxx index 1d736eb..952a03b 100644 --- a/framework/source/uielement/langselectionmenucontroller.cxx +++ b/framework/source/uielement/langselectionmenucontroller.cxx @@ -74,10 +74,11 @@ DEFINE_XSERVICEINFO_MULTISERVICE_2 ( LanguageSelectionMenuController DEFINE_INIT_SERVICE ( LanguageSelectionMenuController, {} ) -LanguageSelectionMenuController::LanguageSelectionMenuController( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& xContext ) : - svt::PopupMenuControllerBase( xContext ), - m_bShowMenu( sal_True ), - m_aLangGuessHelper( xContext ) +LanguageSelectionMenuController::LanguageSelectionMenuController( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& xContext ) + : svt::PopupMenuControllerBase(xContext) + , m_bShowMenu(sal_True) + , m_nScriptType(LS_SCRIPT_LATIN | LS_SCRIPT_ASIAN | LS_SCRIPT_COMPLEX) + , m_aLangGuessHelper(xContext) { } commit 51a954809aebd9f10449a4b9c9d05c25e2a6d668 Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:52:55 2014 +0000 coverity#707879 Uninitialized scalar field Change-Id: I618fa64876dc27a3d3ced9281f1b02b97a983166 diff --git a/framework/source/layoutmanager/toolbarlayoutmanager.hxx b/framework/source/layoutmanager/toolbarlayoutmanager.hxx index b4cbb17..8062eb3 100644 --- a/framework/source/layoutmanager/toolbarlayoutmanager.hxx +++ b/framework/source/layoutmanager/toolbarlayoutmanager.hxx @@ -184,7 +184,12 @@ class ToolbarLayoutManager : public ::cppu::WeakImplHelper3< ::com::sun::star::a typedef std::vector< UIElement > UIElementVector; struct SingleRowColumnWindowData { - SingleRowColumnWindowData() : nVarSize( 0 ), nStaticSize( 0 ), nSpace( 0 ) {} + SingleRowColumnWindowData() + : nVarSize(0) + , nStaticSize(0) + , nSpace(0) + , nRowColumn(0) + {} std::vector< OUString > aUIElementNames; std::vector< ::com::sun::star::uno::Reference< ::com::sun::star::awt::XWindow > > aRowColumnWindows; commit e769d718b11065de1d61edca3c25549afa9cc871 Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:51:42 2014 +0000 coverity#707878 Uninitialized scalar field Change-Id: I80289d98a5ce58a539516d08d1fc37258ca97e52 diff --git a/framework/source/jobs/jobresult.cxx b/framework/source/jobs/jobresult.cxx index f932f0c1..19c9142 100644 --- a/framework/source/jobs/jobresult.cxx +++ b/framework/source/jobs/jobresult.cxx @@ -37,6 +37,7 @@ namespace framework{ */ JobResult::JobResult() : ThreadHelpBase(&Application::GetSolarMutex()) + , m_bDeactivate(false) { // reset the flag mask! // It will reset the accessible state of this object. commit e917d3065a1f1f5cbf8ca4dc37ed30aa72145e37 Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:51:11 2014 +0000 coverity#707877 Uninitialized scalar field Change-Id: I9454da6940f4d63f916e655b237d78fc701025e9 diff --git a/framework/source/jobs/jobresult.cxx b/framework/source/jobs/jobresult.cxx index 703cbc5..f932f0c1 100644 --- a/framework/source/jobs/jobresult.cxx +++ b/framework/source/jobs/jobresult.cxx @@ -90,6 +90,7 @@ JobResult::JobResult() */ JobResult::JobResult( /*IN*/ const css::uno::Any& aResult ) : ThreadHelpBase(&Application::GetSolarMutex()) + , m_bDeactivate(false) { // safe the pure result // May someone need it later ... commit a02181f5ae6ef39ca988f13f8ce50c294652ddba Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:49:47 2014 +0000 coverity#708370 Uninitialized scalar field Change-Id: I9496ce4f5b5233e700aac0a46794e391929d7fbc diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx index dd83385..a225219 100644 --- a/svx/source/svdraw/svdhdl.cxx +++ b/svx/source/svdraw/svdhdl.cxx @@ -1074,15 +1074,15 @@ void SdrHdlColor::SetSize(const Size& rNew) } } - // class SdrHdlGradient - SdrHdlGradient::SdrHdlGradient(const Point& rRef1, const Point& rRef2, sal_Bool bGrad) -: SdrHdl(rRef1, bGrad ? HDL_GRAD : HDL_TRNS), - pColHdl1(NULL), - pColHdl2(NULL), - a2ndPos(rRef2), - bGradient(bGrad) + : SdrHdl(rRef1, bGrad ? HDL_GRAD : HDL_TRNS) + , pColHdl1(NULL) + , pColHdl2(NULL) + , a2ndPos(rRef2) + , bGradient(bGrad) + , bMoveSingleHandle(false) + , bMoveFirstHandle(false) { } commit cc018a907d583b37f0398f8776ae8a92e5508f2d Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:47:40 2014 +0000 coverity#708374 unused mbPolygonIsLine member Change-Id: I1c171cf237927b7a118a947ea914407c06d4a863 diff --git a/include/svx/svdocirc.hxx b/include/svx/svdocirc.hxx index 81fccce..c4e6b23 100644 --- a/include/svx/svdocirc.hxx +++ b/include/svx/svdocirc.hxx @@ -55,10 +55,6 @@ protected: SdrObjKind meCircleKind; long nStartWink; long nEndWink; - - // bitfield - unsigned mbPolygonIsLine : 1; - private: SVX_DLLPRIVATE basegfx::B2DPolygon ImpCalcXPolyCirc(const SdrObjKind eKind, const Rectangle& rRect1, long nStart, long nEnd) const; SVX_DLLPRIVATE void ImpSetCreateParams(SdrDragStat& rStat) const; commit 6611d739704e96647753865efbf53340273a9bae Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:46:28 2014 +0000 coverity#708376 Uninitialized scalar field Change-Id: Ia7c44a27679ee4f4deb6a99ac0f44d31c1f642a7 diff --git a/svx/source/svdraw/svdoedge.cxx b/svx/source/svdraw/svdoedge.cxx index bce9fed..70a6c2d 100644 --- a/svx/source/svdraw/svdoedge.cxx +++ b/svx/source/svdraw/svdoedge.cxx @@ -2429,6 +2429,8 @@ void SdrEdgeObj::NbcSetPoint(const Point& rPnt, sal_uInt32 i) } SdrEdgeObjGeoData::SdrEdgeObjGeoData() + : bEdgeTrackDirty(false) + , bEdgeTrackUserDefined(false) { pEdgeTrack=new XPolygon; } commit 566049e4c59ba7802d32ee512b076e1b86f4e69f Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:44:57 2014 +0000 coverity#708378 Uninitialized scalar field Change-Id: Id0e463abec7434ee1609071651dce16c9357f205 diff --git a/svx/source/svdraw/svdopath.cxx b/svx/source/svdraw/svdopath.cxx index 6ff84ff..4348097 100644 --- a/svx/source/svdraw/svdopath.cxx +++ b/svx/source/svdraw/svdopath.cxx @@ -1652,6 +1652,7 @@ Pointer ImpPathForDragAndCreate::GetCreatePointer() const /*************************************************************************/ SdrPathObjGeoData::SdrPathObjGeoData() + : meKind(OBJ_NONE) { } commit c50b79fbc23c06b55c51861aac8f9a2fd60c0500 Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:40:38 2014 +0000 coverity#1130369 Dereference after null check Change-Id: Id931c038f3715ea69a798de4b14b46dfa9d2afda diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx index 4621581..deb599d 100644 --- a/sc/source/ui/docshell/impex.cxx +++ b/sc/source/ui/docshell/impex.cxx @@ -241,7 +241,7 @@ void ScImportExport::EndPaste(bool bAutoRowHeight) bool bHeight = bAutoRowHeight && pDocSh && pDocSh->AdjustRowHeight( aRange.aStart.Row(), aRange.aEnd.Row(), aRange.aStart.Tab() ); - if( pUndoDoc && pDoc->IsUndoEnabled() ) + if( pUndoDoc && pDoc->IsUndoEnabled() && pDocSh ) { ScDocument* pRedoDoc = new ScDocument( SCDOCMODE_UNDO ); pRedoDoc->InitUndo( pDoc, aRange.aStart.Tab(), aRange.aEnd.Tab() ); commit 1bc8bc96c15be640e247c10f6beb719c98fcc206 Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:32:49 2014 +0000 coverity#1190360 Unintended sign extension Change-Id: I1fa3a668d47190af3197801a4d99e135d50e2088 diff --git a/connectivity/source/drivers/dbase/DTable.cxx b/connectivity/source/drivers/dbase/DTable.cxx index 2a2a332..0577115 100644 --- a/connectivity/source/drivers/dbase/DTable.cxx +++ b/connectivity/source/drivers/dbase/DTable.cxx @@ -2624,10 +2624,10 @@ sal_Bool ODbaseTable::seekRow(IResultSetHelper::Movement eCursorPosition, sal_In goto Error; else { - sal_uInt16 nEntryLen = m_aHeader.db_slng; + sal_Size nEntryLen = m_aHeader.db_slng; OSL_ENSURE(m_nFilePos >= 1,"SdbDBFCursor::FileFetchRow: ungueltige Record-Position"); - sal_Size nPos = m_aHeader.db_kopf + (sal_Int32)(m_nFilePos-1) * nEntryLen; + sal_Size nPos = m_aHeader.db_kopf + (sal_Size)(m_nFilePos-1) * nEntryLen; m_pFileStream->Seek(nPos); if (m_pFileStream->GetError() != ERRCODE_NONE) commit a1b78271c946bd9d67f16b04cbb81cafa675082a Author: Caolán McNamara <caol...@redhat.com> Date: Sat Mar 8 12:28:30 2014 +0000 coverity#1190346 silence Unchecked return value Change-Id: If6223276d2d45431a674047b9540d4ac3eb71395 diff --git a/filter/source/msfilter/eschesdo.cxx b/filter/source/msfilter/eschesdo.cxx index 23b7cdb..bfb9615 100644 --- a/filter/source/msfilter/eschesdo.cxx +++ b/filter/source/msfilter/eschesdo.cxx @@ -1188,8 +1188,8 @@ void ImplEESdrObject::Init( ImplEESdrWriter& rEx ) { // detect name first to make below test (is group) work mType = OUString( mXShape->getShapeType() ); - mType.startsWith( "com.sun.star.", &mType ); // strip "com.sun.star." - mType.endsWith( "Shape", &mType ); // strip "Shape" + (void)mType.startsWith( "com.sun.star.", &mType ); // strip "com.sun.star." + (void)mType.endsWith( "Shape", &mType ); // strip "Shape" if(GetType() == "drawing.Group") {
_______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits