[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang vcl/source xmlsecurity/source

2023-07-21 Thread Noel Grandin (via logerrit) 
 compilerplugins/clang/unusedfields.only-used-in-constructor.results |   46 
++-
 compilerplugins/clang/unusedfields.readonly.results |   16 +-
 compilerplugins/clang/unusedfields.untouched.results|   20 +--
 compilerplugins/clang/unusedfields.writeonly.results|   62 
--
 vcl/source/gdi/pdfextoutdevdata.cxx |2 
 xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx  |6 
 6 files changed, 60 insertions(+), 92 deletions(-)

New commits:
commit a66b9c9adfb2306a021cd286c8346dd1058499ce
Author: Noel Grandin 
AuthorDate: Fri Jul 21 11:52:24 2023 +0200
Commit: Noel Grandin 
CommitDate: Fri Jul 21 22:16:34 2023 +0200

loplugin:unusedfields

Change-Id: Ic2e9de67a00bb9ca8ab4d0f7528b22c58d0cc360
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154721
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git 
a/compilerplugins/clang/unusedfields.only-used-in-constructor.results 
b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index d897f095b3c2..01db79dd80aa 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -16,7 +16,7 @@ binaryurp/source/writer.hxx:135
 binaryurp::Writer state_ WriterState
 canvas/source/tools/surfaceproxy.hxx:104
 canvas::SurfaceProxy mpPageManager PageManagerSharedPtr
-canvas/source/vcl/impltools.hxx:114
+canvas/source/vcl/impltools.hxx:119
 vclcanvas::tools::LocalGuard aSolarGuard SolarMutexGuard
 chart2/source/controller/accessibility/AccessibleChartShape.hxx:78
 chart::AccessibleChartShape m_aShapeTreeInfo 
::accessibility::AccessibleShapeTreeInfo
@@ -140,7 +140,7 @@ cppu/source/uno/check.cxx:267
 (anonymous namespace)::Char4 chars Char3
 cui/source/dialogs/colorpicker.cxx:748
 cui::(anonymous namespace)::ColorPickerDialog m_aColorPrevious 
ColorPreviewControl
-cui/source/factory/dlgfact.cxx:1240
+cui/source/factory/dlgfact.cxx:1245
 (anonymous namespace)::SvxMacroAssignDialog_Impl m_aItems SfxItemSet
 cui/source/inc/AdditionsDialog.hxx:47
 AdditionInfo sReleaseVersion OUString
@@ -586,9 +586,9 @@ sc/inc/token.hxx:402
 SingleDoubleRefModifier aDub ScComplexRefData
 sc/qa/unit/tiledrendering/tiledrendering.cxx:439
 (anonymous namespace)::ViewCallback m_callbackWrapper 
TestLokCallbackWrapper
-sc/source/core/data/document.cxx:1252
+sc/source/core/data/document.cxx:1217
 (anonymous namespace)::BroadcastRecalcOnRefMoveGuard aSwitch 
sc::AutoCalcSwitch
-sc/source/core/data/document.cxx:1253
+sc/source/core/data/document.cxx:1218
 (anonymous namespace)::BroadcastRecalcOnRefMoveGuard aBulk ScBulkBroadcast
 sc/source/core/data/table2.cxx:812
 (anonymous namespace)::TransClipHandler mnEndRow size_t
@@ -810,7 +810,7 @@ 
svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1098
 (anonymous namespace)::ExpressionGrammar::definition identifier 
::boost::spirit::classic::rule
 svx/source/dialog/contimp.hxx:75
 SvxSuperContourDlg aContourItem SvxContourDlgItem
-svx/source/dialog/framelinkarray.cxx:520
+svx/source/dialog/framelinkarray.cxx:515
 svx::frame::(anonymous namespace)::MergedCellIterator mnFirstRow sal_Int32
 svx/source/dialog/imapwnd.hxx:88
 IMapWindow maItemInfos SfxItemInfo[1]
@@ -832,8 +832,6 @@ sw/inc/unosett.hxx:144
 SwXNumberingRules m_pImpl ::sw::UnoImplPtr
 sw/qa/core/test_ToxTextGenerator.cxx:140
 (anonymous namespace)::ToxTextGeneratorWithMockedChapterField 
mChapterFieldType SwChapterFieldType
-sw/qa/extras/rtfimport/rtfimport.cxx:73
-Test m_aSavedSettings AllSettings
 sw/qa/extras/uiwriter/uiwriter5.cxx:66
 SwUiWriterTest5 m_aSavedSettings AllSettings
 sw/qa/extras/uiwriter/uiwriter7.cxx:2286
@@ -878,8 +876,6 @@ sw/source/uibase/inc/uivwimp.hxx:95
 SwView_Impl m_xTmpSelDocShell SfxObjectShellLock
 sw/source/uibase/inc/unodispatch.hxx:43
 SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard 
SolarMutexGuard
-sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx:91
-sw::sidebar::A11yCheckIssuesPanel m_getIssueCollection 
std::function
 toolkit/source/awt/stylesettings.cxx:74
 toolkit::(anonymous namespace)::StyleMethodGuard m_aGuard SolarMutexGuard
 ucb/source/ucp/gio/gio_mount.hxx:73
@@ -896,7 +892,7 @@ vcl/inc/graphic/Manager.hxx:42
 vcl::graphic::Manager maSwapOutTimer Timer
 vcl/inc/headless/BitmapHelper.hxx:32
 BitmapHelper aTmpBmp SvpSalBitmap
-vcl/inc/jsdialog/jsdialogbuilder.hxx:702
+vcl/inc/jsdialog/jsdialogbuilder.hxx:716
 JSToolbar m_pPopovers std::map
 vcl/inc/pdf/pdfbuildin_fonts.hxx:34
 vcl::pdf::BuildinFont m_nAscent const int
@@ -906,9 +902,9 @@ vcl/inc/pdf/pdfbuildin_fonts.hxx:42
 vcl::pdf::BuildinFont m_aWidths const int[256]
 vcl/inc/salprn.hxx:45
 SalPrinterQueueInfo moPortName std::optional
-vcl/inc/salvtables.hxx:615
+vcl/inc/salvtables.hxx:616
 SalInstanc

[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang vcl/source

2014-07-30 Thread Stephan Bergmann 
 compilerplugins/clang/derefnullptr.cxx |2 +-
 vcl/source/outdev/textline.cxx |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ff209b1446c7923c9e8675611a392c9d280d1440
Author: Stephan Bergmann 
Date:   Wed Jul 30 16:21:17 2014 +0200

Avoid needless truncation to int

Change-Id: Ibb9088e73e3e48952ce7f2f4ec42392f7633e8a7

diff --git a/vcl/source/outdev/textline.cxx b/vcl/source/outdev/textline.cxx
index 4e0add0..5cf5978 100644
--- a/vcl/source/outdev/textline.cxx
+++ b/vcl/source/outdev/textline.cxx
@@ -792,8 +792,8 @@ void OutputDevice::ImplDrawTextLines( SalLayout& 
rSalLayout, FontStrikeout eStri
 else
 {
 Point aStartPt = rSalLayout.GetDrawPosition();
-int nWidth = rSalLayout.GetTextWidth() / rSalLayout.GetUnitsPerPixel();
-ImplDrawTextLine( aStartPt.X(), aStartPt.Y(), 0, nWidth,
+ImplDrawTextLine( aStartPt.X(), aStartPt.Y(), 0,
+  rSalLayout.GetTextWidth() / 
rSalLayout.GetUnitsPerPixel(),
   eStrikeout, eUnderline, eOverline, bUnderlineAbove );
 }
 }
commit 222c94f5a40a8bb4134b31ed6dbfb5e3913197a6
Author: Stephan Bergmann 
Date:   Wed Jul 30 16:17:54 2014 +0200

Adapt loplugin:derefnullptr to old Clang versions

...where prior to r183883 "Implement core issue 903: only integer literals 
with
value 0 and prvalues of type std::nullptr_t are null pointer constants from
C++11 onwards," Expr::isNullPointerConstant with NPC_NeverValueDependent 
could
go into an llvm_unreachable case.

Change-Id: I29cf093f18ece4cd83fd759e30f72c2a71f69554

diff --git a/compilerplugins/clang/derefnullptr.cxx 
b/compilerplugins/clang/derefnullptr.cxx
index 5663e4f..83fa5c4 100644
--- a/compilerplugins/clang/derefnullptr.cxx
+++ b/compilerplugins/clang/derefnullptr.cxx
@@ -26,7 +26,7 @@ public:
 bool DerefNullPtr::VisitUnaryDeref(UnaryOperator const * op) {
 if (!ignoreLocation(op)
 && (op->getSubExpr()->IgnoreParenCasts()->isNullPointerConstant(
-compiler.getASTContext(), 
Expr::NPC_NeverValueDependent/*TODO*/)
+compiler.getASTContext(), 
Expr::NPC_ValueDependentIsNotNull/*TODO*/)
 != Expr::NPCK_NotNull))
 {
 report(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits