[Libreoffice-commits] core.git: 2 commits - cui/source sc/inc sc/source

2022-01-10 Thread Tomaž Vajngerl (via logerrit) 
 cui/source/tabpages/grfpage.cxx  |5 +++--
 sc/inc/document.hxx  |6 +++---
 sc/source/core/data/documen2.cxx |2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

New commits:
commit b15010fdfafeae9a6b22998852f0dafd8bf0d3ce
Author: Tomaž Vajngerl 
AuthorDate: Mon Jan 10 17:23:50 2022 +0900
Commit: Tomaž Vajngerl 
CommitDate: Mon Jan 10 13:51:47 2022 +0100

sc: fix typo

Change-Id: If9a8f7265c17dafa99b51fe6266d935afedfa394
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128207
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 07f488df346d..fa13b7b890e4 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -558,7 +558,7 @@ private:
 bool mbEmbedFontScriptAsian : 1;
 bool mbEmbedFontScriptComplex : 1;
 
-sal_Int32 mnImagenPreferredDPI;
+sal_Int32 mnImagePreferredDPI;
 
 std::unique_ptr m_pIconSetBitmapMap;
 
@@ -585,8 +585,8 @@ public:
 void SetEmbedFontScriptAsian(bool bUse) { mbEmbedFontScriptAsian = bUse; }
 void SetEmbedFontScriptComplex(bool bUse) { mbEmbedFontScriptComplex = 
bUse; }
 
-void SetImagePreferredDPI(sal_Int32 nValue) { mnImagenPreferredDPI = 
nValue; }
-sal_Int32 GetImagePreferredDPI() { return mnImagenPreferredDPI; }
+void SetImagePreferredDPI(sal_Int32 nValue) { mnImagePreferredDPI = 
nValue; }
+sal_Int32 GetImagePreferredDPI() { return mnImagePreferredDPI; }
 
 SC_DLLPUBLIC sal_uLong   GetCellCount() const;   // all cells
 SC_DLLPUBLIC sal_uLong   GetFormulaGroupCount() const;   // all cells
diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index 48bd7737dcfe..67f6e9d7ca41 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -177,7 +177,7 @@ ScDocument::ScDocument( ScDocumentMode eMode, 
SfxObjectShell* pDocShell ) :
 mbEmbedFontScriptLatin(true),
 mbEmbedFontScriptAsian(true),
 mbEmbedFontScriptComplex(true),
-mnImagenPreferredDPI(0),
+mnImagePreferredDPI(0),
 mbTrackFormulasPending(false),
 mbFinalTrackFormulas(false),
 mbDocShellRecalc(false),
commit 1126212885ee2d1ba0fd5e48bdb5f6e9d99e0302
Author: Tomaž Vajngerl 
AuthorDate: Mon Jan 10 17:20:43 2022 +0900
Commit: Tomaž Vajngerl 
CommitDate: Mon Jan 10 13:51:26 2022 +0100

cui: no need to fetch the property from the map twice

Change-Id: I7597c352b2ae166657f1e431e3405fc690520afa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128206
Tested-by: Tomaž Vajngerl 
Reviewed-by: Tomaž Vajngerl 

diff --git a/cui/source/tabpages/grfpage.cxx b/cui/source/tabpages/grfpage.cxx
index 9fd58548516e..f18b2aa006fd 100644
--- a/cui/source/tabpages/grfpage.cxx
+++ b/cui/source/tabpages/grfpage.cxx
@@ -290,8 +290,9 @@ void SvxGrfCropPage::ActivatePage(const SfxItemSet& rSet)
 #endif
 
 auto& aProperties = getAdditionalProperties();
-if (aProperties.find("PreferredDPI") != aProperties.end())
-m_aPreferredDPI = aProperties.at("PreferredDPI").get();
+auto aIterator = aProperties.find("PreferredDPI");
+if (aIterator != aProperties.end())
+m_aPreferredDPI = aIterator->second.get();
 
 bSetOrigSize = false;

[Libreoffice-commits] core.git: 2 commits - cui/source sc/inc sc/source

2019-12-11 Thread Caolán McNamara (via logerrit) 
 cui/source/tabpages/align.cxx |   56 ++
 sc/inc/attrib.hxx |   12 +
 sc/inc/globstr.hrc|1 
 sc/inc/scitems.hxx|2 
 sc/source/core/data/attarray.cxx  |2 
 sc/source/core/data/attrib.cxx|   33 +++
 sc/source/core/data/column2.cxx   |2 
 sc/source/core/data/docpool.cxx   |2 
 sc/source/filter/excel/xistyle.cxx|2 
 sc/source/filter/oox/stylesbuffer.cxx |2 
 sc/source/ui/Accessibility/AccessibleText.cxx |2 
 sc/source/ui/unoobj/cellsuno.cxx  |6 +-
 sc/source/ui/unoobj/styleuno.cxx  |7 +--
 sc/source/ui/view/output2.cxx |2 
 sc/source/ui/view/viewfunc.cxx|2 
 15 files changed, 109 insertions(+), 24 deletions(-)

New commits:
commit 5d44be6c13e6da2d50c0b75d0794a69e796072b5
Author: Caolán McNamara 
AuthorDate: Wed Dec 11 14:05:45 2019 +
Commit: Caolán McNamara 
CommitDate: Wed Dec 11 17:09:53 2019 +0100

Related: tdf#129300 clear properties that are set back to their original 
state

Change-Id: Ic957afbdcf6decef07d15fa10a560e560de5795a
Reviewed-on: https://gerrit.libreoffice.org/84951
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/tabpages/align.cxx b/cui/source/tabpages/align.cxx
index 48ee07764cd5..d0dbae16e685 100644
--- a/cui/source/tabpages/align.cxx
+++ b/cui/source/tabpages/align.cxx
@@ -174,8 +174,11 @@ std::unique_ptr 
AlignmentTabPage::Create(weld::Container* pPage, wel
 
 bool AlignmentTabPage::FillItemSet( SfxItemSet* rSet )
 {
+const SfxItemSet& rOldSet = GetItemSet();
+
 bool bChanged = SfxTabPage::FillItemSet(rSet);
 
+sal_uInt16 nWhich = GetWhich(SID_ATTR_ALIGN_HOR_JUSTIFY);
 if (m_xLbHorAlign->get_value_changed_from_saved())
 {
 SvxCellHorJustify eJustify(SvxCellHorJustify::Standard);
@@ -201,10 +204,13 @@ bool AlignmentTabPage::FillItemSet( SfxItemSet* rSet )
 eJustify = SvxCellHorJustify::Repeat;
 break;
 }
-rSet->Put(SvxHorJustifyItem(eJustify, 
GetWhich(SID_ATTR_ALIGN_HOR_JUSTIFY)));
+rSet->Put(SvxHorJustifyItem(eJustify, nWhich));
 bChanged = true;
 }
+else if (SfxItemState::DEFAULT == rOldSet.GetItemState(nWhich, false))
+rSet->InvalidateItem(nWhich);
 
+nWhich = GetWhich(SID_ATTR_ALIGN_INDENT);
 if (m_xEdIndent->get_value_changed_from_saved())
 {
 const SfxUInt16Item* pIndentItem = static_cast(GetOldItem(
@@ -215,7 +221,10 @@ bool AlignmentTabPage::FillItemSet( SfxItemSet* rSet )
 rSet->Put(*pNewIndentItem);
 bChanged = true;
 }
+else if (SfxItemState::DEFAULT == rOldSet.GetItemState(nWhich, false))
+rSet->InvalidateItem(nWhich);
 
+nWhich = GetWhich(SID_ATTR_ALIGN_VER_JUSTIFY);
 if (m_xLbVerAlign->get_value_changed_from_saved())
 {
 SvxCellVerJustify eJustify(SvxCellVerJustify::Standard);
@@ -238,10 +247,13 @@ bool AlignmentTabPage::FillItemSet( SfxItemSet* rSet )
 eJustify = SvxCellVerJustify::Block;
 break;
 }
-rSet->Put(SvxVerJustifyItem(eJustify, 
GetWhich(SID_ATTR_ALIGN_VER_JUSTIFY)));
+rSet->Put(SvxVerJustifyItem(eJustify, nWhich));
 bChanged = true;
 }
+else if (SfxItemState::DEFAULT == rOldSet.GetItemState(nWhich, false))
+rSet->InvalidateItem(nWhich);
 
+nWhich = GetWhich(SID_ATTR_ALIGN_DEGREES);
 if (m_xNfRotate->get_value_changed_from_saved())
 {
 const SdrAngleItem* pAngleItem = static_cast(GetOldItem(
@@ -252,19 +264,22 @@ bool AlignmentTabPage::FillItemSet( SfxItemSet* rSet )
 rSet->Put(*pNewAngleItem);
 bChanged = true;
 }
+else if (SfxItemState::DEFAULT == rOldSet.GetItemState(nWhich, false))
+rSet->InvalidateItem(nWhich);
 
+nWhich = GetWhich(SID_ATTR_ALIGN_LOCKPOS);
 if (m_aVsRefEdge.IsValueChangedFromSaved())
 {
 switch (m_aVsRefEdge.GetSelectedItemId())
 {
 case IID_CELLLOCK:
-
rSet->Put(SvxRotateModeItem(SvxRotateMode::SVX_ROTATE_MODE_STANDARD, 
GetWhich(SID_ATTR_ALIGN_LOCKPOS)));
+
rSet->Put(SvxRotateModeItem(SvxRotateMode::SVX_ROTATE_MODE_STANDARD, nWhich));
 break;
 case IID_TOPLOCK:
-
rSet->Put(SvxRotateModeItem(SvxRotateMode::SVX_ROTATE_MODE_TOP, 
GetWhich(SID_ATTR_ALIGN_LOCKPOS)));
+
rSet->Put(SvxRotateModeItem(SvxRotateMode::SVX_ROTATE_MODE_TOP, nWhich));
 break;
 case IID_BOTTOMLOCK:
-
rSet->Put(SvxRotateModeItem(SvxRotateMode::SVX_ROTATE_MODE_BOTTOM, 
GetWhich(SID_ATTR_ALIGN_LOCKPOS)));
+
rSet->Put(SvxRotateModeItem(SvxRotateMode::SVX_ROTATE_MODE_BOTTOM,

[Libreoffice-commits] core.git: 2 commits - cui/source sc/inc sc/qa sc/source

2019-12-11 Thread Caolán McNamara (via logerrit) 
 cui/source/tabpages/align.cxx |   14 ++-
 sc/inc/attrib.hxx |   24 +
 sc/inc/globstr.hrc|4 ++
 sc/inc/scitems.hxx|8 ++--
 sc/qa/extras/anchor.cxx   |2 -
 sc/source/core/data/attrib.cxx|   46 --
 sc/source/core/data/column2.cxx   |2 -
 sc/source/core/data/docpool.cxx   |4 +-
 sc/source/core/data/patattr.cxx   |2 -
 sc/source/core/tool/autoform.cxx  |6 +--
 sc/source/filter/excel/xistyle.cxx|2 -
 sc/source/filter/html/htmlpars.cxx|3 +
 sc/source/filter/oox/stylesbuffer.cxx |2 -
 sc/source/filter/qpro/qprostyle.cxx   |4 +-
 sc/source/ui/Accessibility/AccessibleText.cxx |2 -
 sc/source/ui/app/inputhdl.cxx |1 
 sc/source/ui/view/formatsh.cxx|2 -
 sc/source/ui/view/output2.cxx |2 -
 18 files changed, 106 insertions(+), 24 deletions(-)

New commits:
commit cfbac86a0423c552a042ae7b9702c0904d4e232a
Author: Caolán McNamara 
AuthorDate: Tue Dec 10 20:03:38 2019 +
Commit: Caolán McNamara 
CommitDate: Wed Dec 11 17:09:01 2019 +0100

Related: tdf#129300 add ScHyphenateCell to provide a description

Change-Id: If00a50a36cf2bb5c9b775a4ca1000af5c5be7bf4
Reviewed-on: https://gerrit.libreoffice.org/84892
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/tabpages/align.cxx b/cui/source/tabpages/align.cxx
index 1994a7e8699c..ead7d7d4f014 100644
--- a/cui/source/tabpages/align.cxx
+++ b/cui/source/tabpages/align.cxx
@@ -298,7 +298,12 @@ bool AlignmentTabPage::FillItemSet( SfxItemSet* rSet )
 
 if (m_xBtnHyphen->get_state_changed_from_saved())
 {
-rSet->Put(SfxBoolItem(GetWhich(SID_ATTR_ALIGN_HYPHENATION), 
m_xBtnHyphen->get_active()));
+const SfxBoolItem* pHyphItem = static_cast(GetOldItem(
+*rSet, 
SID_ATTR_ALIGN_HYPHENATION));
+assert(pHyphItem);
+std::unique_ptr 
pNewHyphItem(static_cast(pHyphItem->Clone()));
+pNewHyphItem->SetValue(m_xBtnHyphen->get_active());
+rSet->Put(*pNewHyphItem);
 bChanged = true;
 }
 
diff --git a/sc/inc/attrib.hxx b/sc/inc/attrib.hxx
index 100766e3afa9..59be64fb243d 100644
--- a/sc/inc/attrib.hxx
+++ b/sc/inc/attrib.hxx
@@ -333,6 +333,18 @@ public:
  const IntlWrapper& rIntl) const override;
 };
 
+class SC_DLLPUBLIC ScHyphenateCell final : public SfxBoolItem
+{
+public:
+ScHyphenateCell(bool bHyphenate= false);
+virtual ScHyphenateCell* Clone(SfxItemPool *pPool = nullptr) const 
override;
+virtual bool GetPresentation(SfxItemPresentation ePres,
+ MapUnit eCoreMetric,
+ MapUnit ePresMetric,
+ OUString ,
+ const IntlWrapper& rIntl) const override;
+};
+
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/globstr.hrc b/sc/inc/globstr.hrc
index 518d033814ee..4f13865ca778 100644
--- a/sc/inc/globstr.hrc
+++ b/sc/inc/globstr.hrc
@@ -521,6 +521,8 @@
 #define STR_VERTICALSTACKCELL_OFF   
NC_("STR_VERTICALSTACKCELL_OFF", "Vertically stacked: Off")
 #define STR_LINEBREAKCELL_ONNC_("STR_LINEBREAKCELL_ON", 
"Wrap text automatically: On")
 #define STR_LINEBREAKCELL_OFF   NC_("STR_LINEBREAKCELL_OFF", 
"Wrap text automatically: Off")
+#define STR_HYPHENATECELL_ONNC_("STR_HYPHENATECELL_ON", 
"Hyphenate: On")
+#define STR_HYPHENATECELL_OFF   NC_("STR_HYPHENATECELL_OFF", 
"Hyphenate: Off")
 
 #endif
 
diff --git a/sc/inc/scitems.hxx b/sc/inc/scitems.hxx
index ce40a2c4a267..674bf07fa3e9 100644
--- a/sc/inc/scitems.hxx
+++ b/sc/inc/scitems.hxx
@@ -111,7 +111,7 @@ class SvxSizeItem;
 #define ATTR_USERDEFTypedWhichId(122)
// not saved in binary files
 #define ATTR_FONT_WORDLINE  TypedWhichId(123)
 #define ATTR_FONT_RELIEFTypedWhichId(124)
-#define ATTR_HYPHENATE  TypedWhichId(125)
+#define ATTR_HYPHENATE  TypedWhichId(125)
 #define ATTR_SCRIPTSPACETypedWhichId(126)
 #define ATTR_HANGPUNCTUATIONTypedWhichId(127)
 #define ATTR_FORBIDDEN_RULESTypedWhichId(128)
diff --git a/sc/source/core/data/attrib.cxx b/sc/source/core/data/attrib.cxx
index 75337c00f75d..4ed61887a67a 100644
--- a/sc/source/core/data/attrib.cxx
+++ b/sc/source/core/data/attrib.cxx
@@ -808,4 +808,24 @@ bool ScLineBreakCell::GetPresentation(SfxItemPresentation,
 return true;
 }
 
+ScHyphenateCell::ScHyphenateCell(bool bHyphenate)
+: SfxBoolItem(ATTR_HYPHENATE, bHyphenate)
+{
+}
+
+ScHyphenateCell* ScHyphenateCell::Clone(SfxItemPool*) const
+{
+return new

[Libreoffice-commits] core.git: 2 commits - cui/source sc/inc

2019-07-27 Thread Caolán McNamara (via logerrit) 
 cui/source/options/optbasic.cxx |  108 
 cui/source/options/optbasic.hxx |   15 ++---
 sc/inc/scmod.hxx|2 
 3 files changed, 53 insertions(+), 72 deletions(-)

New commits:
commit 7360ddd34aa446e6439c733ef0f819a58d709744
Author: Caolán McNamara 
AuthorDate: Sat Jul 27 11:46:17 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jul 27 14:11:45 2019 +0200

cid#1401328 Uncaught exception

Change-Id: I1c4bdd4afec30d7d52054d8c9bd4958191c480f8
Reviewed-on: https://gerrit.libreoffice.org/76470
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/scmod.hxx b/sc/inc/scmod.hxx
index a82ac9337b12..363a9dd2a354 100644
--- a/sc/inc/scmod.hxx
+++ b/sc/inc/scmod.hxx
@@ -87,7 +87,7 @@ class SAL_DLLPUBLIC_RTTI ScModule: public SfxModule, public 
SfxListener, public
 ScMessagePool*  m_pMessagePool;
 // there is no global InputHandler anymore, each View has its own
 ScInputHandler* m_pRefInputHandler;
-std::unique_ptrm_pViewCfg;
+std::unique_ptr> m_pViewCfg;
 std::unique_ptr> m_pDocCfg;
 std::unique_ptr> m_pAppCfg;
 std::unique_ptrm_pDefaultsCfg;
commit bee82941206bfae3f57a3008babec7c16b129b5d
Author: Caolán McNamara 
AuthorDate: Fri Jul 26 17:33:06 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jul 27 14:11:30 2019 +0200

weld SvxBasicIDEOptionsPage

Change-Id: I3f5a7fe106075194e90e0da6f6538882024adec1
Reviewed-on: https://gerrit.libreoffice.org/76454
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/options/optbasic.cxx b/cui/source/options/optbasic.cxx
index 688b4e7e4f83..56a52fbcd45c 100644
--- a/cui/source/options/optbasic.cxx
+++ b/cui/source/options/optbasic.cxx
@@ -22,49 +22,36 @@
 #include 
 #include 
 
-SvxBasicIDEOptionsPage::SvxBasicIDEOptionsPage( vcl::Window* pParent, const 
SfxItemSet& rSet )
-: SfxTabPage(pParent, "OptBasicIDEPage", "cui/ui/optbasicidepage.ui", )
+SvxBasicIDEOptionsPage::SvxBasicIDEOptionsPage(TabPageParent pParent, const 
SfxItemSet& rSet)
+: SfxTabPage(pParent, "cui/ui/optbasicidepage.ui", "OptBasicIDEPage", 
)
+, m_xCodeCompleteChk(m_xBuilder->weld_check_button("codecomplete_enable"))
+, m_xAutocloseProcChk(m_xBuilder->weld_check_button("autoclose_proc"))
+, m_xAutocloseParenChk(m_xBuilder->weld_check_button("autoclose_paren"))
+, m_xAutocloseQuotesChk(m_xBuilder->weld_check_button("autoclose_quotes"))
+, m_xAutoCorrectChk(m_xBuilder->weld_check_button("autocorrect"))
+, 
m_xUseExtendedTypesChk(m_xBuilder->weld_check_button("extendedtypes_enable"))
 {
-get(pCodeCompleteChk, "codecomplete_enable");
-get(pAutocloseProcChk, "autoclose_proc");
-get(pAutocloseParenChk, "autoclose_paren");
-get(pAutocloseQuotesChk, "autoclose_quotes");
-get(pAutoCorrectChk, "autocorrect");
-get(pUseExtendedTypesChk, "extendedtypes_enable");
-
 LoadConfig();
 }
 
 SvxBasicIDEOptionsPage::~SvxBasicIDEOptionsPage()
 {
-disposeOnce();
-}
-
-void SvxBasicIDEOptionsPage::dispose()
-{
-pCodeCompleteChk.clear();
-pAutocloseProcChk.clear();
-pAutocloseParenChk.clear();
-pAutocloseQuotesChk.clear();
-pAutoCorrectChk.clear();
-pUseExtendedTypesChk.clear();
-SfxTabPage::dispose();
 }
 
 void SvxBasicIDEOptionsPage::LoadConfig()
 {
-pCodeCompleteChk->Check( 
officecfg::Office::BasicIDE::Autocomplete::CodeComplete::get() );
-pCodeCompleteChk->Enable( 
!officecfg::Office::BasicIDE::Autocomplete::CodeComplete::isReadOnly() );
-pAutocloseProcChk->Check( 
officecfg::Office::BasicIDE::Autocomplete::AutocloseProc::get() );
-pAutocloseProcChk->Enable( 
!officecfg::Office::BasicIDE::Autocomplete::AutocloseProc::isReadOnly() );
-pAutocloseQuotesChk->Check( 
officecfg::Office::BasicIDE::Autocomplete::AutocloseDoubleQuotes::get() );
-pAutocloseQuotesChk->Enable( 
!officecfg::Office::BasicIDE::Autocomplete::AutocloseDoubleQuotes::isReadOnly() 
);
-pAutocloseParenChk->Check( 
officecfg::Office::BasicIDE::Autocomplete::AutocloseParenthesis::get() );
-pAutocloseParenChk->Enable( 
!officecfg::Office::BasicIDE::Autocomplete::AutocloseParenthesis::isReadOnly() 
);
-pAutoCorrectChk->Check( 
officecfg::Office::BasicIDE::Autocomplete::AutoCorrect::get() );
-pAutoCorrectChk->Enable( 
!officecfg::Office::BasicIDE::Autocomplete::AutoCorrect::isReadOnly() );
-pUseExtendedTypesChk->Check( 
officecfg::Office::BasicIDE::Autocomplete::UseExtended::get() );
-pUseExtendedTypesChk->Enable( 
!officecfg::Office::BasicIDE::Autocomplete::UseExtended::isReadOnly() );
+m_xCodeCompleteChk->set_active( 
officecfg::Office::BasicIDE::Autocomplete::CodeComplete::get() );
+m_xCodeCompleteChk->set_sensitive( 
!officecfg::Office::BasicIDE::Autocomplete::CodeComplete::isReadOnly() );
+m_xAutocloseProcChk->set_active(

[Libreoffice-commits] core.git: 2 commits - cui/source sc/inc sc/source

2017-12-07 Thread Tamás Zolnai 
 cui/source/dialogs/cuicharmap.cxx|4 
 sc/inc/textuno.hxx   |2 
 sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx |8 -
 sc/source/ui/app/uiitems.cxx |   52 ---
 sc/source/ui/dbgui/asciiopt.cxx  |   16 ---
 sc/source/ui/docshell/externalrefmgr.cxx |3 
 sc/source/ui/inc/areasave.hxx|2 
 sc/source/ui/inc/asciiopt.hxx|1 
 sc/source/ui/inc/cellmergeoption.hxx |1 
 sc/source/ui/inc/uiitems.hxx |   10 --
 sc/source/ui/undo/areasave.cxx   |   13 --
 sc/source/ui/unoobj/chart2uno.cxx|   30 --
 sc/source/ui/unoobj/textuno.cxx  |   12 --
 sc/source/ui/view/cellmergeoption.cxx|   10 --
 14 files changed, 2 insertions(+), 162 deletions(-)

New commits:
commit 2432c550d203053214310a23630f89baecdff6cc
Author: Tamás Zolnai 
Date:   Fri Dec 8 04:01:02 2017 +0100

Update recent characters only when the selected character is inserted

Change-Id: Ic8cd715553f995d8adc1e84381c00646c9c252af
Reviewed-on: https://gerrit.libreoffice.org/46065
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 

diff --git a/cui/source/dialogs/cuicharmap.cxx 
b/cui/source/dialogs/cuicharmap.cxx
index 31c259188431..c01af450b5f8 100644
--- a/cui/source/dialogs/cuicharmap.cxx
+++ b/cui/source/dialogs/cuicharmap.cxx
@@ -631,9 +631,9 @@ void SvxCharacterMap::insertCharToDoc(const OUString& 
sGlyph)
 aArgs[1].Name = "FontName";
 aArgs[1].Value <<= aFont.GetFamilyName();
 comphelper::dispatchCommand(".uno:InsertSymbol", aArgs);
-}
 
-updateRecentCharacterList(sGlyph, aFont.GetFamilyName());
+updateRecentCharacterList(sGlyph, aFont.GetFamilyName());
+}
 }
 
 
commit 818f9e4017d16d6a48265638393dec4f9ed30649
Author: Jochen Nitschke 
Date:   Tue Dec 5 19:08:39 2017 +0100

clang-tidy modernize-use-equals-default in sc/source/ui

Change-Id: I827e05835838508eb83053a3de80dfa5f53cb685
Reviewed-on: https://gerrit.libreoffice.org/46046
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/textuno.hxx b/sc/inc/textuno.hxx
index 0d72c9b95008..c88a2831261d 100644
--- a/sc/inc/textuno.hxx
+++ b/sc/inc/textuno.hxx
@@ -220,7 +220,6 @@ class ScCellTextCursor : public SvxUnoTextCursor
 rtl::Reference mxTextObj;
 
 public:
-ScCellTextCursor(const ScCellTextCursor& rOther);
 ScCellTextCursor(ScCellObj& rText);
 virtual ~ScCellTextCursor() throw() override;
 
@@ -271,7 +270,6 @@ private:
 css::uno::Reference< css::text::XText > xParentText;
 
 public:
-ScDrawTextCursor(const ScDrawTextCursor& rOther);
 ScDrawTextCursor( const css::uno::Reference< 
css::text::XText >& xParent,
 const SvxUnoTextBase& rText );
 virtual  ~ScDrawTextCursor() throw() override;
diff --git a/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx 
b/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
index 203058d7cc11..e5bb6a38389a 100644
--- a/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
@@ -559,20 +559,12 @@ struct ScShapeChild
 : mnRangeId(0)
 {
 }
-ScShapeChild(const ScShapeChild& rOld);
 ~ScShapeChild();
 mutable rtl::Reference< ::accessibility::AccessibleShape > mpAccShape;
 css::uno::Reference< css::drawing::XShape > mxShape;
 sal_Int32 mnRangeId;
 };
 
-ScShapeChild::ScShapeChild(const ScShapeChild& rOld)
-:
-mpAccShape(rOld.mpAccShape),
-mxShape(rOld.mxShape),
-mnRangeId(rOld.mnRangeId)
-{}
-
 ScShapeChild::~ScShapeChild()
 {
 if (mpAccShape.is())
diff --git a/sc/source/ui/app/uiitems.cxx b/sc/source/ui/app/uiitems.cxx
index a28e02234ad0..dd0f4eb27f79 100644
--- a/sc/source/ui/app/uiitems.cxx
+++ b/sc/source/ui/app/uiitems.cxx
@@ -137,17 +137,6 @@ ScSortItem::ScSortItem( sal_uInt16  nWhichP,
 if ( pSortData ) theSortData = *pSortData;
 }
 
-ScSortItem::ScSortItem( const ScSortItem& rItem ) :
-SfxPoolItem ( rItem ),
-pViewData   ( rItem.pViewData ),
-theSortData ( rItem.theSortData )
-{
-}
-
-ScSortItem::~ScSortItem()
-{
-}
-
 bool ScSortItem::operator==( const SfxPoolItem& rItem ) const
 {
 assert(SfxPoolItem::operator==(rItem));
@@ -272,17 +261,6 @@ ScSubTotalItem::ScSubTotalItem( sal_uInt16 
 nWhichP,
 if (