Re: [Libreoffice-commits] core.git: 2 commits - editeng/source writerperfect/qa

2014-08-09 Thread David Tardon
Hi,

On Thu, Aug 07, 2014 at 01:06:18PM -0700, Caolán McNamara wrote:
 commit 8f2a714b60d35d7f17b317fa16ab4caac806e932
 Author: Caol??n McNamara caol...@redhat.com
 Date:   Thu Aug 7 20:55:17 2014 +0100
 
 add test-case for CVE-2007-1735
 
 Change-Id: If505b45bd197fb24a2bacaf44cb46f84de8b61ff
 
 diff --git 
 a/writerperfect/qa/unit/data/writer/libwpd/pass/CVE-2007-1735-1.wpd 
 b/writerperfect/qa/unit/data/writer/libwpd/pass/CVE-2007-1735-1.wpd
 new file mode 100644
 index 000..4d11b93
 Binary files /dev/null and 
 b/writerperfect/qa/unit/data/writer/libwpd/pass/CVE-2007-1735-1.wpd differ

The writerperfect import tests are supposed to test libreoffice
integration of the libraries, rather than the libraries themselves.
I.e., that the service that wraps a library can detect and load a
document (of every format that is enabled, for multi-format libs like
libmwaw). Every import library already has its own regression test suite
(http://sourceforge.net/p/libwpd/libwpd-regression/ci/master/tree/ for
libwpd) and specifc documents that need to be tested should preferably
go there.

On the other side, tests in libreoffice will be done on various
platforms, while the regression test suites are typically run only on
Linux/x86_64...

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 2 commits - editeng/source writerperfect/qa

2014-08-07 Thread Caolán McNamara
 editeng/source/editeng/eerdll.cxx |4 ++--
 writerperfect/qa/unit/data/writer/libwpd/pass/CVE-2007-1735-1.wpd |binary
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 48c5934af13710e83f094c5e2902787828065f51
Author: Caolán McNamara caol...@redhat.com
Date:   Thu Aug 7 21:04:37 2014 +0100

loplugin:staticcall

Change-Id: I966c0d6e61e1815252a83e22d142837e26302b30

diff --git a/editeng/source/editeng/eerdll.cxx 
b/editeng/source/editeng/eerdll.cxx
index af588fc..b317064 100644
--- a/editeng/source/editeng/eerdll.cxx
+++ b/editeng/source/editeng/eerdll.cxx
@@ -192,8 +192,8 @@ uno::Reference linguistic2::XLanguageGuessing  
GlobalEditData::GetLanguageGues
 return xLanguageGuesser;
 }
 
-EditResId::EditResId( sal_uInt16 nId ):
-ResId( nId, *EE_DLL().GetResMgr() )
+EditResId::EditResId(sal_uInt16 nId)
+: ResId(nId, *EditDLL::GetResMgr())
 {
 }
 
commit 8f2a714b60d35d7f17b317fa16ab4caac806e932
Author: Caolán McNamara caol...@redhat.com
Date:   Thu Aug 7 20:55:17 2014 +0100

add test-case for CVE-2007-1735

Change-Id: If505b45bd197fb24a2bacaf44cb46f84de8b61ff

diff --git a/writerperfect/qa/unit/data/writer/libwpd/pass/CVE-2007-1735-1.wpd 
b/writerperfect/qa/unit/data/writer/libwpd/pass/CVE-2007-1735-1.wpd
new file mode 100644
index 000..4d11b93
Binary files /dev/null and 
b/writerperfect/qa/unit/data/writer/libwpd/pass/CVE-2007-1735-1.wpd differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits