[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - svx/uiconfig
svx/uiconfig/ui/themecoloreditdialog.ui |1 + svx/uiconfig/ui/themedialog.ui |1 + 2 files changed, 2 insertions(+) New commits: commit 5964d5c49f00e5f2f48a3b69280d4c1ac979 Author: Caolán McNamara AuthorDate: Thu Jul 27 12:26:17 2023 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Sun Jul 30 03:37:45 2023 +0200 make the themeeditdialog and themedialog ui modal doesn't affect that they are run async Change-Id: I7336e64258f5042ee80acb7295b1ed7370be54b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154961 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/svx/uiconfig/ui/themecoloreditdialog.ui b/svx/uiconfig/ui/themecoloreditdialog.ui index bda8538ea082..0ebef71159e6 100644 --- a/svx/uiconfig/ui/themecoloreditdialog.ui +++ b/svx/uiconfig/ui/themecoloreditdialog.ui @@ -10,6 +10,7 @@ True 6 Theme Color Edit +True dialog diff --git a/svx/uiconfig/ui/themedialog.ui b/svx/uiconfig/ui/themedialog.ui index 6895f51dff24..2f16f0070d8f 100644 --- a/svx/uiconfig/ui/themedialog.ui +++ b/svx/uiconfig/ui/themedialog.ui @@ -8,6 +8,7 @@ True 6 Theme +True dialog
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - svx/uiconfig
svx/uiconfig/ui/themecoloreditdialog.ui | 12 1 file changed, 12 insertions(+) New commits: commit 6adc50c5848e2cd7f8b2f31d841485ff4447c930 Author: Caolán McNamara AuthorDate: Thu Jul 27 11:56:44 2023 +0100 Commit: Michael Stahl CommitDate: Fri Jul 28 10:30:45 2023 +0200 gtk: silence gtk_label_set_label: assertion 'GTK_IS_LABEL (label)' failed Change-Id: I7c6a4add9fe11ed123ce81302998ad246538c7fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154959 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/svx/uiconfig/ui/themecoloreditdialog.ui b/svx/uiconfig/ui/themecoloreditdialog.ui index 51e0be981ab6..bda8538ea082 100644 --- a/svx/uiconfig/ui/themecoloreditdialog.ui +++ b/svx/uiconfig/ui/themecoloreditdialog.ui @@ -149,6 +149,7 @@ False 0 True + @@ -168,6 +169,7 @@ False 0 True + @@ -187,6 +189,7 @@ False 0 True + @@ -274,6 +277,7 @@ False 0 True + @@ -327,6 +331,7 @@ False 0 True + @@ -346,6 +351,7 @@ False 0 True + @@ -433,6 +439,7 @@ False 0 True + @@ -452,6 +459,7 @@ False 0 True + @@ -471,6 +479,7 @@ False 0 True + @@ -490,6 +499,7 @@ False 0 True + @@ -543,6 +553,7 @@ False 0 True + @@ -562,6 +573,7 @@ False 0 True +
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - svx/uiconfig
svx/uiconfig/ui/accessibilitycheckentry.ui |1 - 1 file changed, 1 deletion(-) New commits: commit dbd05e732987304e7f69699aa1bf34f31ae18ac2 Author: Thorsten Behrens AuthorDate: Tue Jul 25 15:23:54 2023 +0200 Commit: Thorsten Behrens CommitDate: Wed Jul 26 01:23:44 2023 +0200 Revert "tdf#156137 - A11Y - Fix Long object names need to proper handling" This reverts commit d89dc4ac09d3c2bd55174f09485173057cc1403b. Reason for revert: GtkLinkButton.wrap is not available for native gtk widgets. Change-Id: Ie1634691996fb6d54b69013a585914d123d5e195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154913 Tested-by: Jenkins Reviewed-by: Thorsten Behrens (cherry picked from commit 0b415b64a09647f556bb24c7a09f9daec0b4ebc9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154916 diff --git a/svx/uiconfig/ui/accessibilitycheckentry.ui b/svx/uiconfig/ui/accessibilitycheckentry.ui index 3e364419fcdb..ea4b63c5fe88 100644 --- a/svx/uiconfig/ui/accessibilitycheckentry.ui +++ b/svx/uiconfig/ui/accessibilitycheckentry.ui @@ -37,7 +37,6 @@ True start True -True none
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - svx/uiconfig
svx/uiconfig/ui/accessibilitycheckentry.ui |1 + 1 file changed, 1 insertion(+) New commits: commit d8e9cf6c412874ce7185b98997afd7fb24820f71 Author: Balazs Varga AuthorDate: Fri Jul 21 15:55:33 2023 +0200 Commit: Michael Stahl CommitDate: Tue Jul 25 10:50:03 2023 +0200 tdf#156137 - A11Y - Fix Long object names need to proper handling Add text wrap option (long names ends with '...') for in case of proper handling of long GOTO GtkLinkButton objects in case of accessibility sidebar. Change-Id: I3c4af522fc34289ca57b1a7878134c34353bbc47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154726 Tested-by: Jenkins Reviewed-by: Thorsten Behrens (cherry picked from commit d89dc4ac09d3c2bd55174f09485173057cc1403b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154854 Reviewed-by: Michael Stahl diff --git a/svx/uiconfig/ui/accessibilitycheckentry.ui b/svx/uiconfig/ui/accessibilitycheckentry.ui index ea4b63c5fe88..3e364419fcdb 100644 --- a/svx/uiconfig/ui/accessibilitycheckentry.ui +++ b/svx/uiconfig/ui/accessibilitycheckentry.ui @@ -37,6 +37,7 @@ True start True +True none
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - svx/uiconfig sw/source sw/uiconfig
svx/uiconfig/ui/accessibilitycheckentry.ui| 20 +---
sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx | 22 +-
sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx |4 ++--
sw/uiconfig/swriter/ui/a11ycheckissuespanel.ui| 12 +++-
4 files changed, 43 insertions(+), 15 deletions(-)
New commits:
commit f4b8bfa2ff7c28b36fcc6ff266591186e1205781
Author: Samuel Mehrbrodt
AuthorDate: Mon Jun 5 16:14:35 2023 +0200
Commit: Samuel Mehrbrodt
CommitDate: Thu Jun 8 15:54:50 2023 +0200
tdf#155505 Improve display of individual entries
* Remove "Go to" button and link the issue text directly
* Improve layout a bit
Change-Id: I3b0dbe7fa5ee0f2fcaeddbf12533ba9169171a57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152621
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 40725c05ae1eee580a9b974363fd8921c65b5d17)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152669
diff --git a/svx/uiconfig/ui/accessibilitycheckentry.ui
b/svx/uiconfig/ui/accessibilitycheckentry.ui
index 19f14d8f3779..ea4b63c5fe88 100644
--- a/svx/uiconfig/ui/accessibilitycheckentry.ui
+++ b/svx/uiconfig/ui/accessibilitycheckentry.ui
@@ -5,13 +5,15 @@
True
False
-3
-3
+1
+1
+True
6
True
False
+6
True
True
True
@@ -23,21 +25,23 @@
-False
+True
True
0
-
-Go
to
+
True
True
True
+start
+True
+none
-False
-False
+True
+True
1
@@ -47,6 +51,8 @@
True
True
True
+end
+center
False
diff --git a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
index 1728ed58e266..123ce7e1fa57 100644
--- a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
+++ b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx
@@ -33,24 +33,36 @@ AccessibilityCheckEntry::AccessibilityCheckEntry(
: m_xBuilder(Application::CreateBuilder(pParent,
"svx/ui/accessibilitycheckentry.ui"))
, m_xContainer(m_xBuilder->weld_container("accessibilityCheckEntryBox"))
, m_xLabel(m_xBuilder->weld_label("accessibilityCheckEntryLabel"))
-,
m_xGotoButton(m_xBuilder->weld_button("accessibilityCheckEntryGotoButton"))
+,
m_xGotoButton(m_xBuilder->weld_link_button("accessibilityCheckEntryLinkButton"))
, m_xFixButton(m_xBuilder->weld_button("accessibilityCheckEntryFixButton"))
, m_pAccessibilityIssue(rAccessibilityIssue)
{
-m_xLabel->set_label(m_pAccessibilityIssue->m_aIssueText);
// lock in the height as including the button so all rows are the same
height
m_xContainer->set_size_request(-1,
m_xContainer->get_preferred_size().Height());
-m_xGotoButton->set_visible(m_pAccessibilityIssue->canGotoIssue());
-m_xGotoButton->connect_clicked(LINK(this, AccessibilityCheckEntry,
GotoButtonClicked));
+
+if (m_pAccessibilityIssue->canGotoIssue())
+{
+m_xGotoButton->set_label(m_pAccessibilityIssue->m_aIssueText);
+m_xGotoButton->connect_activate_link(
+LINK(this, AccessibilityCheckEntry, GotoButtonClicked));
+m_xLabel->set_visible(false);
+}
+else
+{
+m_xLabel->set_label(m_pAccessibilityIssue->m_aIssueText);
+m_xGotoButton->set_visible(false);
+}
+
m_xFixButton->set_visible(m_pAccessibilityIssue->canQuickFixIssue());
m_xFixButton->connect_clicked(LINK(this, AccessibilityCheckEntry,
FixButtonClicked));
m_pAccessibilityIssue->setParent(dynamic_cast(get_widget()));
}
-IMPL_LINK_NOARG(AccessibilityCheckEntry, GotoButtonClicked, weld::Button&,
void)
+IMPL_LINK_NOARG(AccessibilityCheckEntry, GotoButtonClicked, weld::LinkButton&,
bool)
{
m_pAccessibilityIssue->gotoIssue();
+return true;
}
IMPL_LINK_NOARG(AccessibilityCheckEntry, FixButtonClicked, weld::Button&, void)
diff --git a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx
b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx
index 1bea8eee98d9..d48f4cae2906 100644
--- a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx
+++ b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx
@@ -28,7 +28,7 @@ private:
std::unique_ptr m_xBuilder;
std::unique_ptr m_xContainer;
std::unique_ptr m_xLabel;
-std::unique_ptr m_xGotoButton;
+std::unique_ptr m_xGotoButton;
std::unique_ptr m_xFixButton;
std::shared_ptr const& m_pAccessibilityIssue;
@@ -39,7 +39,7 @@ public:
weld::Widget* get_widget() const { return m_xContainer.get(); }
-DECL_LINK(GotoButtonClicked, weld::Button&, void);
+DECL_LINK(GotoButtonClicked, weld::LinkButton&, bool);
DECL_LINK(FixButtonClicked, weld::Button&,
