[Libreoffice-commits] core.git: basctl/source basic/inc basic/source chart2/source comphelper/source compilerplugins/clang configmgr/source connectivity/source cppuhelper/source cppu/source cui/source

2022-04-13 Thread Noel Grandin (via logerrit) 
 basctl/source/basicide/moduldl2.cxx   |7 -
 basic/inc/sbxform.hxx |2 
 basic/source/classes/sbunoobj.cxx |4 
 basic/source/inc/sbunoobj.hxx |7 -
 basic/source/sbx/sbxform.cxx  |   21 ++--
 basic/source/sbx/sbxscan.cxx  |5 
 chart2/source/inc/ObjectIdentifier.hxx|2 
 chart2/source/tools/ObjectIdentifier.cxx  |   34 +++---
 comphelper/source/misc/storagehelper.cxx  |9 -
 compilerplugins/clang/stringviewparam.cxx |3 
 configmgr/source/components.cxx   |5 
 configmgr/source/components.hxx   |2 
 connectivity/source/drivers/mysqlc/mysqlc_general.cxx |   55 ++
 connectivity/source/drivers/mysqlc/mysqlc_general.hxx |2 
 connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx   |8 -
 connectivity/source/drivers/postgresql/pq_xcolumns.cxx|4 
 cppu/source/uno/EnvStack.cxx  |   13 +-
 cppu/source/uno/cascade_mapping.cxx   |   13 +-
 cppuhelper/source/servicemanager.cxx  |5 
 cppuhelper/source/servicemanager.hxx  |2 
 cppuhelper/source/typemanager.cxx |5 
 cppuhelper/source/typemanager.hxx |2 
 cui/source/dialogs/cuifmsearch.cxx|7 -
 cui/source/dialogs/multipat.cxx   |   13 +-
 cui/source/inc/cuifmsearch.hxx|2 
 cui/source/inc/multipat.hxx   |4 
 cui/source/inc/optpath.hxx|2 
 cui/source/options/optaboutconfig.cxx |5 
 cui/source/options/optaboutconfig.hxx |2 
 cui/source/options/optpath.cxx|   10 -
 dbaccess/source/core/api/KeySet.cxx   |2 
 dbaccess/source/core/api/KeySet.hxx   |2 
 dbaccess/source/core/dataaccess/documentcontainer.cxx |6 -
 dbaccess/source/core/misc/dsntypes.cxx|4 
 dbaccess/source/ui/app/AppDetailPageHelper.cxx|   13 +-
 dbaccess/source/ui/dlg/TextConnectionHelper.cxx   |4 
 dbaccess/source/ui/dlg/TextConnectionHelper.hxx   |2 
 dbaccess/source/ui/inc/TableWindowListBox.hxx |2 
 dbaccess/source/ui/inc/UITools.hxx|2 
 dbaccess/source/ui/misc/UITools.cxx   |   66 ++--
 dbaccess/source/ui/querydesign/TableWindowListBox.cxx |5 
 dbaccess/source/ui/tabledesign/TEditControl.cxx   |2 
 dbaccess/source/ui/tabledesign/TEditControl.hxx   |2 
 desktop/source/deployment/registry/dp_registry.cxx|4 
 desktop/source/lib/init.cxx   |6 -
 extensions/source/propctrlr/standardcontrol.cxx   |5 
 extensions/source/propctrlr/stringrepresentation.cxx  |   11 +-
 filter/source/config/cache/filtercache.cxx|5 
 filter/source/config/cache/filtercache.hxx|2 
 filter/source/config/cache/querytokenizer.cxx |   11 +-
 filter/source/config/cache/querytokenizer.hxx |2 
 filter/source/svg/svgfontexport.cxx   |5 
 filter/source/svg/svgfontexport.hxx   |2 
 forms/source/xforms/convert.cxx   |4 
 forms/source/xforms/submission/replace.cxx|   11 +-
 forms/source/xforms/submission/submission.hxx |2 
 framework/inc/dispatch/closedispatcher.hxx|4 
 framework/inc/services/layoutmanager.hxx  |2 
 framework/inc/uielement/menubarmerger.hxx |6 -
 framework/inc/uielement/statusbarmerger.hxx   |2 
 framework/inc/uielement/toolbarmerger.hxx |4 
 framework/source/accelerators/keymapping.cxx  |7 -
 framework/source/accelerators/storageholder.cxx   |5 
 framework/source/dispatch/closedispatcher.cxx |9 -
 framework/source/dispatch/dispatchinformationprovider.cxx |2 
 framework/source/fwe/classes/sfxhelperfunctions.cxx   |4 
 framework/source/inc/accelerators/keymapping.hxx  |2 
 framework/source/inc/accelerators/storageholder.hxx   |2 
 framework/source/layoutmanager/helpers.cxx|   27 ++---
 framework/source/layoutmanager/helpers.hxx|6 -
 framework/source/layoutmanager/layoutmanager.cxx  |   25 ++--
 framework/source/services/pathsettings.cxx|7 -
 framework/source/uielement/menubarmerger.cxx  |   11 +-

[Libreoffice-commits] core.git: basctl/source basic/inc basic/source chart2/source

2016-10-19 Thread Noel Grandin 
 basctl/source/basicide/breakpoint.cxx|   11 ++-
 basctl/source/basicide/breakpoint.hxx|1 -
 basctl/source/basicide/scriptdocument.cxx|8 +---
 basctl/source/inc/scriptdocument.hxx |6 --
 basic/inc/sbstdobj.hxx   |1 -
 basic/source/comp/exprgen.cxx|6 +++---
 basic/source/comp/exprnode.cxx   |4 ++--
 basic/source/inc/expr.hxx|9 -
 basic/source/runtime/stdobj1.cxx |2 +-
 chart2/source/controller/main/FeatureCommandDispatchBase.cxx |7 +--
 chart2/source/controller/main/FeatureCommandDispatchBase.hxx |3 ---
 chart2/source/inc/LifeTime.hxx   |5 ++---
 chart2/source/tools/LifeTime.cxx |2 +-
 chart2/source/view/inc/AbstractShapeFactory.hxx  |5 +
 chart2/source/view/main/AbstractShapeFactory.cxx |4 ++--
 15 files changed, 16 insertions(+), 58 deletions(-)

New commits:
commit f019ee7cf9e278cd8a27b1c36172ad4c8124080c
Author: Noel Grandin 
Date:   Tue Oct 18 11:55:32 2016 +0200

loplugin:expandablemethodds in basctl..chart2

Change-Id: I96f565a974fe3e316ae2ab04f8731b8bbfb87993
Reviewed-on: https://gerrit.libreoffice.org/29998
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/basctl/source/basicide/breakpoint.cxx 
b/basctl/source/basicide/breakpoint.cxx
index b3e6a70..3396a19 100644
--- a/basctl/source/basicide/breakpoint.cxx
+++ b/basctl/source/basicide/breakpoint.cxx
@@ -49,10 +49,8 @@ void BreakPointList::reset()
 
 void BreakPointList::transfer(BreakPointList & rList)
 {
-reset();
-for (size_t i = 0; i < rList.size(); ++i)
-maBreakPoints.push_back( rList.at( i ) );
-rList.clear();
+maBreakPoints.swap(rList.maBreakPoints);
+rList.reset();
 }
 
 void BreakPointList::InsertSorted(BreakPoint* pNewBrk)
@@ -159,11 +157,6 @@ const BreakPoint* BreakPointList::at(size_t i) const
 return i < maBreakPoints.size() ? maBreakPoints[ i ] : nullptr;
 }
 
-void BreakPointList::clear()
-{
-maBreakPoints.clear();
-}
-
 } // namespace basctl
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/basctl/source/basicide/breakpoint.hxx 
b/basctl/source/basicide/breakpoint.hxx
index 8431c30..2ade823 100644
--- a/basctl/source/basicide/breakpoint.hxx
+++ b/basctl/source/basicide/breakpoint.hxx
@@ -72,7 +72,6 @@ public:
 size_t size() const;
 BreakPoint* at(size_t i);
 const BreakPoint* at(size_t i) const;
-void clear();
 BreakPoint* remove(BreakPoint* ptr);
 };
 
diff --git a/basctl/source/basicide/scriptdocument.cxx 
b/basctl/source/basicide/scriptdocument.cxx
index 17d928d..a99fefa 100644
--- a/basctl/source/basicide/scriptdocument.cxx
+++ b/basctl/source/basicide/scriptdocument.cxx
@@ -1100,7 +1100,7 @@ namespace basctl
 {
 const ScriptDocument aCheck = ScriptDocument( doc->xModel );
 if  (   _rUrlOrCaption == aCheck.getTitle()
-||  _rUrlOrCaption == aCheck.getURL()
+||  _rUrlOrCaption == aCheck.m_pImpl->getURL()
 )
 {
 aDocument = aCheck;
@@ -1513,12 +1513,6 @@ namespace basctl
 }
 
 
-OUString ScriptDocument::getURL() const
-{
-return m_pImpl->getURL();
-}
-
-
 bool ScriptDocument::isActive() const
 {
 bool bIsActive( false );
diff --git a/basctl/source/inc/scriptdocument.hxx 
b/basctl/source/inc/scriptdocument.hxx
index 1a02436..6546799 100644
--- a/basctl/source/inc/scriptdocument.hxx
+++ b/basctl/source/inc/scriptdocument.hxx
@@ -471,12 +471,6 @@ namespace basctl
 */
 OUStringgetTitle() const;
 
-/** returns the URL of the document
-
-to be used for valid documents only
-*/
-OUStringgetURL() const;
-
 /** determines whether the document is currently the one-and-only 
application-wide active document
 */
 boolisActive() const;
diff --git a/basic/inc/sbstdobj.hxx b/basic/inc/sbstdobj.hxx
index b0840a8..7cc2258 100644
--- a/basic/inc/sbstdobj.hxx
+++ b/basic/inc/sbstdobj.hxx
@@ -90,7 +90,6 @@ public:
 bool IsUnderline() const { return bUnderline; }
 void SetSize( sal_uInt16 nS ) { nSize = nS; }
 sal_uInt16 GetSize() const { return nSize; }
-void SetFontName( const OUString& rName ) { aName = rName; }
 const OUString& GetFontName() const { return aName; }
 };
 
diff --git a/basic/source/comp/exprgen.cxx b/basic/source/comp/exprgen.cxx
index 7581d6e..1b06388 100644
--- a/basic/source/comp/exprgen.cxx
+++ b/basic/source/comp/exprgen.cxx
@@ -108,7 +108,7 @@ void