[Libreoffice-commits] core.git: compilerplugins/clang sc/source sw/source

2019-07-22 Thread Noel Grandin (via logerrit) 
 compilerplugins/clang/unusedfields.only-used-in-constructor.results |   76 ++--
 compilerplugins/clang/unusedfields.readonly.results |  104 
--
 compilerplugins/clang/unusedfields.untouched.results|  118 
---
 compilerplugins/clang/unusedfields.writeonly.results|  158 
+-
 sc/source/filter/xml/xmlexprt.cxx   |1 
 sc/source/filter/xml/xmlexprt.hxx   |1 
 sc/source/filter/xml/xmlsubti.cxx   |2 
 sc/source/filter/xml/xmlsubti.hxx   |1 
 sw/source/filter/inc/fltshell.hxx   |   10 
 9 files changed, 272 insertions(+), 199 deletions(-)

New commits:
commit ac933bb93a7afa8af10382cf2d47e64b31fe2567
Author: Noel Grandin 
AuthorDate: Mon Jul 22 13:35:21 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 23 07:49:07 2019 +0200

loplugin:unusedfields

Change-Id: If1e0b32f2cce7678f454009c0180d7612b4fb7c6
Reviewed-on: https://gerrit.libreoffice.org/76119
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git 
a/compilerplugins/clang/unusedfields.only-used-in-constructor.results 
b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index ca08d4cca7a5..8d2d4d9bb5d5 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -9,13 +9,11 @@ avmedia/source/vlc/wrapper/Types.hxx:44
 avmedia/source/vlc/wrapper/Types.hxx:45
 libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char *
 avmedia/source/vlc/wrapper/Types.hxx:46
-libvlc_event_t::(anonymous) padding struct (anonymous struct at 
/media/noel/disk2/libo5/avmedia/source/vlc/wrapper/Types.hxx:43:7)
+libvlc_event_t::(anonymous) padding struct (anonymous struct at 
/media/noel/disk3/libo6/avmedia/source/vlc/wrapper/Types.hxx:43:7)
 avmedia/source/vlc/wrapper/Types.hxx:47
-libvlc_event_t u union (anonymous union at 
/media/noel/disk2/libo5/avmedia/source/vlc/wrapper/Types.hxx:41:5)
+libvlc_event_t u union (anonymous union at 
/media/noel/disk3/libo6/avmedia/source/vlc/wrapper/Types.hxx:41:5)
 avmedia/source/vlc/wrapper/Types.hxx:53
 libvlc_track_description_t psz_name char *
-basctl/source/basicide/moduldlg.hxx:204
-basctl::OrganizeDialog m_aCurEntry class basctl::EntryDescriptor
 basegfx/source/polygon/b2dtrapezoid.cxx:202
 basegfx::trapezoidhelper::PointBlockAllocator maFirstStackBlock class 
basegfx::B2DPoint [32]
 basic/qa/cppunit/basictest.hxx:27
@@ -26,7 +24,7 @@ binaryurp/source/writer.hxx:148
 binaryurp::Writer state_ struct binaryurp::WriterState
 canvas/source/vcl/impltools.hxx:117
 vclcanvas::tools::LocalGuard aSolarGuard class SolarMutexGuard
-canvas/workben/canvasdemo.cxx:82
+canvas/workben/canvasdemo.cxx:83
 DemoRenderer maColorWhite uno::Sequence
 chart2/source/controller/accessibility/AccessibleChartShape.hxx:79
 chart::AccessibleChartShape m_aShapeTreeInfo 
::accessibility::AccessibleShapeTreeInfo
@@ -132,15 +130,15 @@ cppu/source/uno/check.cxx:138
 (anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3
 cui/source/dialogs/colorpicker.cxx:719
 cui::ColorPickerDialog m_aColorPrevious class cui::ColorPreviewControl
-cui/source/factory/dlgfact.cxx:1349
+cui/source/factory/dlgfact.cxx:1372
 SvxMacroAssignDialog m_aItems class SfxItemSet
 cui/source/inc/about.hxx:39
 AboutDialog m_pCloseButton weld::Button *
 cui/source/inc/cfgutil.hxx:238
 SvxScriptSelectorDialog m_aStylesInfo struct SfxStylesInfo_Impl
-cui/source/inc/cuitabarea.hxx:228
+cui/source/inc/cuitabarea.hxx:229
 SvxAreaTabPage maFixed_ChangeType enum ChangeType
-cui/source/inc/cuitabarea.hxx:236
+cui/source/inc/cuitabarea.hxx:237
 SvxAreaTabPage m_aXFillAttr class XFillAttrSetItem
 cui/source/inc/tabstpge.hxx:88
 SvxTabulatorTabPage m_aLeftWin class TabWin_Impl
@@ -174,7 +172,7 @@ drawinglayer/source/tools/emfphelperdata.hxx:153
 emfplushelper::EmfPlusHelperData mnFrameRight sal_Int32
 drawinglayer/source/tools/emfphelperdata.hxx:154
 emfplushelper::EmfPlusHelperData mnFrameBottom sal_Int32
-editeng/source/editeng/impedit.hxx:462
+editeng/source/editeng/impedit.hxx:465
 ImpEditEngine aSelFuncSet class EditSelFunctionSet
 filter/source/flash/swfwriter.hxx:391
 swf::Writer maMovieTempFile utl::TempFile
@@ -198,11 +196,11 @@ include/drawinglayer/texture/texture3d.hxx:62
 drawinglayer::texture::GeoTexSvxBitmapEx maBitmap class Bitmap
 include/drawinglayer/texture/texture3d.hxx:64
 drawinglayer::texture::GeoTexSvxBitmapEx maTransparence class Bitmap
-include/filter/msfilter/svdfppt.hxx:881
+include/filter/msfilter/svdfppt.hxx:880
 ImplPPTParaPropSet nDontKnow1 sal_uInt32
-include/filter/msfilter/svdfppt.hxx:882
+include/filter/msfilter/svdfppt.hxx:881
 ImplPPTParaPropSet nDontKnow2

[Libreoffice-commits] core.git: compilerplugins/clang sc/source sw/source

2018-02-01 Thread Noel Grandin 
 compilerplugins/clang/singlevalfields.cxx |8 -
 compilerplugins/clang/singlevalfields.results |   82 ++
 sc/source/filter/excel/xechart.cxx|5 
 sc/source/filter/inc/xcl97rec.hxx |2 
 sc/source/filter/inc/xechart.hxx  |1 
 sc/source/filter/xcl97/xcl97rec.cxx   |4 
 sw/source/core/inc/UndoNumbering.hxx  |1 
 sw/source/core/undo/unnum.cxx |   13 --
 sw/source/filter/html/svxcss1.cxx |  143 +++---
 sw/source/filter/html/svxcss1.hxx |5 
 10 files changed, 110 insertions(+), 154 deletions(-)

New commits:
commit 98864543c099027cc3dbedc0389ed46cefe4713e
Author: Noel Grandin 
Date:   Thu Feb 1 12:45:48 2018 +0200

loplugin:singlevalfields

Change-Id: I346f236e28cb0bd064a7d757b187e5e64544700f
Reviewed-on: https://gerrit.libreoffice.org/49086
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/compilerplugins/clang/singlevalfields.cxx 
b/compilerplugins/clang/singlevalfields.cxx
index 83733b7a0041..edf35e5f3cb2 100644
--- a/compilerplugins/clang/singlevalfields.cxx
+++ b/compilerplugins/clang/singlevalfields.cxx
@@ -31,7 +31,7 @@ Note that the actual process may involve a fair amount of 
undoing, hand editing,
 to get it to work :-)
 
 @TODO we don't spot fields that have been zero-initialised via calloc or 
rtl_allocateZeroMemory or memset
-@TODO calls to lambdas (see FIXME near CXXOperatorCallExpr)
+@TODO calls to lambdas where a reference to the field is taken
 
 */
 
@@ -310,12 +310,6 @@ bool SingleValFields::VisitMemberExpr( const MemberExpr* 
memberExpr )
 child = parent;
 parent = getParentStmt(parent);
 }
-else if (isa(parent))
-{
-// FIXME need to handle this properly
-bPotentiallyAssignedTo = true;
-break;
-}
 else if (isa(parent))
 {
 checkCallExpr(child, dyn_cast(parent), assignValue, 
bPotentiallyAssignedTo);
diff --git a/compilerplugins/clang/singlevalfields.results 
b/compilerplugins/clang/singlevalfields.results
index d54fac80e7c9..03a32af65333 100644
--- a/compilerplugins/clang/singlevalfields.results
+++ b/compilerplugins/clang/singlevalfields.results
@@ -4,7 +4,7 @@ chart2/source/model/main/DataPoint.hxx:107
 chart2/source/view/inc/GL3DRenderer.hxx:161
 chart::opengl3D::TextInfoBatch batchNum
 512
-include/basic/sbxvar.hxx:67
+include/basic/sbxvar.hxx:70
 SbxValues::(anonymous) pData
 0
 include/editeng/charsetcoloritem.hxx:35
@@ -25,18 +25,6 @@ include/svtools/svparser.hxx:74
 include/svtools/svparser.hxx:75
 SvParser::TokenStackType bTokenHasValue
 0
-include/tools/multisel.hxx:41
-MultiSelection bInverseCur
-0
-include/unotools/textsearch.hxx:104
-utl::SearchParam m_bWordOnly
-0
-include/unotools/textsearch.hxx:105
-utl::SearchParam m_bSrchInSel
-0
-include/unotools/textsearch.hxx:110
-utl::SearchParam nTransliterationFlags
-0
 include/vcl/filter/pdfdocument.hxx:173
 vcl::filter::PDFNameElement m_nLength
 0
@@ -61,10 +49,10 @@ include/vcl/pdfwriter.hxx:559
 libreofficekit/source/gtk/lokdocview.cxx:84
 LOKDocViewPrivateImpl m_bIsLoading
 0
-opencl/source/opencl_device.cxx:53
+opencl/source/opencl_device.cxx:54
 (anonymous namespace)::LibreOfficeDeviceEvaluationIO inputSize
 15360
-opencl/source/opencl_device.cxx:54
+opencl/source/opencl_device.cxx:55
 (anonymous namespace)::LibreOfficeDeviceEvaluationIO outputSize
 15360
 pyuno/source/module/pyuno_impl.hxx:312
@@ -79,6 +67,12 @@ sc/inc/compiler.hxx:108
 sc/qa/unit/ucalc.hxx:41
 Test::RangeNameDef mnIndex
 1
+sc/source/filter/inc/xcl97rec.hxx:272
+ExcBof8_Base nLowestBiffVer
+6
+sc/source/filter/inc/xechart.hxx:859
+XclExpChDropBar mnBarDist
+100
 sd/inc/sdpptwrp.hxx:42
 SdPPTFilter pBas
 0
@@ -106,10 +100,10 @@ soltools/mkdepend/def.h:130
 soltools/mkdepend/def.h:132
 inclist i_searched
 1
-stoc/source/inspect/introspection.cxx:1533
+stoc/source/inspect/introspection.cxx:1530
 (anonymous namespace)::Cache::Data hits
 1
-sw/inc/hints.hxx:195
+sw/inc/hints.hxx:189
 SwAttrSetChg m_bDelSet
 0
 sw/inc/pagepreviewlayout.hxx:49
@@ -118,9 +112,9 @@ sw/inc/pagepreviewlayout.hxx:49
 sw/source/core/inc/frmtool.hxx:260
 SwBorderAttrs m_bBorderDist
 1
-sw/source/core/inc/swfont.hxx:170
-SwFont m_bURL
-0
+sw/source/core/inc/UndoNumbering.hxx:33
+SwUndoInsNum nSttSet
+18446744073709551615
 sw/source/core/inc/UndoSort.hxx:38
 SwSortUndoElement::(anonymous union)::(anonymous) nKenn
 4294967295
@@ -133,9 +127,12 @@ sw/source/filter/html/htmlcss1.cxx:78
 sw/source/filter/html/htmlcss1.cxx:79
 SwCSS1ItemIds nFormatKeep
 109
-sw/source/filter/html/svxcss1.hxx:199