filter/source/config/cache/querytokenizer.hxx | 2 +- framework/inc/dispatch/closedispatcher.hxx | 6 +++--- framework/source/dispatch/closedispatcher.cxx | 4 ++-- framework/source/dispatch/mailtodispatcher.cxx | 2 +- framework/source/dispatch/servicehandler.cxx | 2 +- framework/source/inc/accelerators/keymapping.hxx | 2 +- framework/source/inc/accelerators/presethandler.hxx | 4 ++-- framework/source/inc/loadenv/loadenv.hxx | 2 +- framework/source/loadenv/loadenv.cxx | 2 +- framework/source/services/autorecovery.cxx | 2 +- framework/source/services/desktop.cxx | 2 +- framework/source/services/frame.cxx | 2 +- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java | 2 +- odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java | 6 +++--- offapi/com/sun/star/frame/DispatchResultState.idl | 2 +- offapi/com/sun/star/frame/XController.idl | 2 +- offapi/com/sun/star/task/XJob.idl | 2 +- offapi/com/sun/star/task/XJobListener.idl | 2 +- offapi/com/sun/star/util/XURLTransformer.idl | 4 ++-- 19 files changed, 26 insertions(+), 26 deletions(-)
New commits: commit 3fce6ae224efb5f8bdf78ef83f89be11dafabf3a Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Tue Apr 16 11:17:10 2019 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Tue Apr 16 12:46:55 2019 +0200 fix usage of successful/successfully in comments Change-Id: If280e1e944c877462cb84b579e19d4fd2ad1900b Reviewed-on: https://gerrit.libreoffice.org/70813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/filter/source/config/cache/querytokenizer.hxx b/filter/source/config/cache/querytokenizer.hxx index 149ddba60552..8f2433f88867 100644 --- a/filter/source/config/cache/querytokenizer.hxx +++ b/filter/source/config/cache/querytokenizer.hxx @@ -84,7 +84,7 @@ class QueryTokenizer : public std::unordered_map< OUString, OUString > /** @short can be used to check if analyzing of given query - was successfully or not. + was successful or not. */ bool valid() const; }; diff --git a/framework/inc/dispatch/closedispatcher.hxx b/framework/inc/dispatch/closedispatcher.hxx index 9aed7b5ae2cc..c6556259818f 100644 --- a/framework/inc/dispatch/closedispatcher.hxx +++ b/framework/inc/dispatch/closedispatcher.hxx @@ -176,7 +176,7 @@ class CloseDispatcher : public ::cppu::WeakImplHelper< We need it to implement the CLOSE_DOC semantic. @return [boolean] - sal_True if closing was successfully. + sal_True if closing was successful. */ bool implts_prepareFrameForClosing(const css::uno::Reference< css::frame::XFrame >& xFrame, bool bCloseAllOtherViewsToo, @@ -194,7 +194,7 @@ class CloseDispatcher : public ::cppu::WeakImplHelper< frame is closed .... @return [bool] - sal_True if closing was successfully. + sal_True if closing was successful. */ bool implts_closeFrame(); @@ -202,7 +202,7 @@ class CloseDispatcher : public ::cppu::WeakImplHelper< as new component of our m_xCloseFrame. @return [bool] - sal_True if operation was successfully. + sal_True if operation was successful. */ bool implts_establishBackingMode(); diff --git a/framework/source/dispatch/closedispatcher.cxx b/framework/source/dispatch/closedispatcher.cxx index d3c77c970fde..f6ac18d400ab 100644 --- a/framework/source/dispatch/closedispatcher.cxx +++ b/framework/source/dispatch/closedispatcher.cxx @@ -140,8 +140,8 @@ void SAL_CALL CloseDispatcher::dispatchWithNotification(const css::util::URL& // our asynchronous process was not finished yet. // We have to reject double calls. Otherwise we risk, // that we try to close an already closed resource ... - // And its no problem to do nothing then. The UI user will try it again, if - // non of these jobs was successfully. + // And it is no problem to do nothing then. The UI user will try it again, if + // non of these jobs was successful. if (m_xSelfHold.is()) { aWriteLock.clear(); diff --git a/framework/source/dispatch/mailtodispatcher.cxx b/framework/source/dispatch/mailtodispatcher.cxx index e2aabd3af857..696291e20f9f 100644 --- a/framework/source/dispatch/mailtodispatcher.cxx +++ b/framework/source/dispatch/mailtodispatcher.cxx @@ -170,7 +170,7 @@ void SAL_CALL MailToDispatcher::dispatchWithNotification( const css::util::URL& @return <TRUE/> if dispatch could be started successfully Note: Our internal used shell executor doesn't return any state value - so we must - believe that call was successfully. + believe that call was successful. <FALSE/> if necessary resource couldn't be created or an exception was thrown. */ bool MailToDispatcher::implts_dispatch( const css::util::URL& aURL ) diff --git a/framework/source/dispatch/servicehandler.cxx b/framework/source/dispatch/servicehandler.cxx index cc4653dce95c..05b20432cd60 100644 --- a/framework/source/dispatch/servicehandler.cxx +++ b/framework/source/dispatch/servicehandler.cxx @@ -172,7 +172,7 @@ void SAL_CALL ServiceHandler::dispatchWithNotification( const css::util::URL& @return <NULL/> if requested service couldn't be created successfully; a valid reference otherwise. This return value can be used to indicate, - if dispatch was successfully or not. + if dispatch was successful. */ css::uno::Reference< css::uno::XInterface > ServiceHandler::implts_dispatch( const css::util::URL& aURL ) { diff --git a/framework/source/inc/accelerators/keymapping.hxx b/framework/source/inc/accelerators/keymapping.hxx index 9ce8cdcd8ed7..108cee42e56d 100644 --- a/framework/source/inc/accelerators/keymapping.hxx +++ b/framework/source/inc/accelerators/keymapping.hxx @@ -118,7 +118,7 @@ class KeyMapping if this method returns sal_True! @return [boolean] - sal_True if conversion was successfully. + sal_True if conversion was successful. */ bool impl_st_interpretIdentifierAsPureKeyCode(const OUString& sIdentifier, sal_uInt16& rCode ); diff --git a/framework/source/inc/accelerators/presethandler.hxx b/framework/source/inc/accelerators/presethandler.hxx index b41593d41bee..55532b8a2a3f 100644 --- a/framework/source/inc/accelerators/presethandler.hxx +++ b/framework/source/inc/accelerators/presethandler.hxx @@ -297,7 +297,7 @@ class PresetHandler @param bShare force using of the share layer instead of the user layer. - @return An opened storage in case method was successfully - null otherwise. + @return An opened storage in case method was successful - null otherwise. */ css::uno::Reference< css::embed::XStorage > impl_openPathIgnoringErrors(const OUString& sPath , sal_Int32 eMode , @@ -354,7 +354,7 @@ class PresetHandler @param bAllowFallback enable/disable fallback handling for locales - @return An opened storage in case method was successfully - null otherwise. + @return An opened storage in case method was successful - null otherwise. */ css::uno::Reference< css::embed::XStorage > impl_openLocalizedPathIgnoringErrors(OUString& sPath , sal_Int32 eMode , diff --git a/framework/source/inc/loadenv/loadenv.hxx b/framework/source/inc/loadenv/loadenv.hxx index 597631488d82..4c8c148e41e9 100644 --- a/framework/source/inc/loadenv/loadenv.hxx +++ b/framework/source/inc/loadenv/loadenv.hxx @@ -293,7 +293,7 @@ public: @descr The timeout parameter can be used to wait some times only or forever. The return value indicates if the load request was finished during the specified timeout period. - But it indicates not, if the load request was successfully or not! + But it indicates not, if the load request was successful or not! @param nTimeout specify a timeout in [ms]. diff --git a/framework/source/loadenv/loadenv.cxx b/framework/source/loadenv/loadenv.cxx index 7855a5cd2072..e70f771eb053 100644 --- a/framework/source/loadenv/loadenv.cxx +++ b/framework/source/loadenv/loadenv.cxx @@ -758,7 +758,7 @@ void LoadEnv::impl_detectTypeAndFilter() // SAFE -> osl::ResettableMutexGuard aWriteLock(m_mutex); - // detection was successfully => update the descriptor member of this class + // detection was successful => update the descriptor member of this class m_lMediaDescriptor << lDescriptor; m_lMediaDescriptor[utl::MediaDescriptor::PROP_TYPENAME()] <<= sType; // Is there an already detected (may be preselected) filter? diff --git a/framework/source/services/autorecovery.cxx b/framework/source/services/autorecovery.cxx index 3f6098efef69..2f0922c02f09 100644 --- a/framework/source/services/autorecovery.cxx +++ b/framework/source/services/autorecovery.cxx @@ -737,7 +737,7 @@ private: Note further: it patches the info struct more than ones. E.g. the new temp URL is set before the file is saved. And the old URL is removed - only if removing of the old file was successfully. + only if removing of the old file was successful. If this method returns without an exception - everything was OK. Otherwise the info struct can be analyzed to get more information, e.g. when the problem occurs. diff --git a/framework/source/services/desktop.cxx b/framework/source/services/desktop.cxx index 964ca410945f..56d0b6886e3e 100644 --- a/framework/source/services/desktop.cxx +++ b/framework/source/services/desktop.cxx @@ -598,7 +598,7 @@ css::uno::Reference< css::frame::XFrame > SAL_CALL Desktop::getCurrentFrame() @param "sTargetFrameName" , name of target frame or special value like "_self", "_blank" ... @param "nSearchFlags" , optional arguments for frame search, if target isn't a special one @param "lArguments" , optional arguments for loading - @return A valid component reference, if loading was successfully. + @return A valid component reference, if loading was successful. A null reference otherwise. @onerror We return a null reference. diff --git a/framework/source/services/frame.cxx b/framework/source/services/frame.cxx index 2396ac9db8a0..ec44c24efd33 100644 --- a/framework/source/services/frame.cxx +++ b/framework/source/services/frame.cxx @@ -570,7 +570,7 @@ void XFrameImpl::initListeners() @param "sTargetFrameName" , name of target frame or special value like "_self", "_blank" ... @param "nSearchFlags" , optional arguments for frame search, if target is not a special one @param "lArguments" , optional arguments for loading - @return A valid component reference, if loading was successfully. + @return A valid component reference, if loading was successful. A null reference otherwise. @onerror We return a null reference. diff --git a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java index d45cb408548b..9388181f3b15 100644 --- a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java +++ b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java @@ -71,7 +71,7 @@ public class OfficeConnect /** * ctor * We try to open the connection in our ctor ... transparently for user. - * After it was successfully you will find an internal set member + * After it was successful you will find an internal set member * m_xRemoteContext which means remote component context of the connected office. * The context can be used to get the remote service manager from the office. * We made it private to support singleton pattern of these implementation. diff --git a/odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java b/odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java index 21dca2ec4c6e..e9fa03afdec0 100644 --- a/odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java +++ b/odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java @@ -321,7 +321,7 @@ public class AsciiReplaceFilter * @param lDescriptor * the MediaDescriptor which describes the document * - * @return a bool value which describes if method was successfully or not. + * @return a bool value which describes if method was successful. */ public boolean filter( com.sun.star.beans.PropertyValue[] lDescriptor ) @@ -406,7 +406,7 @@ public class AsciiReplaceFilter * capsulate all other necessary information for this filter request * (streams, replace values ...) * - * @return a bool value which describes if method was successfully or not. + * @return a bool value which describes if method was successful. */ private boolean implts_import( com.sun.star.text.XTextDocument xTarget , FilterOptions aOptions ) @@ -538,7 +538,7 @@ public class AsciiReplaceFilter * capsulate all other necessary information for this filter request * (streams, replace values ...) * - * @return a bool value which describes if method was successfully or not. + * @return a bool value which describes if method was successful. */ private boolean implts_export( com.sun.star.text.XTextDocument xSource , FilterOptions aOptions) diff --git a/offapi/com/sun/star/frame/DispatchResultState.idl b/offapi/com/sun/star/frame/DispatchResultState.idl index 8b117621c09e..e0658dd2eff6 100644 --- a/offapi/com/sun/star/frame/DispatchResultState.idl +++ b/offapi/com/sun/star/frame/DispatchResultState.idl @@ -31,7 +31,7 @@ published constants DispatchResultState */ const short FAILURE = 0; - /** indicates: dispatch was successfully + /** indicates: dispatch was successful */ const short SUCCESS = 1; diff --git a/offapi/com/sun/star/frame/XController.idl b/offapi/com/sun/star/frame/XController.idl index d8b52b8da83b..0e07f60eec55 100644 --- a/offapi/com/sun/star/frame/XController.idl +++ b/offapi/com/sun/star/frame/XController.idl @@ -49,7 +49,7 @@ published interface XController: com::sun::star::lang::XComponent the new model for this controller @return - `TRUE` If attaching was successfully + `TRUE` If attaching was successful <br> `FALSE` Otherwise */ diff --git a/offapi/com/sun/star/task/XJob.idl b/offapi/com/sun/star/task/XJob.idl index bedced7058b1..8300306a93bf 100644 --- a/offapi/com/sun/star/task/XJob.idl +++ b/offapi/com/sun/star/task/XJob.idl @@ -53,7 +53,7 @@ published interface XJob : com::sun::star::uno::XInterface But it should be possible to <ul> <li>deregister the job</li> - <li>let him registered although execution was successfully(!)</li> + <li>let him registered although execution was successful(!)</li> <li>make some job specific data persistent inside the job configuration which is provided by the executor.</li> </ul> diff --git a/offapi/com/sun/star/task/XJobListener.idl b/offapi/com/sun/star/task/XJobListener.idl index 15cf9d56d19f..9b40682823f2 100644 --- a/offapi/com/sun/star/task/XJobListener.idl +++ b/offapi/com/sun/star/task/XJobListener.idl @@ -45,7 +45,7 @@ published interface XJobListener : com::sun::star::lang::XEventListener <ul> <li>deregister the job</li> - <li>let him registered although execution was successfully(!)</li> + <li>let him registered although execution was successful(!)</li> <li>make some job specific data persistent inside the job configuration which is provided by the executor.</li> </ul> diff --git a/offapi/com/sun/star/util/XURLTransformer.idl b/offapi/com/sun/star/util/XURLTransformer.idl index e6d2b0212872..89f75f71d00b 100644 --- a/offapi/com/sun/star/util/XURLTransformer.idl +++ b/offapi/com/sun/star/util/XURLTransformer.idl @@ -49,7 +49,7 @@ published interface XURLTransformer: com::sun::star::uno::XInterface can be overwritten if the implementation corrected minor failures. @returns - `TRUE` if parsing was successfully (means if given URL was syntactically correct) + `TRUE` if parsing was successful (means if given URL was syntactically correct) or `FALSE` otherwise. */ boolean parseStrict( [inout] com::sun::star::util::URL aURL ); @@ -91,7 +91,7 @@ published interface XURLTransformer: com::sun::star::uno::XInterface URL::Complete is not defined. @returns - `TRUE` if assembling was successfully or `FALSE` otherwise. + `TRUE` if assembling was successful or `FALSE` otherwise. */ boolean assemble( [inout] com::sun::star::util::URL aURL ); _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits