[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2019-07-09 Thread Gabor Kelemen (via logerrit) 
 sc/IwyuFilter_sc.yaml |3 ---
 sc/inc/TablePivotChart.hxx|1 +
 sc/inc/addruno.hxx|2 ++
 sc/inc/afmtuno.hxx|2 ++
 sc/inc/attrib.hxx |1 -
 sc/inc/autoform.hxx   |   20 ++--
 sc/inc/calcmacros.hxx |2 --
 sc/inc/chartuno.hxx   |1 +
 sc/inc/conditio.hxx   |1 -
 sc/inc/dociter.hxx|2 ++
 sc/inc/dpobject.hxx   |1 +
 sc/inc/dpoutput.hxx   |2 +-
 sc/inc/matrixoperators.hxx|2 ++
 sc/inc/orcusxml.hxx   |1 -
 sc/inc/refhint.hxx|2 +-
 sc/inc/scerrors.hrc   |1 +
 sc/inc/scopetools.hxx |1 -
 sc/inc/sheetdata.hxx  |1 +
 sc/inc/unitconv.hxx   |2 ++
 sc/inc/units.hrc  |4 
 sc/inc/userlist.hxx   |2 ++
 sc/inc/viewuno.hxx|2 ++
 sc/inc/waitoff.hxx|2 ++
 sc/source/core/data/global.cxx|1 +
 sc/source/core/tool/autoform.cxx  |   18 ++
 sc/source/ui/docshell/docfunc.cxx |1 +
 sc/source/ui/miscdlgs/autofmt.cxx |2 ++
 sc/source/ui/unoobj/afmtuno.cxx   |4 
 sc/source/ui/view/viewfun2.cxx|1 +
 29 files changed, 56 insertions(+), 29 deletions(-)

New commits:
commit f6e72cf4f70ac4f7bc6ace7c0cdb5e2afa13199a
Author: Gabor Kelemen 
AuthorDate: Tue Jul 2 00:40:24 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Jul 9 09:20:34 2019 +0200

tdf#42949 Fix IWYU warnings in sc/inc

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

New IWYU and recent developments in f-u-i helped to identify
some non self contained files, those were fixed too.

Change-Id: I3b33b0dee7d7c9afc136510898039cab53990ddf
Reviewed-on: https://gerrit.libreoffice.org/74980
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 97ffa6b09a50..9b2bf6629b06 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -32,9 +32,6 @@ blacklist:
 - com/sun/star/sheet/XFunctionDescriptions.hpp
 - com/sun/star/sheet/XGlobalSheetSettings.hpp
 - com/sun/star/sheet/XRecentFunctions.hpp
-sc/inc/autoform.hxx:
-# contains macro definitions
-- scitems.hxx
 sc/inc/chartuno.hxx:
 # base class has to be a complete type
 - com/sun/star/container/XEnumerationAccess.hpp
diff --git a/sc/inc/TablePivotChart.hxx b/sc/inc/TablePivotChart.hxx
index a99711c37845..c357c6fad230 100644
--- a/sc/inc/TablePivotChart.hxx
+++ b/sc/inc/TablePivotChart.hxx
@@ -16,6 +16,7 @@
 #include 
 
 #include 
+#include 
 #include 
 
 #include "types.hxx"
diff --git a/sc/inc/addruno.hxx b/sc/inc/addruno.hxx
index 62a0e7c8b0b8..7503f865677c 100644
--- a/sc/inc/addruno.hxx
+++ b/sc/inc/addruno.hxx
@@ -26,6 +26,8 @@
 #include 
 #include "address.hxx"
 
+#include 
+
 class ScAddressConversionObj : public ::cppu::WeakImplHelper<
 css::beans::XPropertySet,
 css::lang::XServiceInfo >,
diff --git a/sc/inc/afmtuno.hxx b/sc/inc/afmtuno.hxx
index d39e5e41a294..ff997b6e95ca 100644
--- a/sc/inc/afmtuno.hxx
+++ b/sc/inc/afmtuno.hxx
@@ -31,6 +31,8 @@
 #include 
 #include 
 
+#include 
+
 class ScAutoFormatFieldObj;
 class ScAutoFormatObj;
 
diff --git a/sc/inc/attrib.hxx b/sc/inc/attrib.hxx
index 37340e786fe2..a98578abcb23 100644
--- a/sc/inc/attrib.hxx
+++ b/sc/inc/attrib.hxx
@@ -21,7 +21,6 @@
 #define INCLUDED_SC_INC_ATTRIB_HXX
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/sc/inc/autoform.hxx b/sc/inc/autoform.hxx
index 8fad143b8400..43f22b107c62 100644
--- a/sc/inc/autoform.hxx
+++ b/sc/inc/autoform.hxx
@@ -30,25 +30,9 @@
 !!
 **/
 
-#include "scitems.hxx"
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
+#include 
 #include 
-#include 
-#include 
+
 #include "scdllapi.h"
 #include "zforauto.hxx"
 
diff --git a/sc/inc/calcmacros.hxx b/sc/inc/calcmacros.hxx
index d5cffd5db88b..ca51c62adb54 100644
--- a/sc/inc/calcmacros.hxx
+++ b/sc/inc/calcmacros.hxx
@@ -30,8 +30,6 @@
 DEBUG_FORMULA_COMPILER || \
 DEBUG_AREA_BROADCASTER
 #include 
-#include 
-#include 
 using std::cout;
 using std::cerr;
 using std::endl;
diff --git a/sc/inc/chartuno.hxx b/sc/inc/chartuno.hxx
index 801a9d99db93..3e40ead05d40 100644
--- a/sc/inc/chartuno.hxx
+++ b/sc/inc/chartuno.hxx
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx
index 42448174ca52..0ab1d114f8f4 100644
---

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2019-07-04 Thread Gabor Kelemen (via logerrit) 
 sc/IwyuFilter_sc.yaml   |   13 ++-
 sc/inc/miscuno.hxx  |1 
 sc/inc/scitems.hxx  |4 +++
 sc/source/ui/unoobj/ChartRangeSelectionListener.cxx |1 
 sc/source/ui/unoobj/ChartTools.cxx  |8 ---
 sc/source/ui/unoobj/PivotTableDataProvider.cxx  |2 -
 sc/source/ui/unoobj/PivotTableDataSequence.cxx  |4 ---
 sc/source/ui/unoobj/PivotTableDataSource.cxx|1 
 sc/source/ui/unoobj/TablePivotChart.cxx |1 
 sc/source/ui/unoobj/TablePivotCharts.cxx|6 -
 sc/source/ui/unoobj/addruno.cxx |1 
 sc/source/ui/unoobj/afmtuno.cxx |   22 
 sc/source/ui/unoobj/appluno.cxx |4 ---
 sc/source/ui/unoobj/cellsuno.cxx|6 -
 sc/source/ui/unoobj/chart2uno.cxx   |8 ---
 sc/source/ui/unoobj/chartuno.cxx|3 --
 sc/source/ui/unoobj/condformatuno.cxx   |1 
 sc/source/ui/unoobj/confuno.cxx |6 -
 sc/source/ui/unoobj/convuno.cxx |1 
 sc/source/ui/unoobj/cursuno.cxx |5 
 sc/source/ui/unoobj/dapiuno.cxx |6 +
 sc/source/ui/unoobj/datauno.cxx |1 
 sc/source/ui/unoobj/defltuno.cxx|4 ---
 sc/source/ui/unoobj/docuno.cxx  |   14 ++--
 sc/source/ui/unoobj/editsrc.cxx |8 ---
 sc/source/ui/unoobj/exceldetect.cxx |6 -
 sc/source/ui/unoobj/fielduno.cxx|2 -
 sc/source/ui/unoobj/filtuno.cxx |2 -
 sc/source/ui/unoobj/fmtuno.cxx  |2 -
 sc/source/ui/unoobj/funcuno.cxx |3 --
 sc/source/ui/unoobj/linkuno.cxx |3 --
 sc/source/ui/unoobj/nameuno.cxx |1 
 sc/source/ui/unoobj/notesuno.cxx|2 -
 sc/source/ui/unoobj/scdetect.cxx|2 -
 sc/source/ui/unoobj/servuno.cxx |4 ---
 sc/source/ui/unoobj/shapeuno.cxx|3 --
 sc/source/ui/unoobj/srchuno.cxx |5 
 sc/source/ui/unoobj/styleuno.cxx|7 --
 sc/source/ui/unoobj/targuno.cxx |3 --
 sc/source/ui/unoobj/textuno.cxx |7 --
 sc/source/ui/unoobj/tokenuno.cxx|2 -
 sc/source/ui/unoobj/unodoc.cxx  |2 -
 sc/source/ui/unoobj/viewuno.cxx |5 
 sc/source/ui/unoobj/warnpassword.cxx|3 --
 44 files changed, 29 insertions(+), 166 deletions(-)

New commits:
commit f3bf306eb9368c66df9817888739c4c4d3b2a9db
Author: Gabor Kelemen 
AuthorDate: Sun Jun 16 23:30:05 2019 +0200
Commit: Miklos Vajna 
CommitDate: Thu Jul 4 09:46:34 2019 +0200

tdf#42949 Fix IWYU warnings in sc/source/ui/unoobj/*

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9b4111f2b4ccea71a491f2412f0d02ce5a7f64f7
Reviewed-on: https://gerrit.libreoffice.org/74570
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 2508c5b6f78e..97ffa6b09a50 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -873,4 +873,15 @@ blacklist:
 sc/source/ui/undo/undoolk.cxx:
 # Avoid loplugin:unreffun error
 - undoolk.hxx
-
+sc/source/ui/unoobj/cellsuno.cxx:
+# Needed for direct member access
+- refundo.hxx
+sc/source/ui/unoobj/confuno.cxx:
+# Used with function template
+- docpool.hxx
+sc/source/ui/unoobj/notesuno.cxx:
+# Needed for macro defines
+- editeng/unoprnms.hxx
+sc/source/ui/unoobj/textuno.cxx:
+# Needed for macro defines
+- editeng/unoprnms.hxx
diff --git a/sc/inc/miscuno.hxx b/sc/inc/miscuno.hxx
index 365db0ace50b..2fe74f0dfe1a 100644
--- a/sc/inc/miscuno.hxx
+++ b/sc/inc/miscuno.hxx
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 
 #include "scdllapi.h"
 
 #define SC_SIMPLE_SERVICE_INFO( ClassName, ClassNameAscii, ServiceAscii )  
  \
diff --git a/sc/inc/scitems.hxx b/sc/inc/scitems.hxx
index 159e6e013706..0606b39de634 100644
--- a/sc/inc/scitems.hxx
+++ b/sc/inc/scitems.hxx
@@ -50,6 +50,10 @@ class SvxVerJustifyItem;
 class SvxBrushItem;
 class SvxBoxItem;
 class ScCondFormatItem;
+class SvxLineItem;
+class SvxRotateModeItem;
+class SfxStringItem;
+class SvxSizeItem;
 
 //  EditEngine is not allowed to define its own ITEMID's
 #define INCLUDED_EDITENG_EEITEMID_HXX
diff --git a/sc/source/ui/unoobj/ChartRangeSelectionListener.cxx 
b/sc/source/ui/unoobj/ChartRangeSelectionListener.cxx
index 0ef2dbff3f68..696258a8bcf0 100644
---

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2019-03-21 Thread Libreoffice Gerrit user 
 sc/IwyuFilter_sc.yaml  |7 +
 sc/inc/scitems.hxx |1 
 sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx|9 ---
 sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx |   11 -
 sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx   |1 
 sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx|1 
 sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx |   12 
--
 sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx  |   12 
--
 sc/source/ui/StatisticsDialogs/FTestDialog.cxx |   12 
--
 sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx   |   11 -
 sc/source/ui/StatisticsDialogs/MovingAverageDialog.cxx |   12 
--
 sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx |4 ---
 sc/source/ui/StatisticsDialogs/RegressionDialog.cxx|8 --
 sc/source/ui/StatisticsDialogs/SamplingDialog.cxx  |4 ---
 sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx |8 --
 sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx |8 --
 sc/source/ui/StatisticsDialogs/TTestDialog.cxx |   12 
--
 sc/source/ui/StatisticsDialogs/ZTestDialog.cxx |   12 
--
 sc/source/ui/inc/undocell.hxx  |1 
 sc/source/ui/pagedlg/areasdlg.cxx  |1 
 sc/source/ui/pagedlg/hfedtdlg.cxx  |2 -
 sc/source/ui/pagedlg/scuitphfedit.cxx  |   12 
--
 sc/source/ui/pagedlg/tphf.cxx  |2 -
 sc/source/ui/pagedlg/tphfedit.cxx  |5 
 sc/source/ui/pagedlg/tptable.cxx   |1 
 sc/source/ui/sidebar/AlignmentPropertyPanel.cxx|5 
 sc/source/ui/sidebar/AlignmentPropertyPanel.hxx|4 ---
 sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx   |5 
 sc/source/ui/sidebar/CellAppearancePropertyPanel.hxx   |8 ++
 sc/source/ui/sidebar/CellBorderStyleControl.cxx|4 ---
 sc/source/ui/sidebar/CellLineStyleControl.cxx  |4 ---
 sc/source/ui/sidebar/NumberFormatControl.cxx   |1 
 sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx |1 
 sc/source/ui/sidebar/NumberFormatPropertyPanel.hxx |8 --
 sc/source/ui/sidebar/ScPanelFactory.cxx|4 ---
 sc/source/ui/styleui/styledlg.cxx  |4 ---
 sc/source/ui/uitest/uiobject.cxx   |1 
 sc/source/ui/undo/refundo.cxx  |4 ---
 sc/source/ui/undo/undobase.cxx |1 
 sc/source/ui/undo/undoblk.cxx  |4 ---
 sc/source/ui/undo/undoblk2.cxx |3 --
 sc/source/ui/undo/undoblk3.cxx |9 ---
 sc/source/ui/undo/undocell.cxx |7 -
 sc/source/ui/undo/undodat.cxx  |5 
 sc/source/ui/undo/undodraw.cxx |2 -
 sc/source/ui/undo/undorangename.cxx|3 --
 sc/source/ui/undo/undotab.cxx  |1 
 47 files changed, 30 insertions(+), 227 deletions(-)

New commits:
commit 7c7a4675ad5d61add70dd073f680ea37012962ce
Author: Gabor Kelemen 
AuthorDate: Mon Mar 18 00:34:00 2019 +0100
Commit: Miklos Vajna 
CommitDate: Thu Mar 21 09:10:18 2019 +0100

tdf#42949 Fix IWYU warnings in sc/source/ui/pagedlg...undo

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Icb5f0235339364e6dc09936e26f256765a60830a
Reviewed-on: https://gerrit.libreoffice.org/69378
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index d04da62d06f1..fc77866f682d 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -867,3 +867,10 @@ blacklist:
 # Complete type is needed
 - com/sun/star/sheet/XFormulaParser.hpp
 - com/sun/star/sheet/XFormulaOpCodeMapper.hpp
+sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx:
+# Needed for implicit dtor
+- editeng/editobj.hxx
+sc/source/ui/undo/undoolk.cxx:
+# Avoid loplugin:unreffun error
+- undoolk.hxx
+
diff --git a/sc/inc/scitems.hxx b/sc/inc/scitems.hxx
index d2e982d82083..159e6e013706 100644
--- a/sc/inc/scitems.hxx
+++ b/sc/inc/scitems.hxx
@@ -49,6 +49,7 @@ class SvxHorJustifyItem;
 class SvxVerJustifyItem;
 class SvxBrushItem;
 class SvxBoxItem;
+class ScCondFormatItem;
 
 //

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2019-01-23 Thread Libreoffice Gerrit user 
 sc/IwyuFilter_sc.yaml|   23 +++
 sc/inc/scitems.hxx   |5 +
 sc/source/filter/dif/difexp.cxx  |3 ---
 sc/source/filter/dif/difimp.cxx  |4 
 sc/source/filter/ftools/fapihelper.cxx   |3 ---
 sc/source/filter/ftools/fprogressbar.cxx |1 -
 sc/source/filter/ftools/ftools.cxx   |2 --
 sc/source/filter/html/htmlexp.cxx|7 ---
 sc/source/filter/html/htmlexp2.cxx   |4 
 sc/source/filter/html/htmlimp.cxx|4 +---
 sc/source/filter/html/htmlpars.cxx   |4 
 sc/source/filter/inc/dif.hxx |1 +
 sc/source/filter/inc/fprogressbar.hxx|2 +-
 sc/source/filter/lotus/filter.cxx|6 --
 sc/source/filter/lotus/lotattr.cxx   |2 --
 sc/source/filter/lotus/lotform.cxx   |2 --
 sc/source/filter/lotus/lotimpop.cxx  |6 --
 sc/source/filter/lotus/lotread.cxx   |3 ---
 sc/source/filter/lotus/lotus.cxx |1 -
 sc/source/filter/lotus/memory.cxx|2 --
 sc/source/filter/lotus/op.cxx|5 -
 sc/source/filter/lotus/tool.cxx  |5 -
 sc/source/filter/orcus/filterdetect.cxx  |3 ++-
 sc/source/filter/orcus/interface.cxx |8 
 sc/source/filter/orcus/orcusfiltersimpl.cxx  |5 -
 sc/source/filter/orcus/xmlcontext.cxx|5 ++---
 sc/source/filter/qpro/qpro.cxx   |5 -
 sc/source/filter/qpro/qproform.cxx   |3 ---
 sc/source/filter/qpro/qprostyle.cxx  |8 
 sc/source/filter/rtf/eeimpars.cxx|8 
 sc/source/filter/rtf/rtfexp.cxx  |7 ---
 sc/source/filter/rtf/rtfimp.cxx  |2 --
 sc/source/filter/rtf/rtfparse.cxx|5 +
 sc/source/filter/xcl97/XclExpChangeTrack.cxx |2 --
 sc/source/filter/xcl97/xcl97esc.cxx  |8 
 sc/source/filter/xcl97/xcl97rec.cxx  |   19 ---
 36 files changed, 36 insertions(+), 147 deletions(-)

New commits:
commit 8f7c35072a6bbb33f6582c8c9a37a275c8d3cb14
Author: Gabor Kelemen 
AuthorDate: Sun Jan 20 23:42:25 2019 +0100
Commit: Miklos Vajna 
CommitDate: Wed Jan 23 09:10:06 2019 +0100

tdf#42949 Fix IWYU warnings in sc/source/filter/*cxx

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Clean remaining cxx files in directories:
dif/ ftools/ html/ lotus/ orcus/ qpro/ rtf/ xcl97/

Change-Id: I219b61c087c07b0538b4525bf53d79f413d409c5
Reviewed-on: https://gerrit.libreoffice.org/66657
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 68f62a5773ae..571bcd22258a 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -387,6 +387,9 @@ blacklist:
 sc/source/filter/inc/formulabase.hxx:
 # Needed for typedef
 - com/sun/star/table/CellAddress.hpp
+sc/source/filter/inc/fprogressbar.hxx:
+# Avoid collision with fprogressbar.cxx checking
+- progress.hxx
 sc/source/filter/inc/ooxformulaparser.hxx:
 # base class has to be a complete type
 - com/sun/star/lang/XInitialization.hpp
@@ -665,6 +668,9 @@ blacklist:
 sc/source/filter/xml/xmldrani.hxx:
 # Complex type needs complete type
 - com/sun/star/beans/PropertyValue.hpp
+sc/source/filter/ftools/sharedformulagroups.cxx:
+# Needed for implicit dtor
+- tokenarray.hxx
 sc/source/filter/excel/excimp8.cxx:
 # base class has to be a complete type
 - com/sun/star/container/XIndexContainer.hpp
@@ -688,6 +694,15 @@ blacklist:
 sc/source/filter/excel/xistyle.cxx:
 # Needed for direct member access
 - xladdress.hxx
+sc/source/filter/lotus/filter.cxx:
+# Needed to avoid loplugin:unreffun error
+- filter.hxx
+sc/source/filter/lotus/memory.cxx
+# Needed to avoid loplugin:unreffun error
+- scmem.h
+sc/source/filter/lotus/op.cxx:
+# Needed to avoid loplugin:unreffun error
+- op.h
 sc/source/filter/oox/ooxformulaparser.cxx:
 # Needed for direct member access
 - com/sun/star/lang/XComponent.hpp
@@ -697,6 +712,14 @@ blacklist:
 sc/source/filter/oox/worksheethelper.cxx:
 # Needed for implicit dtor
 - editeng/editobj.hxx
+sc/source/filter/orcus/orcusfiltersimpl.cxx:
+# Needed for implicit dtor
+- tokenarray.hxx
+# Needed for direct member access
+- com/sun/star/task/XStatusIndicator.hpp
+sc/source/filter/orcus/xmlcontext.cxx:
+# Needed for implicit dtor
+- tokenarray.hxx
 sc/source/filter/xml/XMLExportIterator.cxx:
 # Needed for direct member access
 - com/sun/star/table/XCellRange.hpp
diff --git a/sc/inc/scitems.hxx b/sc/inc/scitems.hxx
index bd78bda629d0..d2e982d82083 100644
--- a/sc/inc/scitems.hxx
+++

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-12-17 Thread Libreoffice Gerrit user 
 sc/IwyuFilter_sc.yaml |   33 
 sc/inc/scitems.hxx|   23 +
 sc/source/filter/excel/colrowst.cxx   |5 ---
 sc/source/filter/excel/excdoc.cxx |   31 --
 sc/source/filter/excel/excel.cxx  |   11 
 sc/source/filter/excel/excform.cxx|3 --
 sc/source/filter/excel/excform8.cxx   |3 --
 sc/source/filter/excel/excimp8.cxx|   46 --
 sc/source/filter/excel/excrecds.cxx   |   40 -
 sc/source/filter/excel/exctools.cxx   |   17 
 sc/source/filter/excel/expop2.cxx |   11 +---
 sc/source/filter/excel/fontbuff.cxx   |   12 
 sc/source/filter/excel/impop.cxx  |   27 ---
 sc/source/filter/excel/namebuff.cxx   |5 ---
 sc/source/filter/excel/read.cxx   |2 -
 sc/source/filter/excel/tokstack.cxx   |2 -
 sc/source/filter/excel/xechart.cxx|3 --
 sc/source/filter/excel/xecontent.cxx  |2 -
 sc/source/filter/excel/xedbdata.cxx   |1 
 sc/source/filter/excel/xeescher.cxx   |   16 ---
 sc/source/filter/excel/xeextlst.cxx   |5 ---
 sc/source/filter/excel/xeformula.cxx  |3 --
 sc/source/filter/excel/xehelper.cxx   |1 
 sc/source/filter/excel/xelink.cxx |1 
 sc/source/filter/excel/xename.cxx |5 ---
 sc/source/filter/excel/xepage.cxx |1 
 sc/source/filter/excel/xepivot.cxx|5 ---
 sc/source/filter/excel/xepivotxml.cxx |1 
 sc/source/filter/excel/xeroot.cxx |5 ---
 sc/source/filter/excel/xestream.cxx   |8 +
 sc/source/filter/excel/xestyle.cxx|   10 ---
 sc/source/filter/excel/xetable.cxx|1 
 sc/source/filter/excel/xichart.cxx|3 --
 sc/source/filter/excel/xicontent.cxx  |   11 
 sc/source/filter/excel/xiescher.cxx   |   18 ++---
 sc/source/filter/excel/xihelper.cxx   |2 -
 sc/source/filter/excel/xilink.cxx |2 -
 sc/source/filter/excel/xipivot.cxx|2 -
 sc/source/filter/excel/xiroot.cxx |1 
 sc/source/filter/excel/xistyle.cxx|3 --
 sc/source/filter/excel/xlchart.cxx|4 --
 sc/source/filter/excel/xlescher.cxx   |2 -
 sc/source/filter/excel/xlformula.cxx  |5 ---
 sc/source/filter/excel/xlpage.cxx |5 ---
 sc/source/filter/excel/xlpivot.cxx|1 
 sc/source/filter/excel/xlroot.cxx |2 -
 sc/source/filter/excel/xltoolbar.cxx  |8 -
 sc/source/filter/excel/xltools.cxx|   10 ++-
 sc/source/filter/excel/xlview.cxx |1 
 49 files changed, 81 insertions(+), 338 deletions(-)

New commits:
commit 0aff4d06e706fde2543fc0926f2e48e0c2139700
Author: Gabor Kelemen 
AuthorDate: Sun Dec 9 03:35:37 2018 +0100
Commit: Miklos Vajna 
CommitDate: Mon Dec 17 15:41:12 2018 +0100

tdf#42949 Fix IWYU warnings in sc/source/filter/excel/*cxx

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ia155032426e02eb9ee64db3fb10946f5c9d445b7
Reviewed-on: https://gerrit.libreoffice.org/64832
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 44f20377fe97..59f5f1677751 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -392,9 +392,19 @@ blacklist:
 sc/source/filter/inc/xerecord.hxx:
 # Needed for member access
 - xestream.hxx
+sc/source/filter/inc/xetable.hxx:
+# Needed for typedef
+- class XclExpNote
+sc/source/filter/inc/xilink.hxx:
+# Needed for typedef
+- class XclImpCachedMatrix
+- class ScTokenArray
 sc/source/filter/inc/xistream.hxx:
 # Needed for implicit dtor
 - com/sun/star/beans/NamedValue.hpp
+sc/source/filter/inc/xlpage.hxx:
+# Needed for typedef
+- class SvxBrushItem
 sc/source/ui/inc/AccessibleContextBase.hxx:
 # base class has to be a complete type
 - com/sun/star/accessibility/XAccessibleComponent.hpp
@@ -649,3 +659,26 @@ blacklist:
 sc/source/filter/xml/xmldrani.hxx:
 # Complex type needs complete type
 - com/sun/star/beans/PropertyValue.hpp
+sc/source/filter/excel/excimp8.cxx:
+# base class has to be a complete type
+- com/sun/star/container/XIndexContainer.hpp
+sc/source/filter/excel/xechart.cxx:
+# Complex type needs complete type
+- com/sun/star/chart2/RelativePosition.hpp
+- com/sun/star/chart2/RelativeSize.hpp
+sc/source/filter/excel/xeescher.cxx:
+# base class has to be a complete type
+- com/sun/star/chart/XChartDocument.hpp
+sc/source/filter/excel/xeroot.cxx:
+# Complex type needs complete type
+- com/sun/star/sheet/FormulaOpCodeMapEntry.hpp
+sc/source/filter/excel/xicontent.cxx:
+# Needed for implicit dtor
+- editeng/editobj.hxx
+sc/source/filter/excel/xiescher.cxx:
+# Needed for implicit dtor
+- editeng/editobj.hxx
+- com/sun/star/form/XForm.hpp
+

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-11-08 Thread Libreoffice Gerrit user 
 sc/IwyuFilter_sc.yaml   |   34 +++-
 sc/inc/address.hxx  |3 +-
 sc/inc/chgtrack.hxx |1 
 sc/inc/colcontainer.hxx |3 --
 sc/inc/documentimport.hxx   |2 -
 sc/inc/dptabres.hxx |7 +
 sc/inc/global.hxx   |3 +-
 sc/inc/listenercontext.hxx  |3 --
 sc/source/core/data/attarray.cxx|8 --
 sc/source/core/data/attrib.cxx  |8 --
 sc/source/core/data/autonamecache.cxx   |3 --
 sc/source/core/data/bcaslot.cxx |2 -
 sc/source/core/data/cellvalues.cxx  |1 
 sc/source/core/data/colcontainer.cxx|1 
 sc/source/core/data/column.cxx  |8 --
 sc/source/core/data/column2.cxx |9 ---
 sc/source/core/data/column3.cxx |9 ---
 sc/source/core/data/column4.cxx |4 ---
 sc/source/core/data/compressedarray.cxx |3 --
 sc/source/core/data/conditio.cxx|5 
 sc/source/core/data/dbdocutl.cxx|1 
 sc/source/core/data/dociter.cxx |2 -
 sc/source/core/data/docpool.cxx |3 --
 sc/source/core/data/documen2.cxx|   24 ---
 sc/source/core/data/documen3.cxx|   13 --
 sc/source/core/data/documen4.cxx|4 ---
 sc/source/core/data/documen5.cxx|4 ---
 sc/source/core/data/documen6.cxx|2 -
 sc/source/core/data/documen7.cxx|8 --
 sc/source/core/data/documen8.cxx|   11 -
 sc/source/core/data/documen9.cxx|   10 
 sc/source/core/data/document.cxx|   19 ---
 sc/source/core/data/document10.cxx  |5 
 sc/source/core/data/documentimport.cxx  |1 
 sc/source/core/data/dpcache.cxx |2 -
 sc/source/core/data/dpdimsave.cxx   |1 
 sc/source/core/data/dpfilteredcache.cxx |7 -
 sc/source/core/data/dpgroup.cxx |6 
 sc/source/core/data/dpitemdata.cxx  |7 ++---
 sc/source/core/data/dpobject.cxx|4 ---
 sc/source/core/data/dpoutput.cxx|   18 +++---
 sc/source/core/data/dpresfilter.cxx |1 
 sc/source/core/data/dpsave.cxx  |8 +-
 sc/source/core/data/dpsdbtab.cxx|2 -
 sc/source/core/data/dpshttab.cxx|3 --
 sc/source/core/data/dptabdat.cxx|6 
 sc/source/core/data/dptabres.cxx|1 
 sc/source/core/data/dptabsrc.cxx|   10 
 sc/source/core/data/dputil.cxx  |2 -
 sc/source/core/data/drawpage.cxx|3 --
 sc/source/core/data/drwlayer.cxx|   16 ++---
 sc/source/core/data/fillinfo.cxx|3 --
 sc/source/core/data/formulacell.cxx |4 ---
 sc/source/core/data/funcdesc.cxx|3 --
 sc/source/core/data/global.cxx  |   14 ---
 sc/source/core/data/global2.cxx |8 --
 sc/source/core/data/globalx.cxx |4 +--
 sc/source/core/data/grouptokenconverter.cxx |2 -
 sc/source/core/data/markarr.cxx |1 
 sc/source/core/data/mtvelements.cxx |1 
 sc/source/core/data/olinetab.cxx|6 
 sc/source/core/data/patattr.cxx |4 ---
 sc/source/core/data/pivot2.cxx  |   18 --
 sc/source/core/data/postit.cxx  |5 
 sc/source/core/data/stlpool.cxx |   10 
 sc/source/core/data/stlsheet.cxx|5 
 sc/source/core/data/table1.cxx  |7 -
 sc/source/core/data/table2.cxx  |   10 
 sc/source/core/data/table3.cxx  |7 -
 sc/source/core/data/table4.cxx  |   15 
 sc/source/core/data/table5.cxx  |8 --
 sc/source/core/data/table6.cxx  |2 -
 sc/source/core/data/table7.cxx  |1 
 sc/source/core/data/userdat.cxx |2 -
 sc/source/core/data/validat.cxx |6 
 sc/source/core/tool/cellkeytranslator.cxx   |1 
 sc/source/filter/excel/xltracer.cxx |1 
 77 files changed, 75 insertions(+), 394 deletions(-)

New commits:
commit dec3752eeb3bcd46fb5c4af4e0a48738440d21e7
Author: Gabor Kelemen 
AuthorDate: Sat Nov 3 13:14:30 2018 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 8 09:16:26 2018 +0100

tdf#42949 Fix IWYU warnings in sc/source/core/data/*cxx

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I3e3bf3160fe3627cd105d8b69ff165c0577d8c9b
Reviewed-on: https://gerrit.libreoffice.org/62807
Tested-by: Jenkins
Reviewed-by: Miklos

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-10-31 Thread Libreoffice Gerrit user 
 sc/IwyuFilter_sc.yaml |7 +++
 sc/inc/AccessibleFilterMenu.hxx   |6 --
 sc/inc/column.hxx |3 ---
 sc/inc/datamapper.hxx |1 -
 sc/inc/dpresfilter.hxx|1 -
 sc/inc/dpshttab.hxx   |4 
 sc/inc/dptabdat.hxx   |4 
 sc/inc/dptabsrc.hxx   |3 ---
 sc/inc/formulacell.hxx|1 -
 sc/inc/interpretercontext.hxx |6 +-
 sc/inc/listenercalls.hxx  |3 ---
 sc/inc/markdata.hxx   |1 -
 sc/inc/scmatrix.hxx   |2 --
 sc/inc/token.hxx  |6 --
 sc/inc/validat.hxx|1 -
 sc/source/core/tool/chartlis.cxx  |1 +
 sc/source/core/tool/interpretercontext.cxx|2 +-
 sc/source/filter/inc/externallinkfragment.hxx |2 --
 sc/source/filter/inc/sheetdatabuffer.hxx  |2 +-
 sc/source/filter/inc/xiescher.hxx |2 --
 20 files changed, 11 insertions(+), 47 deletions(-)

New commits:
commit 7513af89362a7d54e0210049d3644db5818950a5
Author: Gabor Kelemen 
AuthorDate: Wed Oct 24 01:43:47 2018 +0200
Commit: Miklos Vajna 
CommitDate: Wed Oct 31 09:05:24 2018 +0100

tdf#42949 Fix IWYU warnings in sc/inc; sc/source/filter/inc/

Found with bin/find-unneeded-includes after recent improvements
- remove UNO headers from blacklist
- remove newly found unneeded fw declarations
- fix up some not self contained headers

Change-Id: I605656bc98a64640a78d2ff4de9c7c37326033cf
Reviewed-on: https://gerrit.libreoffice.org/62264
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 0b8fff456db7..e3c0a348db21 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -10,9 +10,6 @@ blacklist:
 sc/inc/AccessibleFilterMenuItem.hxx:
 # base class has to be a complete type
 - com/sun/star/accessibility/XAccessibleAction.hpp
-sc/inc/address.hxx:
-# base class has to be a complete type
-- com/sun/star/uno/Sequence.hxx
 sc/inc/addruno.hxx:
 # base class has to be a complete type
 - com/sun/star/beans/XPropertySet.hpp
@@ -79,6 +76,8 @@ blacklist:
 sc/inc/conditio.hxx:
 # base class has to be a complete type
 - tools/link.hxx
+# Used as type for a boost::optional variable
+- tools/color.hxx
 sc/inc/dapiuno.hxx:
 # base class has to be a complete type
 - com/sun/star/container/XEnumerationAccess.hpp
@@ -202,6 +201,7 @@ blacklist:
 - memory
 # needed for conditionally enabled code path
 - struct ScFormulaCellGroup
+- namespace osl { class File; }
 sc/inc/formulaparserpool.hxx:
 # base class has to be a complete type
 - com/sun/star/sheet/XFormulaParser.hpp
@@ -215,7 +215,6 @@ blacklist:
 - com/sun/star/sheet/XFunctionAccess.hpp
 sc/inc/global.hxx:
 # base class has to be a complete type
-- com/sun/star/uno/Reference.hxx
 - tools/ref.hxx
 sc/inc/linkuno.hxx:
 # base class has to be a complete type
diff --git a/sc/inc/AccessibleFilterMenu.hxx b/sc/inc/AccessibleFilterMenu.hxx
index f5ede6e03f81..878c27a637c3 100644
--- a/sc/inc/AccessibleFilterMenu.hxx
+++ b/sc/inc/AccessibleFilterMenu.hxx
@@ -28,12 +28,6 @@
 
 #include 
 
-namespace com { namespace sun { namespace star {
-namespace accessibility {
-struct AccessibleEventObject;
-}
-}}}
-
 class ScMenuFloatingWindow;
 
 typedef ::cppu::ImplHelper1<
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index ffa43e12ea94..bdaeccde0afe 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -40,7 +40,6 @@ namespace formula { struct VectorRefArray; }
 
 namespace sc {
 
-struct FormulaGroupContext;
 struct FormulaGroupEntry;
 class StartListeningContext;
 class EndListeningContext;
@@ -49,7 +48,6 @@ class CopyToClipContext;
 class CopyToDocContext;
 class MixDocContext;
 class ColumnSpanSet;
-struct ColumnBlockPosition;
 class SingleColumnSpanSet;
 struct RefUpdateContext;
 struct RefUpdateInsertTabContext;
@@ -64,7 +62,6 @@ struct RowSpan;
 class RowHeightContext;
 class CompileFormulaContext;
 struct SetFormulaDirtyContext;
-class RefMovedHint;
 enum class MatrixEdge;
 class ColumnIterator;
 
diff --git a/sc/inc/datamapper.hxx b/sc/inc/datamapper.hxx
index 27bb011521cf..d54e1a81c2ed 100644
--- a/sc/inc/datamapper.hxx
+++ b/sc/inc/datamapper.hxx
@@ -24,7 +24,6 @@ namespace sc {
 
 class ScDBDataManager;
 class DataProvider;
-class ScDBDataManager;
 class DataTransformation;
 
 class SC_DLLPUBLIC ExternalDataSource
diff --git a/sc/inc/dpresfilter.hxx b/sc/inc/dpresfilter.hxx
index 7fed71374dd4..a66a8469f987 100644
--- a/sc/inc/dpresfilter.hxx
+++ b/sc/inc/dpresfilter.hxx
@@ -58,7 +58,6 @@ public:
 private:
 
 struct

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-09-04 Thread Libreoffice Gerrit user 
 sc/IwyuFilter_sc.yaml |8 
 sc/inc/progress.hxx   |1 +
 sc/source/filter/dif/difexp.cxx   |1 +
 sc/source/filter/excel/excform.cxx|1 +
 sc/source/filter/excel/excimp8.cxx|1 +
 sc/source/filter/excel/excrecds.cxx   |1 +
 sc/source/filter/excel/exctools.cxx   |1 +
 sc/source/filter/excel/impop.cxx  |3 +++
 sc/source/filter/excel/read.cxx   |1 +
 sc/source/filter/excel/xestream.cxx   |1 +
 sc/source/filter/excel/xiroot.cxx |1 +
 sc/source/filter/ftools/fapihelper.cxx|1 +
 sc/source/filter/ftools/fprogressbar.cxx  |1 +
 sc/source/filter/inc/addressconverter.hxx |4 +++-
 sc/source/filter/inc/biffhelper.hxx   |3 ++-
 sc/source/filter/inc/colrowst.hxx |3 ++-
 sc/source/filter/inc/condformatbuffer.hxx |3 ---
 sc/source/filter/inc/condformatcontext.hxx|2 --
 sc/source/filter/inc/defnamesbuffer.hxx   |5 +++--
 sc/source/filter/inc/dif.hxx  |6 +-
 sc/source/filter/inc/drawingfragment.hxx  |2 --
 sc/source/filter/inc/eeimport.hxx |2 --
 sc/source/filter/inc/eeparser.hxx |2 ++
 sc/source/filter/inc/excdoc.hxx   |9 +
 sc/source/filter/inc/excelhandlers.hxx|3 ++-
 sc/source/filter/inc/excimp8.hxx  |4 
 sc/source/filter/inc/excrecds.hxx |   11 ---
 sc/source/filter/inc/exp_op.hxx   |5 -
 sc/source/filter/inc/expbase.hxx  |2 +-
 sc/source/filter/inc/externallinkbuffer.hxx   |1 +
 sc/source/filter/inc/extlstcontext.hxx|   10 +-
 sc/source/filter/inc/fapihelper.hxx   |8 
 sc/source/filter/inc/formel.hxx   |5 -
 sc/source/filter/inc/formulabase.hxx  |   10 ++
 sc/source/filter/inc/formulabuffer.hxx|7 ---
 sc/source/filter/inc/fprogressbar.hxx |4 ++--
 sc/source/filter/inc/ftools.hxx   |8 +++-
 sc/source/filter/inc/htmlexp.hxx  |4 +++-
 sc/source/filter/inc/htmlimp.hxx  |1 -
 sc/source/filter/inc/imp_op.hxx   |9 ++---
 sc/source/filter/inc/lotattr.hxx  |2 --
 sc/source/filter/inc/lotfntbf.hxx |2 --
 sc/source/filter/inc/lotform.hxx  |1 -
 sc/source/filter/inc/lotimpop.hxx |3 ---
 sc/source/filter/inc/lotrange.hxx |5 +++--
 sc/source/filter/inc/xeescher.hxx |1 +
 sc/source/filter/inc/xestream.hxx |1 +
 sc/source/filter/inc/xistream.hxx |1 +
 sc/source/filter/lotus/lotattr.cxx|1 +
 sc/source/filter/oox/autofilterbuffer.cxx |1 +
 sc/source/filter/oox/condformatbuffer.cxx |1 +
 sc/source/filter/oox/defnamesbuffer.cxx   |1 +
 sc/source/filter/oox/externallinkbuffer.cxx   |1 +
 sc/source/filter/oox/externallinkfragment.cxx |1 +
 sc/source/filter/oox/extlstcontext.cxx|2 ++
 sc/source/filter/oox/formulabase.cxx  |2 ++
 sc/source/filter/oox/formulabuffer.cxx|1 +
 sc/source/filter/oox/formulaparser.cxx|1 +
 sc/source/filter/oox/pagesettings.cxx |1 +
 sc/source/filter/oox/pivotcachebuffer.cxx |1 +
 sc/source/filter/oox/sheetdatacontext.cxx |1 +
 sc/source/filter/oox/stylesbuffer.cxx |1 +
 sc/source/filter/oox/workbookfragment.cxx |1 +
 sc/source/filter/oox/worksheetbuffer.cxx  |1 +
 sc/source/filter/oox/worksheetfragment.cxx|1 +
 sc/source/filter/xcl97/XclExpChangeTrack.cxx  |1 +
 sc/source/filter/xcl97/XclImpChangeTrack.cxx  |1 +
 sc/source/filter/xcl97/xcl97rec.cxx   |1 +
 68 files changed, 97 insertions(+), 96 deletions(-)

New commits:
commit 9aee9781212328e78b6a34ac2b965b16fd0d9e3a
Author: Gabor Kelemen 
AuthorDate: Mon Aug 27 22:14:27 2018 +0200
Commit: Miklos Vajna 
CommitDate: Tue Sep 4 09:29:23 2018 +0200

tdf#42949 Fix IWYU warnings in sc/source/filter/inc/[a-l]*

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I92cfd8d09ca8229764db4200568b96a62e2ab21e
Reviewed-on: https://gerrit.libreoffice.org/59742
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 100e263949dd..62a5354aee56 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -375,3 +375,11 @@ blacklist:
 sc/source/core/opencl/opbase.hxx:
 # Needed for FormulaTreeNode()
 - formula/token.hxx
+sc/source/filter/inc/drawingfragment.hxx:
+# Needed for implicit dtor
+- drawingbase.hxx
+sc/source/filter/inc/excdoc.hxx:
+# Needed for unique_ptr type
+- class

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-08-07 Thread Libreoffice Gerrit user 
 sc/IwyuFilter_sc.yaml|   66 ++-
 sc/inc/ChartTools.hxx|   10 +++-
 sc/inc/datamapper.hxx|1 
 sc/inc/dociter.hxx   |1 
 sc/inc/externalrefmgr.hxx|   16 +--
 sc/inc/fielduno.hxx  |6 +-
 sc/inc/formulaiter.hxx   |1 
 sc/inc/funcuno.hxx   |1 
 sc/inc/nameuno.hxx   |4 -
 sc/inc/recursionhelper.hxx   |1 
 sc/inc/scabstdlg.hxx |   14 ++
 sc/inc/scdll.hxx |6 --
 sc/inc/scmod.hxx |   11 ++---
 sc/inc/shapeuno.hxx  |2 
 sc/inc/sheetevents.hxx   |3 -
 sc/inc/testlotus.hxx |2 
 sc/source/core/data/drwlayer.cxx |1 
 sc/source/core/data/sheetevents.cxx  |1 
 sc/source/core/tool/chgtrack.cxx |1 
 sc/source/core/tool/editutil.cxx |1 
 sc/source/ui/app/scmod.cxx   |1 
 sc/source/ui/attrdlg/scdlgfact.cxx   |1 
 sc/source/ui/attrdlg/scdlgfact.hxx   |1 
 sc/source/ui/attrdlg/scuiexp.cxx |1 
 sc/source/ui/docshell/dbdocfun.cxx   |1 
 sc/source/ui/docshell/docsh.cxx  |2 
 sc/source/ui/docshell/docsh4.cxx |1 
 sc/source/ui/docshell/externalrefmgr.cxx |1 
 sc/source/ui/inc/scuiasciiopt.hxx|1 
 sc/source/ui/pagedlg/tphf.cxx|1 
 sc/source/ui/pagedlg/tphfedit.cxx|1 
 sc/source/ui/unoobj/ChartTools.cxx   |4 +
 sc/source/ui/unoobj/TablePivotChart.cxx  |1 
 sc/source/ui/unoobj/appluno.cxx  |1 
 sc/source/ui/view/cellsh2.cxx|1 
 sc/source/ui/view/formatsh.cxx   |1 
 sc/source/ui/view/tabvwsha.cxx   |1 
 37 files changed, 117 insertions(+), 53 deletions(-)

New commits:
commit a30072282e7bc7d9dda68986b4859cc1d6575597
Author: Gabor Kelemen 
AuthorDate: Tue Aug 7 10:56:34 2018 +0200
Commit: Miklos Vajna 
CommitDate: Tue Aug 7 17:28:47 2018 +0200

tdf#42949 Fix remaining IWYU warnings in sc/inc

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

With this patch, find-unneeded-includes gives no more problems

Change-Id: I24e62be7a387d7fd97a36f54eed0ba9d83ddaf0c
Reviewed-on: https://gerrit.libreoffice.org/58667
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 951f833a310a..b67bf7f9be83 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -116,6 +116,9 @@ blacklist:
 # base class has to be a complete type
 - com/sun/star/frame/XDispatchProviderInterceptor.hpp
 - com/sun/star/view/XSelectionChangeListener.hpp
+sc/inc/document.hxx:
+# std::unique_ptr deleter type has to be complete
+- o3tl/deleter.hxx
 sc/inc/docuno.hxx:
 # base class has to be a complete type
 - com/sun/star/container/XEnumerationAccess.hpp
@@ -153,6 +156,16 @@ blacklist:
 # base class has to be a complete type
 - com/sun/star/container/XNameReplace.hpp
 - com/sun/star/lang/XServiceInfo.hpp
+sc/inc/fielduno.hxx:
+# base class has to be a complete type
+- com/sun/star/container/XEnumerationAccess.hpp
+- com/sun/star/container/XIndexAccess.hpp
+- com/sun/star/container/XContainer.hpp
+- com/sun/star/util/XRefreshable.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/text/XTextField.hpp
+- com/sun/star/beans/XPropertySet.hpp
+- com/sun/star/lang/XUnoTunnel.hpp
 sc/inc/fillinfo.hxx:
 # base class has to be a complete type
 - o3tl/typed_flags_set.hxx
@@ -193,14 +206,34 @@ blacklist:
 # base class has to be a complete type
 - com/sun/star/sheet/XFormulaParser.hpp
 sc/inc/formularesult.hxx:
-# Needed for enum
-- global.hxx
 # Needed for macros
 - calcmacros.hxx
+sc/inc/funcuno.hxx:
+# base class has to be a complete type
+- com/sun/star/beans/XPropertySet.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/sheet/XFunctionAccess.hpp
 sc/inc/global.hxx:
 # base class has to be a complete type
 - com/sun/star/uno/Reference.hxx
 - tools/ref.hxx
+sc/inc/linkuno.hxx:
+# base class has to be a complete type
+- com/sun/star/beans/XPropertySet.hpp
+- com/sun/star/container/XEnumerationAccess.hpp
+- com/sun/star/container/XIndexAccess.hpp
+- com/sun/star/container/XNameAccess.hpp
+- com/sun/star/container/XNamed.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/sheet/XAreaLink.hpp
+- com/sun/star/sheet/XAreaLinks.hpp
+- com/sun/star/sheet/XDDELink.hpp
+- com/sun/star/sheet/XDDELinkResults.hpp
+- com/sun/star/sheet/XDDELinks.hpp
+- com/sun/star/sheet/XExternalDocLink.hpp
+-

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-06-20 Thread Gabor Kelemen 
 sc/IwyuFilter_sc.yaml|7 +++
 sc/inc/undorangename.hxx |1 -
 sc/inc/userdat.hxx   |2 --
 sc/inc/validat.hxx   |1 -
 sc/inc/viewopti.hxx  |1 -
 sc/inc/viewuno.hxx   |5 +++--
 sc/inc/xmlwrap.hxx   |7 ++-
 sc/source/core/data/documen3.cxx |1 +
 sc/source/core/data/validat.cxx  |1 +
 sc/source/filter/excel/impop.cxx |1 +
 sc/source/filter/excel/xecontent.cxx |1 +
 sc/source/filter/excel/xicontent.cxx |1 +
 sc/source/ui/dbgui/validate.cxx  |1 +
 sc/source/ui/view/cellsh2.cxx|1 +
 sc/source/ui/view/gridwin.cxx|1 +
 15 files changed, 20 insertions(+), 12 deletions(-)

New commits:
commit 3efc2d022b0d1a5cf6155257d57504d47ceefc44
Author: Gabor Kelemen 
Date:   Sat May 19 09:22:07 2018 +0200

tdf#42949 Fix IWYU warnings in sc/inc/[ux]*

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
and a bit of fallout management

Change-Id: I53d2c5dc9e16a64a143b16316d2aeab05023d866
Reviewed-on: https://gerrit.libreoffice.org/56076
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 166b76fbd66b..5011ecdea951 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -208,6 +208,10 @@ blacklist:
 - com/sun/star/lang/XServiceInfo.hpp
 - com/sun/star/util/XCloneable.hpp
 - com/sun/star/util/XModifyBroadcaster.hpp
+sc/inc/PivotTableDataSource.hxx:
+# base class has to be a complete type
+- com/sun/star/chart2/data/XDataSource.hpp
+- com/sun/star/lang/XServiceInfo.hpp
 sc/inc/PivotTableDataProvider.hxx:
 # base class has to be a complete type
 - com/sun/star/beans/XPropertySet.hpp
@@ -287,3 +291,6 @@ blacklist:
 sc/inc/types.hxx:
 # base class has to be a complete type
 - o3tl/typed_flags_set.hxx
+sc/inc/unitconv.hxx:
+# base class has to be a complete type
+- map
diff --git a/sc/inc/undorangename.hxx b/sc/inc/undorangename.hxx
index 46b4075eb7f0..2ad874c2ab96 100644
--- a/sc/inc/undorangename.hxx
+++ b/sc/inc/undorangename.hxx
@@ -11,7 +11,6 @@
 #define INCLUDED_SC_INC_UNDORANGENAME_HXX
 
 #include 
-#include "rangenam.hxx"
 
 #include 
 #include 
diff --git a/sc/inc/userdat.hxx b/sc/inc/userdat.hxx
index 8b1b1cee9e77..a85c5b3d8946 100644
--- a/sc/inc/userdat.hxx
+++ b/sc/inc/userdat.hxx
@@ -21,9 +21,7 @@
 #define INCLUDED_SC_INC_USERDAT_HXX
 
 #include 
-#include 
 #include 
-#include "global.hxx"
 #include "address.hxx"
 #include "drwlayer.hxx"
 
diff --git a/sc/inc/validat.hxx b/sc/inc/validat.hxx
index 92e87901fc9d..a451a999a659 100644
--- a/sc/inc/validat.hxx
+++ b/sc/inc/validat.hxx
@@ -21,7 +21,6 @@
 #define INCLUDED_SC_INC_VALIDAT_HXX
 
 #include "conditio.hxx"
-#include 
 #include "scdllapi.h"
 
 namespace vcl { class Window; }
diff --git a/sc/inc/viewopti.hxx b/sc/inc/viewopti.hxx
index 8bc3d380b28a..cd73ada6640e 100644
--- a/sc/inc/viewopti.hxx
+++ b/sc/inc/viewopti.hxx
@@ -22,7 +22,6 @@
 
 #include 
 
-#include 
 #include "scdllapi.h"
 #include "optutil.hxx"
 #include "global.hxx"
diff --git a/sc/inc/viewuno.hxx b/sc/inc/viewuno.hxx
index 839219677d4b..f9328fb87d95 100644
--- a/sc/inc/viewuno.hxx
+++ b/sc/inc/viewuno.hxx
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -40,7 +39,9 @@
 #include 
 #include 
 
-#include "address.hxx"
+#include "types.hxx"
+
+namespace com { namespace sun { namespace star { namespace view { class 
XSelectionChangeListener; } } } }
 
 class ScTabViewShell;
 class ScPreviewShell;
diff --git a/sc/inc/xmlwrap.hxx b/sc/inc/xmlwrap.hxx
index 0d3e79432c97..3327160b45c0 100644
--- a/sc/inc/xmlwrap.hxx
+++ b/sc/inc/xmlwrap.hxx
@@ -21,10 +21,7 @@
 #define INCLUDED_SC_INC_XMLWRAP_HXX
 
 #include 
-#include 
-#include 
 #include "importfilterdata.hxx"
-#include 
 
 #include 
 
@@ -32,8 +29,8 @@ namespace com { namespace sun { namespace star {
 namespace beans { struct PropertyValue; }
 namespace frame { class XModel; }
 namespace task { class XStatusIndicator; }
-namespace lang { class XMultiServiceFactory; }
-namespace uno { class XInterface; }
+namespace uno { class XComponentContext; }
+namespace uno { template  class Sequence; }
 namespace embed { class XStorage; }
 namespace xml {
 namespace sax { struct InputSource; class XParser; class XWriter; } }
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index cda718468f97..21d11f94d95c 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -18,6 +18,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/sc/source/core/data/validat.cxx b/sc/source/core/data/validat.cxx
index 813c9940ff9f..97c9effbb954 100644
--- a/sc/source/core/data/validat.cxx
+++

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-06-18 Thread Gabor Kelemen 
 sc/IwyuFilter_sc.yaml|   33 +
 sc/inc/TablePivotChart.hxx   |1 -
 sc/inc/TablePivotCharts.hxx  |3 ---
 sc/inc/tabbgcolor.hxx|2 +-
 sc/inc/table.hxx |   16 +---
 sc/inc/tabopparams.hxx   |1 -
 sc/inc/tabprotection.hxx |1 -
 sc/inc/targuno.hxx   |   27 ---
 sc/inc/textuno.hxx   |3 ---
 sc/inc/token.hxx |2 --
 sc/inc/tokenuno.hxx  |7 +++
 sc/inc/typedstrdata.hxx  |1 -
 sc/source/core/data/document.cxx |1 +
 sc/source/core/data/table1.cxx   |1 +
 sc/source/core/data/table2.cxx   |1 +
 sc/source/core/data/table5.cxx   |1 +
 sc/source/ui/unoobj/docuno.cxx   |1 +
 sc/source/ui/unoobj/targuno.cxx  |1 +
 18 files changed, 52 insertions(+), 51 deletions(-)

New commits:
commit cb9414f59eca713e1aebac0a2894e8c9412612b7
Author: Gabor Kelemen 
Date:   Sat May 19 07:29:47 2018 +0200

tdf#42949 Fix IWYU warnings in sc/inc/[Tt]*

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
and a bit of fallout management.

Change-Id: I347377d7bb2a0cf8acda1ad28b5cc79bb954ab7d
Reviewed-on: https://gerrit.libreoffice.org/55726
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 03aafba301b6..166b76fbd66b 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -254,3 +254,36 @@ blacklist:
 - com/sun/star/lang/XUnoTunnel.hpp
 - com/sun/star/style/XStyle.hpp
 - com/sun/star/style/XStyleLoader2.hpp
+sc/inc/TablePivotChart.hxx:
+# base class has to be a complete type
+- com/sun/star/container/XNamed.hpp
+- com/sun/star/document/XEmbeddedObjectSupplier.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/table/XTablePivotChart.hpp
+sc/inc/TablePivotCharts.hxx:
+# base class has to be a complete type
+- com/sun/star/container/XIndexAccess.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/table/XTablePivotCharts.hpp
+sc/inc/targuno.hxx:
+# base class has to be a complete type
+- com/sun/star/beans/XPropertySet.hpp
+- com/sun/star/container/XNameAccess.hpp
+- com/sun/star/document/XLinkTargetSupplier.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+sc/inc/textuno.hxx:
+# base class has to be a complete type
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/lang/XUnoTunnel.hpp
+- com/sun/star/text/XTextFieldsSupplier.hpp
+sc/inc/token.hxx:
+# needed for std::shared_ptr
+- memory
+sc/inc/tokenuno.hxx:
+# base class has to be a complete type
+- com/sun/star/beans/XPropertySet.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/sheet/XFormulaParser.hpp
+sc/inc/types.hxx:
+# base class has to be a complete type
+- o3tl/typed_flags_set.hxx
diff --git a/sc/inc/TablePivotChart.hxx b/sc/inc/TablePivotChart.hxx
index dce05e711f86..b94886bcf96f 100644
--- a/sc/inc/TablePivotChart.hxx
+++ b/sc/inc/TablePivotChart.hxx
@@ -17,7 +17,6 @@
 
 #include 
 #include 
-#include 
 
 #include "types.hxx"
 
diff --git a/sc/inc/TablePivotCharts.hxx b/sc/inc/TablePivotCharts.hxx
index f60726ee2650..b5c9deab92d6 100644
--- a/sc/inc/TablePivotCharts.hxx
+++ b/sc/inc/TablePivotCharts.hxx
@@ -11,13 +11,10 @@
 #define INCLUDED_SC_INC_TABLEPIVOTCHARTS_HXX
 
 #include 
-#include 
 #include 
-#include 
 #include 
 
 #include 
-#include 
 #include 
 
 #include "types.hxx"
diff --git a/sc/inc/tabbgcolor.hxx b/sc/inc/tabbgcolor.hxx
index e93385bd2b73..872d81285201 100644
--- a/sc/inc/tabbgcolor.hxx
+++ b/sc/inc/tabbgcolor.hxx
@@ -21,7 +21,7 @@
 #define INCLUDED_SC_INC_TABBGCOLOR_HXX
 
 #include 
-#include "address.hxx"
+#include "types.hxx"
 
 #include 
 
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index d310d998abc7..a2aa4c911b57 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -21,16 +21,12 @@
 #define INCLUDED_SC_INC_TABLE_HXX
 
 #include 
-#include 
 #include 
 #include 
-#include 
 #include "attarray.hxx"
 #include "column.hxx"
 #include "colcontainer.hxx"
 #include "sortparam.hxx"
-#include "compressedarray.hxx"
-#include "postit.hxx"
 #include "types.hxx"
 #include "cellvalue.hxx"
 #include 
@@ -39,9 +35,11 @@
 #include "document.hxx"
 
 #include 
-#include 
 #include 
 
+template  class ScBitMaskCompressedArray;
+template  class ScCompressedArray;
+
 namespace utl {
 class TextSearch;
 }
@@ -55,7 +53,6 @@ namespace com { namespace sun { namespace star {
 namespace formula { struct VectorRefArray; }
 namespace sc {
 
-struct FormulaGroupContext;
 class StartListeningContext;
 class EndListeningContext;
 class CopyFromClipContext;
@@ -76,8 +73,6 @@ class TableValues;
 class RowHeightContext;
 class CompileFormulaContext;
 struct SetFormulaDirtyContext;
-class RefMovedHint;
-struct ReorderParam;
 class

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-06-17 Thread Gabor Kelemen 
 sc/IwyuFilter_sc.yaml  |   19 +++
 sc/inc/PivotTableDataProvider.hxx  |   17 -
 sc/inc/PivotTableDataSequence.hxx  |5 +
 sc/inc/PivotTableDataSource.hxx|5 ++---
 sc/source/ui/unoobj/PivotTableDataSequence.cxx |1 +
 5 files changed, 31 insertions(+), 16 deletions(-)

New commits:
commit af625c8b7143bef6d2d61037427f9934607f336f
Author: Gabor Kelemen 
Date:   Wed Jun 13 22:06:33 2018 +0200

tdf#42949 Fix IWYU warnings in sc/inc/P*

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ic46d80186b0eb69e7bd8553278ffc9043b9b4bef
Reviewed-on: https://gerrit.libreoffice.org/55768
Tested-by: Jenkins
Reviewed-by: Jochen Nitschke 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index e2a2829c862d..03aafba301b6 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -197,6 +197,25 @@ blacklist:
 - com/sun/star/container/XNameAccess.hpp
 - com/sun/star/lang/XServiceInfo.hpp
 - cppuhelper/supportsservice.hxx
+sc/inc/PivotTableDataSequence.hxx:
+# base class has to be a complete type
+- com/sun/star/beans/XPropertySet.hpp
+- com/sun/star/chart2/data/DataSequenceRole.hpp
+- com/sun/star/chart2/data/XDataSequence.hpp
+- com/sun/star/chart2/data/XDataSequence.hpp
+- com/sun/star/chart2/data/XNumericalDataSequence.hpp
+- com/sun/star/chart2/data/XTextualDataSequence.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/util/XCloneable.hpp
+- com/sun/star/util/XModifyBroadcaster.hpp
+sc/inc/PivotTableDataProvider.hxx:
+# base class has to be a complete type
+- com/sun/star/beans/XPropertySet.hpp
+- com/sun/star/chart2/data/PivotTableFieldEntry.hpp
+- com/sun/star/chart2/data/XDataProvider.hpp
+- com/sun/star/chart2/data/XPivotTableDataProvider.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/util/XModifyBroadcaster.hpp
 sc/inc/reftokenhelper.hxx:
 # base class has to be a complete type
 - refdata.hxx
diff --git a/sc/inc/PivotTableDataProvider.hxx 
b/sc/inc/PivotTableDataProvider.hxx
index b1924753ece3..1403dfdad3d2 100644
--- a/sc/inc/PivotTableDataProvider.hxx
+++ b/sc/inc/PivotTableDataProvider.hxx
@@ -10,19 +10,11 @@
 #ifndef INCLUDED_SC_INC_PIVOTTABLEDATAPROVIDER_HXX
 #define INCLUDED_SC_INC_PIVOTTABLEDATAPROVIDER_HXX
 
-#include "cellsuno.hxx"
-#include "externalrefmgr.hxx"
-#include "types.hxx"
-
 #include 
 #include 
-#include 
-#include 
-#include 
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
@@ -30,8 +22,15 @@
 #include 
 #include 
 
-#include 
 #include 
+#include 
+
+namespace com { namespace sun { namespace star { namespace chart2 { namespace 
data { class XDataSequence; } } } } }
+namespace com { namespace sun { namespace star { namespace chart2 { namespace 
data { class XDataSource; } } } } }
+namespace com { namespace sun { namespace star { namespace chart2 { namespace 
data { class XLabeledDataSequence; } } } } }
+namespace com { namespace sun { namespace star { namespace uno { class 
XComponentContext; } } } }
+
+class ScDocument;
 
 namespace sc
 {
diff --git a/sc/inc/PivotTableDataSequence.hxx 
b/sc/inc/PivotTableDataSequence.hxx
index 470a7a5b2f0c..8448edcc5a9e 100644
--- a/sc/inc/PivotTableDataSequence.hxx
+++ b/sc/inc/PivotTableDataSequence.hxx
@@ -25,10 +25,7 @@
 #include 
 #include 
 
-#include "unonames.hxx"
-#include "document.hxx"
-
-#include "dpsave.hxx"
+class ScDocument;
 
 namespace sc
 {
diff --git a/sc/inc/PivotTableDataSource.hxx b/sc/inc/PivotTableDataSource.hxx
index e6eda8be6c75..a98f977cc0ec 100644
--- a/sc/inc/PivotTableDataSource.hxx
+++ b/sc/inc/PivotTableDataSource.hxx
@@ -15,10 +15,9 @@
 
 #include 
 #include 
+#include 
 
-#include "document.hxx"
-
-#include 
+namespace com { namespace sun { namespace star { namespace chart2 { namespace 
data { class XLabeledDataSequence; } } } } }
 
 namespace sc
 {
diff --git a/sc/source/ui/unoobj/PivotTableDataSequence.cxx 
b/sc/source/ui/unoobj/PivotTableDataSequence.cxx
index ee14b9b85f2f..7cfc609c6512 100644
--- a/sc/source/ui/unoobj/PivotTableDataSequence.cxx
+++ b/sc/source/ui/unoobj/PivotTableDataSequence.cxx
@@ -16,6 +16,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-06-11 Thread Gabor Kelemen 
 sc/IwyuFilter_sc.yaml   |   32 
 sc/inc/sc.hrc   |2 --
 sc/inc/scextopt.hxx |1 -
 sc/inc/scitems.hxx  |1 -
 sc/inc/scmatrix.hxx |5 +
 sc/inc/scres.hrc|1 -
 sc/inc/segmenttree.hxx  |2 +-
 sc/inc/servuno.hxx  |6 --
 sc/inc/sheetdata.hxx|2 --
 sc/inc/simplerangelist.hxx  |3 ---
 sc/inc/spellcheckcontext.hxx|3 ++-
 sc/inc/stlalgorithm.hxx |1 -
 sc/inc/styleuno.hxx |   10 +-
 sc/inc/subtotalparam.hxx|1 -
 sc/source/core/data/drwlayer.cxx|1 +
 sc/source/core/data/segmenttree.cxx |1 +
 sc/source/filter/excel/xehelper.cxx |1 +
 sc/source/filter/excel/xistyle.cxx  |1 +
 sc/source/filter/excel/xlroot.cxx   |1 +
 19 files changed, 50 insertions(+), 25 deletions(-)

New commits:
commit d2dab4079b716f3c2a2c53ab8070340995aed58d
Author: Gabor Kelemen 
Date:   Thu May 17 20:01:16 2018 +0200

tdf#42949 Fix IWYU warnings in sc/inc/s*

Found with bin/find-unneeded-includes
Removal proposals and fallout management are dealt with here.

Change-Id: I21217fbac071f06987b989e735982b2dfad6a54e
Reviewed-on: https://gerrit.libreoffice.org/55537
Tested-by: Jenkins 
Reviewed-by: Jochen Nitschke 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index a72dfb5d1d58..e2a2829c862d 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -203,3 +203,35 @@ blacklist:
 sc/inc/rowheightcontext.hxx:
 # base class has to be a complete type
 - vcl/outdev.hxx
+sc/inc/scerrors.hxx:
+# needed for defines
+- vcl/errcode.hxx
+sc/inc/scitems.hxx:
+# needed for defines
+- svl/typedwhich.hxx
+sc/inc/scmatrix.hxx:
+# base class has to be a complete type
+- svl/sharedstringpool.hxx
+sc/inc/simplerangelist.hxx:
+# base class has to be a complete type
+- memory
+sc/inc/spellcheckcontext.hxx:
+# base class has to be a complete type
+- editeng/misspellrange.hxx
+sc/inc/srchuno.hxx:
+# base class has to be a complete type
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/lang/XUnoTunnel.hpp
+- com/sun/star/util/XReplaceDescriptor.hpp
+sc/inc/styleuno.hxx:
+# base class has to be a complete type
+- com/sun/star/beans/XMultiPropertySet.hpp
+- com/sun/star/beans/XMultiPropertyStates.hpp
+- com/sun/star/beans/XPropertySet.hpp
+- com/sun/star/beans/XPropertyState.hpp
+- com/sun/star/container/XIndexAccess.hpp
+- com/sun/star/container/XNameContainer.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/lang/XUnoTunnel.hpp
+- com/sun/star/style/XStyle.hpp
+- com/sun/star/style/XStyleLoader2.hpp
diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc
index ba6fbc6686dd..961b17979070 100644
--- a/sc/inc/sc.hrc
+++ b/sc/inc/sc.hrc
@@ -23,8 +23,6 @@
 #include 
 #include 
 
-#include 
-
 // areas
 
 #define SC_VIEW_START   (SID_SC_START)
diff --git a/sc/inc/scextopt.hxx b/sc/inc/scextopt.hxx
index 8edc960782fa..22c48d687961 100644
--- a/sc/inc/scextopt.hxx
+++ b/sc/inc/scextopt.hxx
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include "global.hxx"
 #include "rangelst.hxx"
 
 /** Extended settings for the document, used in import/export filters. */
diff --git a/sc/inc/scitems.hxx b/sc/inc/scitems.hxx
index d304828ccaf9..d5871af119fe 100644
--- a/sc/inc/scitems.hxx
+++ b/sc/inc/scitems.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_SC_INC_SCITEMS_HXX
 #define INCLUDED_SC_INC_SCITEMS_HXX
 
-#include 
 #include 
 
 //  EditEngine is not allowed to define its own ITEMID's
diff --git a/sc/inc/scmatrix.hxx b/sc/inc/scmatrix.hxx
index 9be335fbc06b..2dbd3490cfb9 100644
--- a/sc/inc/scmatrix.hxx
+++ b/sc/inc/scmatrix.hxx
@@ -20,20 +20,17 @@
 #ifndef INCLUDED_SC_INC_SCMATRIX_HXX
 #define INCLUDED_SC_INC_SCMATRIX_HXX
 
-#include "global.hxx"
+#include "address.hxx"
 #include "matrixoperators.hxx"
 #include "types.hxx"
 #include 
 #include "scdllapi.h"
-#include 
 #include 
 #include 
 
-#include 
 #include 
 #include 
 #include 
-#include 
 
 #define DEBUG_MATRIX 0
 
diff --git a/sc/inc/scres.hrc b/sc/inc/scres.hrc
index 40c92cedf77d..3189dc9f27fe 100644
--- a/sc/inc/scres.hrc
+++ b/sc/inc/scres.hrc
@@ -21,7 +21,6 @@
 #define SC_SCRES_HRC
 
 #include "sc.hrc"
-#include 
 
 #define STR_START   (SC_RESOURCE_START+100)
 
diff --git a/sc/inc/segmenttree.hxx b/sc/inc/segmenttree.hxx
index 53eec168a722..40f584a931d5 100644
--- a/sc/inc/segmenttree.hxx
+++ b/sc/inc/segmenttree.hxx
@@ -20,7 +20,7 @@
 #ifndef INCLUDED_SC_INC_SEGMENTTREE_HXX
 #define INCLUDED_SC_INC_SEGMENTTREE_HXX
 
-#include "address.hxx"
+#include "types.hxx"
 
 #include 
 
diff --git a/sc/inc/servuno.hxx b/sc/inc/servuno.hxx
index d3e55bcaf272..aa0ab5151ec4 100644
--- a/sc/inc/servuno.hxx
+++

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-05-25 Thread Gabor Kelemen 
 sc/IwyuFilter_sc.yaml  |4 
 sc/inc/attrib.hxx  |1 +
 sc/inc/chartpos.hxx|1 +
 sc/inc/conditio.hxx|2 ++
 sc/inc/consoli.hxx |1 +
 sc/inc/dociter.hxx |1 +
 sc/inc/document.hxx|1 +
 sc/inc/global.hxx  |9 ++---
 sc/inc/grouparealistener.hxx   |1 -
 sc/inc/helpids.h   |2 --
 sc/inc/hints.hxx   |1 +
 sc/inc/queryentry.hxx  |1 +
 sc/source/core/data/markarr.cxx|1 +
 sc/source/core/tool/jumpmatrix.cxx |2 +-
 sc/source/core/tool/zforauto.cxx   |1 +
 sc/source/filter/inc/formel.hxx|1 +
 sc/source/filter/xml/XMLExportSharedData.hxx   |1 +
 sc/source/filter/xml/XMLStylesExportHelper.cxx |1 +
 sc/source/filter/xml/xmlimprt.hxx  |1 +
 sc/source/ui/inc/impex.hxx |1 +
 sc/source/ui/inc/inputhdl.hxx  |1 +
 sc/source/ui/inc/pfuncache.hxx |1 +
 sc/source/ui/inc/rfindlst.hxx  |1 +
 23 files changed, 26 insertions(+), 11 deletions(-)

New commits:
commit f8edef392245c292398a80f6a858ca19f32df9c3
Author: Gabor Kelemen 
Date:   Sun May 13 22:19:46 2018 +0200

tdf#42949 Fix IWYU warnings in sc/inc/[gh]*

Found with bin/find-unneeded-includes
Simple removal proposals are dealt with here
and a bit of fallout management

Change-Id: Ia6f8d4ca46d7b218f5827052ced5641367bd4478
Reviewed-on: https://gerrit.libreoffice.org/54683
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 84b23623a578..853e06214546 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -177,3 +177,7 @@ blacklist:
 - global.hxx
 # Needed for macros
 - calcmacros.hxx
+sc/inc/global.hxx:
+# base class has to be a complete type
+- com/sun/star/uno/Reference.hxx
+- tools/ref.hxx
diff --git a/sc/inc/attrib.hxx b/sc/inc/attrib.hxx
index d44a7cce4d77..fadbad0639ac 100644
--- a/sc/inc/attrib.hxx
+++ b/sc/inc/attrib.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SC_INC_ATTRIB_HXX
 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/sc/inc/chartpos.hxx b/sc/inc/chartpos.hxx
index cde8b9ff5285..275c4da1dafd 100644
--- a/sc/inc/chartpos.hxx
+++ b/sc/inc/chartpos.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SC_INC_CHARTPOS_HXX
 
 #include "rangelst.hxx"
+#include 
 #include 
 #include 
 
diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx
index 6fd387a0e100..21a670053c11 100644
--- a/sc/inc/conditio.hxx
+++ b/sc/inc/conditio.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SC_INC_CONDITIO_HXX
 
 #include "global.hxx"
+#include 
 #include "address.hxx"
 #include 
 #include "scdllapi.h"
@@ -42,6 +43,7 @@
 class ScFormulaCell;
 class ScTokenArray;
 struct ScRefCellValue;
+class Color;
 
 namespace sc {
 
diff --git a/sc/inc/consoli.hxx b/sc/inc/consoli.hxx
index 015245cd1895..d16a082ce578 100644
--- a/sc/inc/consoli.hxx
+++ b/sc/inc/consoli.hxx
@@ -22,6 +22,7 @@
 
 #include "global.hxx"
 #include "address.hxx"
+#include 
 
 class ScDocument;
 
diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx
index ac76f7412a9a..920759abc8c4 100644
--- a/sc/inc/dociter.hxx
+++ b/sc/inc/dociter.hxx
@@ -43,6 +43,7 @@ struct ScQueryParam;
 struct ScDBQueryParamInternal;
 struct ScDBQueryParamMatrix;
 class ScFormulaCell;
+class OutputDevice;
 struct ScInterpreterContext;
 enum class SvNumFormatType : sal_Int16;
 
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 77dfca451d2a..ccade9f02c6f 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include "scdllapi.h"
diff --git a/sc/inc/global.hxx b/sc/inc/global.hxx
index bbdd26d9d38a..050e38250508 100644
--- a/sc/inc/global.hxx
+++ b/sc/inc/global.hxx
@@ -23,18 +23,16 @@
 #include "address.hxx"
 #include 
 #include 
-#include 
+#include 
+#include 
 #include 
 #include "scdllapi.h"
 #include 
 
 #include 
-#include 
 
-class Bitmap;
 class SfxItemSet;
 class SfxViewShell;
-class Color;
 struct ScCalcConfig;
 enum class SvtScriptType;
 enum class FormulaError : sal_uInt16;
@@ -460,7 +458,6 @@ struct ScImportParam
 booloperator==  ( const ScImportParam& r ) const;
 };
 
-class ScDocument;
 class ScDocShell;
 class SvxSearchItem;
 class ScAutoFormat;
@@ -471,7 +468,6 @@ class SvxBrushItem;
 class ScFunctionList;
 class ScFunctionMgr;
 class SfxItemPool;
-class SdrModel;
 class EditTextObject;
 class SfxObjectShell;
 class SvNumberFormatter;
@@ -482,7 +478,6 @@ class SvtSysLocale;
 class

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-05-22 Thread Gabor Kelemen 
 sc/IwyuFilter_sc.yaml |5 +
 sc/inc/formularesult.hxx  |8 +++-
 sc/source/core/data/clipcontext.cxx   |1 +
 sc/source/core/data/colorscale.cxx|1 +
 sc/source/core/data/column3.cxx   |1 +
 sc/source/core/data/formulaiter.cxx   |1 +
 sc/source/core/data/table1.cxx|1 +
 sc/source/core/tool/consoli.cxx   |1 +
 sc/source/core/tool/formularesult.cxx |1 +
 sc/source/core/tool/sharedformula.cxx |1 +
 10 files changed, 20 insertions(+), 1 deletion(-)

New commits:
commit 494f1a98bf32bea014c277bd0bee81b9aab5c966
Author: Gabor Kelemen 
Date:   Wed May 16 08:18:07 2018 +0200

tdf#42949 Fix IWYU warnings in sc/inc/formularesult.hxx

Found with bin/find-unneeded-includes
This one caused lots of fallout, manage it separately

Change-Id: Idf153caa07b1edd85352609806f5b8b74fc6ead8
Reviewed-on: https://gerrit.libreoffice.org/54410
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 455aabd20da0..84b23623a578 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -172,3 +172,8 @@ blacklist:
 sc/inc/formulaparserpool.hxx:
 # base class has to be a complete type
 - com/sun/star/sheet/XFormulaParser.hpp
+sc/inc/formularesult.hxx:
+# Needed for enum
+- global.hxx
+# Needed for macros
+- calcmacros.hxx
diff --git a/sc/inc/formularesult.hxx b/sc/inc/formularesult.hxx
index 4797b5939522..b5fd6228dc41 100644
--- a/sc/inc/formularesult.hxx
+++ b/sc/inc/formularesult.hxx
@@ -20,8 +20,14 @@
 #ifndef INCLUDED_SC_INC_FORMULARESULT_HXX
 #define INCLUDED_SC_INC_FORMULARESULT_HXX
 
-#include "token.hxx"
 #include "scdllapi.h"
+#include "global.hxx"
+#include "calcmacros.hxx"
+#include 
+#include 
+#include 
+
+class ScMatrixFormulaCellToken;
 
 namespace sc {
 
diff --git a/sc/source/core/data/clipcontext.cxx 
b/sc/source/core/data/clipcontext.cxx
index 1f35be3fe9c8..47eca9167cf8 100644
--- a/sc/source/core/data/clipcontext.cxx
+++ b/sc/source/core/data/clipcontext.cxx
@@ -19,6 +19,7 @@
 
 #include 
 #include 
+#include 
 
 namespace sc {
 
diff --git a/sc/source/core/data/colorscale.cxx 
b/sc/source/core/data/colorscale.cxx
index 77e2d1a7c524..4ea3606e48b8 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -15,6 +15,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index 114b132d797f..fc9f253e72fd 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -63,6 +63,7 @@
 #include 
 
 #include 
+#include 
 
 using ::com::sun::star::i18n::LocaleDataItem2;
 
diff --git a/sc/source/core/data/formulaiter.cxx 
b/sc/source/core/data/formulaiter.cxx
index ac5369285b49..bd37a4bc2163 100644
--- a/sc/source/core/data/formulaiter.cxx
+++ b/sc/source/core/data/formulaiter.cxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace formula;
 
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index adaf36c92ceb..c6627ab126d0 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -52,6 +52,7 @@
 #include 
 
 #include 
+#include 
 
 #include 
 #include 
diff --git a/sc/source/core/tool/consoli.cxx b/sc/source/core/tool/consoli.cxx
index bc0bd265bb70..dc085b19882f 100644
--- a/sc/source/core/tool/consoli.cxx
+++ b/sc/source/core/tool/consoli.cxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
diff --git a/sc/source/core/tool/formularesult.cxx 
b/sc/source/core/tool/formularesult.cxx
index 1b3fcd995f8a..c1ed01516113 100644
--- a/sc/source/core/tool/formularesult.cxx
+++ b/sc/source/core/tool/formularesult.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 
 namespace sc {
 
diff --git a/sc/source/core/tool/sharedformula.cxx 
b/sc/source/core/tool/sharedformula.cxx
index ea55273bbc7c..e18e1adf09b4 100644
--- a/sc/source/core/tool/sharedformula.cxx
+++ b/sc/source/core/tool/sharedformula.cxx
@@ -13,6 +13,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace sc {
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

2018-05-18 Thread Gabor Kelemen 
 sc/IwyuFilter_sc.yaml  |   39 +
 sc/inc/fillinfo.hxx|2 -
 sc/inc/filter.hxx  |1 
 sc/inc/filtuno.hxx |2 -
 sc/inc/fmtuno.hxx  |1 
 sc/inc/formulacell.hxx |4 ---
 sc/inc/formulagroup.hxx|3 --
 sc/inc/formulaopt.hxx  |2 -
 sc/inc/funcdesc.hxx|5 
 sc/source/core/tool/formulaopt.cxx |2 -
 10 files changed, 40 insertions(+), 21 deletions(-)

New commits:
commit 88bbceb7c3ff1560b4ab5caf4b42cd6dfd92b971
Author: Gabor Kelemen 
Date:   Sat May 12 00:03:20 2018 +0200

tdf#42949 Fix IWYU warnings in sc/inc/f*

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
with minimal fallout management

Change-Id: I5574c9ccac02977c9cde01e24534f82dd9ec82be
Reviewed-on: https://gerrit.libreoffice.org/54409
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index d76f1530a56e..455aabd20da0 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -133,3 +133,42 @@ blacklist:
 # base class has to be a complete type
 - com/sun/star/container/XNameReplace.hpp
 - com/sun/star/lang/XServiceInfo.hpp
+sc/inc/fillinfo.hxx:
+# base class has to be a complete type
+- o3tl/typed_flags_set.hxx
+sc/inc/filtuno.hxx:
+# base class has to be a complete type
+- com/sun/star/beans/XPropertyAccess.hpp
+- com/sun/star/document/XExporter.hpp
+- com/sun/star/document/XImporter.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/ui/dialogs/XExecutableDialog.hpp
+sc/inc/fmtuno.hxx:
+# base class has to be a complete type
+- com/sun/star/beans/XPropertySet.hpp
+- com/sun/star/container/XEnumerationAccess.hpp
+- com/sun/star/container/XNameAccess.hpp
+- com/sun/star/lang/XUnoTunnel.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/sheet/FormulaToken.hpp
+- com/sun/star/sheet/XSheetCondition2.hpp
+- com/sun/star/sheet/XMultiFormulaTokens.hpp
+- com/sun/star/sheet/XSheetConditionalEntries.hpp
+- com/sun/star/sheet/XSheetConditionalEntry.hpp
+sc/inc/fonthelper.hxx:
+# base class has to be a complete type
+- tools/color.hxx
+sc/inc/formulagroup.hxx:
+# base class has to be a complete type
+- opencl/platforminfo.hxx
+sc/inc/formulacell.hxx:
+# base class has to be a complete type
+- interpretercontext.hxx
+sc/inc/formulalogger.hxx:
+# base class has to be a complete type
+- memory
+# needed for conditionally enabled code path
+- struct ScFormulaCellGroup
+sc/inc/formulaparserpool.hxx:
+# base class has to be a complete type
+- com/sun/star/sheet/XFormulaParser.hpp
diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index e21a11c9a088..41cac93beae9 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -25,7 +25,6 @@
 #include 
 
 #include 
-#include "global.hxx"
 #include "colorscale.hxx"
 #include "cellvalue.hxx"
 #include 
@@ -35,7 +34,6 @@ class SvxBrushItem;
 class SvxBoxItem;
 class SvxLineItem;
 class SvxShadowItem;
-class Color;
 
 class ScPatternAttr;
 
diff --git a/sc/inc/filter.hxx b/sc/inc/filter.hxx
index 11ef4398a701..770d35e91350 100644
--- a/sc/inc/filter.hxx
+++ b/sc/inc/filter.hxx
@@ -22,7 +22,6 @@
 
 #include 
 #include 
-#include 
 #include 
 
 #include "scdllapi.h"
diff --git a/sc/inc/filtuno.hxx b/sc/inc/filtuno.hxx
index 01acc3ccc565..dd6b55950d09 100644
--- a/sc/inc/filtuno.hxx
+++ b/sc/inc/filtuno.hxx
@@ -24,10 +24,8 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
-#include "scdllapi.h"
 
 namespace com { namespace sun { namespace star { namespace io {
 class XInputStream;
diff --git a/sc/inc/fmtuno.hxx b/sc/inc/fmtuno.hxx
index 82e8b9acb445..267828795ecf 100644
--- a/sc/inc/fmtuno.hxx
+++ b/sc/inc/fmtuno.hxx
@@ -43,7 +43,6 @@
 
 class ScDocument;
 class ScTableConditionalEntry;
-class ScConditionalFormat;
 class ScValidationData;
 
 struct ScCondFormatEntryItem
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index 458dc2e10b7c..7656e7a3efec 100644
--- a/sc/inc/formulacell.hxx
+++ b/sc/inc/formulacell.hxx
@@ -20,13 +20,9 @@
 #ifndef INCLUDED_SC_INC_FORMULACELL_HXX
 #define INCLUDED_SC_INC_FORMULACELL_HXX
 
-#include 
 #include 
 
 #include 
-#include 
-#include 
-#include 
 #include 
 
 #include "types.hxx"
diff --git a/sc/inc/formulagroup.hxx b/sc/inc/formulagroup.hxx
index a02157439448..fa6bb4f61877 100644
--- a/sc/inc/formulagroup.hxx
+++ b/sc/inc/formulagroup.hxx
@@ -17,14 +17,11 @@
 #include "types.hxx"
 #include "stlalgorithm.hxx"
 
-#include 
 #if HAVE_FEATURE_OPENCL
 #include 
 #endif
-#include 
 
 #include 
-#include 
 #include 
 #include 
 
diff --git a/sc/inc/formulaopt.hxx b/sc/inc/formulaopt.hxx