[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk| 23 solenv/sanitizers/ui/cui.suppr | 111 +++ solenv/sanitizers/ui/dbaccess.suppr | 31 ++ solenv/sanitizers/ui/desktop.suppr |1 solenv/sanitizers/ui/filter.suppr| 23 solenv/sanitizers/ui/modules/BasicIDE.suppr |4 solenv/sanitizers/ui/modules/dbreport.suppr |2 solenv/sanitizers/ui/modules/sabpilot.suppr | 29 ++ solenv/sanitizers/ui/modules/sbibliography.suppr | 31 ++ solenv/sanitizers/ui/modules/scalc.suppr | 61 solenv/sanitizers/ui/modules/schart.suppr| 16 +++ solenv/sanitizers/ui/modules/sdraw.suppr |6 + solenv/sanitizers/ui/modules/simpress.suppr |8 + solenv/sanitizers/ui/modules/smath.suppr | 24 solenv/sanitizers/ui/modules/spropctrlr.suppr|3 solenv/sanitizers/ui/modules/swriter.suppr | 91 ++ solenv/sanitizers/ui/sfx.suppr |8 + solenv/sanitizers/ui/svt.suppr | 21 solenv/sanitizers/ui/svx.suppr | 51 ++ solenv/sanitizers/ui/uui.suppr |9 + solenv/sanitizers/ui/vcl.suppr |3 solenv/sanitizers/ui/writerperfect.suppr |2 22 files changed, 535 insertions(+), 23 deletions(-) New commits: commit 3c51047edc9209ca97e9d6611deb4258d5be71d2 Author: Samuel Thibault AuthorDate: Wed Jun 13 12:50:44 2018 +0200 Commit: Thorsten Behrens CommitDate: Fri Jul 20 16:46:18 2018 +0200 gla11y: Enable warnings for all orphan labels This completes enabling all gla11y warnings Change-Id: I791de2f03ec09098bd52bfff515270d15584d70d Reviewed-on: https://gerrit.libreoffice.org/57609 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 3098b56cea0f..08922c5c955a 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -149,29 +149,6 @@ gb_UIConfig_gla11y_PARAMETERS += --widgets-button +vcllo-SmallButton,cuilo-RubyR # All new warnings should be fatal except a few kinds which could be only doubtful gb_UIConfig_gla11y_PARAMETERS += --fatal-all --not-fatal-type duplicate-mnemonic --not-fatal-type labelled-by-and-mnemonic --not-fatal-type orphan-label -# Disable all warnings types by default for now, to enable warnings types progressively -gb_UIConfig_gla11y_PARAMETERS += --disable-all - -# For now, ignore orphan labels without an unlabelled widget -gb_UIConfig_gla11y_PARAMETERS += --disable-orphan-labels -# but do not ignore orphan labels with an unlabelled widget -gb_UIConfig_gla11y_PARAMETERS += --enable-type orphan-label - -# The following are to be uncommented progressively - -# These are definite errors -gb_UIConfig_gla11y_PARAMETERS += --enable-type undeclared-target -gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-label-for -gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-labelled-by -gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-id - -# These are often buttons with only an image -gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label -# These are often doubtful -gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-mnemonic --enable-type labelled-by-and-mnemonic - -gb_UIConfig_gla11y_PARAMETERS += --enable-type no-labelled-by - define gb_UIConfig_a11yerrors__command $(call gb_Output_announce,$(2),$(true),UIA,1) $(call gb_UIConfig__gla11y_command) diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index 0780cd7415f3..b503cb85b775 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -26,10 +26,27 @@ cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='m'] orphan-label cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='t'] orphan-label cui/uiconfig/ui/applylocalizedpage.ui://svtlo-SvSimpleTableContainer[@id='list:border'] no-labelled-by cui/uiconfig/ui/applylocalizedpage.ui://svxcorelo-SvxCheckListBox[@id='checklist:border'] no-labelled-by +cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='singlestartex'] orphan-label +cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='singleendex'] orphan-label +cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='doublestartex'] orphan-label +cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='doubleendex'] orphan-label cui/uiconfig/ui/assigncomponentdialog.ui://GtkLabel[@id='label1'] orphan-label cui/uiconfig/ui/assigncomponentdialog.ui://GtkEntry[@id='methodEntry'] no-labelled-by cui/uiconfig/ui/autocorrectdialog.ui://GtkLabel[@id='label1'] orphan-label cui/uiconfig/ui/autocorrectdialog.ui://svxcorelo-SvxLanguageBox[@id='lang'] no-labelled-by +cui/uiconfig/ui/backgroundpage.ui://GtkLabel[@id='fileft'] orphan-label +cui/uiconfig/ui/backgroundpage.ui://GtkLabel[@id='unlinkedft'] orphan-label +cu
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk | 26 -- solenv/sanitizers/ui/cui.suppr | 70 solenv/sanitizers/ui/dbaccess.suppr | 26 ++ solenv/sanitizers/ui/desktop.suppr |3 + solenv/sanitizers/ui/fps.suppr |1 solenv/sanitizers/ui/modules/BasicIDE.suppr |3 + solenv/sanitizers/ui/modules/scalc.suppr| 29 +++ solenv/sanitizers/ui/modules/schart.suppr | 10 solenv/sanitizers/ui/modules/simpress.suppr | 14 + solenv/sanitizers/ui/modules/swriter.suppr | 31 +++- solenv/sanitizers/ui/sfx.suppr | 46 ++ solenv/sanitizers/ui/svx.suppr | 14 + solenv/sanitizers/ui/vcl.suppr |1 solenv/sanitizers/ui/xmlsec.suppr |3 + 14 files changed, 230 insertions(+), 47 deletions(-) New commits: commit 7ba295853669f7c333ba22e8284e9732091c67fa Author: Samuel Thibault AuthorDate: Wed Jun 13 12:08:19 2018 +0200 Commit: Thorsten Behrens CommitDate: Wed Jul 18 02:15:26 2018 +0200 gla11y: Enable warnings for all widgets missing a label Change-Id: I60c0eef6b7532a4631c6f56902a4691b0105e691 Reviewed-on: https://gerrit.libreoffice.org/57403 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 7dea8a2720a6..3098b56cea0f 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -170,31 +170,7 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label # These are often doubtful gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-mnemonic --enable-type labelled-by-and-mnemonic -# For now, disable warning about widgets without a label by default, to enable warnings for classes progressively -# To be uncommented progressively -gb_UIConfig_gla11y_PARAMETERS += --disable-type no-labelled-by -# Clearly need labelling -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkScale -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkEntry -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinButton -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinner -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkProgressBar -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-SvxColorListBox -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-SvxLanguageBox -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.sfxlo-SvxCharView -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.foruilo-RefEdit -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-PaperSizeListBox -# Probably need labelling -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBox -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBoxText -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkMenuItem -# Possibly need labelling -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTreeView -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTreeViewColumn -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTextView -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkDrawingArea -# Perhaps need labelling -gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkImage +gb_UIConfig_gla11y_PARAMETERS += --enable-type no-labelled-by define gb_UIConfig_a11yerrors__command $(call gb_Output_announce,$(2),$(true),UIA,1) diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index 38d31b00995b..0780cd7415f3 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -14,6 +14,18 @@ cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='preference'] orphan-label cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='property'] orphan-label cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='type'] orphan-label cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='value'] orphan-label +cui/uiconfig/ui/aboutconfigdialog.ui://svtlo-SvSimpleTableContainer[@id='preferences'] no-labelled-by +cui/uiconfig/ui/aboutconfigvaluedialog.ui://GtkLabel[@id='label1'] orphan-label +cui/uiconfig/ui/aboutconfigvaluedialog.ui://cuilo-CuiCustomMultilineEdit[@id='valuebox'] no-labelled-by +cui/uiconfig/ui/applyautofmtpage.ui://GtkLabel[@id='label1'] orphan-label +cui/uiconfig/ui/applyautofmtpage.ui://GtkLabel[@id='label2'] orphan-label +cui/uiconfig/ui/applyautofmtpage.ui://GtkLabel[@id='m'] orphan-label +cui/uiconfig/ui/applyautofmtpage.ui://GtkLabel[@id='t'] orphan-label +cui/uiconfig/ui/applyautofmtpage.ui://svtlo-SvSimpleTableContainer[@id='list'] no-labelled-by +cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='m'] orphan-label +cui/uiconfig/ui/applylocalized
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk |2 - solenv/sanitizers/ui/cui.suppr | 20 +++ solenv/sanitizers/ui/desktop.suppr |7 + solenv/sanitizers/ui/modules/scalc.suppr |5 +++ solenv/sanitizers/ui/modules/scanner.suppr |2 + solenv/sanitizers/ui/modules/schart.suppr |6 solenv/sanitizers/ui/modules/smath.suppr |1 solenv/sanitizers/ui/modules/swriter.suppr |6 solenv/sanitizers/ui/sfx.suppr | 15 +++ solenv/sanitizers/ui/vcl.suppr |1 solenv/sanitizers/ui/xmlsec.suppr | 38 + 11 files changed, 102 insertions(+), 1 deletion(-) New commits: commit e92dcc0632dbdecbc561a35530c21ea66c04f85a Author: Samuel Thibault AuthorDate: Wed Jun 13 12:02:16 2018 +0200 Commit: Thorsten Behrens CommitDate: Fri Jul 13 19:20:18 2018 +0200 gla11y: Enable warnings for GtkImage missing a label Change-Id: I6ba9c6bcb8ce4faef6853ea25b2a9e68a67d0087 Reviewed-on: https://gerrit.libreoffice.org/56152 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 1ebb9c3e5d48..7dea8a2720a6 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -194,7 +194,7 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTreeViewCol gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTextView gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkDrawingArea # Perhaps need labelling -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkImage +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkImage define gb_UIConfig_a11yerrors__command $(call gb_Output_announce,$(2),$(true),UIA,1) diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index b3391beb3257..38d31b00995b 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -1,3 +1,4 @@ +cui/uiconfig/ui/aboutdialog.ui://GtkImage[@id='logo'] no-labelled-by cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='logoreplacement'] orphan-label cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='buildid'] orphan-label cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='locale'] orphan-label @@ -169,6 +170,11 @@ cui/uiconfig/ui/fmsearchdialog.ui://GtkLabel[@id='replacedesc'] orphan-label cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='incrementslider'] no-labelled-by cui/uiconfig/ui/gradientpage.ui://GtkLabel[@id='centerft'] orphan-label cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='borderslider'] no-labelled-by +cui/uiconfig/ui/eventsconfigpage.ui://GtkLabel[@id='label1'] orphan-label +cui/uiconfig/ui/eventsconfigpage.ui://GtkLabel[@id='eventft'] orphan-label +cui/uiconfig/ui/eventsconfigpage.ui://GtkLabel[@id='actionft'] orphan-label +cui/uiconfig/ui/eventsconfigpage.ui://GtkImage[@id='macroimg'] no-labelled-by +cui/uiconfig/ui/eventsconfigpage.ui://GtkImage[@id='componentimg'] no-labelled-by cui/uiconfig/ui/hangulhanjaconversiondialog.ui://GtkLabel[@id='label1'] orphan-label cui/uiconfig/ui/hangulhanjaconversiondialog.ui://GtkLabel[@id='originalword'] orphan-label cui/uiconfig/ui/hangulhanjaconversiondialog.ui://GtkLabel[@id='label3'] orphan-label @@ -224,17 +230,25 @@ cui/uiconfig/ui/movemenu.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labell cui/uiconfig/ui/newlibdialog.ui://GtkEntry[@id='entry'] duplicate-mnemonic cui/uiconfig/ui/objecttitledescdialog.ui://GtkLabel[@id='desc_label'] orphan-label cui/uiconfig/ui/objecttitledescdialog.ui://GtkTextView[@id='desc_entry'] no-labelled-by +cui/uiconfig/ui/optemailpage.ui://GtkImage[@id='lockemail'] no-labelled-by cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='browsetitle'] orphan-label cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='suppress'] orphan-label cui/uiconfig/ui/optemailpage.ui://GtkCheckButton[@id='suppressHidden'] button-no-label +cui/uiconfig/ui/optemailpage.ui://GtkImage[@id='lockSuppressHidden'] no-labelled-by cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='always'] orphan-label cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='screenonly'] orphan-label cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='font'] orphan-label cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='replacewith'] orphan-label cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='apply'] button-no-label cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='delete'] button-no-label +cui/uiconfig/ui/optpathspage.ui://GtkLabel[@id='type'] orphan-label +cui/uiconfig/ui/optpathspage.ui://GtkLabel[@id='path'] orphan-label +cui/uiconfig/ui/optpathspage.ui://GtkLabel[@id='editpaths'] orphan-label +cui/uiconfig/ui/optpathspage.ui://GtkImage[@id='lock'] no-labelled-by cui/uiconfig/ui/optsavepage.ui://GtkSpinButton[@id='autosave_spin'] no-labelled-by cui/uiconfig/ui/optsavepage.ui://GtkLabel[@id='autosave_mins'] orphan-label +cui/uiconfig/ui/optsavepage.u
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk |8 +-- solenv/sanitizers/ui/cui.suppr | 67 +++- solenv/sanitizers/ui/dbaccess.suppr |4 + solenv/sanitizers/ui/desktop.suppr |3 + solenv/sanitizers/ui/filter.suppr |4 + solenv/sanitizers/ui/fps.suppr |1 solenv/sanitizers/ui/modules/sabpilot.suppr |2 solenv/sanitizers/ui/modules/scalc.suppr|7 ++ solenv/sanitizers/ui/modules/schart.suppr |2 solenv/sanitizers/ui/modules/smath.suppr|9 +++ solenv/sanitizers/ui/modules/swriter.suppr | 10 solenv/sanitizers/ui/sfx.suppr | 12 + solenv/sanitizers/ui/svx.suppr |8 +++ solenv/sanitizers/ui/uui.suppr |3 + solenv/sanitizers/ui/vcl.suppr |9 +++ solenv/sanitizers/ui/xmlsec.suppr |2 16 files changed, 146 insertions(+), 5 deletions(-) New commits: commit 8cc60b05c688e0edc03a63da0afd85f1e853bbc3 Author: Samuel Thibault Date: Wed Jun 13 11:55:09 2018 +0200 gla11y: Enable warnings for more widgets missing a label Namely GtkTreeView GtkTreeViewColumn GtkTextView GtkDrawingArea Change-Id: I4190fc73d0c7fd3575bef0388f44aa52b51f29d2 Reviewed-on: https://gerrit.libreoffice.org/55743 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 094ed5fe72a8..6113161d970d 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -188,10 +188,10 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBox gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBoxText gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkMenuItem # Possibly need labelling -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTreeView -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTreeViewColumn -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTextView -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkDrawingArea +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTreeView +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTreeViewColumn +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTextView +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkDrawingArea # Perhaps need labelling #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkImage diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index 96186ebd2892..b3391beb3257 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -1,3 +1,13 @@ +cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='logoreplacement'] orphan-label +cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='buildid'] orphan-label +cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='locale'] orphan-label +cui/uiconfig/ui/aboutdialog.ui://GtkTextView[@id='version'] no-labelled-by +cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='description'] orphan-label +cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='copyright'] orphan-label +cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='libreoffice'] orphan-label +cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='derived'] orphan-label +cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='vendor'] orphan-label +cui/uiconfig/ui/aboutdialog.ui://GtkLabel[@id='link'] orphan-label cui/uiconfig/ui/aboutconfigdialog.ui://GtkEntry[@id='searchEntry'] no-labelled-by cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='preference'] orphan-label cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='property'] orphan-label @@ -179,6 +189,8 @@ cui/uiconfig/ui/hatchpage.ui://svxcorelo-SvxColorListBox[@id='backgroundcolorlb' cui/uiconfig/ui/hyphenate.ui://GtkLabel[@id='label1'] orphan-label cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='left'] button-no-label cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='right'] button-no-label +cui/uiconfig/ui/iconchangedialog.ui://GtkTextView[@id='addrTextview'] no-labelled-by +cui/uiconfig/ui/iconchangedialog.ui://GtkLabel[@id='label1'] orphan-label cui/uiconfig/ui/insertfloatingframe.ui://GtkEntry[@id='edname'] no-labelled-by cui/uiconfig/ui/insertfloatingframe.ui://GtkEntry[@id='edurl'] no-labelled-by cui/uiconfig/ui/insertfloatingframe.ui://GtkLabel[@id='label6'] orphan-label @@ -188,6 +200,8 @@ cui/uiconfig/ui/insertfloatingframe.ui://GtkLabel[@id='heightlabel'] orphan-labe cui/uiconfig/ui/insertfloatingframe.ui://GtkSpinButton[@id='width'] no-labelled-by cui/uiconfig/ui/insertfloatingframe.ui://GtkSpinButton[@id='height'] no-labelled-by cui/uiconfig/ui/insertoleobject.ui://GtkEntry[@id='urled'] no-labelled-by +cui/uiconfig/ui/javastartparametersdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by +cui/uiconfig/ui/javastar
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk|6 +- solenv/sanitizers/ui/cui.suppr | 19 solenv/sanitizers/ui/dbaccess.suppr | 26 +++ solenv/sanitizers/ui/fps.suppr |4 + solenv/sanitizers/ui/libreofficekit.suppr|3 + solenv/sanitizers/ui/modules/dbreport.suppr |2 solenv/sanitizers/ui/modules/sabpilot.suppr |3 + solenv/sanitizers/ui/modules/sbibliography.suppr |6 ++ solenv/sanitizers/ui/modules/scalc.suppr | 43 ++ solenv/sanitizers/ui/modules/scanner.suppr |2 solenv/sanitizers/ui/modules/schart.suppr|5 ++ solenv/sanitizers/ui/modules/simpress.suppr |9 +++ solenv/sanitizers/ui/modules/smath.suppr |3 + solenv/sanitizers/ui/modules/swriter.suppr | 54 +++ solenv/sanitizers/ui/svx.suppr | 29 solenv/sanitizers/ui/vcl.suppr | 14 + 16 files changed, 225 insertions(+), 3 deletions(-) New commits: commit e3248c2ac6d1f090b58489d087f029d85d060637 Author: Samuel Thibault Date: Sat Jun 2 01:34:21 2018 +0200 gla11y: Enable warnings for more widgets missing a label Namely GtkComboBox GtkComboBoxText GtkMenuItem Change-Id: I85a971ca9cee5f17649b93d13d6b2aeb5440f830 Reviewed-on: https://gerrit.libreoffice.org/55414 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 7213d5e162a6..094ed5fe72a8 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -184,9 +184,9 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.sfxlo-SvxCharV gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.foruilo-RefEdit gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-PaperSizeListBox # Probably need labelling -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBox -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBoxText -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkMenuItem +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBox +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBoxText +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkMenuItem # Possibly need labelling #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTreeView #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkTreeViewColumn diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index 847e9bb883df..d2de43424f25 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -10,6 +10,7 @@ cui/uiconfig/ui/autocorrectdialog.ui://svxcorelo-SvxLanguageBox[@id='lang'] no-l cui/uiconfig/ui/bitmaptabpage.ui://GtkLabel[@id='label4'] orphan-label cui/uiconfig/ui/bitmaptabpage.ui://GtkLabel[@id='label9'] orphan-label cui/uiconfig/ui/bitmaptabpage.ui://GtkSpinButton[@id='tileoffmtr:0%'] no-labelled-by +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkComboBox[@id='os'] no-labelled-by cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='osversion'] no-labelled-by cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='platformvendor'] no-labelled-by cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='device'] no-labelled-by @@ -151,6 +152,10 @@ cui/uiconfig/ui/colorpickerdialog.ui://GtkSpinButton[@id='satSpinbutton'] no-lab cui/uiconfig/ui/colorpickerdialog.ui://GtkSpinButton[@id='brightSpinbutton'] no-labelled-by cui/uiconfig/ui/comment.ui://GtkButton[@id='previous'] button-no-label cui/uiconfig/ui/comment.ui://GtkButton[@id='next'] button-no-label +cui/uiconfig/ui/dimensionlinestabpage.ui://GtkLabel[@id='FT_POSITION'] orphan-label +cui/uiconfig/ui/dimensionlinestabpage.ui://GtkComboBox[@id='LB_UNIT'] no-labelled-by +cui/uiconfig/ui/fmsearchdialog.ui://GtkComboBox[@id='lbField'] no-labelled-by +cui/uiconfig/ui/fmsearchdialog.ui://GtkLabel[@id='replacedesc'] orphan-label cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='incrementslider'] no-labelled-by cui/uiconfig/ui/gradientpage.ui://GtkLabel[@id='centerft'] orphan-label cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='borderslider'] no-labelled-by @@ -167,6 +172,7 @@ cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='angleft'] orphan-label cui/uiconfig/ui/hatchpage.ui://GtkScale[@id='angleslider'] no-labelled-by cui/uiconfig/ui/hatchpage.ui://GtkSpinButton[@id='anglemtr:0degrees'] no-labelled-by cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linetypeft'] orphan-label +cui/uiconfig/ui/hatchpage.ui://GtkComboBoxText[@id='linetypelb'] no-labelled-by cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linecolorft'] orphan-label cui/uiconfig/ui/hatchpage.ui://svxcorelo-SvxColorListBox[@id='lineco
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk | 10 +- solenv/sanitizers/ui/cui.suppr | 108 solenv/sanitizers/ui/formula.suppr |6 + solenv/sanitizers/ui/modules/scalc.suppr| 30 +++ solenv/sanitizers/ui/modules/simpress.suppr |9 ++ solenv/sanitizers/ui/modules/swriter.suppr |1 solenv/sanitizers/ui/svx.suppr | 14 +++ solenv/sanitizers/ui/uui.suppr |7 + solenv/sanitizers/ui/xmlsec.suppr |1 9 files changed, 178 insertions(+), 8 deletions(-) New commits: commit 7a95afee62e536220230f01a5227c9edda617d4e Author: Samuel Thibault Date: Fri May 25 16:40:56 2018 +0200 gla11y: Enable warnings for more widgets missing a label Namely svxcorelo-SvxColorListBox svxcorelo-SvxLanguageBox sfxlo-SvxCharView foruilo-RefEdit svxcorelo-PaperSizeListBox Change-Id: I5933c7500017a25ce8597d781b4a0dcfbbe3 Reviewed-on: https://gerrit.libreoffice.org/54814 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 3203c22203c2..7213d5e162a6 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -178,11 +178,11 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkEntry gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinButton gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinner gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkProgressBar -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-SvxColorListBox -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-SvxLanguageBox -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.sfxlo-SvxCharView -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.foruilo-RefEdit -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-PaperSizeListBox +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-SvxColorListBox +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-SvxLanguageBox +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.sfxlo-SvxCharView +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.foruilo-RefEdit +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-PaperSizeListBox # Probably need labelling #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBox #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkComboBoxText diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index a9dcaf2ae43f..847e9bb883df 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -5,6 +5,8 @@ cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='type'] orphan-label cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='value'] orphan-label cui/uiconfig/ui/assigncomponentdialog.ui://GtkLabel[@id='label1'] orphan-label cui/uiconfig/ui/assigncomponentdialog.ui://GtkEntry[@id='methodEntry'] no-labelled-by +cui/uiconfig/ui/autocorrectdialog.ui://GtkLabel[@id='label1'] orphan-label +cui/uiconfig/ui/autocorrectdialog.ui://svxcorelo-SvxLanguageBox[@id='lang'] no-labelled-by cui/uiconfig/ui/bitmaptabpage.ui://GtkLabel[@id='label4'] orphan-label cui/uiconfig/ui/bitmaptabpage.ui://GtkLabel[@id='label9'] orphan-label cui/uiconfig/ui/bitmaptabpage.ui://GtkSpinButton[@id='tileoffmtr:0%'] no-labelled-by @@ -24,6 +26,104 @@ cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='wladdtitle'] orph cui/uiconfig/ui/breaknumberoption.ui://GtkSpinButton[@id='beforebreak'] no-labelled-by cui/uiconfig/ui/breaknumberoption.ui://GtkSpinButton[@id='afterbreak'] no-labelled-by cui/uiconfig/ui/breaknumberoption.ui://GtkSpinButton[@id='wordlength'] no-labelled-by +cui/uiconfig/ui/colorconfigwin.ui://GtkLabel[@id='doccolor'] orphan-label +cui/uiconfig/ui/colorconfigwin.ui://svxcorelo-SvxColorListBox[@id='doccolor_lb'] no-labelled-by +cui/uiconfig/ui/colorconfigwin.ui://svxcorelo-SvxColorListBox[@id='docboundaries_lb'] no-labelled-by +cui/uiconfig/ui/colorconfigwin.ui://GtkLabel[@id='general'] orphan-label +cui/uiconfig/ui/colorconfigwin.ui://svxcorelo-SvxColorListBox[@id='appback_lb'] no-labelled-by +cui/uiconfig/ui/colorconfigwin.ui://GtkLabel[@id='appback'] orphan-label +cui/uiconfig/ui/colorconfigwin.ui://svxcorelo-SvxColorListBox[@id='objboundaries_lb'] no-labelled-by +cui/uiconfig/ui/colorconfigwin.ui://svxcorelo-SvxColorListBox[@id='tblboundaries_lb'] no-labelled-by +cui/uiconfig/ui/colorconfigwin.ui://GtkLabel[@id='font'] orphan-label +cui/uiconfig/ui/colorconfigwin.ui://svxcorelo-SvxColorListBox[@id='font_lb'] no-labelled-by +cui/uiconfig/ui/colorconfigwin.ui://svxcorelo-SvxColorListBox[@id='unvisitedlinks_lb'] no-labelled-by +cui/uiconfig/u
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk |6 +-- solenv/sanitizers/ui/cui.suppr | 53 solenv/sanitizers/ui/dbaccess.suppr | 11 + solenv/sanitizers/ui/desktop.suppr |9 solenv/sanitizers/ui/filter.suppr |2 + solenv/sanitizers/ui/modules/scalc.suppr|9 solenv/sanitizers/ui/modules/schart.suppr | 27 ++ solenv/sanitizers/ui/modules/sdraw.suppr|2 - solenv/sanitizers/ui/modules/simpress.suppr | 15 +++ solenv/sanitizers/ui/modules/smath.suppr|3 + solenv/sanitizers/ui/modules/swriter.suppr | 32 solenv/sanitizers/ui/sfx.suppr |3 + solenv/sanitizers/ui/svt.suppr |2 + solenv/sanitizers/ui/svx.suppr |8 solenv/sanitizers/ui/vcl.suppr |3 + 15 files changed, 181 insertions(+), 4 deletions(-) New commits: commit d5bb7db998c4c629ec61b9475c86c130e57787f3 Author: Samuel Thibault Date: Fri May 11 14:01:50 2018 +0200 gla11y: Enable warnings for more widgets missing a label Namely GtkSpinButton GtkSpinner GtkProgressBar Change-Id: I00c1d03cde43d23cee5e8b502a03284ac81967a5 Reviewed-on: https://gerrit.libreoffice.org/54131 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 154e9be51149..3203c22203c2 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -175,9 +175,9 @@ gb_UIConfig_gla11y_PARAMETERS += --disable-type no-labelled-by # Clearly need labelling gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkScale gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkEntry -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinButton -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinner -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkProgressBar +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinButton +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinner +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkProgressBar #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-SvxColorListBox #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.svxcorelo-SvxLanguageBox #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.sfxlo-SvxCharView diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index b0f9d263ad52..a9dcaf2ae43f 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -5,6 +5,9 @@ cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='type'] orphan-label cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='value'] orphan-label cui/uiconfig/ui/assigncomponentdialog.ui://GtkLabel[@id='label1'] orphan-label cui/uiconfig/ui/assigncomponentdialog.ui://GtkEntry[@id='methodEntry'] no-labelled-by +cui/uiconfig/ui/bitmaptabpage.ui://GtkLabel[@id='label4'] orphan-label +cui/uiconfig/ui/bitmaptabpage.ui://GtkLabel[@id='label9'] orphan-label +cui/uiconfig/ui/bitmaptabpage.ui://GtkSpinButton[@id='tileoffmtr:0%'] no-labelled-by cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='osversion'] no-labelled-by cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='platformvendor'] no-labelled-by cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='device'] no-labelled-by @@ -18,8 +21,34 @@ cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='bledittitle'] orp cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='bladdtitle'] orphan-label cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='wledittitle'] orphan-label cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='wladdtitle'] orphan-label +cui/uiconfig/ui/breaknumberoption.ui://GtkSpinButton[@id='beforebreak'] no-labelled-by +cui/uiconfig/ui/breaknumberoption.ui://GtkSpinButton[@id='afterbreak'] no-labelled-by +cui/uiconfig/ui/breaknumberoption.ui://GtkSpinButton[@id='wordlength'] no-labelled-by +cui/uiconfig/ui/colorpage.ui://GtkLabel[@id='label18'] orphan-label +cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='R_preset-nospin'] no-labelled-by +cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='G_preset-nospin'] no-labelled-by +cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='B_preset-nospin'] no-labelled-by +cui/uiconfig/ui/colorpage.ui://GtkLabel[@id='label17'] orphan-label +cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='C_preset-nospin:0%'] no-labelled-by +cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='M_preset-nospin:0%'] no-labelled-by +cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='Y_preset-nospin:0%'] no-labelled-by +cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='K_preset-nospin:0%'] no-labelled-by +cui/uiconfi
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk |2 - solenv/sanitizers/ui/cui.suppr | 33 + solenv/sanitizers/ui/dbaccess.suppr | 14 +++ solenv/sanitizers/ui/modules/BasicIDE.suppr |1 solenv/sanitizers/ui/modules/dbreport.suppr |2 + solenv/sanitizers/ui/modules/sabpilot.suppr |9 solenv/sanitizers/ui/modules/scalc.suppr| 53 +++ solenv/sanitizers/ui/modules/scanner.suppr |2 + solenv/sanitizers/ui/modules/schart.suppr |4 ++ solenv/sanitizers/ui/modules/sdraw.suppr|4 ++ solenv/sanitizers/ui/modules/simpress.suppr |4 ++ solenv/sanitizers/ui/modules/smath.suppr|1 solenv/sanitizers/ui/modules/swriter.suppr | 54 solenv/sanitizers/ui/sfx.suppr |6 +++ solenv/sanitizers/ui/svx.suppr |6 +++ solenv/sanitizers/ui/uui.suppr |7 +++ solenv/sanitizers/ui/vcl.suppr |3 + solenv/sanitizers/ui/writerperfect.suppr|1 solenv/sanitizers/ui/xmlsec.suppr | 19 + 19 files changed, 224 insertions(+), 1 deletion(-) New commits: commit 239d985b712301a5922fe4d32f29db94e5f73766 Author: Samuel Thibault Date: Fri May 4 11:14:12 2018 +0200 gla11y: Enable warnings for GtkEntry widgets missing a label Change-Id: Ie2bd516a8125771e747c5960087f835b63737e9e Reviewed-on: https://gerrit.libreoffice.org/53837 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index e208d99a7309..1eee6edf1922 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -174,7 +174,7 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-mnemonic --enable-type gb_UIConfig_gla11y_PARAMETERS += --disable-type no-labelled-by # Clearly need labelling gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkScale -#gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkEntry +gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkEntry #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinButton #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkSpinner #gb_UIConfig_gla11y_PARAMETERS += --enable-specific no-labelled-by.GtkProgressBar diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index faf5d9357fdd..b0f9d263ad52 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -1,3 +1,23 @@ +cui/uiconfig/ui/aboutconfigdialog.ui://GtkEntry[@id='searchEntry'] no-labelled-by +cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='preference'] orphan-label +cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='property'] orphan-label +cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='type'] orphan-label +cui/uiconfig/ui/aboutconfigdialog.ui://GtkLabel[@id='value'] orphan-label +cui/uiconfig/ui/assigncomponentdialog.ui://GtkLabel[@id='label1'] orphan-label +cui/uiconfig/ui/assigncomponentdialog.ui://GtkEntry[@id='methodEntry'] no-labelled-by +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='osversion'] no-labelled-by +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='platformvendor'] no-labelled-by +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='device'] no-labelled-by +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='driverversion'] no-labelled-by +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label4'] orphan-label +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label5'] orphan-label +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label6'] orphan-label +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label7'] orphan-label +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label8'] orphan-label +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='bledittitle'] orphan-label +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='bladdtitle'] orphan-label +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='wledittitle'] orphan-label +cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='wladdtitle'] orphan-label cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='C_custom:0%'] duplicate-mnemonic cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='K_custom:0%'] duplicate-mnemonic cui/uiconfig/ui/comment.ui://GtkButton[@id='previous'] button-no-label @@ -5,6 +25,13 @@ cui/uiconfig/ui/comment.ui://GtkButton[@id='next'] button-no-label cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='incrementslider'] no-labelled-by cui/uiconfig/ui/gradientpage.ui://GtkLabel[@id='centerft'] orphan-label cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='borderslider'] no-labelled-by +cui/uiconfig/ui/hangulhanjaconversiondialog.ui://GtkLabel[@id='label1'] orphan-label +cui/uiconfig/ui/hangulhanjaconve
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk |2 +- solenv/sanitizers/ui/cui.suppr | 13 + solenv/sanitizers/ui/modules/scalc.suppr |5 + solenv/sanitizers/ui/modules/schart.suppr |3 ++- solenv/sanitizers/ui/modules/swriter.suppr | 14 ++ solenv/sanitizers/ui/svx.suppr |7 +++ 6 files changed, 38 insertions(+), 6 deletions(-) New commits: commit 936eaedddbc6d21737745be3c3131607440e366c Author: Samuel Thibault Date: Mon Apr 23 10:54:20 2018 +0200 gla11y: Enable duplicate labelling warnings Change-Id: Id9022aad4538caa08c3de9a76ff97282cfefb828 Reviewed-on: https://gerrit.libreoffice.org/53314 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 1d9ede0986d1..e208d99a7309 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -167,7 +167,7 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-labelled-by # These are often buttons with only an image gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label # These are often doubtful -#gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-mnemonic --enable-type labelled-by-and-mnemonic +gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-mnemonic --enable-type labelled-by-and-mnemonic # For now, disable warning about widgets without a label by default, to enable warnings for classes progressively # To be uncommented progressively diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index 3cf4f506104c..faf5d9357fdd 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -1,3 +1,5 @@ +cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='C_custom:0%'] duplicate-mnemonic +cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='K_custom:0%'] duplicate-mnemonic cui/uiconfig/ui/comment.ui://GtkButton[@id='previous'] button-no-label cui/uiconfig/ui/comment.ui://GtkButton[@id='next'] button-no-label cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='incrementslider'] no-labelled-by @@ -11,6 +13,8 @@ cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linecolorft'] orphan-label cui/uiconfig/ui/hyphenate.ui://GtkLabel[@id='label1'] orphan-label cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='left'] button-no-label cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='right'] button-no-label +cui/uiconfig/ui/menuassignpage.ui://GtkTextView[@id='desc:border'] labelled-by-and-mnemonic +cui/uiconfig/ui/newlibdialog.ui://GtkEntry[@id='entry'] duplicate-mnemonic cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='browsetitle'] orphan-label cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='suppress'] orphan-label cui/uiconfig/ui/optemailpage.ui://GtkCheckButton[@id='suppressHidden'] button-no-label @@ -20,6 +24,9 @@ cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='font'] orphan-label cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='replacewith'] orphan-label cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='apply'] button-no-label cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='delete'] button-no-label +cui/uiconfig/ui/optviewpage.ui://GtkComboBoxText[@id='iconsize'] duplicate-mnemonic +cui/uiconfig/ui/pageformatpage.ui://GtkSpinButton[@id='spinMargLeft:0.00cm'] duplicate-mnemonic +cui/uiconfig/ui/pageformatpage.ui://GtkSpinButton[@id='spinMargRight:0.00cm'] duplicate-mnemonic cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default1'] button-no-label cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default2'] button-no-label cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default3'] button-no-label @@ -42,8 +49,6 @@ cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result7'] button-no-la cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result8'] button-no-label cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result9'] button-no-label cui/uiconfig/ui/select_persona_dialog.ui://GtkLabel[@id='progress_label'] orphan-label -cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinPageNumber'] missing-label-for -cui/uiconfig/ui/textflowpage.ui://GtkComboBox[@id='comboPageStyle'] missing-label-for -cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinOrphan'] missing-label-for -cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinWidow'] missing-label-for +cui/uiconfig/ui/signsignatureline.ui://GtkTextView[@id='edit_comment'] duplicate-mnemonic cui/uiconfig/ui/thesaurus.ui://GtkButton[@id='left'] button-no-label +cui/uiconfig/ui/wordcompletionpage.ui://GtkSpinButton[@id='maxentries'] duplicate-mnemonic diff --git a/solenv/sanitizers/ui/modules/scalc.suppr b/solenv/sanitizers/ui/modules/scalc.suppr index 28d6cc96060e..6e20952ada84 100644 --- a/solenv/sanitizers/ui/modules/scalc.suppr +++ b/solenv/sanitizers/ui/modules/scalc.suppr @@ -1,3 +1,4 @@ +sc/uiconfig/scalc/ui/datafieldoptionsdialog.ui://GtkComboBoxText[@id='layout'] duplicate-mnemonic sc/u
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk |2 - solenv/sanitizers/ui/cui.suppr | 41 solenv/sanitizers/ui/dbaccess.suppr | 14 + solenv/sanitizers/ui/formula.suppr |7 solenv/sanitizers/ui/fps.suppr |3 ++ solenv/sanitizers/ui/modules/dbreport.suppr |4 ++ solenv/sanitizers/ui/modules/scanner.suppr |3 ++ solenv/sanitizers/ui/modules/schart.suppr |6 solenv/sanitizers/ui/modules/simpress.suppr |9 ++ solenv/sanitizers/ui/modules/swriter.suppr | 33 ++ solenv/sanitizers/ui/svt.suppr |1 solenv/sanitizers/ui/svx.suppr |2 + solenv/sanitizers/ui/vcl.suppr |3 ++ 13 files changed, 127 insertions(+), 1 deletion(-) New commits: commit 79391d92df7a474651e02980f238eac4781305ce Author: Samuel Thibault Date: Mon Apr 16 13:52:38 2018 +0200 gla11y: Enable button labelling warnings Change-Id: Ie6a45060e252e75b76fb6222d02403de6d4bccfd Reviewed-on: https://gerrit.libreoffice.org/52968 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 36ffdeb0d511..1d9ede0986d1 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -165,7 +165,7 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-label-for gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-labelled-by # These are often buttons with only an image -#gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label +gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label # These are often doubtful #gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-mnemonic --enable-type labelled-by-and-mnemonic diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index 598c7a600ae3..3cf4f506104c 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -1,3 +1,5 @@ +cui/uiconfig/ui/comment.ui://GtkButton[@id='previous'] button-no-label +cui/uiconfig/ui/comment.ui://GtkButton[@id='next'] button-no-label cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='incrementslider'] no-labelled-by cui/uiconfig/ui/gradientpage.ui://GtkLabel[@id='centerft'] orphan-label cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='borderslider'] no-labelled-by @@ -6,3 +8,42 @@ cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='angleft'] orphan-label cui/uiconfig/ui/hatchpage.ui://GtkScale[@id='angleslider'] no-labelled-by cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linetypeft'] orphan-label cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linecolorft'] orphan-label +cui/uiconfig/ui/hyphenate.ui://GtkLabel[@id='label1'] orphan-label +cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='left'] button-no-label +cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='right'] button-no-label +cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='browsetitle'] orphan-label +cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='suppress'] orphan-label +cui/uiconfig/ui/optemailpage.ui://GtkCheckButton[@id='suppressHidden'] button-no-label +cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='always'] orphan-label +cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='screenonly'] orphan-label +cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='font'] orphan-label +cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='replacewith'] orphan-label +cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='apply'] button-no-label +cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='delete'] button-no-label +cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default1'] button-no-label +cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default2'] button-no-label +cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default3'] button-no-label +cui/uiconfig/ui/personalization_tab.ui://GtkLabel[@id='applied_theme'] orphan-label +cui/uiconfig/ui/personalization_tab.ui://GtkLabel[@id='extensions_label'] orphan-label +cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='persona_preview'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion1'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion2'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion3'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion4'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion5'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='suggestion6'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result1'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result2'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result3'] button-no-label +cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result4'] button-no-label +cui/u
[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
solenv/gbuild/UIConfig.mk |4 ++-- solenv/sanitizers/ui/cui.suppr |4 solenv/sanitizers/ui/filter.suppr |1 + solenv/sanitizers/ui/modules/scalc.suppr| 25 + solenv/sanitizers/ui/modules/simpress.suppr |3 +++ solenv/sanitizers/ui/modules/swriter.suppr |8 solenv/sanitizers/ui/svx.suppr | 17 + 7 files changed, 60 insertions(+), 2 deletions(-) New commits: commit c1084f6d791b69e612acfe7484f4f38b41662c80 Author: Samuel Thibault Date: Wed Apr 4 19:22:47 2018 +0200 gla11y: Enable label-for/labelled-by pairing warnings Change-Id: Icecc1cf3d7ec5c217e705640f1c4a049b75a6778 Reviewed-on: https://gerrit.libreoffice.org/52405 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk index 4923dd26e431..aec1efb33316 100644 --- a/solenv/gbuild/UIConfig.mk +++ b/solenv/gbuild/UIConfig.mk @@ -161,8 +161,8 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-type orphan-label # These are definite errors gb_UIConfig_gla11y_PARAMETERS += --enable-type undeclared-target -#gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-label-for -#gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-labelled-by +gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-label-for +gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-labelled-by # These are often buttons with only an image #gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr index 598c7a600ae3..8f00b81c4cf2 100644 --- a/solenv/sanitizers/ui/cui.suppr +++ b/solenv/sanitizers/ui/cui.suppr @@ -6,3 +6,7 @@ cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='angleft'] orphan-label cui/uiconfig/ui/hatchpage.ui://GtkScale[@id='angleslider'] no-labelled-by cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linetypeft'] orphan-label cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linecolorft'] orphan-label +cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinPageNumber'] missing-label-for +cui/uiconfig/ui/textflowpage.ui://GtkComboBox[@id='comboPageStyle'] missing-label-for +cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinOrphan'] missing-label-for +cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinWidow'] missing-label-for diff --git a/solenv/sanitizers/ui/filter.suppr b/solenv/sanitizers/ui/filter.suppr new file mode 100644 index ..5cff1cecf634 --- /dev/null +++ b/solenv/sanitizers/ui/filter.suppr @@ -0,0 +1 @@ +filter/uiconfig/ui/pdfgeneralpage.ui://GtkCheckButton[@id='reduceresolution'] missing-labelled-by diff --git a/solenv/sanitizers/ui/modules/scalc.suppr b/solenv/sanitizers/ui/modules/scalc.suppr new file mode 100644 index ..83ffb6cae818 --- /dev/null +++ b/solenv/sanitizers/ui/modules/scalc.suppr @@ -0,0 +1,25 @@ +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='connect1'] missing-label-for +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field1'] missing-label-for +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field2'] missing-label-for +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field3'] missing-label-for +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='cond1'] missing-label-for +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='cond2'] missing-label-for +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='cond3'] missing-label-for +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='val1'] missing-label-for +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='val2'] missing-label-for +sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='val3'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='connect1'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='connect2'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field1'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field2'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field3'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='cond1'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='cond2'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='cond3'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='val1'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='val2'] missing-label-for +sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='val3'] missing-label-for +sc/uiconfig/scalc/ui/selectsource.ui://GtkRadio
