[Libreoffice-commits] core.git: winaccessibility/CustomTarget_ia2_idl.mk winaccessibility/source

2022-08-05 Thread Michael Weghorn (via logerrit)
 winaccessibility/CustomTarget_ia2_idl.mk   |1 
 winaccessibility/source/UAccCOMIDL/Charset.idl |   33 -
 2 files changed, 34 deletions(-)

New commits:
commit 245f39eb1279455f5af0e2329cf9617c79b6e240
Author: Michael Weghorn 
AuthorDate: Fri Aug 5 12:39:03 2022 +0100
Commit: Michael Weghorn 
CommitDate: Fri Aug 5 17:34:19 2022 +0200

wina11y: Drop unused Charset.idl

This is one of the LO- and winaccessibility-specific
(i.e. not part of the UNO API and not from upstream
IAccessible2) IDL files and it's unused, so drop it.

Change-Id: I8802934da174dda3c8b35c39c2196a0ac14a7c1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137865
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/CustomTarget_ia2_idl.mk 
b/winaccessibility/CustomTarget_ia2_idl.mk
index 40a9851537ae..2dcd1a2328ab 100644
--- a/winaccessibility/CustomTarget_ia2_idl.mk
+++ b/winaccessibility/CustomTarget_ia2_idl.mk
@@ -17,7 +17,6 @@ wina11y_SOURCE := $(SRCDIR)/winaccessibility/source/UAccCOMIDL
 $(call gb_CustomTarget_get_target,winaccessibility/ia2/idl) : \
$(wina11y_COMIDLDIR)/AccessibleKeyBinding.h \
$(wina11y_COMIDLDIR)/AccessibleKeyStroke.h \
-   $(wina11y_COMIDLDIR)/Charset.h \
$(wina11y_COMIDLDIR)/UAccCOM.h \
$(wina11y_COMIDLDIR)/defines.h \
$(wina11y_COMIDLDIR)/ia2_api_all.h
diff --git a/winaccessibility/source/UAccCOMIDL/Charset.idl 
b/winaccessibility/source/UAccCOMIDL/Charset.idl
deleted file mode 100644
index d5bf7ecd2c91..
--- a/winaccessibility/source/UAccCOMIDL/Charset.idl
+++ /dev/null
@@ -1,33 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-
-const short CHARSET_DONTKNOW = 0;
-const short ANSI = 1;
-const short MAC = 2;
-const short IBMPC_437 = 3;
-const short IBMPC_850 = 4;
-const short IBMPC_860 = 5;
-const short IBMPC_861 = 6;
-const short IBMPC_863 = 7;
-const short IBMPC_865 = 8;
-const short CHARSET_SYSTEM = 9;
-const short SYMBOL = 10;
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-commits] core.git: winaccessibility/CustomTarget_ia2_idl.mk winaccessibility/source

2022-08-05 Thread Michael Weghorn (via logerrit)
 winaccessibility/CustomTarget_ia2_idl.mk|2 
 winaccessibility/source/UAccCOM/AccActionBase.cxx   |2 
 winaccessibility/source/UAccCOMIDL/AccessibleKeyBinding.idl |   60 
 winaccessibility/source/UAccCOMIDL/AccessibleKeyStroke.idl  |  149 
 4 files changed, 213 deletions(-)

New commits:
commit 56145f237b63a35c142dbccd434fd780badcf489
Author: Michael Weghorn 
AuthorDate: Fri Aug 5 12:46:16 2022 +0100
Commit: Michael Weghorn 
CommitDate: Fri Aug 5 17:35:16 2022 +0200

wina11y: Drop unused AccessibleKey{Binding,Stroke}.idl

The only include of the generated header file
`AccessibleKeyBinding.h` was in `AccActionBase.cxx`,
but that doesn't make any use of what's defined in
the header, so just drop the include and the unused
IDL files altogether. (The IDL files are part of the
winaccessibility-specific UAccCOMIDL, unrelated to
the IDL files for the UNO API.)

`CMAccessible::get_accKeyboardShortcut` directly operates
on the `XAccessibleKeyBinding` UNO interface ever since

commit a18bdb3bc05e761704cc345a66a9d642bc4f4a0a
Date:   Thu Nov 14 08:18:05 2013 +

Integrate branch of IAccessible2

Just the winaccessibility directory initially.

(the commit also adding those 2 IDL files), so it's
unclear to me what might have been the intended use.

Change-Id: I1a08e8ea789ca92e52640a0006f20fac219f6733
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137866
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/CustomTarget_ia2_idl.mk 
b/winaccessibility/CustomTarget_ia2_idl.mk
index 2dcd1a2328ab..ed22a28432d3 100644
--- a/winaccessibility/CustomTarget_ia2_idl.mk
+++ b/winaccessibility/CustomTarget_ia2_idl.mk
@@ -15,8 +15,6 @@ wina11y_SOURCE := $(SRCDIR)/winaccessibility/source/UAccCOMIDL
 # We cannot depend on *.tlb because they only produced by IDL compiler
 # if idl contains 'library' statement.
 $(call gb_CustomTarget_get_target,winaccessibility/ia2/idl) : \
-   $(wina11y_COMIDLDIR)/AccessibleKeyBinding.h \
-   $(wina11y_COMIDLDIR)/AccessibleKeyStroke.h \
$(wina11y_COMIDLDIR)/UAccCOM.h \
$(wina11y_COMIDLDIR)/defines.h \
$(wina11y_COMIDLDIR)/ia2_api_all.h
diff --git a/winaccessibility/source/UAccCOM/AccActionBase.cxx 
b/winaccessibility/source/UAccCOM/AccActionBase.cxx
index cd68f3032ec3..3062e96a855c 100644
--- a/winaccessibility/source/UAccCOM/AccActionBase.cxx
+++ b/winaccessibility/source/UAccCOM/AccActionBase.cxx
@@ -32,8 +32,6 @@
 #include 
 #include 
 
-#include "AccessibleKeyStroke.h"
-
 #include "acccommon.h"
 
 using namespace com::sun::star::accessibility::AccessibleRole;
diff --git a/winaccessibility/source/UAccCOMIDL/AccessibleKeyBinding.idl 
b/winaccessibility/source/UAccCOMIDL/AccessibleKeyBinding.idl
deleted file mode 100644
index 91d17de0539e..
--- a/winaccessibility/source/UAccCOMIDL/AccessibleKeyBinding.idl
+++ /dev/null
@@ -1,60 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-import "objidl.idl";
-import "oaidl.idl";
-import "oleacc.idl";
-import "AccessibleKeyStroke.idl";
-
-[object, uuid(6B1923AC-3E9A-4336-99E1-A69EA4E946E9)]
-interface IAccessibleKeyBinding : IUnknown
-{
-  // get number of key bindings for this object
-  [propget] HRESULT nKeyBindings
-(
- [out, retval] long *nKeyBindings
- );
-
-  // get length of keystroke sequence for specified key binding
-  [propget] HRESULT keyStrokeSequenceLength
-(
- [in] long keyBindingIndex,
- [out] long *sequenceLength
- );
-
-  // The returned sequence of key strokes describes one method
-  // to invoke the associated action (the one from which you
-  // obtained the object at which you called this method) by
-  // pressing keys. The keys specified by each of the returned
-  // key strokes have to be pressed at the same time (the
-  // Control-key and the A-key for example). The keys of one key
-  // stroke have to be released before pressing those of the next.
-  // The order of the key strokes in