[PATCH] translated German comments
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2512
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/2512/1
translated German comments
Change-Id: I6d9b646d9d70dcbf97f7faacc8b15578a597b2a1
---
M dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
1 file changed, 47 insertions(+), 48 deletions(-)
diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index 003c9ac..128fa76 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -135,7 +135,7 @@
m_pFunctionCell-SetHelpId(HID_QRYDGN_ROW_FUNCTION);
//
-// TriState der ::com::sun::star::form::CheckBox abschalten
+// switch off triState of ::com::sun::star::form::CheckBox
m_pVisibleCell-GetBox().EnableTriState( sal_False );
Font aTitleFont = OutputDevice::GetDefaultFont(
DEFAULTFONT_SANS_UNICODE,Window::GetSettings().GetLanguageTag().getLanguageType(),DEFAULTFONT_FLAGS_ONLYONE);
@@ -151,7 +151,7 @@
for(long i=0;i BROW_ROW_CNT;i++)
m_bVisibleRow.push_back(sal_True);
-m_bVisibleRow[BROW_FUNCTION_ROW] = sal_False; // zuerst ausblenden
+m_bVisibleRow[BROW_FUNCTION_ROW] = sal_False; // first hide
m_timerInvalidate.SetTimeout(200);
m_timerInvalidate.SetTimeoutHdl(LINK(this, OSelectionBrowseBox,
OnInvalidateTimer));
@@ -271,7 +271,7 @@
if ( 0 == m_pBrowseBox-GetSelectColumnCount() )
{
m_pBrowseBox-DeactivateCell();
-// wenn es schon eine selektierte Spalte gibt, bin ich schon im
richtigen Modus
+// we are in the right mode if a row hase been selected row
if ( BROWSER_HIDESELECT == ( nMode BROWSER_HIDESELECT ) )
{
nMode = ~BROWSER_HIDESELECT;
@@ -354,7 +354,7 @@
}
SetDataRowHeight(aHeight.Height());
SetTitleLines(1);
-// Anzahl der sichtbaren Zeilen ermitteln
+// get number of visible rows
for(long i=0;iBROW_ROW_CNT;i++)
{
if(m_bVisibleRow[i])
@@ -492,7 +492,7 @@
getDesignView()-fillValidFields(aTable, m_pFieldCell);
-// * durch alias.* ersetzen
+// translate with alias.*
if ((aField.GetChar(0) == '*') aTable.Len())
{
aField = aTable;
@@ -532,7 +532,7 @@
if(!pEntry-IsVisible() pEntry-GetOrderDir() != ORDER_NONE
!m_bOrderByUnRelated)
{
-// Spalte muss sichtbar sein, um im ORDER BY aufzutauchen
+ // a column has to visible in order to show up in ORDER BY
pEntry-SetVisible(sal_True);
m_pVisibleCell-GetBox().Check(pEntry-IsVisible());
m_pVisibleCell-GetBox().SaveValue();
@@ -921,7 +921,7 @@
if (pEntry.is() Controller().Is() Controller()-IsModified())
{
-// fuer die Undo-Action
+// for the Undo-action
String strOldCellContents,sNewValue;
long nRow = GetRealRow(GetCurRow());
sal_Bool bAppendRow = sal_False;
@@ -956,7 +956,7 @@
pNewEntry-SetColumnId( pEntry-GetColumnId() );
::std::replace(getFields().begin(),getFields().end(),pEntry,pNewEntry);
sal_uInt16 nCol = GetCurColumnId();
-for (int i = 0; i m_nVisibleCount; i++) // Spalte
neu zeichnen
+for (int i = 0; i m_nVisibleCount; i++) // redraw
column
RowModified(i,nCol);
}
else
@@ -1060,7 +1060,7 @@
{
strOldCellContents = pEntry-GetFunction();
sal_uInt16 nPos = m_pFunctionCell-GetSelectEntryPos();
-// Diese Funktionen stehen nur unter CORE zur Verf�gung
+// these functions are only available in CORE
String sFunctionName=
m_pFunctionCell-GetEntry(nPos);
String sGroupFunctionName =
m_aFunctionStrings.GetToken(comphelper::string::getTokenCount(m_aFunctionStrings,
';')-1);
sal_Bool bGroupBy = sal_False;
@@ -1203,21 +1203,21 @@
if(!bError)
{
-// und noch die Undo-Action fuer das Ganze
+// and now the undo-action for the total
appendUndoAction(strOldCellContents,sNewValue,nRow);
}
}
-// habe ich Daten in einer FieldDescription gespeichert, die vorher leer
war und es nach den Aenderungen nicht mehr ist ?
+// did I store data in a FieldDescription which was empty before and which
is not empty anymore after the changes?
if ( pEntry.is() bWasEmpty !pEntry-IsEmpty() !bError )
{
-// Default auf sichtbar
+
[PATCH] translated German comments
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2515
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/2515/1
translated German comments
Change-Id: If89452824776c2bd653ca0728cc7e6adf4050e4b
---
M dbaccess/source/ui/tabledesign/TableUndo.cxx
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/dbaccess/source/ui/tabledesign/TableUndo.cxx
b/dbaccess/source/ui/tabledesign/TableUndo.cxx
index 75a8879..68d97e3 100644
--- a/dbaccess/source/ui/tabledesign/TableUndo.cxx
+++ b/dbaccess/source/ui/tabledesign/TableUndo.cxx
@@ -63,7 +63,7 @@
m_pTabDgnCtrl-m_nCurUndoActId--;
//
-// Wenn erstes Undo zurueckgenommen wurde, ist Doc nicht modifiziert worden
+// doc has not been modified if first undo was reverted
if( m_pTabDgnCtrl-m_nCurUndoActId == 0 )
{
m_pTabDgnCtrl-GetView()-getController().setModified(sal_False);
@@ -77,7 +77,7 @@
m_pTabDgnCtrl-m_nCurUndoActId++;
//
-// Wenn Redo fuer erste Undo-Action, muss Modified-Flag wieder gesetzt
werden
+// restore Modifed-flag after Redo of first Undo-action
if( m_pTabDgnCtrl-m_nCurUndoActId 0 )
{
m_pTabDgnCtrl-GetView()-getController().setModified(sal_True);
@@ -95,7 +95,7 @@
{
DBG_CTOR(OTableDesignCellUndoAct,NULL);
//
-// Text an der Position (m_nRow, m_nCol) auslesen
+// read text at position (m_nRow, m_nCol)
m_sOldText = m_pTabDgnCtrl-GetCellData( m_nRow, m_nCol );
}
@@ -109,12 +109,12 @@
void OTableDesignCellUndoAct::Undo()
{
//
-// Neuen Text der alten Zelle speichern und alten wieder einsetzen
+// store text at old line and restore the old one
m_pTabDgnCtrl-ActivateCell( m_nRow, m_nCol );
m_sNewText = m_pTabDgnCtrl-GetCellData( m_nRow, m_nCol );
m_pTabDgnCtrl-SetCellData( m_nRow, m_nCol, m_sOldText );
//
-// Wenn erstes Undo zurueckgenommen wurde, ist Zelle nicht mehr modifiziert
+// line has not been modified if the first Undo was reverted
if (m_pTabDgnCtrl-GetCurUndoActId() == 1)
{
CellControllerRef xController = m_pTabDgnCtrl-Controller();
@@ -131,7 +131,7 @@
void OTableDesignCellUndoAct::Redo()
{
//
-// Neuen Text wieder einseten
+// restore new text
m_pTabDgnCtrl-ActivateCell( m_nRow, m_nCol );
m_pTabDgnCtrl-SetCellData( m_nRow, m_nCol, m_sNewText );
@@ -178,7 +178,7 @@
void OTableEditorTypeSelUndoAct::Undo()
{
//
-// Typ zuruecksetzen
+// restore type
OFieldDescription* pFieldDesc = pTabEdCtrl-GetFieldDescr(m_nRow);
if(pFieldDesc)
m_pNewType = pFieldDesc-getTypeInfo();
@@ -194,7 +194,7 @@
void OTableEditorTypeSelUndoAct::Redo()
{
//
-// Neuen Typ
+// new type
pTabEdCtrl-GoToRowColumnId( m_nRow ,m_nCol);
pTabEdCtrl-SetCellData(m_nRow,m_nCol,m_pNewType);
@@ -210,7 +210,7 @@
{
DBG_CTOR(OTableEditorDelUndoAct,NULL);
//
-// DeletedRowList fuellen
+// fill DeletedRowList
::std::vector ::boost::shared_ptrOTableRow * pOriginalRows =
pOwner-GetRowList();
long nIndex = pOwner-FirstSelectedRow();
::boost::shared_ptrOTableRow pOriginalRow;
@@ -237,7 +237,7 @@
void OTableEditorDelUndoAct::Undo()
{
//
-// Geloeschte Zeilen wieder einfuegen
+// Insert the deleted line
sal_uLong nPos;
::std::vector ::boost::shared_ptrOTableRow ::iterator aIter =
m_aDeletedRows.begin();
::std::vector ::boost::shared_ptrOTableRow ::iterator aEnd =
m_aDeletedRows.end();
@@ -261,7 +261,7 @@
void OTableEditorDelUndoAct::Redo()
{
//
-// Zeilen wieder loeschen
+// delete line again
sal_uLong nPos;
::std::vector ::boost::shared_ptrOTableRow ::iterator aIter =
m_aDeletedRows.begin();
::std::vector ::boost::shared_ptrOTableRow ::iterator aEnd =
m_aDeletedRows.end();
@@ -304,7 +304,7 @@
void OTableEditorInsUndoAct::Undo()
{
//
-// Eingefuegte Zeilen wieder loeschen
+// delete lines again
::std::vector ::boost::shared_ptrOTableRow * pOriginalRows =
pTabEdCtrl-GetRowList();
for( long i=(m_nInsPos+m_vInsertedRows.size()-1); i(m_nInsPos-1);
[PATCH] translated German comments
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2516
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/2516/1
translated German comments
Change-Id: I4a629124270eb39dc879f74f1814618fe660be5e
---
M dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
index 5482bb8..7b89147 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
@@ -27,7 +27,7 @@
namespace dbaui
{
//
-// OQueryDesignFieldUndoAct - Basisklasse fuer Undos in der Feldauflistung
im Abfrageentwurf
+ // OQueryDesignFieldUndoAct - Basisclass for undo's in the fieldlist of a
query design
class OQueryDesignFieldUndoAct : public OCommentUndoAction
@@ -52,7 +52,7 @@
};
//
-// OTabFieldCellModifiedUndoAct - Undo-Klasse fuer Aendern einer Zelle
einer Spaltenbeschreibung
+// OTabFieldCellModifiedUndoAct - undo class to change a line of the
column description
class OTabFieldCellModifiedUndoAct : public OQueryDesignFieldUndoAct
{
@@ -73,7 +73,7 @@
};
//
-// OTabFieldSizedUndoAct - Undo-Klasse fuer Aendern einer Spaltenbreite
+// OTabFieldSizedUndoAct - undo class to change the column width
class OTabFieldSizedUndoAct : public OQueryDesignFieldUndoAct
{
@@ -90,7 +90,7 @@
};
//
-// OTabFieldUndoAct - Basisklasse fuer Undos in der Feldauflistung im
Abfrageentwurf, die mit Veraendern einer kompletten Feldbeschreibung zu tun
haben
+// OTabFieldUndoAct - base class for undos in the fieldlist of a query
design, which are used to change complete field descriptions
class OTabFieldUndoAct : public OQueryDesignFieldUndoAct
{
@@ -104,7 +104,7 @@
};
//
-// OTabFieldDelUndoAct - Undo-Klasse fuer Loeschen eines Feldes
+// OTabFieldDelUndoAct - undo class to delete a field
class OTabFieldDelUndoAct : public OTabFieldUndoAct
{
@@ -118,6 +118,7 @@
//
// OTabFieldDelUndoAct - Undo-Klasse fuer Anlegen eines Feldes
+// OTabFieldDelUndoAct - undo class to create a field
class OTabFieldCreateUndoAct : public OTabFieldUndoAct
{
--
To view, visit https://gerrit.libreoffice.org/2516
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a629124270eb39dc879f74f1814618fe660be5e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luc Castermans luc.casterm...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] translated German comments (file is clean now)
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2517
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/2517/1
translated German comments (file is clean now)
Change-Id: I1f833fe4a2332c1b2fa1e98fd320e55f7e19c649
---
M dbaccess/source/ui/querydesign/QueryDesignView.cxx
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 912e30f..a2335f9 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -567,16 +567,16 @@
const ::connectivity::OSQLParseNode
*pRightTable)
{
SqlParseError eErrorCode = eOk;
-if (pNode-count() == 3 // Ausdruck is geklammert
+if (pNode-count() == 3 // statment between brackets
SQL_ISPUNCTUATION(pNode-getChild(0),()
SQL_ISPUNCTUATION(pNode-getChild(2),)))
{
eErrorCode = InsertJoinConnection(_pView,pNode-getChild(1),
_eJoinType,pLeftTable,pRightTable);
}
-else if (SQL_ISRULEOR2(pNode,search_condition,boolean_term)
// AND/OR-Verknuepfung:
+else if (SQL_ISRULEOR2(pNode,search_condition,boolean_term)
// AND/OR-joints:
pNode-count() == 3)
{
-// nur AND Verkn�pfung zulassen
+// only allow AND joints
if (!SQL_ISTOKEN(pNode-getChild(1),AND))
eErrorCode = eIllegalJoinCondition;
else if ( eOk == (eErrorCode =
InsertJoinConnection(_pView,pNode-getChild(0),
_eJoinType,pLeftTable,pRightTable)) )
@@ -2909,19 +2909,20 @@
OUString aFieldListStr(GenerateSelectList(this,rFieldList,nTabcount1));
if( aFieldListStr.isEmpty() )
return OUString();
-// Ausnahmebehandlung, wenn keine Felder angegeben worden sind
-// Dann darf die Tabpage nicht gewechselt werden
-// Im TabBarSelectHdl wird der SQL-OUString auf STATEMENT_NOFIELDS
abgefragt
-// und eine Errormeldung erzeugt
-// - Tabellenliste aufbauen --
+
+// Exceptionhandling, if no fields have been passed we should not
+// change the tab page
+// TabBarSelectHdl will query the SQL-OUString for STATEMENT_NOFIELDS
+// and trigger a error message
+// - Build table list --
const ::std::vectorOTableConnection** pConnList =
m_pTableView-getTableConnections();
Reference XConnection xConnection = rController.getConnection();
OUString aTableListStr(GenerateFromClause(xConnection,pTabList,pConnList));
OSL_ENSURE(!aTableListStr.isEmpty(), OQueryDesignView::getStatement() :
unexpected : have Fields, but no Tables !);
-// wenn es Felder gibt, koennen die nur durch Einfuegen aus einer schon
existenten Tabelle entstanden sein; wenn andererseits
-// eine Tabelle geloescht wird, verschwinden auch die zugehoerigen Felder
- ergo KANN es das nicht geben, dass Felder
-// existieren, aber keine Tabellen (und aFieldListStr hat schon eine
Laenge, das stelle ich oben sicher)
+// if fields exist now, these only can be created by inserting from an
already existing table; if on the other hand
+// a table is deleted, also the belonging fields will be deleted -
therefore it CANNOT occur that fields
+// exist but no tables exist (and aFieldListStr has its length, I secure
this above)
OUStringBuffer aHavingStr,aCriteriaListStr;
// - Kriterien aufbauen --
if (!GenerateCriterias(this,aCriteriaListStr,aHavingStr,rFieldList,
nTabcount 1))
@@ -2941,7 +2942,7 @@
}
aCriteriaListStr = aTmp;
}
-// - Statement aufbauen --
+// - construct statement --
OUStringBuffer aSqlCmd(OUString(RTL_CONSTASCII_USTRINGPARAM(SELECT )));
if(rController.isDistinct())
aSqlCmd.append(OUString(RTL_CONSTASCII_USTRINGPARAM( DISTINCT )));
@@ -2954,7 +2955,7 @@
aSqlCmd.append(OUString(RTL_CONSTASCII_USTRINGPARAM( WHERE )));
aSqlCmd.append(aCriteriaListStr.makeStringAndClear());
}
-// - GroupBy aufbauen und Anhangen
+// - construct GroupBy and attachen
ReferenceXDatabaseMetaData xMeta;
if ( xConnection.is() )
xMeta = xConnection-getMetaData();
@@ -2963,13 +2964,13 @@
bUseAlias = bUseAlias || !xMeta-supportsGroupByUnrelated();
aSqlCmd.append(GenerateGroupBy(this,rFieldList,bUseAlias));
-// - having Anhangen
+// - attache having
if(aHavingStr.getLength())
{
aSqlCmd.append(OUString(RTL_CONSTASCII_USTRINGPARAM( HAVING )));
[PATCH] translated German comments; all cleaned up.
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2520
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/2520/1
translated German comments; all cleaned up.
Change-Id: I761b190361bbcca2f9655a7a028799586c2d8656
---
M dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx
M dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx
M dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx
M dbaccess/source/ui/querydesign/QueryTabConnUndoAction.cxx
M dbaccess/source/ui/querydesign/QueryTabConnUndoAction.hxx
M dbaccess/source/ui/querydesign/QueryTabWinShowUndoAct.hxx
M dbaccess/source/ui/querydesign/QueryTabWinUndoAct.cxx
M dbaccess/source/ui/querydesign/QueryTabWinUndoAct.hxx
M dbaccess/source/ui/querydesign/QueryTableView.cxx
M dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx
M dbaccess/source/ui/querydesign/TableConnection.cxx
M dbaccess/source/ui/querydesign/TableConnectionData.cxx
M dbaccess/source/ui/querydesign/TableWindowListBox.cxx
M dbaccess/source/ui/querydesign/TableWindowTitle.cxx
M dbaccess/source/ui/querydesign/querycontroller.cxx
M dbaccess/source/ui/querydesign/querydlg.hxx
16 files changed, 156 insertions(+), 147 deletions(-)
diff --git a/dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx
b/dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx
index d4528a1..e114f6e 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx
@@ -24,13 +24,12 @@
namespace dbaui
{
//
-// OQueryDesignUndoAction - Undo-Basisklasse fuer Aktionen im graphischen
Abfrageentwurf (ohne Feldliste)
-
+// OQueryDesignUndoAction - undo base class for actions in graphical query
design (without field list)
class OJoinTableView;
class OQueryDesignUndoAction : public OCommentUndoAction
{
protected:
-OJoinTableView* m_pOwner; // in diesem Container spielt sich
alles ab
+OJoinTableView* m_pOwner; // in this container it all happens
public:
OQueryDesignUndoAction(OJoinTableView* pOwner, sal_uInt16 nCommentID)
: OCommentUndoAction(nCommentID), m_pOwner(pOwner) { }
diff --git a/dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx
b/dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx
index 0256953..e106344 100644
--- a/dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx
+++ b/dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx
@@ -29,9 +29,10 @@
Point ptNext = m_pTabWin-GetPosPixel() + ptFrameScrollPos;
m_pTabWin-SetPosPixel(m_ptNextPosition - ptFrameScrollPos);
-// sieht so aus, als wenn das ptFrameScrollPos sinnlos ist, da ich es
hier abziehe und auf das ptNext aufaddiere, wo
-// ich es das naechste Mal ja wieder abziehe ... Aber ptFrameScrollPos
kann sich natuerlich beim naechsten Mal schon wieder
-// geaendert haben ...
+
+// it looks like ptFrameScrollPos is meaningless, then I it substract here
and add it to ptNext, and
+// next time I substract again ...
+// AbetptFrameScrollPos could have changed next time ...
m_pOwner-EnsureVisible(m_pTabWin);
m_ptNextPosition = ptNext;
diff --git a/dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx
b/dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx
index 853e24c..e21ebf0 100644
--- a/dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx
+++ b/dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx
@@ -26,7 +26,7 @@
{
//
-// OQuerySizeTabWinUndoAct - Undo-Klasse fuer Groessenveraenderung eines
TabWins
+// OQuerySizeTabWinUndoAct - undo class to change size of TabWins
class OTableWindow;
class OJoinSizeTabWinUndoAct : public OQueryDesignUndoAction
{
@@ -39,9 +39,9 @@
public:
OJoinSizeTabWinUndoAct(OJoinTableView* pOwner, const Point
ptOriginalPos, const Size szOriginalSize, OTableWindow* pTabWin);
-// Nebenbedingung : es darf nicht gescrollt worden sein, waehrend die
neue Groesse/Position ermittelt wurde, das heisst, die Position
-// hier sind physische, nicht logische Koordinaten
-// (im Gegensatz zur QueryMoveTabWinUndoAct)
+// Boundary condition: while retrieving size/position scrolling is not
allowed, meaning the position
+// here returns physical and not logical coordinates
+// (in contrary to QueryMoveTabWinUndoAct)
virtual voidUndo() { ToggleSizePosition(); }
virtual voidRedo() { ToggleSizePosition(); }
diff --git a/dbaccess/source/ui/querydesign/QueryTabConnUndoAction.cxx
b/dbaccess/source/ui/querydesign/QueryTabConnUndoAction.cxx
index 5991394..d09f60d 100644
---
[PATCH] Translated German comments and messages to English
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2444
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/2444/1
Translated German comments and messages to English
Change-Id: I80444aac8fdf90ea0f595151788afb14d4415cd3
---
M dbaccess/source/ui/querydesign/QueryTableView.cxx
1 file changed, 66 insertions(+), 64 deletions(-)
diff --git a/dbaccess/source/ui/querydesign/QueryTableView.cxx
b/dbaccess/source/ui/querydesign/QueryTableView.cxx
index db886aa..dfc44d8 100644
--- a/dbaccess/source/ui/querydesign/QueryTableView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryTableView.cxx
@@ -273,27 +273,29 @@
DBG_CHKTHIS(OQueryTableView,NULL);
TTableWindowData* pTabWinDataList =
m_pView-getController().getTableWindowData();
OSL_ENSURE((getTableConnections()-size()==0)
(GetTabWinMap()-size()==0),
-vor OQueryTableView::ReSync() bitte ClearAll aufrufen !);
+before calling OQueryTableView::ReSync() please call ClearAll !);
// ich brauche eine Sammlung aller Fensternamen, deren Anlegen schief
geht, damit ich die entsprechenden Connections
+// gar nicht erst anlege
+// I need a collection of all window names, deren Anlegen schief geht,
damit ich die entsprechenden Connections
// gar nicht erst anlege
::std::vectorString arrInvalidTables;
TTableWindowData::reverse_iterator aIter = pTabWinDataList-rbegin();
-// Fenster kreieren und einfuegen
+// Create the window and add it
for(;aIter != pTabWinDataList-rend();++aIter)
{
OQueryTableWindowData* pData =
static_castOQueryTableWindowData*(aIter-get());
OTableWindow* pTabWin = createWindow(*aIter);
-// ich gehe jetzt NICHT ueber ShowTabWin, da dieses die Daten des
Fensters in die Liste des Docs einfuegt, was
-// schlecht waere, denn genau von dort hole ich sie ja gerade
-// also Schritt fuer Schritt
+// I dont't use ShowTabWin as this adds the window data to the list of
documents.
+// This would be bad as I am getting them from there.
+// Instead, I do it step by step
if (!pTabWin-Init())
{
-// das Initialisieren ging schief, dass heisst, dieses TabWin
steht nicht zur Verfuegung, also muss ich es inklusive
-// seiner Daten am Dokument aufraeumen
+// The initialisation has gone wrong, this TabWin is not
available, so
+// I must clean up the data and the document
pTabWin-clearListBox();
delete pTabWin;
arrInvalidTables.push_back(pData-GetAliasName());
@@ -302,15 +304,15 @@
continue;
}
-(*GetTabWinMap())[pData-GetAliasName()] = pTabWin; // am Anfang
einfuegen, da ich die DataList ja rueckwaerts durchlaufe
-// wenn in den Daten keine Position oder Groesse steht - Default
+(*GetTabWinMap())[pData-GetAliasName()] = pTabWin; // add at the
beginning as I am going backwards through the DataList
+// Use the default if there is no position or size
if (!pData-HasPosition() !pData-HasSize())
SetDefaultTabWinPosSize(pTabWin);
pTabWin-Show();
}
-// Verbindungen einfuegen
+// Add the connections
TTableConnectionData* pTabConnDataList =
m_pView-getController().getTableConnectionData();
TTableConnectionData::reverse_iterator aConIter =
pTabConnDataList-rbegin();
@@ -401,11 +403,11 @@
void OQueryTableView::AddTabWin(const ::rtl::OUString _rTableName, const
::rtl::OUString _rAliasName, sal_Bool bNewTable)
{
DBG_CHKTHIS(OQueryTableView,NULL);
-// das ist die aus der Basisklasse geerbte Methode, die fuehre ich auf die
an meinem Parent zurueck, die mir eventuell einen
-// Alias dazu bastelt und das an mein anderes AddTabWin weiterreicht
+// This is the method inherited from the base class. I send it back to my
parent class and my parent
+// may build an Alias and send it on to AddTabWin.
-// leider ist _rTableName voll qualifiziert, das OQueryDesignView erwartet
aber einen String, der
-// nur aus Schema und Tabelle besteht und keinen Katalog enthaelt.
+// Unfortunately _rTableName is fully qualified, but OQueryDesignView
expects a String consisting
+// of the Schema and Table only and not containing a Catalog.
Reference XConnection xConnection =
m_pView-getController().getConnection();
if(!xConnection.is())
return;
@@ -465,10 +467,10 @@
void OQueryTableView::AddTabWin(const ::rtl::OUString _rComposedName, const
::rtl::OUString _rTableName, const ::rtl::OUString strAlias, sal_Bool
bNewTable)
{
DBG_CHKTHIS(OQueryTableView,NULL);
-OSL_ENSURE(!_rTableName.isEmpty() || !strAlias.isEmpty(),
OQueryTableView::AddTabWin : kein Tabellen- und kein Aliasname !);
-// wenn der Tabellenname nicht gesetzt ist, steht das fuer ein
Dummy-Fenster, das braucht aber wenigstens einen
[PATCH] Translated german comments
From 296b85124bd1b7392ea6fc44b0f35b37311dc199 Mon Sep 17 00:00:00 2001
From: EricSeynaeve git...@nosperse.com
Date: Mon, 4 Feb 2013 22:45:06 +0100
Subject: [PATCH] Translated german comments
Change-Id: Idc31ebc5bb2d11345f68b7275b7fc4d335b633c1
---
sc/source/core/data/column.cxx | 89 --
1 file changed, 43 insertions(+), 46 deletions(-)
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index f29dc2d..ce65100 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -420,7 +420,7 @@ void ScColumn::ApplyPattern( SCROW nRow, const ScPatternAttr rPatAttr )
const ScPatternAttr* pPattern = pAttrArray-GetPattern( nRow );
-// true = alten Eintrag behalten
+// true = keep old content
ScPatternAttr* pNewPattern = (ScPatternAttr*) aCache.ApplyTo( *pPattern, true );
ScDocumentPool::CheckRef( *pPattern );
@@ -543,7 +543,7 @@ const ScStyleSheet* ScColumn::GetSelectionStyle( const ScMarkData rMark, bool
rFound = false;
if (!rMark.IsMultiMarked())
{
-OSL_FAIL(ScColumn::GetSelectionStyle ohne Selektion);
+OSL_FAIL(No selection in ScColumn::GetSelectionStyle);
return NULL;
}
@@ -566,7 +566,7 @@ const ScStyleSheet* ScColumn::GetSelectionStyle( const ScMarkData rMark, bool
pNewStyle = pPattern-GetStyleSheet();
rFound = true;
if ( !pNewStyle || ( pStyle pNewStyle != pStyle ) )
-bEqual = false; // unterschiedliche
+bEqual = false; // difference
pStyle = pNewStyle;
}
}
@@ -593,7 +593,7 @@ const ScStyleSheet* ScColumn::GetAreaStyle( bool rFound, SCROW nRow1, SCROW nRo
pNewStyle = pPattern-GetStyleSheet();
rFound = true;
if ( !pNewStyle || ( pStyle pNewStyle != pStyle ) )
-bEqual = false; // unterschiedliche
+bEqual = false; // difference
pStyle = pNewStyle;
}
@@ -644,8 +644,8 @@ void ScColumn::SetPatternArea( SCROW nStartRow, SCROW nEndRow,
void ScColumn::ApplyAttr( SCROW nRow, const SfxPoolItem rAttr )
{
-// um nur ein neues SetItem zu erzeugen, brauchen wir keinen SfxItemPoolCache.
-//! Achtung: der SfxItemPoolCache scheint zuviele Refs fuer das neue SetItem zu erzeugen ??
+// in order to only create a new SetItem, we don't need SfxItemPoolCache.
+//! Warning: SfxItemPoolCache seems to create to many Refs for the new SetItem ??
ScDocumentPool* pDocPool = pDocument-GetPool();
@@ -657,11 +657,9 @@ void ScColumn::ApplyAttr( SCROW nRow, const SfxPoolItem rAttr )
if ( pNewPattern != pOldPattern )
pAttrArray-SetPattern( nRow, pNewPattern );
else
-pDocPool-Remove( *pNewPattern ); // ausser Spesen nichts gewesen
+pDocPool-Remove( *pNewPattern ); // free up resources
delete pTemp;
-
-// alte Version mit SfxItemPoolCache:
}
bool ScColumn::Search( SCROW nRow, SCSIZE nIndex ) const
@@ -771,7 +769,6 @@ void ScColumn::Resize( SCSIZE nSize )
maItems.reserve(nSize);
}
-// SwapRow zum Sortieren
namespace {
@@ -789,6 +786,7 @@ void lclTakeBroadcaster( ScBaseCell* rpCell, SvtBroadcaster* pBC )
} // namespace
+// SwapRow for sorting
void ScColumn::SwapRow(SCROW nRow1, SCROW nRow2)
{
/* Simple swap of cell pointers does not work if broadcasters exist (crash
@@ -883,7 +881,7 @@ void ScColumn::SwapRow(SCROW nRow1, SCROW nRow2)
ScTokenArray* pCode1 = pFmlaCell1-GetCode();
ScTokenArray* pCode2 = pFmlaCell2-GetCode();
-if (pCode1-GetLen() == pCode2-GetLen()) // nicht-UPN
+if (pCode1-GetLen() == pCode2-GetLen()) // not-UPN
{
bool bEqual = true;
sal_uInt16 nLen = pCode1-GetLen();
@@ -967,10 +965,10 @@ void ScColumn::SwapCell( SCROW nRow, ScColumn rCol)
if ( pCell2 )
{
-// Tauschen
+// swap
maItems[nIndex1].pCell = pCell2;
rCol.maItems[nIndex2].pCell = pCell1;
-// Referenzen aktualisieren
+// update references
SCsCOL dx = rCol.nCol - nCol;
if ( pFmlaCell1 )
{
@@ -989,9 +987,9 @@ void ScColumn::SwapCell( SCROW nRow, ScColumn rCol)
}
else
{
-// Loeschen
+// remove
maItems.erase(maItems.begin() + nIndex1);
-// Referenzen aktualisieren
+// update references
SCsCOL dx = rCol.nCol - nCol;
if ( pFmlaCell1 )
{
@@ -1000,7 +998,7 @@ void ScColumn::SwapCell( SCROW nRow, ScColumn rCol)
pFmlaCell1-aPos.SetCol( rCol.nCol );
pFmlaCell1-UpdateReference(URM_MOVE, aRange, dx, 0, 0);
}
-// Einfuegen
+// insert
rCol.Insert(nRow, pCell1
[PATCH] translated german comments to english
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1098 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/1098/1 translated german comments to english Change-Id: I4df4f471578f78f586d4a69b5eb7561415f3994b --- M svtools/inc/svtools/ctrlbox.hxx 1 file changed, 51 insertions(+), 52 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1098 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4df4f471578f78f586d4a69b5eb7561415f3994b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Enrico Weigelt, metux IT service metuxitserv...@googlemail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] translated German comments in starmath
Hi Alexander, On Fri, 2012-08-03 at 10:28 +0200, Alexander Wilms wrote: this is my first patch, so I don't really what the procedure is. Looks lovely :-) you did your license statement already. If it's alright, can I push it? Yep - that'd be wonderful: git pull -r ; git push should do it :-) great to kick-start the comment translation again with eager hands. If you're confident in your translations, there is no real need to have them reviewed - in general we strongly prefer to separate concerns though - so try to separate any non-comment-translation code cleanup out of the (typically large) comment work. Otherwise this is excellent :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] translated German comments in starmath
Patch was pushed, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=72778119fde55218354ee100481bfad2a1cedf35. Sorry, forgot to send a mail/change the mail subject. Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] translated German comments in starmath
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
this is my first patch, so I don't really what the procedure is.
If it's alright, can I push it?
Alex
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJQG4uSAAoJECO1/tAiWGrN9jMIANQHHqLUF6DSaLJ5S/jiqBip
h2M2r44uWcI2hfqu2/cywKnq9XaRra2V97gLcBbGSTPCt7rq5x3W4cfSX0h+JV3M
eYCdcU5500H16piMLtdxZOhIlvURT6e5Ly0ez7xGMGd7usl0MHyAXcVF4j46RgT8
EJpnzi134RF7LvhZkt2oP3cL7a1e7dvsYTdD5aInvwV5OjBkDQtiwLxjOw1YfDNk
kLPIWOX0m9ZbQzYR799xMwSxWuV6mBfF2S1VdvSmNtUq0WJiIilhiC042JyBwLg8
GwVrnO6w4I2bgNoUXWLpCbmg3WhHBFWZTPfNE1D84iEqxeYgjYvFs19Ad+Qk0AU=
=Ih9p
-END PGP SIGNATURE-
From 6f9f4e770cc4c63071fa128a56c12b3fe3b3c46f Mon Sep 17 00:00:00 2001
From: Alexander Wilms alexander.wi...@zoho.com
Date: Fri, 3 Aug 2012 10:22:14 +0200
Subject: [PATCH] Translated German comments in starmath
---
starmath/source/accessibility.cxx |6 +-
starmath/source/config.cxx|4 +-
starmath/source/dialog.cxx| 136 ++---
starmath/source/document.cxx | 26 ---
starmath/source/edit.cxx | 15 ++--
starmath/source/node.cxx | 123 -
6 files changed, 150 insertions(+), 160 deletions(-)
diff --git a/starmath/source/accessibility.cxx b/starmath/source/accessibility.cxx
index a7b39bc..a8d1b31 100644
--- a/starmath/source/accessibility.cxx
+++ b/starmath/source/accessibility.cxx
@@ -572,12 +572,12 @@ sal_Int32 SAL_CALL SmGraphicAccessible::getIndexAtPoint( const awt::Point aPoin
if (pWin)
{
const SmNode *pTree = pWin-GetView()-GetDoc()-GetFormulaTree();
-//! kann NULL sein! ZB wenn bereits beim laden des Dokuments (bevor der
-//! Parser angeworfen wurde) ins Fenster geklickt wird.
+//! can be NULL! e.g. if already during the loading of the document (before the parser even started)
+//! one clicks within the window
if (!pTree)
return nRes;
-// get position relativ to formula draw position
+// get position relative to formula draw position
Point aPos( aPoint.X, aPoint.Y );
aPos = pWin-PixelToLogic( aPos );
aPos -= pWin-GetFormulaDrawPos();
diff --git a/starmath/source/config.cxx b/starmath/source/config.cxx
index 533dd8c..ac1cebe 100644
--- a/starmath/source/config.cxx
+++ b/starmath/source/config.cxx
@@ -82,8 +82,8 @@ void SmConfig::ItemSetToConfig(const SfxItemSet rSet)
{
SetIgnoreSpacesRight( bVal );
-// (angezeigte) Formeln muessen entsprechen neu formatiert werden.
-// Das erreichen wir mit:
+// (displayed) formulas have to be reformatted accordingly
+// That's how we achieve this:
Broadcast(SfxSimpleHint(HINT_FORMATCHANGED));
}
}
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index 532ed8a..c72302a 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -55,8 +55,8 @@ using ::rtl::OUString;
//
-// Da der FontStyle besser ueber die Attribute gesetzt/abgefragt wird als ueber
-// den StyleName bauen wir uns hier unsere eigene Uebersetzung
+// Since it's better to set/query the FontStyle via its attributes rather
+// than via the StyleName we create a way to translate
// Attribute - StyleName
//
@@ -135,8 +135,8 @@ const SmFontStyles GetFontStyles()
void SetFontStyle(const XubString rStyleName, Font rFont)
{
-// finden des Index passend zum StyleName fuer den leeren StyleName wird
-// 0 (nicht bold nicht italic) angenommen.
+// Finding of the Index fitting the StyleName. For an empty StyleName it's assumed to be
+// 0 (neither bold nor italic).
sal_uInt16 nIndex = 0;
if (rStyleName.Len())
{
@@ -801,9 +801,8 @@ IMPL_LINK( SmDistanceDialog, CheckBoxClickHdl, CheckBox *, pCheckBox )
void SmDistanceDialog::SetHelpId(MetricField rField, const rtl::OString sHelpId)
{
-//! HelpID's die auf diese Weise explizit gesetzt werden, muessen im
-//! util Verzeichnis im File hidother.src mit Hilfe von hidspecial
-//! definiert werden!
+//! HelpIDs which are being set explicitly this way have to be defined in the
+//! util directory in the file hidother.src with the help of hidspecial!
const XubString aEmptyText;
#if OSL_DEBUG_LEVEL 1
@@ -862,8 +861,8 @@ void SmDistanceDialog::SetCategory(sal_uInt16 nCategory)
SmCategoryDesc *pCat;
-// merken der (evtl neuen) Einstellungen der aktiven SmCategoryDesc
-// bevor zu der neuen gewechselt wird.
+// remembering the (maybe new) settings of the active SmCategoryDesc
+// before switching to the new one
if (nActiveCategory != CATEGORY_NONE)
{
pCat = Categories[nActiveCategory];
@@ -878,16 +877,16 @@ void SmDistanceDialog::SetCategory(sal_uInt16 nCategory
Re: [PATCH] translated German comments in starmath
Hi Alex, 2012/8/3 Alexander Wilms alexander.wi...@zoho.com: Hi, this is my first patch, so I don't really what the procedure is. If it's alright, can I push it? Alex Thank you very much for your contribution! I will check your patch and push it as soon as I find some time (should definitely be done before Sunday). I do not expect that you have a freedesktop account and hence commit rights to the official Git repository...and even then I would not suggest pushing directly since, as you write, this is your first contribution. Can you please also send a license statement to the mailing list (see e.g. http://nabble.documentfoundation.org/license-statement-td3999073.html)? Otherwise we cannot integrate your patch and that would be pity... For more regarding the procedure of patch contribution please have a look at the related wiki pages under https://wiki.documentfoundation.org/Development#Preparing_patches. Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] translated German comments in starmath
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Philipp, I do have commit rights, but I don't feel comfortable yet pushing stuff myself :) So thanks for the link. Here's my license statement: http://nabble.documentfoundation.org/License-statement-td3979585.html Kind Regards, Alex -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJQHAa3AAoJECO1/tAiWGrNvI0IAID2PHqYzzRR/lAkTbVr3Awv F1apnq8NQepvsyQfWJr1x1kgLFOYK0hpCiMm9SKg43WnvcsooqWYNVTj1ZIgEnRk cHxqnAQr8jRSh5ItVhppLPrbALgBeB25BSmgCKa9V7bbi0Z/Z+CVCaLne0tP2D19 PuqUVIJWOML57JcSByktDbCzT/ItCs82K4WiASDqoC0LvviHzGmmPgwdrIY6wVwS +bPjXisnNklSUuTH3DAZowLVKS/5DrPv87yZIxPn1y/6lrJMzdCWBl1YIPNDywr+ rtvp6gvMyP3TGEvX5agjF6xaehzHmn+8GrW/q1tdbIFnSzFaLiVkK4pLEi7iXTo= =XbFy -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] translated German comments in starmath
Heyhey, 2012/8/3 Alexander Wilms alexander.wi...@zoho.com: Hi Philipp, I do have commit rights, but I don't feel comfortable yet pushing stuff myself :) So thanks for the link. Here's my license statement: http://nabble.documentfoundation.org/License-statement-td3979585.html Kind Regards, Alex sorry, looks as if I did not search long enough for your license statement (I was assuming that you didn't do it since you wrote that this was your first contribution). In addition, I am impressed that you have commit rights w/o any contribution. I wanted to inform you that I cleaned your patch a little bit and just integrated it into the code base ;-) Thank you very much! You can find it at http://cgit.freedesktop.org/libreoffice/core/commit/?id=72778119fde55218354ee100481bfad2a1cedf35. Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] translated German comments in starmath
Ah thanks, I'm in the design team and got the commit rights for the new templates in 3.6, so I'm not entirely new to the project :) But I didn't touch any code so far. I hope this isn't too off-topic: When I want to continue working, is 'git reset --hard origin/master' all I need to do? Thanks Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] translated German comments in starmath
Hey, 2012/8/3 Alexander Wilms alexander.wi...@zoho.com: Ah thanks, I'm in the design team and got the commit rights for the new templates in 3.6, so I'm not entirely new to the project :) Ah, I see ;-) I hope this isn't too off-topic: When I want to continue working, is 'git reset --hard origin/master' all I need to do? It's one valid way that should work. Yes! But I am currently not sure if this does also pull the latest changes, so doing a git pull afterwards does not harm... gn8 Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Fwd: [PATCH] translated German comments in starmath
Hi, Sorry, this was first sent to the wrong address: -- Forwarded message -- From: Ruslan Kabatsayev b7.10110...@gmail.com Date: Sat, Aug 4, 2012 at 12:56 AM Subject: Re: [PATCH] translated German comments in starmath To: Philipp Riemer ruderphil...@gmail.com Hi, 2012/8/3 Alexander Wilms alexander.wi...@zoho.com: When I want to continue working, is 'git reset --hard origin/master' all I need to do? This doesn't fetch new remote changes, so you should do git pull afterwards. Even better, instead of resetting and pulling, you can do git fetch git rebase origin so that if you have some local commits which haven't been pushed, they'll get applied on top of updated origin. Regards, Ruslan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translated german comments in sw/source/core/layout/
So what's the status of these patches? Have all been reviewed and pushed by now? Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translated german comments in sw/source/core/layout/
On 28/02/12 14:46, Philipp Weissenbacher wrote: So what's the status of these patches? Have all been reviewed and pushed by now? Yes :) Look here: http://lists.freedesktop.org/archives/libreoffice/2012-February/027098.html -- Dave -- Adfinis SyGroup AG David Vogt, Software Engineer / Project Manager Keltenstrasse 98 | CH-3018 Bern Tel. 031 381 70 47 | Direct 031 550 31 12 signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] Translated german comments in sw/source/core/layout/
Hi David, all, On 2012-02-17 at 11:26 +0100, David Vogt wrote: As Nicolas Christener and I promised to Cedric at FOSDEM, we set sail to translate the german comments in the sw/source/core/layout/ directory. We're still not quite done, but here's what we have so far. This, and any future contributions to LibreOffice are available under the MPL / LGPLv3+ unless stated otherwise. Thanks so much for this heroic work! I've pushed everything from this lot what I've found not pushed yet. All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translated german comments in sw/source/core/layout/
Started from the other end, patch 22 and 21 are pushed to master. Nice! Attached are my reviewed patches (don't have commit access :-( ). It's my first review, hopefully I did everything right. I also replaced the bits that seemed like too literal translation with. And an extra kudos for translating spaltiger Bereichsfrischling. That's just unfathomable to me ^^. Just asking: Is there a specific reason to highlight negations with capital letters (e.g. NOT)? Cheers, Philipp 0001-Translated-german-code-comments-to-english.patch Description: Binary data 0002-Correct-some-spelling-errors-and-trailing-whitespace.patch Description: Binary data 0003-Translated-german-code-comments-to-english.patch Description: Binary data 0004-flylay-german-comments-translated.patch Description: Binary data 0005-Correct-spelling-and-fix-trailing-whitespace.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translated german comments in sw/source/core/layout/
On 21/02/12 16:09, Philipp Weissenbacher wrote: Started from the other end, patch 22 and 21 are pushed to master. Nice! Attached are my reviewed patches (don't have commit access :-( ). It's my first review, hopefully I did everything right. I also replaced the bits that seemed like too literal translation with. And an extra kudos for translating spaltiger Bereichsfrischling. That's just unfathomable to me ^^. Yeah, there were quite a few interesting words around :) Just asking: Is there a specific reason to highlight negations with capital letters (e.g. NOT)? Not really. It is mainly a habit of mine because I sometimes overread such things when tired or in a hurry and thus interpret them totally wrong. You may of course use normal case if you think it's better that way :) -- Dave -- Adfinis SyGroup AG David Vogt, Software Engineer / Project Manager Keltenstrasse 98 | CH-3018 Bern Tel. 031 381 70 47 | Direct 031 550 31 12 signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translated german comments in sw/source/core/layout/
Just asking: Is there a specific reason to highlight negations with capital letters (e.g. NOT)? Not really. It is mainly a habit of mine because I sometimes overread such things when tired or in a hurry and thus interpret them totally wrong. You may of course use normal case if you think it's better that way :) No, no, I like that! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translated german comments in sw/source/core/layout/
Hi Philipp Thanks for your response and your hints on how to contribute - I'll keep that in mind for future contributions :) And also thanks for the review! -- Dave On 17/02/12 18:02, Philipp Weissenbacher wrote: Hello you two! Thanks for the big amount of work. I know how tiresome it is to translate this oververbose German to something that makes sense in English. That and the technical jargon make translating it quite time intensive. So kudos for that much work! I think that it'd be much easier to review your patches and get them integrated quicker if you post fewer of them and at an earlier stage. Every little step counts and is appreciated :). I usually try to keep under 50 K per patch - which makes for quite a few small files or one large one with some smaller ones. I saw that you also added TODO comments about the translation. That's not very handy, as I cannot communicate with you about it :-). It'd be nicer to either include the comment in the patch email or ask on IRC. I noticed a lot of trailing whitespace errors. I had the same problem in the beginning too, just find a plugin for your editor that removes them for you or (if you use vim) you can add autocmd BufWritePre * :%s/\s\+$//e to your ~/.vimrc file (see http://vim.wikia.com/wiki/Remove_unwanted_spaces). I would greatly appreciate it if you could do that for any future work. Then I don't have to fix them when reviewing. :-). BTW: I'm reviewing the first five patches. Cheers, Philipp 2012/2/16 David Vogt david.v...@adfinis-sygroup.ch: Hi everybody As Nicolas Christener and I promised to Cedric at FOSDEM, we set sail to translate the german comments in the sw/source/core/layout/ directory. We're still not quite done, but here's what we have so far. This, and any future contributions to LibreOffice are available under the MPL / LGPLv3+ unless stated otherwise. As far as I know, Nicolas has already sent his license statement, Stefan will follow soon. Since we're not very familiar with the code, it may well be that there are conceptual mistakes in our translation, so read with care ;) -- Dave -- Adfinis SyGroup AG David Vogt, Software Engineer / Project Manager Keltenstrasse 98 | CH-3018 Bern Tel. 031 381 70 47 | Direct 031 550 31 12 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Adfinis SyGroup AG David Vogt, Software Engineer / Project Manager Keltenstrasse 98 | CH-3018 Bern Tel. 031 381 70 47 | Direct 031 550 31 12 signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translated german comments in sw/source/core/layout/
Hello you two! Thanks for the big amount of work. I know how tiresome it is to translate this oververbose German to something that makes sense in English. That and the technical jargon make translating it quite time intensive. So kudos for that much work! I think that it'd be much easier to review your patches and get them integrated quicker if you post fewer of them and at an earlier stage. Every little step counts and is appreciated :). I usually try to keep under 50 K per patch - which makes for quite a few small files or one large one with some smaller ones. I saw that you also added TODO comments about the translation. That's not very handy, as I cannot communicate with you about it :-). It'd be nicer to either include the comment in the patch email or ask on IRC. I noticed a lot of trailing whitespace errors. I had the same problem in the beginning too, just find a plugin for your editor that removes them for you or (if you use vim) you can add autocmd BufWritePre * :%s/\s\+$//e to your ~/.vimrc file (see http://vim.wikia.com/wiki/Remove_unwanted_spaces). I would greatly appreciate it if you could do that for any future work. Then I don't have to fix them when reviewing. :-). BTW: I'm reviewing the first five patches. Cheers, Philipp 2012/2/16 David Vogt david.v...@adfinis-sygroup.ch: Hi everybody As Nicolas Christener and I promised to Cedric at FOSDEM, we set sail to translate the german comments in the sw/source/core/layout/ directory. We're still not quite done, but here's what we have so far. This, and any future contributions to LibreOffice are available under the MPL / LGPLv3+ unless stated otherwise. As far as I know, Nicolas has already sent his license statement, Stefan will follow soon. Since we're not very familiar with the code, it may well be that there are conceptual mistakes in our translation, so read with care ;) -- Dave -- Adfinis SyGroup AG David Vogt, Software Engineer / Project Manager Keltenstrasse 98 | CH-3018 Bern Tel. 031 381 70 47 | Direct 031 550 31 12 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translated german comments in sw/source/core/layout/
On Fri, 2012-02-17 at 11:26 +0100, David Vogt wrote: We're still not quite done, but here's what we have so far. Wow - this looks like some brilliant work :-) I imagine when Cedric gets over being flamed by some intersection of those guys who want a new UI, but don't want the UI to change at all ;-) he'll be thrilled too. This, and any future contributions to LibreOffice are available under the MPL / LGPLv3+ unless stated otherwise. I linked you into the developers wiki :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Translated german comments in sw/source/core/layout/
Philipp Weissenbacher wrote: BTW: I'm reviewing the first five patches. Started from the other end, patch 22 and 21 are pushed to master. Slightly tweaked a few things, mostly if instead of when (a rather common error we Germans commit), and sometimes went a bit further away from a verbatim translation of a sentence that sounded weird in German already. At any rate, many thanks for this herculean effort, it is much appreciated! Cheers, -- Thorsten pgpDQ1k3N4VeP.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] translated german comments in module fpicker
Hi,
translated german comments in libs-core/fpicker/.
License is LGPLv3+/MPL.
Regards,
MichaelFrom 5d559f89cb20cc11bab14b44d95d9a2aa771c426 Mon Sep 17 00:00:00 2001
From: Michael Muench mich...@codingmicha.de
Date: Thu, 3 Mar 2011 20:10:07 +0100
Subject: [PATCH] translated german comments in module fpicker
---
fpicker/source/office/iodlg.cxx| 161 +---
fpicker/source/office/iodlg.hxx| 10 +-
fpicker/source/office/iodlgimp.cxx |4 +-
fpicker/source/office/iodlgimp.hxx | 16 ++--
4 files changed, 92 insertions(+), 99 deletions(-)
diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index 7ecfa10..3c949c4 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -122,8 +122,8 @@ using namespace InternalFilePickerElementIds;
#define GET_DECODED_NAME(aObj) \
aObj.getName( INetURLObject::LAST_SEGMENT, true, INetURLObject::DECODE_WITH_CHARSET )
-// Zeit die beim Traveln in der Filterbox gewartet wird,
-// bis in der Browsebox gefiltert wird ( in ms ).
+// Time to wait while traveling in the filterbox until
+// the browsebox gets filtered ( in ms).
#define TRAVELFILTER_TIMEOUT 750
#define WIDTH_ADDITION 15
@@ -142,7 +142,6 @@ namespace
if ( !pFilter )
pFilter = pImpl-GetCurFilter();
-// Filtern.
if ( !pFilter )
return String();
@@ -559,14 +558,13 @@ void SvtFileDialog::Init_Impl
INetURLObject aStdDirObj( SvtPathOptions().GetWorkPath() );
SetStandardDir( aStdDirObj.GetMainURL( INetURLObject::NO_DECODE ) );
-// Reichweite bestimmen.
+// determine range
if ( !( nStyle SFXWB_NOREMOTE ) )
{
_pImp-_nState |= FILEDLG_STATE_REMOTE;
}
-// Kontrollelement erzeugen, wobei die Reihenfolge die Tab-Steuerung
-// bestimmt.
+// Create control element, the order defines the tab control.
_pImp-_pFtFileName = new FixedText( this, SvtResId( FT_EXPLORERFILE_FILENAME ) );
SvtURLBox* pURLBox = new SvtURLBox( this );
@@ -639,7 +637,7 @@ void SvtFileDialog::Init_Impl
_pFileView-SetHelpId( HID_FILEDLG_STANDARD );
_pFileView-SetStyle( _pFileView-GetStyle() | WB_TABSTOP );
-// Positionen und Groessen der Knoepfe bestimmen.
+// determine the positions and size of the buttons
Image aNewFolderImg( GetButtonImage( IMG_FILEDLG_CREATEFOLDER ) );
_pImp-_pBtnNewFolder-SetModeImage( aNewFolderImg );
@@ -709,15 +707,14 @@ void SvtFileDialog::Init_Impl
AddControls_Impl( );
-// Zahl der Pixel bestimmen, um die die anderen Elemente in der Position
-// Angepasst werden muessen.
+// Determine the amount of pixel the other elements have to be adjusted in their position.
aPos.Y() += aSize.Height();
aPos.Y() += LogicToPixel( Size( 0, 6 ), MAP_APPFONT ).Height();
long nYOffset = aPos.Y();
aPos = _pFileView-GetPosPixel();
nYOffset -= aPos.Y();
-// Positionen der uebrigen Elemente anpassen.
+// Adjust the position of the other elements.
aPos.Y() += nYOffset;
_pFileView-SetPosPixel( aPos );
@@ -742,12 +739,12 @@ void SvtFileDialog::Init_Impl
lcl_MoveControl( _pImp-_pBtnHelp, 0, nYOffset + 3 );
// a little more spacing between Cancel- and HelpButton
-// Groesse des Dialoges anpassen.
+// adjust size of the dialog
aSize = GetSizePixel();
aSize.Height() += nYOffset;
SetSizePixel( aSize );
-// Beschriftungen dem Modus anpassen.
+// adjust the labels to the mode
USHORT nResId = STR_EXPLORERFILE_OPEN;
USHORT nButtonResId = 0;
@@ -775,7 +772,7 @@ void SvtFileDialog::Init_Impl
_pImp-GetFilterListControl()-Hide();
}
-// Einstellungen der Steuerelemente vornehmen.
+// Setting preferences of the control elements.
_pImp-_pBtnNewFolder-SetClickHdl( STATIC_LINK( this, SvtFileDialog, NewFolderHdl_Impl ) );
_pImp-_pBtnFileOpen-SetClickHdl( STATIC_LINK( this, SvtFileDialog, OpenHdl_Impl ) );
_pImp-_pBtnCancel-SetClickHdl( LINK( this, SvtFileDialog, CancelHdl_Impl ) );
@@ -786,10 +783,9 @@ void SvtFileDialog::Init_Impl
_pFileView-SetDoubleClickHdl( LINK( this, SvtFileDialog, DblClickHdl_Impl ) );
_pFileView-SetOpenDoneHdl( LINK( this, SvtFileDialog, OpenDoneHdl_Impl ) );
-// Resourcen freigeben.
FreeResource();
-// Timer fuer Filterbox Travel setzen
+// set timer for the filterbox travel
_pImp-_aFilterTimer.SetTimeout( TRAVELFILTER_TIMEOUT );
_pImp-_aFilterTimer.SetTimeoutHdl( STATIC_LINK( this, SvtFileDialog, FilterSelectHdl_Impl ) );
@@ -1000,7 +996,7 @@ IMPL_STATIC_LINK( SvtFileDialog, OpenHdl_Impl, void*, pVoid )
{
if ( pThis-_pImp-_bMultiSelection pThis-_pFileView-GetSelectionCount() 1 )
{
-// bei Multiselektion spezielles Open
+// special open in case of multiselection
pThis-OpenMultiSelection_Impl();
return 0;
}
@@ -1108,7 +1104,7
