[PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3810 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/3810/1 fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents. Added an checkbox option View PDF after Export in Export as Pdf Dialog Box . If a user ticks the checkbox , pdf file will be opened after export else only export will be done . Goto File Export as PDF Tick the checkbox View PDF after Export to observe changes . There is a lot of space in between last checkbox and this ViewPDF checkbox , because if we open impress and check export as pdf , there are more options in the dialog. It will require make dev-install to work properly . Change-Id: Ic94c0a9c6e0f7bef9727a40a8b656218f233cd61 --- M filter/source/pdf/impdialog.cxx M filter/source/pdf/impdialog.hrc M filter/source/pdf/impdialog.hxx M filter/source/pdf/impdialog.src M filter/source/pdf/pdfexport.cxx M filter/source/pdf/pdfexport.hxx M filter/source/pdf/pdffilter.cxx M officecfg/registry/data/org/openoffice/Office/WebWizard.xcu M officecfg/registry/schema/org/openoffice/Office/Common.xcs M vcl/inc/vcl/pdfextoutdevdata.hxx M vcl/source/gdi/pdfextoutdevdata.cxx 11 files changed, 60 insertions(+), 1 deletion(-) diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx index 9ddf052..d265328 100644 --- a/filter/source/pdf/impdialog.cxx +++ b/filter/source/pdf/impdialog.cxx @@ -80,6 +80,7 @@ mnMaxImageResolution( 300 ), mbUseTaggedPDF( sal_False ), mbExportNotes( sal_True ), +mbViewPDF( sal_False ), mbExportNotesPages( sal_False ), mbUseTransitionEffects( sal_False ), mbIsSkipEmptyPages( sal_True ), @@ -192,6 +193,7 @@ if ( mbIsPresentation ) mbExportNotesPages = maConfigItem.ReadBool( ExportNotesPages, sal_False ); mbExportNotes = maConfigItem.ReadBool( ExportNotes, sal_False ); +mbViewPDF = maConfigItem.ReadBool( ViewPDFAfterExport, sal_False ); mbExportBookmarks = maConfigItem.ReadBool( ExportBookmarks, sal_True ); if ( mbIsPresentation ) @@ -360,6 +362,7 @@ if ( mbIsPresentation ) maConfigItem.WriteBool( ExportNotesPages, mbExportNotesPages ); maConfigItem.WriteBool( ExportNotes, mbExportNotes ); +maConfigItem.WriteBool( ViewPDFAfterExport, mbViewPDF ); maConfigItem.WriteBool( ExportBookmarks, mbExportBookmarks ); if ( mbIsPresentation ) @@ -511,6 +514,7 @@ maCbExportBookmarks( this, PDFFilterResId( CB_EXPORTBOOKMARKS ) ), maCbExportHiddenSlides( this, PDFFilterResId( CB_EXPORTHIDDENSLIDES ) ), maCbExportNotes( this, PDFFilterResId( CB_EXPORTNOTES ) ), +maCbViewPDF( this, PDFFilterResId( CB_VIEWPDF ) ), maCbExportNotesPages( this, PDFFilterResId( CB_EXPORTNOTESPAGES ) ), maCbExportEmptyPages( this, PDFFilterResId( CB_EXPORTEMPTYPAGES ) ), maCbAddStream( this, PDFFilterResId( CB_ADDSTREAM ) ), @@ -624,6 +628,7 @@ maCbExportBookmarks.Check( paParent-mbExportBookmarks ); maCbExportNotes.Check( paParent-mbExportNotes ); +maCbViewPDF.Check( paParent-mbViewPDF); if ( mbIsPresentation ) { @@ -668,6 +673,7 @@ paParent-mbReduceImageResolution = maCbReduceImageResolution.IsChecked(); paParent-mnMaxImageResolution = maCoReduceImageResolution.GetText().toInt32(); paParent-mbExportNotes = maCbExportNotes.IsChecked(); +paParent-mbViewPDF = maCbViewPDF.IsChecked(); if ( mbIsPresentation ) paParent-mbExportNotesPages = maCbExportNotesPages.IsChecked(); paParent-mbExportBookmarks = maCbExportBookmarks.IsChecked(); @@ -702,6 +708,7 @@ paParent-mbExportFormFields = maCbExportFormFields.IsChecked(); paParent-mbEmbedStandardFonts = maCbEmbedStandardFonts.IsChecked(); } + paParent-maWatermarkText = maEdWatermark.GetText(); /* diff --git a/filter/source/pdf/impdialog.hrc b/filter/source/pdf/impdialog.hrc index 03b6d55..938b622 100644 --- a/filter/source/pdf/impdialog.hrc +++ b/filter/source/pdf/impdialog.hrc @@ -87,6 +87,7 @@ #define CB_WATERMARK32 #define FT_WATERMARK33 #define ED_WATERMARK34 +#define CB_VIEWPDF 35 //controls for open options tab page diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx index 11a3f38..4049d53 100644 --- a/filter/source/pdf/impdialog.hxx +++ b/filter/source/pdf/impdialog.hxx @@ -94,6 +94,7 @@ sal_BoolmbUseTaggedPDF; sal_Int32 mnPDFTypeSelection; sal_BoolmbExportNotes; +sal_BoolmbViewPDF; sal_BoolmbExportNotesPages; sal_BoolmbUseTransitionEffects; sal_BoolmbIsSkipEmptyPages; @@ -210,6 +211,7 @@ CheckBoxmaCbExportBookmarks; CheckBox
Re: [PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
Hi , Yeah i have already done this , but review is left. You can check new one at https://gerrit.libreoffice.org/#/c/3763 And it will require make dev-install tto work . If possible review and suggest changes , any if required. Thanks On Monday, May 6, 2013, Miklos Vajna (via Code Review) wrote: Miklos Vajna has posted comments on this change. Change subject: fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents. .. Patch Set 1: Instead of using a static field, add a new configuration variable for this. Example commit: 64cea833fb9e5534885aa29844255be2ef32db1f -- To view, visit https://gerrit.libreoffice.org/3709 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief7d2b4413c0964b472e339a0fb46555227d8c6d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Anurag Kanungo anuragkanu...@gmail.com javascript:; Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz javascript:; Gerrit-Reviewer: Tor Lillqvist t...@iki.fi javascript:; ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
Hi , Yeah i have already done this , but review is left. You can check new one at https://gerrit.libreoffice.org/#/c/3763 And it will require make dev-install tto work . If possible review and suggest changes any if required On Monday, May 6, 2013, Miklos Vajna (via Code Review) wrote: Miklos Vajna has posted comments on this change. Change subject: fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents. .. Patch Set 1: Instead of using a static field, add a new configuration variable for this. Example commit: 64cea833fb9e5534885aa29844255be2ef32db1f -- To view, visit https://gerrit.libreoffice.org/3709 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief7d2b4413c0964b472e339a0fb46555227d8c6d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Anurag Kanungo anuragkanu...@gmail.com javascript:; Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz javascript:; Gerrit-Reviewer: Tor Lillqvist t...@iki.fi javascript:; ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
Hi , Yeah i have already done this , but review is left. You can check new one at https://gerrit.libreoffice.org/#/c/3763 And it will require make dev-install tto work . If possible review and suggest changes any if required Thanks On Monday, May 6, 2013, Miklos Vajna (via Code Review) wrote: Miklos Vajna has posted comments on this change. Change subject: fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents. .. Patch Set 1: Instead of using a static field, add a new configuration variable for this. Example commit: 64cea833fb9e5534885aa29844255be2ef32db1f -- To view, visit https://gerrit.libreoffice.org/3709 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief7d2b4413c0964b472e339a0fb46555227d8c6d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Anurag Kanungo anuragkanu...@gmail.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3763 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3763/1 fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents. Added an checkbox option View PDF after Export in Export as Pdf Dialog Box . If a user ticks the checkbox , pdf file will be opened after export else only export will be done . Goto File Export as PDF Tick the checkbox View PDF after Export to observe changes . Change-Id: I6717c08348d2df72b6ad79c163216e5bf01b196c --- M filter/source/pdf/impdialog.cxx M filter/source/pdf/impdialog.hrc M filter/source/pdf/impdialog.hxx M filter/source/pdf/impdialog.src M filter/source/pdf/pdfexport.cxx M filter/source/pdf/pdfexport.hxx M filter/source/pdf/pdffilter.cxx M officecfg/registry/data/org/openoffice/Office/WebWizard.xcu M officecfg/registry/schema/org/openoffice/Office/Common.xcs M vcl/inc/vcl/pdfextoutdevdata.hxx M vcl/source/gdi/pdfextoutdevdata.cxx 11 files changed, 60 insertions(+), 0 deletions(-) diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx index 9ddf052..d265328 100644 --- a/filter/source/pdf/impdialog.cxx +++ b/filter/source/pdf/impdialog.cxx @@ -80,6 +80,7 @@ mnMaxImageResolution( 300 ), mbUseTaggedPDF( sal_False ), mbExportNotes( sal_True ), +mbViewPDF( sal_False ), mbExportNotesPages( sal_False ), mbUseTransitionEffects( sal_False ), mbIsSkipEmptyPages( sal_True ), @@ -192,6 +193,7 @@ if ( mbIsPresentation ) mbExportNotesPages = maConfigItem.ReadBool( ExportNotesPages, sal_False ); mbExportNotes = maConfigItem.ReadBool( ExportNotes, sal_False ); +mbViewPDF = maConfigItem.ReadBool( ViewPDFAfterExport, sal_False ); mbExportBookmarks = maConfigItem.ReadBool( ExportBookmarks, sal_True ); if ( mbIsPresentation ) @@ -360,6 +362,7 @@ if ( mbIsPresentation ) maConfigItem.WriteBool( ExportNotesPages, mbExportNotesPages ); maConfigItem.WriteBool( ExportNotes, mbExportNotes ); +maConfigItem.WriteBool( ViewPDFAfterExport, mbViewPDF ); maConfigItem.WriteBool( ExportBookmarks, mbExportBookmarks ); if ( mbIsPresentation ) @@ -511,6 +514,7 @@ maCbExportBookmarks( this, PDFFilterResId( CB_EXPORTBOOKMARKS ) ), maCbExportHiddenSlides( this, PDFFilterResId( CB_EXPORTHIDDENSLIDES ) ), maCbExportNotes( this, PDFFilterResId( CB_EXPORTNOTES ) ), +maCbViewPDF( this, PDFFilterResId( CB_VIEWPDF ) ), maCbExportNotesPages( this, PDFFilterResId( CB_EXPORTNOTESPAGES ) ), maCbExportEmptyPages( this, PDFFilterResId( CB_EXPORTEMPTYPAGES ) ), maCbAddStream( this, PDFFilterResId( CB_ADDSTREAM ) ), @@ -624,6 +628,7 @@ maCbExportBookmarks.Check( paParent-mbExportBookmarks ); maCbExportNotes.Check( paParent-mbExportNotes ); +maCbViewPDF.Check( paParent-mbViewPDF); if ( mbIsPresentation ) { @@ -668,6 +673,7 @@ paParent-mbReduceImageResolution = maCbReduceImageResolution.IsChecked(); paParent-mnMaxImageResolution = maCoReduceImageResolution.GetText().toInt32(); paParent-mbExportNotes = maCbExportNotes.IsChecked(); +paParent-mbViewPDF = maCbViewPDF.IsChecked(); if ( mbIsPresentation ) paParent-mbExportNotesPages = maCbExportNotesPages.IsChecked(); paParent-mbExportBookmarks = maCbExportBookmarks.IsChecked(); @@ -702,6 +708,7 @@ paParent-mbExportFormFields = maCbExportFormFields.IsChecked(); paParent-mbEmbedStandardFonts = maCbEmbedStandardFonts.IsChecked(); } + paParent-maWatermarkText = maEdWatermark.GetText(); /* diff --git a/filter/source/pdf/impdialog.hrc b/filter/source/pdf/impdialog.hrc index 03b6d55..938b622 100644 --- a/filter/source/pdf/impdialog.hrc +++ b/filter/source/pdf/impdialog.hrc @@ -87,6 +87,7 @@ #define CB_WATERMARK32 #define FT_WATERMARK33 #define ED_WATERMARK34 +#define CB_VIEWPDF 35 //controls for open options tab page diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx index 11a3f38..4049d53 100644 --- a/filter/source/pdf/impdialog.hxx +++ b/filter/source/pdf/impdialog.hxx @@ -94,6 +94,7 @@ sal_BoolmbUseTaggedPDF; sal_Int32 mnPDFTypeSelection; sal_BoolmbExportNotes; +sal_BoolmbViewPDF; sal_BoolmbExportNotesPages; sal_BoolmbUseTransitionEffects; sal_BoolmbIsSkipEmptyPages; @@ -210,6 +211,7 @@ CheckBoxmaCbExportBookmarks; CheckBoxmaCbExportHiddenSlides; CheckBoxmaCbExportNotes; +CheckBoxmaCbViewPDF; CheckBoxmaCbExportNotesPages; CheckBoxmaCbExportEmptyPages; diff --git
Re: [PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
It would require make dev-install to work . On Fri, May 3, 2013 at 10:55 PM, Anurag Kanungo (via Code Review) ger...@gerrit.libreoffice.org wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3763 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/corerefs/changes/63/3763/1 fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents. Added an checkbox option View PDF after Export in Export as Pdf Dialog Box . If a user ticks the checkbox , pdf file will be opened after export else only export will be done . Goto File Export as PDF Tick the checkbox View PDF after Export to observe changes . Change-Id: I6717c08348d2df72b6ad79c163216e5bf01b196c --- M filter/source/pdf/impdialog.cxx M filter/source/pdf/impdialog.hrc M filter/source/pdf/impdialog.hxx M filter/source/pdf/impdialog.src M filter/source/pdf/pdfexport.cxx M filter/source/pdf/pdfexport.hxx M filter/source/pdf/pdffilter.cxx M officecfg/registry/data/org/openoffice/Office/WebWizard.xcu M officecfg/registry/schema/org/openoffice/Office/Common.xcs M vcl/inc/vcl/pdfextoutdevdata.hxx M vcl/source/gdi/pdfextoutdevdata.cxx 11 files changed, 60 insertions(+), 0 deletions(-) diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx index 9ddf052..d265328 100644 --- a/filter/source/pdf/impdialog.cxx +++ b/filter/source/pdf/impdialog.cxx @@ -80,6 +80,7 @@ mnMaxImageResolution( 300 ), mbUseTaggedPDF( sal_False ), mbExportNotes( sal_True ), +mbViewPDF( sal_False ), mbExportNotesPages( sal_False ), mbUseTransitionEffects( sal_False ), mbIsSkipEmptyPages( sal_True ), @@ -192,6 +193,7 @@ if ( mbIsPresentation ) mbExportNotesPages = maConfigItem.ReadBool( ExportNotesPages, sal_False ); mbExportNotes = maConfigItem.ReadBool( ExportNotes, sal_False ); +mbViewPDF = maConfigItem.ReadBool( ViewPDFAfterExport, sal_False ); mbExportBookmarks = maConfigItem.ReadBool( ExportBookmarks, sal_True ); if ( mbIsPresentation ) @@ -360,6 +362,7 @@ if ( mbIsPresentation ) maConfigItem.WriteBool( ExportNotesPages, mbExportNotesPages ); maConfigItem.WriteBool( ExportNotes, mbExportNotes ); +maConfigItem.WriteBool( ViewPDFAfterExport, mbViewPDF ); maConfigItem.WriteBool( ExportBookmarks, mbExportBookmarks ); if ( mbIsPresentation ) @@ -511,6 +514,7 @@ maCbExportBookmarks( this, PDFFilterResId( CB_EXPORTBOOKMARKS ) ), maCbExportHiddenSlides( this, PDFFilterResId( CB_EXPORTHIDDENSLIDES ) ), maCbExportNotes( this, PDFFilterResId( CB_EXPORTNOTES ) ), +maCbViewPDF( this, PDFFilterResId( CB_VIEWPDF ) ), maCbExportNotesPages( this, PDFFilterResId( CB_EXPORTNOTESPAGES ) ), maCbExportEmptyPages( this, PDFFilterResId( CB_EXPORTEMPTYPAGES ) ), maCbAddStream( this, PDFFilterResId( CB_ADDSTREAM ) ), @@ -624,6 +628,7 @@ maCbExportBookmarks.Check( paParent-mbExportBookmarks ); maCbExportNotes.Check( paParent-mbExportNotes ); +maCbViewPDF.Check( paParent-mbViewPDF); if ( mbIsPresentation ) { @@ -668,6 +673,7 @@ paParent-mbReduceImageResolution = maCbReduceImageResolution.IsChecked(); paParent-mnMaxImageResolution = maCoReduceImageResolution.GetText().toInt32(); paParent-mbExportNotes = maCbExportNotes.IsChecked(); +paParent-mbViewPDF = maCbViewPDF.IsChecked(); if ( mbIsPresentation ) paParent-mbExportNotesPages = maCbExportNotesPages.IsChecked(); paParent-mbExportBookmarks = maCbExportBookmarks.IsChecked(); @@ -702,6 +708,7 @@ paParent-mbExportFormFields = maCbExportFormFields.IsChecked(); paParent-mbEmbedStandardFonts = maCbEmbedStandardFonts.IsChecked(); } + paParent-maWatermarkText = maEdWatermark.GetText(); /* diff --git a/filter/source/pdf/impdialog.hrc b/filter/source/pdf/impdialog.hrc index 03b6d55..938b622 100644 --- a/filter/source/pdf/impdialog.hrc +++ b/filter/source/pdf/impdialog.hrc @@ -87,6 +87,7 @@ #define CB_WATERMARK32 #define FT_WATERMARK33 #define ED_WATERMARK34 +#define CB_VIEWPDF 35 //controls for open options tab page diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx index 11a3f38..4049d53 100644 --- a/filter/source/pdf/impdialog.hxx +++ b/filter/source/pdf/impdialog.hxx @@ -94,6 +94,7 @@ sal_BoolmbUseTaggedPDF; sal_Int32 mnPDFTypeSelection; sal_BoolmbExportNotes; +sal_BoolmbViewPDF; sal_BoolmbExportNotesPages; sal_BoolmbUseTransitionEffects; sal_BoolmbIsSkipEmptyPages; @@ -210,6 +211,7 @@ CheckBoxmaCbExportBookmarks; CheckBox
[PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3709 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/3709/1 fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents. Added an checkbox option view pdf after Export in Export as Pdf Dialog Box . If a user ticks the checkbox , pdf file will be opened after export else only export will be done . Goto File Export as PDF Tick the checkbox View PDF after Export to observe changes . Change-Id: Ief7d2b4413c0964b472e339a0fb46555227d8c6d --- M filter/source/pdf/impdialog.cxx M filter/source/pdf/impdialog.hrc M filter/source/pdf/impdialog.hxx M filter/source/pdf/impdialog.src M filter/source/pdf/pdffilter.cxx 5 files changed, 32 insertions(+), 0 deletions(-) diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx index 9ddf052..e4a4a90 100644 --- a/filter/source/pdf/impdialog.cxx +++ b/filter/source/pdf/impdialog.cxx @@ -80,6 +80,7 @@ mnMaxImageResolution( 300 ), mbUseTaggedPDF( sal_False ), mbExportNotes( sal_True ), +mbVIEWPDF( sal_False ), mbExportNotesPages( sal_False ), mbUseTransitionEffects( sal_False ), mbIsSkipEmptyPages( sal_True ), @@ -511,6 +512,7 @@ maCbExportBookmarks( this, PDFFilterResId( CB_EXPORTBOOKMARKS ) ), maCbExportHiddenSlides( this, PDFFilterResId( CB_EXPORTHIDDENSLIDES ) ), maCbExportNotes( this, PDFFilterResId( CB_EXPORTNOTES ) ), +maCbVIEWPDF( this, PDFFilterResId( CB_VIEWPDF ) ), maCbExportNotesPages( this, PDFFilterResId( CB_EXPORTNOTESPAGES ) ), maCbExportEmptyPages( this, PDFFilterResId( CB_EXPORTEMPTYPAGES ) ), maCbAddStream( this, PDFFilterResId( CB_ADDSTREAM ) ), @@ -659,6 +661,7 @@ ToggleAddStreamHdl( NULL ); } +int ImpPDFTabGeneralPage::pdfview=0; // To set Default Value of Checkbox (View Pdf after Export) // - void ImpPDFTabGeneralPage::GetFilterConfigItem( ImpPDFTabDialog* paParent ) { @@ -702,6 +705,12 @@ paParent-mbExportFormFields = maCbExportFormFields.IsChecked(); paParent-mbEmbedStandardFonts = maCbEmbedStandardFonts.IsChecked(); } + +if( maCbVIEWPDF.IsChecked() ) +pdfview=1; +else +pdfview=0; + paParent-maWatermarkText = maEdWatermark.GetText(); /* diff --git a/filter/source/pdf/impdialog.hrc b/filter/source/pdf/impdialog.hrc index 03b6d55..938b622 100644 --- a/filter/source/pdf/impdialog.hrc +++ b/filter/source/pdf/impdialog.hrc @@ -87,6 +87,7 @@ #define CB_WATERMARK32 #define FT_WATERMARK33 #define ED_WATERMARK34 +#define CB_VIEWPDF 35 //controls for open options tab page diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx index 11a3f38..ac5915b 100644 --- a/filter/source/pdf/impdialog.hxx +++ b/filter/source/pdf/impdialog.hxx @@ -94,6 +94,7 @@ sal_BoolmbUseTaggedPDF; sal_Int32 mnPDFTypeSelection; sal_BoolmbExportNotes; +sal_BoolmbVIEWPDF; sal_BoolmbExportNotesPages; sal_BoolmbUseTransitionEffects; sal_BoolmbIsSkipEmptyPages; @@ -178,7 +179,9 @@ class ImpPDFTabGeneralPage : public SfxTabPage { friend classImpPDFTabLinksPage; +friend classPDFFilter; +static int pdfview; FixedLine maFlPages; RadioButton maRbAll; RadioButton maRbRange; @@ -210,6 +213,7 @@ CheckBoxmaCbExportBookmarks; CheckBoxmaCbExportHiddenSlides; CheckBoxmaCbExportNotes; +CheckBoxmaCbVIEWPDF; CheckBoxmaCbExportNotesPages; CheckBoxmaCbExportEmptyPages; diff --git a/filter/source/pdf/impdialog.src b/filter/source/pdf/impdialog.src index 8d74616..1d6e202 100644 --- a/filter/source/pdf/impdialog.src +++ b/filter/source/pdf/impdialog.src @@ -278,6 +278,13 @@ TabStop = TRUE ; Text[ en-US ] = ~Export comments; }; +CheckBox CB_VIEWPDF +{ +Pos = MAP_APPFONT ( 188 , 131 ) ; +Size = MAP_APPFONT ( 158 , 10 ) ; +TabStop = TRUE ; +Text[ en-US ] = ~View Pdf after Export; +}; CheckBox CB_EXPORTNOTESPAGES { HelpID = filter:CheckBox:RID_PDF_TAB_GENER:CB_EXPORTNOTESPAGES; diff --git a/filter/source/pdf/pdffilter.cxx b/filter/source/pdf/pdffilter.cxx index 9aadfed..c19618a 100644 --- a/filter/source/pdf/pdffilter.cxx +++ b/filter/source/pdf/pdffilter.cxx @@ -18,13 +18,17 @@ */ +#include impdialog.hxx #include pdffilter.hxx #include pdfexport.hxx #include vcl/svapp.hxx #include
[PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3693 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/3693/1 fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents. Added an checkbox option view pdf after Export in Export Dialog Box . If a user ticks it , pdf file will be opened after export else only export will be done . Change-Id: Ibc4bf200c67d090d61e6024519b9057f9f8bfd6f --- M filter/source/pdf/impdialog.cxx M filter/source/pdf/impdialog.hrc M filter/source/pdf/impdialog.hxx M filter/source/pdf/impdialog.src M filter/source/pdf/pdffilter.cxx 5 files changed, 29 insertions(+), 0 deletions(-) diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx index 9ddf052..d70d17f 100644 --- a/filter/source/pdf/impdialog.cxx +++ b/filter/source/pdf/impdialog.cxx @@ -39,6 +39,7 @@ #include boost/shared_ptr.hpp +extern int pdfview; static ResMgr getPDFFilterResMgr() { static ResMgr *pRes = ResMgr::CreateResMgr( pdffilter, Application::GetSettings().GetUILanguageTag()); @@ -80,6 +81,7 @@ mnMaxImageResolution( 300 ), mbUseTaggedPDF( sal_False ), mbExportNotes( sal_True ), +mbVIEWPDF( sal_False ), mbExportNotesPages( sal_False ), mbUseTransitionEffects( sal_False ), mbIsSkipEmptyPages( sal_True ), @@ -511,6 +513,7 @@ maCbExportBookmarks( this, PDFFilterResId( CB_EXPORTBOOKMARKS ) ), maCbExportHiddenSlides( this, PDFFilterResId( CB_EXPORTHIDDENSLIDES ) ), maCbExportNotes( this, PDFFilterResId( CB_EXPORTNOTES ) ), +maCbVIEWPDF( this, PDFFilterResId( CB_VIEWPDF ) ), maCbExportNotesPages( this, PDFFilterResId( CB_EXPORTNOTESPAGES ) ), maCbExportEmptyPages( this, PDFFilterResId( CB_EXPORTEMPTYPAGES ) ), maCbAddStream( this, PDFFilterResId( CB_ADDSTREAM ) ), @@ -702,6 +705,12 @@ paParent-mbExportFormFields = maCbExportFormFields.IsChecked(); paParent-mbEmbedStandardFonts = maCbEmbedStandardFonts.IsChecked(); } + +if( maCbVIEWPDF.IsChecked() ) +pdfview=1; +else +pdfview=0; + paParent-maWatermarkText = maEdWatermark.GetText(); /* diff --git a/filter/source/pdf/impdialog.hrc b/filter/source/pdf/impdialog.hrc index 03b6d55..938b622 100644 --- a/filter/source/pdf/impdialog.hrc +++ b/filter/source/pdf/impdialog.hrc @@ -87,6 +87,7 @@ #define CB_WATERMARK32 #define FT_WATERMARK33 #define ED_WATERMARK34 +#define CB_VIEWPDF 35 //controls for open options tab page diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx index 11a3f38..3b0d96c 100644 --- a/filter/source/pdf/impdialog.hxx +++ b/filter/source/pdf/impdialog.hxx @@ -94,6 +94,7 @@ sal_BoolmbUseTaggedPDF; sal_Int32 mnPDFTypeSelection; sal_BoolmbExportNotes; +sal_BoolmbVIEWPDF; sal_BoolmbExportNotesPages; sal_BoolmbUseTransitionEffects; sal_BoolmbIsSkipEmptyPages; @@ -210,6 +211,7 @@ CheckBoxmaCbExportBookmarks; CheckBoxmaCbExportHiddenSlides; CheckBoxmaCbExportNotes; +CheckBoxmaCbVIEWPDF; CheckBoxmaCbExportNotesPages; CheckBoxmaCbExportEmptyPages; diff --git a/filter/source/pdf/impdialog.src b/filter/source/pdf/impdialog.src index 8d74616..1d6e202 100644 --- a/filter/source/pdf/impdialog.src +++ b/filter/source/pdf/impdialog.src @@ -278,6 +278,13 @@ TabStop = TRUE ; Text[ en-US ] = ~Export comments; }; +CheckBox CB_VIEWPDF +{ +Pos = MAP_APPFONT ( 188 , 131 ) ; +Size = MAP_APPFONT ( 158 , 10 ) ; +TabStop = TRUE ; +Text[ en-US ] = ~View Pdf after Export; +}; CheckBox CB_EXPORTNOTESPAGES { HelpID = filter:CheckBox:RID_PDF_TAB_GENER:CB_EXPORTNOTESPAGES; diff --git a/filter/source/pdf/pdffilter.cxx b/filter/source/pdf/pdffilter.cxx index 9aadfed..8c660b9 100644 --- a/filter/source/pdf/pdffilter.cxx +++ b/filter/source/pdf/pdffilter.cxx @@ -24,7 +24,11 @@ #include vcl/window.hxx #include svl/outstrm.hxx #include vcl/FilterConfigItem.hxx +#include com/sun/star/system/SystemShellExecute.hpp +#include com/sun/star/system/SystemShellExecuteFlags.hpp +using namespace css::system; +int pdfview; // - // - PDFFilter - // - @@ -51,6 +55,7 @@ sal_BoolbRet = sal_False; Reference task::XStatusIndicator xStatusIndicator; Reference task::XInteractionHandler xIH; +OUString aUrl; for ( sal_Int32 i = 0 ; ( i nLength ) !xOStm.is(); ++i) { @@ -62,6 +67,8 @@ pValue[ i ].Value = xStatusIndicator; else if ( pValue[i].Name ==
Re: [PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
It is the Dialog box which is opened after clicking on Export as PDF , Screen shot is attached On Tue, Apr 30, 2013 at 2:08 PM, Anurag Kanungo (via Code Review) ger...@gerrit.libreoffice.org wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3693 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/corerefs/changes/93/3693/1 fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents. Added an checkbox option view pdf after Export in Export Dialog Box . If a user ticks it , pdf file will be opened after export else only export will be done . Change-Id: Ibc4bf200c67d090d61e6024519b9057f9f8bfd6f --- M filter/source/pdf/impdialog.cxx M filter/source/pdf/impdialog.hrc M filter/source/pdf/impdialog.hxx M filter/source/pdf/impdialog.src M filter/source/pdf/pdffilter.cxx 5 files changed, 29 insertions(+), 0 deletions(-) diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx index 9ddf052..d70d17f 100644 --- a/filter/source/pdf/impdialog.cxx +++ b/filter/source/pdf/impdialog.cxx @@ -39,6 +39,7 @@ #include boost/shared_ptr.hpp +extern int pdfview; static ResMgr getPDFFilterResMgr() { static ResMgr *pRes = ResMgr::CreateResMgr( pdffilter, Application::GetSettings().GetUILanguageTag()); @@ -80,6 +81,7 @@ mnMaxImageResolution( 300 ), mbUseTaggedPDF( sal_False ), mbExportNotes( sal_True ), +mbVIEWPDF( sal_False ), mbExportNotesPages( sal_False ), mbUseTransitionEffects( sal_False ), mbIsSkipEmptyPages( sal_True ), @@ -511,6 +513,7 @@ maCbExportBookmarks( this, PDFFilterResId( CB_EXPORTBOOKMARKS ) ), maCbExportHiddenSlides( this, PDFFilterResId( CB_EXPORTHIDDENSLIDES ) ), maCbExportNotes( this, PDFFilterResId( CB_EXPORTNOTES ) ), +maCbVIEWPDF( this, PDFFilterResId( CB_VIEWPDF ) ), maCbExportNotesPages( this, PDFFilterResId( CB_EXPORTNOTESPAGES ) ), maCbExportEmptyPages( this, PDFFilterResId( CB_EXPORTEMPTYPAGES ) ), maCbAddStream( this, PDFFilterResId( CB_ADDSTREAM ) ), @@ -702,6 +705,12 @@ paParent-mbExportFormFields = maCbExportFormFields.IsChecked(); paParent-mbEmbedStandardFonts = maCbEmbedStandardFonts.IsChecked(); } + +if( maCbVIEWPDF.IsChecked() ) +pdfview=1; +else +pdfview=0; + paParent-maWatermarkText = maEdWatermark.GetText(); /* diff --git a/filter/source/pdf/impdialog.hrc b/filter/source/pdf/impdialog.hrc index 03b6d55..938b622 100644 --- a/filter/source/pdf/impdialog.hrc +++ b/filter/source/pdf/impdialog.hrc @@ -87,6 +87,7 @@ #define CB_WATERMARK32 #define FT_WATERMARK33 #define ED_WATERMARK34 +#define CB_VIEWPDF 35 //controls for open options tab page diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx index 11a3f38..3b0d96c 100644 --- a/filter/source/pdf/impdialog.hxx +++ b/filter/source/pdf/impdialog.hxx @@ -94,6 +94,7 @@ sal_BoolmbUseTaggedPDF; sal_Int32 mnPDFTypeSelection; sal_BoolmbExportNotes; +sal_BoolmbVIEWPDF; sal_BoolmbExportNotesPages; sal_BoolmbUseTransitionEffects; sal_BoolmbIsSkipEmptyPages; @@ -210,6 +211,7 @@ CheckBoxmaCbExportBookmarks; CheckBoxmaCbExportHiddenSlides; CheckBoxmaCbExportNotes; +CheckBoxmaCbVIEWPDF; CheckBoxmaCbExportNotesPages; CheckBoxmaCbExportEmptyPages; diff --git a/filter/source/pdf/impdialog.src b/filter/source/pdf/impdialog.src index 8d74616..1d6e202 100644 --- a/filter/source/pdf/impdialog.src +++ b/filter/source/pdf/impdialog.src @@ -278,6 +278,13 @@ TabStop = TRUE ; Text[ en-US ] = ~Export comments; }; +CheckBox CB_VIEWPDF +{ +Pos = MAP_APPFONT ( 188 , 131 ) ; +Size = MAP_APPFONT ( 158 , 10 ) ; +TabStop = TRUE ; +Text[ en-US ] = ~View Pdf after Export; +}; CheckBox CB_EXPORTNOTESPAGES { HelpID = filter:CheckBox:RID_PDF_TAB_GENER:CB_EXPORTNOTESPAGES; diff --git a/filter/source/pdf/pdffilter.cxx b/filter/source/pdf/pdffilter.cxx index 9aadfed..8c660b9 100644 --- a/filter/source/pdf/pdffilter.cxx +++ b/filter/source/pdf/pdffilter.cxx @@ -24,7 +24,11 @@ #include vcl/window.hxx #include svl/outstrm.hxx #include vcl/FilterConfigItem.hxx +#include com/sun/star/system/SystemShellExecute.hpp +#include com/sun/star/system/SystemShellExecuteFlags.hpp +using namespace css::system; +int pdfview; // - // - PDFFilter - // - @@ -51,6 +55,7 @@ sal_BoolbRet =
[PATCH] fdo#37222 and fdo#37219 Open pdf after Export and added to ...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3692 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/3692/1 fdo#37222 and fdo#37219 Open pdf after Export and added to recent documents . It opens every pdf after being exported . Change-Id: Ie055b3ee2041457dd4b1db6cd7fe04b62764ec6f --- M filter/source/pdf/pdffilter.cxx 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/filter/source/pdf/pdffilter.cxx b/filter/source/pdf/pdffilter.cxx index 9aadfed..5abc38d 100644 --- a/filter/source/pdf/pdffilter.cxx +++ b/filter/source/pdf/pdffilter.cxx @@ -24,6 +24,10 @@ #include vcl/window.hxx #include svl/outstrm.hxx #include vcl/FilterConfigItem.hxx +#include com/sun/star/system/SystemShellExecute.hpp +#include com/sun/star/system/SystemShellExecuteFlags.hpp + +using namespace css::system; // - // - PDFFilter - @@ -51,6 +55,7 @@ sal_BoolbRet = sal_False; Reference task::XStatusIndicator xStatusIndicator; Reference task::XInteractionHandler xIH; +OUString aUrl; for ( sal_Int32 i = 0 ; ( i nLength ) !xOStm.is(); ++i) { @@ -62,6 +67,8 @@ pValue[ i ].Value = xStatusIndicator; else if ( pValue[i].Name == InteractionHandler ) pValue[i].Value = xIH; +else if ( pValue[ i ].Name == URL ) +pValue[ i ].Value = aUrl; } /* we don't get FilterData if we are exporting directly @@ -132,7 +139,8 @@ } } } - +ReferenceXSystemShellExecute xSystemShellExecute(SystemShellExecute::create( ::comphelper::getProcessComponentContext() ) ); //Open the newly exported pdf +xSystemShellExecute-execute(aUrl, , SystemShellExecuteFlags::URIS_ONLY ); return bRet; } -- To view, visit https://gerrit.libreoffice.org/3692 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie055b3ee2041457dd4b1db6cd7fe04b62764ec6f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Anurag Kanungo anuragkanu...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice