Re: [SOLVED] Re: Wrong copy paste in ucbcmds.cxx? (ucb module)

[Stephan Bergmann]

On 05/20/2014 08:13 PM, julien2412 wrote:

I pushed the fix on master (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f332958999cc38ad778ac381cc67d249e9bd918a)
I didn't gerrit review on 4.2 since it's not related to a known bug but if
you want to, I can.


I don't think it would be worth it.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[SOLVED] Re: Wrong copy paste in ucbcmds.cxx? (ucb module)

[julien2412]

sberg wrote
 ...
 I wonder if line 254 could be a wrong copy paste and should be:
 cppu::UnoType
 ucb::CheckinArgument
 ::get() );
 
 Yes, that's wrong.  (See UniversalContentBroker::execute in 
 ucb/source/core/ucb.cxx, where CHECKIN_HANDLE/CHECKIN_NAME expects to 
 get a CheckinArgument, not a GlobalTransferCommandArgument.

Thank you Stephan for your feedback.
I pushed the fix on master (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f332958999cc38ad778ac381cc67d249e9bd918a)
I didn't gerrit review on 4.2 since it's not related to a known bug but if
you want to, I can.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Wrong-copy-paste-in-ucbcmds-cxx-ucb-module-tp4109103p4109522.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice