Re: [SOLVED] Re: unused easy code, getZoneOffsetInMillis (unotools)
Hi julien2412, On Sunday, 2015-02-15 04:07:56 -0700, julien2412 wrote: Anyway, I pushed the patch, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=836481e35999c3722f1c4fdef8c86c8c098a2492 Yup, the only use was eliminated with http://cgit.freedesktop.org/libreoffice/core/commit/?id=c72cd80f4503f54f6c79cdc1ab03b0654663f488 Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack pgpOodHrDApak.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [SOLVED] Re: unused easy code, getZoneOffsetInMillis (unotools)
Hi Miklos, Indeed, I wasn't sure to have understood so I had mentally changed your last sentence: So no, it doesn't mean that removing a method there would be relevant from the stable public API perspective to: So no, it does mean that removing a method there wouldn't be relevant from the stable public API perspective :-) Anyway, I pushed the patch, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=836481e35999c3722f1c4fdef8c86c8c098a2492 Julien -- View this message in context: http://nabble.documentfoundation.org/unused-easy-code-getZoneOffsetInMillis-unotools-tp4140095p4140158.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[SOLVED] Re: unused easy code, getZoneOffsetInMillis (unotools)
Thank you Miklos for your feedback so I won't remove them since it would change public API. Julien -- View this message in context: http://nabble.documentfoundation.org/unused-easy-code-getZoneOffsetInMillis-unotools-tp4140095p4140140.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [SOLVED] Re: unused easy code, getZoneOffsetInMillis (unotools)
Hi Julien, On Sun, Feb 15, 2015 at 01:05:36AM -0700, julien2412 serval2...@yahoo.fr wrote: Thank you Miklos for your feedback so I won't remove them since it would change public API. You got it wrong, my suggestion was that it's *not* part of the public API, even if it has public in the macro name, i.e. you can remove it if it's truly unused. :-) Regards, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
