Re: .docx file immediately crashes LibreOffice 4.0.2.2

2013-05-13 Thread Manuel Reimer

Norbert Thiebaud wrote:

I pinged cbosdonnat with it... he should be reviewing it shortly, to
make sure that it does not create 'other' side effects...


Is there someone else, who could be added to the CC list.

So far it seems like a crash bug, that makes it impossible to edit some files 
with LibreOffice, has only a low priority...


Yours

Manuel

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: .docx file immediately crashes LibreOffice 4.0.2.2

2013-05-07 Thread Manuel Reimer

Norbert Thiebaud wrote:

I asked the author and I got the permission to publish the file, so I filed
a bug here:
https://bugs.freedesktop.org/show_bug.cgi?id=64249


Yep, that is the way to go :-)

the patch below worked around the crash for me... :


This is a very good start but how to get this fix into the next release? How to 
get a developer informed about the bug to review this patch and commit it to VCS?


Yours

Manuel

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: .docx file immediately crashes LibreOffice 4.0.2.2

2013-05-07 Thread Norbert Thiebaud
On Tue, May 7, 2013 at 4:13 PM, Manuel Reimer
manuel.s...@nurfuerspam.de wrote:
 Norbert Thiebaud wrote:

 I asked the author and I got the permission to publish the file, so I
 filed
 a bug here:
 https://bugs.freedesktop.org/show_bug.cgi?id=64249


 Yep, that is the way to go :-)

 the patch below worked around the crash for me... :


 This is a very good start but how to get this fix into the next release? How
 to get a developer informed about the bug to review this patch and commit it
 to VCS?

I pinged cbosdonnat with it... he should be reviewing it shortly, to
make sure that it does not create 'other' side effects...

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


.docx file immediately crashes LibreOffice 4.0.2.2

2013-05-05 Thread Manuel Reimer

Hello,

I have a .docx file which immediately crashes LibreOffice.

Can someone please tell me where I can send this file to so a developer can have 
a look at this file? I can't publish the file on the internet, as the content in 
this file is copyright protected.


Would be great if one of the developers could give me his mail address, so I can 
send him my file and he (or the group of developers) can check why LibreOffice 
crashes.


Thanks in advance

Yours

Manuel

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: .docx file immediately crashes LibreOffice 4.0.2.2

2013-05-05 Thread Manuel Reimer

Manuel Reimer wrote:

I have a .docx file which immediately crashes LibreOffice.

Can someone please tell me where I can send this file to so a developer can have
a look at this file? I can't publish the file on the internet, as the content in
this file is copyright protected.


I asked the author and I got the permission to publish the file, so I filed a 
bug here:

https://bugs.freedesktop.org/show_bug.cgi?id=64249

Yours

Manuel

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: .docx file immediately crashes LibreOffice 4.0.2.2

2013-05-05 Thread Norbert Thiebaud
On Sun, May 5, 2013 at 12:55 PM, Manuel Reimer
manuel.s...@nurfuerspam.de wrote:
 Manuel Reimer wrote:

 I have a .docx file which immediately crashes LibreOffice.

 Can someone please tell me where I can send this file to so a developer
 can have
 a look at this file? I can't publish the file on the internet, as the
 content in
 this file is copyright protected.


 I asked the author and I got the permission to publish the file, so I filed
 a bug here:
 https://bugs.freedesktop.org/show_bug.cgi?id=64249

Yep, that is the way to go :-)

the patch below worked around the crash for me... :

diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index b5a5baa..2efc636 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1647,6 +1647,8 @@ void DomainMapper_Impl::PushShapeContext( const
uno::Reference drawing::XShape
 if (m_aTextAppendStack.empty())
 return;
 uno::Referencetext::XTextAppend xTextAppend =
m_aTextAppendStack.top().xTextAppend;
+appendTableManager( );
+appendTableHandler( );
 try
 {
 uno::Reference lang::XServiceInfo  xSInfo( xShape,
uno::UNO_QUERY_THROW );
@@ -1705,15 +1707,12 @@ void DomainMapper_Impl::PushShapeContext(
const uno::Reference drawing::XShape
 xProps-setPropertyValue( rPropNameSupplier.GetName(
PROP_ANCHOR_TYPE ), bIsGraphic  ?  uno::makeAny(
text::TextContentAnchorType_AS_CHARACTER ) : uno::makeAny(
text::TextContentAnchorType_AT_PARAGRAPH ) );
 }
 }
-
-appendTableManager( );
-appendTableHandler( );
-getTableManager().startLevel();
 }
 catch ( const uno::Exception e )
 {
 SAL_WARN(writerfilter, Exception when adding shape:   e.Message);
 }
+getTableManager().startLevel();
 }

it seems that that was introduced as a side effect of
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d4fd86e3a48defbff29bfbabfbf0d2c5d95d39f5

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice