Re: Build failure on master with OSX - datetime.hxx
Le 20/04/13 12:09, Jonathan Aquilina a écrit : Still failing for me in dbconversion.cxx:42 : error : integer constant is too large for 'long' type Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build failure on master with OSX - datetime.hxx
On Mon, Apr 22, 2013 at 09:29:45AM +0200, Alexander Thurgood wrote: Still failing for me in dbconversion.cxx:42 : error : integer constant is too large for 'long' type Should have been fixed by commit 693d25f8a601ee3738a396fbd8a9b838f19e39c9 Author: Norbert Thiebaud nthieb...@gmail.com Date: Sat Apr 20 17:31:26 2013 -0500 connectivity: use LL qualifier for int64 contants Change-Id: Iaafbd62920c2b695c5810766d143a01c288e813f If not, let us know. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build failure on master with OSX - datetime.hxx
Le 22/04/13 10:20, Lionel Elie Mamane a écrit : On Mon, Apr 22, 2013 at 09:29:45AM +0200, Alexander Thurgood wrote: Should have been fixed by commit 693d25f8a601ee3738a396fbd8a9b838f19e39c9 Author: Norbert Thiebaud nthieb...@gmail.com Date: Sat Apr 20 17:31:26 2013 -0500 connectivity: use LL qualifier for int64 contants Change-Id: Iaafbd62920c2b695c5810766d143a01c288e813f Ah, OK, I started my build before that commit went in. Will do a fresh pull/build. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build failure on master with OSX - datetime.hxx
On Mon, Apr 22, 2013 at 10:28:21AM +0200, Alexander Thurgood wrote: Le 22/04/13 10:20, Lionel Elie Mamane a écrit : On Mon, Apr 22, 2013 at 09:29:45AM +0200, Alexander Thurgood wrote: Should have been fixed by commit 693d25f8a601ee3738a396fbd8a9b838f19e39c9 Ah, OK, I started my build before that commit went in. Will do a fresh pull/build. Some git recipes for such cases: First, do git fetch. It will do the first half of a pull, that is fetch the new commits from the central repository, but without touching your local branches / tree. Then, you can do stuff like: git diff HEAD..remotes/origin/master -- path/to/file.cxx git log -p HEAD..remotes/origin/master -- path/to/file.cxx git blame remotes/origin/master -- path/to/file.cxx to see the state of that file in the central repository, and see if the failing line has been changed since you last pulled. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build failure on master with OSX - datetime.hxx
Le 22/04/13 10:34, Lionel Elie Mamane a écrit : to see the state of that file in the central repository, and see if the failing line has been changed since you last pulled. Cheers, I must admit to not really understanding the details of how git works in practice (despite reading some of the man pages and even a more graphical explanation), so the various commands for fetching bits, rolling back, resetting, and comparing, etc, are still confusing for me. I have saved your tips for future reference. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build failure on master with OSX - datetime.hxx
Le 19/04/2013 18:33, Lionel Elie Mamane a écrit : Hi Lionel, This should be fixed by commit ec49915442055f5b8f0055f2c250a0da096a3c1b Author: Stephan Bergmann sberg...@redhat.com Date: Fri Apr 19 17:05:55 2013 +0200 Wrap large values in SAL_CONST_UINT64 Thanks, am going to check on the machine later today. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build failure on master with OSX - datetime.hxx
I just left a build running while i was away 52min later it was successful build on master for me :) On Sat, Apr 20, 2013 at 12:08 PM, Alex Thurgood alex.thurg...@gmail.comwrote: Le 19/04/2013 18:33, Lionel Elie Mamane a écrit : Hi Lionel, This should be fixed by commit ec49915442055f5b8f0055f2c250a0da096a3c1b Author: Stephan Bergmann sberg...@redhat.com Date: Fri Apr 19 17:05:55 2013 +0200 Wrap large values in SAL_CONST_UINT64 Thanks, am going to check on the machine later today. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Jonathan Aquilina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Build failure on master with OSX - datetime.hxx
Hi all, I'm getting a build failure this morning on OSX with pull from master in datetime.hxx : [build CXX] tools/source/datetime/datetime.cxx [build CXX] tools/source/datetime/ttime.cxx [build CXX] tools/source/fsys/tempfile.cxx In file included from /Users/Shared/Repos/LO/core/tools/inc/tools/datetime.hxx:25, from /Users/Shared/Repos/LO/core/tools/source/datetime/datetime.cxx:19: /Users/Shared/Repos/LO/core/tools/inc/tools/time.hxx:81: error: integer constant is too large for ‘long’ type /Users/Shared/Repos/LO/core/tools/inc/tools/time.hxx:84: error: integer constant is too large for ‘long’ type make[1]: *** [/Users/Shared/Repos/LO/core/workdir/unxmacxi.pro/CxxObject/tools/source/datetime/datetime.o] Error 1 make[1]: *** Waiting for unfinished jobs In file included from /Users/Shared/Repos/LO/core/tools/source/datetime/ttime.cxx:34: /Users/Shared/Repos/LO/core/tools/inc/tools/time.hxx:81: error: integer constant is too large for ‘long’ type /Users/Shared/Repos/LO/core/tools/inc/tools/time.hxx:84: error: integer constant is too large for ‘long’ type /Users/Shared/Repos/LO/core/tools/source/datetime/ttime.cxx:45: error: integer constant is too large for ‘long’ type /Users/Shared/Repos/LO/core/tools/source/datetime/ttime.cxx:46: error: integer constant is too large for ‘long’ type make[1]: *** [/Users/Shared/Repos/LO/core/workdir/unxmacxi.pro/CxxObject/tools/source/datetime/ttime.o] Error 1 make: *** [build] Error 2 Could this be a result of Lionel's recent changes to that code ? Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build failure on master with OSX - datetime.hxx
Le 19/04/13 14:44, Alexander Thurgood a écrit :
/Users/Shared/Repos/LO/core/tools/inc/tools/time.hxx:81: error: integer
constant is too large for ‘long’ type
/Users/Shared/Repos/LO/core/tools/inc/tools/time.hxx:84: error: integer
constant is too large for ‘long’ type
sal_uInt16 GetHour() const
{ sal_uInt64 nTempTime = (nTime = 0) ? nTime : -nTime;
return static_castsal_uInt16(nTempTime /
10); }
sal_uInt16 GetMin() const
{ sal_uInt64 nTempTime = (nTime = 0) ? nTime : -nTime;
return static_castsal_uInt16((nTempTime /
1000) % 100); }
Alex
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build failure on master with OSX - datetime.hxx
On Fri, Apr 19, 2013 at 02:44:58PM +0200, Alexander Thurgood wrote: datetime.hxx : In file included from /Users/Shared/Repos/LO/core/tools/inc/tools/datetime.hxx:25, from /Users/Shared/Repos/LO/core/tools/source/datetime/datetime.cxx:19: /Users/Shared/Repos/LO/core/tools/inc/tools/time.hxx:81: error: integer constant is too large for ‘long’ type /Users/Shared/Repos/LO/core/tools/inc/tools/time.hxx:84: error: integer constant is too large for ‘long’ type make[1]: *** This should be fixed by commit ec49915442055f5b8f0055f2c250a0da096a3c1b Author: Stephan Bergmann sberg...@redhat.com Date: Fri Apr 19 17:05:55 2013 +0200 Wrap large values in SAL_CONST_UINT64 Change-Id: I865808911043a61de5c4209fa889dbff7c8baf28 If not, contact us again :) -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
