[RESOLVED] Re: Cppcheck reports Resource leak in setup_native/source/win32/wintools/makecab/parseddf.c

2013-02-11 Thread Caolán McNamara 
On Thu, 2012-12-27 at 06:30 -0800, julien2412 wrote:
 Hello,
 
 cppcheck reported this:
 [setup_native/source/win32/wintools/makecab/parseddf.c:381]: (error)
 Resource leak: ddf
 it's in the function ParseDdf
 fclose function seems to miss.

Fixed by your own
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e7014ca47b9147c925fb99154b55c71c7127e935
 now I believe.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Cppcheck reports Resource leak in setup_native/source/win32/wintools/makecab/parseddf.c

2012-12-27 Thread julien2412 
Hello,

cppcheck reported this:
[setup_native/source/win32/wintools/makecab/parseddf.c:381]: (error)
Resource leak: ddf
it's in the function ParseDdf
fclose function seems to miss.

(see
http://opengrok.libreoffice.org/xref/core/setup_native/source/win32/wintools/makecab/parseddf.c#356)

I'm not able to build on Windows but I think that adding this line:
fclose (ddf);

before this line:
return DDF_OK;

should be ok.

Someone to confirm?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-reports-Resource-leak-in-setup-native-source-win32-wintools-makecab-parseddf-c-tp4026214.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice