[Libreoffice-bugs] [Bug 80387] [EasyHack] extend lint-ui.py to check for UI title labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80387

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||143781


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143781
[Bug 143781] [META] Development- and code-related bug reports and tasks
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148251] New: Use std::swap instead of using temporary values, proposed beginner easyHack

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148251

Bug ID: 148251
   Summary: Use std::swap instead of using temporary values,
proposed beginner easyHack
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: parisop...@gmail.com

Description:
There's places in code where a swap between two variables happens like this:

T temp = a;
a = b;
b = temp;

There's no need to clutter code with 3 lines where just one is enough:

std::swap(a, b);

Furthermore, std::swap uses move semantics which can improve performance for
big data members.

How to find occurrences:

You can use this regex that currently finds 78 results:

(\w+)[\n\r\s]+(\w+)[\n\r\s]+=[\n\r\s]+(\w+);[\n\r\s]+(\3)[\n\r\s]+=[\n\r\s]+(\w+);[\n\r\s]+(\5)[\n\r\s]+=[\n\r\s]+(\2)

[\n\r\s]+ matches newlines and spaces. This exhaustively searches for any weird
combination of spaces between the type/variable names/semicolons

See this https://gerrit.libreoffice.org/c/core/+/132194 for an example

Steps to Reproduce:
-

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No



Additional Info:
-

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 45678] EasyHack: kill hwpfilter/source/list.hxx with fire

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45678

badmaeva_n...@mail.ru  changed:

   What|Removed |Added

 CC||badmaeva_n...@mail.ru

--- Comment #7 from badmaeva_n...@mail.ru  ---
*** Bug 146351 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: EasyHack Suggestion: Use range based for loops

[Stephan Bergmann]

On 10/21/21 17:25, Luboš Luňák wrote:

On Thursday 21 of October 2021, Hossein Nourikhah wrote:

Since C++11, range based loops are available for iterating over a known
range of values. For example, when there is a need to process elements
of a container, range based loops are usually a good choice. They are
easy to write, read and understand.

The simplest form is as below:

for(auto variable : range)
statement;


  I generally dislike the (ab)use of 'auto' to save a little typing at the
expense of readibility. Code is read much more often than written, and it's
also quite often read e.g. in gerrit where there's nothing to easily tell
what 'auto' is, so generally code should be aimed at being easy to read, not
necessarily to write. It's not black or white of course, but I disagree with
something that generically advises to use 'auto'.


Range based loops can simplify the code, but there are limitations for
them. For example, if there is a need not to iterate over certain
values, std::ranges::views::drop (C++20) should be used, so they are not
suitable for replacing every normal for loop.


  If the instructions are aimed at people who need spelling out how to use
ranged for loops, then it needs to stress more that it is basically usable
only for sequential iterating over elements of a container that does not
change. Otherwise we risk that newbies will break things by rewriting even
non-trivial loops.


Maybe cut the complete easy hack description down to just "Use range 
based for loops ...where applicable, across the source code".  Those 
easy hacks are meant for people to start getting involved in LO 
development, not to teach people about C++ in general.

Re: EasyHack Suggestion: Use range based for loops

[Luboš Luňák]

On Thursday 21 of October 2021, Hossein Nourikhah wrote:
> Since C++11, range based loops are available for iterating over a known
> range of values. For example, when there is a need to process elements
> of a container, range based loops are usually a good choice. They are
> easy to write, read and understand.
>
> The simplest form is as below:
>
> for(auto variable : range)
>   statement;

 I generally dislike the (ab)use of 'auto' to save a little typing at the 
expense of readibility. Code is read much more often than written, and it's 
also quite often read e.g. in gerrit where there's nothing to easily tell 
what 'auto' is, so generally code should be aimed at being easy to read, not 
necessarily to write. It's not black or white of course, but I disagree with 
something that generically advises to use 'auto'.

> Range based loops can simplify the code, but there are limitations for
> them. For example, if there is a need not to iterate over certain
> values, std::ranges::views::drop (C++20) should be used, so they are not
> suitable for replacing every normal for loop.

 If the instructions are aimed at people who need spelling out how to use 
ranged for loops, then it needs to stress more that it is basically usable 
only for sequential iterating over elements of a container that does not 
change. Otherwise we risk that newbies will break things by rewriting even 
non-trivial loops.

 And that std::ranges::views::drop part does not belong there at all. C++20 
makes it useless for now, and even without that it would only confuse people.

-- 
 Luboš Luňák
 l.lu...@collabora.com

EasyHack Suggestion: Use range based for loops

[Hossein Nourikhah]

Hello,

This is a suggestion for adding an EasyHack with the difficulty 
"Beginner". I have asked one of the newbies to do a submission regarding 
this. Please tell me your opinion. I welcome any suggestions.


Regards,
Hossein


**Use range based for loops**

Since C++11, range based loops are available for iterating over a known 
range of values. For example, when there is a need to process elements 
of a container, range based loops are usually a good choice. They are 
easy to write, read and understand.


The simplest form is as below:

for(auto variable : range)
statement;

In this way, a temporary variable is created to iterate over the range 
of values. But this is usually undesirable because the variable is 
copied.


When a change in the values of the elements is needed, a reference is 
used:


for(auto  : range)
statement;

It is possible to use the reference, but use const to prevent 
modification. This is useful for working on big elements.


for(const auto  : range)
statement;

Range based loops can simplify the code, but there are limitations for 
them. For example, if there is a need not to iterate over certain 
values, std::ranges::views::drop (C++20) should be used, so they are not 
suitable for replacing every normal for loop.


This is an example:
123758: Use range based for loops | 
https://gerrit.libreoffice.org/c/core/+/123758


This is changed:

for(size_t a(0); a < aMatrices.size(); a++)
{
rContainer.push_back(new TransformPrimitive2D(
getTransformation() * aMatrices[a],
Primitive2DContainer(xSeq)));
}

into this:

for(const auto  : aMatrices)
{
rContainer.push_back(new TransformPrimitive2D(
getTransformation() * a, Primitive2DContainer(xSeq)));
}

References:
+ Range-based for loop
https://en.cppreference.com/w/cpp/language/range-for
+Range-based for Statement (C++)
https://docs.microsoft.com/en-us/cpp/cpp/range-based-for-statement-cpp


--
Hossein Nourikhah, Ph.D.
Developer Community Architect
The Document Foundation (TDF)
Email: hoss...@libreoffice.org
Wiki:  https://wiki.documentfoundation.org/User:Hossein
IRC:   hossein at libreoffice-dev room in LiberaChat Network
   irc://irc.libera.chat/#libreoffice-dev

[Libreoffice-bugs] [Bug 38824] [EasyHack] Correct interpretation of -x^y

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38824

b.  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||6268

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Seeking Help in Resolving easyHack

[Aditya Sahu]

Hi,
I'm trying to fix tdf#47065
<https://bugs.documentfoundation.org/show_bug.cgi?id=47065> as it's a
challenging *easyHack*. I have decided to move one step at a time in order
to resolve it at a slow and steady pace.
My first step is to find out a way to check if the lock from the previously
opened file is released and the file is now ready to use. In the change [1]
<https://gerrit.libreoffice.org/#/c/84919/4/sfx2/source/doc/docfile.cxx> ,
I have tried to check if the file lock has been disappeared, please let me
know if it is the right way to do it.  I also tested the change on my
local machine to see if it works.

I've made use of this expression:

*bool* bHandleSysLocked
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#bHandleSysLocked>
= ( bLoading 
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#bLoading>
&& bUseSystemLock
<https://opengrok.libreoffice.org/s?defs=bUseSystemLock=core>
&& !pImpl 
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#pImpl>->xStream
<https://opengrok.libreoffice.org/s?defs=xStream=core>.is
<https://opengrok.libreoffice.org/s?defs=is=core>() && !pImpl
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#pImpl>->m_pOutStream
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#m_pOutStream>
);


Also, when reviewing the change, please try to ignore the function and
variable names which were chosen arbitrarily..
Any given help is appreciated. Thanks!

--
Regards,
Aditya

[1] https://gerrit.libreoffice.org/#/c/84919/4/sfx2/source/doc/docfile.cxx
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Close EasyHack tdf#96099 "Reduce number of typedefs used for trivial container types"?

[Stephan Bergmann]

On 29/06/18 10:16, Stephan Bergmann wrote:
Shall we close the EasyHack 
<https://bugs.documentfoundation.org/show_bug.cgi?id=96099> "Reduce 
number of typedefs used for trivial container types" for good now?


done, <https://bugs.documentfoundation.org/show_bug.cgi?id=96099#c68>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Close EasyHack tdf#96099 "Reduce number of typedefs used for trivial container types"?

[Eike Rathke]

Hi,

On Friday, 2018-06-29 10:16:17 +0200, Stephan Bergmann wrote:

> Following good tradition of not discussing the usefulness of EasyHack bugs
> directly in bugzilla, lets do that here:
> 
> Shall we close the EasyHack
> <https://bugs.documentfoundation.org/show_bug.cgi?id=96099> "Reduce number
> of typedefs used for trivial container types" for good now?

Yes.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Close EasyHack tdf#96099 "Reduce number of typedefs used for trivial container types"?

[Stephan Bergmann]

Following good tradition of not discussing the usefulness of EasyHack 
bugs directly in bugzilla, lets do that here:


Shall we close the EasyHack 
<https://bugs.documentfoundation.org/show_bug.cgi?id=96099> "Reduce 
number of typedefs used for trivial container types" for good now?


While there are certainly the obviously silly, use-once cases like

  typedef std::vector IntVector;
  IntVector v = ...;

there are also cases where such a typedef introduces domain-specific 
vocabulary into a (larger) portion of the code (e.g., see removal of 
such typedefs in 
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=89e0663c55f7f1763536a345d6315c71ef26> 
"tdf#96099 fix trival typedefs, Path to std::vector" in 
configmgr and 
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=5437eb15ad3975b11c6eefe77dfd6687e0e73f81> 
"tdf#96099 Remove trivial std::map typedefs in [cd]*" removing the 
Dependencies typedef from codemaker/source/javamaker/javatype.cxx).  In 
such cases, there is always a tension between keeping the code simple 
(in the sense of easily understood by using well-chosen names) and 
keeping the code simple (by not introducing unnecessary abstractions), 
and finding the right balance there is likely not an easy hack.


(Tor's initial description, 
<https://bugs.documentfoundation.org/show_bug.cgi?id=96099#c0>, already 
warned about that, but it's not clear to me that that warning has always 
been taken into account adequately.)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: More Shapes for LibreOffice (Easyhack)

[Muhammad Ahsan Faheem]

Thanks a lot respected Katrina Behrens. I was really disappointed by the
people who said 'You should be a qualified developer'. I was very motivated
to work with GSoC and tried my best to understand code. I just wanted
someone to tell where to begin with. Few people have tried there best to
demotivate me.

Thanks again for encouraging me.
Regards.
On 27-Mar-2018 6:42 PM, "Katarina Behrens" <katarina.behr...@cib.de> wrote:

> > As a GSoC
> > student you are expected to be a smart developer, able to dig into the
> > code, and to find code pointers yourself. That might be time-consuming
> and
> > one question makes sense, perhaps someone knows the answer off the top of
> > the head. But that happens not too often.
>
> Stating perhaps the obvious, the word "student" is derived from the verb
> "to
> study" ( = "to learn") i.e. it is someone who is learning things, not
> someone
> who is expected to know them already. Fortunately, most of GSoC mentors are
> aware of that.
>
> Moreover, "smart developer" is usually someone with multiple years of
> coding
> experience (and sometimes even that ain't enough *smirk*). In my particular
> case, this is some 12+ years of experience and I still need to ask other
> people for code pointers sometimes. Nobody expects me to always find them
> myself, quite the contrary.
>
> Asking for help (in contrast to banging my head against the wall ad nauseam
> 'cause I don't understand the code) is somehow smarter use of resources I
> have. Again, most of GSoC mentors know this and encourage students to reach
> out when they're stuck.
>
> > Last but not least I'm neither a
> > developer nor your mentor. And while I really appreciate any work on bug
> > 87892, solving a design only easyhack is not a proof of your coding
> skills
> > to me.
>
> IIRC, adding new shapes AND new categories to gallery in tdf#87892 requires
> some non-trivial knowledge of build system and it is neither "design-only"
> nor
> "easy hack" ... oh wait, you already mentioned you were not a developer ;-)
>
> --
> Katarina Behrens
>
> Senior Software-Entwicklerin FLOSS
> –––
> CIB software GmbH
> Geschäftsstelle Hamburg
> Flachsland 10
> 22083 Hamburg
> –––
> T +49 (40) / 28 48 42 -235
> F +49 (40) / 28 48 42 -100
>
> katarina.behr...@cib.de
> www.cib.de
> –––
> Sitz: München
> Registergericht München, HRB 123286
> Geschäftsführer: Dipl.-Ing. Ulrich Brandner
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: More Shapes for LibreOffice (Easyhack)

[Katarina Behrens]

> As a GSoC
> student you are expected to be a smart developer, able to dig into the
> code, and to find code pointers yourself. That might be time-consuming and
> one question makes sense, perhaps someone knows the answer off the top of
> the head. But that happens not too often. 

Stating perhaps the obvious, the word "student" is derived from the verb "to 
study" ( = "to learn") i.e. it is someone who is learning things, not someone 
who is expected to know them already. Fortunately, most of GSoC mentors are 
aware of that.

Moreover, "smart developer" is usually someone with multiple years of coding 
experience (and sometimes even that ain't enough *smirk*). In my particular 
case, this is some 12+ years of experience and I still need to ask other 
people for code pointers sometimes. Nobody expects me to always find them 
myself, quite the contrary. 

Asking for help (in contrast to banging my head against the wall ad nauseam 
'cause I don't understand the code) is somehow smarter use of resources I 
have. Again, most of GSoC mentors know this and encourage students to reach 
out when they're stuck.

> Last but not least I'm neither a
> developer nor your mentor. And while I really appreciate any work on bug
> 87892, solving a design only easyhack is not a proof of your coding skills
> to me.

IIRC, adding new shapes AND new categories to gallery in tdf#87892 requires 
some non-trivial knowledge of build system and it is neither "design-only" nor 
"easy hack" ... oh wait, you already mentioned you were not a developer ;-)

-- 
Katarina Behrens

Senior Software-Entwicklerin FLOSS
–––
CIB software GmbH
Geschäftsstelle Hamburg
Flachsland 10
22083 Hamburg
–––
T +49 (40) / 28 48 42 -235
F +49 (40) / 28 48 42 -100

katarina.behr...@cib.de
www.cib.de
–––
Sitz: München
Registergericht München, HRB 123286
Geschäftsführer: Dipl.-Ing. Ulrich Brandner


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: More Shapes for LibreOffice (Easyhack)

[Muhammad Ahsan Faheem]

Thanks for reply. I thought mail wasn't sent before, so I sent again.
On 27-Mar-2018 12:12 PM, "Heiko Tietze" <tietze.he...@gmail.com> wrote:

> Hi Muhammad,
>
> asking every day on the mailing list and BZ is not helpful. As a GSoC
> student you are expected to be a smart developer, able to dig into the
> code, and to find code pointers yourself. That might be time-consuming and
> one question makes sense, perhaps someone knows the answer off the top of
> the head. But that happens not too often.
> Personally I'm sad that you don't benefit from the latest blog posts about
> easy hacking [1]. Even when it's labeled terminology you could have taken
> the idea into a search for "School & University", for example, that reveals
> two references with a starting point to the right directory [2].
> Last but not least I'm neither a developer nor your mentor. And while I
> really appreciate any work on bug 87892, solving a design only easyhack is
> not a proof of your coding skills to me.
>
> Sorry if that sounds too harsh, you are still welcome.
> Heiko
>
> [1] https://design.blog.documentfoundation.org/2018/
> 02/28/easyhacking-all-about-terminology/
> [2] https://opengrok.libreoffice.org/xref/core/extras/source/gallery/
>
> On 26.03.2018 16:51, Muhammad Ahsan Faheem wrote:
> > Hi LibreOffice Community,
> >
> > I have applied for GSoC to work on LibreOffice development. Right now, I
> want to work on an easyhack /"Bug 87892 - More shapes for LibreOffice draw
> are needed" . /Hopefully, I will also understand the code by working on
> this easyhack. I have built libreOffice successfully and just want someone
> to tell me from where to start? I mean which part of code is responsible to
> fix this easyhack?
> >
> > Thanks,
> > Ahsan
> >
> >
> >
> >
> > ___
> > LibreOffice mailing list
> > LibreOffice@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/libreoffice
> >
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: More Shapes for LibreOffice (Easyhack)

[Heiko Tietze]

Hi Muhammad,

asking every day on the mailing list and BZ is not helpful. As a GSoC student 
you are expected to be a smart developer, able to dig into the code, and to 
find code pointers yourself. That might be time-consuming and one question 
makes sense, perhaps someone knows the answer off the top of the head. But that 
happens not too often.
Personally I'm sad that you don't benefit from the latest blog posts about easy 
hacking [1]. Even when it's labeled terminology you could have taken the idea 
into a search for "School & University", for example, that reveals two 
references with a starting point to the right directory [2].
Last but not least I'm neither a developer nor your mentor. And while I really 
appreciate any work on bug 87892, solving a design only easyhack is not a proof 
of your coding skills to me.

Sorry if that sounds too harsh, you are still welcome.
Heiko

[1] 
https://design.blog.documentfoundation.org/2018/02/28/easyhacking-all-about-terminology/
[2] https://opengrok.libreoffice.org/xref/core/extras/source/gallery/

On 26.03.2018 16:51, Muhammad Ahsan Faheem wrote:
> Hi LibreOffice Community,
> 
> I have applied for GSoC to work on LibreOffice development. Right now, I want 
> to work on an easyhack /"Bug 87892 - More shapes for LibreOffice draw are 
> needed" . /Hopefully, I will also understand the code by working on this 
> easyhack. I have built libreOffice successfully and just want someone to tell 
> me from where to start? I mean which part of code is responsible to fix this 
> easyhack?
> 
> Thanks,
> Ahsan
> 
> 
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
> 



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

More Shapes for LibreOffice (Easyhack)

[Muhammad Ahsan Faheem]

Hi LibreOffice Community,

I have applied for GSoC to work on LibreOffice development. Right now, I
want to work on an easyhack *"Bug 87892 - More shapes for LibreOffice draw
are needed" . *Hopefully, I will also understand the code by working on
this easyhack. I have built libreOffice successfully and just want someone
to tell me from where to start? I mean which part of code is responsible to
fix this easyhack?

Thanks,
Ahsan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Tor Lillqvist <t...@iki.fi> changed:

   What|Removed |Added

   Keywords|difficultyBeginner, |
   |easyHack, skillCpp, |
   |topicCleanup|

--- Comment #25 from Tor Lillqvist <t...@iki.fi> ---
Lots of this has already been handled by Mike Kaganski (who was not aware there
was an Easy Hack for it). What remains is not an Easy Hack any more, he says,
so removing those keywords.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #24 from Tor Lillqvist  ---
This is certainly not a "large scale cosmetic change".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #23 from jan iversen <j...@documentfoundation.org> ---
Please be aware, that this easyhack is considered an important but large scale
cosmetic change as described in
https://wiki.documentfoundation.org/Development/LargeScaleChanges

It was in decided by the ESC to close this kind of easyhacks, and send them
directly as mail, to new contributors.
https://lists.freedesktop.org/archives/libreoffice/2016-August/074920.html

Please do not submit patches with many files !!

This particular easyhack is kept open as an exception to the rule

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #22 from jan iversen  ---
Still a lot of .mk files to correct

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #21 from Commit Notification 
<libreoffice-comm...@lists.freedesktop.org> ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a17c118f312699ab26147148cd2e7844c41a777

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #20 from Commit Notification 
<libreoffice-comm...@lists.freedesktop.org> ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a50cdeb70ec19369f42ed08abfd4a5301d05edb5

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 53878] FILESAVE, EasyHack: Size of XML files can been reduced by using default namespaces on certain elements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53878

--- Comment #6 from Nicholas Shanks  ---
Sorry for the delay on this one — I left the relevant company, no longer need
to use/output OpenOffice files, and have been ignoring related emails. If you
want to send me any current XML file I'll perform some manual optimisation of
the XML and send it back. It's nothing that couldn't be done by any XML-savvy
coder though.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Michael Stahl  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

--- Comment #19 from Michael Stahl  ---
there are still lots of TCHARs being used, see "git grep TCHAR"

most of them are in "workben" and "test" directories that
are not actually built currently but there are a bunch in
desktop, dtrans, embedserv, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

jan iversen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #18 from jan iversen  ---
Seems solved

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #17 from Commit Notification 
<libreoffice-comm...@lists.freedesktop.org> ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=29e0b587df4e509558c22fa478992b07486828d1

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #16 from Commit Notification 
<libreoffice-comm...@lists.freedesktop.org> ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7fe92c766adf97bdeb4d844ffe6d0650a964572e

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0|target:5.2.0 target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #15 from Stuart Swales <stuart.swales.croftnu...@gmail.com> ---
Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

setup_native/source/win32/customactions/shellextensions in MSI Installer
compiled as UNICODE

Functions suffixed with A/W (ANSI/Wide) as needed for clarity

Please find patch at:

https://gerrit.libreoffice.org/#/c/25556/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #14 from Commit Notification 
<libreoffice-comm...@lists.freedesktop.org> ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=68502698d29e577a7a451f1a796677128901cfe3

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #13 from Commit Notification 
<libreoffice-comm...@lists.freedesktop.org> ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=074bd09ee6f3113792b60ee721aabb731c5d7ace

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #12 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=163dcad72e03e214d842e74d1f71ed025cbdd870

Work towards tdf#72606

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #11 from Stuart Swales  ---
More work towards _tstring/TCHAR elimination

Used explicit A/W suffixes on functions for clarity and consistency in sellang
module of MSI Installer

Please find this patch at https://gerrit.libreoffice.org/25167

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #10 from Stuart Swales  ---
More work towards _tstring/TCHAR elimination

Quickstarter code in MSI Installer compiled UNICODE

Used explicit A/W suffixes on functions for clarity

Please find this patch at https://gerrit.libreoffice.org/25153

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #9 from Commit Notification 
<libreoffice-comm...@lists.freedesktop.org> ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8a4dd6f45b12e7d44ad595bc0fadc37075061119

Work towards tdf#72606 EasyHack _tstring/TCHAR elimination

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #8 from Stuart Swales  ---
As a first step towards addressing this issue I have eliminated the TCHAR mess
from one of the modules used in the Windows MSI installer.

Built OK and the resulting installer worked correctly.

If this style is acceptable to progress in LibreOffice I will do so.

Please find patch at:

https://gerrit.libreoffice.org/#/c/24707/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

jan iversen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 Whiteboard|ToBeReviewed target:5.2.0   |target:5.2.0

--- Comment #15 from jan iversen  ---
Seems solved

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

Marian Scerbak  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |devel.marian.scerbak@gmail.
   |desktop.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

--- Comment #6 from Stephan Bergmann  ---
(In reply to Marian Scerbak from comment #5)
> Looks like abandoned bug. Maybe I can pick it up, as a first task here. Do
> you agree?

Yes.  Look if you find places that can be updated, and if yes, send a patch to
gerrit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

--- Comment #5 from Marian Scerbak  ---
Looks like abandoned bug. Maybe I can pick it up, as a first task here. Do you
agree?


(In reply to jan iversen from comment #4)
> (In reply to Pratishta from comment #3)
> > Has this bug been fixed or can I try to work on this?
> 
> I suggest you look yourself to see if there are more places, I suspect there
> are.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

--- Comment #14 from Commit Notification 
 ---
Aleksas Pantechovskis committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=080f355f11ee3422e9512815efd9f8d7eb896d32

tdf#65219 Fix temp files clean up in sd unit tests

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

--- Comment #4 from jan iversen  ---
(In reply to Pratishta from comment #3)
> Has this bug been fixed or can I try to work on this?

I suggest you look yourself to see if there are more places, I suspect there
are.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

--- Comment #3 from Pratishta  ---
Has this bug been fixed or can I try to work on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75280] [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

David Tardon  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed target:5.2.0   |target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75280] [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|ToBeReviewed target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75280] [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

--- Comment #19 from Commit Notification 
 ---
Jaskaran committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=45701913f642b17aabd67b52de9002cc79cf07ae

tdf#75280 Replace sal_uIntPtr to better types in /connectivity

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

Stephan Bergmann  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

--- Comment #3 from Commit Notification 
 ---
Chirag Manwani committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b38f58a3f959b5e36813f8c2d88bdb2baf03a1b9

tdf#97703 Removed empty setUp/tearDown methods

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

--- Comment #13 from Commit Notification 
 ---
Aleksas Pantechovskis committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=123b41c3870810d61fde5e17c74a352e3fd2a694

tdf#65219 Fix temp files clean up in sw unit tests

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

--- Comment #12 from Aleksas Pantechovskis  ---
I fixed temp file leaks in sd tests, submitted patch to gerrit.

There are two more leaks left in sd/qa/unit/mist-tests.cxx, but so I have not
figured out how to fix it yet.
As far as I identified the file is created after executing this line:
  xSSController.GetClipboard().DoPaste();

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|ToBeReviewed target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

--- Comment #2 from Commit Notification 
 ---
Jaskaran committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=00ecf7899a97d09ecf4a8b6d81b10e1f66903f5a

tdf#97499 Remove some Default arguments in unordered container

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

--- Comment #11 from Commit Notification 
 ---
Aleksas Pantechovskis committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=14c14094e8587d28eb9cd2a3b5c0c57b355635b5

tdf#65219 Fix temp files clean up in sc unit tests

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|ToBeReviewed target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

--- Comment #2 from Commit Notification 
 ---
Chirag Manwani committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cc84aaf70ac56092b32d1d329143eca0550dce12

tdf#97703 removed empty setUp/tearDown methods

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

--- Comment #10 from Aleksas Pantechovskis  ---
I fixed temp file leaks in sc tests, now make sc.check does not leave any temp
files. Submitted patch to gerrit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

--- Comment #9 from Aleksas Pantechovskis  ---
I fixed two temp file leaks in sw tests, submitted patch to gerrit.

There is one more leak left in sw/qa/extras/uiwriter.cxx
SwUiWriterTest::testEmbeddedDataSource but I do not know how to fix it.
I found that the leaked file is created after executing these lines: 

uno::Reference
xDataSource(xDatabaseContext->getByName("calc-data-source"), uno::UNO_QUERY);
CPPUNIT_ASSERT(xDataSource.is());
uno::Reference
xConnection(xDataSource->getConnection("", ""), uno::UNO_QUERY);

but I do not see anything related to disposal in XComponentContext or
XDataSource.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|ToBeReviewed target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

--- Comment #1 from Commit Notification 
 ---
Jaskaran committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9fe9f487a25a15558b77a8afc359e844922f1e83

tdf#97703 Removed a few redundant calls to setUp and tearDown

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

jan iversen  changed:

   What|Removed |Added

 CC|libreoffice@lists.freedeskt |j...@documentfoundation.org
   |op.org  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[Chris Sherlock]

What does ToBeReviewed indicate? Like, reviewed by whom and for what reason?

Just curious...

Chris

> On 12 Feb 2016, at 12:46 AM, bugzilla-dae...@bugs.documentfoundation.org 
> wrote:
> 
> jan iversen  changed bug 97499 
>  
> What  Removed Added
> WhiteboardToBeReviewed
> 
> You are receiving this mail because:
> You are on the CC list for the bug.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> On 12 Feb 2016, at 07:56, Chris Sherlock  wrote:
> 
> What does ToBeReviewed indicate? Like, reviewed by whom and for what reason?
> 
ToBeReviewed was set on all easyHacks, because I have been tasked with walking 
through all of them and
- verify they are still valid
- compress those with many comments to a single comment (remove all unneeded 
info)
- verify there is a mentor (typically the reporter)

We have 308 issues, so ToBeReviewed was introduced to make it easier for others 
to help. Due to a funny behaivour of BZ it had some less nice side effects, 
like removing old whiteboard text (kept in history).

You will see the ToBeReviewed go away over the next period of time (after dev 
list is no longer CC on the hacks.)

rgds
jan i.

> Just curious...
> 
> Chris
> 
>> On 12 Feb 2016, at 12:46 AM, bugzilla-dae...@bugs.documentfoundation.org 
>> wrote:
>> 
>> jan iversen changed bug 97499 
>> What Removed Added
>> Whiteboard   ToBeReviewed
>> 
>> You are receiving this mail because:
>> You are on the CC list for the bug.
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/libreoffice
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[Chris Sherlock]

> On 12 Feb 2016, at 6:14 PM, jan iversen  wrote:
> 
> Sent from my iPad, please excuse any misspellings 

Hey, I do the same :-) And your iPad is much nicer than mine!

> On 12 Feb 2016, at 07:56, Chris Sherlock  > wrote:
> 
>> What does ToBeReviewed indicate? Like, reviewed by whom and for what reason?
>> 
> ToBeReviewed was set on all easyHacks, because I have been tasked with 
> walking through all of them and
> - verify they are still valid
> - compress those with many comments to a single comment (remove all unneeded 
> info)
> - verify there is a mentor (typically the reporter)
> 
> We have 308 issues, so ToBeReviewed was introduced to make it easier for 
> others to help. Due to a funny behaivour of BZ it had some less nice side 
> effects, like removing old whiteboard text (kept in history).
> 
> You will see the ToBeReviewed go away over the next period of time (after dev 
> list is no longer CC on the hacks.)
> 
> rgds
> jan i.

Thanks Jan :-)

Chris___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 75280] [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 65219] [EasyHack] unit tests fail to clean up temp files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65219

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 75280] [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97703] New: EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

Bug ID: 97703
   Summary: EasyHack: Remove empty setUp/tearDown overrides from
CppUnit test code
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-b...@lists.freedesktop.org
  Reporter: sberg...@redhat.com
CC: libreoffice@lists.freedesktop.org

Some of our C++ test code using CppUnit needlessly contains empty overrides of
CppUnit::TextFixture::setUp and/or CppUnit::TextFixture::tearDown (e.g.,
<https://cgit.freedesktop.org/libreoffice/core/tree/sal/qa/rtl/random/rtl_random.cxx?id=0c517ab1bf7f17b9d070f0a79fc2e6d637309d11#n38>).
 These can just be removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

Stephan Bergmann  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97703] EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

Stephan Bergmann  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97703] New: EasyHack: Remove empty setUp/tearDown overrides from CppUnit test code

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97703

Bug ID: 97703
   Summary: EasyHack: Remove empty setUp/tearDown overrides from
CppUnit test code
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sberg...@redhat.com
CC: libreoff...@lists.freedesktop.org

Some of our C++ test code using CppUnit needlessly contains empty overrides of
CppUnit::TextFixture::setUp and/or CppUnit::TextFixture::tearDown (e.g.,
<https://cgit.freedesktop.org/libreoffice/core/tree/sal/qa/rtl/random/rtl_random.cxx?id=0c517ab1bf7f17b9d070f0a79fc2e6d637309d11#n38>).
 These can just be removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Easyhack page.

[jan iversen]

Hi.

Sorry for the BZ noise, but I have been updating/splitting

https://wiki.documentfoundation.org/Development/Easy_Hacks/by_Required_Skill

Also added some of the missing skills.

Comments are welcome.

have a nice weekend.
rgds
jan i.


Sent from my iPad, please excuse any misspellings ___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 45678] EasyHack: kill hwpfilter/source/list.hxx with fire

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45678

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||difficultyBeginner

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45678] EasyHack: kill hwpfilter/source/list.hxx with fire

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45678

Björn Michaelsen <bjoern.michael...@canonical.com> changed:

   What|Removed |Added

   Keywords|difficultyEasy  |

--- Comment #6 from Björn Michaelsen <bjoern.michael...@canonical.com> ---
difficultyEasy -> difficultyBeginner. The former never really existed and only
makes the EasyHack not appear on the wiki.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97499] New: EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

Bug ID: 97499
   Summary: EasyHack: Clean up default arguments in uses of C++
unordered containers
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sberg...@redhat.com
CC: libreoff...@lists.freedesktop.org

The standard C++ unordered containers (like std::unordered_map) have additional
template parameters Hash and Pred that default to std::hash and
std::equal_to, respectively.

So these can be removed where they are redundantly specified in the code base,
as in

> --- a/include/comphelper/numberedcollection.hxx
> +++ b/include/comphelper/numberedcollection.hxx
> @@ -61,9 +61,7 @@ class COMPHELPER_DLLPUBLIC NumberedCollection : private 
> ::cppu::BaseMutex
>  
>  typedef std::unordered_map<
>  long,
> -TNumberedItem,
> -::std::hash,
> -::std::equal_to< long > > TNumberedItemHash;
> +TNumberedItem > TNumberedItemHash;
>  
>  typedef ::std::vector< long > TDeadItemList;
>

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97499] New: EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

Bug ID: 97499
   Summary: EasyHack: Clean up default arguments in uses of C++
unordered containers
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-b...@lists.freedesktop.org
  Reporter: sberg...@redhat.com
CC: libreoffice@lists.freedesktop.org

The standard C++ unordered containers (like std::unordered_map) have additional
template parameters Hash and Pred that default to std::hash and
std::equal_to, respectively.

So these can be removed where they are redundantly specified in the code base,
as in

> --- a/include/comphelper/numberedcollection.hxx
> +++ b/include/comphelper/numberedcollection.hxx
> @@ -61,9 +61,7 @@ class COMPHELPER_DLLPUBLIC NumberedCollection : private 
> ::cppu::BaseMutex
>  
>  typedef std::unordered_map<
>  long,
> -TNumberedItem,
> -::std::hash,
> -::std::equal_to< long > > TNumberedItemHash;
> +TNumberedItem > TNumberedItemHash;
>  
>  typedef ::std::vector< long > TDeadItemList;
>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

Stephan Bergmann <sberg...@redhat.com> changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   |    |easyHack, skillCpp,
   ||topicCleanup
 Whiteboard|easyHack difficultyBeginner |
   |skillCpp topicCleanup   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

Stephan Bergmann <sberg...@redhat.com> changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   |    |easyHack, skillCpp,
   ||topicCleanup
 Whiteboard|easyHack difficultyBeginner |
   |skillCpp topicCleanup   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

Stephan Bergmann <sberg...@redhat.com> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Whiteboard|    |easyHack difficultyBeginner
   ||skillCpp topicCleanup

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97499] EasyHack: Clean up default arguments in uses of C++ unordered containers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97499

Stephan Bergmann <sberg...@redhat.com> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Whiteboard|    |easyHack difficultyBeginner
   ||skillCpp topicCleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39640] [EasyHack] Simplify the download of Windows dependencies

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39640

Björn Michaelsen <bjoern.michael...@canonical.com> changed:

   What|Removed |Added

   Keywords|skillWindows|

--- Comment #3 from Björn Michaelsen <bjoern.michael...@canonical.com> ---
removing skillWindows keyword. There is no such thing at
https://wiki.documentfoundation.org/Development/Easy_Hacks/lists/by_Required_Skill
and having a "skill*" keyword makes the easyHack not even appear on that page
even in "uncategorized".

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38833] [EasyHack] get rid of useless Win9x and NT4 support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38833

Björn Michaelsen <bjoern.michael...@canonical.com> changed:

   What|Removed |Added

   Keywords|skillWindows|

--- Comment #4 from Björn Michaelsen <bjoern.michael...@canonical.com> ---
removing skillWindows keyword. There is no such thing at
https://wiki.documentfoundation.org/Development/Easy_Hacks/lists/by_Required_Skill
and having a "skill*" keyword makes the easyHack not even appear on that page
even in "uncategorized".

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75280] [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

Robinson Tryon (qubit) <qu...@runcibility.com> changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   |    |easyHack, skillCpp,
   ||topicCleanup

--- Comment #17 from Robinson Tryon (qubit) <qu...@runcibility.com> ---
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp,
topicCleanup)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Robinson Tryon (qubit) <qu...@runcibility.com> changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   |    |easyHack, skillCpp,
   ||topicCleanup

--- Comment #6 from Robinson Tryon (qubit) <qu...@runcibility.com> ---
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp,
topicCleanup)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 75280] [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

Robinson Tryon (qubit) <qu...@runcibility.com> changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   |    |easyHack, skillCpp,
   ||topicCleanup

--- Comment #17 from Robinson Tryon (qubit) <qu...@runcibility.com> ---
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp,
topicCleanup)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Robinson Tryon (qubit) <qu...@runcibility.com> changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   |    |easyHack, skillCpp,
   ||topicCleanup

--- Comment #6 from Robinson Tryon (qubit) <qu...@runcibility.com> ---
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp,
topicCleanup)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Robinson Tryon (qubit) <qu...@runcibility.com> changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |
   |SkillCpp TopicCleanup   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

Robinson Tryon (qubit) <qu...@runcibility.com> changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |
   |SkillCpp TopicCleanup   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 75280] [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

Robinson Tryon (qubit) <qu...@runcibility.com> changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |
   |SkillCpp TopicCleanup   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 75280] [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75280

Robinson Tryon (qubit) <qu...@runcibility.com> changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |
   |SkillCpp TopicCleanup   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #4 from Michael Stahl  ---
maybe it would be better to move directly to removing the #ifdef UNICODE
everywhere, e.g. look at this nonsense all over
setup_native/source/win32/customactions/shellextensions/

#ifdef UNICODE
#define _UNICODE
#define _tstringwstring
#else
#define _tstringstring
#endif

that requires other headers to be included in a particular order, etc.

just call *W functions and use std::wstring.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 72606] [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72606

--- Comment #5 from Tor Lillqvist  ---
Also, related to this, we should not use any of the  madness anywhere.
No _TCHAR, TEXT(), _tcs*(). Just use wchar_t and the wcs*() functions directly
if that is what is meant. (Or, char and str*() if not.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice