Re: German code comments
Hi all, we could use the list as signpost. It is very anoying to search for german comments manually. But I disagree with editing of text on github. What if the source changes? Without the sourcecode it is hard to translate the text correctly sometimes. Cheese/Käse Matthias Am 06.08.2015 um 18:34 schrieb Philipp Weissenbacher: Hi Johannes, all, Sorry, but this is not going to work properly and will presumably burden the reviewers (mostly German-speaking core developers) a lot. See, even the example on the GitHub page is inaccurate, due to missing context: sw/source/filter/ww8/ww8struc.hxx:534: hiermit wird weitergearbeitet (entspricht weitestgehend dem Ver8-Format - with this we continue (largely matches the Ver8-format That should be With this we continue (largely corresponds to the version 8 format). My experience tells me, that the best translations get as much context from existing comments and surrounding code as possible. I just can't see that happening out of context in a large text file. I really like your enthusiasm, so please read up on how to contribute comment translations like code via Gerrit (https://wiki.documentfoundation.org/Development/gerrit). Cheers/Grüße, Philipp On 6 August 2015 at 14:41, Bjoern Michaelsen bjoern.michael...@canonical.com mailto:bjoern.michael...@canonical.com wrote: Hi, On Thu, Aug 06, 2015 at 07:36:16AM -0500, Norbert Thiebaud wrote: As long as the result is re-injected back in core.git via proper gerrit patch, that can work... assuming the last 5.000 of 50.000 german comments are not weird, strange leftovers that require lots and lots of context from the surrounding code to be sensibly translated at all. Lets see, maybe this works, but I am somewhat sceptical. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org mailto:LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: German code comments
Hi, there is no better/other way then to go through the code and translate. Also the last pieces can be done this way. Luc Op vr 7 aug. 2015 14:10 schreef Papamatti matti...@mailbox.org: Hi all, we could use the list as signpost. It is very anoying to search for german comments manually. But I disagree with editing of text on github. What if the source changes? Without the sourcecode it is hard to translate the text correctly sometimes. Cheese/Käse Matthias Am 06.08.2015 um 18:34 schrieb Philipp Weissenbacher: Hi Johannes, all, Sorry, but this is not going to work properly and will presumably burden the reviewers (mostly German-speaking core developers) a lot. See, even the example on the GitHub page is inaccurate, due to missing context: sw/source/filter/ww8/ww8struc.hxx:534: hiermit wird weitergearbeitet (entspricht weitestgehend dem Ver8-Format - with this we continue (largely matches the Ver8-format That should be With this we continue (largely corresponds to the version 8 format). My experience tells me, that the best translations get as much context from existing comments and surrounding code as possible. I just can't see that happening out of context in a large text file. I really like your enthusiasm, so please read up on how to contribute comment translations like code via Gerrit (https://wiki.documentfoundation.org/Development/gerrit). Cheers/Grüße, Philipp On 6 August 2015 at 14:41, Bjoern Michaelsen bjoern.michael...@canonical.com mailto:bjoern.michael...@canonical.com wrote: Hi, On Thu, Aug 06, 2015 at 07:36:16AM -0500, Norbert Thiebaud wrote: As long as the result is re-injected back in core.git via proper gerrit patch, that can work... assuming the last 5.000 of 50.000 german comments are not weird, strange leftovers that require lots and lots of context from the surrounding code to be sensibly translated at all. Lets see, maybe this works, but I am somewhat sceptical. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org mailto:LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: German code comments
Hi Johannes, all, Sorry, but this is not going to work properly and will presumably burden the reviewers (mostly German-speaking core developers) a lot. See, even the example on the GitHub page is inaccurate, due to missing context: sw/source/filter/ww8/ww8struc.hxx:534: hiermit wird weitergearbeitet (entspricht weitestgehend dem Ver8-Format - with this we continue (largely matches the Ver8-format That should be With this we continue (largely corresponds to the version 8 format). My experience tells me, that the best translations get as much context from existing comments and surrounding code as possible. I just can't see that happening out of context in a large text file. I really like your enthusiasm, so please read up on how to contribute comment translations like code via Gerrit ( https://wiki.documentfoundation.org/Development/gerrit). Cheers/Grüße, Philipp On 6 August 2015 at 14:41, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: Hi, On Thu, Aug 06, 2015 at 07:36:16AM -0500, Norbert Thiebaud wrote: As long as the result is re-injected back in core.git via proper gerrit patch, that can work... assuming the last 5.000 of 50.000 german comments are not weird, strange leftovers that require lots and lots of context from the surrounding code to be sensibly translated at all. Lets see, maybe this works, but I am somewhat sceptical. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: German code comments
I copied them here and started translating (my translations are at the bottom). https://github.com/JohannesBuchner/libreoffice-translate Maybe some of you speak German and can help out by forking and pull requests. Thank you very much for your work, but please, this is the wrong approach. Comment translation should use the same workflow as other changes to the source code, i.e. using git commits to your local repository clone and submitted to gerrit.libreoffice.org. (Read more in our wiki.) Github is not involved at all. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: German code comments
On Thu, Aug 6, 2015 at 1:13 AM, Tor Lillqvist t...@iki.fi wrote: I copied them here and started translating (my translations are at the bottom). https://github.com/JohannesBuchner/libreoffice-translate Maybe some of you speak German and can help out by forking and pull requests. Thank you very much for your work, but please, this is the wrong approach. Comment translation should use the same workflow as other changes to the source code, i.e. using git commits to your local repository clone and submitted to gerrit.libreoffice.org. (Read more in our wiki.) Github is not involved at all. That was my first reaction too.. but what Joannes put in github is just a single file with all the german comment extracted there. I suppose the idea is to allow for people to just concentrate on 'translating' by cloning a couple ok K repo rather than the whole core.git As long as the result is re-injected back in core.git via proper gerrit patch, that can work... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: German code comments
Hi, On Thu, Aug 06, 2015 at 07:36:16AM -0500, Norbert Thiebaud wrote: As long as the result is re-injected back in core.git via proper gerrit patch, that can work... assuming the last 5.000 of 50.000 german comments are not weird, strange leftovers that require lots and lots of context from the surrounding code to be sensibly translated at all. Lets see, maybe this works, but I am somewhat sceptical. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
German code comments
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, Michael mentioned[1] that 5000 German comments in the source code still require translation into German. I copied them here and started translating (my translations are at the bottom). https://github.com/JohannesBuchner/libreoffice-translate Maybe some of you speak German and can help out by forking and pull requests. If you can contribute 50 translations, that is already helpful . Cheers, Johannes [1] https://people.gnome.org/~michael/blog/2015-08-05-under-the-hood-5-0.htm l -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEYEARECAAYFAlXCYIgACgkQ7X1+MfqVcr2sPwCcDd+sh1D0v1DqnN5/HbDAlmRG RLAAnRCPP55EZKrTCZzjD4v1tERZSqxg =ooNB -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: German code comments
Hi Johannes, Great initiative. By doing so you remove comment out of context (= code), which in my experience can hamper translation. Maybe we can splitt work still on file-basis? Regards, Luc Op wo 5 aug. 2015 21:13 schreef Johannes Buchner buchner.johan...@gmx.at: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, Michael mentioned[1] that 5000 German comments in the source code still require translation into German. I copied them here and started translating (my translations are at the bottom). https://github.com/JohannesBuchner/libreoffice-translate Maybe some of you speak German and can help out by forking and pull requests. If you can contribute 50 translations, that is already helpful . Cheers, Johannes [1] https://people.gnome.org/~michael/blog/2015-08-05-under-the-hood-5-0.htm l -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEYEARECAAYFAlXCYIgACgkQ7X1+MfqVcr2sPwCcDd+sh1D0v1DqnN5/HbDAlmRG RLAAnRCPP55EZKrTCZzjD4v1tERZSqxg =ooNB -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 4/4] Translate german code comments
Hi Martin, On Thu, 2011-04-21 at 22:00 +0200, Martin Kepplinger wrote: Translate german code comments to english! Nice work ! - it's a real pleasure to read the resulting code. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 4/4] Translate german code comments
Am 21.04.2011 22:13, schrieb Júlio Hoffimann: Nice patches Martin! :-) Next time you could attach the files, instead of put them in the mail body. So, the developers just download and apply your changes. ;-) Martin has already pushed them. He just posted them for reviewing. Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 4/4] Translate german code comments
Hm, I should have read the whole thread first...sorry for the noise. Christina Am 22.04.2011 09:27, schrieb Chr. Rossmanith: Am 21.04.2011 22:13, schrieb Júlio Hoffimann: Nice patches Martin! :-) Next time you could attach the files, instead of put them in the mail body. So, the developers just download and apply your changes. ;-) Martin has already pushed them. He just posted them for reviewing. Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 4/4] Translate german code comments
Hi Martin, Sorry for my bad interpretation. :-) Regards, Júlio. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH 1/4] Translate german code comments
Translate some german code comments in writer/sw/source/ui/inc to english.
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
---
sw/source/ui/inc/actctrl.hxx |6 +++---
sw/source/ui/inc/app.hrc | 10 +-
sw/source/ui/inc/autoedit.hxx |2 +-
sw/source/ui/inc/basesh.hxx |6 +++---
sw/source/ui/inc/bmpwin.hxx |2 +-
sw/source/ui/inc/caption.hxx |2 +-
sw/source/ui/inc/cfgitems.hxx | 10 +-
sw/source/ui/inc/changedb.hxx |2 +-
8 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/sw/source/ui/inc/actctrl.hxx b/sw/source/ui/inc/actctrl.hxx
index a778a2f..259c887 100644
--- a/sw/source/ui/inc/actctrl.hxx
+++ b/sw/source/ui/inc/actctrl.hxx
@@ -32,7 +32,7 @@
#include swdllapi.h
/*
-Beschreibung: numerische Eingabe
+Description: numerical input
*/
class SW_DLLPUBLIC NumEditAction: public NumericField
{
@@ -51,7 +51,7 @@ public:
/* --
- * Edit, dass keine Spaces akzeptiert
+ * Edit that doesn't accept spaces
* --*/
class SW_DLLPUBLIC NoSpaceEdit : public Edit
{
@@ -68,7 +68,7 @@ public:
};
/* --
- * Kein Space und kein Punkt
+ * No space and no full stop
* --*/
class TableNameEdit : public NoSpaceEdit
{
diff --git a/sw/source/ui/inc/app.hrc b/sw/source/ui/inc/app.hrc
index 9d017f5..f74b659 100644
--- a/sw/source/ui/inc/app.hrc
+++ b/sw/source/ui/inc/app.hrc
@@ -33,7 +33,7 @@
// Document-Icon
#define RC_DOC_ICON(RC_APP_BEGIN + 2)
-//Soll das Clipboard fuer andere Applikationen...
+// Should the clipboard for other applications...
#define MSG_CLPBRD_CLEAR (RC_APP_BEGIN + 3)
#define STR_CANTCREATE (RC_APP_BEGIN + 4)
@@ -43,7 +43,7 @@
#define MSG_ERROR_SEND_MAIL( RC_APP_BEGIN + 6)
#define MSG_SAVE_HTML_QUERY ( RC_APP_BEGIN + 7)
-//Fuer das Interface, weil der RID_APP_BEGIN jetzt Desktop ist.
+// For the interface because the RID_APP_BEGIN is now Desktop.
#define RID_SW_NAME( RC_APP_BEGIN + 8)
#define MSG_SAVEAS_HTML_QUERY ( RC_APP_BEGIN + 9)
@@ -53,10 +53,10 @@
#define STR_PRINT_MERGE_MACRO (RC_APP_BEGIN + 15)
#define STR_PAGE_COUNT_MACRO (RC_APP_BEGIN + 16)
-// Bitmap fuer die NumerierungsVorlagen im Organizer
+// Bitmap for the numbering style in organizer
#define BMP_STYLES_FAMILY_NUM (RC_APP_BEGIN + 17)
-// Strings fuer Bereiche in der Konfiguration
+// Strings for regions in the configuration
#define STR_GRP_FILE (RC_APP_BEGIN + 56)
#define STR_GRP_EDIT (RC_APP_BEGIN + 57)
#define STR_GRP_TRAVELLING (RC_APP_BEGIN + 58)
@@ -102,7 +102,7 @@
#define STR_FDLG_TEMPLATE_NAME (RC_APP_BEGIN + 2)
-// Ids fuer die einzelnen PopUpMenues
+// Ids for all the PopUpMenues
#define MN_FORMAT_STYLE (RC_APP_BEGIN + 17)
#define MN_FORMAT_ALGN (RC_APP_BEGIN + 18)
#define MN_FORMAT_LINESPACE (RC_APP_BEGIN + 19)
diff --git a/sw/source/ui/inc/autoedit.hxx b/sw/source/ui/inc/autoedit.hxx
index c3221a7..5f34933 100644
--- a/sw/source/ui/inc/autoedit.hxx
+++ b/sw/source/ui/inc/autoedit.hxx
@@ -40,7 +40,7 @@ protected:
virtual void KeyInput( const KeyEvent rEvent );
};
-// Implementieriung im autocorr.cxx
+// Implementation in autocorr.cxx
diff --git a/sw/source/ui/inc/basesh.hxx b/sw/source/ui/inc/basesh.hxx
index 76d32e6..02336d1 100644
--- a/sw/source/ui/inc/basesh.hxx
+++ b/sw/source/ui/inc/basesh.hxx
@@ -52,14 +52,14 @@ class SwBaseShell: public SfxShell
{
SwView rView;
-// DragModus
+// DragMode
static FlyMode eFrameMode;
// Bug 75078 - if in GetState the asynch call of GetGraphic returns
// synch, the set the state directly into the
itemset
SfxItemSet*pGetStateSet;
-//Update-Timer fuer Graphic
+// Update-Timer for graphic
SvUShortsSort aGrfUpdateSlots;
DECL_LINK( GraphicArrivedHdl, SwCrsrShell* );
@@ -118,7 +118,7 @@ public:
void ExecField(SfxRequest rReq);
-static voidSetFrmMode( FlyMode eMode, SwWrtShell *pShell ); //Mit
Update!
+static voidSetFrmMode( FlyMode eMode, SwWrtShell *pShell ); // with
update!
static void _SetFrmMode( FlyMode eMode ) { eFrameMode = eMode; }
static FlyMode GetFrmMode() { return eFrameMode; }
diff --git a/sw/source/ui/inc/bmpwin.hxx b/sw/source/ui/inc/bmpwin.hxx
index baefb78
[Libreoffice] [PATCH 4/4] Translate german code comments
Translate german code comments to english!
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
---
sw/source/ui/inc/srcview.hxx|2 +-
sw/source/ui/inc/swcont.hxx | 12 ++--
sw/source/ui/inc/swdtflvr.hxx |4 +-
sw/source/ui/inc/swlbox.hxx |4 +-
sw/source/ui/inc/swuiidxmrk.hxx |2 +-
sw/source/ui/inc/tabledlg.hxx |2 +-
sw/source/ui/inc/tmpdlg.hxx |2 +-
sw/source/ui/inc/toxmgr.hxx | 10 ++--
sw/source/ui/inc/uiitems.hxx|2 +-
sw/source/ui/inc/uinums.hxx |6 +-
sw/source/ui/inc/uitool.hxx | 16 ++--
sw/source/ui/inc/utlui.hrc |2 +-
sw/source/ui/inc/view.hxx | 77 ++--
sw/source/ui/inc/workctrl.hxx |6 +-
sw/source/ui/inc/wrap.hxx |2 +-
sw/source/ui/inc/wrtsh.hxx | 152 +++
16 files changed, 146 insertions(+), 155 deletions(-)
diff --git a/sw/source/ui/inc/srcview.hxx b/sw/source/ui/inc/srcview.hxx
index 336a9fc..8ee18ed 100644
--- a/sw/source/ui/inc/srcview.hxx
+++ b/sw/source/ui/inc/srcview.hxx
@@ -49,7 +49,7 @@ class SwSrcView: public SfxViewShell
rtl_TextEncodingeLoadEncoding;
voidInit();
-// fuer Readonly-Umschaltung
+// for read-only switching
virtual void Notify( SfxBroadcaster rBC, const SfxHint
rHint );
diff --git a/sw/source/ui/inc/swcont.hxx b/sw/source/ui/inc/swcont.hxx
index 0688dd6..58111b5 100644
--- a/sw/source/ui/inc/swcont.hxx
+++ b/sw/source/ui/inc/swcont.hxx
@@ -33,7 +33,7 @@
class SwContentType;
-//Reihenfolge und Anzahl mit ResIds abgleichen!!
+// synchronize order and number with ResIds!!
#define CONTENT_TYPE_OUTLINE 0
#define CONTENT_TYPE_TABLE 1
#define CONTENT_TYPE_FRAME 2
@@ -49,17 +49,17 @@ class SwContentType;
#define CONTENT_TYPE_MAX CONTENT_TYPE_DRAWOBJECT +1
-// Typen fuer das Globaldokument
+// types for global document
#define GLOBAL_CONTENT_REGION 100
#define GLOBAL_CONTENT_INDEX101
#define GLOBAL_CONTENT_TEXT102
#define GLOBAL_CONTENT_MAX 3
-// Strings fuer Kontextmenue
+// strings for context menus
#define CONTEXT_COUNT 12
#define GLOBAL_CONTEXT_COUNT 14
-// Modi fuer Drag 'n Drop
+// modes for Drag 'n Drop
#define REGION_MODE_NONE 0
#define REGION_MODE_LINK1
#define REGION_MODE_EMBEDDED2
@@ -94,12 +94,12 @@ public:
const String GetName() const {return
sContentName;}
intoperator==(const
SwContent /*rCont*/) const
{
-//gleich sind sie nie, sonst fallen sie
aus dem Array
+// they're never equal, otherwise they'd
fall out of the array
return sal_False;
}
intoperator(const
SwContent rCont) const
{
-//zuerst nach Position dann nach Name
sortieren
+// at first sort by position and then by
name
return nYPosition != rCont.nYPosition ?
nYPosition rCont.nYPosition :
sContentName rCont.sContentName;;
diff --git a/sw/source/ui/inc/swdtflvr.hxx b/sw/source/ui/inc/swdtflvr.hxx
index 4e37f63..845a7ef 100644
--- a/sw/source/ui/inc/swdtflvr.hxx
+++ b/sw/source/ui/inc/swdtflvr.hxx
@@ -58,7 +58,7 @@ namespace nsTransferBufferType
const sal_uInt16 TRNSFR_DDELINK= 0x0010;
const sal_uInt16 TRNSFR_OLE= 0x0020;
const sal_uInt16 TRNSFR_INETFLD= 0x0040;
-const sal_uInt16 TRNSFR_DRAWING= 0x0081;
//Drawing ist auch intern!
+const sal_uInt16 TRNSFR_DRAWING= 0x0081; //
drawing is internal too!
}
#define DATA_FLAVOR::com::sun::star::datatransfer::DataFlavor
@@ -77,7 +77,7 @@ class SwTransferable : public TransferableHelper
const ViewShell *pCreatorView;
SwDocFac *pClpDocFac;
Graphic*pClpGraphic, *pClpBitmap, *pOrigGrf;
-INetBookmark *pBkmk; // URL und Beschreibung!
+INetBookmark *pBkmk; // URL and description!
ImageMap *pImageMap;
INetImage *pTargetURL;
diff --git a/sw/source/ui/inc/swlbox.hxx b/sw/source/ui/inc/swlbox.hxx
index 265b5ad..6aab6cc 100644
--- a/sw/source/ui/inc/swlbox.hxx
+++ b/sw/source/ui/inc/swlbox.hxx
@@ -41,7 +41,7 @@ class Window;
SV_DECL_PTRARR_DEL(SwEntryLst, SwBoxEntry*, 10, 10
Re: [Libreoffice] [PATCH 4/4] Translate german code comments
Nice patches Martin! :-) Next time you could attach the files, instead of put them in the mail body. So, the developers just download and apply your changes. ;-) Regards, Júlio. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 4/4] Translate german code comments
Am 21.04.2011 22:13, schrieb Júlio Hoffimann: Nice patches Martin! :-) Next time you could attach the files, instead of put them in the mail body. So, the developers just download and apply your changes. ;-) Regards, Júlio. Hi Julio, As I mentioned, these patches are already applied and pushed to master. Not need to do anything. I just posted them to the list for visibility reasons. I used git send-email according to the wiki, see http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline#Send_patches_as_attachments_or_use_git_send-email. I'd be happy for comments, thanks, martin -- /```\ |Martin Kepplinger | | | | diaspora handlemartinkepplin...@joindiaspora.com | | | | E-Mail IMmartinkepplin...@eml.cc| | | | 7346 FE02 27C3 3958 813A C351 C100 D7B5 7F2A 1E26 | \,,,/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 4/4] Translate german code comments
Hi Martin, i don't knew about that Git command. :-) You tried to say that the changes you made are in your local repo, right? If not, there are no reasons to send again for the mailing list. These are big files to review, the probability of anyone read is too small, just do your job, it's great. :-) Best regards, Júlio. 2011/4/21 Martin Kepplinger martinkepplin...@eml.cc Am 21.04.2011 22:13, schrieb Júlio Hoffimann: Nice patches Martin! :-) Next time you could attach the files, instead of put them in the mail body. So, the developers just download and apply your changes. ;-) Regards, Júlio. Hi Julio, As I mentioned, these patches are already applied and pushed to master. Not need to do anything. I just posted them to the list for visibility reasons. I used git send-email according to the wiki, see http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline#Send_patches_as_attachments_or_use_git_send-email . I'd be happy for comments, thanks, martin -- /```\ |Martin Kepplinger | | | | diaspora handlemartinkepplin...@joindiaspora.com | | | | E-Mail IMmartinkepplin...@eml.cc| | | | 7346 FE02 27C3 3958 813A C351 C100 D7B5 7F2A 1E26 | \,,,/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 4/4] Translate german code comments
Am 21.04.2011 23:09, schrieb Júlio Hoffimann: Hi Martin, i don't knew about that Git command. :-) You tried to say that the changes you made are in your local repo, right? If not, there are no reasons to send again for the mailing list. sorry, I don't really understand what you are saying. As I said, my changes are not only in my local repo but also already pushed to the master repo. These are big files to review, the probability of anyone read is too small, just do your job, it's great. :-) Best regards, Júlio. I'm glad to get advice but so far I thought it makes sense to post translations here as well in order to discuss possible mistakes and improve the quality. _If_ what you are suggesting here is what more developers also say, I won't post my translations anymore. Though I think it doesn't hurt to do so. thanks, martin 2011/4/21 Martin Kepplinger martinkepplin...@eml.cc Am 21.04.2011 22:13, schrieb Júlio Hoffimann: Nice patches Martin! :-) Next time you could attach the files, instead of put them in the mail body. So, the developers just download and apply your changes. ;-) Regards, Júlio. Hi Julio, As I mentioned, these patches are already applied and pushed to master. Not need to do anything. I just posted them to the list for visibility reasons. I used git send-email according to the wiki, see http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline#Send_patches_as_attachments_or_use_git_send-email. I'd be happy for comments, thanks, martin -- /```\ |Martin Kepplinger | | | | diaspora handlemartinkepplin...@joindiaspora.com mailto:martinkepplin...@joindiaspora.com | | | | E-Mail IMmartinkepplin...@eml.cc| | | | 7346 FE02 27C3 3958 813A C351 C100 D7B5 7F2A 1E26 | \,,,/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH 1/4] Translate german code comments
This translates all german code comments in writer/sw/source/ui/fmtui to
english.
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
---
sw/source/ui/fmtui/tmpdlg.cxx | 34 +-
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/sw/source/ui/fmtui/tmpdlg.cxx b/sw/source/ui/fmtui/tmpdlg.cxx
index 9edb36d..e88c26b 100644
--- a/sw/source/ui/fmtui/tmpdlg.cxx
+++ b/sw/source/ui/fmtui/tmpdlg.cxx
@@ -57,12 +57,12 @@
#include viewopt.hxx
#include pgfnote.hxx
#include pggrid.hxx
-#include tmpdlg.hxx // der Dialog
-#include column.hxx // Spalten
-#include drpcps.hxx // Initialen
-#include frmpage.hxx // Rahmen
-#include wrap.hxx// Rahmen
-#include frmmgr.hxx // Rahmen
+#include tmpdlg.hxx // the dialog
+#include column.hxx // columns
+#include drpcps.hxx // initials
+#include frmpage.hxx // frames
+#include wrap.hxx// frames
+#include frmmgr.hxx // frames
#include ccoll.hxx // CondColl
#include swuiccoll.hxx
#include docstyle.hxx//
@@ -91,7 +91,7 @@
extern SW_DLLPUBLIC SwWrtShell* GetActiveWrtShell();
/*
-Beschreibung: Der Traeger des Dialoges
+Description: the dialog's carrier
*/
SwTemplateDlg::SwTemplateDlg(Window* pParent,
@@ -114,10 +114,10 @@ SwTemplateDlg::SwTemplateDlg(Window*
pParent,
nHtmlMode = ::GetHtmlMode(pWrtShell-GetView().GetDocShell());
SfxAbstractDialogFactory* pFact = SfxAbstractDialogFactory::Create();
OSL_ENSURE(pFact, Dialogdiet fail!);
-// TabPages zusammenfieseln
+// tinker TabPages together
switch( nRegion )
{
-// Zeichenvorlagen
+// character templates
case SFX_STYLE_FAMILY_CHAR:
{
OSL_ENSURE(pFact-GetTabPageCreatorFunc( RID_SVXPAGE_CHAR_NAME ),
GetTabPageCreatorFunc fail!);
@@ -145,7 +145,7 @@ SwTemplateDlg::SwTemplateDlg(Window*
pParent,
RemoveTabPage(TP_CHAR_TWOLN);
}
break;
-// Absatzvorlagen
+// paragraph templates
case SFX_STYLE_FAMILY_PARA:
{
OSL_ENSURE(pFact-GetTabPageCreatorFunc(RID_SVXPAGE_STD_PARAGRAPH),
GetTabPageCreatorFunc fail!);
@@ -230,7 +230,7 @@ SwTemplateDlg::SwTemplateDlg(Window*
pParent,
}
}
break;
-// Rahmenvorlagen
+// frame templates
case SFX_STYLE_FAMILY_FRAME:
{
AddTabPage(TP_FRM_STD, SwFrmPage::Create,
@@ -253,7 +253,7 @@ SwTemplateDlg::SwTemplateDlg(Window*
pParent,
break;
}
-// Seitenvorlagen
+// page templates
case SFX_STYLE_FAMILY_PAGE:
{
OSL_ENSURE(pFact-GetTabPageCreatorFunc( RID_SVXPAGE_BACKGROUND ),
GetTabPageCreatorFunc fail!);
@@ -274,7 +274,7 @@ SwTemplateDlg::SwTemplateDlg(Window*
pParent,
pFact-GetTabPageCreatorFunc(
RID_SVXPAGE_PAGE ),
pFact-GetTabPageRangesFunc(
RID_SVXPAGE_PAGE ),
sal_False,
-1 ); // nach der Verwalten-Page
+1 ); // after the manage-page
if(!pActShell || 0 ==
::GetHtmlMode(pWrtShell-GetView().GetDocShell()))
{
OSL_ENSURE(pFact-GetTabPageCreatorFunc( RID_SVXPAGE_BORDER ),
GetTabPageCreatorFunc fail!);
@@ -298,7 +298,7 @@ SwTemplateDlg::SwTemplateDlg(Window*
pParent,
}
break;
-// Numerierungsvorlagen
+// numbering templates
case SFX_STYLE_FAMILY_PSEUDO:
{
AddTabPage( RID_SVXPAGE_PICK_SINGLE_NUM );
@@ -355,7 +355,7 @@ short SwTemplateDlg::Ok()
}
else
//JP 09.01.98 Bug #46446#:
-// das ist der Ok - Handler also muss auf OK defaultet werden!
+// that's the Ok-Handler, so OK has to be default!
nRet = RET_OK;
return nRet;
}
@@ -370,7 +370,7 @@ const SfxItemSet* SwTemplateDlg::GetRefreshedSet()
void SwTemplateDlg::PageCreated( sal_uInt16 nId, SfxTabPage rPage )
{
-//Namen der Vorlagen und Metric setzen
+// set template's and metric's names
String sNumCharFmt, sBulletCharFmt;
SwStyleNameMapper::FillUIName( RES_POOLCHR_NUM_LEVEL, sNumCharFmt);
SwStyleNameMapper::FillUIName( RES_POOLCHR_BUL_LEVEL, sBulletCharFmt);
@@ -551,7 +551,7 @@ void SwTemplateDlg::PageCreated( sal_uInt16 nId, SfxTabPage
rPage )
aSet.Put (SfxStringItem(SID_NUM_CHAR_FMT
[Libreoffice] [PATCH 3/4] Translate german code comments
Translate more german code comments to english. This is contributed under the
terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple license.
---
sw/source/ui/frmdlg/frmdlg.cxx |6 +-
sw/source/ui/frmdlg/frmmgr.cxx | 33
sw/source/ui/frmdlg/frmpage.cxx | 182 +++
3 files changed, 109 insertions(+), 112 deletions(-)
diff --git a/sw/source/ui/frmdlg/frmdlg.cxx b/sw/source/ui/frmdlg/frmdlg.cxx
index 230dcf9..a9fccc6 100644
--- a/sw/source/ui/frmdlg/frmdlg.cxx
+++ b/sw/source/ui/frmdlg/frmdlg.cxx
@@ -55,7 +55,7 @@
#include svx/svxdlg.hxx
/*
-Beschreibung: Der Traeger des Dialoges
+Description: the dialog's carrier
*/
SwFrmDlg::SwFrmDlg( SfxViewFrame* pViewFrame,
Window*pParent,
@@ -77,7 +77,7 @@ SwFrmDlg::SwFrmDlg( SfxViewFrame* pViewFrame,
sal_uInt16 nHtmlMode = ::GetHtmlMode(m_pWrtShell-GetView().GetDocShell());
m_bHTMLMode = static_cast sal_Bool (nHtmlMode HTMLMODE_ON);
-// BspFont fuer beide Bsp-TabPages
+// example font for both example TabPages
//
if(pStr)
{
@@ -114,7 +114,7 @@ SwFrmDlg::SwFrmDlg( SfxViewFrame* pViewFrame,
if(0 == (nHtmlMode HTMLMODE_SOME_ABS_POS))
RemoveTabPage(TP_BORDER);
RemoveTabPage(TP_COLUMN);
-// kein break
+// no break
case DLG_FRM_OLE:
RemoveTabPage(TP_FRM_URL);
RemoveTabPage(TP_MACRO_ASSIGN);
diff --git a/sw/source/ui/frmdlg/frmmgr.cxx b/sw/source/ui/frmdlg/frmmgr.cxx
index d2c3a41..52db350 100644
--- a/sw/source/ui/frmdlg/frmmgr.cxx
+++ b/sw/source/ui/frmdlg/frmmgr.cxx
@@ -63,7 +63,7 @@ static sal_uInt16 aFrmMgrRange[] = {
0};
/*
- Beschreibung: Rahmen-Attribute ueber Shell ermitteln
+ Description: determine frame attributes via Shell
*/
SwFlyFrmAttrMgr::SwFlyFrmAttrMgr( sal_Bool bNew, SwWrtShell* pSh, sal_uInt8
nType ) :
aSet( (SwAttrPool)pSh-GetAttrPool(), aFrmMgrRange ),
@@ -75,7 +75,7 @@ SwFlyFrmAttrMgr::SwFlyFrmAttrMgr( sal_Bool bNew, SwWrtShell*
pSh, sal_uInt8 nTyp
{
if ( bNewFrm )
{
-// Defaults einstellen:
+// set Defaults:
sal_uInt16 nId = 0;
switch ( nType )
{
@@ -113,7 +113,7 @@ SwFlyFrmAttrMgr::SwFlyFrmAttrMgr( sal_Bool bNew,
SwWrtShell* pSh, const SfxItemS
}
/*
- Beschreibung: Initialisieren
+ Description: Initialise
*/
void SwFlyFrmAttrMgr::UpdateAttrMgr()
{
@@ -139,7 +139,7 @@ void SwFlyFrmAttrMgr::_UpdateFlyFrm()
}
/*
-Beschreibung: Bestehenden Fly-Frame aendern
+Description: change existing Fly-Frame
*/
void SwFlyFrmAttrMgr::UpdateFlyFrm()
{
@@ -172,7 +172,7 @@ void SwFlyFrmAttrMgr::UpdateFlyFrm()
}
/*
- Beschreibung: Rahmen einfuegen
+ Description: insert frame
*/
sal_Bool SwFlyFrmAttrMgr::InsertFlyFrm()
{
@@ -180,7 +180,7 @@ sal_Bool SwFlyFrmAttrMgr::InsertFlyFrm()
sal_Bool bRet = 0 != pOwnSh-NewFlyFrm( aSet );
-// richtigen Mode an der Shell einschalten, Rahmen wurde aut. selektiert.
+// turn on the right mode at the shell, frame got selected automatically.
if ( bRet )
{
_UpdateFlyFrm();
@@ -192,10 +192,9 @@ sal_Bool SwFlyFrmAttrMgr::InsertFlyFrm()
}
/*
- Beschreibung: Rahmen des Typs eAnchorType einfuegen. Position und
-Groesse werden explizit angegeben.
-Nicht erlaubte Werte des Aufzaehlungstypes werden
-korrigiert.
+ Description: insert frames of type eAnchorType. Position and size are
+being set explicitely.
+Not-allowed values of the enumeration type get corrected.
*/
void SwFlyFrmAttrMgr::InsertFlyFrm(RndStdIds eAnchorType,
const Point rPos,
@@ -219,7 +218,7 @@ void SwFlyFrmAttrMgr::InsertFlyFrm(RndStdIds
eAnchorType,
}
/*
- Beschreibung: Anker setzen
+ Description: set anchor
[Libreoffice] [PATCH 4/4] Translate german code comments
Translate the remaining german code comments in writer/sw/source/ui/frmdlg to
english.
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
---
sw/source/ui/frmdlg/frmui.src| 10 +-
sw/source/ui/frmdlg/uiborder.cxx |2 +-
sw/source/ui/frmdlg/wrap.cxx | 24
3 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/sw/source/ui/frmdlg/frmui.src b/sw/source/ui/frmdlg/frmui.src
index b420a65..230d170 100644
--- a/sw/source/ui/frmdlg/frmui.src
+++ b/sw/source/ui/frmdlg/frmui.src
@@ -27,7 +27,7 @@
#include frmui.hrc
/*---
-Beschreibung: V-Align
+Description: V-Align
---*/
String STR_TOP
{
@@ -46,7 +46,7 @@ String STR_CENTER_HORI
Text [ en-US ] = ~Center ;
};
/*---
-Beschreibung: V-Rel
+Description: V-Rel
---*/
String STR_TOPPRT
{
@@ -54,13 +54,13 @@ String STR_TOPPRT
};
/*---
-Beschreibung: H-Rel
+Description: H-Rel
---*/
/*---
-Beschreibung: V-Rel Zeichenausrichtungen
+Description: V-Rel character alignment
---*/
/*---
-Beschreibung: Zeichenausrichtungen fuer frmsh.cxx - Kontextmenue
+Description: character alignment for frmsh.cxx - context menu
---*/
String STR_TOP_BASE
{
diff --git a/sw/source/ui/frmdlg/uiborder.cxx b/sw/source/ui/frmdlg/uiborder.cxx
index 9a60449..78e02d5 100644
--- a/sw/source/ui/frmdlg/uiborder.cxx
+++ b/sw/source/ui/frmdlg/uiborder.cxx
@@ -55,7 +55,7 @@ SwBorderDlg::SwBorderDlg(Window* pParent, SfxItemSet rSet,
sal_uInt16 nType) :
{
SetText(SW_RESSTR(STR_FRMUI_BORDER));
-// TabPage erzeugen
+// create TabPage
SfxAbstractDialogFactory* pFact = SfxAbstractDialogFactory::Create();
OSL_ENSURE(pFact, Dialogdiet fail!);
::CreateTabPage fnCreatePage = pFact-GetTabPageCreatorFunc(
RID_SVXPAGE_BORDER );
diff --git a/sw/source/ui/frmdlg/wrap.cxx b/sw/source/ui/frmdlg/wrap.cxx
index 8980b27..213cc95 100644
--- a/sw/source/ui/frmdlg/wrap.cxx
+++ b/sw/source/ui/frmdlg/wrap.cxx
@@ -73,7 +73,7 @@ SwWrapDlg::SwWrapDlg(Window* pParent, SfxItemSet rSet,
SwWrtShell* pSh, sal_Boo
pWrtShell(pSh)
{
-// TabPage erzeugen
+// create TabPage
SwWrapTabPage* pNewPage = (SwWrapTabPage*) SwWrapTabPage::Create(this,
rSet);
pNewPage-SetFormatUsed(sal_False, bDrawMode);
pNewPage-SetShell(pWrtShell);
@@ -178,7 +178,7 @@ SfxTabPage* SwWrapTabPage::Create(Window *pParent, const
SfxItemSet rSet)
void SwWrapTabPage::Reset(const SfxItemSet rSet)
{
-//Contour fuer Draw, Grafik und OLE (Einfuegen/Grafik/Eigenschaften fehlt
noch!)
+//Contour for Draw, Graphic and OLE (Insert/Graphic/Properties still
missing!)
if( bDrawMode )
{
aWrapOutlineCB.Show();
@@ -284,9 +284,9 @@ void SwWrapTabPage::Reset(const SfxItemSet rSet)
{
pBtn-Check();
WrapTypeHdl(pBtn);
-// Hier wird fuer Zeichenobjekte, die im Moment auf Durchlauf stehen,
-// schon mal der Default Kontur an vorbereitet, falls man spaeter auf
-// irgendeinen Umlauf umschaltet.
+// For character objects that currently are in passage, the default
+// contour on is prepared here, in case we switch to any other
+// passage later.
if (bDrawMode !aWrapOutlineCB.IsEnabled())
aWrapOutlineCB.Check();
}
@@ -295,7 +295,7 @@ void SwWrapTabPage::Reset(const SfxItemSet rSet)
const SvxULSpaceItem rUL = (const SvxULSpaceItem)rSet.Get(RES_UL_SPACE);
const SvxLRSpaceItem rLR = (const SvxLRSpaceItem)rSet.Get(RES_LR_SPACE);
-// Abstand zum Text
+// gap to text
aLeftMarginED.SetValue(aLeftMarginED.Normalize(rLR.GetLeft()), FUNIT_TWIP);
aRightMarginED.SetValue(aRightMarginED.Normalize(rLR.GetRight()),
FUNIT_TWIP);
aTopMarginED.SetValue(aTopMarginED.Normalize(rUL.GetUpper()), FUNIT_TWIP);
@@ -306,7 +306,7 @@ void SwWrapTabPage::Reset(const SfxItemSet rSet)
}
/*
-Beschreibung: Attribute in den Set stopfen bei OK
+Description: stuff attributes into the set when OK
*/
sal_Bool SwWrapTabPage::FillItemSet(SfxItemSet rSet)
{
@@ -411,7 +411,7 @@ sal_Bool SwWrapTabPage::FillItemSet
Re: [Libreoffice] [PATCH 1/4] Translate german code comments
Hi Martin, Martin Kepplinger wrote (31-03-11 16:03) -// Zeichenvorlagen +// character templates For Characters, Paragraphs, Pages, Frames, Lists ... I would expect the translation to be 'styles' Or is it explicitly 'templates' here, because it refers to all the predefined styles? ( When talking about a whole document, Vorlage is of course translated as templates'. ) Regards, Cor -- - http://nl.libreoffice.org - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCHSET] Translate german code-comments
This translates the remaining code-comments of the writer/sw/source/ui/app directory from german to english. The approach here is to do this once and for all. I didn't leave any german comments I could find. I did my best to preserve all the information. But I _don't_ have semantical insight or experience with the writer-code. There *were* (not many) comments where I was not 100% certain of what they actually said. I just translated them anyways. So, although it might not be a too critical issue when some word ended up chosen wrongly here, I call for _review_ (if possible)! I hope this helps the writer-code to get picked up by even more people (what would hopefully make up for any possible loss of information) and I move on to the next directory in writer/sw/source/ui. thanks! Martin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
