Re: Gerrit "new change" emails started to lack URL of change near the top

[Stephan Bergmann]

On 20/01/2020 12:31, Guilhem Moulin wrote:

On Mon, 20 Jan 2020 at 10:50:34 +0100, Stephan Bergmann wrote:

But current 

still contains
[…]
(Oh, now that I spot the "patch from" vs. "patch by" difference, it is
obvious that those mails are not using the templates specified by the
gerrit-etc repo?)


Velocity mail templates are no longer used:
https://www.gerritcodereview.com/2.16.html#support-for-velocity-templates-removed
Had to manually convert them to Soy templates during the upgrade path,
and I guess I missed this line.  Should be fixed now; IIRC there is no
need to reload/restart gerrit so the edit should be enough.


Yes, seen that working now, thanks.


And indeed gerrit-etc is no longer used either.  Like for other
programs, gerrit's configuration files are now directly managed by salt
(our config management tool).


As discussed on IRC, would be nice to decommission that git repo then, 
to avoid confusion.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gerrit "new change" emails started to lack URL of change near the top

[Guilhem Moulin]

[Please, use hostmaster@tdf.]

On Mon, 20 Jan 2020 at 10:50:34 +0100, Stephan Bergmann wrote:
> But current 
> 
> still contains
> […] 
> (Oh, now that I spot the "patch from" vs. "patch by" difference, it is
> obvious that those mails are not using the templates specified by the
> gerrit-etc repo?)

Velocity mail templates are no longer used:
https://www.gerritcodereview.com/2.16.html#support-for-velocity-templates-removed
Had to manually convert them to Soy templates during the upgrade path,
and I guess I missed this line.  Should be fixed now; IIRC there is no
need to reload/restart gerrit so the edit should be enough.

And indeed gerrit-etc is no longer used either.  Like for other
programs, gerrit's configuration files are now directly managed by salt
(our config management tool).

-- 
Guilhem.


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Gerrit "new change" emails started to lack URL of change near the top

[Stephan Bergmann]

Those emails Gerrit sends out about new changes, starting like


Hi,

I would like you to review the following patch from Stephan Bergmann:

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/86993/1

external/pdfium: C++20 comparison operator fix


no longer include the URL of the change.  (It only appears in the footer,


To view, visit https://gerrit.libreoffice.org/c/core/+/86993
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.libreoffice.org/settings


if you scroll all the way down there.)

But current 
 
still contains



Hi,

I would like you to review the following patch by $patchSetInfo.author.name:

$email.changeUrl

#if($email.sshHost)
To pull it, you can do:

git pull ssh://$email.sshHost/$projectName $patchSet.refName

#end
(Oh, now that I spot the "patch from" vs. "patch by" difference, it is 
obvious that those mails are not using the templates specified by the 
gerrit-etc repo?)


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice