Re: Improve WriteCustomGeometry in oox export; review of patch
Hi Regina, On Thu, Mar 24, 2022 at 07:33:24PM +0100, Regina Henschel wrote: > The commit message is quite detailed. If something is still unclear, please > send me a mail. Not only that, but the various test files you added in the tests also helped to understand the problem you solve. Thanks for that. > BTW, Jenkins fails for a reason I don't know. But I want to first > incorporate your suggestions before I start a next try with Jenkins. It was just a one-off failure, it went away after a "resume". Regards, Miklos
Improve WriteCustomGeometry in oox export; review of patch
Hi Miklos, hi all, the patch in https://gerrit.libreoffice.org/c/core/+/131837 is now ready for review. It is a change in the way a custGeom element is generated. I have dropped the export via PolyPolygon. Instead our path commands are directly mapped to oox path commands. That is a larger change, so it would be good, if you find time to review it. The commit message is quite detailed. If something is still unclear, please send me a mail. BTW, Jenkins fails for a reason I don't know. But I want to first incorporate your suggestions before I start a next try with Jenkins. Kind regards, Regina
