Re: Is it ok to remove visual navigator comments?
On 06/06/2012 05:00 PM, Michael Stahl wrote: it is more useful if it separates a chunk of related stuff from another chunk of related stuff, e.g. if there are multiple classes implemented in one file it can be nice to have a separator between the methods of different classes, but this should usually result in a number of separators in a file that can be counted on one hand. The only thing that never looks right is a rule. There is not in existence a page with a rule on it that cannot be instantly and obviously improved by taking the rule out. — George Bernard Shaw, in The Dolphin (1940) [according to Knuth] :) Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Is it ok to remove visual navigator comments?
On 07/06/12 11:46, Stephan Bergmann wrote: On 06/06/2012 05:00 PM, Michael Stahl wrote: it is more useful if it separates a chunk of related stuff from another chunk of related stuff, e.g. if there are multiple classes implemented in one file it can be nice to have a separator between the methods of different classes, but this should usually result in a number of separators in a file that can be counted on one hand. The only thing that never looks right is a rule. There is not in existence a page with a rule on it that cannot be instantly and obviously improved by taking the rule out. — George Bernard Shaw, in The Dolphin (1940) [according to Knuth] :) well obviously in a printed work you'd have a page break in this case, so i fully agree with that. however, people rarely print out our source code, so the various files in sw/ that include literal ASCII form feed characters are somewhat outdated; on a non-paginated display medium a rule may make sense :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Is it ok to remove visual navigator comments?
Hi all, Is it ok to remove visual navigator comments (starting and ending with ** and only containing the function's name)? E.g. what I did in fe436d. In my experience this greatly reduces visual noise to the cost of visual separation. Or am I missing something? Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Is it ok to remove visual navigator comments?
On 06/06/12 16:46, Philipp Weissenbacher wrote: Hi all, Is it ok to remove visual navigator comments (starting and ending with ** and only containing the function's name)? E.g. what I did in fe436d. In my experience this greatly reduces visual noise to the cost of visual separation. Or am I missing something? yes if they only contain the name of the method, or empty lines that start with Description: :) then they're just useless clutter. it is more useful if it separates a chunk of related stuff from another chunk of related stuff, e.g. if there are multiple classes implemented in one file it can be nice to have a separator between the methods of different classes, but this should usually result in a number of separators in a file that can be counted on one hand. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Is it ok to remove visual navigator comments?
Hi Philipp, On Wed, 2012-06-06 at 16:46 +0200, Philipp Weissenbacher wrote: Is it ok to remove visual navigator comments (starting and ending with ** and only containing the function's name)? Yes :-) In my experience this greatly reduces visual noise to the cost of visual separation. Or am I missing something? It's a nice cleanup; I'd prefer if you could hold-fire temporarily at least until the re-basing on the ALv2 code-base is done - since there is a degree of merging / auditing necessary there. As we go, I'll try to build a list of files which are great to do further aggressive cleanups in :-) will let you know when that's in-place. Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
