Re: Question about vcl/source/window/builder.cxx

2012-12-17 Thread Caolán McNamara 
On Sat, 2012-12-15 at 06:19 -0800, julien2412 wrote:
 Should it be  (sValue[0] == 'e' || sValue[0] == 'E')

Yeah, that's what I had in mind. Fixed now, thanks for that :-)

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Question about vcl/source/window/builder.cxx

2012-12-15 Thread julien2412 
Hello,

Keeping on with cppcheck, I found this on vcl/source/window/builder.cxx
   1892 else if (sKey == pack-type)
   1893 {
   1894 VclPackType ePackType = (sValue[0] == 'e' ||
sValue[0] == 'e') ? VCL_PACK_END : VCL_PACK_START;
   1895 pCurrent-set_pack_type(ePackType);
   1896 }

Should it be  (sValue[0] == 'e' || sValue[0] == 'E'), just sValue[0] == 'e'
or something else?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Question-about-vcl-source-window-builder-cxx-tp4024520.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice