Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks 3.27 Change Sheet copy process

2010-12-14 Thread Joost Eekhoorn
Hi Kohei,

Thanks a lot for completing.

Can you mark this Easy Hack 3.27 as completed on the Development/Easy
Hacks page? Or explain to me how to do that?

I am now looking at

   - 3.28 Leftover data after an Undo
operationhttp://wiki.documentfoundation.org/Easy_Hacks#Leftover_data_after_an_Undo_operation

Joost

2010/12/14 Kohei Yoshida kyosh...@novell.com

 Hi Andy,

 On Mon, 2010-12-13 at 21:06 -0800, Andy Brown wrote:

  I would like to thank you guys.  This will be great. :)  Any idea when
  we will see it in action?

 Well, since this just landed on master, I would say it'll be in the next
 major version after 3.3maybe 3.4?

 Just a guess.

 Kohei

 --
 Kohei Yoshida, LibreOffice hacker, Calc
 kyosh...@novell.com


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks 3.27 Change Sheet copy process

2010-12-13 Thread Kohei Yoshida
Hi Joost,

On Sun, 2010-12-12 at 12:19 +0100, Joost Eekhoorn wrote:

 Hereby additional patch with:
 
 * Check on pName is NULL.
 
 * Showing original sheet name in input box, when Rename option is
 checked.
 
 Not  implemented: OrgName_#.

Ok.  I've finished my review  followup work to give it a little more
polish, and finally pushed it to master.  What I did was polish up the
dialog a bit, and properly supported undo and redo.  I now consider this
functionality to be in pretty good shape.

Thanks for the patch, Joost.  I look forward to receiving even more
patches from you in the future. :-)

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks 3.27 Change Sheet copy process

2010-12-13 Thread Andy Brown

On Mon Dec 13 2010 20:53:22 GMT-0800 (PST)  Kohei Yoshida wrote:

Hi Joost,

On Sun, 2010-12-12 at 12:19 +0100, Joost Eekhoorn wrote:


Hereby additional patch with:

* Check on pName is NULL.

* Showing original sheet name in input box, when Rename option is
checked.

Not  implemented: OrgName_#.


Ok.  I've finished my review  followup work to give it a little more
polish, and finally pushed it to master.  What I did was polish up the
dialog a bit, and properly supported undo and redo.  I now consider this
functionality to be in pretty good shape.

Thanks for the patch, Joost.  I look forward to receiving even more
patches from you in the future. :-)

Kohei



I would like to thank you guys.  This will be great. :)  Any idea when 
we will see it in action?


Andy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks 3.27 Change Sheet copy process

2010-12-13 Thread Kohei Yoshida
On Mon, 2010-12-13 at 23:53 -0500, Kohei Yoshida wrote:
 Hi Joost,
 
 On Sun, 2010-12-12 at 12:19 +0100, Joost Eekhoorn wrote:
 
  Hereby additional patch with:
  
  * Check on pName is NULL.
  
  * Showing original sheet name in input box, when Rename option is
  checked.
  
  Not  implemented: OrgName_#.
 
 Ok.  I've finished my review  followup work to give it a little more
 polish, and finally pushed it to master.

Oh yeah, please also move that task to the 'Completed' page.

Thanks!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice